)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"0827fa1108af00b544a0b6971a585e0d33f83b9f","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[Sahara] More debug logging"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The log entries added will allow a user to track if the benchmartk is"},{"line_number":10,"context_line":"waiting for something or it has stuck."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"_is_cluster_active method is not required anymore with a new wait"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":14,"id":"9a0c5dc1_34260bcf","line":9,"updated":"2015-05-13 06:52:12.000000000","message":"* typo - benchmartk","commit_id":"3ce7df84a2cf86f93c3a968c1a8b90e60fab8a78"}],"rally/benchmark/scenarios/sahara/utils.py":[{"author":{"_account_id":7369,"name":"Sergey Skripnick","email":"sskripnick@mirantis.com","username":"redixin"},"change_message_id":"eccf38ba7a96fdfe389f63b48429c6e29e455c05","unresolved":false,"context_lines":[{"line_number":329,"context_line":""},{"line_number":330,"context_line":"    def _is_cluster_active(self, cluster):"},{"line_number":331,"context_line":"        cluster_status \u003d cluster.status.lower()"},{"line_number":332,"context_line":"        LOG.debug(\"Waiting for cluster %s to become active. Status: %s\" %"},{"line_number":333,"context_line":"                  (cluster.name, cluster_status))"},{"line_number":334,"context_line":""},{"line_number":335,"context_line":"        if cluster_status \u003d\u003d \"error\":"}],"source_content_type":"text/x-python","patch_set":2,"id":"baa041b7_e373f3e5","line":332,"updated":"2015-04-06 10:13:11.000000000","message":"This method is not waiting, this method is checking. The same about other methods.","commit_id":"4f139c4f1e398668fe08ed36efcd1246181ecccd"},{"author":{"_account_id":8507,"name":"Mikhail Dubov","email":"mdubov@mirantis.com","username":"msdubov"},"change_message_id":"e4c5adb4c42be9c427ba70adabcf33097a16a6e2","unresolved":false,"context_lines":[{"line_number":329,"context_line":""},{"line_number":330,"context_line":"    def _is_cluster_active(self, cluster):"},{"line_number":331,"context_line":"        cluster_status \u003d cluster.status.lower()"},{"line_number":332,"context_line":"        LOG.debug(\"Waiting for cluster %s to become active. Status: %s\" %"},{"line_number":333,"context_line":"                  (cluster.name, cluster_status))"},{"line_number":334,"context_line":""},{"line_number":335,"context_line":"        if cluster_status \u003d\u003d \"error\":"}],"source_content_type":"text/x-python","patch_set":2,"id":"9aa53dc9_bf7b377b","line":332,"in_reply_to":"baa041b7_617d9be6","updated":"2015-04-06 11:45:18.000000000","message":"Agree with Sergei. Can you please also add quotes around cluster name/status here and below? Like\n\n    ... for cluster `%s` to become active...","commit_id":"4f139c4f1e398668fe08ed36efcd1246181ecccd"},{"author":{"_account_id":7369,"name":"Sergey Skripnick","email":"sskripnick@mirantis.com","username":"redixin"},"change_message_id":"17648427b8ab3e0564536c7943933a52d25c6ab0","unresolved":false,"context_lines":[{"line_number":329,"context_line":""},{"line_number":330,"context_line":"    def _is_cluster_active(self, cluster):"},{"line_number":331,"context_line":"        cluster_status \u003d cluster.status.lower()"},{"line_number":332,"context_line":"        LOG.debug(\"Waiting for cluster %s to become active. Status: %s\" %"},{"line_number":333,"context_line":"                  (cluster.name, cluster_status))"},{"line_number":334,"context_line":""},{"line_number":335,"context_line":"        if cluster_status \u003d\u003d \"error\":"}],"source_content_type":"text/x-python","patch_set":2,"id":"baa041b7_617d9be6","line":332,"in_reply_to":"baa041b7_e16e4b95","updated":"2015-04-06 11:30:57.000000000","message":"It is good place, but this message will be appeared in log several times in a row:\n\n DEBUG: Deleting cluster\n DEBUG: Waiting for cluster to be deleted\n DEBUG: Waiting for cluster to be deleted\n DEBUG: Waiting for cluster to be deleted\n\nThis may be confusing.\n\nBut this would be not:\n\n DEBUG: Deleting cluster\n DEBUG: Checking for cluster to be deleted\n DEBUG: Checking for cluster to be deleted\n DEBUG: Checking for cluster to be deleted","commit_id":"4f139c4f1e398668fe08ed36efcd1246181ecccd"},{"author":{"_account_id":7132,"name":"Nikita Konovalov","email":"nkonovalov@mirantis.com","username":"nkonovalov"},"change_message_id":"2b7c5d693b0db000f802b75c90a30340bd950da9","unresolved":false,"context_lines":[{"line_number":329,"context_line":""},{"line_number":330,"context_line":"    def _is_cluster_active(self, cluster):"},{"line_number":331,"context_line":"        cluster_status \u003d cluster.status.lower()"},{"line_number":332,"context_line":"        LOG.debug(\"Waiting for cluster %s to become active. Status: %s\" %"},{"line_number":333,"context_line":"                  (cluster.name, cluster_status))"},{"line_number":334,"context_line":""},{"line_number":335,"context_line":"        if cluster_status \u003d\u003d \"error\":"}],"source_content_type":"text/x-python","patch_set":2,"id":"baa041b7_e16e4b95","line":332,"in_reply_to":"baa041b7_e373f3e5","updated":"2015-04-06 11:06:51.000000000","message":"This method is called while waiting for the objects and only there, so I think it\u0027s the best place to write the log.","commit_id":"4f139c4f1e398668fe08ed36efcd1246181ecccd"},{"author":{"_account_id":8507,"name":"Mikhail Dubov","email":"mdubov@mirantis.com","username":"msdubov"},"change_message_id":"e4c5adb4c42be9c427ba70adabcf33097a16a6e2","unresolved":false,"context_lines":[{"line_number":400,"context_line":"            is_ready\u003dself._is_cluster_deleted)"},{"line_number":401,"context_line":""},{"line_number":402,"context_line":"    def _is_cluster_deleted(self, cl_id):"},{"line_number":403,"context_line":"        LOG.debug(\"Waiting for cluster %s to be deleted.\" % cl_id)"},{"line_number":404,"context_line":"        try:"},{"line_number":405,"context_line":"            self.clients(\"sahara\").clusters.get(cl_id)"},{"line_number":406,"context_line":"            return False"}],"source_content_type":"text/x-python","patch_set":2,"id":"9aa53dc9_1fe46339","line":403,"updated":"2015-04-06 11:45:18.000000000","message":"Maybe also add the status info here? To be consistent with other log messages","commit_id":"4f139c4f1e398668fe08ed36efcd1246181ecccd"},{"author":{"_account_id":7132,"name":"Nikita Konovalov","email":"nkonovalov@mirantis.com","username":"nkonovalov"},"change_message_id":"727e1d402c5c6db903caf045237ecba87eebb745","unresolved":false,"context_lines":[{"line_number":400,"context_line":"            is_ready\u003dself._is_cluster_deleted)"},{"line_number":401,"context_line":""},{"line_number":402,"context_line":"    def _is_cluster_deleted(self, cl_id):"},{"line_number":403,"context_line":"        LOG.debug(\"Waiting for cluster %s to be deleted.\" % cl_id)"},{"line_number":404,"context_line":"        try:"},{"line_number":405,"context_line":"            self.clients(\"sahara\").clusters.get(cl_id)"},{"line_number":406,"context_line":"            return False"}],"source_content_type":"text/x-python","patch_set":2,"id":"9aa53dc9_ae71c7e2","line":403,"in_reply_to":"9aa53dc9_1fe46339","updated":"2015-04-06 14:39:20.000000000","message":"Agree makes sense.","commit_id":"4f139c4f1e398668fe08ed36efcd1246181ecccd"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"ac7b1e6257a60a75765e6e3220ccadb1ff5eb15c","unresolved":false,"context_lines":[{"line_number":403,"context_line":"            is_ready\u003dself._is_cluster_deleted)"},{"line_number":404,"context_line":""},{"line_number":405,"context_line":"    def _is_cluster_deleted(self, cluster):"},{"line_number":406,"context_line":"        LOG.debug(\"Checking cluster `%s` to be deleted. Status: `%s`\" %"},{"line_number":407,"context_line":"                  (cluster.name, cluster.status))"},{"line_number":408,"context_line":"        try:"},{"line_number":409,"context_line":"            self.clients(\"sahara\").clusters.get(cluster.id)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9aa53dc9_6fcf06b1","line":406,"updated":"2015-04-07 16:01:23.000000000","message":"So I dislike this idea a bit. \n\nI mean there are finished state, error state and not ready state, why we need to print \"not ready state\" at all how this will help end users at all?","commit_id":"fe3cae8777c72fb2f36ad437908c9230800e6a21"},{"author":{"_account_id":7369,"name":"Sergey Skripnick","email":"sskripnick@mirantis.com","username":"redixin"},"change_message_id":"6c22089d4cc28bd157327573a56842c92807141b","unresolved":false,"context_lines":[{"line_number":403,"context_line":"            is_ready\u003dself._is_cluster_deleted)"},{"line_number":404,"context_line":""},{"line_number":405,"context_line":"    def _is_cluster_deleted(self, cluster):"},{"line_number":406,"context_line":"        LOG.debug(\"Checking cluster `%s` to be deleted. Status: `%s`\" %"},{"line_number":407,"context_line":"                  (cluster.name, cluster.status))"},{"line_number":408,"context_line":"        try:"},{"line_number":409,"context_line":"            self.clients(\"sahara\").clusters.get(cluster.id)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9aa53dc9_2c053a45","line":406,"in_reply_to":"9aa53dc9_6fcf06b1","updated":"2015-04-09 09:51:57.000000000","message":"How all LOG.debug will help end users?","commit_id":"fe3cae8777c72fb2f36ad437908c9230800e6a21"},{"author":{"_account_id":7369,"name":"Sergey Skripnick","email":"sskripnick@mirantis.com","username":"redixin"},"change_message_id":"ce8e832b5d0fbd9bb27fde21453405e605753199","unresolved":false,"context_lines":[{"line_number":470,"context_line":"        status \u003d self.clients(\"sahara\").job_executions.get(je_id).info["},{"line_number":471,"context_line":"            \"status\"].lower()"},{"line_number":472,"context_line":""},{"line_number":473,"context_line":"        LOG.debug(\"Waiting for Job Execution %s to complete. Status: %s\" %"},{"line_number":474,"context_line":"                  (je_id, status))"},{"line_number":475,"context_line":"        if status in (\"success\", \"succeeded\"):"},{"line_number":476,"context_line":"            return True"}],"source_content_type":"text/x-python","patch_set":6,"id":"dac4157f_73882d23","line":473,"updated":"2015-04-20 11:41:33.000000000","message":"This looks more like \"Checking\", not \"Waiting. Just like in _is_cluster_deleted","commit_id":"0e88b4ea55ef0a23559c19de9804ba8d803fbcfb"}]}
