)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"d8d1af6f27b6eedd03c36b6f57e5788a545ed16a","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Wait for status"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"wait_for helper improved to handle and log the status changes of the"},{"line_number":10,"context_line":"resource."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I04f917033a02ca21fa1ad6eb55fcdb727ce82090"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":13,"id":"7a016987_51659cb2","line":9,"updated":"2015-05-20 23:35:29.000000000","message":"I think we can describe that know we can specify list of statuses etc","commit_id":"1164f10d4fc37a3e5f27c991d065e4d1d8514962"},{"author":{"_account_id":13609,"name":"Pavel Boldin","email":"pboldin@mirantis.com","username":"pboldin"},"change_message_id":"8b2db9c61e08ad46c17a158c47fa9e26fcf5906e","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Nikita Konovalov \u003cnkonovalov@mirantis.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-05-27 15:36:01 +0300"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Wait for status"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"wait_for helper improved to handle and log the status changes of the"},{"line_number":10,"context_line":"resource."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":16,"id":"7a016987_92fc2473","line":7,"updated":"2015-05-30 19:49:20.000000000","message":"Please also change this short-line since it is confusing.\n\nFollow the https://wiki.openstack.org/wiki/GitCommitMessages","commit_id":"ee3cfa185db3bf17e64a24383540a5427b09028f"},{"author":{"_account_id":13609,"name":"Pavel Boldin","email":"pboldin@mirantis.com","username":"pboldin"},"change_message_id":"8e2e9ea603e311f3aa32df732d44dd11585c221e","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Wait for status"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"wait_for helper improved to handle and log the status changes of the"},{"line_number":10,"context_line":"resource."},{"line_number":11,"context_line":"wait_for now accepts active_statuses, failure_statuses and attribute"},{"line_number":12,"context_line":"name to perform status checks on the resource."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":16,"id":"7a016987_cd4b4f86","line":10,"updated":"2015-05-30 19:48:16.000000000","message":"No need for a newline.","commit_id":"ee3cfa185db3bf17e64a24383540a5427b09028f"},{"author":{"_account_id":13609,"name":"Pavel Boldin","email":"pboldin@mirantis.com","username":"pboldin"},"change_message_id":"2eab867b244fe539fe2c850c509eb6dd59609bdf","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Nikita Konovalov \u003cnkonovalov@mirantis.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-06-01 17:30:11 +0300"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Wait for status"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"wait_for helper improved to handle and log the status changes of the"},{"line_number":10,"context_line":"resource. wait_for now accepts active_statuses, failure_statuses and attribute"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":17,"id":"7a016987_38a6580f","line":7,"updated":"2015-06-01 14:51:13.000000000","message":"Please rewrite as\n Add `wait_for_status\u0027\n\nThe first line of the commit message is to say shortly what the commit does:\n Add something\n Delete something\n Revert something\n Implement something\n Refactor something\n\nSaying \"Wait for status\" means that the commit is waiting for something, which is impossible.","commit_id":"51efe92149b320982a2336344371ce96324fa6e0"}],"rally/benchmark/utils.py":[{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"1b0b29feaa965ed60704f82b5492edbc285bf6b7","unresolved":false,"context_lines":[{"line_number":135,"context_line":"    return resource"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"def wait_for_status(resource, ready_statuses, failure_statuses\u003d[],"},{"line_number":139,"context_line":"                    status_attr\u003d\"status\", update_resource\u003dNone, timeout\u003d60,"},{"line_number":140,"context_line":"                    check_interval\u003d1):"},{"line_number":141,"context_line":"    \"\"\"Waits for the given resource to come into the one of the given statuses."}],"source_content_type":"text/x-python","patch_set":6,"id":"3acd31a7_e661ce3a","line":138,"updated":"2015-05-03 09:35:08.000000000","message":"I am not sure that we need new method that does the same thing like wait_for. \n\nCould you just extend wait_for so all benchmark scenarios will get this improvement","commit_id":"04be9917dc84e2d1ddb0ff1bf677861fb3b2af5d"},{"author":{"_account_id":8507,"name":"Mikhail Dubov","email":"mdubov@mirantis.com","username":"msdubov"},"change_message_id":"638c4c0e737b99501f470b9225722e3d10918f0e","unresolved":false,"context_lines":[{"line_number":96,"context_line":"    return _list"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"def wait_for(resource, is_ready\u003dNone, ready_statuses\u003d[],"},{"line_number":100,"context_line":"             failure_statuses\u003d[], status_attr\u003d\"status\", update_resource\u003dNone,"},{"line_number":101,"context_line":"             timeout\u003d60, check_interval\u003d1):"},{"line_number":102,"context_line":"    \"\"\"Waits for the given resource to come into the one of the given statuses."}],"source_content_type":"text/x-python","patch_set":11,"id":"9a0c5dc1_a31cfa13","line":99,"updated":"2015-05-13 11:22:50.000000000","message":"Having [] as the default value should always be avoided in Python, please read this: http://docs.python-guide.org/en/latest/writing/gotchas/\n\nThe most common way to handle this is to set\n\n    ..., ready_statuses\u003dNone,\n\nand then in the method body:\n\n    ready_statuses \u003d ready_statuses or []\n\nSame for failure_statuses","commit_id":"ffc6fd2bbd0b8fba8d43ba20a89ae74f33b12129"},{"author":{"_account_id":8507,"name":"Mikhail Dubov","email":"mdubov@mirantis.com","username":"msdubov"},"change_message_id":"638c4c0e737b99501f470b9225722e3d10918f0e","unresolved":false,"context_lines":[{"line_number":134,"context_line":"        if status in ready_statuses:"},{"line_number":135,"context_line":"            return True"},{"line_number":136,"context_line":"        if status in failure_statuses:"},{"line_number":137,"context_line":"            raise exceptions.TaskInvalidStatus("},{"line_number":138,"context_line":"                \"Resource %s has come into %s status\" %"},{"line_number":139,"context_line":"                (resource_repr, status))"},{"line_number":140,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"9a0c5dc1_63ede2ee","line":137,"updated":"2015-05-13 11:22:50.000000000","message":"Seems like \u0027TaskInvalidStatus\u0027 is not the best choice for exception raised when the resource status is invalid.","commit_id":"ffc6fd2bbd0b8fba8d43ba20a89ae74f33b12129"},{"author":{"_account_id":7132,"name":"Nikita Konovalov","email":"nkonovalov@mirantis.com","username":"nkonovalov"},"change_message_id":"ddc9fc5e2ca4e7a83f4ffe739e6f3ee2b34913c2","unresolved":false,"context_lines":[{"line_number":134,"context_line":"        if status in ready_statuses:"},{"line_number":135,"context_line":"            return True"},{"line_number":136,"context_line":"        if status in failure_statuses:"},{"line_number":137,"context_line":"            raise exceptions.TaskInvalidStatus("},{"line_number":138,"context_line":"                \"Resource %s has come into %s status\" %"},{"line_number":139,"context_line":"                (resource_repr, status))"},{"line_number":140,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"9a0c5dc1_02b857e4","line":137,"in_reply_to":"9a0c5dc1_63ede2ee","updated":"2015-05-13 14:53:07.000000000","message":"ok, I\u0027ll add a special exception for this case.","commit_id":"ffc6fd2bbd0b8fba8d43ba20a89ae74f33b12129"},{"author":{"_account_id":8507,"name":"Mikhail Dubov","email":"mdubov@mirantis.com","username":"msdubov"},"change_message_id":"638c4c0e737b99501f470b9225722e3d10918f0e","unresolved":false,"context_lines":[{"line_number":150,"context_line":""},{"line_number":151,"context_line":"        if not ready_statuses:"},{"line_number":152,"context_line":"            raise exceptions.TaskInvalidStatus("},{"line_number":153,"context_line":"                \"Cant wait for resource\u0027s %s status. No ready \""},{"line_number":154,"context_line":"                \"statuses provided\" % resource_repr)"},{"line_number":155,"context_line":"        if not update_resource:"},{"line_number":156,"context_line":"            raise exceptions.TaskInvalidStatus("}],"source_content_type":"text/x-python","patch_set":11,"id":"9a0c5dc1_63c4c25e","line":153,"updated":"2015-05-13 11:22:50.000000000","message":"s/Cant/Can\u0027t","commit_id":"ffc6fd2bbd0b8fba8d43ba20a89ae74f33b12129"},{"author":{"_account_id":8507,"name":"Mikhail Dubov","email":"mdubov@mirantis.com","username":"msdubov"},"change_message_id":"638c4c0e737b99501f470b9225722e3d10918f0e","unresolved":false,"context_lines":[{"line_number":167,"context_line":"    latest_status_update \u003d start"},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"    while True:"},{"line_number":170,"context_line":"        if update_resource is not None:"},{"line_number":171,"context_line":"            resource \u003d update_resource(resource)"},{"line_number":172,"context_line":"        status \u003d get_status(resource, status_attr)"},{"line_number":173,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"9a0c5dc1_a3787a2c","line":170,"updated":"2015-05-13 11:22:50.000000000","message":"Why can\u0027t we have here just\n\n    if update_resource:\n\nas before?","commit_id":"ffc6fd2bbd0b8fba8d43ba20a89ae74f33b12129"},{"author":{"_account_id":7132,"name":"Nikita Konovalov","email":"nkonovalov@mirantis.com","username":"nkonovalov"},"change_message_id":"ddc9fc5e2ca4e7a83f4ffe739e6f3ee2b34913c2","unresolved":false,"context_lines":[{"line_number":167,"context_line":"    latest_status_update \u003d start"},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"    while True:"},{"line_number":170,"context_line":"        if update_resource is not None:"},{"line_number":171,"context_line":"            resource \u003d update_resource(resource)"},{"line_number":172,"context_line":"        status \u003d get_status(resource, status_attr)"},{"line_number":173,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"9a0c5dc1_e221c34e","line":170,"in_reply_to":"9a0c5dc1_a3787a2c","updated":"2015-05-13 14:53:07.000000000","message":"It\u0027t better to have it this way because of python 2.7 and 3.4 difference. When writing tests the assert_has_calls method needs all calls to be listed. py27 calls __non_zero__ and py34 is calling something else.","commit_id":"ffc6fd2bbd0b8fba8d43ba20a89ae74f33b12129"},{"author":{"_account_id":8507,"name":"Mikhail Dubov","email":"mdubov@mirantis.com","username":"msdubov"},"change_message_id":"638c4c0e737b99501f470b9225722e3d10918f0e","unresolved":false,"context_lines":[{"line_number":175,"context_line":"            current_time \u003d time.time()"},{"line_number":176,"context_line":"            delta \u003d current_time - latest_status_update"},{"line_number":177,"context_line":"            LOG.debug("},{"line_number":178,"context_line":"                \"Waiting for resource %s. Status changed %s \u003d\u003e %s in %s\" %"},{"line_number":179,"context_line":"                (resource_repr, latest_status, status, delta))"},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"            latest_status \u003d status"}],"source_content_type":"text/x-python","patch_set":11,"id":"9a0c5dc1_03e866b3","line":178,"updated":"2015-05-13 11:22:50.000000000","message":"Our convenience is to use string substitutions with dictionaries when there is more than one substitution, this improves readability:\n\n    \"Waiting for resource %(resource)s. Status changed: \"\n    \"%(latest)s \u003d\u003e %(current)s in %(delta)s\" %\n    {\"resource\": resource_repr, \"latest\": latest_status,\n     \"current\": status, \"delta\": delta}","commit_id":"ffc6fd2bbd0b8fba8d43ba20a89ae74f33b12129"},{"author":{"_account_id":7132,"name":"Nikita Konovalov","email":"nkonovalov@mirantis.com","username":"nkonovalov"},"change_message_id":"ddc9fc5e2ca4e7a83f4ffe739e6f3ee2b34913c2","unresolved":false,"context_lines":[{"line_number":175,"context_line":"            current_time \u003d time.time()"},{"line_number":176,"context_line":"            delta \u003d current_time - latest_status_update"},{"line_number":177,"context_line":"            LOG.debug("},{"line_number":178,"context_line":"                \"Waiting for resource %s. Status changed %s \u003d\u003e %s in %s\" %"},{"line_number":179,"context_line":"                (resource_repr, latest_status, status, delta))"},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"            latest_status \u003d status"}],"source_content_type":"text/x-python","patch_set":11,"id":"9a0c5dc1_22debb3f","line":178,"in_reply_to":"9a0c5dc1_03e866b3","updated":"2015-05-13 14:53:07.000000000","message":"willdo","commit_id":"ffc6fd2bbd0b8fba8d43ba20a89ae74f33b12129"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"441cb29dad2da1b4f56c066bd31f617bce65cf90","unresolved":false,"context_lines":[{"line_number":49,"context_line":"         isinstance(resource[status_attr], six.string_types))):"},{"line_number":50,"context_line":"        return resource[status_attr].upper()"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    return \"NONE\""},{"line_number":53,"context_line":""},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"class resource_is(object):"}],"source_content_type":"text/x-python","patch_set":13,"id":"7a016987_91b9d417","line":52,"updated":"2015-05-20 23:34:05.000000000","message":"Why not return None? Maybe I\u0027m wrong and this is used in Rally core\u003d) I\u0027m too lazy to check it at the night)","commit_id":"1164f10d4fc37a3e5f27c991d065e4d1d8514962"},{"author":{"_account_id":7132,"name":"Nikita Konovalov","email":"nkonovalov@mirantis.com","username":"nkonovalov"},"change_message_id":"7b911cf035d8dde1248aa951fc3db309aa82785f","unresolved":false,"context_lines":[{"line_number":49,"context_line":"         isinstance(resource[status_attr], six.string_types))):"},{"line_number":50,"context_line":"        return resource[status_attr].upper()"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    return \"NONE\""},{"line_number":53,"context_line":""},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"class resource_is(object):"}],"source_content_type":"text/x-python","patch_set":13,"id":"7a016987_1ece082e","line":52,"in_reply_to":"7a016987_91b9d417","updated":"2015-05-21 12:49:18.000000000","message":"This value is returned by the original code and it is not in the scope of this change to update this behavior I think.","commit_id":"1164f10d4fc37a3e5f27c991d065e4d1d8514962"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"441cb29dad2da1b4f56c066bd31f617bce65cf90","unresolved":false,"context_lines":[{"line_number":134,"context_line":"    ready_statuses \u003d [s.upper() for s in ready_statuses or []]"},{"line_number":135,"context_line":"    failure_statuses \u003d [s.upper() for s in failure_statuses or []]"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"    def status_check(resource, status):"},{"line_number":138,"context_line":"        if status in ready_statuses:"},{"line_number":139,"context_line":"            return True"},{"line_number":140,"context_line":"        if status in failure_statuses:"}],"source_content_type":"text/x-python","patch_set":13,"id":"7a016987_9aad769d","line":137,"updated":"2015-05-20 23:34:05.000000000","message":"Just a thoughts what if we have status X in both lists. I think its better to specify error)","commit_id":"1164f10d4fc37a3e5f27c991d065e4d1d8514962"},{"author":{"_account_id":7132,"name":"Nikita Konovalov","email":"nkonovalov@mirantis.com","username":"nkonovalov"},"change_message_id":"7b911cf035d8dde1248aa951fc3db309aa82785f","unresolved":false,"context_lines":[{"line_number":134,"context_line":"    ready_statuses \u003d [s.upper() for s in ready_statuses or []]"},{"line_number":135,"context_line":"    failure_statuses \u003d [s.upper() for s in failure_statuses or []]"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"    def status_check(resource, status):"},{"line_number":138,"context_line":"        if status in ready_statuses:"},{"line_number":139,"context_line":"            return True"},{"line_number":140,"context_line":"        if status in failure_statuses:"}],"source_content_type":"text/x-python","patch_set":13,"id":"7a016987_3ef0a466","line":137,"in_reply_to":"7a016987_9aad769d","updated":"2015-05-21 12:49:18.000000000","message":"I agree that lists should not intersect.","commit_id":"1164f10d4fc37a3e5f27c991d065e4d1d8514962"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"441cb29dad2da1b4f56c066bd31f617bce65cf90","unresolved":false,"context_lines":[{"line_number":141,"context_line":"            raise exceptions.GetResourceErrorStatus("},{"line_number":142,"context_line":"                resource\u003dresource,"},{"line_number":143,"context_line":"                status\u003dstatus,"},{"line_number":144,"context_line":"                fault\u003d\"Status in failure list %s\" % str(failure_statuses))"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"    def is_ready_check(resource, status):"},{"line_number":147,"context_line":"        return is_ready(resource)"}],"source_content_type":"text/x-python","patch_set":13,"id":"7a016987_3a18c21d","line":144,"updated":"2015-05-20 23:34:05.000000000","message":"I think users will not no what is the list with falures we need to rewrite maybe this message. Also in last line of this function for consistency we\u0027d better return False.","commit_id":"1164f10d4fc37a3e5f27c991d065e4d1d8514962"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"441cb29dad2da1b4f56c066bd31f617bce65cf90","unresolved":false,"context_lines":[{"line_number":143,"context_line":"                status\u003dstatus,"},{"line_number":144,"context_line":"                fault\u003d\"Status in failure list %s\" % str(failure_statuses))"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"    def is_ready_check(resource, status):"},{"line_number":147,"context_line":"        return is_ready(resource)"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"    check \u003d is_ready_check"}],"source_content_type":"text/x-python","patch_set":13,"id":"7a016987_4ba28bfe","line":146,"updated":"2015-05-20 23:34:05.000000000","message":"Maybe add \"if not is_ready:\" to status_check and we don\u0027t need to add second inner function. Also inner function is not gooad as I know.","commit_id":"1164f10d4fc37a3e5f27c991d065e4d1d8514962"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"441cb29dad2da1b4f56c066bd31f617bce65cf90","unresolved":false,"context_lines":[{"line_number":159,"context_line":"                \"statuses provided\" % resource_repr)"},{"line_number":160,"context_line":"        if not update_resource:"},{"line_number":161,"context_line":"            raise exceptions.TaskInvalidStatus("},{"line_number":162,"context_line":"                \"Cant wait for resource\u0027s %s status. No update method.\""},{"line_number":163,"context_line":"                % resource_repr)"},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"    start \u003d time.time()"}],"source_content_type":"text/x-python","patch_set":13,"id":"7a016987_2ba98f90","line":162,"updated":"2015-05-20 23:34:05.000000000","message":"* typo Can\u0027t","commit_id":"1164f10d4fc37a3e5f27c991d065e4d1d8514962"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"441cb29dad2da1b4f56c066bd31f617bce65cf90","unresolved":false,"context_lines":[{"line_number":168,"context_line":"    latest_status_update \u003d start"},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"    while True:"},{"line_number":171,"context_line":"        if update_resource is not None:"},{"line_number":172,"context_line":"            resource \u003d update_resource(resource)"},{"line_number":173,"context_line":"        status \u003d get_status(resource, status_attr)"},{"line_number":174,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"7a016987_0e44a118","line":171,"updated":"2015-05-20 23:34:05.000000000","message":"Could we seplify \"if update_resource:\"?","commit_id":"1164f10d4fc37a3e5f27c991d065e4d1d8514962"},{"author":{"_account_id":7132,"name":"Nikita Konovalov","email":"nkonovalov@mirantis.com","username":"nkonovalov"},"change_message_id":"7b911cf035d8dde1248aa951fc3db309aa82785f","unresolved":false,"context_lines":[{"line_number":168,"context_line":"    latest_status_update \u003d start"},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"    while True:"},{"line_number":171,"context_line":"        if update_resource is not None:"},{"line_number":172,"context_line":"            resource \u003d update_resource(resource)"},{"line_number":173,"context_line":"        status \u003d get_status(resource, status_attr)"},{"line_number":174,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"7a016987_1ef5e855","line":171,"in_reply_to":"7a016987_0e44a118","updated":"2015-05-21 12:49:18.000000000","message":"The simple check makes writing unit tests not simple for both python 2.7 and 3.4 as there are different call made on updated_resource.","commit_id":"1164f10d4fc37a3e5f27c991d065e4d1d8514962"},{"author":{"_account_id":8576,"name":"Yair Fried","email":"yfried@redhat.com","username":"yfried"},"change_message_id":"45c39b8ba2190500a953937b5d019ebd0d57cfd3","unresolved":false,"context_lines":[{"line_number":28,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"def get_status(resource, status_attr\u003d\"status\"):"},{"line_number":32,"context_line":"    # workaround for heat resources - using stack_status instead of status"},{"line_number":33,"context_line":"    if ((hasattr(resource, \"stack_status\") and"},{"line_number":34,"context_line":"         isinstance(resource.stack_status, six.string_types))):"}],"source_content_type":"text/x-python","patch_set":14,"id":"7a016987_0b8b2820","line":31,"updated":"2015-05-25 11:57:40.000000000","message":"if you have a default return value, please add an appropriate doc-string for this method.","commit_id":"8dba0e5cc8e278777eb971c27e9b71b9134c48ac"},{"author":{"_account_id":8576,"name":"Yair Fried","email":"yfried@redhat.com","username":"yfried"},"change_message_id":"45c39b8ba2190500a953937b5d019ebd0d57cfd3","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"def get_status(resource, status_attr\u003d\"status\"):"},{"line_number":32,"context_line":"    # workaround for heat resources - using stack_status instead of status"},{"line_number":33,"context_line":"    if ((hasattr(resource, \"stack_status\") and"},{"line_number":34,"context_line":"         isinstance(resource.stack_status, six.string_types))):"},{"line_number":35,"context_line":"        return resource.stack_status.upper()"},{"line_number":36,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"7a016987_2b8a6464","line":33,"updated":"2015-05-25 11:57:40.000000000","message":"if we add \"status_attr\", do we still need these 2 workarounds?\n\nIf so, I bet we can do this with less code duplication:  \n\n  for s_attr in [\"stack_status\", \"state\", status_attr]:\n      status \u003d getattr(resource, s_attr)\n      if isinstance(status, six.string_types):\n          return status.upper()","commit_id":"8dba0e5cc8e278777eb971c27e9b71b9134c48ac"},{"author":{"_account_id":8576,"name":"Yair Fried","email":"yfried@redhat.com","username":"yfried"},"change_message_id":"1642b8e59774ac7f261dc716d444d9c78fb048dc","unresolved":false,"context_lines":[{"line_number":96,"context_line":"    return _list"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"def wait_for(resource, is_ready\u003dNone, ready_statuses\u003dNone,"},{"line_number":100,"context_line":"             failure_statuses\u003dNone, status_attr\u003d\"status\", update_resource\u003dNone,"},{"line_number":101,"context_line":"             timeout\u003d60, check_interval\u003d1):"},{"line_number":102,"context_line":"    \"\"\"Waits for the given resource to come into the one of the given statuses."}],"source_content_type":"text/x-python","patch_set":14,"id":"7a016987_9271797a","line":99,"updated":"2015-05-26 07:40:38.000000000","message":"It seems like you\u0027ve introduced a whole new method into the old one that handles status lists and update method instead of is_ready callable.\n\nCould you please split it so wait_for calls either the old method or your new one based on the input?","commit_id":"8dba0e5cc8e278777eb971c27e9b71b9134c48ac"},{"author":{"_account_id":8576,"name":"Yair Fried","email":"yfried@redhat.com","username":"yfried"},"change_message_id":"1642b8e59774ac7f261dc716d444d9c78fb048dc","unresolved":false,"context_lines":[{"line_number":134,"context_line":"    ready_statuses \u003d set([s.upper() for s in ready_statuses or []])"},{"line_number":135,"context_line":"    failure_statuses \u003d set([s.upper() for s in failure_statuses or []])"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"    def status_check(resource, status):"},{"line_number":138,"context_line":"        if status in ready_statuses:"},{"line_number":139,"context_line":"            return True"},{"line_number":140,"context_line":"        if status in failure_statuses:"}],"source_content_type":"text/x-python","patch_set":14,"id":"7a016987_b7122708","line":137,"updated":"2015-05-26 07:40:38.000000000","message":"please define status_check as a default \"is_ready\"","commit_id":"8dba0e5cc8e278777eb971c27e9b71b9134c48ac"},{"author":{"_account_id":8576,"name":"Yair Fried","email":"yfried@redhat.com","username":"yfried"},"change_message_id":"45c39b8ba2190500a953937b5d019ebd0d57cfd3","unresolved":false,"context_lines":[{"line_number":144,"context_line":"                fault\u003d\"Status in failure list %s\" % str(failure_statuses))"},{"line_number":145,"context_line":"        return False"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"    def is_ready_check(resource, status):"},{"line_number":148,"context_line":"        return is_ready(resource)"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"    check \u003d is_ready_check"}],"source_content_type":"text/x-python","patch_set":14,"id":"7a016987_6b24dc0b","line":147,"updated":"2015-05-25 11:57:40.000000000","message":"status isn\u0027t used","commit_id":"8dba0e5cc8e278777eb971c27e9b71b9134c48ac"},{"author":{"_account_id":8576,"name":"Yair Fried","email":"yfried@redhat.com","username":"yfried"},"change_message_id":"45c39b8ba2190500a953937b5d019ebd0d57cfd3","unresolved":false,"context_lines":[{"line_number":147,"context_line":"    def is_ready_check(resource, status):"},{"line_number":148,"context_line":"        return is_ready(resource)"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"    check \u003d is_ready_check"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"    if not is_ready:"},{"line_number":153,"context_line":"        # The checking function is not provided, using `ready_statuses` and"}],"source_content_type":"text/x-python","patch_set":14,"id":"7a016987_2b1a64c6","line":150,"updated":"2015-05-25 11:57:40.000000000","message":"why?","commit_id":"8dba0e5cc8e278777eb971c27e9b71b9134c48ac"},{"author":{"_account_id":8576,"name":"Yair Fried","email":"yfried@redhat.com","username":"yfried"},"change_message_id":"1642b8e59774ac7f261dc716d444d9c78fb048dc","unresolved":false,"context_lines":[{"line_number":147,"context_line":"    def is_ready_check(resource, status):"},{"line_number":148,"context_line":"        return is_ready(resource)"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"    check \u003d is_ready_check"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"    if not is_ready:"},{"line_number":153,"context_line":"        # The checking function is not provided, using `ready_statuses` and"}],"source_content_type":"text/x-python","patch_set":14,"id":"7a016987_f7bf7f5e","line":150,"in_reply_to":"7a016987_2b1a64c6","updated":"2015-05-26 07:40:38.000000000","message":"check \u003d is_ready_check if is_ready else status_check","commit_id":"8dba0e5cc8e278777eb971c27e9b71b9134c48ac"},{"author":{"_account_id":8576,"name":"Yair Fried","email":"yfried@redhat.com","username":"yfried"},"change_message_id":"1642b8e59774ac7f261dc716d444d9c78fb048dc","unresolved":false,"context_lines":[{"line_number":152,"context_line":"    if not is_ready:"},{"line_number":153,"context_line":"        # The checking function is not provided, using `ready_statuses` and"},{"line_number":154,"context_line":"        # `failure_statuses`"},{"line_number":155,"context_line":"        check \u003d status_check"},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"        if len(ready_statuses \u0026 failure_statuses) \u003e 0:"},{"line_number":158,"context_line":"            raise exceptions.TaskInvalidStatus("}],"source_content_type":"text/x-python","patch_set":14,"id":"7a016987_97af2b2b","line":155,"updated":"2015-05-26 07:40:38.000000000","message":"see previous comment. the rest of this block should go after L136 as input validation.","commit_id":"8dba0e5cc8e278777eb971c27e9b71b9134c48ac"},{"author":{"_account_id":8576,"name":"Yair Fried","email":"yfried@redhat.com","username":"yfried"},"change_message_id":"1642b8e59774ac7f261dc716d444d9c78fb048dc","unresolved":false,"context_lines":[{"line_number":155,"context_line":"        check \u003d status_check"},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"        if len(ready_statuses \u0026 failure_statuses) \u003e 0:"},{"line_number":158,"context_line":"            raise exceptions.TaskInvalidStatus("},{"line_number":159,"context_line":"                \"Can\u0027t wait for resource\u0027s %s status. Ready and Failure\""},{"line_number":160,"context_line":"                \"statuses conflict.\" % resource_repr)"},{"line_number":161,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"7a016987_1717bb55","line":158,"updated":"2015-05-26 07:40:38.000000000","message":"IMO ValueError is better for a bad-input exception: http://stackoverflow.com/questions/256222/which-exception-should-i-raise-on-bad-illegal-argument-combinations-in-python","commit_id":"8dba0e5cc8e278777eb971c27e9b71b9134c48ac"},{"author":{"_account_id":13609,"name":"Pavel Boldin","email":"pboldin@mirantis.com","username":"pboldin"},"change_message_id":"8e2e9ea603e311f3aa32df732d44dd11585c221e","unresolved":false,"context_lines":[{"line_number":165,"context_line":"                resource_status\u003dget_status(resource))"},{"line_number":166,"context_line":""},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"def wait_for_status(resource, ready_statuses, failure_statuses\u003dNone,"},{"line_number":169,"context_line":"                    status_attr\u003d\"status\", update_resource\u003dNone,"},{"line_number":170,"context_line":"                    timeout\u003d60, check_interval\u003d1):"},{"line_number":171,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"7a016987_f2d478e9","line":168,"updated":"2015-05-30 19:48:16.000000000","message":"I do really think there should be a check that the value supplied is either a list or a tuple.","commit_id":"ee3cfa185db3bf17e64a24383540a5427b09028f"},{"author":{"_account_id":7132,"name":"Nikita Konovalov","email":"nkonovalov@mirantis.com","username":"nkonovalov"},"change_message_id":"26271eed51778d8c9e65b46366a61fd7babe514f","unresolved":false,"context_lines":[{"line_number":165,"context_line":"                resource_status\u003dget_status(resource))"},{"line_number":166,"context_line":""},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"def wait_for_status(resource, ready_statuses, failure_statuses\u003dNone,"},{"line_number":169,"context_line":"                    status_attr\u003d\"status\", update_resource\u003dNone,"},{"line_number":170,"context_line":"                    timeout\u003d60, check_interval\u003d1):"},{"line_number":171,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"7a016987_1de02e28","line":168,"in_reply_to":"7a016987_f2d478e9","updated":"2015-06-01 14:29:39.000000000","message":"Anything that is iterable fits. Converting to upper case will fail otherwise.","commit_id":"ee3cfa185db3bf17e64a24383540a5427b09028f"},{"author":{"_account_id":13609,"name":"Pavel Boldin","email":"pboldin@mirantis.com","username":"pboldin"},"change_message_id":"8e2e9ea603e311f3aa32df732d44dd11585c221e","unresolved":false,"context_lines":[{"line_number":176,"context_line":"    failure_statuses \u003d set([s.upper() for s in failure_statuses or []])"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"    if len(ready_statuses \u0026 failure_statuses) \u003e 0:"},{"line_number":179,"context_line":"            raise ValueError("},{"line_number":180,"context_line":"                \"Can\u0027t wait for resource\u0027s %s status. Ready and Failure\""},{"line_number":181,"context_line":"                \"statuses conflict.\" % resource_repr)"},{"line_number":182,"context_line":"    if not ready_statuses:"}],"source_content_type":"text/x-python","patch_set":16,"id":"7a016987_72e888b3","line":179,"updated":"2015-05-30 19:48:16.000000000","message":"Why different indent?","commit_id":"ee3cfa185db3bf17e64a24383540a5427b09028f"},{"author":{"_account_id":13609,"name":"Pavel Boldin","email":"pboldin@mirantis.com","username":"pboldin"},"change_message_id":"2eab867b244fe539fe2c850c509eb6dd59609bdf","unresolved":false,"context_lines":[{"line_number":172,"context_line":"    resource_repr \u003d getattr(resource, \"name\", repr(resource))"},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"    # make all statuses upper case"},{"line_number":175,"context_line":"    ready_statuses \u003d set([s.upper() for s in ready_statuses or []])"},{"line_number":176,"context_line":"    failure_statuses \u003d set([s.upper() for s in failure_statuses or []])"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"    if len(ready_statuses \u0026 failure_statuses) \u003e 0:"}],"source_content_type":"text/x-python","patch_set":17,"id":"7a016987_ddc61667","line":175,"updated":"2015-06-01 14:51:13.000000000","message":"Well, I just want to point out that:\n 1. A string is an iterable as well.\n 2. It is easy to confuse list of strings with a string.\n\nSo, someone will almost definitely call this function like.\n wait_for_status(ready_statuses\u003d\"abc\")","commit_id":"51efe92149b320982a2336344371ce96324fa6e0"},{"author":{"_account_id":13609,"name":"Pavel Boldin","email":"pboldin@mirantis.com","username":"pboldin"},"change_message_id":"2eab867b244fe539fe2c850c509eb6dd59609bdf","unresolved":false,"context_lines":[{"line_number":175,"context_line":"    ready_statuses \u003d set([s.upper() for s in ready_statuses or []])"},{"line_number":176,"context_line":"    failure_statuses \u003d set([s.upper() for s in failure_statuses or []])"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"    if len(ready_statuses \u0026 failure_statuses) \u003e 0:"},{"line_number":179,"context_line":"        raise ValueError("},{"line_number":180,"context_line":"            \"Can\u0027t wait for resource\u0027s %s status. Ready and Failure\""},{"line_number":181,"context_line":"            \"statuses conflict.\" % resource_repr)"}],"source_content_type":"text/x-python","patch_set":17,"id":"7a016987_7d8de22f","line":178,"updated":"2015-06-01 14:51:13.000000000","message":"I do really think that just\n if ready_statuses \u0026 failure_status:\n    ...\n\ndoes the same. (Sorry for not pointing that out earlier)","commit_id":"51efe92149b320982a2336344371ce96324fa6e0"},{"author":{"_account_id":8576,"name":"Yair Fried","email":"yfried@redhat.com","username":"yfried"},"change_message_id":"5d5b38a49c205167e1b9768845cdac271cbfcf87","unresolved":false,"context_lines":[{"line_number":172,"context_line":"    resource_repr \u003d getattr(resource, \"name\", repr(resource))"},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"    # make all statuses upper case"},{"line_number":175,"context_line":"    ready_statuses \u003d set([s.upper() for s in ready_statuses or []])"},{"line_number":176,"context_line":"    failure_statuses \u003d set([s.upper() for s in failure_statuses or []])"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"    if len(ready_statuses \u0026 failure_statuses) \u003e 0:"}],"source_content_type":"text/x-python","patch_set":18,"id":"3afb71cf_383c78e1","line":175,"updated":"2015-06-09 05:48:26.000000000","message":"please address Pavel\u0027s comments from patchset 17.","commit_id":"e3a8ab952d5531ddcc3a3fc29c24d54e9cd05d59"}],"tests/unit/benchmark/test_utils.py":[{"author":{"_account_id":13609,"name":"Pavel Boldin","email":"pboldin@mirantis.com","username":"pboldin"},"change_message_id":"8e2e9ea603e311f3aa32df732d44dd11585c221e","unresolved":false,"context_lines":[{"line_number":246,"context_line":"        utils.wait_for(resource\u003dres, ready_statuses\u003d[\"ready\"],"},{"line_number":247,"context_line":"                       update_resource\u003dupd)"},{"line_number":248,"context_line":""},{"line_number":249,"context_line":"        upd.assertCalledOnceWith(res)"},{"line_number":250,"context_line":"        mock_sleep.assertNotCalled()"},{"line_number":251,"context_line":""},{"line_number":252,"context_line":"    @mock.patch(\"rally.benchmark.utils.time.sleep\")"}],"source_content_type":"text/x-python","patch_set":16,"id":"7a016987_12da7417","line":249,"updated":"2015-05-30 19:48:16.000000000","message":"What is this?\n\nCorrect one is `assert_called_once_with\u0027.\n\n \u003e\u003e\u003e m \u003d mock.Mock()\n \u003e\u003e\u003e m.assertCalledOnceWith()\n \u003cMock name\u003d\u0027mock.assertCalledOnceWith()\u0027 id\u003d\u0027140698204060368\u0027\u003e","commit_id":"ee3cfa185db3bf17e64a24383540a5427b09028f"},{"author":{"_account_id":13609,"name":"Pavel Boldin","email":"pboldin@mirantis.com","username":"pboldin"},"change_message_id":"10677bf6a9cc49981e22dfb514b2f235d1a8d570","unresolved":false,"context_lines":[{"line_number":247,"context_line":"                       update_resource\u003dupd)"},{"line_number":248,"context_line":""},{"line_number":249,"context_line":"        upd.assert_called_once_with(res)"},{"line_number":250,"context_line":"        mock_sleep.assertNotCalled()"},{"line_number":251,"context_line":""},{"line_number":252,"context_line":"    @mock.patch(\"rally.benchmark.utils.time.sleep\")"},{"line_number":253,"context_line":"    @mock.patch(\"rally.benchmark.utils.time.time\", return_value\u003d1)"}],"source_content_type":"text/x-python","patch_set":17,"id":"7a016987_78d5f040","line":250,"updated":"2015-06-01 14:53:29.000000000","message":"There is no such assertion.\n\n \u003e\u003e\u003e dir(mock.Mock())\n[\u0027assert_any_call\u0027, \u0027assert_called_once_with\u0027, \u0027assert_called_with\u0027, \u0027assert_has_calls\u0027, \u0027attach_mock\u0027, \u0027call_args\u0027, \u0027call_args_list\u0027, \u0027call_count\u0027, \u0027called\u0027, \u0027configure_mock\u0027, \u0027method_calls\u0027, \u0027mock_add_spec\u0027, \u0027mock_calls\u0027, \u0027reset_mock\u0027, \u0027return_value\u0027, \u0027side_effect\u0027]\n\nUse self.assertFalse(mock_sleep.called)","commit_id":"51efe92149b320982a2336344371ce96324fa6e0"}]}
