)]}'
{"rally-jobs/rally.yaml":[{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"ac3438b32c787149599c1db6573f617c31bca887","unresolved":false,"context_lines":[{"line_number":1096,"context_line":"        image:"},{"line_number":1097,"context_line":"          name: {{image_name}}"},{"line_number":1098,"context_line":"        flavor:"},{"line_number":1099,"context_line":"          name: m1.tiny"},{"line_number":1100,"context_line":"        count: 3"},{"line_number":1101,"context_line":"      runner:"},{"line_number":1102,"context_line":"        type: \"constant\""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3acd31a7_30c7c697","line":1099,"updated":"2015-05-05 13:22:08.000000000","message":"Lets write for uniformity double quotes around flavor name.","commit_id":"b767002c5e354a260b92c09c83f7d70c0ddf595a"},{"author":{"_account_id":11748,"name":"Chris St. Pierre","email":"cstpierr@cisco.com","username":"stpierre"},"change_message_id":"4ae1a21ff06fd32b4de4c285f152d43c1b22c02f","unresolved":false,"context_lines":[{"line_number":1096,"context_line":"        image:"},{"line_number":1097,"context_line":"          name: {{image_name}}"},{"line_number":1098,"context_line":"        flavor:"},{"line_number":1099,"context_line":"          name: m1.tiny"},{"line_number":1100,"context_line":"        count: 3"},{"line_number":1101,"context_line":"      runner:"},{"line_number":1102,"context_line":"        type: \"constant\""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3acd31a7_73b305ea","line":1099,"in_reply_to":"3acd31a7_30c7c697","updated":"2015-05-05 13:55:38.000000000","message":"Done","commit_id":"b767002c5e354a260b92c09c83f7d70c0ddf595a"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"8a3f09bfbd3eafc0999214b0935aba2a9ed52e18","unresolved":false,"context_lines":[{"line_number":1075,"context_line":"      runner:"},{"line_number":1076,"context_line":"        type: \"constant\""},{"line_number":1077,"context_line":"        times: 1"},{"line_number":1078,"context_line":"        concurrency: 1"},{"line_number":1079,"context_line":"      context:"},{"line_number":1080,"context_line":"        users:"},{"line_number":1081,"context_line":"          tenants: 1"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"9a0c5dc1_92d702bf","line":1078,"updated":"2015-05-13 10:02:16.000000000","message":"This is actually bad test. Because it doesn\u0027t test concurrency.\n\nI  would prefer to put here: \n\n  times: 3 \n  concurrency: 3 \n\nand se what will happen","commit_id":"c72fad07c5712e10c3e3a72006aea58490002d27"},{"author":{"_account_id":11748,"name":"Chris St. Pierre","email":"cstpierr@cisco.com","username":"stpierre"},"change_message_id":"bc6f23364b95ad429226480274b13f29043ae745","unresolved":false,"context_lines":[{"line_number":1075,"context_line":"      runner:"},{"line_number":1076,"context_line":"        type: \"constant\""},{"line_number":1077,"context_line":"        times: 1"},{"line_number":1078,"context_line":"        concurrency: 1"},{"line_number":1079,"context_line":"      context:"},{"line_number":1080,"context_line":"        users:"},{"line_number":1081,"context_line":"          tenants: 1"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"7a016987_4d3b51ec","line":1078,"in_reply_to":"9a0c5dc1_92d702bf","updated":"2015-05-14 17:37:32.000000000","message":"Done","commit_id":"c72fad07c5712e10c3e3a72006aea58490002d27"}],"rally/benchmark/scenarios/nova/servers.py":[{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"309d058ca6e93ded2f2fc1c62c0411d35a516136","unresolved":false,"context_lines":[{"line_number":122,"context_line":"        :param force_delete: True if force_delete should be used"},{"line_number":123,"context_line":"        :param kwargs: Optional additional arguments for instance creation"},{"line_number":124,"context_line":"        \"\"\""},{"line_number":125,"context_line":"        self._boot_servers(\"rally_boot_multiple\", image, flavor,"},{"line_number":126,"context_line":"                           1, instances_amount\u003dcount, **kwargs)"},{"line_number":127,"context_line":"        self.sleep_between(min_sleep, max_sleep)"},{"line_number":128,"context_line":"        self._delete_all_servers(force\u003dforce_delete)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3acd31a7_34648ce2","line":125,"updated":"2015-05-03 14:03:50.000000000","message":"this can be call from one user 2 times simultaneously and it won\u0027t work. \n\nYou should pick different names","commit_id":"06070349787ebcbfbd1ee04b5f548f124eb0a382"},{"author":{"_account_id":11748,"name":"Chris St. Pierre","email":"cstpierr@cisco.com","username":"stpierre"},"change_message_id":"b61b54f9e2a718f78cbc95cb2f00f25004e76b6d","unresolved":false,"context_lines":[{"line_number":122,"context_line":"        :param force_delete: True if force_delete should be used"},{"line_number":123,"context_line":"        :param kwargs: Optional additional arguments for instance creation"},{"line_number":124,"context_line":"        \"\"\""},{"line_number":125,"context_line":"        self._boot_servers(\"rally_boot_multiple\", image, flavor,"},{"line_number":126,"context_line":"                           1, instances_amount\u003dcount, **kwargs)"},{"line_number":127,"context_line":"        self.sleep_between(min_sleep, max_sleep)"},{"line_number":128,"context_line":"        self._delete_all_servers(force\u003dforce_delete)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3acd31a7_dbf8d94b","line":125,"in_reply_to":"3acd31a7_34648ce2","updated":"2015-05-04 14:26:36.000000000","message":"Done","commit_id":"06070349787ebcbfbd1ee04b5f548f124eb0a382"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"ac3438b32c787149599c1db6573f617c31bca887","unresolved":false,"context_lines":[{"line_number":109,"context_line":"    @validation.required_services(consts.Service.NOVA)"},{"line_number":110,"context_line":"    @validation.required_openstack(admin\u003dTrue, users\u003dTrue)"},{"line_number":111,"context_line":"    @base.scenario(context\u003d{\"cleanup\": [\"nova\"]})"},{"line_number":112,"context_line":"    def boot_and_delete_multiple_servers(self, image, flavor, count\u003d10,"},{"line_number":113,"context_line":"                                         min_sleep\u003d0, max_sleep\u003d0,"},{"line_number":114,"context_line":"                                         force_delete\u003dFalse, **kwargs):"},{"line_number":115,"context_line":"        \"\"\"Boot multiple guests in a single request and delete them."}],"source_content_type":"text/x-python","patch_set":4,"id":"3acd31a7_3057c659","line":112,"updated":"2015-05-05 13:22:08.000000000","message":"There is a sense to reduce default value for count because booting takes a lot of time. For example 2 or 1.","commit_id":"b767002c5e354a260b92c09c83f7d70c0ddf595a"},{"author":{"_account_id":11748,"name":"Chris St. Pierre","email":"cstpierr@cisco.com","username":"stpierre"},"change_message_id":"4ae1a21ff06fd32b4de4c285f152d43c1b22c02f","unresolved":false,"context_lines":[{"line_number":109,"context_line":"    @validation.required_services(consts.Service.NOVA)"},{"line_number":110,"context_line":"    @validation.required_openstack(admin\u003dTrue, users\u003dTrue)"},{"line_number":111,"context_line":"    @base.scenario(context\u003d{\"cleanup\": [\"nova\"]})"},{"line_number":112,"context_line":"    def boot_and_delete_multiple_servers(self, image, flavor, count\u003d10,"},{"line_number":113,"context_line":"                                         min_sleep\u003d0, max_sleep\u003d0,"},{"line_number":114,"context_line":"                                         force_delete\u003dFalse, **kwargs):"},{"line_number":115,"context_line":"        \"\"\"Boot multiple guests in a single request and delete them."}],"source_content_type":"text/x-python","patch_set":4,"id":"3acd31a7_33ca2d4f","line":112,"in_reply_to":"3acd31a7_3057c659","updated":"2015-05-05 13:55:38.000000000","message":"Done","commit_id":"b767002c5e354a260b92c09c83f7d70c0ddf595a"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"ac3438b32c787149599c1db6573f617c31bca887","unresolved":false,"context_lines":[{"line_number":110,"context_line":"    @validation.required_openstack(admin\u003dTrue, users\u003dTrue)"},{"line_number":111,"context_line":"    @base.scenario(context\u003d{\"cleanup\": [\"nova\"]})"},{"line_number":112,"context_line":"    def boot_and_delete_multiple_servers(self, image, flavor, count\u003d10,"},{"line_number":113,"context_line":"                                         min_sleep\u003d0, max_sleep\u003d0,"},{"line_number":114,"context_line":"                                         force_delete\u003dFalse, **kwargs):"},{"line_number":115,"context_line":"        \"\"\"Boot multiple guests in a single request and delete them."},{"line_number":116,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"3acd31a7_00c0f928","line":113,"updated":"2015-05-05 13:22:08.000000000","message":"Maybe to made some non zero sleep by default?","commit_id":"b767002c5e354a260b92c09c83f7d70c0ddf595a"},{"author":{"_account_id":11748,"name":"Chris St. Pierre","email":"cstpierr@cisco.com","username":"stpierre"},"change_message_id":"4ae1a21ff06fd32b4de4c285f152d43c1b22c02f","unresolved":false,"context_lines":[{"line_number":110,"context_line":"    @validation.required_openstack(admin\u003dTrue, users\u003dTrue)"},{"line_number":111,"context_line":"    @base.scenario(context\u003d{\"cleanup\": [\"nova\"]})"},{"line_number":112,"context_line":"    def boot_and_delete_multiple_servers(self, image, flavor, count\u003d10,"},{"line_number":113,"context_line":"                                         min_sleep\u003d0, max_sleep\u003d0,"},{"line_number":114,"context_line":"                                         force_delete\u003dFalse, **kwargs):"},{"line_number":115,"context_line":"        \"\"\"Boot multiple guests in a single request and delete them."},{"line_number":116,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"3acd31a7_f3bf15a8","line":113,"in_reply_to":"3acd31a7_00c0f928","updated":"2015-05-05 13:55:38.000000000","message":"No other scenario that includes a random sleep has a non-zero sleep default.","commit_id":"b767002c5e354a260b92c09c83f7d70c0ddf595a"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"ac3438b32c787149599c1db6573f617c31bca887","unresolved":false,"context_lines":[{"line_number":112,"context_line":"    def boot_and_delete_multiple_servers(self, image, flavor, count\u003d10,"},{"line_number":113,"context_line":"                                         min_sleep\u003d0, max_sleep\u003d0,"},{"line_number":114,"context_line":"                                         force_delete\u003dFalse, **kwargs):"},{"line_number":115,"context_line":"        \"\"\"Boot multiple guests in a single request and delete them."},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"        :param image: The image to boot from"},{"line_number":118,"context_line":"        :param flavor: Flavor used to boot instance"}],"source_content_type":"text/x-python","patch_set":4,"id":"3acd31a7_70e53eda","line":115,"updated":"2015-05-05 13:22:08.000000000","message":"Why \"guests\"? I think it would be better to use server term here.","commit_id":"b767002c5e354a260b92c09c83f7d70c0ddf595a"},{"author":{"_account_id":11748,"name":"Chris St. Pierre","email":"cstpierr@cisco.com","username":"stpierre"},"change_message_id":"4ae1a21ff06fd32b4de4c285f152d43c1b22c02f","unresolved":false,"context_lines":[{"line_number":112,"context_line":"    def boot_and_delete_multiple_servers(self, image, flavor, count\u003d10,"},{"line_number":113,"context_line":"                                         min_sleep\u003d0, max_sleep\u003d0,"},{"line_number":114,"context_line":"                                         force_delete\u003dFalse, **kwargs):"},{"line_number":115,"context_line":"        \"\"\"Boot multiple guests in a single request and delete them."},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"        :param image: The image to boot from"},{"line_number":118,"context_line":"        :param flavor: Flavor used to boot instance"}],"source_content_type":"text/x-python","patch_set":4,"id":"3acd31a7_93e581dd","line":115,"in_reply_to":"3acd31a7_70e53eda","updated":"2015-05-05 13:55:38.000000000","message":"Done","commit_id":"b767002c5e354a260b92c09c83f7d70c0ddf595a"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"ac3438b32c787149599c1db6573f617c31bca887","unresolved":false,"context_lines":[{"line_number":120,"context_line":"        :param min_sleep: Minimum sleep time in seconds (non-negative)"},{"line_number":121,"context_line":"        :param max_sleep: Maximum sleep time in seconds (non-negative)"},{"line_number":122,"context_line":"        :param force_delete: True if force_delete should be used"},{"line_number":123,"context_line":"        :param kwargs: Optional additional arguments for instance creation"},{"line_number":124,"context_line":"        \"\"\""},{"line_number":125,"context_line":"        servers \u003d self._boot_servers("},{"line_number":126,"context_line":"            self._generate_random_name(\"rally_boot_multiple_\"),"}],"source_content_type":"text/x-python","patch_set":4,"id":"3acd31a7_d001b207","line":123,"updated":"2015-05-05 13:22:08.000000000","message":"Optional, additional - I think this two words with the same meaning)","commit_id":"b767002c5e354a260b92c09c83f7d70c0ddf595a"},{"author":{"_account_id":11748,"name":"Chris St. Pierre","email":"cstpierr@cisco.com","username":"stpierre"},"change_message_id":"4ae1a21ff06fd32b4de4c285f152d43c1b22c02f","unresolved":false,"context_lines":[{"line_number":120,"context_line":"        :param min_sleep: Minimum sleep time in seconds (non-negative)"},{"line_number":121,"context_line":"        :param max_sleep: Maximum sleep time in seconds (non-negative)"},{"line_number":122,"context_line":"        :param force_delete: True if force_delete should be used"},{"line_number":123,"context_line":"        :param kwargs: Optional additional arguments for instance creation"},{"line_number":124,"context_line":"        \"\"\""},{"line_number":125,"context_line":"        servers \u003d self._boot_servers("},{"line_number":126,"context_line":"            self._generate_random_name(\"rally_boot_multiple_\"),"}],"source_content_type":"text/x-python","patch_set":4,"id":"3acd31a7_b332bd5d","line":123,"in_reply_to":"3acd31a7_d001b207","updated":"2015-05-05 13:55:38.000000000","message":"Not really. Something can be additional without being optional, and vice-versa. This verbiage is also copied directly from 15 other docstrings in this file alone, and another 10 in other files use the same wording.","commit_id":"b767002c5e354a260b92c09c83f7d70c0ddf595a"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"8a3f09bfbd3eafc0999214b0935aba2a9ed52e18","unresolved":false,"context_lines":[{"line_number":124,"context_line":"        :param kwargs: Optional additional arguments for instance creation"},{"line_number":125,"context_line":"        \"\"\""},{"line_number":126,"context_line":"        servers \u003d self._boot_servers("},{"line_number":127,"context_line":"            self._generate_random_name(\"rally_boot_multiple_\"),"},{"line_number":128,"context_line":"            image, flavor, 1, instances_amount\u003dcount, **kwargs)"},{"line_number":129,"context_line":"        self.sleep_between(min_sleep, max_sleep)"},{"line_number":130,"context_line":"        self._delete_servers(servers, force\u003dforce_delete)"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a0c5dc1_f2351e46","line":127,"updated":"2015-05-13 10:02:16.000000000","message":"During the work on plugins we saw that generation of names should be part of utils not in scenarios..","commit_id":"c72fad07c5712e10c3e3a72006aea58490002d27"},{"author":{"_account_id":11748,"name":"Chris St. Pierre","email":"cstpierr@cisco.com","username":"stpierre"},"change_message_id":"bc6f23364b95ad429226480274b13f29043ae745","unresolved":false,"context_lines":[{"line_number":124,"context_line":"        :param kwargs: Optional additional arguments for instance creation"},{"line_number":125,"context_line":"        \"\"\""},{"line_number":126,"context_line":"        servers \u003d self._boot_servers("},{"line_number":127,"context_line":"            self._generate_random_name(\"rally_boot_multiple_\"),"},{"line_number":128,"context_line":"            image, flavor, 1, instances_amount\u003dcount, **kwargs)"},{"line_number":129,"context_line":"        self.sleep_between(min_sleep, max_sleep)"},{"line_number":130,"context_line":"        self._delete_servers(servers, force\u003dforce_delete)"}],"source_content_type":"text/x-python","patch_set":7,"id":"7a016987_b09c5c6a","line":127,"in_reply_to":"9a0c5dc1_f2351e46","updated":"2015-05-14 17:37:32.000000000","message":"I\u0027ve added another commit as the parent of this change that refactors _boot_servers() to no longer require a name prefix.","commit_id":"c72fad07c5712e10c3e3a72006aea58490002d27"}],"rally/benchmark/scenarios/nova/utils.py":[{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"309d058ca6e93ded2f2fc1c62c0411d35a516136","unresolved":false,"context_lines":[{"line_number":390,"context_line":"        atomic_name \u003d (\"nova.%sdelete_all_servers\") % (force"},{"line_number":391,"context_line":"                                                       and \"force_\" or \"\")"},{"line_number":392,"context_line":"        with base.AtomicAction(self, atomic_name):"},{"line_number":393,"context_line":"            servers \u003d self.clients(\"nova\").servers.list()"},{"line_number":394,"context_line":"            for server in servers:"},{"line_number":395,"context_line":"                if force:"},{"line_number":396,"context_line":"                    server.force_delete()"}],"source_content_type":"text/x-python","patch_set":3,"id":"3acd31a7_f49cd4c1","line":393,"updated":"2015-05-03 14:03:50.000000000","message":"You can\u0027t delete all user\u0027s servers. You should delete only those that were actually created.","commit_id":"06070349787ebcbfbd1ee04b5f548f124eb0a382"},{"author":{"_account_id":11748,"name":"Chris St. Pierre","email":"cstpierr@cisco.com","username":"stpierre"},"change_message_id":"b61b54f9e2a718f78cbc95cb2f00f25004e76b6d","unresolved":false,"context_lines":[{"line_number":390,"context_line":"        atomic_name \u003d (\"nova.%sdelete_all_servers\") % (force"},{"line_number":391,"context_line":"                                                       and \"force_\" or \"\")"},{"line_number":392,"context_line":"        with base.AtomicAction(self, atomic_name):"},{"line_number":393,"context_line":"            servers \u003d self.clients(\"nova\").servers.list()"},{"line_number":394,"context_line":"            for server in servers:"},{"line_number":395,"context_line":"                if force:"},{"line_number":396,"context_line":"                    server.force_delete()"}],"source_content_type":"text/x-python","patch_set":3,"id":"3acd31a7_5b484987","line":393,"in_reply_to":"3acd31a7_f49cd4c1","updated":"2015-05-04 14:26:36.000000000","message":"I\u0027ve added another commit to remove this function altogether, as it\u0027s not used and, as you point out, seems to be The Wrong Thing. I then replace it with a better function that deletes an explicit list of servers, and does it in parallel.","commit_id":"06070349787ebcbfbd1ee04b5f548f124eb0a382"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"309d058ca6e93ded2f2fc1c62c0411d35a516136","unresolved":false,"context_lines":[{"line_number":397,"context_line":"                else:"},{"line_number":398,"context_line":"                    server.delete()"},{"line_number":399,"context_line":""},{"line_number":400,"context_line":"                bench_utils.wait_for_delete("},{"line_number":401,"context_line":"                    server,"},{"line_number":402,"context_line":"                    update_resource\u003dbench_utils.get_from_manager(),"},{"line_number":403,"context_line":"                    timeout\u003dCONF.benchmark.nova_server_delete_timeout,"}],"source_content_type":"text/x-python","patch_set":3,"id":"3acd31a7_d49f98b2","line":400,"updated":"2015-05-03 14:03:50.000000000","message":"You should send request to delete all servers.\nAnd then wait for each of them, not delete one-by-one","commit_id":"06070349787ebcbfbd1ee04b5f548f124eb0a382"},{"author":{"_account_id":11748,"name":"Chris St. Pierre","email":"cstpierr@cisco.com","username":"stpierre"},"change_message_id":"b61b54f9e2a718f78cbc95cb2f00f25004e76b6d","unresolved":false,"context_lines":[{"line_number":397,"context_line":"                else:"},{"line_number":398,"context_line":"                    server.delete()"},{"line_number":399,"context_line":""},{"line_number":400,"context_line":"                bench_utils.wait_for_delete("},{"line_number":401,"context_line":"                    server,"},{"line_number":402,"context_line":"                    update_resource\u003dbench_utils.get_from_manager(),"},{"line_number":403,"context_line":"                    timeout\u003dCONF.benchmark.nova_server_delete_timeout,"}],"source_content_type":"text/x-python","patch_set":3,"id":"3acd31a7_3b60ed00","line":400,"in_reply_to":"3acd31a7_d49f98b2","updated":"2015-05-04 14:26:36.000000000","message":"Done","commit_id":"06070349787ebcbfbd1ee04b5f548f124eb0a382"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"ac3438b32c787149599c1db6573f617c31bca887","unresolved":false,"context_lines":[{"line_number":390,"context_line":"        :param force: If True, force_delete will be used instead of delete."},{"line_number":391,"context_line":"        \"\"\""},{"line_number":392,"context_line":"        atomic_name \u003d (\"nova.%sdelete_servers\") % (force and \"force_\" or \"\")"},{"line_number":393,"context_line":"        with base.AtomicAction(self, atomic_name):"},{"line_number":394,"context_line":"            for server in servers:"},{"line_number":395,"context_line":"                if force:"},{"line_number":396,"context_line":"                    server.force_delete()"}],"source_content_type":"text/x-python","patch_set":4,"id":"3acd31a7_e0ebbd11","line":393,"updated":"2015-05-05 13:22:08.000000000","message":"I\u0027d prefer not to copy code below and try to wrap _delete_server if its possible in:  \n   atomic_name \u003d (\"nova.%sdelete_servers\") % (force and \"force_\" or \"\")\n   with base.AtomicAction(self, atomic_name):\n       for server in servers:\n           _delete_server(self, server, force\u003dforce)\nBut Boris don\u0027t like my idea) Just suggestion if you\u0027d like it","commit_id":"b767002c5e354a260b92c09c83f7d70c0ddf595a"},{"author":{"_account_id":11748,"name":"Chris St. Pierre","email":"cstpierr@cisco.com","username":"stpierre"},"change_message_id":"4ae1a21ff06fd32b4de4c285f152d43c1b22c02f","unresolved":false,"context_lines":[{"line_number":390,"context_line":"        :param force: If True, force_delete will be used instead of delete."},{"line_number":391,"context_line":"        \"\"\""},{"line_number":392,"context_line":"        atomic_name \u003d (\"nova.%sdelete_servers\") % (force and \"force_\" or \"\")"},{"line_number":393,"context_line":"        with base.AtomicAction(self, atomic_name):"},{"line_number":394,"context_line":"            for server in servers:"},{"line_number":395,"context_line":"                if force:"},{"line_number":396,"context_line":"                    server.force_delete()"}],"source_content_type":"text/x-python","patch_set":4,"id":"3acd31a7_f31b95c8","line":393,"in_reply_to":"3acd31a7_e0ebbd11","updated":"2015-05-05 13:55:38.000000000","message":"There used to be a _delete_all_servers() function that did what you\u0027re suggesting, but there are two problems:\n\n1. You get multiple timers running for the same action. In your sample code, for example, you\u0027d have a \"nova.delete_servers\" timer created for the full operation, plus individual timers running for each server deletion, which fouls the results.\n\n2. It forces deletion to be sequential instead of parallel.\n\nIt turns out that both of these problems are difficult to address in code, and the second is particularly intractable.","commit_id":"b767002c5e354a260b92c09c83f7d70c0ddf595a"}],"rally/plugins/openstack/scenarios/nova/servers.py":[{"author":{"_account_id":9601,"name":"Oleh Anufriiev","email":"oanufriev@mirantis.com","username":"oanufriev"},"change_message_id":"0db08b50c48f64849755056c55a2226ca3b2d10e","unresolved":false,"context_lines":[{"line_number":112,"context_line":"    def boot_and_delete_multiple_servers(self, image, flavor, count\u003d2,"},{"line_number":113,"context_line":"                                         min_sleep\u003d0, max_sleep\u003d0,"},{"line_number":114,"context_line":"                                         force_delete\u003dFalse, **kwargs):"},{"line_number":115,"context_line":"        \"\"\"Boot multiple servers in a single request and delete them."},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"        :param image: The image to boot from"},{"line_number":118,"context_line":"        :param flavor: Flavor used to boot instance"}],"source_content_type":"text/x-python","patch_set":13,"id":"7a016987_06b5f62f","line":115,"range":{"start_line":115,"start_character":11,"end_line":115,"end_character":68},"updated":"2015-05-28 01:19:58.000000000","message":"You have to display, that deletion of servers is sequential,\nnot in one request as boot","commit_id":"105865e5bb7f8824a320c68e0ccdaed90f64cf80"},{"author":{"_account_id":11748,"name":"Chris St. Pierre","email":"cstpierr@cisco.com","username":"stpierre"},"change_message_id":"92524323d9aa639b91b7fac9c09cc2b068acef70","unresolved":false,"context_lines":[{"line_number":112,"context_line":"    def boot_and_delete_multiple_servers(self, image, flavor, count\u003d2,"},{"line_number":113,"context_line":"                                         min_sleep\u003d0, max_sleep\u003d0,"},{"line_number":114,"context_line":"                                         force_delete\u003dFalse, **kwargs):"},{"line_number":115,"context_line":"        \"\"\"Boot multiple servers in a single request and delete them."},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"        :param image: The image to boot from"},{"line_number":118,"context_line":"        :param flavor: Flavor used to boot instance"}],"source_content_type":"text/x-python","patch_set":13,"id":"7a016987_c758e758","line":115,"in_reply_to":"7a016987_06b5f62f","updated":"2015-05-28 13:31:06.000000000","message":"Deletion is parallel, but I\u0027ve clarified that it\u0027s multiple requests.","commit_id":"105865e5bb7f8824a320c68e0ccdaed90f64cf80"}],"samples/tasks/scenarios/nova/boot-and-delete-multiple.json":[{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"f253adcb201a9cbd43fa0fe6d73ed3f855910f40","unresolved":false,"context_lines":[{"line_number":2,"context_line":"  \"NovaServers.boot_and_delete_multiple_servers\": ["},{"line_number":3,"context_line":"    {"},{"line_number":4,"context_line":"      \"runner\": {"},{"line_number":5,"context_line":"        \"type\": \"constant\", "},{"line_number":6,"context_line":"        \"concurrency\": 1, "},{"line_number":7,"context_line":"        \"times\": 1"},{"line_number":8,"context_line":"      }, "}],"source_content_type":"application/json","patch_set":4,"id":"3acd31a7_4026f115","line":5,"updated":"2015-05-05 13:26:42.000000000","message":"A lot of redundant spaces.","commit_id":"b767002c5e354a260b92c09c83f7d70c0ddf595a"},{"author":{"_account_id":11748,"name":"Chris St. Pierre","email":"cstpierr@cisco.com","username":"stpierre"},"change_message_id":"4ae1a21ff06fd32b4de4c285f152d43c1b22c02f","unresolved":false,"context_lines":[{"line_number":2,"context_line":"  \"NovaServers.boot_and_delete_multiple_servers\": ["},{"line_number":3,"context_line":"    {"},{"line_number":4,"context_line":"      \"runner\": {"},{"line_number":5,"context_line":"        \"type\": \"constant\", "},{"line_number":6,"context_line":"        \"concurrency\": 1, "},{"line_number":7,"context_line":"        \"times\": 1"},{"line_number":8,"context_line":"      }, "}],"source_content_type":"application/json","patch_set":4,"id":"3acd31a7_938101c6","line":5,"in_reply_to":"3acd31a7_4026f115","updated":"2015-05-05 13:55:38.000000000","message":"Done","commit_id":"b767002c5e354a260b92c09c83f7d70c0ddf595a"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"77974d6b21d8a10a9984b74b9deda4063ad42d22","unresolved":false,"context_lines":[{"line_number":9,"context_line":"      \"args\": {"},{"line_number":10,"context_line":"        \"count\": 5,"},{"line_number":11,"context_line":"        \"image\": {"},{"line_number":12,"context_line":"          \"name\": \"cirros-0.3.4-x86_64-uec\""},{"line_number":13,"context_line":"        },"},{"line_number":14,"context_line":"        \"flavor\": {"},{"line_number":15,"context_line":"          \"name\": \"m1.tiny\""}],"source_content_type":"application/json","patch_set":7,"id":"9a0c5dc1_14f6678f","line":12,"updated":"2015-05-13 06:43:26.000000000","message":"same here","commit_id":"c72fad07c5712e10c3e3a72006aea58490002d27"},{"author":{"_account_id":11748,"name":"Chris St. Pierre","email":"cstpierr@cisco.com","username":"stpierre"},"change_message_id":"bc6f23364b95ad429226480274b13f29043ae745","unresolved":false,"context_lines":[{"line_number":9,"context_line":"      \"args\": {"},{"line_number":10,"context_line":"        \"count\": 5,"},{"line_number":11,"context_line":"        \"image\": {"},{"line_number":12,"context_line":"          \"name\": \"cirros-0.3.4-x86_64-uec\""},{"line_number":13,"context_line":"        },"},{"line_number":14,"context_line":"        \"flavor\": {"},{"line_number":15,"context_line":"          \"name\": \"m1.tiny\""}],"source_content_type":"application/json","patch_set":7,"id":"7a016987_b0aa1c6f","line":12,"in_reply_to":"9a0c5dc1_14f6678f","updated":"2015-05-14 17:37:32.000000000","message":"Done","commit_id":"c72fad07c5712e10c3e3a72006aea58490002d27"}],"samples/tasks/scenarios/nova/boot-and-delete-multiple.yaml":[{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"f253adcb201a9cbd43fa0fe6d73ed3f855910f40","unresolved":false,"context_lines":[{"line_number":3,"context_line":"    -"},{"line_number":4,"context_line":"      args:"},{"line_number":5,"context_line":"        image:"},{"line_number":6,"context_line":"          name: cirros-0.3.2-x86_64-uec"},{"line_number":7,"context_line":"        flavor:"},{"line_number":8,"context_line":"          name: m1.itsybitsy"},{"line_number":9,"context_line":"        count: 10"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3acd31a7_a0e6e5ad","line":6,"updated":"2015-05-05 13:26:42.000000000","message":"Please take it to double quotes.","commit_id":"b767002c5e354a260b92c09c83f7d70c0ddf595a"},{"author":{"_account_id":11748,"name":"Chris St. Pierre","email":"cstpierr@cisco.com","username":"stpierre"},"change_message_id":"4ae1a21ff06fd32b4de4c285f152d43c1b22c02f","unresolved":false,"context_lines":[{"line_number":3,"context_line":"    -"},{"line_number":4,"context_line":"      args:"},{"line_number":5,"context_line":"        image:"},{"line_number":6,"context_line":"          name: cirros-0.3.2-x86_64-uec"},{"line_number":7,"context_line":"        flavor:"},{"line_number":8,"context_line":"          name: m1.itsybitsy"},{"line_number":9,"context_line":"        count: 10"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3acd31a7_d362d93d","line":6,"in_reply_to":"3acd31a7_a0e6e5ad","updated":"2015-05-05 13:55:38.000000000","message":"Done","commit_id":"b767002c5e354a260b92c09c83f7d70c0ddf595a"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"f253adcb201a9cbd43fa0fe6d73ed3f855910f40","unresolved":false,"context_lines":[{"line_number":5,"context_line":"        image:"},{"line_number":6,"context_line":"          name: cirros-0.3.2-x86_64-uec"},{"line_number":7,"context_line":"        flavor:"},{"line_number":8,"context_line":"          name: m1.itsybitsy"},{"line_number":9,"context_line":"        count: 10"},{"line_number":10,"context_line":"      runner:"},{"line_number":11,"context_line":"        type: \"constant\""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3acd31a7_c0c321ec","line":8,"updated":"2015-05-05 13:26:42.000000000","message":"Same here. Use here some value from gate please m1.tiny for example","commit_id":"b767002c5e354a260b92c09c83f7d70c0ddf595a"},{"author":{"_account_id":11748,"name":"Chris St. Pierre","email":"cstpierr@cisco.com","username":"stpierre"},"change_message_id":"4ae1a21ff06fd32b4de4c285f152d43c1b22c02f","unresolved":false,"context_lines":[{"line_number":5,"context_line":"        image:"},{"line_number":6,"context_line":"          name: cirros-0.3.2-x86_64-uec"},{"line_number":7,"context_line":"        flavor:"},{"line_number":8,"context_line":"          name: m1.itsybitsy"},{"line_number":9,"context_line":"        count: 10"},{"line_number":10,"context_line":"      runner:"},{"line_number":11,"context_line":"        type: \"constant\""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3acd31a7_53dec9dd","line":8,"in_reply_to":"3acd31a7_c0c321ec","updated":"2015-05-05 13:55:38.000000000","message":"Quotes added.\n\nSince this file isn\u0027t used in gate, I\u0027m not sure I see the value of using m1.tiny. Instead, this is able to serve as an example of the flavors context, and also uses a much smaller flavor, which is handy when booting large numbers of instances.","commit_id":"b767002c5e354a260b92c09c83f7d70c0ddf595a"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"8397991e1ba8e3ccbd1b0fba2a6fae2c098dd2cf","unresolved":false,"context_lines":[{"line_number":5,"context_line":"        image:"},{"line_number":6,"context_line":"          name: \"cirros-0.3.2-x86_64-uec\""},{"line_number":7,"context_line":"        flavor:"},{"line_number":8,"context_line":"          name: \"m1.itsybitsy\""},{"line_number":9,"context_line":"        count: 10"},{"line_number":10,"context_line":"      runner:"},{"line_number":11,"context_line":"        type: \"constant\""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"1aca2d91_079d0159","line":8,"updated":"2015-05-07 13:25:36.000000000","message":"For functional testing of samples on gates we need to use flavors that are exists in gate. So we need to change to some flavor from gates. Patch that allow you to test functional samples is here https://review.openstack.org/#/c/163870/","commit_id":"2c6c34eeb389d0b7084f0ff1a900bab40daee394"},{"author":{"_account_id":11748,"name":"Chris St. Pierre","email":"cstpierr@cisco.com","username":"stpierre"},"change_message_id":"89dc74e470ce6b93564e868132e190de95d23fda","unresolved":false,"context_lines":[{"line_number":5,"context_line":"        image:"},{"line_number":6,"context_line":"          name: \"cirros-0.3.2-x86_64-uec\""},{"line_number":7,"context_line":"        flavor:"},{"line_number":8,"context_line":"          name: \"m1.itsybitsy\""},{"line_number":9,"context_line":"        count: 10"},{"line_number":10,"context_line":"      runner:"},{"line_number":11,"context_line":"        type: \"constant\""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"1aca2d91_1ade743f","line":8,"in_reply_to":"1aca2d91_079d0159","updated":"2015-05-07 13:41:23.000000000","message":"This already uses a flavor context to create the m1.itsybitsy flavor.\n\nI guess the other possibility would be to create just 2 m1.tiny instances, but that seems to prioritize the wrong thing -- i.e., it optimizes the samples to pass gate, rather than to be useful samples.","commit_id":"2c6c34eeb389d0b7084f0ff1a900bab40daee394"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"77974d6b21d8a10a9984b74b9deda4063ad42d22","unresolved":false,"context_lines":[{"line_number":3,"context_line":"    -"},{"line_number":4,"context_line":"      args:"},{"line_number":5,"context_line":"        image:"},{"line_number":6,"context_line":"          name: \"cirros-0.3.4-x86_64-uec\""},{"line_number":7,"context_line":"        flavor:"},{"line_number":8,"context_line":"          name: \"m1.tiny\""},{"line_number":9,"context_line":"        count: 5"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"9a0c5dc1_74fec36c","line":6,"updated":"2015-05-13 06:43:26.000000000","message":"There is no such flavor on Gate so we would be unable to test functional samples on it. Please change it to {{{image_name}}} or some exist image on gate.","commit_id":"c72fad07c5712e10c3e3a72006aea58490002d27"},{"author":{"_account_id":11748,"name":"Chris St. Pierre","email":"cstpierr@cisco.com","username":"stpierre"},"change_message_id":"bc6f23364b95ad429226480274b13f29043ae745","unresolved":false,"context_lines":[{"line_number":3,"context_line":"    -"},{"line_number":4,"context_line":"      args:"},{"line_number":5,"context_line":"        image:"},{"line_number":6,"context_line":"          name: \"cirros-0.3.4-x86_64-uec\""},{"line_number":7,"context_line":"        flavor:"},{"line_number":8,"context_line":"          name: \"m1.tiny\""},{"line_number":9,"context_line":"        count: 5"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"7a016987_f0a09492","line":6,"in_reply_to":"9a0c5dc1_323856a0","updated":"2015-05-14 17:37:32.000000000","message":"Done","commit_id":"c72fad07c5712e10c3e3a72006aea58490002d27"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"2df9aeec38dc1f20d03962d0ba7317e5415afcb6","unresolved":false,"context_lines":[{"line_number":3,"context_line":"    -"},{"line_number":4,"context_line":"      args:"},{"line_number":5,"context_line":"        image:"},{"line_number":6,"context_line":"          name: \"cirros-0.3.4-x86_64-uec\""},{"line_number":7,"context_line":"        flavor:"},{"line_number":8,"context_line":"          name: \"m1.tiny\""},{"line_number":9,"context_line":"        count: 5"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"9a0c5dc1_323856a0","line":6,"in_reply_to":"9a0c5dc1_74fec36c","updated":"2015-05-13 09:51:54.000000000","message":"We should use regexp here: \n  \n  ^cirros.*uec$\n\notherwise it will get out of date soon.","commit_id":"c72fad07c5712e10c3e3a72006aea58490002d27"}]}
