)]}'
{"rally/benchmark/validation.py":[{"author":{"_account_id":8576,"name":"Yair Fried","email":"yfried@redhat.com","username":"yfried"},"change_message_id":"1481716c168cd63575161d95c1fbbe6f4050bfcd","unresolved":false,"context_lines":[{"line_number":129,"context_line":"            % {\"name\": param_name, \"val\": val, \"type\": num_func.__name__})"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"def _file_access_ok(file_name, mode, param_name, required\u003dTrue):"},{"line_number":133,"context_line":"    if not file_name:"},{"line_number":134,"context_line":"        return ValidationResult("},{"line_number":135,"context_line":"            not required,"}],"source_content_type":"text/x-python","patch_set":4,"id":"7ad32947_b9347b4a","line":132,"updated":"2015-04-27 14:06:43.000000000","message":"nit: \"file_accessible\" seems like a better name, IMO","commit_id":"3a55713348eca4985c99ce9e33e67225da89eec2"},{"author":{"_account_id":7369,"name":"Sergey Skripnick","email":"sskripnick@mirantis.com","username":"redixin"},"change_message_id":"336f8ce4480505a1df8dc01e9c1401a96079e5e3","unresolved":false,"context_lines":[{"line_number":129,"context_line":"            % {\"name\": param_name, \"val\": val, \"type\": num_func.__name__})"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"def _file_access_ok(file_name, mode, param_name, required\u003dTrue):"},{"line_number":133,"context_line":"    if not file_name:"},{"line_number":134,"context_line":"        return ValidationResult("},{"line_number":135,"context_line":"            not required,"}],"source_content_type":"text/x-python","patch_set":5,"id":"5ad0253b_6d41590b","line":132,"updated":"2015-04-29 11:23:02.000000000","message":"Is this function going to be used somewhere else?\n\nFunction file_exists does nothing but calling this function. Maybe 1 function is enough?","commit_id":"451e6603e29c3cd3e0b2e6439e9127c2172219b1"},{"author":{"_account_id":13609,"name":"Pavel Boldin","email":"pboldin@mirantis.com","username":"pboldin"},"change_message_id":"5ed2f6472c39e0301a8202c530bec30de67c93ac","unresolved":false,"context_lines":[{"line_number":129,"context_line":"            % {\"name\": param_name, \"val\": val, \"type\": num_func.__name__})"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"def _file_access_ok(file_name, mode, param_name, required\u003dTrue):"},{"line_number":133,"context_line":"    if not file_name:"},{"line_number":134,"context_line":"        return ValidationResult("},{"line_number":135,"context_line":"            not required,"}],"source_content_type":"text/x-python","patch_set":5,"id":"5ad0253b_8da6f5bf","line":132,"in_reply_to":"5ad0253b_6d41590b","updated":"2015-04-29 11:26:21.000000000","message":"Yes, in the following `valid_command\u0027 validator: https://review.openstack.org/#/c/177012/7/rally/benchmark/validation.py,cm\n\nHowever, we can introduce it this patch instead.\n\nThe bad thing about gerrit is that it is unable to show you a patchset as a whole.","commit_id":"451e6603e29c3cd3e0b2e6439e9127c2172219b1"}]}