)]}'
{"rally-jobs/rally-neutron.yaml":[{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"e784f0e059be2878b93896e0ba07ebb76575f813","unresolved":false,"context_lines":[{"line_number":864,"context_line":"        image:"},{"line_number":865,"context_line":"            name: {{image_name}}"},{"line_number":866,"context_line":"        script: \"/home/jenkins/.rally/extra/instance_dd_test.sh\""},{"line_number":867,"context_line":"        interpreter: \"/bin/sh\""},{"line_number":868,"context_line":"        username: \"cirros\""},{"line_number":869,"context_line":"      runner:"},{"line_number":870,"context_line":"        type: \"constant\""}],"source_content_type":"text/x-yaml","patch_set":9,"id":"7a016987_7846bf24","side":"PARENT","line":867,"updated":"2015-05-15 00:00:47.000000000","message":"You can\u0027t just remove this. We need to test that old way works as well. Just add one more scenario","commit_id":"b07d8399501d0e5109db641f2a1e0422141a01e3"}],"rally/benchmark/validation.py":[{"author":{"_account_id":8576,"name":"Yair Fried","email":"yfried@redhat.com","username":"yfried"},"change_message_id":"fea8a3fbd474a7aeb32a49c92cb91bb68fb2b687","unresolved":false,"context_lines":[{"line_number":191,"context_line":"    \"\"\"Checks that parameter is a proper command-specifying dictionary."},{"line_number":192,"context_line":""},{"line_number":193,"context_line":"    Ensure that the command dictionary is a proper command-specifying"},{"line_number":194,"context_line":"    dictionary described in `vmtasks.VMTasks.boot_runcommand_delete\u0027 docstring."},{"line_number":195,"context_line":""},{"line_number":196,"context_line":"    :param param_name: Name of parameter to validate"},{"line_number":197,"context_line":"    :param required: Boolean indicating that the command dictionary is required"}],"source_content_type":"text/x-python","patch_set":21,"id":"3afb71cf_4d9258f7","line":194,"updated":"2015-06-11 12:31:59.000000000","message":"please keep the docstring.\nI worry about code duplication. I\u0027m ok with doc duplication.","commit_id":"4da86acc381ae3c73f0bc76e5a0883a9242ade2b"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"05d3c2d905502804876f70d500e320443d7e42f6","unresolved":false,"context_lines":[{"line_number":191,"context_line":"    \"\"\"Checks that parameter is a proper command-specifying dictionary."},{"line_number":192,"context_line":""},{"line_number":193,"context_line":"    Ensure that the command dictionary is a proper command-specifying"},{"line_number":194,"context_line":"    dictionary described in `vmtasks.VMTasks.boot_runcommand_delete\u0027 docstring."},{"line_number":195,"context_line":""},{"line_number":196,"context_line":"    :param param_name: Name of parameter to validate"},{"line_number":197,"context_line":"    :param required: Boolean indicating that the command dictionary is required"}],"source_content_type":"text/x-python","patch_set":21,"id":"fa32b979_0a8b1869","line":194,"in_reply_to":"1af86dd1_b3ad7f8a","updated":"2015-06-18 08:37:03.000000000","message":"I think this should be kept, there are other places refer this: \n\nhttps://github.com/openstack/rally/blob/master/rally/plugins/openstack/scenarios/vm/utils.py#L50, \n\nhttps://github.com/openstack/rally/blob/master/rally/plugins/openstack/scenarios/vm/utils.py#L153","commit_id":"4da86acc381ae3c73f0bc76e5a0883a9242ade2b"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"e9308a1b411101880eb1d4834f8c1c4ed06cf5f5","unresolved":false,"context_lines":[{"line_number":191,"context_line":"    \"\"\"Checks that parameter is a proper command-specifying dictionary."},{"line_number":192,"context_line":""},{"line_number":193,"context_line":"    Ensure that the command dictionary is a proper command-specifying"},{"line_number":194,"context_line":"    dictionary described in `vmtasks.VMTasks.boot_runcommand_delete\u0027 docstring."},{"line_number":195,"context_line":""},{"line_number":196,"context_line":"    :param param_name: Name of parameter to validate"},{"line_number":197,"context_line":"    :param required: Boolean indicating that the command dictionary is required"}],"source_content_type":"text/x-python","patch_set":21,"id":"1af86dd1_b3ad7f8a","line":194,"in_reply_to":"3afb71cf_4d9258f7","updated":"2015-06-13 00:35:27.000000000","message":"I don\u0027t agree, it\u0027s better to refer to other place than to keep in two places same docs","commit_id":"4da86acc381ae3c73f0bc76e5a0883a9242ade2b"},{"author":{"_account_id":13609,"name":"Pavel Boldin","email":"pboldin@mirantis.com","username":"pboldin"},"change_message_id":"632458829a139ca4a9168c21e9b4f3b478814a31","unresolved":false,"context_lines":[{"line_number":191,"context_line":"    \"\"\"Checks that parameter is a proper command-specifying dictionary."},{"line_number":192,"context_line":""},{"line_number":193,"context_line":"    Ensure that the command dictionary is a proper command-specifying"},{"line_number":194,"context_line":"    dictionary described in `vmtasks.VMTasks.boot_runcommand_delete\u0027 docstring."},{"line_number":195,"context_line":""},{"line_number":196,"context_line":"    :param param_name: Name of parameter to validate"},{"line_number":197,"context_line":"    :param required: Boolean indicating that the command dictionary is required"}],"source_content_type":"text/x-python","patch_set":21,"id":"fa32b979_94f28d6e","line":194,"in_reply_to":"fa32b979_0a8b1869","updated":"2015-06-20 18:14:12.000000000","message":"Well, this should be fixed in the other parts to refer directly to the boot_runcommand_delete doc.\n\nBut I welcome you to HTTP 301 code.","commit_id":"4da86acc381ae3c73f0bc76e5a0883a9242ade2b"}],"rally/plugins/openstack/scenarios/vm/vmtasks.py":[{"author":{"_account_id":8576,"name":"Yair Fried","email":"yfried@redhat.com","username":"yfried"},"change_message_id":"4a2924c704e91aecc2723bc45bb2b464ae74f72d","unresolved":false,"context_lines":[{"line_number":72,"context_line":"                       below)"},{"line_number":73,"context_line":"        :param interpreter: DEPRECATED. server\u0027s interpreter to run the script"},{"line_number":74,"context_line":"        :param command: Command-specifying dictionary. See docstring of the"},{"line_number":75,"context_line":"                        `validation.valid_command\u0027 for details."},{"line_number":76,"context_line":"        :param volume_args: volume args for booting server from volume"},{"line_number":77,"context_line":"        :param floating_network: external network name, for floating ip"},{"line_number":78,"context_line":"        :param port: ssh port for SSH connection"}],"source_content_type":"text/x-python","patch_set":18,"id":"3afb71cf_54010304","line":75,"updated":"2015-06-10 06:17:39.000000000","message":"I don\u0027t like a docstring that point to different one, instead of doc\u0027ing. Esp since this doc is displayed in \"rally info\" output and the other isn\u0027t.","commit_id":"9249db8c61ab625188dd7d289aa569b7934931a4"},{"author":{"_account_id":13609,"name":"Pavel Boldin","email":"pboldin@mirantis.com","username":"pboldin"},"change_message_id":"9e1ec6c96c01185565bc1465be7398140a3e7d57","unresolved":false,"context_lines":[{"line_number":72,"context_line":"                       below)"},{"line_number":73,"context_line":"        :param interpreter: DEPRECATED. server\u0027s interpreter to run the script"},{"line_number":74,"context_line":"        :param command: Command-specifying dictionary. See docstring of the"},{"line_number":75,"context_line":"                        `validation.valid_command\u0027 for details."},{"line_number":76,"context_line":"        :param volume_args: volume args for booting server from volume"},{"line_number":77,"context_line":"        :param floating_network: external network name, for floating ip"},{"line_number":78,"context_line":"        :param port: ssh port for SSH connection"}],"source_content_type":"text/x-python","patch_set":18,"id":"3afb71cf_6e31b959","line":75,"in_reply_to":"3afb71cf_54010304","updated":"2015-06-10 15:43:43.000000000","message":"Good point.\n\nI think I will just copy the docstring over here removing it from the `valid_command\u0027.","commit_id":"9249db8c61ab625188dd7d289aa569b7934931a4"},{"author":{"_account_id":11748,"name":"Chris St. Pierre","email":"cstpierr@cisco.com","username":"stpierre"},"change_message_id":"24610fe93c511a77a0f180b35f983dfb8be943b0","unresolved":false,"context_lines":[{"line_number":139,"context_line":"                fip[\"ip\"], port, username, password, command\u003dcommand)"},{"line_number":140,"context_line":"            if code:"},{"line_number":141,"context_line":"                raise exceptions.ScriptError("},{"line_number":142,"context_line":"                    \"Error running command %(command)s. \""},{"line_number":143,"context_line":"                    \"Error %(code)s: %(error)s\" % {"},{"line_number":144,"context_line":"                        \"command\": command, \"code\": code, \"error\": err})"},{"line_number":145,"context_line":""}],"source_content_type":"text/x-python","patch_set":25,"id":"9a41bdd9_b4545121","line":142,"updated":"2015-07-13 15:36:42.000000000","message":"Particularly where command is an inline script, this (and the ScriptError below) will be very difficult to read. It\u0027d be nicer IMO to give a friendly error message (\"Error running script \u003cfilename\u003e\" or \"Error running inline script\", for instance), and then set an attribute on the exception with the inline script that was run, and let the presentation layer take care of printing the script out. This might require subclassing ScriptError (InlineScriptError?).","commit_id":"4912279a844c83c533c25fb4aa1ac371d5e5af32"}]}
