)]}'
{"rally/benchmark/scenarios/vm/utils.py":[{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"3804ecbb75e26442c85c3d498787cb948c488b68","unresolved":false,"context_lines":[{"line_number":69,"context_line":"            ssh.put_file(command[\"local_path\"], remote_path, 0o777)"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"        if \"command_args\" in command:"},{"line_number":72,"context_line":"            if not isinstance(cmd, (list, tuple)):"},{"line_number":73,"context_line":"                cmd \u003d [cmd]"},{"line_number":74,"context_line":"            cmd \u003d cmd + list(command[\"command_args\"])"},{"line_number":75,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"7a016987_d8b6d3db","line":72,"updated":"2015-05-15 00:14:00.000000000","message":"Please don\u0027t do the checking in such way. \n\n  isinstance(cmd, collections.Iterable)\n\nis much better","commit_id":"45a6de6f7102cb8baa0a25c6a5a6279355b7a848"},{"author":{"_account_id":13609,"name":"Pavel Boldin","email":"pboldin@mirantis.com","username":"pboldin"},"change_message_id":"f9ec9e4d0c901a959391416d5bc501546dd18119","unresolved":false,"context_lines":[{"line_number":69,"context_line":"            ssh.put_file(command[\"local_path\"], remote_path, 0o777)"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"        if \"command_args\" in command:"},{"line_number":72,"context_line":"            if not isinstance(cmd, (list, tuple)):"},{"line_number":73,"context_line":"                cmd \u003d [cmd]"},{"line_number":74,"context_line":"            cmd \u003d cmd + list(command[\"command_args\"])"},{"line_number":75,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"7a016987_956819f7","line":72,"in_reply_to":"7a016987_d8b6d3db","updated":"2015-05-15 09:00:59.000000000","message":"\u003e\u003e\u003e isinstance(\"\", collections.Iterable)\n True","commit_id":"45a6de6f7102cb8baa0a25c6a5a6279355b7a848"}],"rally/plugins/openstack/scenarios/vm/utils.py":[{"author":{"_account_id":11748,"name":"Chris St. Pierre","email":"cstpierr@cisco.com","username":"stpierre"},"change_message_id":"bcbd8e8d4a86f307122fe5e419746253eb276818","unresolved":false,"context_lines":[{"line_number":77,"context_line":"        if command.get(\"command_args\"):"},{"line_number":78,"context_line":"            if not isinstance(cmd, (list, tuple)):"},{"line_number":79,"context_line":"                cmd \u003d [cmd]"},{"line_number":80,"context_line":"            cmd \u003d cmd + list(command[\"command_args\"])"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"        return ssh.execute(cmd, stdin\u003dstdin)"},{"line_number":83,"context_line":""}],"source_content_type":"text/x-python","patch_set":26,"id":"9a41bdd9_2aec5a8e","line":80,"updated":"2015-07-13 16:05:09.000000000","message":"It took me a while to understand this block, largely because \u0027cmd\u0027 is modified so much (and can have so many different values) in this function. A nice big comment here would be very nice.","commit_id":"5707ae69ac2adec4d90ca921501851b26d6e03de"}],"samples/tasks/support/instance_dd_test.sh":[{"author":{"_account_id":11748,"name":"Chris St. Pierre","email":"cstpierr@cisco.com","username":"stpierre"},"change_message_id":"bcbd8e8d4a86f307122fe5e419746253eb276818","unresolved":false,"context_lines":[{"line_number":2,"context_line":"time_seconds(){ (time -p $1 ) 2\u003e\u00261 |awk \u0027/real/{print $2}\u0027; }"},{"line_number":3,"context_line":"file\u003d/tmp/test.img"},{"line_number":4,"context_line":"c\u003d${1}"},{"line_number":5,"context_line":"c\u003d${c:-$SIZE}"},{"line_number":6,"context_line":"c\u003d${c:-1000} #default is 1GB"},{"line_number":7,"context_line":"write_seq\u003d$(time_seconds \"dd if\u003d/dev/zero of\u003d$file bs\u003d1M count\u003d$c\")"},{"line_number":8,"context_line":"read_seq\u003d$(time_seconds \"dd if\u003d$file of\u003d/dev/null bs\u003d1M count\u003d$c\")"}],"source_content_type":"text/x-sh","patch_set":26,"id":"9a41bdd9_2a71bae0","line":5,"updated":"2015-07-13 16:05:09.000000000","message":"Nit: These two lines could be:\n\n    c\u003d${1:-$SIZE}","commit_id":"5707ae69ac2adec4d90ca921501851b26d6e03de"}]}
