)]}'
{"rally/osclients.py":[{"author":{"_account_id":13609,"name":"Pavel Boldin","email":"pboldin@mirantis.com","username":"pboldin"},"change_message_id":"10fff78f460835842b6950460237b8dee39df1b5","unresolved":false,"context_lines":[{"line_number":434,"context_line":"def register(client_name, client_func):"},{"line_number":435,"context_line":"    \"\"\"Add new OpenStack client dynamically."},{"line_number":436,"context_line":""},{"line_number":437,"context_line":"    :param client_name: str name how client will be named in Rally clients"},{"line_number":438,"context_line":"    :param client_func: function that implememnts client spawning."},{"line_number":439,"context_line":"                        It will be added to Clients in runtime, so its"},{"line_number":440,"context_line":"                        sole argument is Clients instance"}],"source_content_type":"text/x-python","patch_set":1,"id":"7ad32947_76a02591","line":437,"updated":"2015-04-27 17:18:05.000000000","message":"\u0027name\u0027 is not checked to be a string.\n\nIt can be \u0027unicode\u0027 as well and still suffice for \u0027setattr\u0027 call.","commit_id":"3b91a410df55ef7d7b957cac14029d10d9b4f9f0"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"1b091528205f44bba7cdf8bc80f7ea6e1f134d15","unresolved":false,"context_lines":[{"line_number":434,"context_line":"def register(client_name, client_func):"},{"line_number":435,"context_line":"    \"\"\"Add new OpenStack client dynamically."},{"line_number":436,"context_line":""},{"line_number":437,"context_line":"    :param client_name: str name how client will be named in Rally clients"},{"line_number":438,"context_line":"    :param client_func: function that implememnts client spawning."},{"line_number":439,"context_line":"                        It will be added to Clients in runtime, so its"},{"line_number":440,"context_line":"                        sole argument is Clients instance"}],"source_content_type":"text/x-python","patch_set":1,"id":"3acd31a7_27dca0e3","line":437,"in_reply_to":"7ad32947_76a02591","updated":"2015-04-30 10:11:04.000000000","message":"This is not critical","commit_id":"3b91a410df55ef7d7b957cac14029d10d9b4f9f0"},{"author":{"_account_id":13609,"name":"Pavel Boldin","email":"pboldin@mirantis.com","username":"pboldin"},"change_message_id":"10fff78f460835842b6950460237b8dee39df1b5","unresolved":false,"context_lines":[{"line_number":440,"context_line":"                        sole argument is Clients instance"},{"line_number":441,"context_line":""},{"line_number":442,"context_line":"    Example:"},{"line_number":443,"context_line":"      \u003e\u003e\u003e def supernova(self):"},{"line_number":444,"context_line":"      ...   from novaclient import client as nova"},{"line_number":445,"context_line":"      ...   return nova.Client(\"2\", auth_token\u003dself.keystone().auth_token,"},{"line_number":446,"context_line":"      ...                      **self._get_auth_info(password_key\u003d\"api_key\"))"}],"source_content_type":"text/x-python","patch_set":1,"id":"7ad32947_36aaad71","line":443,"updated":"2015-04-27 17:18:05.000000000","message":"Is that a doctest? If it is, then: don\u0027t change indentation, call for a doctest.","commit_id":"3b91a410df55ef7d7b957cac14029d10d9b4f9f0"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"1b091528205f44bba7cdf8bc80f7ea6e1f134d15","unresolved":false,"context_lines":[{"line_number":440,"context_line":"                        sole argument is Clients instance"},{"line_number":441,"context_line":""},{"line_number":442,"context_line":"    Example:"},{"line_number":443,"context_line":"      \u003e\u003e\u003e def supernova(self):"},{"line_number":444,"context_line":"      ...   from novaclient import client as nova"},{"line_number":445,"context_line":"      ...   return nova.Client(\"2\", auth_token\u003dself.keystone().auth_token,"},{"line_number":446,"context_line":"      ...                      **self._get_auth_info(password_key\u003d\"api_key\"))"}],"source_content_type":"text/x-python","patch_set":1,"id":"3acd31a7_81bfe4cf","line":443,"in_reply_to":"7ad32947_36aaad71","updated":"2015-04-30 10:11:04.000000000","message":"We do not use doctests in Rally","commit_id":"3b91a410df55ef7d7b957cac14029d10d9b4f9f0"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"17fc26d0c68c6e40dff1230caed64fb164e22b0d","unresolved":false,"context_lines":[{"line_number":431,"context_line":"        return services_data"},{"line_number":432,"context_line":""},{"line_number":433,"context_line":""},{"line_number":434,"context_line":"def register(client_name, client_func):"},{"line_number":435,"context_line":"    \"\"\"Add new OpenStack client dynamically."},{"line_number":436,"context_line":""},{"line_number":437,"context_line":"    :param client_name: str name how client will be named in Rally clients"}],"source_content_type":"text/x-python","patch_set":3,"id":"3acd31a7_633c90c8","line":434,"updated":"2015-05-03 02:55:53.000000000","message":"I will put this into Clients class and inside this method I will use cls then.","commit_id":"95066319dbd78827e01587f96f7c3470e9178995"}],"tests/unit/test_osclients.py":[{"author":{"_account_id":13609,"name":"Pavel Boldin","email":"pboldin@mirantis.com","username":"pboldin"},"change_message_id":"10fff78f460835842b6950460237b8dee39df1b5","unresolved":false,"context_lines":[{"line_number":473,"context_line":"    def test_register(self, mock_cached):"},{"line_number":474,"context_line":"        client_func \u003d mock.Mock(return_value\u003d\"foo_client\")"},{"line_number":475,"context_line":"        cached_client_func \u003d mock.Mock(return_value\u003d\"cached_foo_client\")"},{"line_number":476,"context_line":"        mock_cached.side_effect \u003d lambda func: cached_client_func"},{"line_number":477,"context_line":"        clients \u003d osclients.Clients(mock.Mock())"},{"line_number":478,"context_line":""},{"line_number":479,"context_line":"        self.assertFalse(hasattr(clients, \"foo\"))"}],"source_content_type":"text/x-python","patch_set":1,"id":"7ad32947_f62f95f4","line":476,"updated":"2015-04-27 17:18:05.000000000","message":"Why not \u0027return_value \u003d\u0027?","commit_id":"3b91a410df55ef7d7b957cac14029d10d9b4f9f0"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"1b091528205f44bba7cdf8bc80f7ea6e1f134d15","unresolved":false,"context_lines":[{"line_number":473,"context_line":"    def test_register(self, mock_cached):"},{"line_number":474,"context_line":"        client_func \u003d mock.Mock(return_value\u003d\"foo_client\")"},{"line_number":475,"context_line":"        cached_client_func \u003d mock.Mock(return_value\u003d\"cached_foo_client\")"},{"line_number":476,"context_line":"        mock_cached.side_effect \u003d lambda func: cached_client_func"},{"line_number":477,"context_line":"        clients \u003d osclients.Clients(mock.Mock())"},{"line_number":478,"context_line":""},{"line_number":479,"context_line":"        self.assertFalse(hasattr(clients, \"foo\"))"}],"source_content_type":"text/x-python","patch_set":1,"id":"3acd31a7_61b4c8f1","line":476,"in_reply_to":"7ad32947_f62f95f4","updated":"2015-04-30 10:11:04.000000000","message":"Agreed","commit_id":"3b91a410df55ef7d7b957cac14029d10d9b4f9f0"},{"author":{"_account_id":13609,"name":"Pavel Boldin","email":"pboldin@mirantis.com","username":"pboldin"},"change_message_id":"10fff78f460835842b6950460237b8dee39df1b5","unresolved":false,"context_lines":[{"line_number":481,"context_line":"        osclients.register(\"foo\", client_func)"},{"line_number":482,"context_line":""},{"line_number":483,"context_line":"        mock_cached.assert_called_once_with(client_func)"},{"line_number":484,"context_line":"        self.assertEqual(clients.foo(), \"cached_foo_client\")"},{"line_number":485,"context_line":"        self.assertEqual(clients.foo, cached_client_func)"},{"line_number":486,"context_line":""},{"line_number":487,"context_line":"        # Call second time with same name"}],"source_content_type":"text/x-python","patch_set":1,"id":"7ad32947_56dbe91b","line":484,"updated":"2015-04-27 17:18:05.000000000","message":"is the order of arguments correct?","commit_id":"3b91a410df55ef7d7b957cac14029d10d9b4f9f0"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"1b091528205f44bba7cdf8bc80f7ea6e1f134d15","unresolved":false,"context_lines":[{"line_number":481,"context_line":"        osclients.register(\"foo\", client_func)"},{"line_number":482,"context_line":""},{"line_number":483,"context_line":"        mock_cached.assert_called_once_with(client_func)"},{"line_number":484,"context_line":"        self.assertEqual(clients.foo(), \"cached_foo_client\")"},{"line_number":485,"context_line":"        self.assertEqual(clients.foo, cached_client_func)"},{"line_number":486,"context_line":""},{"line_number":487,"context_line":"        # Call second time with same name"}],"source_content_type":"text/x-python","patch_set":1,"id":"3acd31a7_c74bacaf","line":484,"in_reply_to":"7ad32947_56dbe91b","updated":"2015-04-30 10:11:04.000000000","message":"Agreed","commit_id":"3b91a410df55ef7d7b957cac14029d10d9b4f9f0"}]}
