)]}'
{"rally/benchmark/scenarios/nova/servers.py":[{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"3a247f79d078871a7cba54603cccb8fcd639b685","unresolved":false,"context_lines":[{"line_number":578,"context_line":"    def boot_and_associate_floating_ip(self, image, flavor, **kwargs):"},{"line_number":579,"context_line":"        \"\"\"Boot a server and associate a floating IP to it."},{"line_number":580,"context_line":""},{"line_number":581,"context_line":"        Expects a network to be part of the context."},{"line_number":582,"context_line":""},{"line_number":583,"context_line":"        :param image: image to be used to boot an instance"},{"line_number":584,"context_line":"        :param flavor: flavor to be used to boot an instance"}],"source_content_type":"text/x-python","patch_set":4,"id":"3acd31a7_2e38c69f","line":581,"updated":"2015-05-01 23:45:55.000000000","message":"So I believe it\u0027s better to put: \n\n  @validation.required_context(\"network\")\n\ninstead of writing it to docstrings","commit_id":"f09d0b04e4bb703735f266b7db68fa49698fe8a3"},{"author":{"_account_id":11748,"name":"Chris St. Pierre","email":"cstpierr@cisco.com","username":"stpierre"},"change_message_id":"69d3a2bf522fb30ee174133775dc61be6105bc63","unresolved":false,"context_lines":[{"line_number":578,"context_line":"    def boot_and_associate_floating_ip(self, image, flavor, **kwargs):"},{"line_number":579,"context_line":"        \"\"\"Boot a server and associate a floating IP to it."},{"line_number":580,"context_line":""},{"line_number":581,"context_line":"        Expects a network to be part of the context."},{"line_number":582,"context_line":""},{"line_number":583,"context_line":"        :param image: image to be used to boot an instance"},{"line_number":584,"context_line":"        :param flavor: flavor to be used to boot an instance"}],"source_content_type":"text/x-python","patch_set":4,"id":"3acd31a7_46d510b7","line":581,"in_reply_to":"3acd31a7_2e38c69f","updated":"2015-05-04 14:30:43.000000000","message":"Done","commit_id":"f09d0b04e4bb703735f266b7db68fa49698fe8a3"}],"rally/benchmark/scenarios/nova/utils.py":[{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"f28cc354b2dea35ff7e9636991991a3223577c7a","unresolved":false,"context_lines":[{"line_number":756,"context_line":"        return self.admin_clients(\"nova\").floating_ips_bulk.delete(ip_range)"},{"line_number":757,"context_line":""},{"line_number":758,"context_line":"    def _get_netwrap(self):"},{"line_number":759,"context_line":"        if not hasattr(self, \"_netwrap\"):"},{"line_number":760,"context_line":"            self._netwrap \u003d network_wrapper.wrap(self.clients)"},{"line_number":761,"context_line":"        return self._netwrap"}],"source_content_type":"text/x-python","patch_set":3,"id":"3acd31a7_f2275d10","line":759,"updated":"2015-05-01 14:33:25.000000000","message":"Such kind of hidden behavior makes code really hard readable (like something somewhere is adding some protected fields to the class). \n\nEspecially it is unexpected when it is called _get and not _set. \n\nThe second thing I would prefer to use network_wrapper in explicit manner, so just remove this code and use it directly e.g.: \n\n  net_wrap \u003d network_wrapper.wrap(self.clients)\n   ..","commit_id":"3012ef69457090d694027f967c4a7b173a47a9be"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"018535eeef9366b9f5ce9c8f26d1cd9a672be430","unresolved":false,"context_lines":[{"line_number":756,"context_line":"        return self.admin_clients(\"nova\").floating_ips_bulk.delete(ip_range)"},{"line_number":757,"context_line":""},{"line_number":758,"context_line":"    def _get_netwrap(self):"},{"line_number":759,"context_line":"        if not hasattr(self, \"_netwrap\"):"},{"line_number":760,"context_line":"            self._netwrap \u003d network_wrapper.wrap(self.clients)"},{"line_number":761,"context_line":"        return self._netwrap"}],"source_content_type":"text/x-python","patch_set":3,"id":"3acd31a7_68612039","line":759,"in_reply_to":"3acd31a7_a8f298d0","updated":"2015-05-01 15:40:20.000000000","message":"Chris,\n\nThank you. And it\u0027s very sad that we merged such code... Could you please cleanup it in vm/utils as well?","commit_id":"3012ef69457090d694027f967c4a7b173a47a9be"},{"author":{"_account_id":11748,"name":"Chris St. Pierre","email":"cstpierr@cisco.com","username":"stpierre"},"change_message_id":"e7338feb8084cd743e688386199984409cf52cb6","unresolved":false,"context_lines":[{"line_number":756,"context_line":"        return self.admin_clients(\"nova\").floating_ips_bulk.delete(ip_range)"},{"line_number":757,"context_line":""},{"line_number":758,"context_line":"    def _get_netwrap(self):"},{"line_number":759,"context_line":"        if not hasattr(self, \"_netwrap\"):"},{"line_number":760,"context_line":"            self._netwrap \u003d network_wrapper.wrap(self.clients)"},{"line_number":761,"context_line":"        return self._netwrap"}],"source_content_type":"text/x-python","patch_set":3,"id":"3acd31a7_a8f298d0","line":759,"in_reply_to":"3acd31a7_f2275d10","updated":"2015-05-01 15:31:19.000000000","message":"Done.\n\nFWIW, I copied this directly from the VM scenarios (scenarios/vm/utils.py), so we may want to clean that module up so that future copy-pasters don\u0027t repeat my mistake.","commit_id":"3012ef69457090d694027f967c4a7b173a47a9be"}],"samples/tasks/scenarios/nova/boot-and-associate-floating-ip.json":[{"author":{"_account_id":14168,"name":"Alexandr Nevenchannyy","email":"anevenchannyy@mirantis.com","username":"anevenchannyy"},"change_message_id":"5299c24723873e3f604120a273ad169a793f0b2e","unresolved":false,"context_lines":[{"line_number":2,"context_line":"  \"NovaServers.boot_and_associate_floating_ip\": ["},{"line_number":3,"context_line":"    {"},{"line_number":4,"context_line":"      \"runner\": {"},{"line_number":5,"context_line":"        \"type\": \"constant\", "},{"line_number":6,"context_line":"        \"concurrency\": 1, "},{"line_number":7,"context_line":"        \"times\": 1"},{"line_number":8,"context_line":"      }, "}],"source_content_type":"application/json","patch_set":1,"id":"7ad32947_0d82f700","line":5,"updated":"2015-04-27 21:10:48.000000000","message":"Please remove trailing spaces at EOF","commit_id":"21bf0a59e6c82b7f1834faf2e431b0b3d6805921"}]}