)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"f0d581f5ab3b68f5faee7456f1b22d551bfa112c","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     ravikumar-venkatesan \u003cravikumar.venkatesan@hp.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-04-30 05:43:48 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Adds Keystone ec2-credentials tests"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This submission adds methods to"},{"line_number":10,"context_line":"basic.py and utils.py"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"1aca2d91_da27dc10","line":7,"updated":"2015-05-07 14:00:20.000000000","message":"Not tests. Scenarios right word here","commit_id":"03cf7f2861248d858ef1fa1b64872e25388effe4"},{"author":{"_account_id":9989,"name":"kalyan bhonagiri","email":"kalyan_bhonagiri@persistent.co.in"},"change_message_id":"36af3d68407ca4923e3edb05c86d0405e6e8c0bd","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     ravikumar-venkatesan \u003cravikumar.venkatesan@hp.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-04-30 05:43:48 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Adds Keystone ec2-credentials tests"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This submission adds methods to"},{"line_number":10,"context_line":"basic.py and utils.py"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"7a016987_049b7973","line":7,"in_reply_to":"1aca2d91_da27dc10","updated":"2015-05-21 07:20:50.000000000","message":"Done","commit_id":"03cf7f2861248d858ef1fa1b64872e25388effe4"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"cd3a2211bbd29e5a687022013fcc5da282bbe53c","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     nayna-patel \u003cnayna.patel@hp.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-05-22 06:56:04 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Adds Keystone ec2-credentials scenarios"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This submission adds methods to"},{"line_number":10,"context_line":"basic.py and utils.py"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"7a016987_660b18d7","line":7,"updated":"2015-05-22 11:58:28.000000000","message":"its good to write in declarative style message \"Add ...\"","commit_id":"c621378e1f36f60932a524babd7a13095c16ad7b"}],"rally/benchmark/scenarios/keystone/basic.py":[{"author":{"_account_id":8507,"name":"Mikhail Dubov","email":"mdubov@mirantis.com","username":"msdubov"},"change_message_id":"16aaf49cb808e444fcc1bff69338196a08f8ab27","unresolved":false,"context_lines":[{"line_number":167,"context_line":""},{"line_number":168,"context_line":"    @validation.required_openstack(admin\u003dTrue)"},{"line_number":169,"context_line":"    @base.scenario(context\u003d{\"admin_cleanup\": [\"keystone\"]})"},{"line_number":170,"context_line":"    def create_and_list_ec2credentials(self, **kwargs):"},{"line_number":171,"context_line":"        \"\"\"Create and List all keystone ec2-credentials"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"        with user id and tenant id."}],"source_content_type":"text/x-python","patch_set":5,"id":"7a016987_c36f7729","line":170,"updated":"2015-05-21 11:50:15.000000000","message":"kwargs aren\u0027t used in the method, do you really need them?","commit_id":"c487be4344283cd81d3aadf91392a1b54c23ced1"},{"author":{"_account_id":9989,"name":"kalyan bhonagiri","email":"kalyan_bhonagiri@persistent.co.in"},"change_message_id":"165ef64ddd1ae8e79f38788e812e054bd80f1258","unresolved":false,"context_lines":[{"line_number":167,"context_line":""},{"line_number":168,"context_line":"    @validation.required_openstack(admin\u003dTrue)"},{"line_number":169,"context_line":"    @base.scenario(context\u003d{\"admin_cleanup\": [\"keystone\"]})"},{"line_number":170,"context_line":"    def create_and_list_ec2credentials(self, **kwargs):"},{"line_number":171,"context_line":"        \"\"\"Create and List all keystone ec2-credentials"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"        with user id and tenant id."}],"source_content_type":"text/x-python","patch_set":5,"id":"7a016987_0c436db3","line":170,"in_reply_to":"7a016987_c36f7729","updated":"2015-05-22 05:44:49.000000000","message":"Done","commit_id":"c487be4344283cd81d3aadf91392a1b54c23ced1"},{"author":{"_account_id":8507,"name":"Mikhail Dubov","email":"mdubov@mirantis.com","username":"msdubov"},"change_message_id":"16aaf49cb808e444fcc1bff69338196a08f8ab27","unresolved":false,"context_lines":[{"line_number":168,"context_line":"    @validation.required_openstack(admin\u003dTrue)"},{"line_number":169,"context_line":"    @base.scenario(context\u003d{\"admin_cleanup\": [\"keystone\"]})"},{"line_number":170,"context_line":"    def create_and_list_ec2credentials(self, **kwargs):"},{"line_number":171,"context_line":"        \"\"\"Create and List all keystone ec2-credentials"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"        with user id and tenant id."},{"line_number":174,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"7a016987_63720313","line":171,"updated":"2015-05-21 11:50:15.000000000","message":"The sentence should end on the first line (that\u0027s the rule for the docstrings)","commit_id":"c487be4344283cd81d3aadf91392a1b54c23ced1"},{"author":{"_account_id":9989,"name":"kalyan bhonagiri","email":"kalyan_bhonagiri@persistent.co.in"},"change_message_id":"165ef64ddd1ae8e79f38788e812e054bd80f1258","unresolved":false,"context_lines":[{"line_number":168,"context_line":"    @validation.required_openstack(admin\u003dTrue)"},{"line_number":169,"context_line":"    @base.scenario(context\u003d{\"admin_cleanup\": [\"keystone\"]})"},{"line_number":170,"context_line":"    def create_and_list_ec2credentials(self, **kwargs):"},{"line_number":171,"context_line":"        \"\"\"Create and List all keystone ec2-credentials"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"        with user id and tenant id."},{"line_number":174,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"7a016987_cc48b5ce","line":171,"in_reply_to":"7a016987_63720313","updated":"2015-05-22 05:44:49.000000000","message":"Done","commit_id":"c487be4344283cd81d3aadf91392a1b54c23ced1"},{"author":{"_account_id":8507,"name":"Mikhail Dubov","email":"mdubov@mirantis.com","username":"msdubov"},"change_message_id":"16aaf49cb808e444fcc1bff69338196a08f8ab27","unresolved":false,"context_lines":[{"line_number":180,"context_line":""},{"line_number":181,"context_line":"    @validation.required_openstack(admin\u003dTrue)"},{"line_number":182,"context_line":"    @base.scenario(context\u003d{\"admin_cleanup\": [\"keystone\"]})"},{"line_number":183,"context_line":"    def create_and_delete_ec2credential(self, **kwargs):"},{"line_number":184,"context_line":"        \"\"\"Create and delete keystone ec2-credential"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"        with user id and tenant id."}],"source_content_type":"text/x-python","patch_set":5,"id":"7a016987_8375fffa","line":183,"updated":"2015-05-21 11:50:15.000000000","message":"Why not \u0027...credentialS\u0027?","commit_id":"c487be4344283cd81d3aadf91392a1b54c23ced1"},{"author":{"_account_id":9989,"name":"kalyan bhonagiri","email":"kalyan_bhonagiri@persistent.co.in"},"change_message_id":"165ef64ddd1ae8e79f38788e812e054bd80f1258","unresolved":false,"context_lines":[{"line_number":180,"context_line":""},{"line_number":181,"context_line":"    @validation.required_openstack(admin\u003dTrue)"},{"line_number":182,"context_line":"    @base.scenario(context\u003d{\"admin_cleanup\": [\"keystone\"]})"},{"line_number":183,"context_line":"    def create_and_delete_ec2credential(self, **kwargs):"},{"line_number":184,"context_line":"        \"\"\"Create and delete keystone ec2-credential"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"        with user id and tenant id."}],"source_content_type":"text/x-python","patch_set":5,"id":"7a016987_0c580d87","line":183,"in_reply_to":"7a016987_8375fffa","updated":"2015-05-22 05:44:49.000000000","message":"Hi Mikhail,\nIn rally we are using keystone v2 client, which has ec2 .so used ec2-credentials.\n\nThanks","commit_id":"c487be4344283cd81d3aadf91392a1b54c23ced1"},{"author":{"_account_id":8507,"name":"Mikhail Dubov","email":"mdubov@mirantis.com","username":"msdubov"},"change_message_id":"16aaf49cb808e444fcc1bff69338196a08f8ab27","unresolved":false,"context_lines":[{"line_number":185,"context_line":""},{"line_number":186,"context_line":"        with user id and tenant id."},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"        :param kwargs: Optional parameters"},{"line_number":189,"context_line":"        \"\"\""},{"line_number":190,"context_line":"        creds \u003d self._create_ec2credentials(self.context[\"user\"][\"id\"],"},{"line_number":191,"context_line":"                                            self.context[\"user\"][\"tenant_id\"])"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a016987_c304174b","line":188,"updated":"2015-05-21 11:50:15.000000000","message":"Same problem with kwargs here","commit_id":"c487be4344283cd81d3aadf91392a1b54c23ced1"},{"author":{"_account_id":9989,"name":"kalyan bhonagiri","email":"kalyan_bhonagiri@persistent.co.in"},"change_message_id":"165ef64ddd1ae8e79f38788e812e054bd80f1258","unresolved":false,"context_lines":[{"line_number":185,"context_line":""},{"line_number":186,"context_line":"        with user id and tenant id."},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"        :param kwargs: Optional parameters"},{"line_number":189,"context_line":"        \"\"\""},{"line_number":190,"context_line":"        creds \u003d self._create_ec2credentials(self.context[\"user\"][\"id\"],"},{"line_number":191,"context_line":"                                            self.context[\"user\"][\"tenant_id\"])"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a016987_ac4339ae","line":188,"in_reply_to":"7a016987_c304174b","updated":"2015-05-22 05:44:49.000000000","message":"Done","commit_id":"c487be4344283cd81d3aadf91392a1b54c23ced1"}],"rally/benchmark/scenarios/keystone/utils.py":[{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"2d037cf7643497681b39b08fa69cc149d3aff05d","unresolved":false,"context_lines":[{"line_number":190,"context_line":""},{"line_number":191,"context_line":"    @base.atomic_action_timer(\"keystone.create_ec2creds\")"},{"line_number":192,"context_line":"    def _create_ec2credentials(self, user_id, tenant_id):"},{"line_number":193,"context_line":"        \"\"\"Creates ec2credentials."},{"line_number":194,"context_line":""},{"line_number":195,"context_line":"        :param user_id: User ID for which to create credentials"},{"line_number":196,"context_line":"        :param tenant_id: Tenant ID for which to create credentials"}],"source_content_type":"text/x-python","patch_set":1,"id":"7ad32947_2ee8fbe1","line":193,"updated":"2015-04-28 10:47:03.000000000","message":"s/Creates/Create/   ref.PEP257","commit_id":"f10a414b1a329dfb54562881e0b045e863f8b236"},{"author":{"_account_id":9989,"name":"kalyan bhonagiri","email":"kalyan_bhonagiri@persistent.co.in"},"change_message_id":"8aa9a15a20933485712750636095dd92f8f9241e","unresolved":false,"context_lines":[{"line_number":190,"context_line":""},{"line_number":191,"context_line":"    @base.atomic_action_timer(\"keystone.create_ec2creds\")"},{"line_number":192,"context_line":"    def _create_ec2credentials(self, user_id, tenant_id):"},{"line_number":193,"context_line":"        \"\"\"Creates ec2credentials."},{"line_number":194,"context_line":""},{"line_number":195,"context_line":"        :param user_id: User ID for which to create credentials"},{"line_number":196,"context_line":"        :param tenant_id: Tenant ID for which to create credentials"}],"source_content_type":"text/x-python","patch_set":1,"id":"7ad32947_d0623dd8","line":193,"in_reply_to":"7ad32947_2ee8fbe1","updated":"2015-04-28 13:47:02.000000000","message":"Done","commit_id":"f10a414b1a329dfb54562881e0b045e863f8b236"},{"author":{"_account_id":8507,"name":"Mikhail Dubov","email":"mdubov@mirantis.com","username":"msdubov"},"change_message_id":"16aaf49cb808e444fcc1bff69338196a08f8ab27","unresolved":false,"context_lines":[{"line_number":193,"context_line":"        \"\"\"Create ec2credentials."},{"line_number":194,"context_line":""},{"line_number":195,"context_line":"        :param user_id: User ID for which to create credentials"},{"line_number":196,"context_line":"        :param tenant_id: Tenant ID for which to create credentials"},{"line_number":197,"context_line":"        \"\"\""},{"line_number":198,"context_line":"        return self.clients(\"keystone\").ec2.create(user_id, tenant_id)"},{"line_number":199,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"7a016987_a3da3be6","line":196,"updated":"2015-05-21 11:50:15.000000000","message":"Please also specify what is the return value here and in _list_ec2credentials():\n\n    :returns: ...","commit_id":"c487be4344283cd81d3aadf91392a1b54c23ced1"},{"author":{"_account_id":9989,"name":"kalyan bhonagiri","email":"kalyan_bhonagiri@persistent.co.in"},"change_message_id":"165ef64ddd1ae8e79f38788e812e054bd80f1258","unresolved":false,"context_lines":[{"line_number":193,"context_line":"        \"\"\"Create ec2credentials."},{"line_number":194,"context_line":""},{"line_number":195,"context_line":"        :param user_id: User ID for which to create credentials"},{"line_number":196,"context_line":"        :param tenant_id: Tenant ID for which to create credentials"},{"line_number":197,"context_line":"        \"\"\""},{"line_number":198,"context_line":"        return self.clients(\"keystone\").ec2.create(user_id, tenant_id)"},{"line_number":199,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"7a016987_8c151d9d","line":196,"in_reply_to":"7a016987_a3da3be6","updated":"2015-05-22 05:44:49.000000000","message":"Done","commit_id":"c487be4344283cd81d3aadf91392a1b54c23ced1"},{"author":{"_account_id":8507,"name":"Mikhail Dubov","email":"mdubov@mirantis.com","username":"msdubov"},"change_message_id":"16aaf49cb808e444fcc1bff69338196a08f8ab27","unresolved":false,"context_lines":[{"line_number":212,"context_line":"        :param user_id: User ID for which to delete credential"},{"line_number":213,"context_line":"        :param access: access key for ec2credential to delete"},{"line_number":214,"context_line":"        \"\"\""},{"line_number":215,"context_line":"        return self.clients(\"keystone\").ec2.delete(user_id, access)"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a016987_83e3bfa3","line":215,"updated":"2015-05-21 11:50:15.000000000","message":"Do you really need to return something from this method? If yes, please specify what is returned here in the docstring as well.","commit_id":"c487be4344283cd81d3aadf91392a1b54c23ced1"},{"author":{"_account_id":9989,"name":"kalyan bhonagiri","email":"kalyan_bhonagiri@persistent.co.in"},"change_message_id":"165ef64ddd1ae8e79f38788e812e054bd80f1258","unresolved":false,"context_lines":[{"line_number":212,"context_line":"        :param user_id: User ID for which to delete credential"},{"line_number":213,"context_line":"        :param access: access key for ec2credential to delete"},{"line_number":214,"context_line":"        \"\"\""},{"line_number":215,"context_line":"        return self.clients(\"keystone\").ec2.delete(user_id, access)"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a016987_6c18a1d3","line":215,"in_reply_to":"7a016987_83e3bfa3","updated":"2015-05-22 05:44:49.000000000","message":"Done","commit_id":"c487be4344283cd81d3aadf91392a1b54c23ced1"}],"rally/plugins/openstack/scenarios/keystone/basic.py":[{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"2cb9c70c15e681b13ac4edd7bb05c9c3170b8c61","unresolved":false,"context_lines":[{"line_number":200,"context_line":"                                    self.context[\"tenant\"][\"id\"])"},{"line_number":201,"context_line":"        self._list_ec2credentials(self.context[\"user\"][\"id\"])"},{"line_number":202,"context_line":""},{"line_number":203,"context_line":"    @validation.required_openstack(admin\u003dTrue)"},{"line_number":204,"context_line":"    @base.scenario(context\u003d{\"admin_cleanup\": [\"keystone\"]})"},{"line_number":205,"context_line":"    def create_and_delete_ec2credential(self):"},{"line_number":206,"context_line":"        \"\"\"Create and delete keystone ec2-credential.\"\"\""}],"source_content_type":"text/x-python","patch_set":10,"id":"7a016987_6d4ff0be","line":203,"updated":"2015-05-27 21:47:46.000000000","message":"seems like you don\u0027t need here admin and you need actually users \n\n  @validation.required_openstack(users\u003dTrue)\n\n\nbecause I believe you can create_ec2credentials without admin?","commit_id":"788f025c87a76ab674068919fe20b98324f26634"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"ee8eda60f6981fdc4ed31369f0424b125bb8c056","unresolved":false,"context_lines":[{"line_number":200,"context_line":"                                    self.context[\"tenant\"][\"id\"])"},{"line_number":201,"context_line":"        self._list_ec2credentials(self.context[\"user\"][\"id\"])"},{"line_number":202,"context_line":""},{"line_number":203,"context_line":"    @validation.required_openstack(admin\u003dTrue)"},{"line_number":204,"context_line":"    @base.scenario(context\u003d{\"admin_cleanup\": [\"keystone\"]})"},{"line_number":205,"context_line":"    def create_and_delete_ec2credential(self):"},{"line_number":206,"context_line":"        \"\"\"Create and delete keystone ec2-credential.\"\"\""}],"source_content_type":"text/x-python","patch_set":10,"id":"ba3cc151_15d6b727","line":203,"in_reply_to":"7a016987_6d4ff0be","updated":"2015-07-03 09:46:48.000000000","message":"Done","commit_id":"788f025c87a76ab674068919fe20b98324f26634"}],"rally/plugins/openstack/scenarios/keystone/utils.py":[{"author":{"_account_id":8576,"name":"Yair Fried","email":"yfried@redhat.com","username":"yfried"},"change_message_id":"896cad8bf12b09170a7870ae9d965595d025157f","unresolved":false,"context_lines":[{"line_number":238,"context_line":""},{"line_number":239,"context_line":"        :returns: Return ec2-credentials list"},{"line_number":240,"context_line":"        \"\"\""},{"line_number":241,"context_line":"        return self.clients(\"keystone\").ec2.list(user_id)"},{"line_number":242,"context_line":""},{"line_number":243,"context_line":"    @base.atomic_action_timer(\"keystone.delete_ec2creds\")"},{"line_number":244,"context_line":"    def _delete_ec2credential(self, user_id, access):"}],"source_content_type":"text/x-python","patch_set":10,"id":"7a016987_bbc68a47","line":241,"updated":"2015-05-26 12:32:21.000000000","message":"for future use - doesn\u0027t ec2.list() support **kwargs as additional filters? if so, please add **kwargs to method and pass it to list","commit_id":"788f025c87a76ab674068919fe20b98324f26634"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"f364d8f3e4e3292baa5c7ac2ff487d476eec64a8","unresolved":false,"context_lines":[{"line_number":238,"context_line":""},{"line_number":239,"context_line":"        :returns: Return ec2-credentials list"},{"line_number":240,"context_line":"        \"\"\""},{"line_number":241,"context_line":"        return self.clients(\"keystone\").ec2.list(user_id)"},{"line_number":242,"context_line":""},{"line_number":243,"context_line":"    @base.atomic_action_timer(\"keystone.delete_ec2creds\")"},{"line_number":244,"context_line":"    def _delete_ec2credential(self, user_id, access):"}],"source_content_type":"text/x-python","patch_set":10,"id":"ba3cc151_cf0b06d5","line":241,"in_reply_to":"7a016987_bbc68a47","updated":"2015-07-03 09:46:04.000000000","message":"No, it doesn\u0027t support kwargs.","commit_id":"788f025c87a76ab674068919fe20b98324f26634"}],"tests/unit/benchmark/scenarios/keystone/test_basic.py":[{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"2d037cf7643497681b39b08fa69cc149d3aff05d","unresolved":false,"context_lines":[{"line_number":27,"context_line":"    def setUp(self):"},{"line_number":28,"context_line":"        super(KeystoneBasicTestCase, self).setUp()"},{"line_number":29,"context_line":"        self.context \u003d {"},{"line_number":30,"context_line":"            \"user\": {\"id\": \"fake\", \"tenant_id\": \"fake\"}"},{"line_number":31,"context_line":"        }"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    @mock.patch(BASIC + \"_generate_random_name\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"7ad32947_4e033774","line":30,"updated":"2015-04-28 10:47:03.000000000","message":"Value of \"id\" must differ from value of \"tenant_id\".\n\nFor example: if there is a bug in tested code and \"id\" is mixed up with \"tenant_id\", then this will not allow to check that - because id and tenant_id have same value\".\n\nUse this:\n\n self.context \u003d {\n     \"user\": {\"id\": \"fake_id\", \"tenant_id\": \"fake_tenant_id\"}\n }","commit_id":"f10a414b1a329dfb54562881e0b045e863f8b236"},{"author":{"_account_id":9989,"name":"kalyan bhonagiri","email":"kalyan_bhonagiri@persistent.co.in"},"change_message_id":"8aa9a15a20933485712750636095dd92f8f9241e","unresolved":false,"context_lines":[{"line_number":27,"context_line":"    def setUp(self):"},{"line_number":28,"context_line":"        super(KeystoneBasicTestCase, self).setUp()"},{"line_number":29,"context_line":"        self.context \u003d {"},{"line_number":30,"context_line":"            \"user\": {\"id\": \"fake\", \"tenant_id\": \"fake\"}"},{"line_number":31,"context_line":"        }"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    @mock.patch(BASIC + \"_generate_random_name\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"7ad32947_50a50d02","line":30,"in_reply_to":"7ad32947_4e033774","updated":"2015-04-28 13:47:02.000000000","message":"Done","commit_id":"f10a414b1a329dfb54562881e0b045e863f8b236"}],"tests/unit/benchmark/scenarios/keystone/test_utils.py":[{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"2d037cf7643497681b39b08fa69cc149d3aff05d","unresolved":false,"context_lines":[{"line_number":320,"context_line":"        create_creds \u003d scenario._create_ec2credentials(\"user_id\","},{"line_number":321,"context_line":"                                                       \"tenant_id\")"},{"line_number":322,"context_line":"        self.assertEqual(create_creds, creds)"},{"line_number":323,"context_line":"        self._test_atomic_action_timer(scenario.atomic_actions(),"},{"line_number":324,"context_line":"                                       \"keystone.create_ec2creds\")"},{"line_number":325,"context_line":""},{"line_number":326,"context_line":"    @mock.patch(UTILS + \"KeystoneScenario.clients\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"7ad32947_2e6ebb2f","line":323,"updated":"2015-04-28 10:47:03.000000000","message":"Missed assert:\n\n mock_clients(\"keystone\").ec2.create.assert_called_once_with(\n     \"user_id\", \"tenant_id\")","commit_id":"f10a414b1a329dfb54562881e0b045e863f8b236"},{"author":{"_account_id":9989,"name":"kalyan bhonagiri","email":"kalyan_bhonagiri@persistent.co.in"},"change_message_id":"8aa9a15a20933485712750636095dd92f8f9241e","unresolved":false,"context_lines":[{"line_number":320,"context_line":"        create_creds \u003d scenario._create_ec2credentials(\"user_id\","},{"line_number":321,"context_line":"                                                       \"tenant_id\")"},{"line_number":322,"context_line":"        self.assertEqual(create_creds, creds)"},{"line_number":323,"context_line":"        self._test_atomic_action_timer(scenario.atomic_actions(),"},{"line_number":324,"context_line":"                                       \"keystone.create_ec2creds\")"},{"line_number":325,"context_line":""},{"line_number":326,"context_line":"    @mock.patch(UTILS + \"KeystoneScenario.clients\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"7ad32947_10b0b542","line":323,"in_reply_to":"7ad32947_2e6ebb2f","updated":"2015-04-28 13:47:02.000000000","message":"Done","commit_id":"f10a414b1a329dfb54562881e0b045e863f8b236"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"2d037cf7643497681b39b08fa69cc149d3aff05d","unresolved":false,"context_lines":[{"line_number":329,"context_line":"        creds_list \u003d mock.Mock()"},{"line_number":330,"context_line":"        mock_clients(\"keystone\").ec2.list.return_value \u003d creds_list"},{"line_number":331,"context_line":"        list_creds \u003d scenario._list_ec2credentials(\"user_id\")"},{"line_number":332,"context_line":"        self.assertEqual(list_creds, creds_list)"},{"line_number":333,"context_line":"        self._test_atomic_action_timer(scenario.atomic_actions(),"},{"line_number":334,"context_line":"                                       \"keystone.list_ec2creds\")"},{"line_number":335,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7ad32947_aec76b11","line":332,"updated":"2015-04-28 10:47:03.000000000","message":"Missed assert:\n\n mock_clients(\"keystone\").ec2.list.assert_called_once_with(\n     \"user_id\")","commit_id":"f10a414b1a329dfb54562881e0b045e863f8b236"},{"author":{"_account_id":9989,"name":"kalyan bhonagiri","email":"kalyan_bhonagiri@persistent.co.in"},"change_message_id":"8aa9a15a20933485712750636095dd92f8f9241e","unresolved":false,"context_lines":[{"line_number":329,"context_line":"        creds_list \u003d mock.Mock()"},{"line_number":330,"context_line":"        mock_clients(\"keystone\").ec2.list.return_value \u003d creds_list"},{"line_number":331,"context_line":"        list_creds \u003d scenario._list_ec2credentials(\"user_id\")"},{"line_number":332,"context_line":"        self.assertEqual(list_creds, creds_list)"},{"line_number":333,"context_line":"        self._test_atomic_action_timer(scenario.atomic_actions(),"},{"line_number":334,"context_line":"                                       \"keystone.list_ec2creds\")"},{"line_number":335,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7ad32947_d0b91d30","line":332,"in_reply_to":"7ad32947_aec76b11","updated":"2015-04-28 13:47:02.000000000","message":"Done","commit_id":"f10a414b1a329dfb54562881e0b045e863f8b236"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"2d037cf7643497681b39b08fa69cc149d3aff05d","unresolved":false,"context_lines":[{"line_number":339,"context_line":"        creds_delete \u003d mock.Mock()"},{"line_number":340,"context_line":"        mock_clients(\"keystone\").ec2.delete.return_value \u003d creds_delete"},{"line_number":341,"context_line":"        delete_creds \u003d scenario._delete_ec2credential(\"user_id\", \"access\")"},{"line_number":342,"context_line":"        self.assertEqual(delete_creds, creds_delete)"},{"line_number":343,"context_line":"        self._test_atomic_action_timer(scenario.atomic_actions(),"},{"line_number":344,"context_line":"                                       \"keystone.delete_ec2creds\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"7ad32947_8ef38f73","line":342,"updated":"2015-04-28 10:47:03.000000000","message":"Missed assert:\n\n  mock_clients(\"keystone\").ec2.delete.assert_called_once_with(\n     \"user_id\", \"access\")","commit_id":"f10a414b1a329dfb54562881e0b045e863f8b236"},{"author":{"_account_id":9989,"name":"kalyan bhonagiri","email":"kalyan_bhonagiri@persistent.co.in"},"change_message_id":"8aa9a15a20933485712750636095dd92f8f9241e","unresolved":false,"context_lines":[{"line_number":339,"context_line":"        creds_delete \u003d mock.Mock()"},{"line_number":340,"context_line":"        mock_clients(\"keystone\").ec2.delete.return_value \u003d creds_delete"},{"line_number":341,"context_line":"        delete_creds \u003d scenario._delete_ec2credential(\"user_id\", \"access\")"},{"line_number":342,"context_line":"        self.assertEqual(delete_creds, creds_delete)"},{"line_number":343,"context_line":"        self._test_atomic_action_timer(scenario.atomic_actions(),"},{"line_number":344,"context_line":"                                       \"keystone.delete_ec2creds\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"7ad32947_7087e961","line":342,"in_reply_to":"7ad32947_8ef38f73","updated":"2015-04-28 13:47:02.000000000","message":"Done","commit_id":"f10a414b1a329dfb54562881e0b045e863f8b236"}],"tests/unit/plugins/openstack/scenarios/keystone/test_basic.py":[{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"a09a018165cbed3477f88c2690dee9000104a8ac","unresolved":false,"context_lines":[{"line_number":242,"context_line":"        scenario._create_ec2credentials \u003d mock.MagicMock()"},{"line_number":243,"context_line":"        scenario._list_ec2credentials \u003d mock.MagicMock()"},{"line_number":244,"context_line":"        scenario.create_and_list_ec2credentials()"},{"line_number":245,"context_line":"        scenario._create_ec2credentials.assert_called_once_with(\"fake\","},{"line_number":246,"context_line":"                                                                \"fake\")"},{"line_number":247,"context_line":"        scenario._list_ec2credentials.assert_called_with(\"fake\")"},{"line_number":248,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"ba3cc151_ff24bbc5","line":245,"updated":"2015-07-01 12:45:20.000000000","message":"I would recommend to update L30-31 so user_id and tenant_id would not be equal - that is buggy testing approach","commit_id":"788f025c87a76ab674068919fe20b98324f26634"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"ee8eda60f6981fdc4ed31369f0424b125bb8c056","unresolved":false,"context_lines":[{"line_number":242,"context_line":"        scenario._create_ec2credentials \u003d mock.MagicMock()"},{"line_number":243,"context_line":"        scenario._list_ec2credentials \u003d mock.MagicMock()"},{"line_number":244,"context_line":"        scenario.create_and_list_ec2credentials()"},{"line_number":245,"context_line":"        scenario._create_ec2credentials.assert_called_once_with(\"fake\","},{"line_number":246,"context_line":"                                                                \"fake\")"},{"line_number":247,"context_line":"        scenario._list_ec2credentials.assert_called_with(\"fake\")"},{"line_number":248,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"ba3cc151_95eac7d9","line":245,"in_reply_to":"ba3cc151_ff24bbc5","updated":"2015-07-03 09:46:48.000000000","message":"Done","commit_id":"788f025c87a76ab674068919fe20b98324f26634"}]}
