)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"f1c3a404e3154fd4cf82717f2fcbf105a7246069","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Chris St. Pierre \u003cchris.a.st.pierre@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-05-15 11:03:57 -0500"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add Nova networks tests"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Added base methods (create/delete) for nova networks"},{"line_number":10,"context_line":"and configuration files for these operations."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"7a016987_56696e24","line":7,"updated":"2015-05-15 22:43:11.000000000","message":"Add Nova network scenarios","commit_id":"8b5d2e7c1ea8a469891320215644b4e074109e58"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"f1c3a404e3154fd4cf82717f2fcbf105a7246069","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add Nova networks tests"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Added base methods (create/delete) for nova networks"},{"line_number":10,"context_line":"and configuration files for these operations."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I8c1f11e0f84345e10423b2117fc88513ca206fe0"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"7a016987_362152fc","line":9,"updated":"2015-05-15 22:43:11.000000000","message":"Add create_and_list... scenarios. Add create_network method.... to utils.","commit_id":"8b5d2e7c1ea8a469891320215644b4e074109e58"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"f1c3a404e3154fd4cf82717f2fcbf105a7246069","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Add Nova networks tests"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Added base methods (create/delete) for nova networks"},{"line_number":10,"context_line":"and configuration files for these operations."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I8c1f11e0f84345e10423b2117fc88513ca206fe0"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"7a016987_f6605a37","line":10,"updated":"2015-05-15 22:43:11.000000000","message":"Add scenario to rally jobs for functional test","commit_id":"8b5d2e7c1ea8a469891320215644b4e074109e58"}],"rally-jobs/rally.yaml":[{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"a3a1e0f6cc6e4685da4533c4266aae602572ee66","unresolved":false,"context_lines":[{"line_number":1623,"context_line":"        users:"},{"line_number":1624,"context_line":"          tenants: 3"},{"line_number":1625,"context_line":"          users_per_tenant: 1"},{"line_number":1626,"context_line":""},{"line_number":1627,"context_line":""},{"line_number":1628,"context_line":"  NovaNetworks.create_and_delete_network:"},{"line_number":1629,"context_line":"    -"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"5afe65bd_41776c3a","line":1626,"updated":"2015-06-03 09:31:47.000000000","message":"Your change has removed `sla\u0027 from EC2Servers.boot_server","commit_id":"a6f94398e414180df153f12a10cfb48f9b52e7a8"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"b508152fdfd91a6da43632a7074dfd97eeaa8f2a","unresolved":false,"context_lines":[{"line_number":1607,"context_line":"        failure_rate:"},{"line_number":1608,"context_line":"          max: 0"},{"line_number":1609,"context_line":""},{"line_number":1610,"context_line":""},{"line_number":1611,"context_line":"  EC2Servers.boot_server:"},{"line_number":1612,"context_line":"    -"},{"line_number":1613,"context_line":"      args:"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"5afe65bd_fd1b5971","line":1610,"updated":"2015-06-04 16:08:16.000000000","message":"remove all extra changes in this files","commit_id":"e5cbcca824468a90df75e98a2ae9c498f4025045"}],"rally/benchmark/scenarios/nova/networks.py":[{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"4588fcb141e539330895c496b11deaebf4885a1a","unresolved":false,"context_lines":[{"line_number":22,"context_line":"class NovaNetworks(utils.NovaScenario):"},{"line_number":23,"context_line":"    \"\"\"Benchmark scenarios for creation nova network.\"\"\""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"    # @validation.restricted_parameters(\"label\")"},{"line_number":26,"context_line":"    @validation.required_parameters(\"start_cidr\")"},{"line_number":27,"context_line":"    @validation.required_services(consts.Service.NOVA)"},{"line_number":28,"context_line":"    @validation.required_openstack(admin\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7ad32947_3ab6f28a","line":25,"updated":"2015-04-28 13:20:46.000000000","message":"why this decorator is commented?","commit_id":"f8d9ad45944b25c4bc870a332320d9421451ff94"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"4588fcb141e539330895c496b11deaebf4885a1a","unresolved":false,"context_lines":[{"line_number":39,"context_line":"        self._create_network(start_cidr, **kwargs)"},{"line_number":40,"context_line":"        self._list_networks()"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    # @validation.restricted_parameters(\"label\")"},{"line_number":43,"context_line":"    @validation.required_parameters(\"start_cidr\")"},{"line_number":44,"context_line":"    @validation.required_services(consts.Service.NOVA)"},{"line_number":45,"context_line":"    @validation.required_openstack(admin\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7ad32947_daadbe32","line":42,"updated":"2015-04-28 13:20:46.000000000","message":"same question here","commit_id":"f8d9ad45944b25c4bc870a332320d9421451ff94"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"f1c3a404e3154fd4cf82717f2fcbf105a7246069","unresolved":false,"context_lines":[{"line_number":30,"context_line":"    def create_and_list_network(self, start_cidr, **kwargs):"},{"line_number":31,"context_line":"        \"\"\"Create nova network and list all networks."},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"        This scenario creates Nova network and then lists all."},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"        :param start_cidr: IP range"},{"line_number":36,"context_line":"        :param kwargs: Optional additional arguments for network creation"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a016987_1647764c","line":33,"updated":"2015-05-15 22:43:11.000000000","message":"\"This scenario\" is don\u0027t needed prefix","commit_id":"8b5d2e7c1ea8a469891320215644b4e074109e58"},{"author":{"_account_id":11748,"name":"Chris St. Pierre","email":"cstpierr@cisco.com","username":"stpierre"},"change_message_id":"14752b5f3640294b13933e3e0d98e4f0dd000d4a","unresolved":false,"context_lines":[{"line_number":30,"context_line":"    def create_and_list_network(self, start_cidr, **kwargs):"},{"line_number":31,"context_line":"        \"\"\"Create nova network and list all networks."},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"        This scenario creates Nova network and then lists all."},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"        :param start_cidr: IP range"},{"line_number":36,"context_line":"        :param kwargs: Optional additional arguments for network creation"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a016987_606239af","line":33,"in_reply_to":"7a016987_1647764c","updated":"2015-05-18 18:25:39.000000000","message":"Done","commit_id":"8b5d2e7c1ea8a469891320215644b4e074109e58"}],"rally/consts.py":[{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"ecf3d8228a6ea2524a29126a6f3f5c3b98568808","unresolved":false,"context_lines":[{"line_number":86,"context_line":"    \"\"\"OpenStack services names, by rally convention.\"\"\""},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"    NOVA \u003d \"nova\""},{"line_number":89,"context_line":"    NOVA_NET \u003d \"nova-network\""},{"line_number":90,"context_line":"    NOVAV21 \u003d \"novav21\""},{"line_number":91,"context_line":"    NOVAV3 \u003d \"novav3\""},{"line_number":92,"context_line":"    CINDER \u003d \"cinder\""}],"source_content_type":"text/x-python","patch_set":19,"id":"9a41bdd9_73c051e1","line":89,"updated":"2015-07-17 00:19:33.000000000","message":"Is that an OpenStack service?","commit_id":"313e351ec8cfd7b38448e71d90b33c80371900dd"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"8795c15ac2f33dc58ea78c532cade80e40e6ed90","unresolved":false,"context_lines":[{"line_number":86,"context_line":"    \"\"\"OpenStack services names, by rally convention.\"\"\""},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"    NOVA \u003d \"nova\""},{"line_number":89,"context_line":"    NOVA_NET \u003d \"nova-network\""},{"line_number":90,"context_line":"    NOVAV21 \u003d \"novav21\""},{"line_number":91,"context_line":"    NOVAV3 \u003d \"novav3\""},{"line_number":92,"context_line":"    CINDER \u003d \"cinder\""}],"source_content_type":"text/x-python","patch_set":19,"id":"9a41bdd9_b3456218","line":89,"in_reply_to":"9a41bdd9_73c051e1","updated":"2015-07-17 11:19:18.000000000","message":"Agree, looks like nova_net mustn’t to be here","commit_id":"313e351ec8cfd7b38448e71d90b33c80371900dd"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"b3f9715ca85379377b0872057b9597138dbc0ce0","unresolved":false,"context_lines":[{"line_number":86,"context_line":"    \"\"\"OpenStack services names, by rally convention.\"\"\""},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"    NOVA \u003d \"nova\""},{"line_number":89,"context_line":"    NOVA_NET \u003d \"nova-network\""},{"line_number":90,"context_line":"    NOVAV21 \u003d \"novav21\""},{"line_number":91,"context_line":"    NOVAV3 \u003d \"novav3\""},{"line_number":92,"context_line":"    CINDER \u003d \"cinder\""}],"source_content_type":"text/x-python","patch_set":20,"id":"9a41bdd9_fd46477a","line":89,"updated":"2015-07-17 16:03:13.000000000","message":"Look at my comment in previous patch set (\"nova-network\" is not an OpenStack service)","commit_id":"55f580e2999ad1735ab404cc2ee4b3c348a4633f"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"9f3c7fcde9e60a78eeee16cf93a7f27007f6448e","unresolved":false,"context_lines":[{"line_number":86,"context_line":"    \"\"\"OpenStack services names, by rally convention.\"\"\""},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"    NOVA \u003d \"nova\""},{"line_number":89,"context_line":"    NOVA_NET \u003d \"nova-network\""},{"line_number":90,"context_line":"    NOVAV21 \u003d \"novav21\""},{"line_number":91,"context_line":"    NOVAV3 \u003d \"novav3\""},{"line_number":92,"context_line":"    CINDER \u003d \"cinder\""}],"source_content_type":"text/x-python","patch_set":20,"id":"3a50d1a3_e3f7c1f3","line":89,"in_reply_to":"3a50d1a3_62c41292","updated":"2015-07-19 11:22:58.000000000","message":"@Alexander. nova-compute service is a separate service, nova-scheduler is a separate service,  nova-network is a separate service. Please do not pay attention to single code repository. \n\n\u003ewhy the only validation knows about that \n\nWe don\u0027t need often check nova-network is enabled. In most cases check neutron is enough. Since check of nova-network require one additional call, so I prefer to do it, only when we need it.","commit_id":"55f580e2999ad1735ab404cc2ee4b3c348a4633f"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"6b2d1f3d613db3db41b9038fd537469c5636bedd","unresolved":false,"context_lines":[{"line_number":86,"context_line":"    \"\"\"OpenStack services names, by rally convention.\"\"\""},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"    NOVA \u003d \"nova\""},{"line_number":89,"context_line":"    NOVA_NET \u003d \"nova-network\""},{"line_number":90,"context_line":"    NOVAV21 \u003d \"novav21\""},{"line_number":91,"context_line":"    NOVAV3 \u003d \"novav3\""},{"line_number":92,"context_line":"    CINDER \u003d \"cinder\""}],"source_content_type":"text/x-python","patch_set":20,"id":"1a4dcd0f_ea5da947","line":89,"in_reply_to":"3a50d1a3_e3f7c1f3","updated":"2015-08-06 11:19:01.000000000","message":"Okay","commit_id":"55f580e2999ad1735ab404cc2ee4b3c348a4633f"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"00e1b08dd9ca70fe2274a1268a7ad676f333de2b","unresolved":false,"context_lines":[{"line_number":86,"context_line":"    \"\"\"OpenStack services names, by rally convention.\"\"\""},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"    NOVA \u003d \"nova\""},{"line_number":89,"context_line":"    NOVA_NET \u003d \"nova-network\""},{"line_number":90,"context_line":"    NOVAV21 \u003d \"novav21\""},{"line_number":91,"context_line":"    NOVAV3 \u003d \"novav3\""},{"line_number":92,"context_line":"    CINDER \u003d \"cinder\""}],"source_content_type":"text/x-python","patch_set":20,"id":"3a50d1a3_62c41292","line":89,"in_reply_to":"9a41bdd9_839319fa","updated":"2015-07-18 22:12:03.000000000","message":"@Andrey, AFAIK nova-network is a part of compute.\n\nWe can distinguish that as a service, but in this case why the only validation knows about that - IMO we should update https://github.com/openstack/rally/blob/master/rally/osclients.py#L440-L450 - this will automatically solve all problems related to validation, etc...","commit_id":"55f580e2999ad1735ab404cc2ee4b3c348a4633f"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"f44fbc504b91ba58104a9fe81e8cf93226ac6a98","unresolved":false,"context_lines":[{"line_number":86,"context_line":"    \"\"\"OpenStack services names, by rally convention.\"\"\""},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"    NOVA \u003d \"nova\""},{"line_number":89,"context_line":"    NOVA_NET \u003d \"nova-network\""},{"line_number":90,"context_line":"    NOVAV21 \u003d \"novav21\""},{"line_number":91,"context_line":"    NOVAV3 \u003d \"novav3\""},{"line_number":92,"context_line":"    CINDER \u003d \"cinder\""}],"source_content_type":"text/x-python","patch_set":20,"id":"9a41bdd9_839319fa","line":89,"in_reply_to":"9a41bdd9_fd46477a","updated":"2015-07-17 18:17:00.000000000","message":"If nova-network is not  openstack service, please tell me what is it. :)\nNova-network is a simple network service, which is now deprecated in master due to more complex service - neutron. But it still used by a lot of deployments. Why keystone doesn\u0027t handle it? I don\u0027t know.","commit_id":"55f580e2999ad1735ab404cc2ee4b3c348a4633f"}],"rally/plugins/openstack/scenarios/nova/networks.py":[{"author":{"_account_id":8507,"name":"Mikhail Dubov","email":"mdubov@mirantis.com","username":"msdubov"},"change_message_id":"3d81951b3318a42157cf60f8a03bf3d3425165c8","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"class NovaNetworks(utils.NovaScenario):"},{"line_number":23,"context_line":"    \"\"\"Benchmark scenarios for creation nova network.\"\"\""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"    @validation.restricted_parameters(\"label\")"},{"line_number":26,"context_line":"    @validation.required_parameters(\"start_cidr\")"}],"source_content_type":"text/x-python","patch_set":10,"id":"7a016987_3e35e8f6","line":23,"updated":"2015-05-26 13:03:26.000000000","message":"Since all this is not only about network creation, please correct:\n\n    \"\"\"Benchmark scenarios for Nova networks.\"\"\"","commit_id":"e2096adc79780c7eb79e4b4366ca3fea2f81000c"},{"author":{"_account_id":8507,"name":"Mikhail Dubov","email":"mdubov@mirantis.com","username":"msdubov"},"change_message_id":"3d81951b3318a42157cf60f8a03bf3d3425165c8","unresolved":false,"context_lines":[{"line_number":27,"context_line":"    @validation.required_services(consts.Service.NOVA)"},{"line_number":28,"context_line":"    @validation.required_openstack(admin\u003dTrue)"},{"line_number":29,"context_line":"    @base.scenario(context\u003d{\"admin_cleanup\": [\"nova.networks\"]})"},{"line_number":30,"context_line":"    def create_and_list_network(self, start_cidr, **kwargs):"},{"line_number":31,"context_line":"        \"\"\"Create nova network and list all networks."},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"        :param start_cidr: IP range"}],"source_content_type":"text/x-python","patch_set":10,"id":"7a016987_de0b742a","line":30,"updated":"2015-05-26 13:03:26.000000000","message":"The analogous scenario for Neutron is called \u0027create_and_list_networks\u0027, so maybe rename it here to be consistent?","commit_id":"e2096adc79780c7eb79e4b4366ca3fea2f81000c"},{"author":{"_account_id":8507,"name":"Mikhail Dubov","email":"mdubov@mirantis.com","username":"msdubov"},"change_message_id":"7af57835d9b77caef2b6f04ecb1cbf88512e8e01","unresolved":false,"context_lines":[{"line_number":42,"context_line":"    @validation.required_services(consts.Service.NOVA)"},{"line_number":43,"context_line":"    @validation.required_openstack(admin\u003dTrue)"},{"line_number":44,"context_line":"    @base.scenario(context\u003d{\"admin_cleanup\": [\"nova.networks\"]})"},{"line_number":45,"context_line":"    def create_and_delete_networks(self, start_cidr, **kwargs):"},{"line_number":46,"context_line":"        \"\"\"Create nova network and delete it."},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"        :param start_cidr: IP range"}],"source_content_type":"text/x-python","patch_set":12,"id":"7a016987_043c0e2e","line":45,"updated":"2015-05-26 18:11:33.000000000","message":"IMO renaming this to \u0027..._networks\u0027 had no sense because this scenario creates\u0026deletes only one network. I asked only to rename the scenaro above.","commit_id":"ff3c4732a5d154df54edf230ad6aec5c50aa22a5"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"8597336c90764b9ec9d689080f88909ce897d6fe","unresolved":false,"context_lines":[{"line_number":13,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"from rally.benchmark.scenarios import base"},{"line_number":17,"context_line":"from rally.benchmark import validation"},{"line_number":18,"context_line":"from rally import consts"},{"line_number":19,"context_line":"from rally.plugins.openstack.scenarios.nova import utils"}],"source_content_type":"text/x-python","patch_set":16,"id":"ba3cc151_eb2d6ffe","line":16,"updated":"2015-07-03 12:50:20.000000000","message":"Rebase please on master branch. This was renamed","commit_id":"aff36298a0bff4dab7e03a47b8a5b7a5acab4d78"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"59cefc4f4d857a6722af236743436efaa3d2935c","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"    @validation.restricted_parameters(\"label\")"},{"line_number":26,"context_line":"    @validation.required_parameters(\"start_cidr\")"},{"line_number":27,"context_line":"    @validation.required_services(consts.Service.NOVA, consts.Service.NOVA_NET)"},{"line_number":28,"context_line":"    @validation.required_openstack(admin\u003dTrue)"},{"line_number":29,"context_line":"    @base.scenario(context\u003d{\"admin_cleanup\": [\"nova.networks\"]})"},{"line_number":30,"context_line":"    def create_and_list_networks(self, start_cidr, **kwargs):"}],"source_content_type":"text/x-python","patch_set":18,"id":"ba3cc151_b1eb1cb0","line":27,"updated":"2015-07-06 15:44:18.000000000","message":"Sorry but I can\u0027t find here such service https://github.com/openstack/rally/blob/master/rally/consts.py#L85","commit_id":"79c66208cf06aebd857efb2af1e74f172f94ce59"},{"author":{"_account_id":13454,"name":"Alexander Gubanov","email":"ogubanov@mirantis.com","username":"hop"},"change_message_id":"68a4ea6e2ed3677199d12a49c73b734af42fcc63","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"    @validation.restricted_parameters(\"label\")"},{"line_number":26,"context_line":"    @validation.required_parameters(\"start_cidr\")"},{"line_number":27,"context_line":"    @validation.required_services(consts.Service.NOVA, consts.Service.NOVA_NET)"},{"line_number":28,"context_line":"    @validation.required_openstack(admin\u003dTrue)"},{"line_number":29,"context_line":"    @base.scenario(context\u003d{\"admin_cleanup\": [\"nova.networks\"]})"},{"line_number":30,"context_line":"    def create_and_list_networks(self, start_cidr, **kwargs):"}],"source_content_type":"text/x-python","patch_set":18,"id":"ba3cc151_941fe65a","line":27,"in_reply_to":"ba3cc151_b1eb1cb0","updated":"2015-07-06 15:47:33.000000000","message":"https://review.openstack.org/#/c/178139/18/rally/consts.py","commit_id":"79c66208cf06aebd857efb2af1e74f172f94ce59"}],"rally/plugins/openstack/scenarios/nova/utils.py":[{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"8597336c90764b9ec9d689080f88909ce897d6fe","unresolved":false,"context_lines":[{"line_number":799,"context_line":"        server.unlock()"},{"line_number":800,"context_line":""},{"line_number":801,"context_line":"    @base.atomic_action_timer(\"nova.create_network\")"},{"line_number":802,"context_line":"    def _create_network(self, ip_range, **kwargs):"},{"line_number":803,"context_line":"        \"\"\"Create nova network.\"\"\""},{"line_number":804,"context_line":"        net_label \u003d self._generate_random_name(prefix\u003d\"rally_novanet\")"},{"line_number":805,"context_line":"        ip_range \u003d network_wrapper.generate_cidr(start_cidr\u003dip_range)"}],"source_content_type":"text/x-python","patch_set":16,"id":"ba3cc151_0b0bf3d6","line":802,"updated":"2015-07-03 12:50:20.000000000","message":"Please document function params","commit_id":"aff36298a0bff4dab7e03a47b8a5b7a5acab4d78"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"8597336c90764b9ec9d689080f88909ce897d6fe","unresolved":false,"context_lines":[{"line_number":807,"context_line":"            label\u003dnet_label, cidr\u003dip_range, **kwargs)"},{"line_number":808,"context_line":""},{"line_number":809,"context_line":"    @base.atomic_action_timer(\"nova.delete_network\")"},{"line_number":810,"context_line":"    def _delete_network(self, net_id):"},{"line_number":811,"context_line":"        \"\"\"Delete nova network.\"\"\""},{"line_number":812,"context_line":"        return self.admin_clients(\"nova\").networks.delete(net_id)"}],"source_content_type":"text/x-python","patch_set":16,"id":"ba3cc151_cb10ab02","line":810,"updated":"2015-07-03 12:50:20.000000000","message":"Same here","commit_id":"aff36298a0bff4dab7e03a47b8a5b7a5acab4d78"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"ecf3d8228a6ea2524a29126a6f3f5c3b98568808","unresolved":false,"context_lines":[{"line_number":802,"context_line":"    def _create_network(self, ip_range, **kwargs):"},{"line_number":803,"context_line":"        \"\"\"Create nova network."},{"line_number":804,"context_line":""},{"line_number":805,"context_line":"        param ip_range: IP range in CIDR notation to create"},{"line_number":806,"context_line":"        \"\"\""},{"line_number":807,"context_line":"        net_label \u003d self._generate_random_name(prefix\u003d\"rally_novanet\")"},{"line_number":808,"context_line":"        ip_range \u003d network_wrapper.generate_cidr(start_cidr\u003dip_range)"}],"source_content_type":"text/x-python","patch_set":19,"id":"9a41bdd9_d3011d3b","line":805,"updated":"2015-07-17 00:19:33.000000000","message":"s/param/:param/","commit_id":"313e351ec8cfd7b38448e71d90b33c80371900dd"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"8795c15ac2f33dc58ea78c532cade80e40e6ed90","unresolved":false,"context_lines":[{"line_number":802,"context_line":"    def _create_network(self, ip_range, **kwargs):"},{"line_number":803,"context_line":"        \"\"\"Create nova network."},{"line_number":804,"context_line":""},{"line_number":805,"context_line":"        param ip_range: IP range in CIDR notation to create"},{"line_number":806,"context_line":"        \"\"\""},{"line_number":807,"context_line":"        net_label \u003d self._generate_random_name(prefix\u003d\"rally_novanet\")"},{"line_number":808,"context_line":"        ip_range \u003d network_wrapper.generate_cidr(start_cidr\u003dip_range)"}],"source_content_type":"text/x-python","patch_set":19,"id":"9a41bdd9_936dbece","line":805,"in_reply_to":"9a41bdd9_d3011d3b","updated":"2015-07-17 11:19:18.000000000","message":"param \u003d \u003eparams)\nAnd please document return value","commit_id":"313e351ec8cfd7b38448e71d90b33c80371900dd"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"8795c15ac2f33dc58ea78c532cade80e40e6ed90","unresolved":false,"context_lines":[{"line_number":813,"context_line":"    def _delete_network(self, net_id):"},{"line_number":814,"context_line":"        \"\"\"Delete nova network."},{"line_number":815,"context_line":""},{"line_number":816,"context_line":"        param net_id: The nova-network ID to delete"},{"line_number":817,"context_line":"        \"\"\""},{"line_number":818,"context_line":"        return self.admin_clients(\"nova\").networks.delete(net_id)"}],"source_content_type":"text/x-python","patch_set":19,"id":"9a41bdd9_b3f7a2f4","line":816,"updated":"2015-07-17 11:19:18.000000000","message":"please document return value","commit_id":"313e351ec8cfd7b38448e71d90b33c80371900dd"}],"rally/task/validation.py":[{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"ecf3d8228a6ea2524a29126a6f3f5c3b98568808","unresolved":false,"context_lines":[{"line_number":495,"context_line":"    \"\"\""},{"line_number":496,"context_line":"    available_services \u003d clients.services().values()"},{"line_number":497,"context_line":""},{"line_number":498,"context_line":"    if consts.Service.NOVA_NET in required_services:"},{"line_number":499,"context_line":"        nova \u003d osclients.Clients("},{"line_number":500,"context_line":"            objects.Endpoint(**deployment[\"admin\"])).nova()"},{"line_number":501,"context_line":"        for service in nova.services.list():"}],"source_content_type":"text/x-python","patch_set":19,"id":"9a41bdd9_9392b5f5","line":498,"updated":"2015-07-17 00:19:33.000000000","message":"This looks like terminology error, since nova-network is not a service, that is a part of nova service. This is dirty validation","commit_id":"313e351ec8cfd7b38448e71d90b33c80371900dd"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"8795c15ac2f33dc58ea78c532cade80e40e6ed90","unresolved":false,"context_lines":[{"line_number":495,"context_line":"    \"\"\""},{"line_number":496,"context_line":"    available_services \u003d clients.services().values()"},{"line_number":497,"context_line":""},{"line_number":498,"context_line":"    if consts.Service.NOVA_NET in required_services:"},{"line_number":499,"context_line":"        nova \u003d osclients.Clients("},{"line_number":500,"context_line":"            objects.Endpoint(**deployment[\"admin\"])).nova()"},{"line_number":501,"context_line":"        for service in nova.services.list():"}],"source_content_type":"text/x-python","patch_set":19,"id":"9a41bdd9_33e4f239","line":498,"in_reply_to":"9a41bdd9_9392b5f5","updated":"2015-07-17 11:19:18.000000000","message":"Agree. I thin you can take as an example required_cinder_services validator. And write something like required_nova_services.","commit_id":"313e351ec8cfd7b38448e71d90b33c80371900dd"}],"tests/unit/benchmark/scenarios/nova/test_utils.py":[{"author":{"_account_id":11748,"name":"Chris St. Pierre","email":"cstpierr@cisco.com","username":"stpierre"},"change_message_id":"d63ab3b7bffa2b26bd3e6a6b6ee32d464a35428d","unresolved":false,"context_lines":[{"line_number":784,"context_line":""},{"line_number":785,"context_line":"    @mock.patch(NOVA_UTILS + \".network_wrapper.generate_cidr\")"},{"line_number":786,"context_line":"    @mock.patch(NOVA_UTILS + \".NovaScenario.admin_clients\")"},{"line_number":787,"context_line":"    def test__create_network(self, mock_clients, mock_gencidr):"},{"line_number":788,"context_line":"        fake_cidr \u003d \"10.2.0.0/24\""},{"line_number":789,"context_line":"        fake_network \u003d mock.MagicMock()"},{"line_number":790,"context_line":"        fake_network.cidr \u003d fake_cidr"}],"source_content_type":"text/x-python","patch_set":5,"id":"3acd31a7_0982ef00","line":787,"updated":"2015-04-29 20:19:08.000000000","message":"This test never makes sure that network creation is actually called. It looks like you\u0027ll need to mock out _generate_random_name and ensure that create() is called with the proper values. Ideally, pass in a fake keyword argument to _create_network() to ensure that it\u0027s passed through appropriately.","commit_id":"c85685397f7be9792f8bf268e57cdf8f2ff2c98f"}],"tests/unit/plugins/openstack/context/cleanup/test_resources.py":[{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"b508152fdfd91a6da43632a7074dfd97eeaa8f2a","unresolved":false,"context_lines":[{"line_number":146,"context_line":"        network[1].label \u003d \"rally_novanet\""},{"line_number":147,"context_line":"        network[2].label \u003d \"rally_novanet\""},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"        mock_manager().list.return_value \u003d network"},{"line_number":150,"context_line":"        self.assertEqual(network[1:], resources.NovaNetworks().list())"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"5afe65bd_1d6875b8","line":149,"updated":"2015-06-04 16:08:16.000000000","message":"mock_manager.return_value.list.return_value \u003d network","commit_id":"e5cbcca824468a90df75e98a2ae9c498f4025045"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"b508152fdfd91a6da43632a7074dfd97eeaa8f2a","unresolved":false,"context_lines":[{"line_number":147,"context_line":"        network[2].label \u003d \"rally_novanet\""},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"        mock_manager().list.return_value \u003d network"},{"line_number":150,"context_line":"        self.assertEqual(network[1:], resources.NovaNetworks().list())"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"class EC2MixinTestCase(test.TestCase):"}],"source_content_type":"text/x-python","patch_set":14,"id":"5afe65bd_bd84c15d","line":150,"updated":"2015-06-04 16:08:16.000000000","message":"where is the assertation to check that mock_manager.list were called?","commit_id":"e5cbcca824468a90df75e98a2ae9c498f4025045"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"ba94aa1a7141c6e7801703b2c4c3ce9d5b931246","unresolved":false,"context_lines":[{"line_number":141,"context_line":""},{"line_number":142,"context_line":"    @mock.patch(\"%s.base.ResourceManager._manager\" % BASE)"},{"line_number":143,"context_line":"    def test_list(self, mock_resource_manager__manager):"},{"line_number":144,"context_line":"        network \u003d [mock.MagicMock(), mock.MagicMock(), mock.MagicMock()]"},{"line_number":145,"context_line":"        network[0].label \u003d \"a\""},{"line_number":146,"context_line":"        network[1].label \u003d \"rally_novanet_a\""},{"line_number":147,"context_line":"        network[2].label \u003d \"rally_novanet_b\""}],"source_content_type":"text/x-python","patch_set":19,"id":"9a41bdd9_33488987","line":144,"updated":"2015-07-17 00:23:59.000000000","message":"L144-147 can be rewritten more compact:\n\n network \u003d [mock.Mock(label\u003d\"a\"), mock.Mock(label\u003d\"rally_novanet_a\"),\n            mock.Mock(label\u003d\"rally_novanet_b\")]","commit_id":"313e351ec8cfd7b38448e71d90b33c80371900dd"}],"tests/unit/plugins/openstack/scenarios/nova/test_networks.py":[{"author":{"_account_id":8507,"name":"Mikhail Dubov","email":"mdubov@mirantis.com","username":"msdubov"},"change_message_id":"7af57835d9b77caef2b6f04ecb1cbf88512e8e01","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"class NovaNetworksTestCase(test.TestCase):"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    def test_create_and_list_network(self):"},{"line_number":25,"context_line":"        scenario \u003d networks.NovaNetworks()"},{"line_number":26,"context_line":"        scenario._create_network \u003d mock.MagicMock()"},{"line_number":27,"context_line":"        scenario._list_networks \u003d mock.MagicMock()"}],"source_content_type":"text/x-python","patch_set":12,"id":"7a016987_c48f16cb","line":24,"updated":"2015-05-26 18:11:33.000000000","message":"By the way, the test names better should precisely reflect those for methods being tested. So please \u0027_networks\u0027 here and \u0027_network\u0027 in the test below","commit_id":"ff3c4732a5d154df54edf230ad6aec5c50aa22a5"}]}