)]}'
{"rally-jobs/extra/autoscaling_group.yaml.template":[{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"dd8beb78667d479c54267c4c983f2bdd92189e2b","unresolved":false,"context_lines":[{"line_number":8,"context_line":"      - custom_constraint: nova.flavor"},{"line_number":9,"context_line":"  image:"},{"line_number":10,"context_line":"    type: string"},{"line_number":11,"context_line":"    default: cirros-0.3.2-x86_64-uec"},{"line_number":12,"context_line":"    constraints:"},{"line_number":13,"context_line":"      - custom_constraint: glance.image"},{"line_number":14,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":6,"id":"1aca2d91_02c7ef96","line":11,"updated":"2015-05-09 00:11:22.000000000","message":"Now in gates we have this one: \n\n cirros-0.3.4-x86_64-uec","commit_id":"54e8482d8be4cbe20f9a0a5b8d924a77c301b4ad"},{"author":{"_account_id":11748,"name":"Chris St. Pierre","email":"cstpierr@cisco.com","username":"stpierre"},"change_message_id":"4db147a6c05693de2ea12d18960b9ac74034b1b0","unresolved":false,"context_lines":[{"line_number":8,"context_line":"      - custom_constraint: nova.flavor"},{"line_number":9,"context_line":"  image:"},{"line_number":10,"context_line":"    type: string"},{"line_number":11,"context_line":"    default: cirros-0.3.2-x86_64-uec"},{"line_number":12,"context_line":"    constraints:"},{"line_number":13,"context_line":"      - custom_constraint: glance.image"},{"line_number":14,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":6,"id":"5ad58531_edd22534","line":11,"in_reply_to":"1aca2d91_02c7ef96","updated":"2015-05-11 19:20:47.000000000","message":"Done","commit_id":"54e8482d8be4cbe20f9a0a5b8d924a77c301b4ad"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"d2f9bc45c5d0736636a7f471b59b89eb4ae65001","unresolved":false,"context_lines":[{"line_number":37,"context_line":"    properties:"},{"line_number":38,"context_line":"      adjustment_type: change_in_capacity"},{"line_number":39,"context_line":"      auto_scaling_group_id: {get_resource: asg}"},{"line_number":40,"context_line":"      scaling_adjustment: \u0027-1\u0027"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"outputs:"},{"line_number":43,"context_line":"  scale_up_url:"}],"source_content_type":"application/octet-stream","patch_set":12,"id":"5afe65bd_9d996971","line":40,"updated":"2015-06-02 17:07:32.000000000","message":"Remove quotes please","commit_id":"981a66728d2fdfee5dde2a8fd6ba7c5bf12de5cc"},{"author":{"_account_id":11748,"name":"Chris St. Pierre","email":"cstpierr@cisco.com","username":"stpierre"},"change_message_id":"0d40809937f67dea9b11cee536f308cc98206b30","unresolved":false,"context_lines":[{"line_number":37,"context_line":"    properties:"},{"line_number":38,"context_line":"      adjustment_type: change_in_capacity"},{"line_number":39,"context_line":"      auto_scaling_group_id: {get_resource: asg}"},{"line_number":40,"context_line":"      scaling_adjustment: \u0027-1\u0027"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"outputs:"},{"line_number":43,"context_line":"  scale_up_url:"}],"source_content_type":"application/octet-stream","patch_set":12,"id":"5afe65bd_cb7da5e8","line":40,"in_reply_to":"5afe65bd_9d996971","updated":"2015-06-03 16:14:10.000000000","message":"Done","commit_id":"981a66728d2fdfee5dde2a8fd6ba7c5bf12de5cc"},{"author":{"_account_id":14676,"name":"Kairat Kushaev","email":"kkushaev@mirantis.com","username":"kairat_kushaev"},"change_message_id":"deb8d2f962da2330c592a895af93bfe86dd69e1e","unresolved":false,"context_lines":[{"line_number":30,"context_line":"    properties:"},{"line_number":31,"context_line":"      adjustment_type: change_in_capacity"},{"line_number":32,"context_line":"      auto_scaling_group_id: {get_resource: asg}"},{"line_number":33,"context_line":"      scaling_adjustment: 1"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"  scale_down_policy:"},{"line_number":36,"context_line":"    type: OS::Heat::ScalingPolicy"}],"source_content_type":"application/octet-stream","patch_set":19,"id":"fa32b979_2a0c7893","line":33,"updated":"2015-06-15 12:50:39.000000000","message":"Same. Users might want to have this parameters to be 2 or 3.","commit_id":"411fb52582ee3b7eb2177858228e0ae42890fb27"},{"author":{"_account_id":14676,"name":"Kairat Kushaev","email":"kkushaev@mirantis.com","username":"kairat_kushaev"},"change_message_id":"deb8d2f962da2330c592a895af93bfe86dd69e1e","unresolved":false,"context_lines":[{"line_number":37,"context_line":"    properties:"},{"line_number":38,"context_line":"      adjustment_type: change_in_capacity"},{"line_number":39,"context_line":"      auto_scaling_group_id: {get_resource: asg}"},{"line_number":40,"context_line":"      scaling_adjustment: -1"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"outputs:"},{"line_number":43,"context_line":"  scale_up_url:"}],"source_content_type":"application/octet-stream","patch_set":19,"id":"fa32b979_ea269015","line":40,"updated":"2015-06-15 12:50:39.000000000","message":"Same.","commit_id":"411fb52582ee3b7eb2177858228e0ae42890fb27"}],"rally-jobs/heat.yaml":[{"author":{"_account_id":14676,"name":"Kairat Kushaev","email":"kkushaev@mirantis.com","username":"kairat_kushaev"},"change_message_id":"3c6d7e097fc03f0bc33fe10c55a43eeb3d533a82","unresolved":false,"context_lines":[{"line_number":213,"context_line":"    -"},{"line_number":214,"context_line":"      args:"},{"line_number":215,"context_line":"        template_path: \"/home/jenkins/.rally/extra/autoscaling_group.yaml.template\""},{"line_number":216,"context_line":"        output_key: \"scale_up_url\""},{"line_number":217,"context_line":"        delta: 1"},{"line_number":218,"context_line":"      runner:"},{"line_number":219,"context_line":"        type: \"constant\""}],"source_content_type":"text/x-yaml","patch_set":21,"id":"fa32b979_edf6038e","line":216,"updated":"2015-06-18 12:57:25.000000000","message":"Not sure that you need this parameter.\nWouldn\u0027t it be simplier to receive this parameter from stack output and apply appropriate alarm_url basing on delta parameter?\nFor example if delta is positive then we need to use scale_up_url that we can receive from stack_output.\nYou will also get rid of some redundant functions in utils in this case.","commit_id":"5fbaf593bd880ad647f5b55abf7cb218f709f3e4"},{"author":{"_account_id":11748,"name":"Chris St. Pierre","email":"cstpierr@cisco.com","username":"stpierre"},"change_message_id":"b6b8bf0a6b70f580793421b0662308b76ed41d23","unresolved":false,"context_lines":[{"line_number":213,"context_line":"    -"},{"line_number":214,"context_line":"      args:"},{"line_number":215,"context_line":"        template_path: \"/home/jenkins/.rally/extra/autoscaling_group.yaml.template\""},{"line_number":216,"context_line":"        output_key: \"scale_up_url\""},{"line_number":217,"context_line":"        delta: 1"},{"line_number":218,"context_line":"      runner:"},{"line_number":219,"context_line":"        type: \"constant\""}],"source_content_type":"text/x-yaml","patch_set":21,"id":"fa32b979_fffc6ab9","line":216,"in_reply_to":"fa32b979_edf6038e","updated":"2015-06-18 13:35:21.000000000","message":"That would constrain the Heat template, though: We\u0027d have to require that it contain at most two scaling policies; and that the output keys be called \"scale_up_url\" and \"scale_down_url.\" That would prevent, for instance, a single Heat template from being used to benchmark both absolute and percentage scaling.\n\nIt\u0027d also be hidden magic, IMO; output keys are (usually) arbitrary, but we\u0027d be requiring people to name their output keys very specific things and discovering them implicitly (i.e., magically) instead of being explicit about what key to use.","commit_id":"5fbaf593bd880ad647f5b55abf7cb218f709f3e4"},{"author":{"_account_id":14676,"name":"Kairat Kushaev","email":"kkushaev@mirantis.com","username":"kairat_kushaev"},"change_message_id":"11e505ac1f13e726a1f5e8f94ba0da6bdcaaaf29","unresolved":false,"context_lines":[{"line_number":213,"context_line":"    -"},{"line_number":214,"context_line":"      args:"},{"line_number":215,"context_line":"        template_path: \"/home/jenkins/.rally/extra/autoscaling_group.yaml.template\""},{"line_number":216,"context_line":"        output_key: \"scale_up_url\""},{"line_number":217,"context_line":"        delta: 1"},{"line_number":218,"context_line":"      runner:"},{"line_number":219,"context_line":"        type: \"constant\""}],"source_content_type":"text/x-yaml","patch_set":21,"id":"fa32b979_9c217db7","line":216,"in_reply_to":"fa32b979_fffc6ab9","updated":"2015-06-19 10:46:45.000000000","message":"Yep, agree, it had better go this way. The potential alternative could be just use resource get and extract the alarm_url attribute but it also requires some resource_id to be defined.","commit_id":"5fbaf593bd880ad647f5b55abf7cb218f709f3e4"}],"rally-jobs/rally.yaml":[{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"d2f9bc45c5d0736636a7f471b59b89eb4ae65001","unresolved":false,"context_lines":[{"line_number":1683,"context_line":"        scale_down_key: \"scale_down_url\""},{"line_number":1684,"context_line":"      runner:"},{"line_number":1685,"context_line":"        type: \"constant\""},{"line_number":1686,"context_line":"        times: 1"},{"line_number":1687,"context_line":"        concurrency: 1"},{"line_number":1688,"context_line":"      context:"},{"line_number":1689,"context_line":"        users:"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"5afe65bd_5d03f142","line":1686,"updated":"2015-06-02 17:07:32.000000000","message":"Why not to test it on concurrency? Lets make it 2-2","commit_id":"981a66728d2fdfee5dde2a8fd6ba7c5bf12de5cc"},{"author":{"_account_id":11748,"name":"Chris St. Pierre","email":"cstpierr@cisco.com","username":"stpierre"},"change_message_id":"0d40809937f67dea9b11cee536f308cc98206b30","unresolved":false,"context_lines":[{"line_number":1683,"context_line":"        scale_down_key: \"scale_down_url\""},{"line_number":1684,"context_line":"      runner:"},{"line_number":1685,"context_line":"        type: \"constant\""},{"line_number":1686,"context_line":"        times: 1"},{"line_number":1687,"context_line":"        concurrency: 1"},{"line_number":1688,"context_line":"      context:"},{"line_number":1689,"context_line":"        users:"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"5afe65bd_ab84a9d3","line":1686,"in_reply_to":"5afe65bd_5d03f142","updated":"2015-06-03 16:14:10.000000000","message":"Done","commit_id":"981a66728d2fdfee5dde2a8fd6ba7c5bf12de5cc"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"7c42578defeeec4158581e3a7d74a1f6a8854fc8","unresolved":false,"context_lines":[{"line_number":1726,"context_line":"      context:"},{"line_number":1727,"context_line":"        users:"},{"line_number":1728,"context_line":"          tenants: 2"},{"line_number":1729,"context_line":"          users_per_tenant: 3"},{"line_number":1730,"context_line":"      sla:"},{"line_number":1731,"context_line":"        failure_rate:"},{"line_number":1732,"context_line":"          max: 0"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"fa32b979_3e1122ad","line":1729,"updated":"2015-06-15 12:11:18.000000000","message":"`3\u0027 makes no sense - we have 6 users but only 2 iterations. Value of `1\u0027 is enough","commit_id":"892f1a7ead49ef27728a5f70f22e7aca72262ba9"},{"author":{"_account_id":11748,"name":"Chris St. Pierre","email":"cstpierr@cisco.com","username":"stpierre"},"change_message_id":"4a41682761e8aec76c0faeffb8f0cf94a354c5bd","unresolved":false,"context_lines":[{"line_number":1726,"context_line":"      context:"},{"line_number":1727,"context_line":"        users:"},{"line_number":1728,"context_line":"          tenants: 2"},{"line_number":1729,"context_line":"          users_per_tenant: 3"},{"line_number":1730,"context_line":"      sla:"},{"line_number":1731,"context_line":"        failure_rate:"},{"line_number":1732,"context_line":"          max: 0"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"fa32b979_cf52bedd","line":1729,"in_reply_to":"fa32b979_3e1122ad","updated":"2015-06-15 12:15:24.000000000","message":"Done","commit_id":"892f1a7ead49ef27728a5f70f22e7aca72262ba9"}],"rally/plugins/openstack/scenarios/heat/stacks.py":[{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"d2f9bc45c5d0736636a7f471b59b89eb4ae65001","unresolved":false,"context_lines":[{"line_number":135,"context_line":"        self._stack_webhook(stack, scale_up_key)"},{"line_number":136,"context_line":"        self.sleep_between(min_sleep, max_sleep)"},{"line_number":137,"context_line":"        self._stack_webhook(stack, scale_down_key)"},{"line_number":138,"context_line":"        self._delete_stack(stack)"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"    @types.set(template_path\u003dtypes.FileType)"},{"line_number":141,"context_line":"    @validation.required_services(consts.Service.HEAT)"}],"source_content_type":"text/x-python","patch_set":12,"id":"5afe65bd_a0207a9c","line":138,"updated":"2015-06-02 17:07:32.000000000","message":"Why not to delete it through cleanup? Or we need to specify deletion in docstring and name of scenario.","commit_id":"981a66728d2fdfee5dde2a8fd6ba7c5bf12de5cc"},{"author":{"_account_id":11748,"name":"Chris St. Pierre","email":"cstpierr@cisco.com","username":"stpierre"},"change_message_id":"0d40809937f67dea9b11cee536f308cc98206b30","unresolved":false,"context_lines":[{"line_number":135,"context_line":"        self._stack_webhook(stack, scale_up_key)"},{"line_number":136,"context_line":"        self.sleep_between(min_sleep, max_sleep)"},{"line_number":137,"context_line":"        self._stack_webhook(stack, scale_down_key)"},{"line_number":138,"context_line":"        self._delete_stack(stack)"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"    @types.set(template_path\u003dtypes.FileType)"},{"line_number":141,"context_line":"    @validation.required_services(consts.Service.HEAT)"}],"source_content_type":"text/x-python","patch_set":12,"id":"5afe65bd_2b79d9f6","line":138,"in_reply_to":"5afe65bd_a0207a9c","updated":"2015-06-03 16:14:10.000000000","message":"Done","commit_id":"981a66728d2fdfee5dde2a8fd6ba7c5bf12de5cc"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"f608a821c6d5a27d9c33502405c817c52c58671c","unresolved":false,"context_lines":[{"line_number":169,"context_line":"        self.sleep_between(min_sleep, max_sleep)"},{"line_number":170,"context_line":"        self._stack_webhook(stack, scale_down_key)"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"    @types.set(template_path\u003dtypes.FileType)"},{"line_number":173,"context_line":"    @validation.required_services(consts.Service.HEAT)"},{"line_number":174,"context_line":"    @validation.required_openstack(users\u003dTrue)"},{"line_number":175,"context_line":"    @base.scenario(context\u003d{\"cleanup\": [\"heat\"]})"}],"source_content_type":"text/x-python","patch_set":17,"id":"1af86dd1_4f7eb3af","line":172,"updated":"2015-06-12 11:28:36.000000000","message":"Why this line is changed(keyargument \u0027files\u003dtypes.FileTypeDict\u0027 is removed? It looks like unrelated change","commit_id":"2de2949d7746a9f1ec50c3b29f600018941d5d58"},{"author":{"_account_id":11748,"name":"Chris St. Pierre","email":"cstpierr@cisco.com","username":"stpierre"},"change_message_id":"14202e1b7565b8a45604e677b981c48f0fd81e5a","unresolved":false,"context_lines":[{"line_number":169,"context_line":"        self.sleep_between(min_sleep, max_sleep)"},{"line_number":170,"context_line":"        self._stack_webhook(stack, scale_down_key)"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"    @types.set(template_path\u003dtypes.FileType)"},{"line_number":173,"context_line":"    @validation.required_services(consts.Service.HEAT)"},{"line_number":174,"context_line":"    @validation.required_openstack(users\u003dTrue)"},{"line_number":175,"context_line":"    @base.scenario(context\u003d{\"cleanup\": [\"heat\"]})"}],"source_content_type":"text/x-python","patch_set":17,"id":"1af86dd1_41e207d7","line":172,"in_reply_to":"1af86dd1_4f7eb3af","updated":"2015-06-12 12:56:37.000000000","message":"I\u0027m guessing that\u0027s merge cruft. Fixed.","commit_id":"2de2949d7746a9f1ec50c3b29f600018941d5d58"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"7c42578defeeec4158581e3a7d74a1f6a8854fc8","unresolved":false,"context_lines":[{"line_number":163,"context_line":"        :param scale_up_key: stack output key for the scale up URL"},{"line_number":164,"context_line":"        :param scale_down_key: stack output key for the scale down URL"},{"line_number":165,"context_line":"        :param parameters: parameters to use in heat template"},{"line_number":166,"context_line":"        :param files: files used in template"},{"line_number":167,"context_line":"        :param environment: stack environment definition"},{"line_number":168,"context_line":"        :param min_sleep: Minimum sleep time in seconds (non-negative)"},{"line_number":169,"context_line":"        :param max_sleep: Maximum sleep time in seconds (non-negative)"}],"source_content_type":"text/x-python","patch_set":18,"id":"fa32b979_99040816","line":166,"updated":"2015-06-15 12:11:18.000000000","message":"Maybe `list of files paths\u0027? Or `dict mapping files names to files paths\u0027? Please make this param definition more clear","commit_id":"892f1a7ead49ef27728a5f70f22e7aca72262ba9"},{"author":{"_account_id":11748,"name":"Chris St. Pierre","email":"cstpierr@cisco.com","username":"stpierre"},"change_message_id":"4a41682761e8aec76c0faeffb8f0cf94a354c5bd","unresolved":false,"context_lines":[{"line_number":163,"context_line":"        :param scale_up_key: stack output key for the scale up URL"},{"line_number":164,"context_line":"        :param scale_down_key: stack output key for the scale down URL"},{"line_number":165,"context_line":"        :param parameters: parameters to use in heat template"},{"line_number":166,"context_line":"        :param files: files used in template"},{"line_number":167,"context_line":"        :param environment: stack environment definition"},{"line_number":168,"context_line":"        :param min_sleep: Minimum sleep time in seconds (non-negative)"},{"line_number":169,"context_line":"        :param max_sleep: Maximum sleep time in seconds (non-negative)"}],"source_content_type":"text/x-python","patch_set":18,"id":"fa32b979_0f1e660c","line":166,"in_reply_to":"fa32b979_99040816","updated":"2015-06-15 12:15:24.000000000","message":"Done","commit_id":"892f1a7ead49ef27728a5f70f22e7aca72262ba9"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"7c42578defeeec4158581e3a7d74a1f6a8854fc8","unresolved":false,"context_lines":[{"line_number":164,"context_line":"        :param scale_down_key: stack output key for the scale down URL"},{"line_number":165,"context_line":"        :param parameters: parameters to use in heat template"},{"line_number":166,"context_line":"        :param files: files used in template"},{"line_number":167,"context_line":"        :param environment: stack environment definition"},{"line_number":168,"context_line":"        :param min_sleep: Minimum sleep time in seconds (non-negative)"},{"line_number":169,"context_line":"        :param max_sleep: Maximum sleep time in seconds (non-negative)"},{"line_number":170,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":18,"id":"fa32b979_feff3a32","line":167,"updated":"2015-06-15 12:11:18.000000000","message":"Please add type definition `dict\u0027","commit_id":"892f1a7ead49ef27728a5f70f22e7aca72262ba9"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"fd6f3125cd478081d9510cada99740c3985b8646","unresolved":false,"context_lines":[{"line_number":164,"context_line":"        :param scale_down_key: stack output key for the scale down URL"},{"line_number":165,"context_line":"        :param parameters: parameters to use in heat template"},{"line_number":166,"context_line":"        :param files: files used in template"},{"line_number":167,"context_line":"        :param environment: stack environment definition"},{"line_number":168,"context_line":"        :param min_sleep: Minimum sleep time in seconds (non-negative)"},{"line_number":169,"context_line":"        :param max_sleep: Maximum sleep time in seconds (non-negative)"},{"line_number":170,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":18,"id":"fa32b979_cae4ec3c","line":167,"in_reply_to":"fa32b979_af1ada15","updated":"2015-06-15 12:34:59.000000000","message":"That would be nice","commit_id":"892f1a7ead49ef27728a5f70f22e7aca72262ba9"},{"author":{"_account_id":11748,"name":"Chris St. Pierre","email":"cstpierr@cisco.com","username":"stpierre"},"change_message_id":"4a41682761e8aec76c0faeffb8f0cf94a354c5bd","unresolved":false,"context_lines":[{"line_number":164,"context_line":"        :param scale_down_key: stack output key for the scale down URL"},{"line_number":165,"context_line":"        :param parameters: parameters to use in heat template"},{"line_number":166,"context_line":"        :param files: files used in template"},{"line_number":167,"context_line":"        :param environment: stack environment definition"},{"line_number":168,"context_line":"        :param min_sleep: Minimum sleep time in seconds (non-negative)"},{"line_number":169,"context_line":"        :param max_sleep: Maximum sleep time in seconds (non-negative)"},{"line_number":170,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":18,"id":"fa32b979_af1ada15","line":167,"in_reply_to":"fa32b979_feff3a32","updated":"2015-06-15 12:15:24.000000000","message":"Done.\n\nFWIW, the definitions for both \u0027files\u0027 and \u0027environment\u0027 were copied from every other scenario in this module, so we probably want to fix them all at some point.","commit_id":"892f1a7ead49ef27728a5f70f22e7aca72262ba9"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"7c42578defeeec4158581e3a7d74a1f6a8854fc8","unresolved":false,"context_lines":[{"line_number":165,"context_line":"        :param parameters: parameters to use in heat template"},{"line_number":166,"context_line":"        :param files: files used in template"},{"line_number":167,"context_line":"        :param environment: stack environment definition"},{"line_number":168,"context_line":"        :param min_sleep: Minimum sleep time in seconds (non-negative)"},{"line_number":169,"context_line":"        :param max_sleep: Maximum sleep time in seconds (non-negative)"},{"line_number":170,"context_line":"        \"\"\""},{"line_number":171,"context_line":"        stack \u003d self._create_stack(template_path, parameters, files,"}],"source_content_type":"text/x-python","patch_set":18,"id":"fa32b979_de77d6d2","line":168,"updated":"2015-06-15 12:11:18.000000000","message":"Can seconds be float? Please add type definition\n\n :param min_sleep: Minimum sleep time in float seconds","commit_id":"892f1a7ead49ef27728a5f70f22e7aca72262ba9"},{"author":{"_account_id":11748,"name":"Chris St. Pierre","email":"cstpierr@cisco.com","username":"stpierre"},"change_message_id":"4a41682761e8aec76c0faeffb8f0cf94a354c5bd","unresolved":false,"context_lines":[{"line_number":165,"context_line":"        :param parameters: parameters to use in heat template"},{"line_number":166,"context_line":"        :param files: files used in template"},{"line_number":167,"context_line":"        :param environment: stack environment definition"},{"line_number":168,"context_line":"        :param min_sleep: Minimum sleep time in seconds (non-negative)"},{"line_number":169,"context_line":"        :param max_sleep: Maximum sleep time in seconds (non-negative)"},{"line_number":170,"context_line":"        \"\"\""},{"line_number":171,"context_line":"        stack \u003d self._create_stack(template_path, parameters, files,"}],"source_content_type":"text/x-python","patch_set":18,"id":"fa32b979_2f0faae2","line":168,"in_reply_to":"fa32b979_de77d6d2","updated":"2015-06-15 12:15:24.000000000","message":"Done","commit_id":"892f1a7ead49ef27728a5f70f22e7aca72262ba9"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"7c42578defeeec4158581e3a7d74a1f6a8854fc8","unresolved":false,"context_lines":[{"line_number":166,"context_line":"        :param files: files used in template"},{"line_number":167,"context_line":"        :param environment: stack environment definition"},{"line_number":168,"context_line":"        :param min_sleep: Minimum sleep time in seconds (non-negative)"},{"line_number":169,"context_line":"        :param max_sleep: Maximum sleep time in seconds (non-negative)"},{"line_number":170,"context_line":"        \"\"\""},{"line_number":171,"context_line":"        stack \u003d self._create_stack(template_path, parameters, files,"},{"line_number":172,"context_line":"                                   environment)"}],"source_content_type":"text/x-python","patch_set":18,"id":"fa32b979_b906ac1e","line":169,"updated":"2015-06-15 12:11:18.000000000","message":"ditto","commit_id":"892f1a7ead49ef27728a5f70f22e7aca72262ba9"},{"author":{"_account_id":11748,"name":"Chris St. Pierre","email":"cstpierr@cisco.com","username":"stpierre"},"change_message_id":"4a41682761e8aec76c0faeffb8f0cf94a354c5bd","unresolved":false,"context_lines":[{"line_number":166,"context_line":"        :param files: files used in template"},{"line_number":167,"context_line":"        :param environment: stack environment definition"},{"line_number":168,"context_line":"        :param min_sleep: Minimum sleep time in seconds (non-negative)"},{"line_number":169,"context_line":"        :param max_sleep: Maximum sleep time in seconds (non-negative)"},{"line_number":170,"context_line":"        \"\"\""},{"line_number":171,"context_line":"        stack \u003d self._create_stack(template_path, parameters, files,"},{"line_number":172,"context_line":"                                   environment)"}],"source_content_type":"text/x-python","patch_set":18,"id":"fa32b979_eff9c2c9","line":169,"in_reply_to":"fa32b979_b906ac1e","updated":"2015-06-15 12:15:24.000000000","message":"Done","commit_id":"892f1a7ead49ef27728a5f70f22e7aca72262ba9"},{"author":{"_account_id":14676,"name":"Kairat Kushaev","email":"kkushaev@mirantis.com","username":"kairat_kushaev"},"change_message_id":"deb8d2f962da2330c592a895af93bfe86dd69e1e","unresolved":false,"context_lines":[{"line_number":172,"context_line":"        stack \u003d self._create_stack(template_path, parameters, files,"},{"line_number":173,"context_line":"                                   environment)"},{"line_number":174,"context_line":"        self.sleep_between(min_sleep, max_sleep)"},{"line_number":175,"context_line":"        self._stack_webhook(stack, scale_up_key)"},{"line_number":176,"context_line":"        self.sleep_between(min_sleep, max_sleep)"},{"line_number":177,"context_line":"        self._stack_webhook(stack, scale_down_key)"},{"line_number":178,"context_line":""}],"source_content_type":"text/x-python","patch_set":19,"id":"fa32b979_0ad974f3","line":175,"updated":"2015-06-15 12:50:39.000000000","message":"Are we testing the performance of POST request here?\nIt seems that we need to check stack status and current_size parameter of AutoScaling Group to be sure that group has scaled correctly.\nThe same should be when we downsize the stack.","commit_id":"411fb52582ee3b7eb2177858228e0ae42890fb27"},{"author":{"_account_id":8840,"name":"Carlos L. Torres","email":"carlos.torres@rackspace.com","username":"carl6796"},"change_message_id":"9287b1b5cde7925f9a6749930b4fb882eb74dd2d","unresolved":false,"context_lines":[{"line_number":144,"context_line":"    @validation.required_services(consts.Service.HEAT)"},{"line_number":145,"context_line":"    @validation.required_openstack(users\u003dTrue)"},{"line_number":146,"context_line":"    @base.scenario(context\u003d{\"cleanup\": [\"heat\"]})"},{"line_number":147,"context_line":"    def create_stack_and_scale(self, template_path, output_key, delta,"},{"line_number":148,"context_line":"                               parameters\u003dNone, files\u003dNone,"},{"line_number":149,"context_line":"                               environment\u003dNone):"},{"line_number":150,"context_line":"        \"\"\"Create an autoscaling stack and invoke a scaling policy."}],"source_content_type":"text/x-python","patch_set":21,"id":"fa32b979_385b2f89","line":147,"updated":"2015-06-16 16:45:49.000000000","message":"Maybe I\u0027m missing something important, but please, can you give a reason(s) to prefer \u0027delta\u0027 over just the expected number of instances?","commit_id":"5fbaf593bd880ad647f5b55abf7cb218f709f3e4"},{"author":{"_account_id":11748,"name":"Chris St. Pierre","email":"cstpierr@cisco.com","username":"stpierre"},"change_message_id":"39cd5e9c51e7429e13cf778c77822702f87cca70","unresolved":false,"context_lines":[{"line_number":144,"context_line":"    @validation.required_services(consts.Service.HEAT)"},{"line_number":145,"context_line":"    @validation.required_openstack(users\u003dTrue)"},{"line_number":146,"context_line":"    @base.scenario(context\u003d{\"cleanup\": [\"heat\"]})"},{"line_number":147,"context_line":"    def create_stack_and_scale(self, template_path, output_key, delta,"},{"line_number":148,"context_line":"                               parameters\u003dNone, files\u003dNone,"},{"line_number":149,"context_line":"                               environment\u003dNone):"},{"line_number":150,"context_line":"        \"\"\"Create an autoscaling stack and invoke a scaling policy."}],"source_content_type":"text/x-python","patch_set":21,"id":"fa32b979_d35ea411","line":147,"in_reply_to":"fa32b979_385b2f89","updated":"2015-06-16 16:50:55.000000000","message":"In an absolute scaling policy, you already are setting the delta (not the expected number of instances) in the Heat template, so you can just repeat that datum here instead of doing math. (Unfortunately I couldn\u0027t find a way to directly interrogate the Heat resources so that you wouldn\u0027t have to do that.)\n\nIn the case of a percentage scaling policy, you have to do math either way so there\u0027s no particular advantage one way or the other.","commit_id":"5fbaf593bd880ad647f5b55abf7cb218f709f3e4"},{"author":{"_account_id":8840,"name":"Carlos L. Torres","email":"carlos.torres@rackspace.com","username":"carl6796"},"change_message_id":"d2c8441b540e7f41cbd1b73420f7dc5d6a6646c3","unresolved":false,"context_lines":[{"line_number":144,"context_line":"    @validation.required_services(consts.Service.HEAT)"},{"line_number":145,"context_line":"    @validation.required_openstack(users\u003dTrue)"},{"line_number":146,"context_line":"    @base.scenario(context\u003d{\"cleanup\": [\"heat\"]})"},{"line_number":147,"context_line":"    def create_stack_and_scale(self, template_path, output_key, delta,"},{"line_number":148,"context_line":"                               parameters\u003dNone, files\u003dNone,"},{"line_number":149,"context_line":"                               environment\u003dNone):"},{"line_number":150,"context_line":"        \"\"\"Create an autoscaling stack and invoke a scaling policy."}],"source_content_type":"text/x-python","patch_set":21,"id":"fa32b979_f3c5e88d","line":147,"in_reply_to":"fa32b979_d35ea411","updated":"2015-06-16 16:54:20.000000000","message":"Ok, that\u0027s fair. Especially that it has the same semantics as in the  Heat template.\n\nDo you think scale_adjustment would be a better name for the parameter?","commit_id":"5fbaf593bd880ad647f5b55abf7cb218f709f3e4"}],"rally/plugins/openstack/scenarios/heat/utils.py":[{"author":{"_account_id":8507,"name":"Mikhail Dubov","email":"mdubov@mirantis.com","username":"msdubov"},"change_message_id":"098b8e5f112b3a8224ddbc5397cbf9a878c78485","unresolved":false,"context_lines":[{"line_number":222,"context_line":""},{"line_number":223,"context_line":"        :param stack: stack to call a webhook on"},{"line_number":224,"context_line":"        :param output_key: The name of the output to get the URL from"},{"line_number":225,"context_line":"        :param count: Number of times to invoke the hook"},{"line_number":226,"context_line":"        \"\"\""},{"line_number":227,"context_line":"        url \u003d None"},{"line_number":228,"context_line":"        for output in stack.outputs:"}],"source_content_type":"text/x-python","patch_set":11,"id":"7a016987_408124c2","line":225,"updated":"2015-06-01 09:58:54.000000000","message":"This parameter does not exist, please update the docstring.","commit_id":"4377d2f970a0160779d2b1f6459395f6adb1e5b5"},{"author":{"_account_id":11748,"name":"Chris St. Pierre","email":"cstpierr@cisco.com","username":"stpierre"},"change_message_id":"9f2d25c76dfa8f0b1f40c0e77e8f1c8b6b0bacc0","unresolved":false,"context_lines":[{"line_number":222,"context_line":""},{"line_number":223,"context_line":"        :param stack: stack to call a webhook on"},{"line_number":224,"context_line":"        :param output_key: The name of the output to get the URL from"},{"line_number":225,"context_line":"        :param count: Number of times to invoke the hook"},{"line_number":226,"context_line":"        \"\"\""},{"line_number":227,"context_line":"        url \u003d None"},{"line_number":228,"context_line":"        for output in stack.outputs:"}],"source_content_type":"text/x-python","patch_set":11,"id":"7a016987_ddef36e7","line":225,"in_reply_to":"7a016987_408124c2","updated":"2015-06-01 14:33:08.000000000","message":"Done","commit_id":"4377d2f970a0160779d2b1f6459395f6adb1e5b5"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"d2f9bc45c5d0736636a7f471b59b89eb4ae65001","unresolved":false,"context_lines":[{"line_number":221,"context_line":"        This can be used to scale stacks up and down, for instance."},{"line_number":222,"context_line":""},{"line_number":223,"context_line":"        :param stack: stack to call a webhook on"},{"line_number":224,"context_line":"        :param output_key: The name of the output to get the URL from"},{"line_number":225,"context_line":"        \"\"\""},{"line_number":226,"context_line":"        url \u003d None"},{"line_number":227,"context_line":"        for output in stack.outputs:"}],"source_content_type":"text/x-python","patch_set":12,"id":"5afe65bd_2bcc6b88","line":224,"updated":"2015-06-02 17:07:32.000000000","message":"need to document :raises","commit_id":"981a66728d2fdfee5dde2a8fd6ba7c5bf12de5cc"},{"author":{"_account_id":11748,"name":"Chris St. Pierre","email":"cstpierr@cisco.com","username":"stpierre"},"change_message_id":"0d40809937f67dea9b11cee536f308cc98206b30","unresolved":false,"context_lines":[{"line_number":221,"context_line":"        This can be used to scale stacks up and down, for instance."},{"line_number":222,"context_line":""},{"line_number":223,"context_line":"        :param stack: stack to call a webhook on"},{"line_number":224,"context_line":"        :param output_key: The name of the output to get the URL from"},{"line_number":225,"context_line":"        \"\"\""},{"line_number":226,"context_line":"        url \u003d None"},{"line_number":227,"context_line":"        for output in stack.outputs:"}],"source_content_type":"text/x-python","patch_set":12,"id":"5afe65bd_2be799b1","line":224,"in_reply_to":"5afe65bd_2bcc6b88","updated":"2015-06-03 16:14:10.000000000","message":"Done","commit_id":"981a66728d2fdfee5dde2a8fd6ba7c5bf12de5cc"},{"author":{"_account_id":14676,"name":"Kairat Kushaev","email":"kkushaev@mirantis.com","username":"kairat_kushaev"},"change_message_id":"deb8d2f962da2330c592a895af93bfe86dd69e1e","unresolved":false,"context_lines":[{"line_number":243,"context_line":"                \"No output key %(key)s found in stack %(id)s\" %"},{"line_number":244,"context_line":"                {\"key\": output_key, \"id\": stack.id})"},{"line_number":245,"context_line":""},{"line_number":246,"context_line":"        with base.AtomicAction(self, \"heat.%s_webhook\" % output_key):"},{"line_number":247,"context_line":"            requests.post(url).raise_for_status()"}],"source_content_type":"text/x-python","patch_set":19,"id":"fa32b979_eab0d08d","line":246,"updated":"2015-06-15 12:50:39.000000000","message":"Not sure that we need it.\nThe actual performance of scaling (how long does it take to scale autoscaling group) would be more useful. So I guess you need to check current_size parameter of AutoScaling group.","commit_id":"411fb52582ee3b7eb2177858228e0ae42890fb27"},{"author":{"_account_id":14676,"name":"Kairat Kushaev","email":"kkushaev@mirantis.com","username":"kairat_kushaev"},"change_message_id":"3c6d7e097fc03f0bc33fe10c55a43eeb3d533a82","unresolved":false,"context_lines":[{"line_number":238,"context_line":""},{"line_number":239,"context_line":"        :param stack: stack to count instances in."},{"line_number":240,"context_line":"        \"\"\""},{"line_number":241,"context_line":"        return len(["},{"line_number":242,"context_line":"            r for r in self.clients(\"heat\").resources.list(stack.id,"},{"line_number":243,"context_line":"                                                           nested_depth\u003d1)"},{"line_number":244,"context_line":"            if r.resource_type \u003d\u003d \"OS::Nova::Server\"])"}],"source_content_type":"text/x-python","patch_set":21,"id":"fa32b979_8dbdf703","line":241,"updated":"2015-06-18 12:57:25.000000000","message":"I think you can use current_size attribute of autoscaling group instead of iterating through all the resources.\nSee here: http://docs.openstack.org/developer/heat/template_guide/openstack.html#OS::Heat::AutoScalingGroup","commit_id":"5fbaf593bd880ad647f5b55abf7cb218f709f3e4"},{"author":{"_account_id":11748,"name":"Chris St. Pierre","email":"cstpierr@cisco.com","username":"stpierre"},"change_message_id":"b6b8bf0a6b70f580793421b0662308b76ed41d23","unresolved":false,"context_lines":[{"line_number":238,"context_line":""},{"line_number":239,"context_line":"        :param stack: stack to count instances in."},{"line_number":240,"context_line":"        \"\"\""},{"line_number":241,"context_line":"        return len(["},{"line_number":242,"context_line":"            r for r in self.clients(\"heat\").resources.list(stack.id,"},{"line_number":243,"context_line":"                                                           nested_depth\u003d1)"},{"line_number":244,"context_line":"            if r.resource_type \u003d\u003d \"OS::Nova::Server\"])"}],"source_content_type":"text/x-python","patch_set":21,"id":"fa32b979_c2fbc945","line":241,"in_reply_to":"fa32b979_8dbdf703","updated":"2015-06-18 13:35:21.000000000","message":"That attribute was added in Kilo, so relying on it would break Juno compatibility. Since Juno is still supported, I don\u0027t think that\u0027s ideal.","commit_id":"5fbaf593bd880ad647f5b55abf7cb218f709f3e4"},{"author":{"_account_id":14676,"name":"Kairat Kushaev","email":"kkushaev@mirantis.com","username":"kairat_kushaev"},"change_message_id":"11e505ac1f13e726a1f5e8f94ba0da6bdcaaaf29","unresolved":false,"context_lines":[{"line_number":238,"context_line":""},{"line_number":239,"context_line":"        :param stack: stack to count instances in."},{"line_number":240,"context_line":"        \"\"\""},{"line_number":241,"context_line":"        return len(["},{"line_number":242,"context_line":"            r for r in self.clients(\"heat\").resources.list(stack.id,"},{"line_number":243,"context_line":"                                                           nested_depth\u003d1)"},{"line_number":244,"context_line":"            if r.resource_type \u003d\u003d \"OS::Nova::Server\"])"}],"source_content_type":"text/x-python","patch_set":21,"id":"fa32b979_fcc5290a","line":241,"in_reply_to":"fa32b979_c2fbc945","updated":"2015-06-19 10:46:45.000000000","message":"Ok, that makes sense","commit_id":"5fbaf593bd880ad647f5b55abf7cb218f709f3e4"},{"author":{"_account_id":14676,"name":"Kairat Kushaev","email":"kkushaev@mirantis.com","username":"kairat_kushaev"},"change_message_id":"11e505ac1f13e726a1f5e8f94ba0da6bdcaaaf29","unresolved":false,"context_lines":[{"line_number":260,"context_line":"        LOG.debug(\"Scaling stack %s from %s to %s instances with %s\" %"},{"line_number":261,"context_line":"                  (stack.id, num_instances, expected_instances, output_key))"},{"line_number":262,"context_line":"        with base.AtomicAction(self, \"heat.scale_with_%s\" % output_key):"},{"line_number":263,"context_line":"            self._stack_webhook(stack, output_key)"},{"line_number":264,"context_line":"            bench_utils.wait_for("},{"line_number":265,"context_line":"                stack,"},{"line_number":266,"context_line":"                is_ready\u003dlambda s: ("}],"source_content_type":"text/x-python","patch_set":21,"id":"fa32b979_f77222b0","line":263,"updated":"2015-06-19 10:46:45.000000000","message":"Ok, If I understand correctly the algorithm is the following:\n1. define desired num of instances\n2. send one request to scale (that will be defined by scale adjustment)\n3. wait until we reach the desired number of instances.\nIf I understand correctly we will not reach success in the following case:\ndelta \u003d 3\nscaling adjustment \u003d 1 \nThat happens because we are sending only one request for scale.\nSo If you planned to make only one adjustment wouldn\u0027t it be useful to validate the case above somehow? Otherwise, it is better to send several requests for scale.","commit_id":"5fbaf593bd880ad647f5b55abf7cb218f709f3e4"},{"author":{"_account_id":14676,"name":"Kairat Kushaev","email":"kkushaev@mirantis.com","username":"kairat_kushaev"},"change_message_id":"3c6d7e097fc03f0bc33fe10c55a43eeb3d533a82","unresolved":false,"context_lines":[{"line_number":287,"context_line":"                \"No output key %(key)s found in stack %(id)s\" %"},{"line_number":288,"context_line":"                {\"key\": output_key, \"id\": stack.id})"},{"line_number":289,"context_line":""},{"line_number":290,"context_line":"        with base.AtomicAction(self, \"heat.%s_webhook\" % output_key):"},{"line_number":291,"context_line":"            requests.post(url).raise_for_status()"}],"source_content_type":"text/x-python","patch_set":21,"id":"fa32b979_cd053f46","line":290,"updated":"2015-06-18 12:57:25.000000000","message":"I am not sure we need this because it measures just performance of post request. Do we really need this?","commit_id":"5fbaf593bd880ad647f5b55abf7cb218f709f3e4"},{"author":{"_account_id":14676,"name":"Kairat Kushaev","email":"kkushaev@mirantis.com","username":"kairat_kushaev"},"change_message_id":"11e505ac1f13e726a1f5e8f94ba0da6bdcaaaf29","unresolved":false,"context_lines":[{"line_number":287,"context_line":"                \"No output key %(key)s found in stack %(id)s\" %"},{"line_number":288,"context_line":"                {\"key\": output_key, \"id\": stack.id})"},{"line_number":289,"context_line":""},{"line_number":290,"context_line":"        with base.AtomicAction(self, \"heat.%s_webhook\" % output_key):"},{"line_number":291,"context_line":"            requests.post(url).raise_for_status()"}],"source_content_type":"text/x-python","patch_set":21,"id":"fa32b979_58280c33","line":290,"in_reply_to":"fa32b979_3fdc1245","updated":"2015-06-19 10:46:45.000000000","message":"So here is responsibility of rally guys.","commit_id":"5fbaf593bd880ad647f5b55abf7cb218f709f3e4"},{"author":{"_account_id":11748,"name":"Chris St. Pierre","email":"cstpierr@cisco.com","username":"stpierre"},"change_message_id":"b6b8bf0a6b70f580793421b0662308b76ed41d23","unresolved":false,"context_lines":[{"line_number":287,"context_line":"                \"No output key %(key)s found in stack %(id)s\" %"},{"line_number":288,"context_line":"                {\"key\": output_key, \"id\": stack.id})"},{"line_number":289,"context_line":""},{"line_number":290,"context_line":"        with base.AtomicAction(self, \"heat.%s_webhook\" % output_key):"},{"line_number":291,"context_line":"            requests.post(url).raise_for_status()"}],"source_content_type":"text/x-python","patch_set":21,"id":"fa32b979_3fdc1245","line":290,"in_reply_to":"fa32b979_cd053f46","updated":"2015-06-18 13:35:21.000000000","message":"Yes. It may just be a POST, but it takes time and can and should be measured.","commit_id":"5fbaf593bd880ad647f5b55abf7cb218f709f3e4"},{"author":{"_account_id":14676,"name":"Kairat Kushaev","email":"kkushaev@mirantis.com","username":"kairat_kushaev"},"change_message_id":"a8b483f9db38837a8df10cb08ab3b68511f556b4","unresolved":false,"context_lines":[{"line_number":260,"context_line":"        LOG.debug(\"Scaling stack %s from %s to %s instances with %s\" %"},{"line_number":261,"context_line":"                  (stack.id, num_instances, expected_instances, output_key))"},{"line_number":262,"context_line":"        with base.AtomicAction(self, \"heat.scale_with_%s\" % output_key):"},{"line_number":263,"context_line":"            self._stack_webhook(stack, output_key)"},{"line_number":264,"context_line":"            bench_utils.wait_for("},{"line_number":265,"context_line":"                stack,"},{"line_number":266,"context_line":"                is_ready\u003dlambda s: ("}],"source_content_type":"text/x-python","patch_set":22,"id":"fa32b979_e9577424","line":263,"updated":"2015-06-22 08:02:21.000000000","message":"Ok, the question still the same.\nDo we need to send several requests if delta is too big and we need several scaling adjustments to reach expected_instances?","commit_id":"4ec60acd48236b455607e11207ca736d7b0be79a"},{"author":{"_account_id":11748,"name":"Chris St. Pierre","email":"cstpierr@cisco.com","username":"stpierre"},"change_message_id":"aa35b22882960a0a7369aa3196e4c5e587ee48ae","unresolved":false,"context_lines":[{"line_number":260,"context_line":"        LOG.debug(\"Scaling stack %s from %s to %s instances with %s\" %"},{"line_number":261,"context_line":"                  (stack.id, num_instances, expected_instances, output_key))"},{"line_number":262,"context_line":"        with base.AtomicAction(self, \"heat.scale_with_%s\" % output_key):"},{"line_number":263,"context_line":"            self._stack_webhook(stack, output_key)"},{"line_number":264,"context_line":"            bench_utils.wait_for("},{"line_number":265,"context_line":"                stack,"},{"line_number":266,"context_line":"                is_ready\u003dlambda s: ("}],"source_content_type":"text/x-python","patch_set":22,"id":"fa32b979_687ca920","line":263,"in_reply_to":"fa32b979_e9577424","updated":"2015-06-22 15:06:49.000000000","message":"No. The goal of this scenario is to benchmark how long it takes to invoke the scaling policy, not to benchmark how long it takes to scale by a certain number of hosts.","commit_id":"4ec60acd48236b455607e11207ca736d7b0be79a"}],"samples/tasks/scenarios/heat/create-stack-scale-up-and-down.json":[{"author":{"_account_id":13609,"name":"Pavel Boldin","email":"pboldin@mirantis.com","username":"pboldin"},"change_message_id":"58a9fb14a0ac43266e97a81163c8740b9c660638","unresolved":false,"context_lines":[{"line_number":6,"context_line":"        \"concurrency\": 2,"},{"line_number":7,"context_line":"        \"times\": 3"},{"line_number":8,"context_line":"      },"},{"line_number":9,"context_line":"      \"args\": {"},{"line_number":10,"context_line":"        \"template_path\": \"templates/autoscaling_group.yaml.template\","},{"line_number":11,"context_line":"        \"scale_up_key\": \"scale_up_url\","},{"line_number":12,"context_line":"        \"scale_down_key\": \"scale_down_url\""}],"source_content_type":"application/json","patch_set":9,"id":"7a016987_47b29e95","line":9,"updated":"2015-05-29 00:10:24.000000000","message":"Please keep \"args\" first.","commit_id":"9cde259c54e1a0e281b1a57e59123926142491bd"},{"author":{"_account_id":11748,"name":"Chris St. Pierre","email":"cstpierr@cisco.com","username":"stpierre"},"change_message_id":"5408b4012f56ea9359674a408ee03e5615840bd3","unresolved":false,"context_lines":[{"line_number":6,"context_line":"        \"concurrency\": 2,"},{"line_number":7,"context_line":"        \"times\": 3"},{"line_number":8,"context_line":"      },"},{"line_number":9,"context_line":"      \"args\": {"},{"line_number":10,"context_line":"        \"template_path\": \"templates/autoscaling_group.yaml.template\","},{"line_number":11,"context_line":"        \"scale_up_key\": \"scale_up_url\","},{"line_number":12,"context_line":"        \"scale_down_key\": \"scale_down_url\""}],"source_content_type":"application/json","patch_set":9,"id":"7a016987_cf9a1162","line":9,"in_reply_to":"7a016987_47b29e95","updated":"2015-05-29 14:50:45.000000000","message":"Done","commit_id":"9cde259c54e1a0e281b1a57e59123926142491bd"}],"tests/unit/plugins/openstack/scenarios/heat/test_stacks.py":[{"author":{"_account_id":13609,"name":"Pavel Boldin","email":"pboldin@mirantis.com","username":"pboldin"},"change_message_id":"58a9fb14a0ac43266e97a81163c8740b9c660638","unresolved":false,"context_lines":[{"line_number":116,"context_line":"        heat_scenario._stack_webhook \u003d mock.Mock()"},{"line_number":117,"context_line":"        heat_scenario._delete_stack \u003d mock.Mock()"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"        heat_scenario.create_stack_scale_up_and_down(self.default_template,"},{"line_number":120,"context_line":"                                                     \"scale_up_key\","},{"line_number":121,"context_line":"                                                     \"scale_down_key\","},{"line_number":122,"context_line":"                                                     min_sleep\u003d1,"}],"source_content_type":"text/x-python","patch_set":9,"id":"7a016987_67d35ad6","line":119,"updated":"2015-05-29 00:10:24.000000000","message":"Seems like rally is slowly starting to use:\n inst.method(\n    abc, def, foo, bar)\n\nInstead of:\n inst.method(aaaa,\n             bbbb)","commit_id":"9cde259c54e1a0e281b1a57e59123926142491bd"},{"author":{"_account_id":13609,"name":"Pavel Boldin","email":"pboldin@mirantis.com","username":"pboldin"},"change_message_id":"2cd562169179347fcbf48e3d1b5796625fd71efc","unresolved":false,"context_lines":[{"line_number":30,"context_line":"        self.default_parameters \u003d {\"dummy_param\": \"dummy_key\"}"},{"line_number":31,"context_line":"        self.default_files \u003d [\"dummy_file.yaml\"]"},{"line_number":32,"context_line":"        self.default_environment \u003d {\"env\": \"dummy_env\"}"},{"line_number":33,"context_line":"        self.useFixture(mockpatch.Patch(\"time.sleep\"))"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    @mock.patch(HEAT_STACKS + \"._generate_random_name\")"},{"line_number":36,"context_line":"    @mock.patch(HEAT_STACKS + \"._list_stacks\")"}],"source_content_type":"text/x-python","patch_set":14,"id":"5afe65bd_c089cd76","line":33,"updated":"2015-06-04 18:29:16.000000000","message":"Since the `time.sleep\u0027 is used only in `create_stack_scale_up_and_down\u0027 please mock it only in the appropriate test.","commit_id":"e0a07577172bf3782b3fc982c1bc4f1b6a3d7117"},{"author":{"_account_id":11748,"name":"Chris St. Pierre","email":"cstpierr@cisco.com","username":"stpierre"},"change_message_id":"abdcbcff87933186724ab36b8d3d60d693beb133","unresolved":false,"context_lines":[{"line_number":30,"context_line":"        self.default_parameters \u003d {\"dummy_param\": \"dummy_key\"}"},{"line_number":31,"context_line":"        self.default_files \u003d [\"dummy_file.yaml\"]"},{"line_number":32,"context_line":"        self.default_environment \u003d {\"env\": \"dummy_env\"}"},{"line_number":33,"context_line":"        self.useFixture(mockpatch.Patch(\"time.sleep\"))"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    @mock.patch(HEAT_STACKS + \"._generate_random_name\")"},{"line_number":36,"context_line":"    @mock.patch(HEAT_STACKS + \"._list_stacks\")"}],"source_content_type":"text/x-python","patch_set":14,"id":"3afb71cf_079c3868","line":33,"in_reply_to":"5afe65bd_c089cd76","updated":"2015-06-04 19:30:51.000000000","message":"Done","commit_id":"e0a07577172bf3782b3fc982c1bc4f1b6a3d7117"},{"author":{"_account_id":13609,"name":"Pavel Boldin","email":"pboldin@mirantis.com","username":"pboldin"},"change_message_id":"2cd562169179347fcbf48e3d1b5796625fd71efc","unresolved":false,"context_lines":[{"line_number":143,"context_line":"                                            self.default_environment)"},{"line_number":144,"context_line":"        mock_delete.assert_called_once_with(fake_stack)"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"    def test_create_stack_scale_up_and_down(self):"},{"line_number":147,"context_line":"        heat_scenario \u003d stacks.HeatStacks()"},{"line_number":148,"context_line":"        stack \u003d mock.Mock()"},{"line_number":149,"context_line":"        heat_scenario._create_stack \u003d mock.Mock(return_value\u003dstack)"}],"source_content_type":"text/x-python","patch_set":14,"id":"5afe65bd_6099f9c3","line":146,"updated":"2015-06-04 18:29:16.000000000","message":"@mock.patch(\"time.sleep\")\n def test_create_stack_scale_up_and_down(self, mock_sleep):","commit_id":"e0a07577172bf3782b3fc982c1bc4f1b6a3d7117"},{"author":{"_account_id":11748,"name":"Chris St. Pierre","email":"cstpierr@cisco.com","username":"stpierre"},"change_message_id":"abdcbcff87933186724ab36b8d3d60d693beb133","unresolved":false,"context_lines":[{"line_number":143,"context_line":"                                            self.default_environment)"},{"line_number":144,"context_line":"        mock_delete.assert_called_once_with(fake_stack)"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"    def test_create_stack_scale_up_and_down(self):"},{"line_number":147,"context_line":"        heat_scenario \u003d stacks.HeatStacks()"},{"line_number":148,"context_line":"        stack \u003d mock.Mock()"},{"line_number":149,"context_line":"        heat_scenario._create_stack \u003d mock.Mock(return_value\u003dstack)"}],"source_content_type":"text/x-python","patch_set":14,"id":"3afb71cf_e787dc10","line":146,"in_reply_to":"5afe65bd_6099f9c3","updated":"2015-06-04 19:30:51.000000000","message":"Done","commit_id":"e0a07577172bf3782b3fc982c1bc4f1b6a3d7117"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"02466d8347ee3437533b06a0d8ef9c47e6beae82","unresolved":false,"context_lines":[{"line_number":147,"context_line":"        stack \u003d mock.Mock()"},{"line_number":148,"context_line":"        heat_scenario._create_stack \u003d mock.Mock(return_value\u003dstack)"},{"line_number":149,"context_line":"        heat_scenario._stack_webhook \u003d mock.Mock()"},{"line_number":150,"context_line":"        heat_scenario._delete_stack \u003d mock.Mock()"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"        heat_scenario.create_stack_scale_up_and_down(self.default_template,"},{"line_number":153,"context_line":"                                                     \"scale_up_key\","}],"source_content_type":"text/x-python","patch_set":16,"id":"3afb71cf_8c38d6a1","line":150,"updated":"2015-06-09 01:53:27.000000000","message":"_delete_stack is not used","commit_id":"69755cb24515b51a5ea391957b39c91eb71f754b"}],"tests/unit/plugins/openstack/scenarios/heat/test_utils.py":[{"author":{"_account_id":13609,"name":"Pavel Boldin","email":"pboldin@mirantis.com","username":"pboldin"},"change_message_id":"58a9fb14a0ac43266e97a81163c8740b9c660638","unresolved":false,"context_lines":[{"line_number":150,"context_line":""},{"line_number":151,"context_line":"    @mock.patch(HEAT_UTILS + \".HeatScenario.clients\")"},{"line_number":152,"context_line":"    @mock.patch(\"requests.post\")"},{"line_number":153,"context_line":"    def test_stack_webhook(self, mock_post, mock_clients):"},{"line_number":154,"context_line":"        scenario \u003d utils.HeatScenario()"},{"line_number":155,"context_line":"        stack \u003d mock.Mock()"},{"line_number":156,"context_line":"        stack.outputs \u003d [{\"output_key\": \"output1\", \"output_value\": \"url1\"},"}],"source_content_type":"text/x-python","patch_set":9,"id":"7a016987_67a11a46","line":153,"updated":"2015-05-29 00:10:24.000000000","message":"The function is called `_stack_webhook\u0027, please call the test `test__stack_webhook\u0027","commit_id":"9cde259c54e1a0e281b1a57e59123926142491bd"},{"author":{"_account_id":13609,"name":"Pavel Boldin","email":"pboldin@mirantis.com","username":"pboldin"},"change_message_id":"e8a39c63746548f03ed0b911b4db63d00f44736c","unresolved":false,"context_lines":[{"line_number":150,"context_line":""},{"line_number":151,"context_line":"    @mock.patch(HEAT_UTILS + \".HeatScenario.clients\")"},{"line_number":152,"context_line":"    @mock.patch(\"requests.post\")"},{"line_number":153,"context_line":"    def test_stack_webhook(self, mock_post, mock_clients):"},{"line_number":154,"context_line":"        scenario \u003d utils.HeatScenario()"},{"line_number":155,"context_line":"        stack \u003d mock.Mock()"},{"line_number":156,"context_line":"        stack.outputs \u003d [{\"output_key\": \"output1\", \"output_value\": \"url1\"},"}],"source_content_type":"text/x-python","patch_set":9,"id":"7a016987_64a0c642","line":153,"in_reply_to":"7a016987_2fde4511","updated":"2015-05-30 14:54:20.000000000","message":"Well, we are thinking about starting a project that will aid in automated reviews.\n\nHowever, these are only dreams at the moment.","commit_id":"9cde259c54e1a0e281b1a57e59123926142491bd"},{"author":{"_account_id":11748,"name":"Chris St. Pierre","email":"cstpierr@cisco.com","username":"stpierre"},"change_message_id":"5408b4012f56ea9359674a408ee03e5615840bd3","unresolved":false,"context_lines":[{"line_number":150,"context_line":""},{"line_number":151,"context_line":"    @mock.patch(HEAT_UTILS + \".HeatScenario.clients\")"},{"line_number":152,"context_line":"    @mock.patch(\"requests.post\")"},{"line_number":153,"context_line":"    def test_stack_webhook(self, mock_post, mock_clients):"},{"line_number":154,"context_line":"        scenario \u003d utils.HeatScenario()"},{"line_number":155,"context_line":"        stack \u003d mock.Mock()"},{"line_number":156,"context_line":"        stack.outputs \u003d [{\"output_key\": \"output1\", \"output_value\": \"url1\"},"}],"source_content_type":"text/x-python","patch_set":9,"id":"7a016987_2fde4511","line":153,"in_reply_to":"7a016987_67a11a46","updated":"2015-05-29 14:50:45.000000000","message":"Rally is actually inconsistent in this regard; some test modules use the double underscore, while others (such as this one) do not. I agree that we should be consistent going forward, I just don\u0027t know which way we want to go. Perhaps Boris can weigh in.","commit_id":"9cde259c54e1a0e281b1a57e59123926142491bd"},{"author":{"_account_id":13609,"name":"Pavel Boldin","email":"pboldin@mirantis.com","username":"pboldin"},"change_message_id":"58a9fb14a0ac43266e97a81163c8740b9c660638","unresolved":false,"context_lines":[{"line_number":161,"context_line":"        self._test_atomic_action_timer(scenario.atomic_actions(),"},{"line_number":162,"context_line":"                                       \"heat.output1_webhook\")"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"        self.assertRaises(exceptions.InvalidConfigException,"},{"line_number":165,"context_line":"                          scenario._stack_webhook, stack, \"bogus\")"},{"line_number":166,"context_line":""},{"line_number":167,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"7a016987_c7bd6e69","line":164,"updated":"2015-05-29 00:10:24.000000000","message":"I think it is better to separate these into two test functions.","commit_id":"9cde259c54e1a0e281b1a57e59123926142491bd"},{"author":{"_account_id":11748,"name":"Chris St. Pierre","email":"cstpierr@cisco.com","username":"stpierre"},"change_message_id":"5408b4012f56ea9359674a408ee03e5615840bd3","unresolved":false,"context_lines":[{"line_number":161,"context_line":"        self._test_atomic_action_timer(scenario.atomic_actions(),"},{"line_number":162,"context_line":"                                       \"heat.output1_webhook\")"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"        self.assertRaises(exceptions.InvalidConfigException,"},{"line_number":165,"context_line":"                          scenario._stack_webhook, stack, \"bogus\")"},{"line_number":166,"context_line":""},{"line_number":167,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"7a016987_2f2c0501","line":164,"in_reply_to":"7a016987_c7bd6e69","updated":"2015-05-29 14:50:45.000000000","message":"Done","commit_id":"9cde259c54e1a0e281b1a57e59123926142491bd"},{"author":{"_account_id":13609,"name":"Pavel Boldin","email":"pboldin@mirantis.com","username":"pboldin"},"change_message_id":"2cd562169179347fcbf48e3d1b5796625fd71efc","unresolved":false,"context_lines":[{"line_number":171,"context_line":"    @mock.patch(\"requests.post\")"},{"line_number":172,"context_line":"    def test_stack_webhook(self, mock_post, mock_clients):"},{"line_number":173,"context_line":"        scenario \u003d utils.HeatScenario()"},{"line_number":174,"context_line":"        stack \u003d mock.Mock()"},{"line_number":175,"context_line":"        stack.outputs \u003d [{\"output_key\": \"output1\", \"output_value\": \"url1\"},"},{"line_number":176,"context_line":"                         {\"output_key\": \"output2\", \"output_value\": \"url2\"}]"},{"line_number":177,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"5afe65bd_008c857d","line":174,"updated":"2015-06-04 18:29:16.000000000","message":"You can specify:\n stack \u003d mock.Mock(\n   outputs\u003d...)","commit_id":"e0a07577172bf3782b3fc982c1bc4f1b6a3d7117"},{"author":{"_account_id":11748,"name":"Chris St. Pierre","email":"cstpierr@cisco.com","username":"stpierre"},"change_message_id":"abdcbcff87933186724ab36b8d3d60d693beb133","unresolved":false,"context_lines":[{"line_number":171,"context_line":"    @mock.patch(\"requests.post\")"},{"line_number":172,"context_line":"    def test_stack_webhook(self, mock_post, mock_clients):"},{"line_number":173,"context_line":"        scenario \u003d utils.HeatScenario()"},{"line_number":174,"context_line":"        stack \u003d mock.Mock()"},{"line_number":175,"context_line":"        stack.outputs \u003d [{\"output_key\": \"output1\", \"output_value\": \"url1\"},"},{"line_number":176,"context_line":"                         {\"output_key\": \"output2\", \"output_value\": \"url2\"}]"},{"line_number":177,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"3afb71cf_2776143f","line":174,"in_reply_to":"5afe65bd_008c857d","updated":"2015-06-04 19:30:51.000000000","message":"Done","commit_id":"e0a07577172bf3782b3fc982c1bc4f1b6a3d7117"}]}
