)]}'
{"optional-requirements.txt":[{"author":{"_account_id":8507,"name":"Mikhail Dubov","email":"mdubov@mirantis.com","username":"msdubov"},"change_message_id":"318abd4cbcf798e2de558e9353cb82d0880d6b29","unresolved":false,"context_lines":[{"line_number":1,"context_line":"python-fuelclient\u003d\u003d6.1.0"},{"line_number":2,"context_line":"python-muranoclient\u003e\u003d0.5.5"}],"source_content_type":"text/plain","patch_set":17,"id":"7a016987_99afb229","line":1,"updated":"2015-05-21 13:48:16.000000000","message":"Seems like mistral should be left here","commit_id":"c0a3865f788f4fb8d3a63e444d13514a943ba9c7"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"a1e3ed4b9a680b5635299657e3bef4bc5850a120","unresolved":false,"context_lines":[{"line_number":1,"context_line":"python-fuelclient\u003d\u003d6.1.0"},{"line_number":2,"context_line":"python-muranoclient\u003e\u003d0.5.5"}],"source_content_type":"text/plain","patch_set":17,"id":"7a016987_d9140a4e","line":1,"in_reply_to":"7a016987_99afb229","updated":"2015-05-21 13:51:43.000000000","message":"I have removed mistral by mistake. Thanks","commit_id":"c0a3865f788f4fb8d3a63e444d13514a943ba9c7"}],"rally-jobs/fuel.yaml":[{"author":{"_account_id":7369,"name":"Sergey Skripnick","email":"sskripnick@mirantis.com","username":"redixin"},"change_message_id":"718fcf925081041f3c2fccb2152d8e8ad7218367","unresolved":false,"context_lines":[{"line_number":5,"context_line":"      runner:"},{"line_number":6,"context_line":"        type: \"constant\""},{"line_number":7,"context_line":"        times: 200"},{"line_number":8,"context_line":"        concurrency: 10"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"9a0c5dc1_0c979791","line":8,"updated":"2015-05-12 16:50:41.000000000","message":"Please add\n\n       sla:\n        failure_rate:\n          max: 0","commit_id":"74cb131da8862ee7e8af5fd0f7be2bf1c9c2168d"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"9df0eac7f1d8cbd8260c4b40b67573c90cc49f3e","unresolved":false,"context_lines":[{"line_number":5,"context_line":"      runner:"},{"line_number":6,"context_line":"        type: \"constant\""},{"line_number":7,"context_line":"        times: 200"},{"line_number":8,"context_line":"        concurrency: 10"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"9a0c5dc1_2c5dbbe9","line":8,"in_reply_to":"9a0c5dc1_0c979791","updated":"2015-05-12 16:53:29.000000000","message":"Done","commit_id":"74cb131da8862ee7e8af5fd0f7be2bf1c9c2168d"}],"rally/benchmark/scenarios/fuel/__init__.py":[{"author":{"_account_id":7369,"name":"Sergey Skripnick","email":"sskripnick@mirantis.com","username":"redixin"},"change_message_id":"fc19eece08fe6718f5034c823771ca7c446531e5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"3acd31a7_7c94ed41","updated":"2015-05-05 18:37:49.000000000","message":"we usually don\u0027t place code in __init__.py","commit_id":"82fb6ef04b0efb19b3214202490b60d78ecbc62a"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"9b09c9d8979531e5c7d879105e0639b63b48e25c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"1aca2d91_41c56159","in_reply_to":"3acd31a7_7c94ed41","updated":"2015-05-06 10:15:40.000000000","message":"Done","commit_id":"82fb6ef04b0efb19b3214202490b60d78ecbc62a"},{"author":{"_account_id":7369,"name":"Sergey Skripnick","email":"sskripnick@mirantis.com","username":"redixin"},"change_message_id":"fc19eece08fe6718f5034c823771ca7c446531e5","unresolved":false,"context_lines":[{"line_number":35,"context_line":"        os.environ[\"KEYSTONE_USER\"] \u003d username"},{"line_number":36,"context_line":"        os.environ[\"KEYSTONE_PASS\"] \u003d password"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"        import fuelclient"},{"line_number":39,"context_line":"        client \u003d fuelclient.get_client"},{"line_number":40,"context_line":"        self.environment \u003d client(\"environment\", version\u003dversion)"},{"line_number":41,"context_line":"        self.node \u003d client(\"node\", version\u003dversion)"}],"source_content_type":"text/x-python","patch_set":5,"id":"3acd31a7_9cd0e920","line":38,"updated":"2015-05-05 18:37:49.000000000","message":"we should add this to requirements.txt. or at least to optional-requirements.txt","commit_id":"82fb6ef04b0efb19b3214202490b60d78ecbc62a"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"9b09c9d8979531e5c7d879105e0639b63b48e25c","unresolved":false,"context_lines":[{"line_number":35,"context_line":"        os.environ[\"KEYSTONE_USER\"] \u003d username"},{"line_number":36,"context_line":"        os.environ[\"KEYSTONE_PASS\"] \u003d password"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"        import fuelclient"},{"line_number":39,"context_line":"        client \u003d fuelclient.get_client"},{"line_number":40,"context_line":"        self.environment \u003d client(\"environment\", version\u003dversion)"},{"line_number":41,"context_line":"        self.node \u003d client(\"node\", version\u003dversion)"}],"source_content_type":"text/x-python","patch_set":5,"id":"1aca2d91_21a145aa","line":38,"in_reply_to":"3acd31a7_9cd0e920","updated":"2015-05-06 10:15:40.000000000","message":"Done","commit_id":"82fb6ef04b0efb19b3214202490b60d78ecbc62a"}],"rally/benchmark/scenarios/fuel/environments.py":[{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"7e5d4e65274391ba5f6edc3d926aff09e75383c3","unresolved":false,"context_lines":[{"line_number":20,"context_line":"class FuelEnvironments(utils.FuelScenario):"},{"line_number":21,"context_line":"    \"\"\"Benchmark scenarios for Fuel environments.\"\"\""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"    @validation.required_openstack(admin\u003dTrue)"},{"line_number":24,"context_line":"    @base.scenario()"},{"line_number":25,"context_line":"    def list_environments(self):"},{"line_number":26,"context_line":"        \"\"\"List Fuel environments.\"\"\""}],"source_content_type":"text/x-python","patch_set":12,"id":"9a0c5dc1_8a21f4b6","line":23,"updated":"2015-05-13 18:06:44.000000000","message":"why we are not using here\n\n   @required_service() , require_clients()\n\nvalidators? \n\nhttps://github.com/openstack/rally/blob/master/rally/benchmark/validation.py#L433-L446","commit_id":"84730bf3b7409f69466cdc9f3143bae1cb590f08"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"f87a20ddd47b0f85babe79bfdd1e739e4960fc6d","unresolved":false,"context_lines":[{"line_number":20,"context_line":"class FuelEnvironments(utils.FuelScenario):"},{"line_number":21,"context_line":"    \"\"\"Benchmark scenarios for Fuel environments.\"\"\""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"    @validation.required_openstack(admin\u003dTrue)"},{"line_number":24,"context_line":"    @base.scenario()"},{"line_number":25,"context_line":"    def list_environments(self):"},{"line_number":26,"context_line":"        \"\"\"List Fuel environments.\"\"\""}],"source_content_type":"text/x-python","patch_set":12,"id":"7a016987_f4af7a7b","line":23,"in_reply_to":"9a0c5dc1_8a21f4b6","updated":"2015-05-14 10:46:17.000000000","message":"required_service - this decorator can not be used because in case of Fuel node we have empty services list\n\nrequire_clients - yes","commit_id":"84730bf3b7409f69466cdc9f3143bae1cb590f08"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"5b7b0cd7f733bf0a170c482513b9b372427389fe","unresolved":false,"context_lines":[{"line_number":20,"context_line":"class FuelEnvironments(utils.FuelScenario):"},{"line_number":21,"context_line":"    \"\"\"Benchmark scenarios for Fuel environments.\"\"\""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"    @validation.required_clients(\"fuel\", admin\u003dTrue)"},{"line_number":24,"context_line":"    @validation.required_openstack(admin\u003dTrue)"},{"line_number":25,"context_line":"    @base.scenario()"},{"line_number":26,"context_line":"    def list_environments(self):"}],"source_content_type":"text/x-python","patch_set":13,"id":"7a016987_6855e9c4","line":23,"updated":"2015-05-14 12:32:24.000000000","message":"Remove admin\u003dTrue","commit_id":"dc85da543b172c4481eaba38125bb690a05d6c46"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"9717dfc075a95307ffff2b8b244d110ab471ad80","unresolved":false,"context_lines":[{"line_number":20,"context_line":"class FuelEnvironments(utils.FuelScenario):"},{"line_number":21,"context_line":"    \"\"\"Benchmark scenarios for Fuel environments.\"\"\""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"    @validation.required_clients(\"fuel\", admin\u003dTrue)"},{"line_number":24,"context_line":"    @validation.required_openstack(admin\u003dTrue)"},{"line_number":25,"context_line":"    @base.scenario()"},{"line_number":26,"context_line":"    def list_environments(self):"}],"source_content_type":"text/x-python","patch_set":13,"id":"7a016987_ce6ef02e","line":23,"in_reply_to":"7a016987_6855e9c4","updated":"2015-05-15 16:15:08.000000000","message":"This is new option (see related patch), and this is required to verify admin clients","commit_id":"dc85da543b172c4481eaba38125bb690a05d6c46"},{"author":{"_account_id":8507,"name":"Mikhail Dubov","email":"mdubov@mirantis.com","username":"msdubov"},"change_message_id":"318abd4cbcf798e2de558e9353cb82d0880d6b29","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"7a016987_1932a25f","updated":"2015-05-21 13:48:16.000000000","message":"Yair has almost finished moving scenarios to rally/plugins/, so the modules related to Fuel scenarios should also be placed in that directory.","commit_id":"c0a3865f788f4fb8d3a63e444d13514a943ba9c7"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"0bc21d34ade2d14fb9fff3024f999785610732cd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"7a016987_992452c5","in_reply_to":"7a016987_1932a25f","updated":"2015-05-21 13:51:02.000000000","message":"Okay","commit_id":"c0a3865f788f4fb8d3a63e444d13514a943ba9c7"}],"rally/benchmark/scenarios/fuel/utils.py":[{"author":{"_account_id":13609,"name":"Pavel Boldin","email":"pboldin@mirantis.com","username":"pboldin"},"change_message_id":"1c52a568d0425535ce5c9e1e20471bd752db6c50","unresolved":false,"context_lines":[{"line_number":59,"context_line":"#   class FooScenario(base.Scenario):"},{"line_number":60,"context_line":"#       def bar_benchmark(self):"},{"line_number":61,"context_line":"#           all_envs \u003d self.admin_clients(\"fuel\").environment.get_all()"},{"line_number":62,"context_line":"osclients.Clients.register(\"fuel\", fuel)"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"class FuelScenario(base.Scenario):"}],"source_content_type":"text/x-python","patch_set":6,"id":"1aca2d91_84190f7c","line":62,"updated":"2015-05-07 13:12:53.000000000","message":"Let\u0027s make that a decorator. The simply line in the .py file looks like hell.","commit_id":"a4117a7549df9aa991d826932ebfac914ec51f4c"},{"author":{"_account_id":8507,"name":"Mikhail Dubov","email":"mdubov@mirantis.com","username":"msdubov"},"change_message_id":"318abd4cbcf798e2de558e9353cb82d0880d6b29","unresolved":false,"context_lines":[{"line_number":45,"context_line":""},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"@osclients.Clients.register(\"fuel\")"},{"line_number":48,"context_line":"def fuel(self):"},{"line_number":49,"context_line":"    \"\"\"FuelClient factory for osclients.Clients.\"\"\""},{"line_number":50,"context_line":"    auth_url \u003d six.moves.urllib.parse.urlparse(self.endpoint.auth_url)"},{"line_number":51,"context_line":"    return FuelClient(version\u003d\"v1\","}],"source_content_type":"text/x-python","patch_set":17,"id":"7a016987_196aa2ee","line":48,"updated":"2015-05-21 13:48:16.000000000","message":"Should this be an instance method? Seems like wrong indent here","commit_id":"c0a3865f788f4fb8d3a63e444d13514a943ba9c7"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"0bc21d34ade2d14fb9fff3024f999785610732cd","unresolved":false,"context_lines":[{"line_number":45,"context_line":""},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"@osclients.Clients.register(\"fuel\")"},{"line_number":48,"context_line":"def fuel(self):"},{"line_number":49,"context_line":"    \"\"\"FuelClient factory for osclients.Clients.\"\"\""},{"line_number":50,"context_line":"    auth_url \u003d six.moves.urllib.parse.urlparse(self.endpoint.auth_url)"},{"line_number":51,"context_line":"    return FuelClient(version\u003d\"v1\","}],"source_content_type":"text/x-python","patch_set":17,"id":"7a016987_39331e16","line":48,"in_reply_to":"7a016987_196aa2ee","updated":"2015-05-21 13:51:02.000000000","message":"No, this should not be instance method, this is generic function that becomes instance method of osclients.Clients at run time","commit_id":"c0a3865f788f4fb8d3a63e444d13514a943ba9c7"}],"rally/plugins/openstack/scenarios/fuel/utils.py":[{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"01040514f06d6c4dfad78f33033a43ec8814650e","unresolved":false,"context_lines":[{"line_number":45,"context_line":""},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"@osclients.Clients.register(\"fuel\")"},{"line_number":48,"context_line":"def fuel(ins):"},{"line_number":49,"context_line":"    \"\"\"FuelClient factory for osclients.Clients.\"\"\""},{"line_number":50,"context_line":"    auth_url \u003d six.moves.urllib.parse.urlparse(ins.endpoint.auth_url)"},{"line_number":51,"context_line":"    return FuelClient(version\u003d\"v1\","}],"source_content_type":"text/x-python","patch_set":21,"id":"7a016987_007753d5","line":48,"updated":"2015-05-26 21:27:53.000000000","message":"ins is really unclear name\u003d(\n\nwhy not instance?","commit_id":"4f5868744e19e5056a580ddfe3e8a4a3278e6b1a"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"de6363fd0eeb0c5be2a2cf4194c6cb0c43fa0f89","unresolved":false,"context_lines":[{"line_number":45,"context_line":""},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"@osclients.Clients.register(\"fuel\")"},{"line_number":48,"context_line":"def fuel(ins):"},{"line_number":49,"context_line":"    \"\"\"FuelClient factory for osclients.Clients.\"\"\""},{"line_number":50,"context_line":"    auth_url \u003d six.moves.urllib.parse.urlparse(ins.endpoint.auth_url)"},{"line_number":51,"context_line":"    return FuelClient(version\u003d\"v1\","}],"source_content_type":"text/x-python","patch_set":21,"id":"7a016987_e980948d","line":48,"in_reply_to":"7a016987_007753d5","updated":"2015-05-27 09:27:58.000000000","message":"Done","commit_id":"4f5868744e19e5056a580ddfe3e8a4a3278e6b1a"}],"samples/tasks/scenarios/foo/list-environments.json":[{"author":{"_account_id":13609,"name":"Pavel Boldin","email":"pboldin@mirantis.com","username":"pboldin"},"change_message_id":"0874dbad163f71ec6882752feb9d4e9a02482790","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{"},{"line_number":2,"context_line":"    \"FuelEnvironments.list_environments\": ["},{"line_number":3,"context_line":"        {"},{"line_number":4,"context_line":"            \"runner\": {"}],"source_content_type":"application/json","patch_set":10,"id":"1aca2d91_2c12e209","line":1,"updated":"2015-05-08 22:33:20.000000000","message":"scenarios/foo?","commit_id":"48d15bc40a87f24eaee4e28b211caf69a4512982"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"421598c1c9dfdc425890a416b7cf027fc0b8e84b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{"},{"line_number":2,"context_line":"    \"FuelEnvironments.list_environments\": ["},{"line_number":3,"context_line":"        {"},{"line_number":4,"context_line":"            \"runner\": {"}],"source_content_type":"application/json","patch_set":10,"id":"9a0c5dc1_1ba59403","line":1,"in_reply_to":"1aca2d91_2c12e209","updated":"2015-05-12 14:33:55.000000000","message":"Great remark. Thanks!","commit_id":"48d15bc40a87f24eaee4e28b211caf69a4512982"}],"tests/unit/benchmark/scenarios/fuel/test_environments.py":[{"author":{"_account_id":13609,"name":"Pavel Boldin","email":"pboldin@mirantis.com","username":"pboldin"},"change_message_id":"1c52a568d0425535ce5c9e1e20471bd752db6c50","unresolved":false,"context_lines":[{"line_number":23,"context_line":"    def test_list_environments(self):"},{"line_number":24,"context_line":"        scenario \u003d environments.FuelEnvironments()"},{"line_number":25,"context_line":"        scenario._list_environments \u003d mock.Mock()"},{"line_number":26,"context_line":"        scenario.list_environments()"},{"line_number":27,"context_line":"        scenario._list_environments.assert_called_once_with()"}],"source_content_type":"text/x-python","patch_set":6,"id":"1aca2d91_84c0ef2b","line":26,"updated":"2015-05-07 13:12:53.000000000","message":"Return is not asserted on.\n\nIt should return None, please check.","commit_id":"a4117a7549df9aa991d826932ebfac914ec51f4c"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"6ee0436b84f89b87f16eb6d8e0d3ca96d375ce41","unresolved":false,"context_lines":[{"line_number":23,"context_line":"    def test_list_environments(self):"},{"line_number":24,"context_line":"        scenario \u003d environments.FuelEnvironments()"},{"line_number":25,"context_line":"        scenario._list_environments \u003d mock.Mock()"},{"line_number":26,"context_line":"        scenario.list_environments()"},{"line_number":27,"context_line":"        scenario._list_environments.assert_called_once_with()"}],"source_content_type":"text/x-python","patch_set":6,"id":"1aca2d91_a7352ddb","line":26,"in_reply_to":"1aca2d91_84c0ef2b","updated":"2015-05-07 13:15:33.000000000","message":"We do not use return values in scenarios","commit_id":"a4117a7549df9aa991d826932ebfac914ec51f4c"},{"author":{"_account_id":13609,"name":"Pavel Boldin","email":"pboldin@mirantis.com","username":"pboldin"},"change_message_id":"b93cc802863625de7a9536956689c5af4c0f4656","unresolved":false,"context_lines":[{"line_number":23,"context_line":"    def test_list_environments(self):"},{"line_number":24,"context_line":"        scenario \u003d environments.FuelEnvironments()"},{"line_number":25,"context_line":"        scenario._list_environments \u003d mock.Mock()"},{"line_number":26,"context_line":"        scenario.list_environments()"},{"line_number":27,"context_line":"        scenario._list_environments.assert_called_once_with()"}],"source_content_type":"text/x-python","patch_set":6,"id":"1aca2d91_07ce21b4","line":26,"in_reply_to":"1aca2d91_a7352ddb","updated":"2015-05-07 13:18:35.000000000","message":"At first, we do. https://github.com/openstack/rally/blob/master/rally/benchmark/scenarios/vm/vmtasks.py#L106\n\nAt second, then explicitly check that nothing is returned.","commit_id":"a4117a7549df9aa991d826932ebfac914ec51f4c"}],"tests/unit/benchmark/scenarios/fuel/test_utils.py":[{"author":{"_account_id":13609,"name":"Pavel Boldin","email":"pboldin@mirantis.com","username":"pboldin"},"change_message_id":"1c52a568d0425535ce5c9e1e20471bd752db6c50","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    @mock.patch(UTILS + \"six\")"},{"line_number":29,"context_line":"    @mock.patch(UTILS + \"FuelClient\", return_value\u003d\"fuel_client\")"},{"line_number":30,"context_line":"    def test_fuel(self, mock_fuelclient, mock_six):"},{"line_number":31,"context_line":"        mock_six.moves.urllib.parse.urlparse.return_value \u003d ("},{"line_number":32,"context_line":"            mock.Mock(hostname\u003d\"foo_host\"))"},{"line_number":33,"context_line":"        clients_ins \u003d mock.Mock(endpoint\u003dmock.Mock(username\u003d\"foo_user\","},{"line_number":34,"context_line":"                                                   password\u003d\"foo_pass\"))"}],"source_content_type":"text/x-python","patch_set":6,"id":"1aca2d91_24847bd2","line":31,"updated":"2015-05-07 13:12:53.000000000","message":"This should work as well.\n .return_value.hostname \u003d \"foo_host\"","commit_id":"a4117a7549df9aa991d826932ebfac914ec51f4c"},{"author":{"_account_id":13609,"name":"Pavel Boldin","email":"pboldin@mirantis.com","username":"pboldin"},"change_message_id":"1c52a568d0425535ce5c9e1e20471bd752db6c50","unresolved":false,"context_lines":[{"line_number":46,"context_line":"        self.assertFalse(hasattr(osclients.Clients, \"fuel\"))"},{"line_number":47,"context_line":"        six.moves.reload_module(utils)"},{"line_number":48,"context_line":"        self.assertTrue(hasattr(osclients.Clients, \"fuel\"))"},{"line_number":49,"context_line":"        with mock.patch(UTILS + \"FuelClient\","},{"line_number":50,"context_line":"                        mock.Mock(return_value\u003d\"fuel_client\")):"},{"line_number":51,"context_line":"            with mock.patch(UTILS + \"six\"):"},{"line_number":52,"context_line":"                clients \u003d osclients.Clients(mock.Mock())"}],"source_content_type":"text/x-python","patch_set":6,"id":"1aca2d91_e4556350","line":49,"updated":"2015-05-07 13:12:53.000000000","message":"Since you are using mock.patch FuelClient and six in both the tests please consider moving them to the setUp.","commit_id":"a4117a7549df9aa991d826932ebfac914ec51f4c"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"3fcdb113684a7e34645d5daee10f3cbffcd7c405","unresolved":false,"context_lines":[{"line_number":46,"context_line":"        self.assertFalse(hasattr(osclients.Clients, \"fuel\"))"},{"line_number":47,"context_line":"        six.moves.reload_module(utils)"},{"line_number":48,"context_line":"        self.assertTrue(hasattr(osclients.Clients, \"fuel\"))"},{"line_number":49,"context_line":"        with mock.patch(UTILS + \"FuelClient\","},{"line_number":50,"context_line":"                        mock.Mock(return_value\u003d\"fuel_client\")):"},{"line_number":51,"context_line":"            with mock.patch(UTILS + \"six\"):"},{"line_number":52,"context_line":"                clients \u003d osclients.Clients(mock.Mock())"}],"source_content_type":"text/x-python","patch_set":6,"id":"1aca2d91_7a09badc","line":49,"in_reply_to":"1aca2d91_e4556350","updated":"2015-05-08 14:50:12.000000000","message":"This test calls `six.moves.reload_module(utils)\u0027, so both six and FuelClient cannot be mocked by decorator - six.moves is in use, and FuelClient will be reloaded after reload_module()","commit_id":"a4117a7549df9aa991d826932ebfac914ec51f4c"},{"author":{"_account_id":13609,"name":"Pavel Boldin","email":"pboldin@mirantis.com","username":"pboldin"},"change_message_id":"1c52a568d0425535ce5c9e1e20471bd752db6c50","unresolved":false,"context_lines":[{"line_number":87,"context_line":"            \"foo_environments_list\")"},{"line_number":88,"context_line":"        scenario \u003d utils.FuelScenario()"},{"line_number":89,"context_line":"        envs_list \u003d scenario._list_environments()"},{"line_number":90,"context_line":"        self.assertEqual(envs_list, \"foo_environments_list\")"},{"line_number":91,"context_line":"        mock_clients.assert_called_once_with(\"fuel\")"},{"line_number":92,"context_line":"        self._test_atomic_action_timer(scenario.atomic_actions(),"},{"line_number":93,"context_line":"                                       \"fuel.list_environments\")"}],"source_content_type":"text/x-python","patch_set":6,"id":"1aca2d91_24a0fb42","line":90,"updated":"2015-05-07 13:12:53.000000000","message":"the order is wrong.","commit_id":"a4117a7549df9aa991d826932ebfac914ec51f4c"},{"author":{"_account_id":13609,"name":"Pavel Boldin","email":"pboldin@mirantis.com","username":"pboldin"},"change_message_id":"0874dbad163f71ec6882752feb9d4e9a02482790","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    @mock.patch(UTILS + \"six\")"},{"line_number":29,"context_line":"    @mock.patch(UTILS + \"FuelClient\", return_value\u003d\"fuel_client\")"},{"line_number":30,"context_line":"    def test_fuel(self, mock_fuelclient, mock_six):"},{"line_number":31,"context_line":"        mock_six.moves.urllib.parse.urlparse().hostname \u003d \"foo_host\""},{"line_number":32,"context_line":"        clients_ins \u003d mock.Mock(endpoint\u003dmock.Mock(username\u003d\"foo_user\","},{"line_number":33,"context_line":"                                                   password\u003d\"foo_pass\"))"}],"source_content_type":"text/x-python","patch_set":10,"id":"1aca2d91_0cea86db","line":30,"updated":"2015-05-08 22:33:20.000000000","message":"Please change the name of the test.","commit_id":"48d15bc40a87f24eaee4e28b211caf69a4512982"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"17a8d9b9ec2bd72719d2f878aac61e62c7bdb721","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    @mock.patch(UTILS + \"six\")"},{"line_number":29,"context_line":"    @mock.patch(UTILS + \"FuelClient\", return_value\u003d\"fuel_client\")"},{"line_number":30,"context_line":"    def test_fuel(self, mock_fuelclient, mock_six):"},{"line_number":31,"context_line":"        mock_six.moves.urllib.parse.urlparse().hostname \u003d \"foo_host\""},{"line_number":32,"context_line":"        clients_ins \u003d mock.Mock(endpoint\u003dmock.Mock(username\u003d\"foo_user\","},{"line_number":33,"context_line":"                                                   password\u003d\"foo_pass\"))"}],"source_content_type":"text/x-python","patch_set":10,"id":"1aca2d91_354e9e3b","line":30,"in_reply_to":"1aca2d91_0cea86db","updated":"2015-05-09 15:30:47.000000000","message":"Change to what name?","commit_id":"48d15bc40a87f24eaee4e28b211caf69a4512982"},{"author":{"_account_id":13609,"name":"Pavel Boldin","email":"pboldin@mirantis.com","username":"pboldin"},"change_message_id":"7525b3c8e0fe43768cd207f7149a5a0589a185e8","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    @mock.patch(UTILS + \"six\")"},{"line_number":29,"context_line":"    @mock.patch(UTILS + \"FuelClient\", return_value\u003d\"fuel_client\")"},{"line_number":30,"context_line":"    def test_fuel(self, mock_fuelclient, mock_six):"},{"line_number":31,"context_line":"        mock_six.moves.urllib.parse.urlparse().hostname \u003d \"foo_host\""},{"line_number":32,"context_line":"        clients_ins \u003d mock.Mock(endpoint\u003dmock.Mock(username\u003d\"foo_user\","},{"line_number":33,"context_line":"                                                   password\u003d\"foo_pass\"))"}],"source_content_type":"text/x-python","patch_set":10,"id":"1aca2d91_35a69eae","line":30,"in_reply_to":"1aca2d91_354e9e3b","updated":"2015-05-09 15:56:53.000000000","message":"That is your code.\n\nBut you are not testing fuel, so the test name is wrong.\nI think `test_fuelclient\u0027 is better.","commit_id":"48d15bc40a87f24eaee4e28b211caf69a4512982"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"90c0163bb5e178cc65bf9f45f0ec3dc15417c6ea","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    @mock.patch(UTILS + \"six\")"},{"line_number":29,"context_line":"    @mock.patch(UTILS + \"FuelClient\", return_value\u003d\"fuel_client\")"},{"line_number":30,"context_line":"    def test_fuel(self, mock_fuelclient, mock_six):"},{"line_number":31,"context_line":"        mock_six.moves.urllib.parse.urlparse().hostname \u003d \"foo_host\""},{"line_number":32,"context_line":"        clients_ins \u003d mock.Mock(endpoint\u003dmock.Mock(username\u003d\"foo_user\","},{"line_number":33,"context_line":"                                                   password\u003d\"foo_pass\"))"}],"source_content_type":"text/x-python","patch_set":10,"id":"9af37de9_b2b35e0a","line":30,"in_reply_to":"1aca2d91_35a69eae","updated":"2015-05-09 21:41:42.000000000","message":"test method naming convention is based on `test_\u0027 + {name of tested function/method/property} + {`_\u0027 + optional test case description}\n\nSo this test is for function `utils.fuel\u0027 - that is why test name is `test_fuel\u0027","commit_id":"48d15bc40a87f24eaee4e28b211caf69a4512982"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"4b2950a84b3c2121b8ee5e51fd180c99a4530de7","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    @mock.patch(UTILS + \"six\")"},{"line_number":29,"context_line":"    @mock.patch(UTILS + \"FuelClient\", return_value\u003d\"fuel_client\")"},{"line_number":30,"context_line":"    def test_fuel(self, mock_fuelclient, mock_six):"},{"line_number":31,"context_line":"        mock_six.moves.urllib.parse.urlparse().hostname \u003d \"foo_host\""},{"line_number":32,"context_line":"        clients_ins \u003d mock.Mock(endpoint\u003dmock.Mock(username\u003d\"foo_user\","},{"line_number":33,"context_line":"                                                   password\u003d\"foo_pass\"))"}],"source_content_type":"text/x-python","patch_set":10,"id":"9a0c5dc1_d602333e","line":30,"in_reply_to":"9a0c5dc1_360aafd3","updated":"2015-05-12 14:56:49.000000000","message":"This can not be done since function `utils.fuel\u0027 not in FuelClient class scope","commit_id":"48d15bc40a87f24eaee4e28b211caf69a4512982"},{"author":{"_account_id":13609,"name":"Pavel Boldin","email":"pboldin@mirantis.com","username":"pboldin"},"change_message_id":"9463af2be2cfbc3d45c8b1bf2bb4a70c31823334","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    @mock.patch(UTILS + \"six\")"},{"line_number":29,"context_line":"    @mock.patch(UTILS + \"FuelClient\", return_value\u003d\"fuel_client\")"},{"line_number":30,"context_line":"    def test_fuel(self, mock_fuelclient, mock_six):"},{"line_number":31,"context_line":"        mock_six.moves.urllib.parse.urlparse().hostname \u003d \"foo_host\""},{"line_number":32,"context_line":"        clients_ins \u003d mock.Mock(endpoint\u003dmock.Mock(username\u003d\"foo_user\","},{"line_number":33,"context_line":"                                                   password\u003d\"foo_pass\"))"}],"source_content_type":"text/x-python","patch_set":10,"id":"9a0c5dc1_360aafd3","line":30,"in_reply_to":"9a0c5dc1_bb5b2854","updated":"2015-05-12 14:49:11.000000000","message":"Then I propose to move this test to the FuelClientTestCase.","commit_id":"48d15bc40a87f24eaee4e28b211caf69a4512982"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"e6184e81df0c8c67b1f62f6919ce6012262ca998","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    @mock.patch(UTILS + \"six\")"},{"line_number":29,"context_line":"    @mock.patch(UTILS + \"FuelClient\", return_value\u003d\"fuel_client\")"},{"line_number":30,"context_line":"    def test_fuel(self, mock_fuelclient, mock_six):"},{"line_number":31,"context_line":"        mock_six.moves.urllib.parse.urlparse().hostname \u003d \"foo_host\""},{"line_number":32,"context_line":"        clients_ins \u003d mock.Mock(endpoint\u003dmock.Mock(username\u003d\"foo_user\","},{"line_number":33,"context_line":"                                                   password\u003d\"foo_pass\"))"}],"source_content_type":"text/x-python","patch_set":10,"id":"9a0c5dc1_bb5b2854","line":30,"in_reply_to":"9a0c5dc1_fbebe0ae","updated":"2015-05-12 14:46:44.000000000","message":"`ModuleTestCase\u0027 is for module namespace tests. This is generic name for Rally unit tests","commit_id":"48d15bc40a87f24eaee4e28b211caf69a4512982"},{"author":{"_account_id":13609,"name":"Pavel Boldin","email":"pboldin@mirantis.com","username":"pboldin"},"change_message_id":"79321dee319d84cb43e5b4b554764400920aacae","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    @mock.patch(UTILS + \"six\")"},{"line_number":29,"context_line":"    @mock.patch(UTILS + \"FuelClient\", return_value\u003d\"fuel_client\")"},{"line_number":30,"context_line":"    def test_fuel(self, mock_fuelclient, mock_six):"},{"line_number":31,"context_line":"        mock_six.moves.urllib.parse.urlparse().hostname \u003d \"foo_host\""},{"line_number":32,"context_line":"        clients_ins \u003d mock.Mock(endpoint\u003dmock.Mock(username\u003d\"foo_user\","},{"line_number":33,"context_line":"                                                   password\u003d\"foo_pass\"))"}],"source_content_type":"text/x-python","patch_set":10,"id":"9a0c5dc1_fbebe0ae","line":30,"in_reply_to":"9af37de9_b2b35e0a","updated":"2015-05-12 14:41:31.000000000","message":"OK. The methods are really called `test_nova\u0027 and `test_glance\u0027 and so on. The difference is the class name.\n\nSo, having `OSClientsTestCase.test_nova\u0027 is OK, while `ModuleTestCase.test_fuel\u0027 is not.","commit_id":"48d15bc40a87f24eaee4e28b211caf69a4512982"},{"author":{"_account_id":13609,"name":"Pavel Boldin","email":"pboldin@mirantis.com","username":"pboldin"},"change_message_id":"0874dbad163f71ec6882752feb9d4e9a02482790","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    @mock.patch(UTILS + \"six\")"},{"line_number":29,"context_line":"    @mock.patch(UTILS + \"FuelClient\", return_value\u003d\"fuel_client\")"},{"line_number":30,"context_line":"    def test_fuel(self, mock_fuelclient, mock_six):"},{"line_number":31,"context_line":"        mock_six.moves.urllib.parse.urlparse().hostname \u003d \"foo_host\""},{"line_number":32,"context_line":"        clients_ins \u003d mock.Mock(endpoint\u003dmock.Mock(username\u003d\"foo_user\","},{"line_number":33,"context_line":"                                                   password\u003d\"foo_pass\"))"},{"line_number":34,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"1aca2d91_ac15d2e5","line":31,"updated":"2015-05-08 22:33:20.000000000","message":"Please use .return_value.\n\nThis prevents a bad style of ().f \u003d something. The style is bad because it is then impossible to assert on the call, since the function was called already.","commit_id":"48d15bc40a87f24eaee4e28b211caf69a4512982"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"90c0163bb5e178cc65bf9f45f0ec3dc15417c6ea","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    @mock.patch(UTILS + \"six\")"},{"line_number":29,"context_line":"    @mock.patch(UTILS + \"FuelClient\", return_value\u003d\"fuel_client\")"},{"line_number":30,"context_line":"    def test_fuel(self, mock_fuelclient, mock_six):"},{"line_number":31,"context_line":"        mock_six.moves.urllib.parse.urlparse().hostname \u003d \"foo_host\""},{"line_number":32,"context_line":"        clients_ins \u003d mock.Mock(endpoint\u003dmock.Mock(username\u003d\"foo_user\","},{"line_number":33,"context_line":"                                                   password\u003d\"foo_pass\"))"},{"line_number":34,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"9af37de9_52cb1273","line":31,"in_reply_to":"1aca2d91_75ae5682","updated":"2015-05-09 21:41:42.000000000","message":"This test is not intended for copy-paste, and I do not write code for copy-paste","commit_id":"48d15bc40a87f24eaee4e28b211caf69a4512982"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"17a8d9b9ec2bd72719d2f878aac61e62c7bdb721","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    @mock.patch(UTILS + \"six\")"},{"line_number":29,"context_line":"    @mock.patch(UTILS + \"FuelClient\", return_value\u003d\"fuel_client\")"},{"line_number":30,"context_line":"    def test_fuel(self, mock_fuelclient, mock_six):"},{"line_number":31,"context_line":"        mock_six.moves.urllib.parse.urlparse().hostname \u003d \"foo_host\""},{"line_number":32,"context_line":"        clients_ins \u003d mock.Mock(endpoint\u003dmock.Mock(username\u003d\"foo_user\","},{"line_number":33,"context_line":"                                                   password\u003d\"foo_pass\"))"},{"line_number":34,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"1aca2d91_b5398ea6","line":31,"in_reply_to":"1aca2d91_ac15d2e5","updated":"2015-05-09 15:30:47.000000000","message":"we don\u0027t check calls for `urlparse\u0027 so style is ok for this test","commit_id":"48d15bc40a87f24eaee4e28b211caf69a4512982"},{"author":{"_account_id":13609,"name":"Pavel Boldin","email":"pboldin@mirantis.com","username":"pboldin"},"change_message_id":"7525b3c8e0fe43768cd207f7149a5a0589a185e8","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    @mock.patch(UTILS + \"six\")"},{"line_number":29,"context_line":"    @mock.patch(UTILS + \"FuelClient\", return_value\u003d\"fuel_client\")"},{"line_number":30,"context_line":"    def test_fuel(self, mock_fuelclient, mock_six):"},{"line_number":31,"context_line":"        mock_six.moves.urllib.parse.urlparse().hostname \u003d \"foo_host\""},{"line_number":32,"context_line":"        clients_ins \u003d mock.Mock(endpoint\u003dmock.Mock(username\u003d\"foo_user\","},{"line_number":33,"context_line":"                                                   password\u003d\"foo_pass\"))"},{"line_number":34,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"1aca2d91_75ae5682","line":31,"in_reply_to":"1aca2d91_b5398ea6","updated":"2015-05-09 15:56:53.000000000","message":"People tend to copy tests so one caveat in one place can be copied over and required a lot of time to fix everywhere.","commit_id":"48d15bc40a87f24eaee4e28b211caf69a4512982"},{"author":{"_account_id":13609,"name":"Pavel Boldin","email":"pboldin@mirantis.com","username":"pboldin"},"change_message_id":"79321dee319d84cb43e5b4b554764400920aacae","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    @mock.patch(UTILS + \"six\")"},{"line_number":29,"context_line":"    @mock.patch(UTILS + \"FuelClient\", return_value\u003d\"fuel_client\")"},{"line_number":30,"context_line":"    def test_fuel(self, mock_fuelclient, mock_six):"},{"line_number":31,"context_line":"        mock_six.moves.urllib.parse.urlparse().hostname \u003d \"foo_host\""},{"line_number":32,"context_line":"        clients_ins \u003d mock.Mock(endpoint\u003dmock.Mock(username\u003d\"foo_user\","},{"line_number":33,"context_line":"                                                   password\u003d\"foo_pass\"))"},{"line_number":34,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"9a0c5dc1_fb02c06e","line":31,"in_reply_to":"9af37de9_52cb1273","updated":"2015-05-12 14:41:31.000000000","message":"Sadly, your code can be copy-pasted disregarding what you write it for.","commit_id":"48d15bc40a87f24eaee4e28b211caf69a4512982"},{"author":{"_account_id":13609,"name":"Pavel Boldin","email":"pboldin@mirantis.com","username":"pboldin"},"change_message_id":"0874dbad163f71ec6882752feb9d4e9a02482790","unresolved":false,"context_lines":[{"line_number":45,"context_line":"        self.assertFalse(hasattr(osclients.Clients, \"fuel\"))"},{"line_number":46,"context_line":"        six.moves.reload_module(utils)"},{"line_number":47,"context_line":"        self.assertTrue(hasattr(osclients.Clients, \"fuel\"))"},{"line_number":48,"context_line":"        with mock.patch(UTILS + \"FuelClient\","},{"line_number":49,"context_line":"                        mock.Mock(return_value\u003d\"fuel_client\")):"},{"line_number":50,"context_line":"            with mock.patch(UTILS + \"six\"):"},{"line_number":51,"context_line":"                clients \u003d osclients.Clients(mock.Mock())"}],"source_content_type":"text/x-python","patch_set":10,"id":"1aca2d91_4cdbde4f","line":48,"updated":"2015-05-08 22:33:20.000000000","message":"Please move these to setUp as they are common among two test cases.","commit_id":"48d15bc40a87f24eaee4e28b211caf69a4512982"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"90c0163bb5e178cc65bf9f45f0ec3dc15417c6ea","unresolved":false,"context_lines":[{"line_number":45,"context_line":"        self.assertFalse(hasattr(osclients.Clients, \"fuel\"))"},{"line_number":46,"context_line":"        six.moves.reload_module(utils)"},{"line_number":47,"context_line":"        self.assertTrue(hasattr(osclients.Clients, \"fuel\"))"},{"line_number":48,"context_line":"        with mock.patch(UTILS + \"FuelClient\","},{"line_number":49,"context_line":"                        mock.Mock(return_value\u003d\"fuel_client\")):"},{"line_number":50,"context_line":"            with mock.patch(UTILS + \"six\"):"},{"line_number":51,"context_line":"                clients \u003d osclients.Clients(mock.Mock())"}],"source_content_type":"text/x-python","patch_set":10,"id":"9af37de9_32c88e74","line":48,"in_reply_to":"1aca2d91_35d45eea","updated":"2015-05-09 21:41:42.000000000","message":"What to comment explicitly? I do not understand you. What is wrong with this test?","commit_id":"48d15bc40a87f24eaee4e28b211caf69a4512982"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"17a8d9b9ec2bd72719d2f878aac61e62c7bdb721","unresolved":false,"context_lines":[{"line_number":45,"context_line":"        self.assertFalse(hasattr(osclients.Clients, \"fuel\"))"},{"line_number":46,"context_line":"        six.moves.reload_module(utils)"},{"line_number":47,"context_line":"        self.assertTrue(hasattr(osclients.Clients, \"fuel\"))"},{"line_number":48,"context_line":"        with mock.patch(UTILS + \"FuelClient\","},{"line_number":49,"context_line":"                        mock.Mock(return_value\u003d\"fuel_client\")):"},{"line_number":50,"context_line":"            with mock.patch(UTILS + \"six\"):"},{"line_number":51,"context_line":"                clients \u003d osclients.Clients(mock.Mock())"}],"source_content_type":"text/x-python","patch_set":10,"id":"1aca2d91_d5508ad6","line":48,"in_reply_to":"1aca2d91_4cdbde4f","updated":"2015-05-09 15:30:47.000000000","message":"Read my comment regarding this in previous patch sets","commit_id":"48d15bc40a87f24eaee4e28b211caf69a4512982"},{"author":{"_account_id":13609,"name":"Pavel Boldin","email":"pboldin@mirantis.com","username":"pboldin"},"change_message_id":"7525b3c8e0fe43768cd207f7149a5a0589a185e8","unresolved":false,"context_lines":[{"line_number":45,"context_line":"        self.assertFalse(hasattr(osclients.Clients, \"fuel\"))"},{"line_number":46,"context_line":"        six.moves.reload_module(utils)"},{"line_number":47,"context_line":"        self.assertTrue(hasattr(osclients.Clients, \"fuel\"))"},{"line_number":48,"context_line":"        with mock.patch(UTILS + \"FuelClient\","},{"line_number":49,"context_line":"                        mock.Mock(return_value\u003d\"fuel_client\")):"},{"line_number":50,"context_line":"            with mock.patch(UTILS + \"six\"):"},{"line_number":51,"context_line":"                clients \u003d osclients.Clients(mock.Mock())"}],"source_content_type":"text/x-python","patch_set":10,"id":"1aca2d91_35d45eea","line":48,"in_reply_to":"1aca2d91_d5508ad6","updated":"2015-05-09 15:56:53.000000000","message":"Please then 1. comment this explicitly 2. use nested contexts.","commit_id":"48d15bc40a87f24eaee4e28b211caf69a4512982"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"e6184e81df0c8c67b1f62f6919ce6012262ca998","unresolved":false,"context_lines":[{"line_number":45,"context_line":"        self.assertFalse(hasattr(osclients.Clients, \"fuel\"))"},{"line_number":46,"context_line":"        six.moves.reload_module(utils)"},{"line_number":47,"context_line":"        self.assertTrue(hasattr(osclients.Clients, \"fuel\"))"},{"line_number":48,"context_line":"        with mock.patch(UTILS + \"FuelClient\","},{"line_number":49,"context_line":"                        mock.Mock(return_value\u003d\"fuel_client\")):"},{"line_number":50,"context_line":"            with mock.patch(UTILS + \"six\"):"},{"line_number":51,"context_line":"                clients \u003d osclients.Clients(mock.Mock())"}],"source_content_type":"text/x-python","patch_set":10,"id":"9a0c5dc1_f672d7ac","line":48,"in_reply_to":"9a0c5dc1_1b8354ce","updated":"2015-05-12 14:46:44.000000000","message":"Okay, I will add a comment","commit_id":"48d15bc40a87f24eaee4e28b211caf69a4512982"},{"author":{"_account_id":13609,"name":"Pavel Boldin","email":"pboldin@mirantis.com","username":"pboldin"},"change_message_id":"79321dee319d84cb43e5b4b554764400920aacae","unresolved":false,"context_lines":[{"line_number":45,"context_line":"        self.assertFalse(hasattr(osclients.Clients, \"fuel\"))"},{"line_number":46,"context_line":"        six.moves.reload_module(utils)"},{"line_number":47,"context_line":"        self.assertTrue(hasattr(osclients.Clients, \"fuel\"))"},{"line_number":48,"context_line":"        with mock.patch(UTILS + \"FuelClient\","},{"line_number":49,"context_line":"                        mock.Mock(return_value\u003d\"fuel_client\")):"},{"line_number":50,"context_line":"            with mock.patch(UTILS + \"six\"):"},{"line_number":51,"context_line":"                clients \u003d osclients.Clients(mock.Mock())"}],"source_content_type":"text/x-python","patch_set":10,"id":"9a0c5dc1_1b8354ce","line":48,"in_reply_to":"9af37de9_32c88e74","updated":"2015-05-12 14:41:31.000000000","message":"There is a possibility that there would be an intern whose task would be to rewrite tests in a more clear manner. He/she will come to your code and will try to place these common `mock.patch\u0027 to a setUp/tearDown pair.\n\nIt is better to comment on non-obvious decisions made in the code.","commit_id":"48d15bc40a87f24eaee4e28b211caf69a4512982"},{"author":{"_account_id":13609,"name":"Pavel Boldin","email":"pboldin@mirantis.com","username":"pboldin"},"change_message_id":"0874dbad163f71ec6882752feb9d4e9a02482790","unresolved":false,"context_lines":[{"line_number":56,"context_line":""},{"line_number":57,"context_line":"    @mock.patch(UTILS + \"os\")"},{"line_number":58,"context_line":"    def test___init__(self, mock_os):"},{"line_number":59,"context_line":"        mock_get_client \u003d mock.Mock("},{"line_number":60,"context_line":"            side_effect\u003dlambda *args, **kw: [args, kw])"},{"line_number":61,"context_line":"        mock_fuelclient \u003d mock.Mock(get_client\u003dmock_get_client)"},{"line_number":62,"context_line":"        with mock.patch.dict(\"sys.modules\", {\"fuelclient\": mock_fuelclient}):"}],"source_content_type":"text/x-python","patch_set":10,"id":"1aca2d91_4c24fe5e","line":59,"updated":"2015-05-08 22:33:20.000000000","message":"mock is not required, just\n get_client \u003d lambda *args, **kw: [args, kw]","commit_id":"48d15bc40a87f24eaee4e28b211caf69a4512982"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"421598c1c9dfdc425890a416b7cf027fc0b8e84b","unresolved":false,"context_lines":[{"line_number":56,"context_line":""},{"line_number":57,"context_line":"    @mock.patch(UTILS + \"os\")"},{"line_number":58,"context_line":"    def test___init__(self, mock_os):"},{"line_number":59,"context_line":"        mock_get_client \u003d mock.Mock("},{"line_number":60,"context_line":"            side_effect\u003dlambda *args, **kw: [args, kw])"},{"line_number":61,"context_line":"        mock_fuelclient \u003d mock.Mock(get_client\u003dmock_get_client)"},{"line_number":62,"context_line":"        with mock.patch.dict(\"sys.modules\", {\"fuelclient\": mock_fuelclient}):"}],"source_content_type":"text/x-python","patch_set":10,"id":"9a0c5dc1_1b20f49a","line":59,"in_reply_to":"1aca2d91_4c24fe5e","updated":"2015-05-12 14:33:55.000000000","message":"Done","commit_id":"48d15bc40a87f24eaee4e28b211caf69a4512982"},{"author":{"_account_id":13609,"name":"Pavel Boldin","email":"pboldin@mirantis.com","username":"pboldin"},"change_message_id":"0874dbad163f71ec6882752feb9d4e9a02482790","unresolved":false,"context_lines":[{"line_number":65,"context_line":"                                      server_port\u003d1234,"},{"line_number":66,"context_line":"                                      username\u003d\"foo_user\","},{"line_number":67,"context_line":"                                      password\u003d\"foo_pass\")"},{"line_number":68,"context_line":"            self.assertEqual([mock.call(\"SERVER_ADDRESS\", \"foo_address\"),"},{"line_number":69,"context_line":"                              mock.call(\"LISTEN_PORT\", \"1234\"),"},{"line_number":70,"context_line":"                              mock.call(\"KEYSTONE_USER\", \"foo_user\"),"},{"line_number":71,"context_line":"                              mock.call(\"KEYSTONE_PASS\", \"foo_pass\")],"}],"source_content_type":"text/x-python","patch_set":10,"id":"1aca2d91_8c2e9641","line":68,"updated":"2015-05-08 22:33:20.000000000","message":"why do you do this?\n\nYou should do it:\n mock_os.environ \u003d {}\n\nThen check the contents of mock_os.environ using assertEqual","commit_id":"48d15bc40a87f24eaee4e28b211caf69a4512982"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"421598c1c9dfdc425890a416b7cf027fc0b8e84b","unresolved":false,"context_lines":[{"line_number":65,"context_line":"                                      server_port\u003d1234,"},{"line_number":66,"context_line":"                                      username\u003d\"foo_user\","},{"line_number":67,"context_line":"                                      password\u003d\"foo_pass\")"},{"line_number":68,"context_line":"            self.assertEqual([mock.call(\"SERVER_ADDRESS\", \"foo_address\"),"},{"line_number":69,"context_line":"                              mock.call(\"LISTEN_PORT\", \"1234\"),"},{"line_number":70,"context_line":"                              mock.call(\"KEYSTONE_USER\", \"foo_user\"),"},{"line_number":71,"context_line":"                              mock.call(\"KEYSTONE_PASS\", \"foo_pass\")],"}],"source_content_type":"text/x-python","patch_set":10,"id":"9a0c5dc1_db3a5ccd","line":68,"in_reply_to":"1aca2d91_8c2e9641","updated":"2015-05-12 14:33:55.000000000","message":"Done","commit_id":"48d15bc40a87f24eaee4e28b211caf69a4512982"},{"author":{"_account_id":13609,"name":"Pavel Boldin","email":"pboldin@mirantis.com","username":"pboldin"},"change_message_id":"0874dbad163f71ec6882752feb9d4e9a02482790","unresolved":false,"context_lines":[{"line_number":87,"context_line":"        scenario \u003d utils.FuelScenario()"},{"line_number":88,"context_line":"        self.assertEqual(\"foo_environments_list\","},{"line_number":89,"context_line":"                         scenario._list_environments())"},{"line_number":90,"context_line":"        mock_clients().environment.get_all.assert_called_once_with()"},{"line_number":91,"context_line":"        self._test_atomic_action_timer(scenario.atomic_actions(),"},{"line_number":92,"context_line":"                                       \"fuel.list_environments\")"}],"source_content_type":"text/x-python","patch_set":10,"id":"1aca2d91_2cb782f6","line":90,"updated":"2015-05-08 22:33:20.000000000","message":"mock_clients.return_value.environment...","commit_id":"48d15bc40a87f24eaee4e28b211caf69a4512982"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"17a8d9b9ec2bd72719d2f878aac61e62c7bdb721","unresolved":false,"context_lines":[{"line_number":87,"context_line":"        scenario \u003d utils.FuelScenario()"},{"line_number":88,"context_line":"        self.assertEqual(\"foo_environments_list\","},{"line_number":89,"context_line":"                         scenario._list_environments())"},{"line_number":90,"context_line":"        mock_clients().environment.get_all.assert_called_once_with()"},{"line_number":91,"context_line":"        self._test_atomic_action_timer(scenario.atomic_actions(),"},{"line_number":92,"context_line":"                                       \"fuel.list_environments\")"}],"source_content_type":"text/x-python","patch_set":10,"id":"1aca2d91_55123a0a","line":90,"in_reply_to":"1aca2d91_2cb782f6","updated":"2015-05-09 15:30:47.000000000","message":"I would prefer `mock_clients()...\u0027 since is shorter, and `.return_value...\u0027 gives zero advantages for this test","commit_id":"48d15bc40a87f24eaee4e28b211caf69a4512982"},{"author":{"_account_id":13609,"name":"Pavel Boldin","email":"pboldin@mirantis.com","username":"pboldin"},"change_message_id":"7525b3c8e0fe43768cd207f7149a5a0589a185e8","unresolved":false,"context_lines":[{"line_number":87,"context_line":"        scenario \u003d utils.FuelScenario()"},{"line_number":88,"context_line":"        self.assertEqual(\"foo_environments_list\","},{"line_number":89,"context_line":"                         scenario._list_environments())"},{"line_number":90,"context_line":"        mock_clients().environment.get_all.assert_called_once_with()"},{"line_number":91,"context_line":"        self._test_atomic_action_timer(scenario.atomic_actions(),"},{"line_number":92,"context_line":"                                       \"fuel.list_environments\")"}],"source_content_type":"text/x-python","patch_set":10,"id":"1aca2d91_559c7a5c","line":90,"in_reply_to":"1aca2d91_55123a0a","updated":"2015-05-09 15:56:53.000000000","message":"This promotes bad behavior of calling mocked objects during the test preparation or assertion, making it hard to use \u0027mock_clients.assert_called_once_with()\u0027 after this.\n\ntl;dr: mocks are for the tested code to call, not for the test itself.","commit_id":"48d15bc40a87f24eaee4e28b211caf69a4512982"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"90c0163bb5e178cc65bf9f45f0ec3dc15417c6ea","unresolved":false,"context_lines":[{"line_number":87,"context_line":"        scenario \u003d utils.FuelScenario()"},{"line_number":88,"context_line":"        self.assertEqual(\"foo_environments_list\","},{"line_number":89,"context_line":"                         scenario._list_environments())"},{"line_number":90,"context_line":"        mock_clients().environment.get_all.assert_called_once_with()"},{"line_number":91,"context_line":"        self._test_atomic_action_timer(scenario.atomic_actions(),"},{"line_number":92,"context_line":"                                       \"fuel.list_environments\")"}],"source_content_type":"text/x-python","patch_set":10,"id":"9af37de9_f2a0c6a7","line":90,"in_reply_to":"1aca2d91_559c7a5c","updated":"2015-05-09 21:41:42.000000000","message":"I do not check `mock_clients.assert_called_once_with()\u0027 in this test, because that is not required","commit_id":"48d15bc40a87f24eaee4e28b211caf69a4512982"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"e6184e81df0c8c67b1f62f6919ce6012262ca998","unresolved":false,"context_lines":[{"line_number":87,"context_line":"        scenario \u003d utils.FuelScenario()"},{"line_number":88,"context_line":"        self.assertEqual(\"foo_environments_list\","},{"line_number":89,"context_line":"                         scenario._list_environments())"},{"line_number":90,"context_line":"        mock_clients().environment.get_all.assert_called_once_with()"},{"line_number":91,"context_line":"        self._test_atomic_action_timer(scenario.atomic_actions(),"},{"line_number":92,"context_line":"                                       \"fuel.list_environments\")"}],"source_content_type":"text/x-python","patch_set":10,"id":"9a0c5dc1_36874f63","line":90,"in_reply_to":"9a0c5dc1_1b5a3484","updated":"2015-05-12 14:46:44.000000000","message":"This is common practice for Rally unit tests, and this is good practice at all, and I do not see why this is wrong in this specific test","commit_id":"48d15bc40a87f24eaee4e28b211caf69a4512982"},{"author":{"_account_id":13609,"name":"Pavel Boldin","email":"pboldin@mirantis.com","username":"pboldin"},"change_message_id":"a661a5e141cebe22f35ca1f86386ad850587b51d","unresolved":false,"context_lines":[{"line_number":87,"context_line":"        scenario \u003d utils.FuelScenario()"},{"line_number":88,"context_line":"        self.assertEqual(\"foo_environments_list\","},{"line_number":89,"context_line":"                         scenario._list_environments())"},{"line_number":90,"context_line":"        mock_clients().environment.get_all.assert_called_once_with()"},{"line_number":91,"context_line":"        self._test_atomic_action_timer(scenario.atomic_actions(),"},{"line_number":92,"context_line":"                                       \"fuel.list_environments\")"}],"source_content_type":"text/x-python","patch_set":10,"id":"9a0c5dc1_ac93e6f9","line":90,"in_reply_to":"9a0c5dc1_2cfed66b","updated":"2015-05-12 19:03:47.000000000","message":"Second one has a side-effect that adds a mock call into the calls list.","commit_id":"48d15bc40a87f24eaee4e28b211caf69a4512982"},{"author":{"_account_id":13609,"name":"Pavel Boldin","email":"pboldin@mirantis.com","username":"pboldin"},"change_message_id":"9463af2be2cfbc3d45c8b1bf2bb4a70c31823334","unresolved":false,"context_lines":[{"line_number":87,"context_line":"        scenario \u003d utils.FuelScenario()"},{"line_number":88,"context_line":"        self.assertEqual(\"foo_environments_list\","},{"line_number":89,"context_line":"                         scenario._list_environments())"},{"line_number":90,"context_line":"        mock_clients().environment.get_all.assert_called_once_with()"},{"line_number":91,"context_line":"        self._test_atomic_action_timer(scenario.atomic_actions(),"},{"line_number":92,"context_line":"                                       \"fuel.list_environments\")"}],"source_content_type":"text/x-python","patch_set":10,"id":"9a0c5dc1_96befbfd","line":90,"in_reply_to":"9a0c5dc1_36874f63","updated":"2015-05-12 14:49:11.000000000","message":"This common practice is wrong. We need to start writing the code that is not using it.","commit_id":"48d15bc40a87f24eaee4e28b211caf69a4512982"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"4b2950a84b3c2121b8ee5e51fd180c99a4530de7","unresolved":false,"context_lines":[{"line_number":87,"context_line":"        scenario \u003d utils.FuelScenario()"},{"line_number":88,"context_line":"        self.assertEqual(\"foo_environments_list\","},{"line_number":89,"context_line":"                         scenario._list_environments())"},{"line_number":90,"context_line":"        mock_clients().environment.get_all.assert_called_once_with()"},{"line_number":91,"context_line":"        self._test_atomic_action_timer(scenario.atomic_actions(),"},{"line_number":92,"context_line":"                                       \"fuel.list_environments\")"}],"source_content_type":"text/x-python","patch_set":10,"id":"9a0c5dc1_b6ad7f33","line":90,"in_reply_to":"9a0c5dc1_96befbfd","updated":"2015-05-12 14:56:49.000000000","message":"This should be discussed with boris-42","commit_id":"48d15bc40a87f24eaee4e28b211caf69a4512982"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"a109461f5911327917ff8acaa961e9b4ebc3c433","unresolved":false,"context_lines":[{"line_number":87,"context_line":"        scenario \u003d utils.FuelScenario()"},{"line_number":88,"context_line":"        self.assertEqual(\"foo_environments_list\","},{"line_number":89,"context_line":"                         scenario._list_environments())"},{"line_number":90,"context_line":"        mock_clients().environment.get_all.assert_called_once_with()"},{"line_number":91,"context_line":"        self._test_atomic_action_timer(scenario.atomic_actions(),"},{"line_number":92,"context_line":"                                       \"fuel.list_environments\")"}],"source_content_type":"text/x-python","patch_set":10,"id":"9a0c5dc1_2cfed66b","line":90,"in_reply_to":"9a0c5dc1_b6ad7f33","updated":"2015-05-12 18:59:09.000000000","message":"Both ways are okay: \n\n  1) return_value - is more strict \n\n   2) () - is shorter \n\nboth works as expected..","commit_id":"48d15bc40a87f24eaee4e28b211caf69a4512982"},{"author":{"_account_id":13609,"name":"Pavel Boldin","email":"pboldin@mirantis.com","username":"pboldin"},"change_message_id":"79321dee319d84cb43e5b4b554764400920aacae","unresolved":false,"context_lines":[{"line_number":87,"context_line":"        scenario \u003d utils.FuelScenario()"},{"line_number":88,"context_line":"        self.assertEqual(\"foo_environments_list\","},{"line_number":89,"context_line":"                         scenario._list_environments())"},{"line_number":90,"context_line":"        mock_clients().environment.get_all.assert_called_once_with()"},{"line_number":91,"context_line":"        self._test_atomic_action_timer(scenario.atomic_actions(),"},{"line_number":92,"context_line":"                                       \"fuel.list_environments\")"}],"source_content_type":"text/x-python","patch_set":10,"id":"9a0c5dc1_1b5a3484","line":90,"in_reply_to":"9af37de9_f2a0c6a7","updated":"2015-05-12 14:41:31.000000000","message":"See the comment above. Please, don\u0027t call mocks inside the tests.","commit_id":"48d15bc40a87f24eaee4e28b211caf69a4512982"}],"tests/unit/plugins/openstack/scenarios/fuel/test_utils.py":[{"author":{"_account_id":8507,"name":"Mikhail Dubov","email":"mdubov@mirantis.com","username":"msdubov"},"change_message_id":"37ed418365fb554f4561e84e8c9cbbbf4507a953","unresolved":false,"context_lines":[{"line_number":23,"context_line":"UTILS \u003d \"rally.plugins.openstack.scenarios.fuel.utils.\""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"class ModuleTestCase(test.TestCase):"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    @mock.patch(UTILS + \"six\")"},{"line_number":29,"context_line":"    @mock.patch(UTILS + \"FuelClient\", return_value\u003d\"fuel_client\")"}],"source_content_type":"text/x-python","patch_set":18,"id":"7a016987_d6e15b2b","line":26,"updated":"2015-05-22 14:28:38.000000000","message":"Why not merge this class with FuelClientTestCase? This would make sense imho","commit_id":"e824908a716c8d89aba5be06ecb93c283fa2a495"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"e9d4d66b30a46bf878f294af352f8d682a07ed13","unresolved":false,"context_lines":[{"line_number":23,"context_line":"UTILS \u003d \"rally.plugins.openstack.scenarios.fuel.utils.\""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"class ModuleTestCase(test.TestCase):"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    @mock.patch(UTILS + \"six\")"},{"line_number":29,"context_line":"    @mock.patch(UTILS + \"FuelClient\", return_value\u003d\"fuel_client\")"}],"source_content_type":"text/x-python","patch_set":18,"id":"7a016987_37f64d5d","line":26,"in_reply_to":"7a016987_d6e15b2b","updated":"2015-05-25 09:09:09.000000000","message":"Because here we test module-level stuff","commit_id":"e824908a716c8d89aba5be06ecb93c283fa2a495"},{"author":{"_account_id":8507,"name":"Mikhail Dubov","email":"mdubov@mirantis.com","username":"msdubov"},"change_message_id":"37ed418365fb554f4561e84e8c9cbbbf4507a953","unresolved":false,"context_lines":[{"line_number":46,"context_line":"        six.moves.reload_module(utils)"},{"line_number":47,"context_line":"        self.assertTrue(hasattr(osclients.Clients, \"fuel\"))"},{"line_number":48,"context_line":"        # NOTE(amaretskiy): Now we can finally mock utils.FuelClient,"},{"line_number":49,"context_line":"        # since `reload_module\u0027 above destoys mocks"},{"line_number":50,"context_line":"        with mock.patch(UTILS + \"FuelClient\","},{"line_number":51,"context_line":"                        mock.Mock(return_value\u003d\"fuel_client\")):"},{"line_number":52,"context_line":"            with mock.patch(UTILS + \"six\"):"}],"source_content_type":"text/x-python","patch_set":18,"id":"7a016987_76c987ab","line":49,"updated":"2015-05-22 14:28:38.000000000","message":"s/destoys/destroys","commit_id":"e824908a716c8d89aba5be06ecb93c283fa2a495"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"01040514f06d6c4dfad78f33033a43ec8814650e","unresolved":false,"context_lines":[{"line_number":88,"context_line":"        scenario \u003d utils.FuelScenario()"},{"line_number":89,"context_line":"        self.assertEqual(\"foo_environments_list\","},{"line_number":90,"context_line":"                         scenario._list_environments())"},{"line_number":91,"context_line":"        mock_clients().environment.get_all.assert_called_once_with()"},{"line_number":92,"context_line":"        self._test_atomic_action_timer(scenario.atomic_actions(),"},{"line_number":93,"context_line":"                                       \"fuel.list_environments\")"}],"source_content_type":"text/x-python","patch_set":21,"id":"7a016987_c02edba4","line":91,"updated":"2015-05-26 21:27:53.000000000","message":"it\u0027s really better to use \n\n       mock_clients.return_value.environment.get_all.assert_called_once_with()","commit_id":"4f5868744e19e5056a580ddfe3e8a4a3278e6b1a"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"de6363fd0eeb0c5be2a2cf4194c6cb0c43fa0f89","unresolved":false,"context_lines":[{"line_number":88,"context_line":"        scenario \u003d utils.FuelScenario()"},{"line_number":89,"context_line":"        self.assertEqual(\"foo_environments_list\","},{"line_number":90,"context_line":"                         scenario._list_environments())"},{"line_number":91,"context_line":"        mock_clients().environment.get_all.assert_called_once_with()"},{"line_number":92,"context_line":"        self._test_atomic_action_timer(scenario.atomic_actions(),"},{"line_number":93,"context_line":"                                       \"fuel.list_environments\")"}],"source_content_type":"text/x-python","patch_set":21,"id":"7a016987_4971e8df","line":91,"in_reply_to":"7a016987_c02edba4","updated":"2015-05-27 09:27:58.000000000","message":"Done","commit_id":"4f5868744e19e5056a580ddfe3e8a4a3278e6b1a"}]}
