)]}'
{"doc/source/plugins.rst":[{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"858b4cc13f593947e9656a5acfec08b155e88508","unresolved":false,"context_lines":[{"line_number":235,"context_line":""},{"line_number":236,"context_line":".. code-block:: none"},{"line_number":237,"context_line":""},{"line_number":238,"context_line":"    from rally.plugins.common.sla import base"},{"line_number":239,"context_line":""},{"line_number":240,"context_line":""},{"line_number":241,"context_line":"    class MaxDurationRange(base.SLA):"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1aca2d91_3fc71514","line":238,"updated":"2015-05-06 12:59:53.000000000","message":"Nope this should be done in different way.\nThis is not backward compatible change and can break custom out of tree plugins.\n\nWe should do next things:\n\n  - split base.py to 2 parts (plugins and base code) \n  - move plugins to separated dir","commit_id":"1dc1eb7319064aadbbd7af3980d3054b5166ff2c"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"04fb86efaa584ec038409faabde4fa8d1456be2b","unresolved":false,"context_lines":[{"line_number":235,"context_line":""},{"line_number":236,"context_line":".. code-block:: none"},{"line_number":237,"context_line":""},{"line_number":238,"context_line":"    from rally.plugins.common.sla import base"},{"line_number":239,"context_line":""},{"line_number":240,"context_line":""},{"line_number":241,"context_line":"    class MaxDurationRange(base.SLA):"}],"source_content_type":"text/x-rst","patch_set":5,"id":"1aca2d91_9db98c31","line":238,"updated":"2015-05-06 15:02:06.000000000","message":"We already spoke in IRC regarding to breaking backward compatibility \u003d(\n\nYou can\u0027t touch base.py module, you can\u0027t move it, you can\u0027t rename anything inside it that is related to base of support of sla checkers. \n\nthis import should stay as is: \n\n  from rally.benchmark import base \n\n\nThe only thing that you may change is to move all plugins outside of base.py module and move it to rally/plugins....","commit_id":"77d5904689c73b4b1108938bc5c676f947415927"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"d7607fd695d8daf212ce8ad069096fe92c7a6c3d","unresolved":false,"context_lines":[{"line_number":235,"context_line":""},{"line_number":236,"context_line":".. code-block:: none"},{"line_number":237,"context_line":""},{"line_number":238,"context_line":"    from rally.plugins.common.sla import base"},{"line_number":239,"context_line":""},{"line_number":240,"context_line":""},{"line_number":241,"context_line":"    class MaxDurationRange(base.SLA):"}],"source_content_type":"text/x-rst","patch_set":6,"id":"1aca2d91_3d94b835","line":238,"updated":"2015-05-06 15:02:31.000000000","message":"We already spoke in IRC regarding to breaking backward compatibility \u003d(\nYou can\u0027t touch base.py module, you can\u0027t move it, you can\u0027t rename anything inside it that is related to base of support of sla checkers.\nthis import should stay as is:\n  from rally.benchmark import base \nThe only thing that you may change is to move all plugins outside of base.py module and move it to rally/plugins....","commit_id":"bc04828f53e9805113ff8140958244efe094f172"}],"rally/cmd/cliutils.py":[{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"ddd462e4c61252c3e73ce781cd70aadc73bebc4c","unresolved":false,"context_lines":[{"line_number":510,"context_line":"    try:"},{"line_number":511,"context_line":"        utils.load_plugins(\"/opt/rally/plugins/\")"},{"line_number":512,"context_line":"        utils.load_plugins(os.path.expanduser(\"~/.rally/plugins/\"))"},{"line_number":513,"context_line":"        utils.load_plugins(\"rally.plugins\")"},{"line_number":514,"context_line":""},{"line_number":515,"context_line":"        validate_deprecated_args(argv, fn)"},{"line_number":516,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"9af37de9_ce11965f","line":513,"updated":"2015-05-11 01:49:42.000000000","message":"Nope this won\u0027t work. As I said in IRC you should import  to use different method: \n\n  utils.import_modules_from_package(\"rally.plugin\")\n\nYou are importing from module not from path.","commit_id":"57f1db2fdfde52531a5c9613d1853f9162ebff79"}],"rally/cmd/commands/info.py":[{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"cc63fbf26aa148e680fcfd0f8f27214ba697a0b1","unresolved":false,"context_lines":[{"line_number":55,"context_line":"from rally import deploy"},{"line_number":56,"context_line":"from rally.deploy import serverprovider"},{"line_number":57,"context_line":"from rally import exceptions"},{"line_number":58,"context_line":"from rally.plugins.common.sla import sla_plugin"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"class InfoCommands(object):"}],"source_content_type":"text/x-python","patch_set":7,"id":"1aca2d91_bbae5096","line":58,"updated":"2015-05-07 21:44:17.000000000","message":"I know why you have added this. But this is just hiding of bug that is going to hit us later. \n\nYou should import all plugins from plugin tree.\nTo do that properly you should do next: \n\nAdd here https://github.com/openstack/rally/blob/master/rally/cmd/cliutils.py#L511-L512 one more line that imports whole \"rally/plugin\" tree","commit_id":"1d81f5713597910796af60a024fae3f89e5a3274"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"5fa51bc5e03b1798da931e88bfee7309f1d31025","unresolved":false,"context_lines":[{"line_number":162,"context_line":"                \"assosiated value, e.g.:\\n\\n\""},{"line_number":163,"context_line":"                \"  sla:\\n\""},{"line_number":164,"context_line":"                \"    max_seconds_per_iteration: 4\\n\""},{"line_number":165,"context_line":"                \"    sla_base:\\n\""},{"line_number":166,"context_line":"                \"      max: 1\""},{"line_number":167,"context_line":"                \"\\n\\n\" +"},{"line_number":168,"context_line":"                self._compose_table(\"List of SLA checks\", sla) +"}],"source_content_type":"text/x-python","patch_set":9,"id":"9a0c5dc1_e80e7de4","line":165,"updated":"2015-05-12 12:43:16.000000000","message":"seems like a bug.","commit_id":"3622dbfd66321953d6abb90c4064e52ab13e139e"}],"rally/plugins/common/sla/sla_plugin.py":[{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"cc63fbf26aa148e680fcfd0f8f27214ba697a0b1","unresolved":false,"context_lines":[{"line_number":24,"context_line":"from rally.common import streaming_algorithms"},{"line_number":25,"context_line":"from rally import consts"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"SLA \u003d sla.SLA"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"class FailureRateDeprecated(SLA):"}],"source_content_type":"text/x-python","patch_set":7,"id":"1aca2d91_c0ea3dac","line":27,"updated":"2015-05-07 21:44:17.000000000","message":"This is very bad pattern. \n\nPlease just remove this line","commit_id":"1d81f5713597910796af60a024fae3f89e5a3274"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"cc63fbf26aa148e680fcfd0f8f27214ba697a0b1","unresolved":false,"context_lines":[{"line_number":27,"context_line":"SLA \u003d sla.SLA"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"class FailureRateDeprecated(SLA):"},{"line_number":31,"context_line":"    \"\"\"[Deprecated] Failure rate in percents.\"\"\""},{"line_number":32,"context_line":"    OPTION_NAME \u003d \"max_failure_percent\""},{"line_number":33,"context_line":"    CONFIG_SCHEMA \u003d {\"type\": \"number\", \"minimum\": 0.0, \"maximum\": 100.0}"}],"source_content_type":"text/x-python","patch_set":7,"id":"1aca2d91_3bffe0ab","line":30,"updated":"2015-05-07 21:44:17.000000000","message":"As we discuss before in IRC.\n\nWe should put each plugin in separated file: \n\n  e.g. \n\n  max_failure_precent.py : \n   \n    class FailureRateDeprecated\n\n\n  failure_rate.py:\n\n    class FailureRate\n\n\n  ...","commit_id":"1d81f5713597910796af60a024fae3f89e5a3274"}],"samples/plugins/sla/sla_plugin.py":[{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"76032a85552cdb5d71013b7fbbfdde1771290a84","unresolved":false,"context_lines":[{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"from rally.common.i18n import _"},{"line_number":17,"context_line":"from rally.plugins.common.sla import failure_rate"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"class MaxDurationRange(failure_rate.SLA):"}],"source_content_type":"text/x-python","patch_set":8,"id":"9af37de9_11ffbf02","line":17,"updated":"2015-05-11 01:50:47.000000000","message":"Okay I am not sure what you are trying to achieve here...","commit_id":"57f1db2fdfde52531a5c9613d1853f9162ebff79"}]}