)]}'
{"rally/benchmark/context/sahara/sahara_output_data_sources.py":[{"author":{"_account_id":7132,"name":"Nikita Konovalov","email":"nkonovalov@mirantis.com","username":"nkonovalov"},"change_message_id":"56cc2be2e7fa007149211ada9f3f06e732a4849c","unresolved":false,"context_lines":[{"line_number":96,"context_line":"                            username, password):"},{"line_number":97,"context_line":"        file_name \u003d rutils.generate_random_name()"},{"line_number":98,"context_line":"        self.context[\"sahara\"][container_name][\"output_swift_objects\"].append("},{"line_number":99,"context_line":"            swift._upload_object(container_name,"},{"line_number":100,"context_line":"                                 \"\","},{"line_number":101,"context_line":"                                 object_name\u003dfile_name))"},{"line_number":102,"context_line":"        output_ds_swift \u003d sahara.data_sources.create("}],"source_content_type":"text/x-python","patch_set":3,"id":"7a016987_8008a092","line":99,"updated":"2015-05-18 10:27:32.000000000","message":"There is no need to upload anything to the output container. Hadoop will do that.","commit_id":"e7258edfba9cb7a5fecd0e0bf942119453d02128"},{"author":{"_account_id":7132,"name":"Nikita Konovalov","email":"nkonovalov@mirantis.com","username":"nkonovalov"},"change_message_id":"c266b17840caa5ba532280a1e7ba84061d85bb4a","unresolved":false,"context_lines":[{"line_number":124,"context_line":"                swift._delete_container(container_name)"},{"line_number":125,"context_line":"        else:"},{"line_number":126,"context_line":"            resources \u003d [\"data_sources\"]"},{"line_number":127,"context_line":"            resource_manager.cleanup("},{"line_number":128,"context_line":"                names\u003d[\"sahara.%s\" % res for res in resources],"},{"line_number":129,"context_line":"                users\u003dself.context.get(\"users\", []))"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a016987_337fef67","line":127,"updated":"2015-05-19 12:14:22.000000000","message":"We should be cleaning Data Source objects anyway.","commit_id":"a69694d92240686ecbe89bfe6ed5fedff7241c1a"},{"author":{"_account_id":13919,"name":"Evgeny Sikachev","email":"esikachov@gmail.com","username":"esikachev"},"change_message_id":"d4d192fc877109a8610dcc50b5249c43a1f68cc4","unresolved":false,"context_lines":[{"line_number":124,"context_line":"                swift._delete_container(container_name)"},{"line_number":125,"context_line":"        else:"},{"line_number":126,"context_line":"            resources \u003d [\"data_sources\"]"},{"line_number":127,"context_line":"            resource_manager.cleanup("},{"line_number":128,"context_line":"                names\u003d[\"sahara.%s\" % res for res in resources],"},{"line_number":129,"context_line":"                users\u003dself.context.get(\"users\", []))"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a016987_33124f0a","line":127,"in_reply_to":"7a016987_337fef67","updated":"2015-05-19 12:21:52.000000000","message":"done","commit_id":"a69694d92240686ecbe89bfe6ed5fedff7241c1a"}],"rally/plugins/openstack/context/sahara/sahara_output_data_sources.py":[{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"47aaf07935e4d96eb324ff98c0d0af5c16270269","unresolved":false,"context_lines":[{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    def __init__(self, context):"},{"line_number":49,"context_line":"        super(SaharaOutputDataSources, self).__init__(context)"},{"line_number":50,"context_line":"        self.context[\"sahara\"] \u003d {}"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    @rutils.log_task_wrapper(LOG.info,"},{"line_number":53,"context_line":"                             _(\"Enter context: `Sahara Output Data Sources`\"))"}],"source_content_type":"text/x-python","patch_set":19,"id":"3a50d1a3_a90dd3e9","line":50,"updated":"2015-07-31 13:16:29.000000000","message":"This better to make in setup() and delete __init__","commit_id":"31d54d6511667d02ab061fa39c7546795f6b5c56"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"47aaf07935e4d96eb324ff98c0d0af5c16270269","unresolved":false,"context_lines":[{"line_number":77,"context_line":"                    \"output_swift_objects\": []"},{"line_number":78,"context_line":"                }"},{"line_number":79,"context_line":"                username \u003d user[\"endpoint\"].username"},{"line_number":80,"context_line":"                password \u003d user[\"endpoint\"].password"},{"line_number":81,"context_line":"                self.setup_outputs_swift(swift, sahara, tenant_id,"},{"line_number":82,"context_line":"                                         container_name, username, password)"},{"line_number":83,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":19,"id":"3a50d1a3_8f71f7e0","line":80,"updated":"2015-07-31 13:16:29.000000000","message":"Please delete local variable that u created just to pass them to params","commit_id":"31d54d6511667d02ab061fa39c7546795f6b5c56"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"47aaf07935e4d96eb324ff98c0d0af5c16270269","unresolved":false,"context_lines":[{"line_number":104,"context_line":""},{"line_number":105,"context_line":"        self.context[\"tenants\"][tenant_id][\"sahara_output\"] \u003d ("},{"line_number":106,"context_line":"            output_ds_swift.id"},{"line_number":107,"context_line":"        )"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"    @rutils.log_task_wrapper(LOG.info, _(\"Exit context: `Sahara Output Data \""},{"line_number":110,"context_line":"                                         \"Sources`\"))"}],"source_content_type":"text/x-python","patch_set":19,"id":"3a50d1a3_af0ab377","line":107,"updated":"2015-07-31 13:16:29.000000000","message":"I prefer to create here one function setup_outputs() that will realize functionality of two functions setup_outputs_hdfs and setup_outputs_swift. Whithout const they do exactly the same.","commit_id":"31d54d6511667d02ab061fa39c7546795f6b5c56"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"47aaf07935e4d96eb324ff98c0d0af5c16270269","unresolved":false,"context_lines":[{"line_number":121,"context_line":"                    for swift_object in swift_objects:"},{"line_number":122,"context_line":"                        swift._delete_object(container_name,"},{"line_number":123,"context_line":"                                             swift_object[1])"},{"line_number":124,"context_line":"                swift._delete_container(container_name)"},{"line_number":125,"context_line":"        resources \u003d [\"data_sources\"]"},{"line_number":126,"context_line":"        resource_manager.cleanup("},{"line_number":127,"context_line":"            names\u003d[\"sahara.%s\" % res for res in resources],"}],"source_content_type":"text/x-python","patch_set":19,"id":"3a50d1a3_4f99af78","line":124,"updated":"2015-07-31 13:16:29.000000000","message":"This need to be done in resource manager.  https://github.com/openstack/rally/blob/master/rally/plugins/openstack/context/cleanup/resources.py","commit_id":"31d54d6511667d02ab061fa39c7546795f6b5c56"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"a42977921fe331b26c476cbf0371f8acb10628d8","unresolved":false,"context_lines":[{"line_number":118,"context_line":"                    swift_objects \u003d swift._list_objects(container_name)"},{"line_number":119,"context_line":"                    for swift_object in swift_objects:"},{"line_number":120,"context_line":"                        res_cleanup.SwiftObject(swift_object[1])"},{"line_number":121,"context_line":"                res_cleanup.SwiftContainer(container_name)"},{"line_number":122,"context_line":"        resources \u003d [\"data_sources\"]"},{"line_number":123,"context_line":"        resource_manager.cleanup("},{"line_number":124,"context_line":"            names\u003d[\"sahara.%s\" % res for res in resources],"}],"source_content_type":"text/x-python","patch_set":20,"id":"3a50d1a3_2995263f","line":121,"updated":"2015-07-31 22:34:49.000000000","message":"We need to use swift context for manage Swift object (setup and cleanup), not to call them in sahara context. This will create not needed relations between contexts and not allow us to use it as a plugins.","commit_id":"38eac73d21a4615ec84af2a62f841b0c7db719dc"},{"author":{"_account_id":9601,"name":"Oleh Anufriiev","email":"oanufriev@mirantis.com","username":"oanufriev"},"change_message_id":"74eca7031b3b4ee440944ff052c7af01d3d2ed5d","unresolved":false,"context_lines":[{"line_number":52,"context_line":"        self.context[\"sahara\"] \u003d {}"},{"line_number":53,"context_line":"        self.context[\"sahara_output_conf\"] \u003d {"},{"line_number":54,"context_line":"            \"output_type\": self.config[\"output_type\"],"},{"line_number":55,"context_line":"            \"output_url_prefix\": self.config[\"output_url_prefix\"]}"},{"line_number":56,"context_line":"        output_type \u003d self.context[\"sahara_output_conf\"][\"output_type\"]"},{"line_number":57,"context_line":"        output_url_prefix \u003d ("},{"line_number":58,"context_line":"            self.context[\"sahara_output_conf\"][\"output_url_prefix\"]"},{"line_number":59,"context_line":"        )"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"        for user, tenant_id in rutils.iterate_per_tenants("},{"line_number":62,"context_line":"                self.context[\"users\"]):"}],"source_content_type":"text/x-python","patch_set":24,"id":"fa80f949_e873da4b","line":59,"range":{"start_line":55,"start_character":1,"end_line":59,"end_character":9},"updated":"2015-11-04 15:32:13.000000000","message":"Using context[\"sahara\"], context[\"sahara_output_conf\"],\ncontext[\"sahara\"][container_name] and context[\"tenants\"][tenant_id][\"sahara_output\"] is too conplicated and confusing.\nYou have to collect all sahara data under context[\"tenants\"][tenant_id][\"sahara\"][\"output\"][container_name, conf, swift_objects] and other.","commit_id":"2e823dd89550c85a34d78cf6f43c86280cc635a7"},{"author":{"_account_id":9601,"name":"Oleh Anufriiev","email":"oanufriev@mirantis.com","username":"oanufriev"},"change_message_id":"4d10a1e2c2fab0ae7cb25a44d2c49ed86ff5b91e","unresolved":false,"context_lines":[{"line_number":60,"context_line":"                                                  context\u003dself.context)"},{"line_number":61,"context_line":"                container_name \u003d rutils.generate_random_name("},{"line_number":62,"context_line":"                    prefix\u003dself.config[\"output_url_prefix\"])"},{"line_number":63,"context_line":"                self.context[\"tenants\"][tenant_id][\"container\"] \u003d {"},{"line_number":64,"context_line":"                    \"name\": swift._create_container("},{"line_number":65,"context_line":"                        container_name\u003dcontainer_name),"},{"line_number":66,"context_line":"                    \"output_swift_objects\": []"}],"source_content_type":"text/x-python","patch_set":25,"id":"da85f559_cf9c8b11","line":63,"updated":"2015-11-11 01:41:29.000000000","message":"Please, just use self.context[\"tenants\"][tenant_id][\"sahara\"][...]\n\nWhat if another context sets [\"tenants\"][tenant_id][\"container\"] too? Some swift context, for example...","commit_id":"a33fc5f6049d0d8559f8e7fc8db33c77938fcabb"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"70c9d2ab0f3ced74c575932f0a84d27ae2a4fb93","unresolved":false,"context_lines":[{"line_number":60,"context_line":"                                                  context\u003dself.context)"},{"line_number":61,"context_line":"                container_name \u003d rutils.generate_random_name("},{"line_number":62,"context_line":"                    prefix\u003dself.config[\"output_url_prefix\"])"},{"line_number":63,"context_line":"                self.context[\"tenants\"][tenant_id][\"container\"] \u003d {"},{"line_number":64,"context_line":"                    \"name\": swift._create_container("},{"line_number":65,"context_line":"                        container_name\u003dcontainer_name),"},{"line_number":66,"context_line":"                    \"output_swift_objects\": []"}],"source_content_type":"text/x-python","patch_set":25,"id":"ba8a016a_0b4e596f","line":63,"in_reply_to":"da85f559_cf9c8b11","updated":"2015-11-17 10:10:20.000000000","message":"so I totally agree with this comment. Because there are other projects that may use \"container\" word.","commit_id":"a33fc5f6049d0d8559f8e7fc8db33c77938fcabb"},{"author":{"_account_id":7369,"name":"Sergey Skripnick","email":"sskripnick@mirantis.com","username":"redixin"},"change_message_id":"d542b62601bb00c31b15fce81db7e060be7fc6bf","unresolved":false,"context_lines":[{"line_number":58,"context_line":"            if self.config[\"output_type\"] \u003d\u003d \"swift\":"},{"line_number":59,"context_line":"                swift \u003d swift_utils.SwiftScenario(clients\u003dclients,"},{"line_number":60,"context_line":"                                                  context\u003dself.context)"},{"line_number":61,"context_line":"                container_name \u003d rutils.generate_random_name("},{"line_number":62,"context_line":"                    prefix\u003dself.config[\"output_url_prefix\"])"},{"line_number":63,"context_line":"                self.context[\"tenants\"][tenant_id][\"sahara_container\"] \u003d {"},{"line_number":64,"context_line":"                    \"name\": swift._create_container("}],"source_content_type":"text/x-python","patch_set":26,"id":"ba8a016a_b45bd6f5","line":61,"updated":"2015-11-17 16:17:20.000000000","message":"I have a doubt. This will not match to delete in our cleanup code, and will not be deleted if self.cleanup failed somehow.","commit_id":"2195f8de9ca9f17f5ba7c1ddd4240370a03eb78b"},{"author":{"_account_id":13919,"name":"Evgeny Sikachev","email":"esikachov@gmail.com","username":"esikachev"},"change_message_id":"6f7f6de6a33e873f5f4777b6c3dc4a05e0011d08","unresolved":false,"context_lines":[{"line_number":109,"context_line":"                        \"output_swift_objects\"]):"},{"line_number":110,"context_line":"                    res_cleanup.SwiftObject(swift_object[1])"},{"line_number":111,"context_line":"            res_cleanup.SwiftContainer("},{"line_number":112,"context_line":"                self.context[\"tenants\"][tenant_id].get(\"sahara_container\","},{"line_number":113,"context_line":"                                                       {}).get(\"name\"))"},{"line_number":114,"context_line":"        resources \u003d [\"data_sources\"]"},{"line_number":115,"context_line":"        resource_manager.cleanup("}],"source_content_type":"text/x-python","patch_set":26,"id":"ba8a016a_749fae50","line":112,"updated":"2015-11-17 16:19:48.000000000","message":"this line remove it","commit_id":"2195f8de9ca9f17f5ba7c1ddd4240370a03eb78b"},{"author":{"_account_id":7369,"name":"Sergey Skripnick","email":"sskripnick@mirantis.com","username":"redixin"},"change_message_id":"1a1d685a928e275541bef93ff4949ce1ecb7f10c","unresolved":false,"context_lines":[{"line_number":109,"context_line":"                        \"output_swift_objects\"]):"},{"line_number":110,"context_line":"                    res_cleanup.SwiftObject(swift_object[1])"},{"line_number":111,"context_line":"            res_cleanup.SwiftContainer("},{"line_number":112,"context_line":"                self.context[\"tenants\"][tenant_id].get(\"sahara_container\","},{"line_number":113,"context_line":"                                                       {}).get(\"name\"))"},{"line_number":114,"context_line":"        resources \u003d [\"data_sources\"]"},{"line_number":115,"context_line":"        resource_manager.cleanup("}],"source_content_type":"text/x-python","patch_set":26,"id":"ba8a016a_df91c09a","line":112,"in_reply_to":"ba8a016a_749fae50","updated":"2015-11-17 23:21:15.000000000","message":"\u003e and will not be deleted if self.cleanup failed somehow.","commit_id":"2195f8de9ca9f17f5ba7c1ddd4240370a03eb78b"}]}
