)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":13609,"name":"Pavel Boldin","email":"pboldin@mirantis.com","username":"pboldin"},"change_message_id":"4349cbc898f326bf9c53eb615f4664bc8f2fb182","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Maplalabs \u003cmaniram.sekaran@maplelabs.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-05-26 17:22:51 +0530"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Added Loadbalancer create and list pool"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: If51f6286be49724c0bc4ae343815704f01153e97"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"7a016987_69c3ab39","line":7,"updated":"2015-05-26 12:09:09.000000000","message":"Just \u0027add\u0027.","commit_id":"44976446de430238bb94b0adfca36061b7fe0f6e"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"66dbf97ea7bd67994a5995c267379af5373df55e","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2015-05-27 07:34:34 +0530"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add Loadbalancer create and list pool"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: If51f6286be49724c0bc4ae343815704f01153e97"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"7a016987_ce8cbe81","line":8,"updated":"2015-05-27 08:47:37.000000000","message":"Please, add more details about change. Mention that new scenario is related to \"Neutron\", etc...","commit_id":"3c40938a4d03ee6c1087992e6e11467a381f10c1"},{"author":{"_account_id":13609,"name":"Pavel Boldin","email":"pboldin@mirantis.com","username":"pboldin"},"change_message_id":"3c249bea40f3374646b9265350901fac173bb3b8","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add Neutron Loadbalancer create and list pool"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch would enable benchmarking of neutron loadbalancer pool-create and pool-list."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: If51f6286be49724c0bc4ae343815704f01153e97"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":15,"id":"7a016987_6ac20feb","line":9,"updated":"2015-05-28 17:40:07.000000000","message":"Line is too long.\n\n\u0027This patch would\u0027 is not needed.","commit_id":"61c53bdc5fd03faecd77bc821de4c73858faa275"},{"author":{"_account_id":13609,"name":"Pavel Boldin","email":"pboldin@mirantis.com","username":"pboldin"},"change_message_id":"4acb3c26ee18341ceb14e9b5c8a085f1914e78a9","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add Neutron Loadbalancer(v1) create and list pool"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Enable benchmarking of neutron loadbalancer v1 pool-create and pool-list."},{"line_number":10,"context_line":"LBaaS v1 uses path \"lb/pools\" and LBaaS v2 \"lbaas/pools\" thus"},{"line_number":11,"context_line":"neutron differentiates v1 pools and v2 pools by lb and lbaas respectively."},{"line_number":12,"context_line":"Using the same convention in rally scenarios does not seem good, hence"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":33,"id":"3afb71cf_b3336262","line":9,"updated":"2015-06-11 15:25:20.000000000","message":"Commit message is outdated.","commit_id":"c3471d3c713ae5a05e188b579d9b0edc5f56fb6b"},{"author":{"_account_id":13609,"name":"Pavel Boldin","email":"pboldin@mirantis.com","username":"pboldin"},"change_message_id":"a44cef48013a95cab3dcdae9f33960c61d43459c","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add Neutron Loadbalancer(v1) create and list pool"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Enable benchmarking of neutron loadbalancer v1 pool-create and pool-list."},{"line_number":10,"context_line":"LBaaS v1 uses path \"lb/pools\" and LBaaS v2 \"lbaas/pools\" thus"},{"line_number":11,"context_line":"neutron differentiates v1 pools and v2 pools by lb and lbaas respectively."},{"line_number":12,"context_line":"Using the same convention in rally scenarios does not seem good, hence"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":33,"id":"3afb71cf_2bedbaef","line":9,"in_reply_to":"3afb71cf_0b4c3e75","updated":"2015-06-11 16:22:36.000000000","message":"Add Neutron LoadBalancer v1 create and list pool\n\nEnable benchmarking of the Neutron LoadBalancer v1 pool-create and pool-list APIs. Due to the different API scheme and confusing naming conventions in Neutron (LB is v1 API and LBaaS for v2 API) the appropriate code is explicitly marked with \u0027v1\u0027 since this only implements the API v1 benchmarking.","commit_id":"c3471d3c713ae5a05e188b579d9b0edc5f56fb6b"},{"author":{"_account_id":14884,"name":"Kiran Ranganath","email":"kiran7193@gmail.com","username":"kiran"},"change_message_id":"3201b6005695189d9cbefb776296d71c38a1a74b","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add Neutron Loadbalancer(v1) create and list pool"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Enable benchmarking of neutron loadbalancer v1 pool-create and pool-list."},{"line_number":10,"context_line":"LBaaS v1 uses path \"lb/pools\" and LBaaS v2 \"lbaas/pools\" thus"},{"line_number":11,"context_line":"neutron differentiates v1 pools and v2 pools by lb and lbaas respectively."},{"line_number":12,"context_line":"Using the same convention in rally scenarios does not seem good, hence"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":33,"id":"1af86dd1_6f6a9c1c","line":9,"in_reply_to":"3afb71cf_2bedbaef","updated":"2015-06-12 03:28:09.000000000","message":"Thanks.","commit_id":"c3471d3c713ae5a05e188b579d9b0edc5f56fb6b"},{"author":{"_account_id":14884,"name":"Kiran Ranganath","email":"kiran7193@gmail.com","username":"kiran"},"change_message_id":"c44801ab6e1cb19b09bd9b877800de3ec3fb3489","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add Neutron Loadbalancer(v1) create and list pool"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Enable benchmarking of neutron loadbalancer v1 pool-create and pool-list."},{"line_number":10,"context_line":"LBaaS v1 uses path \"lb/pools\" and LBaaS v2 \"lbaas/pools\" thus"},{"line_number":11,"context_line":"neutron differentiates v1 pools and v2 pools by lb and lbaas respectively."},{"line_number":12,"context_line":"Using the same convention in rally scenarios does not seem good, hence"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":33,"id":"3afb71cf_0b4c3e75","line":9,"in_reply_to":"3afb71cf_b3336262","updated":"2015-06-11 16:16:55.000000000","message":"Please suggest a simple commit message relevant to this patch-set. :)","commit_id":"c3471d3c713ae5a05e188b579d9b0edc5f56fb6b"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"66dd36d9c4de5fe8418b233fce961062dea73fdc","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add Neutron Loadbalancer v1 create and list pool"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Enable benchmarking of the Neutron LoadBalancer v1 pool-create and pool-list APIs. Due to the different API scheme and confusing naming conventions in Neutron (LB is v1 API and LBaaS for v2 API) the appropriate code is explicitly marked with \u0027v1\u0027 since this only implements the API v1 benchmarking."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: If51f6286be49724c0bc4ae343815704f01153e97"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":34,"id":"1af86dd1_162c5d49","line":9,"updated":"2015-06-12 07:11:43.000000000","message":"Too long lineeeee","commit_id":"79ecb54a39a1282e754bbe472e65b434f9dca140"}],"rally-jobs/rally-neutron.yaml":[{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"eabb8358b034e41e8e67083212a5afaa95dc8ce5","unresolved":false,"context_lines":[{"line_number":150,"context_line":"            pool: -1"},{"line_number":151,"context_line":"      sla:"},{"line_number":152,"context_line":"        failure_rate:"},{"line_number":153,"context_line":"          max: 20"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"  NeutronNetworks.create_and_update_networks:"},{"line_number":156,"context_line":"    -"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"7a016987_667531c9","line":153,"updated":"2015-05-25 13:08:51.000000000","message":"So if we have 20 failed iterations this will be OK? Probably we should have `0\u0027 here","commit_id":"8dcbd1073c537be28a3775f2f3fdb161f2e58110"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"1f89b8070fd2057412f5ed1f89cbaaa8057a99fc","unresolved":false,"context_lines":[{"line_number":133,"context_line":"    -"},{"line_number":134,"context_line":"      args:"},{"line_number":135,"context_line":"        pool_create_args: {}"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"      runner:"},{"line_number":138,"context_line":"        type: \"constant\""},{"line_number":139,"context_line":"        times: 40"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"7a016987_fe77faff","line":136,"updated":"2015-05-28 10:01:29.000000000","message":"Lets delete tis line","commit_id":"559b3c927072a0d0ac328464052732bc4216b5d5"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"1f89b8070fd2057412f5ed1f89cbaaa8057a99fc","unresolved":false,"context_lines":[{"line_number":136,"context_line":""},{"line_number":137,"context_line":"      runner:"},{"line_number":138,"context_line":"        type: \"constant\""},{"line_number":139,"context_line":"        times: 40"},{"line_number":140,"context_line":"        concurrency: 10"},{"line_number":141,"context_line":"      context:"},{"line_number":142,"context_line":"        users:"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"7a016987_4023c8a7","line":139,"updated":"2015-05-28 10:01:29.000000000","message":"Lets reduce number of times to 20 for example. Its take a lot of time in gate.","commit_id":"559b3c927072a0d0ac328464052732bc4216b5d5"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"cb1ee7bfcb69d61abde8c95a9fe3665adf7aea7e","unresolved":false,"context_lines":[{"line_number":91,"context_line":"        failure_rate:"},{"line_number":92,"context_line":"          max: 20"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"  NeutronLoadbalancerv1.create_and_list_v1_pools:"},{"line_number":95,"context_line":"    -"},{"line_number":96,"context_line":"      args:"},{"line_number":97,"context_line":"        pool_create_args: {}"}],"source_content_type":"text/x-yaml","patch_set":30,"id":"3afb71cf_bc7d806e","line":94,"updated":"2015-06-11 10:56:35.000000000","message":"Even if including version number into class/method name is normal approach (however I\u0027m in doubt about that), that looks wrong to add version number to both.\n\nAdd version number to class name only.\nAlso, use CamelCase correctly:\n\n NeutronLoadBalancerV1.create_and_list_pools","commit_id":"2ed5821bbe3ca1515b56587d0f1bf4aec11fb903"},{"author":{"_account_id":8576,"name":"Yair Fried","email":"yfried@redhat.com","username":"yfried"},"change_message_id":"35e24995b541ef499e20dff35cddf63509fe2c0a","unresolved":false,"context_lines":[{"line_number":91,"context_line":"        failure_rate:"},{"line_number":92,"context_line":"          max: 20"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"  NeutronLoadbalancerv1.create_and_list_v1_pools:"},{"line_number":95,"context_line":"    -"},{"line_number":96,"context_line":"      args:"},{"line_number":97,"context_line":"        pool_create_args: {}"}],"source_content_type":"text/x-yaml","patch_set":30,"id":"3afb71cf_4f1c9069","line":94,"in_reply_to":"3afb71cf_bc7d806e","updated":"2015-06-11 11:30:29.000000000","message":"I agree. if the class has the version number, no need to rename the methods as well","commit_id":"2ed5821bbe3ca1515b56587d0f1bf4aec11fb903"}],"rally/benchmark/scenarios/neutron/loadbalancer.py":[{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"c19c509e9e9ad147cc3e7aabe5ead3bf1cb961f1","unresolved":false,"context_lines":[{"line_number":27,"context_line":"    @validation.required_openstack(users\u003dTrue)"},{"line_number":28,"context_line":"    @base.scenario(context\u003d{\"cleanup\": [\"neutron\"]})"},{"line_number":29,"context_line":"    def create_and_list_pools(self,"},{"line_number":30,"context_line":"                              network_create_args\u003d{},"},{"line_number":31,"context_line":"                              subnet_create_args\u003d{},"},{"line_number":32,"context_line":"                              pool_create_args\u003d{},"},{"line_number":33,"context_line":"                              subnet_cidr_start\u003d\"10.0.0.0/24\","}],"source_content_type":"text/x-python","patch_set":3,"id":"7a016987_8b39cda6","line":30,"updated":"2015-05-19 09:42:43.000000000","message":"network_create_args\u003dNone\n\nDo not use mutable types as defaults","commit_id":"fe146f75b0a3147ae03a53e05b6b7573fd74fc5b"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"c19c509e9e9ad147cc3e7aabe5ead3bf1cb961f1","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    @base.scenario(context\u003d{\"cleanup\": [\"neutron\"]})"},{"line_number":29,"context_line":"    def create_and_list_pools(self,"},{"line_number":30,"context_line":"                              network_create_args\u003d{},"},{"line_number":31,"context_line":"                              subnet_create_args\u003d{},"},{"line_number":32,"context_line":"                              pool_create_args\u003d{},"},{"line_number":33,"context_line":"                              subnet_cidr_start\u003d\"10.0.0.0/24\","},{"line_number":34,"context_line":"                              subnets_per_network\u003d1):"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a016987_6b3e918d","line":31,"updated":"2015-05-19 09:42:43.000000000","message":"ditto","commit_id":"fe146f75b0a3147ae03a53e05b6b7573fd74fc5b"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"c19c509e9e9ad147cc3e7aabe5ead3bf1cb961f1","unresolved":false,"context_lines":[{"line_number":29,"context_line":"    def create_and_list_pools(self,"},{"line_number":30,"context_line":"                              network_create_args\u003d{},"},{"line_number":31,"context_line":"                              subnet_create_args\u003d{},"},{"line_number":32,"context_line":"                              pool_create_args\u003d{},"},{"line_number":33,"context_line":"                              subnet_cidr_start\u003d\"10.0.0.0/24\","},{"line_number":34,"context_line":"                              subnets_per_network\u003d1):"},{"line_number":35,"context_line":"        \"\"\"Create a pool and then list all pools."}],"source_content_type":"text/x-python","patch_set":3,"id":"7a016987_4b3f5587","line":32,"updated":"2015-05-19 09:42:43.000000000","message":"ditto","commit_id":"fe146f75b0a3147ae03a53e05b6b7573fd74fc5b"}],"rally/benchmark/scenarios/neutron/utils.py":[{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"b6d79e10e6d5eb40632e57280f0bcb7c25fe9c92","unresolved":false,"context_lines":[{"line_number":290,"context_line":"        self.clients(\"neutron\").remove_interface_router("},{"line_number":291,"context_line":"             router[\"id\"], {\"subnet_id\": subnet[\"id\"]})"},{"line_number":292,"context_line":""},{"line_number":293,"context_line":"    @base.atomic_action_timer(\"create_pools\")"},{"line_number":294,"context_line":"    def _create_pools(self, network_create_args\u003d{},"},{"line_number":295,"context_line":"                      subnet_create_args\u003d{},"},{"line_number":296,"context_line":"                      pool_create_args\u003d{},"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a016987_a2bbd9c3","line":293,"updated":"2015-05-15 08:11:37.000000000","message":"Look. You have create atomic action \"create_pools\" but in this action you have created networks and subnets its a lot of time. There is exist context for that. You can create network and subnets in context","commit_id":"fe146f75b0a3147ae03a53e05b6b7573fd74fc5b"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"d902cc2de01c0269b63e96c79bdfb52049b67a96","unresolved":false,"context_lines":[{"line_number":290,"context_line":"        self.clients(\"neutron\").remove_interface_router("},{"line_number":291,"context_line":"             router[\"id\"], {\"subnet_id\": subnet[\"id\"]})"},{"line_number":292,"context_line":""},{"line_number":293,"context_line":"    @base.atomic_action_timer(\"create_pools\")"},{"line_number":294,"context_line":"    def _create_pools(self, network_create_args\u003d{},"},{"line_number":295,"context_line":"                      subnet_create_args\u003d{},"},{"line_number":296,"context_line":"                      pool_create_args\u003d{},"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a016987_30a2484c","line":293,"in_reply_to":"7a016987_a2bbd9c3","updated":"2015-05-19 09:31:50.000000000","message":"Add prefix `neutron\u0027: \"neutron.create_pools\"","commit_id":"fe146f75b0a3147ae03a53e05b6b7573fd74fc5b"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"d902cc2de01c0269b63e96c79bdfb52049b67a96","unresolved":false,"context_lines":[{"line_number":291,"context_line":"             router[\"id\"], {\"subnet_id\": subnet[\"id\"]})"},{"line_number":292,"context_line":""},{"line_number":293,"context_line":"    @base.atomic_action_timer(\"create_pools\")"},{"line_number":294,"context_line":"    def _create_pools(self, network_create_args\u003d{},"},{"line_number":295,"context_line":"                      subnet_create_args\u003d{},"},{"line_number":296,"context_line":"                      pool_create_args\u003d{},"},{"line_number":297,"context_line":"                      subnets_per_network\u003d1,"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a016987_f0539069","line":294,"updated":"2015-05-19 09:31:50.000000000","message":"You definitely should NOT create network and subnets in this method, because you have specified atomic action here, so this atomic action must measure only pools creating.\n\nSo you can create network and subnets 1) in scenario (not in utils), or 2) use network context for that\n\nIf you expect networks and subnets created by context, you should add validation that context is given in task file:\n\nhttps://github.com/openstack/rally/blob/master/rally/benchmark/scenarios/nova/servers.py#L608\n\nIf you decide to create network and subnets in scenario, then use our new network wrapper (not methods from this utils), here is how that is done in network context:\n\nhttps://github.com/openstack/rally/blob/master/rally/benchmark/context/network.py#L67-L69","commit_id":"fe146f75b0a3147ae03a53e05b6b7573fd74fc5b"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"d902cc2de01c0269b63e96c79bdfb52049b67a96","unresolved":false,"context_lines":[{"line_number":321,"context_line":"                self._generate_random_name(\"rally_pool_\"))"},{"line_number":322,"context_line":"            pool_create_args.setdefault(\"subnet_id\","},{"line_number":323,"context_line":"                                        subnet[\"subnet\"][\"id\"])"},{"line_number":324,"context_line":"            pool \u003d self.clients(\"neutron\").create_pool("},{"line_number":325,"context_line":"                {\"pool\": pool_create_args})"},{"line_number":326,"context_line":"            pools.append(pool)"},{"line_number":327,"context_line":"        return network, subnets, pools"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a016987_503944f1","line":324,"updated":"2015-05-19 09:31:50.000000000","message":"This should be moved to network wrapper.\n\nThis approach is more flexible, so we are not bound to scenario code and will be able, for example, to create pools in some context in future","commit_id":"fe146f75b0a3147ae03a53e05b6b7573fd74fc5b"}],"rally/plugins/openstack/context/cleanup/resources.py":[{"author":{"_account_id":8576,"name":"Yair Fried","email":"yfried@redhat.com","username":"yfried"},"change_message_id":"35e24995b541ef499e20dff35cddf63509fe2c0a","unresolved":false,"context_lines":[{"line_number":191,"context_line":""},{"line_number":192,"context_line":"@base.resource(\"neutron\", \"pool\", order\u003dnext(_neutron_order),"},{"line_number":193,"context_line":"               tenant_resource\u003dTrue)"},{"line_number":194,"context_line":"class Neutronv1Pool(NeutronMixin):"},{"line_number":195,"context_line":"    pass"},{"line_number":196,"context_line":""},{"line_number":197,"context_line":""}],"source_content_type":"text/x-python","patch_set":30,"id":"3afb71cf_4f3370f6","line":194,"updated":"2015-06-11 11:30:29.000000000","message":"CammelCase please.  \n\n  NeutronV1Pool","commit_id":"2ed5821bbe3ca1515b56587d0f1bf4aec11fb903"}],"rally/plugins/openstack/scenarios/neutron/loadbalancer.py":[{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"eabb8358b034e41e8e67083212a5afaa95dc8ce5","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"class NeutronLoadbalancer(utils.NeutronScenario):"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    \"\"\"Benchmark scenarios for Neutron Loadbalancer.\"\"\""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    @validation.required_openstack(users\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a016987_061b1d82","line":26,"updated":"2015-05-25 13:08:51.000000000","message":"Remove this empty line (ref. PEP257)","commit_id":"8dcbd1073c537be28a3775f2f3fdb161f2e58110"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"eabb8358b034e41e8e67083212a5afaa95dc8ce5","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    \"\"\"Benchmark scenarios for Neutron Loadbalancer.\"\"\""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    @validation.required_openstack(users\u003dTrue)"},{"line_number":30,"context_line":"    @validation.required_contexts(\"network\")"},{"line_number":31,"context_line":"    @base.scenario(context\u003d{\"cleanup\": [\"neutron\"]})"},{"line_number":32,"context_line":"    def create_and_list_pools(self,"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a016987_414a1f56","line":29,"updated":"2015-05-25 13:08:51.000000000","message":"Add this validator, because this scenario works only for neutron, so you must validate that neutron is available before starting benchmarking:\n\n @validation.required_services(consts.Service.NEUTRON)","commit_id":"8dcbd1073c537be28a3775f2f3fdb161f2e58110"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"eabb8358b034e41e8e67083212a5afaa95dc8ce5","unresolved":false,"context_lines":[{"line_number":27,"context_line":"    \"\"\"Benchmark scenarios for Neutron Loadbalancer.\"\"\""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    @validation.required_openstack(users\u003dTrue)"},{"line_number":30,"context_line":"    @validation.required_contexts(\"network\")"},{"line_number":31,"context_line":"    @base.scenario(context\u003d{\"cleanup\": [\"neutron\"]})"},{"line_number":32,"context_line":"    def create_and_list_pools(self,"},{"line_number":33,"context_line":"                              pool_create_args\u003dNone,"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a016987_215cc317","line":30,"updated":"2015-05-25 13:08:51.000000000","message":"As I mentioned below, this context seems to be not used (since you create network and subnets in this scenario) - so maybe remove this validator?","commit_id":"8dcbd1073c537be28a3775f2f3fdb161f2e58110"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"eabb8358b034e41e8e67083212a5afaa95dc8ce5","unresolved":false,"context_lines":[{"line_number":43,"context_line":"        :param kwargs: Optional additional arguments for network,subnet and"},{"line_number":44,"context_line":"        pool creation creation"},{"line_number":45,"context_line":"        \"\"\""},{"line_number":46,"context_line":"        network_resources \u003d network_wrapper.wrap(self.clients).create_network("},{"line_number":47,"context_line":"            tenant_id\u003dself.context[\"tenant\"][\"id\"], subnets_num\u003d1)"},{"line_number":48,"context_line":"        for subnet in network_resources[\"subnets\"]:"},{"line_number":49,"context_line":"            self._create_pools(pool_create_args or {},"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a016987_61387bd3","line":46,"updated":"2015-05-25 13:08:51.000000000","message":"You already require network context above, by `@validation.required_contexts(\"network\")\u0027 - so you already have network created by context. If you create network+subnets by scenario, then you do not need network context","commit_id":"8dcbd1073c537be28a3775f2f3fdb161f2e58110"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"57965fd3133880f2b88d70876dc7e9fbde83aff5","unresolved":false,"context_lines":[{"line_number":21,"context_line":"from rally.plugins.openstack.scenarios.neutron import utils"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"class NeutronLoadbalancer(utils.NeutronScenario):"},{"line_number":25,"context_line":"    \"\"\"Benchmark scenarios for Neutron Loadbalancer.\"\"\""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    @validation.required_services(consts.Service.NEUTRON)"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a016987_63198a22","line":24,"updated":"2015-05-26 10:34:31.000000000","message":"s/NeutronLoadbalancer/NeutronLoadBalancer/","commit_id":"935d9c5595a07367e1edec9a8209a1a31adf56e0"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"58c1e2a403df9151874a84b59570c70f2426bde1","unresolved":false,"context_lines":[{"line_number":27,"context_line":"    @validation.required_services(consts.Service.NEUTRON)"},{"line_number":28,"context_line":"    @validation.required_openstack(users\u003dTrue)"},{"line_number":29,"context_line":"    @validation.required_contexts(\"network\")"},{"line_number":30,"context_line":"    def create_and_list_pools(self,"},{"line_number":31,"context_line":"                              pool_create_args\u003dNone,"},{"line_number":32,"context_line":"                              **kwargs):"},{"line_number":33,"context_line":"        \"\"\"Create a pool and then list all pools."}],"source_content_type":"text/x-python","patch_set":6,"id":"7a016987_c9cdffb8","line":30,"updated":"2015-05-26 11:45:17.000000000","message":"You have tests broken because `base.scenario\u0027 decorator is missed - this decorator is important since it actually transforms method to scenario\n\nExample: https://github.com/openstack/rally/blob/master/rally/plugins/openstack/scenarios/neutron/network.py#L27","commit_id":"935d9c5595a07367e1edec9a8209a1a31adf56e0"},{"author":{"_account_id":13609,"name":"Pavel Boldin","email":"pboldin@mirantis.com","username":"pboldin"},"change_message_id":"4349cbc898f326bf9c53eb615f4664bc8f2fb182","unresolved":false,"context_lines":[{"line_number":40,"context_line":"        for every subnet and then lists pools."},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"        :param pool_create_args: dict, POST /v2.0/pools request options"},{"line_number":43,"context_line":"        :param kwargs: Optional additional arguments for network,subnet and"},{"line_number":44,"context_line":"        pool creation creation"},{"line_number":45,"context_line":"        \"\"\""},{"line_number":46,"context_line":"        for subnet in self.context[\"subnets\"]:"}],"source_content_type":"text/x-python","patch_set":7,"id":"7a016987_89cdc75f","line":43,"updated":"2015-05-26 12:09:09.000000000","message":"space after a comma.","commit_id":"44976446de430238bb94b0adfca36061b7fe0f6e"},{"author":{"_account_id":13609,"name":"Pavel Boldin","email":"pboldin@mirantis.com","username":"pboldin"},"change_message_id":"4349cbc898f326bf9c53eb615f4664bc8f2fb182","unresolved":false,"context_lines":[{"line_number":43,"context_line":"        :param kwargs: Optional additional arguments for network,subnet and"},{"line_number":44,"context_line":"        pool creation creation"},{"line_number":45,"context_line":"        \"\"\""},{"line_number":46,"context_line":"        for subnet in self.context[\"subnets\"]:"},{"line_number":47,"context_line":"            self._create_pools(pool_create_args or {},"},{"line_number":48,"context_line":"                               subnet)"},{"line_number":49,"context_line":"        self._list_pools()"}],"source_content_type":"text/x-python","patch_set":7,"id":"7a016987_49d7cfed","line":46,"updated":"2015-05-26 12:09:09.000000000","message":"Probably use `broker\u0027 here.","commit_id":"44976446de430238bb94b0adfca36061b7fe0f6e"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"a46b1c99d2682d9dd37d90a39ba326e65d9418cf","unresolved":false,"context_lines":[{"line_number":43,"context_line":"        :param kwargs: Optional additional arguments for network, subnet and"},{"line_number":44,"context_line":"        pool creation creation"},{"line_number":45,"context_line":"        \"\"\""},{"line_number":46,"context_line":"        for subnet in self.context[\"subnets\"]:"},{"line_number":47,"context_line":"            self._create_pools(pool_create_args or {}, subnet)"},{"line_number":48,"context_line":"        self._list_pools()"}],"source_content_type":"text/x-python","patch_set":8,"id":"7a016987_d0f11897","line":46,"updated":"2015-05-26 16:33:21.000000000","message":"Top level context does not have \"subnets\".\n\nTry this:\n\n\"\"\"\n\n for net in self.context.get(\"tenant\", {}).get(\"networks\", []):\n\n     for subnet in net[\"subnets\"]:\n\n         self._create_pools(pool_create_args or {}, subnet)\n\n self._list_pools()\n\n\"\"\"","commit_id":"d2e45893bf6c135eaf0058ad237a7e499878b6a6"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"66dbf97ea7bd67994a5995c267379af5373df55e","unresolved":false,"context_lines":[{"line_number":32,"context_line":"    def create_and_list_pools(self,"},{"line_number":33,"context_line":"                              pool_create_args\u003dNone,"},{"line_number":34,"context_line":"                              **kwargs):"},{"line_number":35,"context_line":"        \"\"\"Create a pool and then list all pools."},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"        Measure the \"neutron lb-pool-list\" command performance."},{"line_number":38,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"7a016987_ae3622b2","line":35,"updated":"2015-05-27 08:47:37.000000000","message":"This is not correct statement. You create here one pool for each subnet, not just one pool.\n\nAlso, you create one pool for each subnet in EACH run of scenario. It means, that if you run this scenario 100 times and have 5 networks, you will have 500 pools. Is it intended result?","commit_id":"3c40938a4d03ee6c1087992e6e11467a381f10c1"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"66dbf97ea7bd67994a5995c267379af5373df55e","unresolved":false,"context_lines":[{"line_number":36,"context_line":""},{"line_number":37,"context_line":"        Measure the \"neutron lb-pool-list\" command performance."},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"        The scenario creates a network, a given number of subnets, a pool"},{"line_number":40,"context_line":"        for every subnet and then lists pools."},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"        :param pool_create_args: dict, POST /v2.0/pools request options"}],"source_content_type":"text/x-python","patch_set":10,"id":"7a016987_ee02dab3","line":39,"updated":"2015-05-27 08:47:37.000000000","message":"Scenario does not create network. Context does it. Scenario creates pools.","commit_id":"3c40938a4d03ee6c1087992e6e11467a381f10c1"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"1f89b8070fd2057412f5ed1f89cbaaa8057a99fc","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2015: Maple Labs"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Author: Kiran Ranganath \u003ckiran.ranganath@maplelabs.com\u003e"},{"line_number":4,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":12,"id":"7a016987_6035a444","line":1,"updated":"2015-05-28 10:01:29.000000000","message":"As I know you need to write other license. Like in all other ours files.","commit_id":"559b3c927072a0d0ac328464052732bc4216b5d5"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"98a70938e946ec736afc9edf8b1912cdf11be047","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2015: Maple Labs"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Author: Kiran Ranganath \u003ckiran.ranganath@maplelabs.com\u003e"},{"line_number":4,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":12,"id":"7a016987_83d30a5f","line":1,"in_reply_to":"7a016987_6035a444","updated":"2015-05-28 10:06:00.000000000","message":"It is the same - Apache v2 license.","commit_id":"559b3c927072a0d0ac328464052732bc4216b5d5"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"30ebad2608dc9f5bf17741bea096ae610c92cec0","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    @validation.required_services(consts.Service.NEUTRON)"},{"line_number":29,"context_line":"    @validation.required_openstack(users\u003dTrue)"},{"line_number":30,"context_line":"    @validation.required_contexts(\"network\")"},{"line_number":31,"context_line":"    @base.scenario()"},{"line_number":32,"context_line":"    def create_and_list_pools(self,"},{"line_number":33,"context_line":"                              pool_create_args\u003dNone,"},{"line_number":34,"context_line":"                              **kwargs):"}],"source_content_type":"text/x-python","patch_set":12,"id":"7a016987_00915052","line":31,"updated":"2015-05-28 10:23:56.000000000","message":"this scenario creates pools, but does not delete them, so cleanup is required:\n\n @base.scenario(context\u003d{\"cleanup\": [\"neutron\"])","commit_id":"559b3c927072a0d0ac328464052732bc4216b5d5"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"30ebad2608dc9f5bf17741bea096ae610c92cec0","unresolved":false,"context_lines":[{"line_number":29,"context_line":"    @validation.required_openstack(users\u003dTrue)"},{"line_number":30,"context_line":"    @validation.required_contexts(\"network\")"},{"line_number":31,"context_line":"    @base.scenario()"},{"line_number":32,"context_line":"    def create_and_list_pools(self,"},{"line_number":33,"context_line":"                              pool_create_args\u003dNone,"},{"line_number":34,"context_line":"                              **kwargs):"},{"line_number":35,"context_line":"        \"\"\"Create a pool for every subnet created in the context"}],"source_content_type":"text/x-python","patch_set":12,"id":"7a016987_c071f845","line":32,"updated":"2015-05-28 10:23:56.000000000","message":"If placed on single line, method definition will take 69 chars, so do not need to break line for each argument","commit_id":"559b3c927072a0d0ac328464052732bc4216b5d5"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"30ebad2608dc9f5bf17741bea096ae610c92cec0","unresolved":false,"context_lines":[{"line_number":32,"context_line":"    def create_and_list_pools(self,"},{"line_number":33,"context_line":"                              pool_create_args\u003dNone,"},{"line_number":34,"context_line":"                              **kwargs):"},{"line_number":35,"context_line":"        \"\"\"Create a pool for every subnet created in the context"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"        and then list pools."},{"line_number":38,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"7a016987_c01b38c9","line":35,"updated":"2015-05-28 10:23:56.000000000","message":"PEP257 is widely used in Rally, so please follow its requirement - first line in docstring must be short description ended with a period.\n\nhttps://www.python.org/dev/peps/pep-0257/","commit_id":"559b3c927072a0d0ac328464052732bc4216b5d5"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"30ebad2608dc9f5bf17741bea096ae610c92cec0","unresolved":false,"context_lines":[{"line_number":39,"context_line":"        Measure the \"neutron lb-pool-list\" command performance."},{"line_number":40,"context_line":"        The scenario creates a pool for every subnet and then lists pools."},{"line_number":41,"context_line":"        :param pool_create_args: dict, POST /v2.0/pools request options"},{"line_number":42,"context_line":"        :param kwargs: Optional additional arguments for network and subnet"},{"line_number":43,"context_line":"        creation"},{"line_number":44,"context_line":"        \"\"\""},{"line_number":45,"context_line":"        for net in self.context.get(\"tenant\", {}).get(\"networks\", []):"}],"source_content_type":"text/x-python","patch_set":12,"id":"7a016987_e093d4f8","line":42,"updated":"2015-05-28 10:23:56.000000000","message":"I do not see where kwargs are used","commit_id":"559b3c927072a0d0ac328464052732bc4216b5d5"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"30ebad2608dc9f5bf17741bea096ae610c92cec0","unresolved":false,"context_lines":[{"line_number":43,"context_line":"        creation"},{"line_number":44,"context_line":"        \"\"\""},{"line_number":45,"context_line":"        for net in self.context.get(\"tenant\", {}).get(\"networks\", []):"},{"line_number":46,"context_line":"            for subnet in net[\"subnets\"]:"},{"line_number":47,"context_line":"                self._create_pools(pool_create_args or {}, subnet)"},{"line_number":48,"context_line":"        self._list_pools()"}],"source_content_type":"text/x-python","patch_set":12,"id":"7a016987_63e80e7d","line":46,"updated":"2015-05-28 10:23:56.000000000","message":"It is better to rename subnet -\u003e subnet_id (more explicit name)","commit_id":"559b3c927072a0d0ac328464052732bc4216b5d5"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"3f359d302aa8d7ca34ef9257927ee662fff3fc98","unresolved":false,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":"        Measure the \"neutron lb-pool-list\" command performance."},{"line_number":30,"context_line":"        The scenario creates a pool for every subnet and then lists pools."},{"line_number":31,"context_line":"        :param pool_create_args: dict, POST /v2.0/pools request options"},{"line_number":32,"context_line":"        \"\"\""},{"line_number":33,"context_line":"        for net in self.context.get(\"tenant\", {}).get(\"networks\", []):"},{"line_number":34,"context_line":"            for subnet_id in net[\"subnets\"]:"}],"source_content_type":"text/x-python","patch_set":22,"id":"5afe65bd_95b45435","line":31,"updated":"2015-06-04 07:10:32.000000000","message":"nitpick: please add a new line before \":param pool...\"","commit_id":"7441bacce6640d40c1b6f992cb04f8a80577a81a"}],"rally/plugins/openstack/scenarios/neutron/loadbalancer_v1.py":[{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"cb1ee7bfcb69d61abde8c95a9fe3665adf7aea7e","unresolved":false,"context_lines":[{"line_number":16,"context_line":"from rally.plugins.openstack.scenarios.neutron import utils"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"class NeutronLoadbalancerv1(utils.NeutronScenario):"},{"line_number":20,"context_line":"    \"\"\"Benchmark scenarios for Neutron Loadbalancer v1.\"\"\""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"    @validation.restricted_parameters(\"subnet_id\", subdict\u003d\"pool_create_args\")"}],"source_content_type":"text/x-python","patch_set":30,"id":"3afb71cf_dcf15c02","line":19,"updated":"2015-06-11 10:56:35.000000000","message":"NeutronLoadBalancerV1, or even just NeutronLoadBalancer (without V1)","commit_id":"2ed5821bbe3ca1515b56587d0f1bf4aec11fb903"},{"author":{"_account_id":8576,"name":"Yair Fried","email":"yfried@redhat.com","username":"yfried"},"change_message_id":"35e24995b541ef499e20dff35cddf63509fe2c0a","unresolved":false,"context_lines":[{"line_number":16,"context_line":"from rally.plugins.openstack.scenarios.neutron import utils"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"class NeutronLoadbalancerv1(utils.NeutronScenario):"},{"line_number":20,"context_line":"    \"\"\"Benchmark scenarios for Neutron Loadbalancer v1.\"\"\""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"    @validation.restricted_parameters(\"subnet_id\", subdict\u003d\"pool_create_args\")"}],"source_content_type":"text/x-python","patch_set":30,"id":"3afb71cf_0f77b8a0","line":19,"in_reply_to":"3afb71cf_dcf15c02","updated":"2015-06-11 11:30:29.000000000","message":"@Alexander,\nmust keep the V1","commit_id":"2ed5821bbe3ca1515b56587d0f1bf4aec11fb903"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"cb1ee7bfcb69d61abde8c95a9fe3665adf7aea7e","unresolved":false,"context_lines":[{"line_number":24,"context_line":"    @validation.required_openstack(users\u003dTrue)"},{"line_number":25,"context_line":"    @validation.required_contexts(\"network\")"},{"line_number":26,"context_line":"    @base.scenario(context\u003d{\"cleanup\": [\"neutron\"]})"},{"line_number":27,"context_line":"    def create_and_list_v1_pools(self, pool_create_args\u003dNone):"},{"line_number":28,"context_line":"        \"\"\"Create a pool(LBaaS v1) and then list pools(LBaaS v1)."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"        Measure the \"neutron lb-pool-list\" command performance."}],"source_content_type":"text/x-python","patch_set":30,"id":"3afb71cf_1cec9428","line":27,"updated":"2015-06-11 10:56:35.000000000","message":"create_and_list_pools","commit_id":"2ed5821bbe3ca1515b56587d0f1bf4aec11fb903"},{"author":{"_account_id":8576,"name":"Yair Fried","email":"yfried@redhat.com","username":"yfried"},"change_message_id":"35e24995b541ef499e20dff35cddf63509fe2c0a","unresolved":false,"context_lines":[{"line_number":24,"context_line":"    @validation.required_openstack(users\u003dTrue)"},{"line_number":25,"context_line":"    @validation.required_contexts(\"network\")"},{"line_number":26,"context_line":"    @base.scenario(context\u003d{\"cleanup\": [\"neutron\"]})"},{"line_number":27,"context_line":"    def create_and_list_v1_pools(self, pool_create_args\u003dNone):"},{"line_number":28,"context_line":"        \"\"\"Create a pool(LBaaS v1) and then list pools(LBaaS v1)."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"        Measure the \"neutron lb-pool-list\" command performance."}],"source_content_type":"text/x-python","patch_set":30,"id":"3afb71cf_af6f84c2","line":27,"in_reply_to":"3afb71cf_1cec9428","updated":"2015-06-11 11:30:29.000000000","message":"you can drop the \"v1\" from the method name, since it\u0027s in class name","commit_id":"2ed5821bbe3ca1515b56587d0f1bf4aec11fb903"},{"author":{"_account_id":8576,"name":"Yair Fried","email":"yfried@redhat.com","username":"yfried"},"change_message_id":"35e24995b541ef499e20dff35cddf63509fe2c0a","unresolved":false,"context_lines":[{"line_number":34,"context_line":"        \"\"\""},{"line_number":35,"context_line":"        for net in self.context.get(\"tenant\", {}).get(\"networks\", []):"},{"line_number":36,"context_line":"            for subnet_id in net[\"subnets\"]:"},{"line_number":37,"context_line":"                self._create_v1_pool(pool_create_args or {}, subnet_id)"},{"line_number":38,"context_line":"        self._list_v1_pools()"}],"source_content_type":"text/x-python","patch_set":30,"id":"3afb71cf_cfa3e0fe","line":37,"updated":"2015-06-11 11:30:29.000000000","message":"_create_v1_pool(subnet_id\u003dsubnet_id, **pool_create_args)","commit_id":"2ed5821bbe3ca1515b56587d0f1bf4aec11fb903"}],"rally/plugins/openstack/scenarios/neutron/utils.py":[{"author":{"_account_id":8576,"name":"Yair Fried","email":"yfried@redhat.com","username":"yfried"},"change_message_id":"ed7dcea49ac5b22324c1f6be0422754a87a70ac4","unresolved":false,"context_lines":[{"line_number":295,"context_line":"                      subnet):"},{"line_number":296,"context_line":"        \"\"\"Create pools"},{"line_number":297,"context_line":""},{"line_number":298,"context_line":"        :parm subnet_create_args: dict, POST /v2.0/pools request options"},{"line_number":299,"context_line":"        :parm subnets: list, list of subnets"},{"line_number":300,"context_line":"        :returns: list of pools"},{"line_number":301,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":5,"id":"7a016987_0a7a0988","line":298,"updated":"2015-05-25 06:22:07.000000000","message":"shouldn\u0027t this be \"pool_create_args\"?","commit_id":"8dcbd1073c537be28a3775f2f3fdb161f2e58110"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"eabb8358b034e41e8e67083212a5afaa95dc8ce5","unresolved":false,"context_lines":[{"line_number":296,"context_line":"        \"\"\"Create pools"},{"line_number":297,"context_line":""},{"line_number":298,"context_line":"        :parm subnet_create_args: dict, POST /v2.0/pools request options"},{"line_number":299,"context_line":"        :parm subnets: list, list of subnets"},{"line_number":300,"context_line":"        :returns: list of pools"},{"line_number":301,"context_line":"        \"\"\""},{"line_number":302,"context_line":"        pool_create_args.setdefault("}],"source_content_type":"text/x-python","patch_set":5,"id":"7a016987_6194fb89","line":299,"updated":"2015-05-25 13:08:51.000000000","message":":param subnet: str neutron subnet id","commit_id":"8dcbd1073c537be28a3775f2f3fdb161f2e58110"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"eabb8358b034e41e8e67083212a5afaa95dc8ce5","unresolved":false,"context_lines":[{"line_number":307,"context_line":"            \"name\","},{"line_number":308,"context_line":"            self._generate_random_name(\"rally_pool_\"))"},{"line_number":309,"context_line":"        pool_create_args.setdefault(\"subnet_id\","},{"line_number":310,"context_line":"                                    subnet)"},{"line_number":311,"context_line":"        pool \u003d self.clients(\"neutron\").create_pool({\"pool\": pool_create_args})"},{"line_number":312,"context_line":"        return pool"},{"line_number":313,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"7a016987_21eba3dd","line":310,"updated":"2015-05-25 13:08:51.000000000","message":"Why `subnet)\u0027 is on next line - if moved to L309, then this will be 56 symbols long, so no reason to break line","commit_id":"8dcbd1073c537be28a3775f2f3fdb161f2e58110"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"a46b1c99d2682d9dd37d90a39ba326e65d9418cf","unresolved":false,"context_lines":[{"line_number":300,"context_line":"        :returns: obj, neutron lb pool"},{"line_number":301,"context_line":"        \"\"\""},{"line_number":302,"context_line":"        pool_create_args.setdefault("},{"line_number":303,"context_line":"            \"lb_method\", self.LB_METHOD)"},{"line_number":304,"context_line":"        pool_create_args.setdefault("},{"line_number":305,"context_line":"            \"protocol\", self.LB_PROTOCOL)"},{"line_number":306,"context_line":"        pool_create_args.setdefault("}],"source_content_type":"text/x-python","patch_set":8,"id":"7a016987_90c60015","line":303,"updated":"2015-05-26 16:33:21.000000000","message":"Can be in one line. Same below.","commit_id":"d2e45893bf6c135eaf0058ad237a7e499878b6a6"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"30ebad2608dc9f5bf17741bea096ae610c92cec0","unresolved":false,"context_lines":[{"line_number":291,"context_line":"            router[\"id\"], {\"subnet_id\": subnet[\"id\"]})"},{"line_number":292,"context_line":""},{"line_number":293,"context_line":"    @base.atomic_action_timer(\"neutron.create_pools\")"},{"line_number":294,"context_line":"    def _create_pools(self, pool_create_args,"},{"line_number":295,"context_line":"                      subnet):"},{"line_number":296,"context_line":"        \"\"\"Create pools"},{"line_number":297,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"7a016987_23dc56e3","line":294,"updated":"2015-05-28 10:23:56.000000000","message":"Why pools (plural)? I see creation of single pool here","commit_id":"559b3c927072a0d0ac328464052732bc4216b5d5"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"1f89b8070fd2057412f5ed1f89cbaaa8057a99fc","unresolved":false,"context_lines":[{"line_number":292,"context_line":""},{"line_number":293,"context_line":"    @base.atomic_action_timer(\"neutron.create_pools\")"},{"line_number":294,"context_line":"    def _create_pools(self, pool_create_args,"},{"line_number":295,"context_line":"                      subnet):"},{"line_number":296,"context_line":"        \"\"\"Create pools"},{"line_number":297,"context_line":""},{"line_number":298,"context_line":"        :parm pool_create_args: dict, POST /v2.0/pools request options"}],"source_content_type":"text/x-python","patch_set":12,"id":"7a016987_807c20ec","line":295,"updated":"2015-05-28 10:01:29.000000000","message":"write it in one line","commit_id":"559b3c927072a0d0ac328464052732bc4216b5d5"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"30ebad2608dc9f5bf17741bea096ae610c92cec0","unresolved":false,"context_lines":[{"line_number":292,"context_line":""},{"line_number":293,"context_line":"    @base.atomic_action_timer(\"neutron.create_pools\")"},{"line_number":294,"context_line":"    def _create_pools(self, pool_create_args,"},{"line_number":295,"context_line":"                      subnet):"},{"line_number":296,"context_line":"        \"\"\"Create pools"},{"line_number":297,"context_line":""},{"line_number":298,"context_line":"        :parm pool_create_args: dict, POST /v2.0/pools request options"}],"source_content_type":"text/x-python","patch_set":12,"id":"7a016987_2355764f","line":295,"in_reply_to":"7a016987_807c20ec","updated":"2015-05-28 10:23:56.000000000","message":"Agree with Roman, and also please rename subnet -\u003e subnet_id, because this will explicitly define that value is ID","commit_id":"559b3c927072a0d0ac328464052732bc4216b5d5"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"30ebad2608dc9f5bf17741bea096ae610c92cec0","unresolved":false,"context_lines":[{"line_number":296,"context_line":"        \"\"\"Create pools"},{"line_number":297,"context_line":""},{"line_number":298,"context_line":"        :parm pool_create_args: dict, POST /v2.0/pools request options"},{"line_number":299,"context_line":"        :parm subnets: str, neutron subnet-id"},{"line_number":300,"context_line":"        :returns: obj, neutron lb pool"},{"line_number":301,"context_line":"        \"\"\""},{"line_number":302,"context_line":"        pool_create_args.setdefault("}],"source_content_type":"text/x-python","patch_set":12,"id":"7a016987_a3604636","line":299,"updated":"2015-05-28 10:23:56.000000000","message":"s/subnets/subnet_id/","commit_id":"559b3c927072a0d0ac328464052732bc4216b5d5"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"30ebad2608dc9f5bf17741bea096ae610c92cec0","unresolved":false,"context_lines":[{"line_number":299,"context_line":"        :parm subnets: str, neutron subnet-id"},{"line_number":300,"context_line":"        :returns: obj, neutron lb pool"},{"line_number":301,"context_line":"        \"\"\""},{"line_number":302,"context_line":"        pool_create_args.setdefault("},{"line_number":303,"context_line":"            \"lb_method\", self.LB_METHOD)"},{"line_number":304,"context_line":"        pool_create_args.setdefault("},{"line_number":305,"context_line":"            \"protocol\", self.LB_PROTOCOL)"}],"source_content_type":"text/x-python","patch_set":12,"id":"7a016987_2340d6a4","line":302,"updated":"2015-05-28 10:23:56.000000000","message":"Lines 302-303 should take 1 line, since this takes \u003c79 chars","commit_id":"559b3c927072a0d0ac328464052732bc4216b5d5"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"1f89b8070fd2057412f5ed1f89cbaaa8057a99fc","unresolved":false,"context_lines":[{"line_number":302,"context_line":"        pool_create_args.setdefault("},{"line_number":303,"context_line":"            \"lb_method\", self.LB_METHOD)"},{"line_number":304,"context_line":"        pool_create_args.setdefault("},{"line_number":305,"context_line":"            \"protocol\", self.LB_PROTOCOL)"},{"line_number":306,"context_line":"        pool_create_args.setdefault("},{"line_number":307,"context_line":"            \"name\","},{"line_number":308,"context_line":"            self._generate_random_name(\"rally_pool_\"))"}],"source_content_type":"text/x-python","patch_set":12,"id":"7a016987_208a0cc0","line":305,"updated":"2015-05-28 10:01:29.000000000","message":"Why you type this in two lines? Two lines above is smaller then 79 charecters.","commit_id":"559b3c927072a0d0ac328464052732bc4216b5d5"},{"author":{"_account_id":13609,"name":"Pavel Boldin","email":"pboldin@mirantis.com","username":"pboldin"},"change_message_id":"3c249bea40f3374646b9265350901fac173bb3b8","unresolved":false,"context_lines":[{"line_number":303,"context_line":"        pool_create_args.setdefault(\"name\","},{"line_number":304,"context_line":"                                    self._generate_random_name(\"rally_pool_\"))"},{"line_number":305,"context_line":"        pool_create_args.setdefault(\"subnet_id\", subnet_id)"},{"line_number":306,"context_line":"        pool \u003d self.clients(\"neutron\").create_pool({\"pool\": pool_create_args})"},{"line_number":307,"context_line":"        return pool"},{"line_number":308,"context_line":""},{"line_number":309,"context_line":"    @base.atomic_action_timer(\"neutron.list_pools\")"}],"source_content_type":"text/x-python","patch_set":15,"id":"7a016987_0a603b00","line":306,"updated":"2015-05-28 17:40:07.000000000","message":"return self.clients(\"neutron)","commit_id":"61c53bdc5fd03faecd77bc821de4c73858faa275"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"3f359d302aa8d7ca34ef9257927ee662fff3fc98","unresolved":false,"context_lines":[{"line_number":302,"context_line":"        pool_create_args.setdefault(\"protocol\", self.LB_PROTOCOL)"},{"line_number":303,"context_line":"        pool_create_args.setdefault(\"name\","},{"line_number":304,"context_line":"                                    self._generate_random_name(\"rally_pool_\"))"},{"line_number":305,"context_line":"        pool_create_args.setdefault(\"subnet_id\", subnet_id)"},{"line_number":306,"context_line":"        return self.clients(\"neutron\").create_pool({\"pool\": pool_create_args})"},{"line_number":307,"context_line":""},{"line_number":308,"context_line":"    @base.atomic_action_timer(\"neutron.list_pools\")"}],"source_content_type":"text/x-python","patch_set":22,"id":"5afe65bd_759d58bb","line":305,"updated":"2015-06-04 07:10:32.000000000","message":"I prefer to restrict setting \"subnet_id\" value at all via pool_create_args(we have a validator for such things - [*]). \nIf user specify \"subnet_id\", there is no need to list all networks and subnets in NeutronLoadbalancer.create_and_list_pools\n\n[*] - https://github.com/openstack/rally/blob/master/rally/benchmark/validation.py#L515-L520","commit_id":"7441bacce6640d40c1b6f992cb04f8a80577a81a"},{"author":{"_account_id":13609,"name":"Pavel Boldin","email":"pboldin@mirantis.com","username":"pboldin"},"change_message_id":"95b4e465355aeb4c906cccb5c878f62386bfbf50","unresolved":false,"context_lines":[{"line_number":298,"context_line":"        :parm subnet_id: str, neutron subnet-id"},{"line_number":299,"context_line":"        :returns: obj, neutron lb pool"},{"line_number":300,"context_line":"        \"\"\""},{"line_number":301,"context_line":"        pool_create_args.setdefault(\"lb_method\", self.LB_METHOD)"},{"line_number":302,"context_line":"        pool_create_args.setdefault(\"protocol\", self.LB_PROTOCOL)"},{"line_number":303,"context_line":"        pool_create_args.setdefault(\"name\","},{"line_number":304,"context_line":"                                    self._generate_random_name(\"rally_pool_\"))"}],"source_content_type":"text/x-python","patch_set":24,"id":"3afb71cf_27d62d4f","line":301,"updated":"2015-06-11 01:12:53.000000000","message":"Well, this seems to be a `action-at-a-distance\u0027 anti-pattern: you are changing an argument that is passed to you.\n\nPlease don\u0027t do this. (Yet there is a code in the project where this is necessary partially)\n\nBetter do this way:\n args \u003d {\"lb_method\": self.LB_METHOD,\n         \"protocol\": self.LB_PROTOCOL,\n         \"name\": ....\n         \"subnet_id\": subnet_id}\n\n args.update(pool_create_args) # everything that is not in pool_create_args will default to args\n return self.clients(\"neutron\").create_pool({\"pool\": args})","commit_id":"7e91461cb084be790a18e08648afbb479f1fdcc8"},{"author":{"_account_id":8576,"name":"Yair Fried","email":"yfried@redhat.com","username":"yfried"},"change_message_id":"35e24995b541ef499e20dff35cddf63509fe2c0a","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    RESOURCE_NAME_PREFIX \u003d \"rally_net_\""},{"line_number":29,"context_line":"    RESOURCE_NAME_LENGTH \u003d 16"},{"line_number":30,"context_line":"    SUBNET_IP_VERSION \u003d 4"},{"line_number":31,"context_line":"    LB_METHOD \u003d \"ROUND_ROBIN\""},{"line_number":32,"context_line":"    LB_PROTOCOL \u003d \"HTTP\""},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    @base.atomic_action_timer(\"neutron.create_network\")"}],"source_content_type":"text/x-python","patch_set":30,"id":"3afb71cf_ef31fca2","line":31,"updated":"2015-06-11 11:30:29.000000000","message":"please comment above these 2 lines:\nTODO: modify in case lbaasV2 requires","commit_id":"2ed5821bbe3ca1515b56587d0f1bf4aec11fb903"},{"author":{"_account_id":8576,"name":"Yair Fried","email":"yfried@redhat.com","username":"yfried"},"change_message_id":"35e24995b541ef499e20dff35cddf63509fe2c0a","unresolved":false,"context_lines":[{"line_number":291,"context_line":"            router[\"id\"], {\"subnet_id\": subnet[\"id\"]})"},{"line_number":292,"context_line":""},{"line_number":293,"context_line":"    @base.atomic_action_timer(\"neutron.create_pool\")"},{"line_number":294,"context_line":"    def _create_v1_pool(self, pool_create_args, subnet_id):"},{"line_number":295,"context_line":"        \"\"\"Create pool(LBaaS v1)"},{"line_number":296,"context_line":""},{"line_number":297,"context_line":"        :parm pool_create_args: dict, POST /lb/pools request options"}],"source_content_type":"text/x-python","patch_set":30,"id":"3afb71cf_6f498c30","line":294,"updated":"2015-06-11 11:30:29.000000000","message":"_create_v1_pool(self, subnet_id, **pool_create_args):","commit_id":"2ed5821bbe3ca1515b56587d0f1bf4aec11fb903"},{"author":{"_account_id":13609,"name":"Pavel Boldin","email":"pboldin@mirantis.com","username":"pboldin"},"change_message_id":"ea2c10191e4d3138e8827562f7602b881622d0c0","unresolved":false,"context_lines":[{"line_number":291,"context_line":"            router[\"id\"], {\"subnet_id\": subnet[\"id\"]})"},{"line_number":292,"context_line":""},{"line_number":293,"context_line":"    @base.atomic_action_timer(\"neutron.create_pool\")"},{"line_number":294,"context_line":"    def _create_v1_pool(self, pool_create_args, subnet_id):"},{"line_number":295,"context_line":"        \"\"\"Create pool(LBaaS v1)"},{"line_number":296,"context_line":""},{"line_number":297,"context_line":"        :parm pool_create_args: dict, POST /lb/pools request options"}],"source_content_type":"text/x-python","patch_set":30,"id":"3afb71cf_0fca181b","line":294,"in_reply_to":"3afb71cf_6f498c30","updated":"2015-06-11 11:34:42.000000000","message":"Well, I would prefer them to be moved to the appropriate class:\n\nclass NeutronLBaaSV1Scenario(NeutronScenario)...","commit_id":"2ed5821bbe3ca1515b56587d0f1bf4aec11fb903"},{"author":{"_account_id":8576,"name":"Yair Fried","email":"yfried@redhat.com","username":"yfried"},"change_message_id":"35e24995b541ef499e20dff35cddf63509fe2c0a","unresolved":false,"context_lines":[{"line_number":305,"context_line":"        return self.clients(\"neutron\").create_pool({\"pool\": args})"},{"line_number":306,"context_line":""},{"line_number":307,"context_line":"    @base.atomic_action_timer(\"neutron.list_pools\")"},{"line_number":308,"context_line":"    def _list_v1_pools(self):"},{"line_number":309,"context_line":"        \"\"\"Return user lb pool list(LBaaS v1).\"\"\""},{"line_number":310,"context_line":"        return self.clients(\"neutron\").list_pools()"}],"source_content_type":"text/x-python","patch_set":30,"id":"3afb71cf_2f995479","line":308,"updated":"2015-06-11 11:30:29.000000000","message":"most of neutron listers receive arguments so:  \n\n  def _list_v1_pools(self, **kwargs)\n\nhttps://github.com/openstack/python-neutronclient/blob/master/neutronclient/v2_0/client.py#L1053","commit_id":"2ed5821bbe3ca1515b56587d0f1bf4aec11fb903"},{"author":{"_account_id":8576,"name":"Yair Fried","email":"yfried@redhat.com","username":"yfried"},"change_message_id":"35e24995b541ef499e20dff35cddf63509fe2c0a","unresolved":false,"context_lines":[{"line_number":307,"context_line":"    @base.atomic_action_timer(\"neutron.list_pools\")"},{"line_number":308,"context_line":"    def _list_v1_pools(self):"},{"line_number":309,"context_line":"        \"\"\"Return user lb pool list(LBaaS v1).\"\"\""},{"line_number":310,"context_line":"        return self.clients(\"neutron\").list_pools()"}],"source_content_type":"text/x-python","patch_set":30,"id":"3afb71cf_cf8080f9","line":310,"updated":"2015-06-11 11:30:29.000000000","message":"return self.clients(\"neutron\").list_pools(**kwargs)","commit_id":"2ed5821bbe3ca1515b56587d0f1bf4aec11fb903"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"66dd36d9c4de5fe8418b233fce961062dea73fdc","unresolved":false,"context_lines":[{"line_number":296,"context_line":"        \"\"\"Create pool(v1)"},{"line_number":297,"context_line":""},{"line_number":298,"context_line":"        :parm pool_create_args: dict, POST /lb/pools request options"},{"line_number":299,"context_line":"        :parm subnet_id: str, neutron subnet-id"},{"line_number":300,"context_line":"        :returns: obj, neutron lb pool"},{"line_number":301,"context_line":"        \"\"\""},{"line_number":302,"context_line":"        args \u003d {\"lb_method\": self.LB_METHOD, \"protocol\": self.LB_PROTOCOL,"}],"source_content_type":"text/x-python","patch_set":34,"id":"1af86dd1_168fbd24","line":299,"updated":"2015-06-12 07:11:43.000000000","message":"move this line up","commit_id":"79ecb54a39a1282e754bbe472e65b434f9dca140"}],"samples/tasks/scenarios/neutron/create_and_list_pools.json":[{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"48359083c6d82a099f3d83de49be506c298be82e","unresolved":false,"context_lines":[{"line_number":15,"context_line":"            },"},{"line_number":16,"context_line":"            \"context\": {"},{"line_number":17,"context_line":"                \"users\": {"},{"line_number":18,"context_line":"                    \"tenants\": 1,"},{"line_number":19,"context_line":"                    \"users_per_tenant\": 1"},{"line_number":20,"context_line":"                },"},{"line_number":21,"context_line":"                \"quotas\": {"}],"source_content_type":"application/json","patch_set":3,"id":"7a016987_cb6a2581","line":18,"updated":"2015-05-19 09:49:51.000000000","message":"I would recommend to increase number of tenants, since you have 100 iterations","commit_id":"fe146f75b0a3147ae03a53e05b6b7573fd74fc5b"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"30ebad2608dc9f5bf17741bea096ae610c92cec0","unresolved":false,"context_lines":[{"line_number":17,"context_line":"                \"network\":{},"},{"line_number":18,"context_line":"                \"quotas\": {"},{"line_number":19,"context_line":"                    \"neutron\": {"},{"line_number":20,"context_line":"                        \"network\": -1"},{"line_number":21,"context_line":"                    }"},{"line_number":22,"context_line":"                }"},{"line_number":23,"context_line":"            }"}],"source_content_type":"application/json","patch_set":12,"id":"7a016987_639fee03","line":20,"updated":"2015-05-28 10:23:56.000000000","message":"Let\u0027s add -1 quota for pool as well","commit_id":"559b3c927072a0d0ac328464052732bc4216b5d5"}],"samples/tasks/scenarios/neutron/create_and_list_pools.yaml":[{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"66dd36d9c4de5fe8418b233fce961062dea73fdc","unresolved":false,"context_lines":[{"line_number":3,"context_line":"    -"},{"line_number":4,"context_line":"      args:"},{"line_number":5,"context_line":"        pool_create_args: {}"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"      runner:"},{"line_number":8,"context_line":"        type: \"constant\""},{"line_number":9,"context_line":"        times: 100"}],"source_content_type":"text/x-yaml","patch_set":34,"id":"1af86dd1_d6afe57b","line":6,"updated":"2015-06-12 07:11:43.000000000","message":"remove blank line","commit_id":"79ecb54a39a1282e754bbe472e65b434f9dca140"}],"tests/unit/benchmark/scenarios/neutron/test_utils.py":[{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"48359083c6d82a099f3d83de49be506c298be82e","unresolved":false,"context_lines":[{"line_number":499,"context_line":"    @mock.patch(NEUTRON_UTILS + \"NeutronScenario.clients\")"},{"line_number":500,"context_line":"    def test_list_pools(self, mock_clients):"},{"line_number":501,"context_line":"        scenario \u003d utils.NeutronScenario()"},{"line_number":502,"context_line":"        mock_clients(\"neutron\").list_pools.return_value \u003d ()"},{"line_number":503,"context_line":""},{"line_number":504,"context_line":"        scenario._list_pools()"},{"line_number":505,"context_line":"        mock_clients(\"neutron\").list_pools.assert_called_once_with()"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a016987_eb1f2106","line":502,"updated":"2015-05-19 09:49:51.000000000","message":"Add assert to check return value.\n\nAlso, empty tuple looks too simple for testing, use non-empty tuple or even a string:\n\n mock_clients(\"neutron\").list_pools.return_value \u003d \"foo_list\"\n result \u003d scenario._list_pools()\n self.assertEqual(\"foo_list\", result)","commit_id":"fe146f75b0a3147ae03a53e05b6b7573fd74fc5b"}],"tests/unit/plugins/openstack/scenarios/neutron/test_loadbalancer.py":[{"author":{"_account_id":13609,"name":"Pavel Boldin","email":"pboldin@mirantis.com","username":"pboldin"},"change_message_id":"4349cbc898f326bf9c53eb615f4664bc8f2fb182","unresolved":false,"context_lines":[{"line_number":17,"context_line":"from rally.plugins.openstack.scenarios.neutron import loadbalancer"},{"line_number":18,"context_line":"from tests.unit import test"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"LB_SCENRIO \u003d \"rally.plugins.openstack.scenarios.neutron.loadbalancer.\""},{"line_number":21,"context_line":"NEUTRON_LOADBALANCER \u003d LB_SCENRIO + \"NeutronLoadbalancer\""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"7a016987_89502760","line":20,"updated":"2015-05-26 12:09:09.000000000","message":"LB_SCENARIO is not required here.","commit_id":"44976446de430238bb94b0adfca36061b7fe0f6e"},{"author":{"_account_id":13609,"name":"Pavel Boldin","email":"pboldin@mirantis.com","username":"pboldin"},"change_message_id":"4349cbc898f326bf9c53eb615f4664bc8f2fb182","unresolved":false,"context_lines":[{"line_number":18,"context_line":"from tests.unit import test"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"LB_SCENRIO \u003d \"rally.plugins.openstack.scenarios.neutron.loadbalancer.\""},{"line_number":21,"context_line":"NEUTRON_LOADBALANCER \u003d LB_SCENRIO + \"NeutronLoadbalancer\""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"class NeutronLoadbalancerTestCase(test.TestCase):"}],"source_content_type":"text/x-python","patch_set":7,"id":"7a016987_09cb1720","line":21,"updated":"2015-05-26 12:09:09.000000000","message":"Just\n\n NEUTRON_LOADBALANCER \u003d (\".......\"\n   \".....\")","commit_id":"44976446de430238bb94b0adfca36061b7fe0f6e"},{"author":{"_account_id":13609,"name":"Pavel Boldin","email":"pboldin@mirantis.com","username":"pboldin"},"change_message_id":"4349cbc898f326bf9c53eb615f4664bc8f2fb182","unresolved":false,"context_lines":[{"line_number":45,"context_line":"                subnet)"},{"line_number":46,"context_line":"        mock_list.assert_called_once_with()"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"        mock_create.reset_mock()"},{"line_number":49,"context_line":"        mock_list.reset_mock()"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"        # Explicit pool name is specified"}],"source_content_type":"text/x-python","patch_set":7,"id":"7a016987_49f8ef49","line":48,"updated":"2015-05-26 12:09:09.000000000","message":"Please separate these into two test functions:\n\n test_create_and_list_pools_default\n test_create_and_list_pools_explicit","commit_id":"44976446de430238bb94b0adfca36061b7fe0f6e"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"a46b1c99d2682d9dd37d90a39ba326e65d9418cf","unresolved":false,"context_lines":[{"line_number":28,"context_line":"        self.context \u003d {"},{"line_number":29,"context_line":"            \"user\": {\"tenant_id\": \"fake\"},"},{"line_number":30,"context_line":"            \"tenant\": {\"id\": \"fake\"},"},{"line_number":31,"context_line":"            \"subnets\": \"id\"}"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    @mock.patch(NEUTRON_LOADBALANCER + \"._list_pools\")"},{"line_number":34,"context_line":"    @mock.patch(NEUTRON_LOADBALANCER + \"._create_pools\")"}],"source_content_type":"text/x-python","patch_set":8,"id":"7a016987_90304009","line":31,"updated":"2015-05-26 16:33:21.000000000","message":"This is not correct init of context. Doing so, you hide bugs of context initialization.\n\nIn current case, your unit tests pass, when \"self.context[\"subnets\"]\" does not exist indeed. See comment here:\n\nhttps://review.openstack.org/#/c/182685/8/rally/plugins/openstack/scenarios/neutron/loadbalancer.py","commit_id":"d2e45893bf6c135eaf0058ad237a7e499878b6a6"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"66dbf97ea7bd67994a5995c267379af5373df55e","unresolved":false,"context_lines":[{"line_number":28,"context_line":"        self.context \u003d {"},{"line_number":29,"context_line":"            \"user\": {\"tenant_id\": \"fake\"},"},{"line_number":30,"context_line":"            \"tenant\": {\"id\": \"fake\"},"},{"line_number":31,"context_line":"            \"subnets\": \"id\"}"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    @mock.patch(NEUTRON_LOADBALANCER + \"._list_pools\")"},{"line_number":34,"context_line":"    @mock.patch(NEUTRON_LOADBALANCER + \"._create_pools\")"}],"source_content_type":"text/x-python","patch_set":10,"id":"7a016987_ee753a32","line":31,"updated":"2015-05-27 08:47:37.000000000","message":"See comment: https://review.openstack.org/#/c/182685/8/tests/unit/plugins/openstack/scenarios/neutron/test_loadbalancer.py\n\nYou changed behavior but tests still pass. Looks like your tests do not verify expected logic at all.","commit_id":"3c40938a4d03ee6c1087992e6e11467a381f10c1"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"30ebad2608dc9f5bf17741bea096ae610c92cec0","unresolved":false,"context_lines":[{"line_number":26,"context_line":"    def setUp(self):"},{"line_number":27,"context_line":"        super(NeutronLoadbalancerTestCase, self).setUp()"},{"line_number":28,"context_line":"        self.context \u003d {"},{"line_number":29,"context_line":"            \"user\": {\"id\": \"fake\", \"tenant_id\": \"fake\"},"},{"line_number":30,"context_line":"            \"tenant\": {\"id\": \"fake\", \"networks\": [{\"id\": \"fake\","},{"line_number":31,"context_line":"                                                   \"subnets\": [\"fake\"]}]}}"},{"line_number":32,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"7a016987_235fb642","line":29,"updated":"2015-05-28 10:23:56.000000000","message":"Using same value for different IDs is very bad practice\n\n self.context \u003d {\n            \"user\": {\"id\": \"fake_user\", \"tenant_id\": \"fake_tenant\"},\n            \"tenant\": {\n                \"id\": \"fake_tenant\",\n                \"networks\": [{\"id\": \"fake_net\",\n                              \"subnets\": [\"fake_subnet\"]}]}}","commit_id":"559b3c927072a0d0ac328464052732bc4216b5d5"},{"author":{"_account_id":13609,"name":"Pavel Boldin","email":"pboldin@mirantis.com","username":"pboldin"},"change_message_id":"3c249bea40f3374646b9265350901fac173bb3b8","unresolved":false,"context_lines":[{"line_number":50,"context_line":"        # Explicit pool name is specified"},{"line_number":51,"context_line":"        pool_create_args \u003d {}"},{"line_number":52,"context_line":"        expected_args \u003d {\"name\": \"given-name\"}"},{"line_number":53,"context_line":"        neutron_scenario.create_and_list_pools(pool_create_args\u003dexpected_args)"},{"line_number":54,"context_line":"        for net in self.context[\"tenant\"][\"networks\"]:"},{"line_number":55,"context_line":"            for subnet_id in net[\"subnets\"]:"},{"line_number":56,"context_line":"                mock_create.assert_has_calls(pool_create_args, subnet_id)"}],"source_content_type":"text/x-python","patch_set":15,"id":"7a016987_c5b6943d","line":53,"updated":"2015-05-28 17:40:07.000000000","message":"As far as I see this should fail.","commit_id":"61c53bdc5fd03faecd77bc821de4c73858faa275"},{"author":{"_account_id":13609,"name":"Pavel Boldin","email":"pboldin@mirantis.com","username":"pboldin"},"change_message_id":"129d956d8ce58e4e2af9a7d98b3dfec54db49c22","unresolved":false,"context_lines":[{"line_number":29,"context_line":"                       \"networks\": [{\"id\": \"fake_net\","},{"line_number":30,"context_line":"                                     \"subnets\": [\"fake_subnet\"]}]}}"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    @mock.patch(NEUTRON_LOADBALANCER + \"._list_pools\")"},{"line_number":33,"context_line":"    @mock.patch(NEUTRON_LOADBALANCER + \"._create_pool\")"},{"line_number":34,"context_line":"    def test_create_and_list_pools_default(self, mock_create, mock_list):"},{"line_number":35,"context_line":"        neutron_scenario \u003d loadbalancer.NeutronLoadbalancer(self.context)"}],"source_content_type":"text/x-python","patch_set":16,"id":"7a016987_fd310fa3","line":32,"updated":"2015-05-29 10:59:10.000000000","message":"You can actually mock these inside the function body:\n neutron_scenario._list_pools \u003d mock.Mock()\n neutron_scenario._create_pool \u003d mock.Mock()","commit_id":"801ae9ab96256a07438fabfacc5c62a285035fad"},{"author":{"_account_id":13609,"name":"Pavel Boldin","email":"pboldin@mirantis.com","username":"pboldin"},"change_message_id":"6181b6102913391742f36b2af4229a9f40839559","unresolved":false,"context_lines":[{"line_number":29,"context_line":"                       \"networks\": [{\"id\": \"fake_net\","},{"line_number":30,"context_line":"                                     \"subnets\": [\"fake_subnet\"]}]}}"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    @mock.patch(NEUTRON_LOADBALANCER + \"._list_pools\")"},{"line_number":33,"context_line":"    @mock.patch(NEUTRON_LOADBALANCER + \"._create_pool\")"},{"line_number":34,"context_line":"    def test_create_and_list_pools_default(self, mock_create, mock_list):"},{"line_number":35,"context_line":"        neutron_scenario \u003d loadbalancer.NeutronLoadbalancer(self.context)"}],"source_content_type":"text/x-python","patch_set":16,"id":"7a016987_14ef201f","line":32,"in_reply_to":"7a016987_0395a831","updated":"2015-05-29 13:13:21.000000000","message":"The differ from each other. One you have followed is bad.","commit_id":"801ae9ab96256a07438fabfacc5c62a285035fad"},{"author":{"_account_id":14298,"name":"maplelabs","email":"maniram.sekaran@maplelabs.com","username":"maplelabs"},"change_message_id":"c9d063c56c685be5549e82d10894697982301291","unresolved":false,"context_lines":[{"line_number":29,"context_line":"                       \"networks\": [{\"id\": \"fake_net\","},{"line_number":30,"context_line":"                                     \"subnets\": [\"fake_subnet\"]}]}}"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    @mock.patch(NEUTRON_LOADBALANCER + \"._list_pools\")"},{"line_number":33,"context_line":"    @mock.patch(NEUTRON_LOADBALANCER + \"._create_pool\")"},{"line_number":34,"context_line":"    def test_create_and_list_pools_default(self, mock_create, mock_list):"},{"line_number":35,"context_line":"        neutron_scenario \u003d loadbalancer.NeutronLoadbalancer(self.context)"}],"source_content_type":"text/x-python","patch_set":16,"id":"7a016987_0395a831","line":32,"in_reply_to":"7a016987_fd310fa3","updated":"2015-05-29 12:10:41.000000000","message":"I have followed the conventions from the existing scenarios","commit_id":"801ae9ab96256a07438fabfacc5c62a285035fad"},{"author":{"_account_id":13609,"name":"Pavel Boldin","email":"pboldin@mirantis.com","username":"pboldin"},"change_message_id":"129d956d8ce58e4e2af9a7d98b3dfec54db49c22","unresolved":false,"context_lines":[{"line_number":40,"context_line":"            pool_create_args\u003dpool_create_args)"},{"line_number":41,"context_line":"        for net in self.context[\"tenant\"][\"networks\"]:"},{"line_number":42,"context_line":"            for subnet_id in net[\"subnets\"]:"},{"line_number":43,"context_line":"                mock_create.assert_called_once_with("},{"line_number":44,"context_line":"                    pool_create_args, subnet_id)"},{"line_number":45,"context_line":"        mock_list.assert_called_once_with()"},{"line_number":46,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"7a016987_bdb5d7ed","line":43,"updated":"2015-05-29 10:59:10.000000000","message":"And then use `neutron_scenario._create_pool\u0027 instead of `mock_create\u0027. This makes code more readable, since one has the semantics in the `neutron_scenario._create_pool\u0027 rather then having to check what `mock_create\u0027 is.","commit_id":"801ae9ab96256a07438fabfacc5c62a285035fad"},{"author":{"_account_id":13609,"name":"Pavel Boldin","email":"pboldin@mirantis.com","username":"pboldin"},"change_message_id":"6181b6102913391742f36b2af4229a9f40839559","unresolved":false,"context_lines":[{"line_number":40,"context_line":"            pool_create_args\u003dpool_create_args)"},{"line_number":41,"context_line":"        for net in self.context[\"tenant\"][\"networks\"]:"},{"line_number":42,"context_line":"            for subnet_id in net[\"subnets\"]:"},{"line_number":43,"context_line":"                mock_create.assert_called_once_with("},{"line_number":44,"context_line":"                    pool_create_args, subnet_id)"},{"line_number":45,"context_line":"        mock_list.assert_called_once_with()"},{"line_number":46,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"7a016987_d4cbc8a2","line":43,"in_reply_to":"7a016987_83ae382c","updated":"2015-05-29 13:13:21.000000000","message":"Yes. As I stated -- these are bad. And in the comment above I present you exactly why:\n 1. You are introducing a new variable.\n 2. This variable\u0027s purpose and origin are outside of the one screen of the code (24 lines). So, the person who will read your code will require to look at what `mock_create\u0027 and `mock_list\u0027 do mean.\n\nUsing `neutron_scenario._create_pool\u0027 fixes both of these problems.","commit_id":"801ae9ab96256a07438fabfacc5c62a285035fad"},{"author":{"_account_id":14298,"name":"maplelabs","email":"maniram.sekaran@maplelabs.com","username":"maplelabs"},"change_message_id":"c9d063c56c685be5549e82d10894697982301291","unresolved":false,"context_lines":[{"line_number":40,"context_line":"            pool_create_args\u003dpool_create_args)"},{"line_number":41,"context_line":"        for net in self.context[\"tenant\"][\"networks\"]:"},{"line_number":42,"context_line":"            for subnet_id in net[\"subnets\"]:"},{"line_number":43,"context_line":"                mock_create.assert_called_once_with("},{"line_number":44,"context_line":"                    pool_create_args, subnet_id)"},{"line_number":45,"context_line":"        mock_list.assert_called_once_with()"},{"line_number":46,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"7a016987_83ae382c","line":43,"in_reply_to":"7a016987_bdb5d7ed","updated":"2015-05-29 12:10:41.000000000","message":"I have followed conventions from the existing functions","commit_id":"801ae9ab96256a07438fabfacc5c62a285035fad"},{"author":{"_account_id":14298,"name":"maplelabs","email":"maniram.sekaran@maplelabs.com","username":"maplelabs"},"change_message_id":"c9d063c56c685be5549e82d10894697982301291","unresolved":false,"context_lines":[{"line_number":40,"context_line":"            pool_create_args\u003dpool_create_args)"},{"line_number":41,"context_line":"        for net in self.context[\"tenant\"][\"networks\"]:"},{"line_number":42,"context_line":"            for subnet_id in net[\"subnets\"]:"},{"line_number":43,"context_line":"                mock_create.assert_called_once_with("},{"line_number":44,"context_line":"                    pool_create_args, subnet_id)"},{"line_number":45,"context_line":"        mock_list.assert_called_once_with()"},{"line_number":46,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"7a016987_c30d5090","line":43,"in_reply_to":"7a016987_bdb5d7ed","updated":"2015-05-29 12:10:41.000000000","message":"Same here","commit_id":"801ae9ab96256a07438fabfacc5c62a285035fad"},{"author":{"_account_id":13609,"name":"Pavel Boldin","email":"pboldin@mirantis.com","username":"pboldin"},"change_message_id":"129d956d8ce58e4e2af9a7d98b3dfec54db49c22","unresolved":false,"context_lines":[{"line_number":47,"context_line":"    @mock.patch(NEUTRON_LOADBALANCER + \"._list_pools\")"},{"line_number":48,"context_line":"    @mock.patch(NEUTRON_LOADBALANCER + \"._create_pool\")"},{"line_number":49,"context_line":"    def test_create_and_list_pools_explicit(self, mock_create, mock_list):"},{"line_number":50,"context_line":"        neutron_scenario \u003d loadbalancer.NeutronLoadbalancer(self.context)"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"        # Explicit pool name is specified"},{"line_number":53,"context_line":"        pool_create_args \u003d {\"name\": \"given-name\"}"}],"source_content_type":"text/x-python","patch_set":16,"id":"7a016987_bd271762","line":50,"updated":"2015-05-29 10:59:10.000000000","message":"Same here.","commit_id":"801ae9ab96256a07438fabfacc5c62a285035fad"},{"author":{"_account_id":14298,"name":"maplelabs","email":"maniram.sekaran@maplelabs.com","username":"maplelabs"},"change_message_id":"c9d063c56c685be5549e82d10894697982301291","unresolved":false,"context_lines":[{"line_number":47,"context_line":"    @mock.patch(NEUTRON_LOADBALANCER + \"._list_pools\")"},{"line_number":48,"context_line":"    @mock.patch(NEUTRON_LOADBALANCER + \"._create_pool\")"},{"line_number":49,"context_line":"    def test_create_and_list_pools_explicit(self, mock_create, mock_list):"},{"line_number":50,"context_line":"        neutron_scenario \u003d loadbalancer.NeutronLoadbalancer(self.context)"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"        # Explicit pool name is specified"},{"line_number":53,"context_line":"        pool_create_args \u003d {\"name\": \"given-name\"}"}],"source_content_type":"text/x-python","patch_set":16,"id":"7a016987_036928f9","line":50,"in_reply_to":"7a016987_bd271762","updated":"2015-05-29 12:10:41.000000000","message":"I have followed existing functions","commit_id":"801ae9ab96256a07438fabfacc5c62a285035fad"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"cbbf24714c78d7ac0cdd211eb4ab3cd325c79bb8","unresolved":false,"context_lines":[{"line_number":26,"context_line":"                       \"networks\": [{\"id\": \"fake_net\","},{"line_number":27,"context_line":"                                     \"subnets\": [\"fake_subnet\"]}]}}"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    def test_create_and_list_pools_default(self):"},{"line_number":30,"context_line":"        neutron_scenario \u003d loadbalancer.NeutronLoadbalancer(self.context)"},{"line_number":31,"context_line":"        neutron_scenario._create_pool \u003d mock.Mock()"},{"line_number":32,"context_line":"        neutron_scenario._list_pools \u003d mock.Mock()"}],"source_content_type":"text/x-python","patch_set":19,"id":"5afe65bd_721dca72","line":29,"updated":"2015-06-02 12:07:53.000000000","message":"These two tests are very similar. And it would be correct to say that we have code duplication here. I would suggest to reuse that part of code and avoid code duplication.","commit_id":"a654f3959b1c8c231edc1d2551da1abe39355267"},{"author":{"_account_id":8507,"name":"Mikhail Dubov","email":"mdubov@mirantis.com","username":"msdubov"},"change_message_id":"f6a62f27067ee514805ab68e4754ecf36c4ee7c5","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"    def setUp(self):"},{"line_number":22,"context_line":"        super(NeutronLoadbalancerTestCase, self).setUp()"},{"line_number":23,"context_line":"        self.context \u003d {"},{"line_number":24,"context_line":"            \"user\": {\"id\": \"fake_user\", \"tenant_id\": \"fake_tenant\"},"},{"line_number":25,"context_line":"            \"tenant\": {\"id\": \"fake_tenant\","},{"line_number":26,"context_line":"                       \"networks\": [{\"id\": \"fake_net\","}],"source_content_type":"text/x-python","patch_set":21,"id":"5afe65bd_6b8c5e35","line":23,"updated":"2015-06-04 01:34:05.000000000","message":"Introducing a variable in setUp() and then using it in a test method is a kind of antipattern just because this variable potentially may be modified while executing the test scenario. Could you please add instead a method like:\n\n    def get_context(self):\n         return {...}\n\nand use it in lines 30/35?","commit_id":"1bd6e7e9d26d698eb8ae409ddd89f7352f44cbd8"},{"author":{"_account_id":13609,"name":"Pavel Boldin","email":"pboldin@mirantis.com","username":"pboldin"},"change_message_id":"95b4e465355aeb4c906cccb5c878f62386bfbf50","unresolved":false,"context_lines":[{"line_number":32,"context_line":"        neutron_scenario._list_pools \u003d mock.Mock()"},{"line_number":33,"context_line":"        neutron_scenario.create_and_list_pools("},{"line_number":34,"context_line":"            pool_create_args\u003dpool_create_args)"},{"line_number":35,"context_line":"        for net in self._get_context()[\"tenant\"][\"networks\"]:"},{"line_number":36,"context_line":"            for subnet_id in net[\"subnets\"]:"},{"line_number":37,"context_line":"                neutron_scenario._create_pool.assert_called_once_with("},{"line_number":38,"context_line":"                    pool_create_args, subnet_id)"}],"source_content_type":"text/x-python","patch_set":24,"id":"3afb71cf_472fe93e","line":35,"updated":"2015-06-11 01:12:53.000000000","message":"You will have to fix these as well.","commit_id":"7e91461cb084be790a18e08648afbb479f1fdcc8"},{"author":{"_account_id":13609,"name":"Pavel Boldin","email":"pboldin@mirantis.com","username":"pboldin"},"change_message_id":"cbd399509789c64d018491578cfbd184f0a5cdec","unresolved":false,"context_lines":[{"line_number":32,"context_line":"        neutron_scenario._list_pools \u003d mock.Mock()"},{"line_number":33,"context_line":"        neutron_scenario.create_and_list_pools("},{"line_number":34,"context_line":"            pool_create_args\u003dpool_create_args)"},{"line_number":35,"context_line":"        for net in self._get_context()[\"tenant\"][\"networks\"]:"},{"line_number":36,"context_line":"            for subnet_id in net[\"subnets\"]:"},{"line_number":37,"context_line":"                neutron_scenario._create_pool.assert_called_once_with("},{"line_number":38,"context_line":"                    pool_create_args, subnet_id)"}],"source_content_type":"text/x-python","patch_set":24,"id":"3afb71cf_47b929cb","line":35,"in_reply_to":"3afb71cf_472fe93e","updated":"2015-06-11 01:16:47.000000000","message":"(I mean: fixing the anti-pattern will most surely break these).","commit_id":"7e91461cb084be790a18e08648afbb479f1fdcc8"}],"tests/unit/plugins/openstack/scenarios/neutron/test_utils.py":[{"author":{"_account_id":13609,"name":"Pavel Boldin","email":"pboldin@mirantis.com","username":"pboldin"},"change_message_id":"4349cbc898f326bf9c53eb615f4664bc8f2fb182","unresolved":false,"context_lines":[{"line_number":451,"context_line":"                \"id\": \"pool-id\""},{"line_number":452,"context_line":"            }"},{"line_number":453,"context_line":"        }"},{"line_number":454,"context_line":"        mock_clients(\"neutron\").create_pool.return_value \u003d (pool)"},{"line_number":455,"context_line":"        mock_random_name.return_value \u003d random_name"},{"line_number":456,"context_line":""},{"line_number":457,"context_line":"        # Pool name is specified"}],"source_content_type":"text/x-python","patch_set":7,"id":"7a016987_a98883c7","line":454,"updated":"2015-05-26 12:09:09.000000000","message":"Please use\n mock_clients.return_value.create_pool.return_value \u003d pool\n\nSee here for reason: https://github.com/paboldin/python-samples/blob/master/why-not-call-mock-during-test-setup.py","commit_id":"44976446de430238bb94b0adfca36061b7fe0f6e"},{"author":{"_account_id":13609,"name":"Pavel Boldin","email":"pboldin@mirantis.com","username":"pboldin"},"change_message_id":"f45b0d3d7d1ee2eaebad802a3da359ac2521dbd2","unresolved":false,"context_lines":[{"line_number":461,"context_line":""},{"line_number":462,"context_line":"        neutron_scenario._create_pools(pool_create_args\u003dpool_data,"},{"line_number":463,"context_line":"                                       subnet\u003dsubnet)"},{"line_number":464,"context_line":"        mock_clients(\"neutron\").create_pool.assert_called_once_with("},{"line_number":465,"context_line":"            expected_pool_data)"},{"line_number":466,"context_line":"        self._test_atomic_action_timer("},{"line_number":467,"context_line":"            neutron_scenario.atomic_actions(), \"neutron.create_pools\")"}],"source_content_type":"text/x-python","patch_set":8,"id":"7a016987_b4d7b7be","line":464,"updated":"2015-05-26 13:51:10.000000000","message":"Use `return_value\u0027 here as well.","commit_id":"d2e45893bf6c135eaf0058ad237a7e499878b6a6"},{"author":{"_account_id":13609,"name":"Pavel Boldin","email":"pboldin@mirantis.com","username":"pboldin"},"change_message_id":"f45b0d3d7d1ee2eaebad802a3da359ac2521dbd2","unresolved":false,"context_lines":[{"line_number":466,"context_line":"        self._test_atomic_action_timer("},{"line_number":467,"context_line":"            neutron_scenario.atomic_actions(), \"neutron.create_pools\")"},{"line_number":468,"context_line":""},{"line_number":469,"context_line":"        mock_clients(\"neutron\").create_pool.reset_mock()"},{"line_number":470,"context_line":""},{"line_number":471,"context_line":"        # Random pool name"},{"line_number":472,"context_line":"        pool_data \u003d {}"}],"source_content_type":"text/x-python","patch_set":8,"id":"7a016987_74e13f9a","line":469,"updated":"2015-05-26 13:51:10.000000000","message":"And here.","commit_id":"d2e45893bf6c135eaf0058ad237a7e499878b6a6"},{"author":{"_account_id":13609,"name":"Pavel Boldin","email":"pboldin@mirantis.com","username":"pboldin"},"change_message_id":"f45b0d3d7d1ee2eaebad802a3da359ac2521dbd2","unresolved":false,"context_lines":[{"line_number":473,"context_line":"        expected_pool_data[\"pool\"][\"name\"] \u003d random_name"},{"line_number":474,"context_line":"        pool \u003d neutron_scenario._create_pools("},{"line_number":475,"context_line":"            pool_create_args\u003dpool_data, subnet\u003dsubnet)"},{"line_number":476,"context_line":"        mock_clients(\"neutron\").create_pool.assert_called_once_with("},{"line_number":477,"context_line":"            expected_pool_data)"},{"line_number":478,"context_line":""},{"line_number":479,"context_line":"    @mock.patch(NEUTRON_UTILS + \"NeutronScenario.clients\")"}],"source_content_type":"text/x-python","patch_set":8,"id":"7a016987_54ed238d","line":476,"updated":"2015-05-26 13:51:10.000000000","message":"And here.","commit_id":"d2e45893bf6c135eaf0058ad237a7e499878b6a6"},{"author":{"_account_id":13609,"name":"Pavel Boldin","email":"pboldin@mirantis.com","username":"pboldin"},"change_message_id":"f45b0d3d7d1ee2eaebad802a3da359ac2521dbd2","unresolved":false,"context_lines":[{"line_number":482,"context_line":"        mock_clients.return_value.create_pool.return_value \u003d ()"},{"line_number":483,"context_line":""},{"line_number":484,"context_line":"        scenario._list_pools()"},{"line_number":485,"context_line":"        mock_clients(\"neutron\").list_pools.assert_called_once_with()"},{"line_number":486,"context_line":"        self._test_atomic_action_timer(scenario.atomic_actions(),"},{"line_number":487,"context_line":"                                       \"neutron.list_pools\")"}],"source_content_type":"text/x-python","patch_set":8,"id":"7a016987_14e7abad","line":485,"updated":"2015-05-26 13:51:10.000000000","message":"And here.","commit_id":"d2e45893bf6c135eaf0058ad237a7e499878b6a6"},{"author":{"_account_id":13609,"name":"Pavel Boldin","email":"pboldin@mirantis.com","username":"pboldin"},"change_message_id":"129d956d8ce58e4e2af9a7d98b3dfec54db49c22","unresolved":false,"context_lines":[{"line_number":463,"context_line":"        self._test_atomic_action_timer("},{"line_number":464,"context_line":"            neutron_scenario.atomic_actions(), \"neutron.create_pool\")"},{"line_number":465,"context_line":""},{"line_number":466,"context_line":"        mock_clients.return_value.create_pool.reset_mock()"},{"line_number":467,"context_line":""},{"line_number":468,"context_line":"        # Random pool name"},{"line_number":469,"context_line":"        pool_data \u003d {}"}],"source_content_type":"text/x-python","patch_set":16,"id":"7a016987_9d733b80","line":466,"updated":"2015-05-29 10:59:10.000000000","message":"Please split this in two functions:\n test__create_pool_explicit\n test__create_pool_random","commit_id":"801ae9ab96256a07438fabfacc5c62a285035fad"},{"author":{"_account_id":13609,"name":"Pavel Boldin","email":"pboldin@mirantis.com","username":"pboldin"},"change_message_id":"6181b6102913391742f36b2af4229a9f40839559","unresolved":false,"context_lines":[{"line_number":463,"context_line":"        self._test_atomic_action_timer("},{"line_number":464,"context_line":"            neutron_scenario.atomic_actions(), \"neutron.create_pool\")"},{"line_number":465,"context_line":""},{"line_number":466,"context_line":"        mock_clients.return_value.create_pool.reset_mock()"},{"line_number":467,"context_line":""},{"line_number":468,"context_line":"        # Random pool name"},{"line_number":469,"context_line":"        pool_data \u003d {}"}],"source_content_type":"text/x-python","patch_set":16,"id":"7a016987_54b8f810","line":466,"in_reply_to":"7a016987_437ba0be","updated":"2015-05-29 13:13:21.000000000","message":"Yes, but generally, unit-tests are to test *exactly one code path* per unit-test.","commit_id":"801ae9ab96256a07438fabfacc5c62a285035fad"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"1a1320e86f9f9fde4e7ff38787919fcef73bd39c","unresolved":false,"context_lines":[{"line_number":463,"context_line":"        self._test_atomic_action_timer("},{"line_number":464,"context_line":"            neutron_scenario.atomic_actions(), \"neutron.create_pool\")"},{"line_number":465,"context_line":""},{"line_number":466,"context_line":"        mock_clients.return_value.create_pool.reset_mock()"},{"line_number":467,"context_line":""},{"line_number":468,"context_line":"        # Random pool name"},{"line_number":469,"context_line":"        pool_data \u003d {}"}],"source_content_type":"text/x-python","patch_set":16,"id":"7a016987_b4f96c82","line":466,"in_reply_to":"7a016987_54b8f810","updated":"2015-05-29 13:25:20.000000000","message":"One case - one test. +1 for splitting.","commit_id":"801ae9ab96256a07438fabfacc5c62a285035fad"},{"author":{"_account_id":14298,"name":"maplelabs","email":"maniram.sekaran@maplelabs.com","username":"maplelabs"},"change_message_id":"c9d063c56c685be5549e82d10894697982301291","unresolved":false,"context_lines":[{"line_number":463,"context_line":"        self._test_atomic_action_timer("},{"line_number":464,"context_line":"            neutron_scenario.atomic_actions(), \"neutron.create_pool\")"},{"line_number":465,"context_line":""},{"line_number":466,"context_line":"        mock_clients.return_value.create_pool.reset_mock()"},{"line_number":467,"context_line":""},{"line_number":468,"context_line":"        # Random pool name"},{"line_number":469,"context_line":"        pool_data \u003d {}"}],"source_content_type":"text/x-python","patch_set":16,"id":"7a016987_437ba0be","line":466,"in_reply_to":"7a016987_9d733b80","updated":"2015-05-29 12:10:41.000000000","message":"In methods like create_and_list_networks, both explicit and random are done in a single one.","commit_id":"801ae9ab96256a07438fabfacc5c62a285035fad"},{"author":{"_account_id":13609,"name":"Pavel Boldin","email":"pboldin@mirantis.com","username":"pboldin"},"change_message_id":"129d956d8ce58e4e2af9a7d98b3dfec54db49c22","unresolved":false,"context_lines":[{"line_number":474,"context_line":"            expected_pool_data)"},{"line_number":475,"context_line":""},{"line_number":476,"context_line":"    @mock.patch(NEUTRON_UTILS + \"NeutronScenario.clients\")"},{"line_number":477,"context_line":"    def test_list_pools(self, mock_clients):"},{"line_number":478,"context_line":"        scenario \u003d utils.NeutronScenario()"},{"line_number":479,"context_line":"        mock_clients.return_value.create_pool.return_value \u003d ()"},{"line_number":480,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"7a016987_3d6687bb","line":477,"updated":"2015-05-29 10:59:10.000000000","message":"Please rename to `test__list_pools`","commit_id":"801ae9ab96256a07438fabfacc5c62a285035fad"},{"author":{"_account_id":13609,"name":"Pavel Boldin","email":"pboldin@mirantis.com","username":"pboldin"},"change_message_id":"6181b6102913391742f36b2af4229a9f40839559","unresolved":false,"context_lines":[{"line_number":474,"context_line":"            expected_pool_data)"},{"line_number":475,"context_line":""},{"line_number":476,"context_line":"    @mock.patch(NEUTRON_UTILS + \"NeutronScenario.clients\")"},{"line_number":477,"context_line":"    def test_list_pools(self, mock_clients):"},{"line_number":478,"context_line":"        scenario \u003d utils.NeutronScenario()"},{"line_number":479,"context_line":"        mock_clients.return_value.create_pool.return_value \u003d ()"},{"line_number":480,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"7a016987_143de08e","line":477,"in_reply_to":"7a016987_03500831","updated":"2015-05-29 13:13:21.000000000","message":"rally$ git grep \u0027test__\u0027  | wc -l\n266","commit_id":"801ae9ab96256a07438fabfacc5c62a285035fad"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"1a1320e86f9f9fde4e7ff38787919fcef73bd39c","unresolved":false,"context_lines":[{"line_number":474,"context_line":"            expected_pool_data)"},{"line_number":475,"context_line":""},{"line_number":476,"context_line":"    @mock.patch(NEUTRON_UTILS + \"NeutronScenario.clients\")"},{"line_number":477,"context_line":"    def test_list_pools(self, mock_clients):"},{"line_number":478,"context_line":"        scenario \u003d utils.NeutronScenario()"},{"line_number":479,"context_line":"        mock_clients.return_value.create_pool.return_value \u003d ()"},{"line_number":480,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"7a016987_74d8941e","line":477,"in_reply_to":"7a016987_143de08e","updated":"2015-05-29 13:25:20.000000000","message":"Pavel is right.\n\nIt is not two underscores. It is Prefix \"test_\" with name of method which is \"_list_pools\".","commit_id":"801ae9ab96256a07438fabfacc5c62a285035fad"},{"author":{"_account_id":14298,"name":"maplelabs","email":"maniram.sekaran@maplelabs.com","username":"maplelabs"},"change_message_id":"c9d063c56c685be5549e82d10894697982301291","unresolved":false,"context_lines":[{"line_number":474,"context_line":"            expected_pool_data)"},{"line_number":475,"context_line":""},{"line_number":476,"context_line":"    @mock.patch(NEUTRON_UTILS + \"NeutronScenario.clients\")"},{"line_number":477,"context_line":"    def test_list_pools(self, mock_clients):"},{"line_number":478,"context_line":"        scenario \u003d utils.NeutronScenario()"},{"line_number":479,"context_line":"        mock_clients.return_value.create_pool.return_value \u003d ()"},{"line_number":480,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"7a016987_03500831","line":477,"in_reply_to":"7a016987_3d6687bb","updated":"2015-05-29 12:10:41.000000000","message":"I have not seen any unit tests with a double underscore (\"__\")","commit_id":"801ae9ab96256a07438fabfacc5c62a285035fad"},{"author":{"_account_id":8507,"name":"Mikhail Dubov","email":"mdubov@mirantis.com","username":"msdubov"},"change_message_id":"f6a62f27067ee514805ab68e4754ecf36c4ee7c5","unresolved":false,"context_lines":[{"line_number":446,"context_line":"                \"id\": \"pool-id\""},{"line_number":447,"context_line":"            }"},{"line_number":448,"context_line":"        }"},{"line_number":449,"context_line":"        mock_clients.return_value.create_pool.return_value \u003d pool"},{"line_number":450,"context_line":""},{"line_number":451,"context_line":"        # Pool name is specified"},{"line_number":452,"context_line":"        pool_data \u003d {\"name\": explicit_name, \"lb_method\": lb_method,"}],"source_content_type":"text/x-python","patch_set":21,"id":"5afe65bd_0b7e0a19","line":449,"updated":"2015-06-04 01:34:05.000000000","message":"This already looks a bit too complicated, please split:\n\nneutron_mock \u003d mock_clients.return_value\nneutron_mock.create_pool.return_value \u003d pool","commit_id":"1bd6e7e9d26d698eb8ae409ddd89f7352f44cbd8"},{"author":{"_account_id":8507,"name":"Mikhail Dubov","email":"mdubov@mirantis.com","username":"msdubov"},"change_message_id":"f6a62f27067ee514805ab68e4754ecf36c4ee7c5","unresolved":false,"context_lines":[{"line_number":455,"context_line":""},{"line_number":456,"context_line":"        neutron_scenario._create_pool(pool_create_args\u003dpool_data,"},{"line_number":457,"context_line":"                                      subnet_id\u003dsubnet)"},{"line_number":458,"context_line":"        mock_clients.return_value.create_pool.assert_called_once_with("},{"line_number":459,"context_line":"            expected_pool_data)"},{"line_number":460,"context_line":"        self._test_atomic_action_timer("},{"line_number":461,"context_line":"            neutron_scenario.atomic_actions(), \"neutron.create_pool\")"}],"source_content_type":"text/x-python","patch_set":21,"id":"5afe65bd_ab725647","line":458,"updated":"2015-06-04 01:34:05.000000000","message":"neutron_mock can be reused here as well","commit_id":"1bd6e7e9d26d698eb8ae409ddd89f7352f44cbd8"},{"author":{"_account_id":8507,"name":"Mikhail Dubov","email":"mdubov@mirantis.com","username":"msdubov"},"change_message_id":"f6a62f27067ee514805ab68e4754ecf36c4ee7c5","unresolved":false,"context_lines":[{"line_number":472,"context_line":"                \"id\": \"pool-id\""},{"line_number":473,"context_line":"            }"},{"line_number":474,"context_line":"        }"},{"line_number":475,"context_line":"        mock_clients.return_value.create_pool.return_value \u003d pool"},{"line_number":476,"context_line":"        mock_random_name.return_value \u003d random_name"},{"line_number":477,"context_line":"        # Random pool name"},{"line_number":478,"context_line":"        pool_data \u003d {}"}],"source_content_type":"text/x-python","patch_set":21,"id":"5afe65bd_6b933e50","line":475,"updated":"2015-06-04 01:34:05.000000000","message":"Same here and in analogous places below","commit_id":"1bd6e7e9d26d698eb8ae409ddd89f7352f44cbd8"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"d0c713279a8126e7a9d883d6d892cbc8832da82d","unresolved":false,"context_lines":[{"line_number":446,"context_line":"                \"id\": \"pool-id\""},{"line_number":447,"context_line":"            }"},{"line_number":448,"context_line":"        }"},{"line_number":449,"context_line":"        neutron_mock \u003d mock_clients.return_value"},{"line_number":450,"context_line":"        neutron_mock.create_pool.return_value \u003d pool"},{"line_number":451,"context_line":"        # Pool name is specified"},{"line_number":452,"context_line":"        pool_data \u003d {\"name\": explicit_name, \"lb_method\": lb_method,"}],"source_content_type":"text/x-python","patch_set":24,"id":"3afb71cf_a7c21d83","line":449,"updated":"2015-06-11 01:08:24.000000000","message":"Don\u0027t need to return_value here, just use:\n\nmock_clients().create_pool.return_value \u003d pool\nmock_clients().create_pool.assert_called_once_with(expected_pool_data)","commit_id":"7e91461cb084be790a18e08648afbb479f1fdcc8"},{"author":{"_account_id":13609,"name":"Pavel Boldin","email":"pboldin@mirantis.com","username":"pboldin"},"change_message_id":"95b4e465355aeb4c906cccb5c878f62386bfbf50","unresolved":false,"context_lines":[{"line_number":446,"context_line":"                \"id\": \"pool-id\""},{"line_number":447,"context_line":"            }"},{"line_number":448,"context_line":"        }"},{"line_number":449,"context_line":"        neutron_mock \u003d mock_clients.return_value"},{"line_number":450,"context_line":"        neutron_mock.create_pool.return_value \u003d pool"},{"line_number":451,"context_line":"        # Pool name is specified"},{"line_number":452,"context_line":"        pool_data \u003d {\"name\": explicit_name, \"lb_method\": lb_method,"}],"source_content_type":"text/x-python","patch_set":24,"id":"3afb71cf_c723d954","line":449,"in_reply_to":"3afb71cf_a7c21d83","updated":"2015-06-11 01:12:53.000000000","message":"Never call a mock from unit-test. https://github.com/paboldin/python-samples/blob/master/why-not-call-mock-during-test-setup.py\n\nActually, there was a `ClientsTestCase\u0027 unit-testing base class merged. Use it instead: https://review.openstack.org/#/c/188554/","commit_id":"7e91461cb084be790a18e08648afbb479f1fdcc8"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"7daba7ba95c59156e0b03495d6d693a1e3f782dd","unresolved":false,"context_lines":[{"line_number":446,"context_line":"                \"id\": \"pool-id\""},{"line_number":447,"context_line":"            }"},{"line_number":448,"context_line":"        }"},{"line_number":449,"context_line":"        neutron_mock \u003d mock_clients.return_value"},{"line_number":450,"context_line":"        neutron_mock.create_pool.return_value \u003d pool"},{"line_number":451,"context_line":"        # Pool name is specified"},{"line_number":452,"context_line":"        pool_data \u003d {\"name\": explicit_name, \"lb_method\": lb_method,"}],"source_content_type":"text/x-python","patch_set":24,"id":"3afb71cf_c7d4f9ec","line":449,"in_reply_to":"3afb71cf_c723d954","updated":"2015-06-11 01:18:59.000000000","message":"Oh, agree, thanks for remind","commit_id":"7e91461cb084be790a18e08648afbb479f1fdcc8"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"d0c713279a8126e7a9d883d6d892cbc8832da82d","unresolved":false,"context_lines":[{"line_number":471,"context_line":"                \"id\": \"pool-id\""},{"line_number":472,"context_line":"            }"},{"line_number":473,"context_line":"        }"},{"line_number":474,"context_line":"        neutron_mock \u003d mock_clients.return_value"},{"line_number":475,"context_line":"        neutron_mock.create_pool.return_value \u003d pool"},{"line_number":476,"context_line":"        mock_random_name.return_value \u003d random_name"},{"line_number":477,"context_line":"        # Random pool name"}],"source_content_type":"text/x-python","patch_set":24,"id":"3afb71cf_87bde103","line":474,"updated":"2015-06-11 01:08:24.000000000","message":"same here","commit_id":"7e91461cb084be790a18e08648afbb479f1fdcc8"},{"author":{"_account_id":13609,"name":"Pavel Boldin","email":"pboldin@mirantis.com","username":"pboldin"},"change_message_id":"95b4e465355aeb4c906cccb5c878f62386bfbf50","unresolved":false,"context_lines":[{"line_number":471,"context_line":"                \"id\": \"pool-id\""},{"line_number":472,"context_line":"            }"},{"line_number":473,"context_line":"        }"},{"line_number":474,"context_line":"        neutron_mock \u003d mock_clients.return_value"},{"line_number":475,"context_line":"        neutron_mock.create_pool.return_value \u003d pool"},{"line_number":476,"context_line":"        mock_random_name.return_value \u003d random_name"},{"line_number":477,"context_line":"        # Random pool name"}],"source_content_type":"text/x-python","patch_set":24,"id":"3afb71cf_a71e9d09","line":474,"in_reply_to":"3afb71cf_87bde103","updated":"2015-06-11 01:12:53.000000000","message":"Never call a mocked object in the unit-test.","commit_id":"7e91461cb084be790a18e08648afbb479f1fdcc8"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"d0c713279a8126e7a9d883d6d892cbc8832da82d","unresolved":false,"context_lines":[{"line_number":487,"context_line":"    @mock.patch(NEUTRON_UTILS + \"NeutronScenario.clients\")"},{"line_number":488,"context_line":"    def test__list_pools(self, mock_clients):"},{"line_number":489,"context_line":"        scenario \u003d utils.NeutronScenario()"},{"line_number":490,"context_line":"        neutron_mock \u003d mock_clients.return_value"},{"line_number":491,"context_line":"        neutron_mock.list_pools.return_value \u003d ()"},{"line_number":492,"context_line":"        scenario._list_pools()"},{"line_number":493,"context_line":"        neutron_mock.list_pools.assert_called_once_with()"}],"source_content_type":"text/x-python","patch_set":24,"id":"3afb71cf_67b8a511","line":490,"updated":"2015-06-11 01:08:24.000000000","message":"same here.","commit_id":"7e91461cb084be790a18e08648afbb479f1fdcc8"},{"author":{"_account_id":13609,"name":"Pavel Boldin","email":"pboldin@mirantis.com","username":"pboldin"},"change_message_id":"95b4e465355aeb4c906cccb5c878f62386bfbf50","unresolved":false,"context_lines":[{"line_number":487,"context_line":"    @mock.patch(NEUTRON_UTILS + \"NeutronScenario.clients\")"},{"line_number":488,"context_line":"    def test__list_pools(self, mock_clients):"},{"line_number":489,"context_line":"        scenario \u003d utils.NeutronScenario()"},{"line_number":490,"context_line":"        neutron_mock \u003d mock_clients.return_value"},{"line_number":491,"context_line":"        neutron_mock.list_pools.return_value \u003d ()"},{"line_number":492,"context_line":"        scenario._list_pools()"},{"line_number":493,"context_line":"        neutron_mock.list_pools.assert_called_once_with()"}],"source_content_type":"text/x-python","patch_set":24,"id":"3afb71cf_87196124","line":490,"in_reply_to":"3afb71cf_67b8a511","updated":"2015-06-11 01:12:53.000000000","message":"Never call a mocked object in the unit-test.","commit_id":"7e91461cb084be790a18e08648afbb479f1fdcc8"}]}
