)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":13609,"name":"Pavel Boldin","email":"pboldin@mirantis.com","username":"pboldin"},"change_message_id":"3cb5485cf46b134a671a7a0104aa9c8713cda124","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[Fuel] Environments scenarios"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Added create_list_and_delete_environmens scenario"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Co-Authored-By: Alexander Maretskiy \u003camaretskiy@mirantis.com\u003e"},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"5afe65bd_00e36534","line":9,"updated":"2015-06-04 18:45:06.000000000","message":"Use just \u0027add\u0027","commit_id":"4bb5eb6f13a78d981614d9b497aed02088c9cbdc"},{"author":{"_account_id":9601,"name":"Oleh Anufriiev","email":"oanufriev@mirantis.com","username":"oanufriev"},"change_message_id":"48b23f4714b1ff75767bd6284cc4febc166436a1","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[Fuel] Environments scenarios"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Added create_list_and_delete_environmens scenario"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Co-Authored-By: Alexander Maretskiy \u003camaretskiy@mirantis.com\u003e"},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"3afb71cf_7e1f6e6c","line":9,"in_reply_to":"5afe65bd_00e36534","updated":"2015-06-09 11:51:26.000000000","message":"Done","commit_id":"4bb5eb6f13a78d981614d9b497aed02088c9cbdc"},{"author":{"_account_id":13609,"name":"Pavel Boldin","email":"pboldin@mirantis.com","username":"pboldin"},"change_message_id":"ce1abdf33f781460b961bbb95ff14c466f5dee73","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[Fuel] Environments scenarios"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add create_list_and_delete_environmens scenario"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Co-Authored-By: Alexander Maretskiy \u003camaretskiy@mirantis.com\u003e"},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"3afb71cf_258efa27","line":9,"updated":"2015-06-11 21:15:23.000000000","message":"environments\n\nbtw, you can add a dot at the end of the sentence in the long commit message (but not in the short)","commit_id":"63a7d4562e97685ff3b26276b6d85efbf11c6158"},{"author":{"_account_id":9601,"name":"Oleh Anufriiev","email":"oanufriev@mirantis.com","username":"oanufriev"},"change_message_id":"46eb3f43931340768e2e9b38ac84fb534d6d5105","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[Fuel] Environments scenarios"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add create_list_and_delete_environmens scenario"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Co-Authored-By: Alexander Maretskiy \u003camaretskiy@mirantis.com\u003e"},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"1af86dd1_f7809148","line":9,"in_reply_to":"3afb71cf_258efa27","updated":"2015-06-12 15:03:46.000000000","message":"Done","commit_id":"63a7d4562e97685ff3b26276b6d85efbf11c6158"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"293974de87e8a70f34b5574a958c678fc1c14b91","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"* add create_and_delete_environments scenario"},{"line_number":10,"context_line":"* add create_and_list_environments scenario"},{"line_number":11,"context_line":"* add cleanup for environments"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Co-Authored-By: Alexander Maretskiy \u003camaretskiy@mirantis.com\u003e"},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":14,"id":"ba3cc151_4524b50b","line":11,"updated":"2015-07-09 06:05:01.000000000","message":"Also please document changes in retry function.","commit_id":"099ba248f1fbe0f7e46cb735c07cbe5c8f01e503"},{"author":{"_account_id":9601,"name":"Oleh Anufriiev","email":"oanufriev@mirantis.com","username":"oanufriev"},"change_message_id":"222f7efea7079d5f64d976d1be3c94888d609a00","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"* add create_and_delete_environments scenario"},{"line_number":10,"context_line":"* add create_and_list_environments scenario"},{"line_number":11,"context_line":"* add cleanup for environments"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Co-Authored-By: Alexander Maretskiy \u003camaretskiy@mirantis.com\u003e"},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":14,"id":"ba3cc151_91a88d8d","line":11,"in_reply_to":"ba3cc151_4524b50b","updated":"2015-07-09 21:40:05.000000000","message":"Done","commit_id":"099ba248f1fbe0f7e46cb735c07cbe5c8f01e503"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"b19cc261f762fb683ea82bb56d8234d4f2042912","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[Fuel] Environments scenarios"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"* add create_and_delete_environments scenario"},{"line_number":10,"context_line":"* add create_and_list_environments scenario"},{"line_number":11,"context_line":"* add cleanup for environments"},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":23,"id":"1a4dcd0f_c976ff3d","line":9,"updated":"2015-08-11 09:57:34.000000000","message":"s/_environments/_environment/","commit_id":"88ef81f6a3fb36604d65aa9797930ce6ea60db79"},{"author":{"_account_id":9601,"name":"Oleh Anufriiev","email":"oanufriev@mirantis.com","username":"oanufriev"},"change_message_id":"8643ccdc6334f9f7cf0e30ec6657c41c9c123206","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[Fuel] Environments scenarios"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"* add create_and_delete_environments scenario"},{"line_number":10,"context_line":"* add create_and_list_environments scenario"},{"line_number":11,"context_line":"* add cleanup for environments"},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":23,"id":"1a4dcd0f_8dbda4d9","line":9,"in_reply_to":"1a4dcd0f_c976ff3d","updated":"2015-08-14 12:43:43.000000000","message":"Done","commit_id":"88ef81f6a3fb36604d65aa9797930ce6ea60db79"}],"rally/benchmark/context/cleanup/resources.py":[{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"daa9ba7d1ef5a2e2dcaed082a365c4c1931634e8","unresolved":false,"context_lines":[{"line_number":496,"context_line":""},{"line_number":497,"context_line":"    def list(self):"},{"line_number":498,"context_line":"        return [env for env in self._manager().get_all() if env["},{"line_number":499,"context_line":"            \"name\"].startswith(sc_base.Scenario.RESOURCE_NAME_PREFIX)]"},{"line_number":500,"context_line":""},{"line_number":501,"context_line":"    def delete(self):"},{"line_number":502,"context_line":"        self._manager().delete_by_id(self.id())"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a016987_911fbb6b","line":499,"updated":"2015-05-19 14:52:38.000000000","message":"sc_base.Scenario.RESOURCE_NAME_PREFIX is \"\" so this filter has no sense","commit_id":"6bde2eaaa1f407959ca7ff9322b709a8d76f5639"}],"rally/benchmark/scenarios/fuel/utils.py":[{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"daa9ba7d1ef5a2e2dcaed082a365c4c1931634e8","unresolved":false,"context_lines":[{"line_number":58,"context_line":"class FuelScenario(base.Scenario):"},{"line_number":59,"context_line":"    \"\"\"Base class for Fuel scenarios.\"\"\""},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    def get_env_id_by_name(self, name):"},{"line_number":62,"context_line":"        enves \u003d map(lambda x: {\"id\": x[\"id\"], \"name\": x[\"name\"]})"},{"line_number":63,"context_line":"        for env in enves:"},{"line_number":64,"context_line":"            if env[\"name\"] \u003d\u003d name:"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a016987_6cfc6472","line":61,"updated":"2015-05-19 14:52:38.000000000","message":"I guess WIP is here","commit_id":"6bde2eaaa1f407959ca7ff9322b709a8d76f5639"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"daa9ba7d1ef5a2e2dcaed082a365c4c1931634e8","unresolved":false,"context_lines":[{"line_number":74,"context_line":"                            network_provider\u003d\"neutron\","},{"line_number":75,"context_line":"                            deployment_mode\u003d\"ha_compact\","},{"line_number":76,"context_line":"                            net_segment_type\u003d\"vlan\"):"},{"line_number":77,"context_line":"        name \u003d name or self._generate_random_name()"},{"line_number":78,"context_line":"        env \u003d self.admin_clients(\"fuel\").environment.create("},{"line_number":79,"context_line":"            name, release_id, network_provider, deployment_mode,"},{"line_number":80,"context_line":"            net_segment_type)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a016987_8c19e0d9","line":77,"updated":"2015-05-19 14:52:38.000000000","message":"you should use scenarios.base.Scenario.RESOURCE_NAME_PREFIX here (since you use this filter in cleanup)","commit_id":"6bde2eaaa1f407959ca7ff9322b709a8d76f5639"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"daa9ba7d1ef5a2e2dcaed082a365c4c1931634e8","unresolved":false,"context_lines":[{"line_number":78,"context_line":"        env \u003d self.admin_clients(\"fuel\").environment.create("},{"line_number":79,"context_line":"            name, release_id, network_provider, deployment_mode,"},{"line_number":80,"context_line":"            net_segment_type)"},{"line_number":81,"context_line":"        if env:"},{"line_number":82,"context_line":"            return env[\"id\"]"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"    @base.atomic_action_timer(\"fuel.delete_environment\")"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a016987_8c67a04c","line":81,"updated":"2015-05-19 14:52:38.000000000","message":"I think we should have some exception raised if env is not created, so this can be KeyError - just `return env[\"id\"]\u0027, without checking if env is casted to True","commit_id":"6bde2eaaa1f407959ca7ff9322b709a8d76f5639"}],"rally/common/utils.py":[{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"13c225c5a29bb66531f49ad3f8ddd9e64fa9fe9a","unresolved":false,"context_lines":[{"line_number":379,"context_line":"    :returns: Result of func(*args, **kwargs)"},{"line_number":380,"context_line":"    \"\"\""},{"line_number":381,"context_line":""},{"line_number":382,"context_line":"    catch_exception \u003d kwargs.get(\"catch_exception\", Exception)"},{"line_number":383,"context_line":""},{"line_number":384,"context_line":"    for i in range(times):"},{"line_number":385,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":14,"id":"ba3cc151_25441148","line":382,"updated":"2015-07-09 06:04:00.000000000","message":"Lets check that catch_exception is exactly of the class(subclass) \u0027Exception\u0027.","commit_id":"099ba248f1fbe0f7e46cb735c07cbe5c8f01e503"},{"author":{"_account_id":9601,"name":"Oleh Anufriiev","email":"oanufriev@mirantis.com","username":"oanufriev"},"change_message_id":"222f7efea7079d5f64d976d1be3c94888d609a00","unresolved":false,"context_lines":[{"line_number":379,"context_line":"    :returns: Result of func(*args, **kwargs)"},{"line_number":380,"context_line":"    \"\"\""},{"line_number":381,"context_line":""},{"line_number":382,"context_line":"    catch_exception \u003d kwargs.get(\"catch_exception\", Exception)"},{"line_number":383,"context_line":""},{"line_number":384,"context_line":"    for i in range(times):"},{"line_number":385,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":14,"id":"ba3cc151_71ace9ec","line":382,"in_reply_to":"ba3cc151_25441148","updated":"2015-07-09 21:40:05.000000000","message":"There are BaseException and SystemExit which are not subclasses of Exception","commit_id":"099ba248f1fbe0f7e46cb735c07cbe5c8f01e503"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"13c225c5a29bb66531f49ad3f8ddd9e64fa9fe9a","unresolved":false,"context_lines":[{"line_number":386,"context_line":"            return func(*args, **kwargs)"},{"line_number":387,"context_line":"        except catch_exception:"},{"line_number":388,"context_line":"            if i \u003d\u003d times - 1:"},{"line_number":389,"context_line":"                raise Exception()"},{"line_number":390,"context_line":""},{"line_number":391,"context_line":""},{"line_number":392,"context_line":"def iterate_per_tenants(users):"}],"source_content_type":"text/x-python","patch_set":14,"id":"ba3cc151_e5494961","line":389,"updated":"2015-07-09 06:04:00.000000000","message":"I think its better to throw catch_exception here.","commit_id":"099ba248f1fbe0f7e46cb735c07cbe5c8f01e503"},{"author":{"_account_id":9601,"name":"Oleh Anufriiev","email":"oanufriev@mirantis.com","username":"oanufriev"},"change_message_id":"222f7efea7079d5f64d976d1be3c94888d609a00","unresolved":false,"context_lines":[{"line_number":386,"context_line":"            return func(*args, **kwargs)"},{"line_number":387,"context_line":"        except catch_exception:"},{"line_number":388,"context_line":"            if i \u003d\u003d times - 1:"},{"line_number":389,"context_line":"                raise Exception()"},{"line_number":390,"context_line":""},{"line_number":391,"context_line":""},{"line_number":392,"context_line":"def iterate_per_tenants(users):"}],"source_content_type":"text/x-python","patch_set":14,"id":"ba3cc151_f186b963","line":389,"in_reply_to":"ba3cc151_e5494961","updated":"2015-07-09 21:40:05.000000000","message":"There was an Exception here. It works fine.\nThis change gives an ability to catch not only Exception subclasses, but more or less specific exceptions","commit_id":"099ba248f1fbe0f7e46cb735c07cbe5c8f01e503"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"2f8575fcd7d6b001b159a11e852742ea5fd7f073","unresolved":false,"context_lines":[{"line_number":386,"context_line":"            return func(*args, **kwargs)"},{"line_number":387,"context_line":"        except catch_exception:"},{"line_number":388,"context_line":"            if i \u003d\u003d times - 1:"},{"line_number":389,"context_line":"                raise Exception()"},{"line_number":390,"context_line":""},{"line_number":391,"context_line":""},{"line_number":392,"context_line":"def iterate_per_tenants(users):"}],"source_content_type":"text/x-python","patch_set":16,"id":"ba3cc151_e7fb427a","line":389,"updated":"2015-07-10 11:54:25.000000000","message":"Okey, lets add message to the Exception that told to us \"This Exception is raised because of....\" Without it would be hard t read logs.","commit_id":"6047efadcc634cce304aa865dd8925f3a7aee19c"},{"author":{"_account_id":9601,"name":"Oleh Anufriiev","email":"oanufriev@mirantis.com","username":"oanufriev"},"change_message_id":"a5988282c739f913da804a09db6c7303c2841dcb","unresolved":false,"context_lines":[{"line_number":386,"context_line":"            return func(*args, **kwargs)"},{"line_number":387,"context_line":"        except catch_exception:"},{"line_number":388,"context_line":"            if i \u003d\u003d times - 1:"},{"line_number":389,"context_line":"                raise Exception()"},{"line_number":390,"context_line":""},{"line_number":391,"context_line":""},{"line_number":392,"context_line":"def iterate_per_tenants(users):"}],"source_content_type":"text/x-python","patch_set":16,"id":"ba3cc151_4de7ac46","line":389,"in_reply_to":"ba3cc151_e7fb427a","updated":"2015-07-10 13:25:24.000000000","message":"IMO, that\u0027s redundand.","commit_id":"6047efadcc634cce304aa865dd8925f3a7aee19c"}],"rally/plugins/openstack/context/cleanup/resources.py":[{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"6fe9b5efcb3c988c63bc72748ea3e698016aae7e","unresolved":false,"context_lines":[{"line_number":493,"context_line":"        return self.raw_resource[\"id\"]"},{"line_number":494,"context_line":""},{"line_number":495,"context_line":"    def list(self):"},{"line_number":496,"context_line":"        return self._manager().list_environments()"},{"line_number":497,"context_line":""},{"line_number":498,"context_line":"    def delete(self):"},{"line_number":499,"context_line":"        self._manager().delete_environment(self.id())"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a016987_8c85eb08","line":496,"updated":"2015-05-25 15:24:40.000000000","message":"Having `list()\u0027 instead of `list_environments\u0027 you can get rid of this method at all\n\nhttps://github.com/openstack/rally/blob/master/rally/plugins/openstack/context/cleanup/base.py#L106","commit_id":"362530a7859ac03f264c03f7d0ca83e0a392db47"},{"author":{"_account_id":9601,"name":"Oleh Anufriiev","email":"oanufriev@mirantis.com","username":"oanufriev"},"change_message_id":"117b0db7e9babd5e9318e2e9557a64bd35a01e7d","unresolved":false,"context_lines":[{"line_number":493,"context_line":"        return self.raw_resource[\"id\"]"},{"line_number":494,"context_line":""},{"line_number":495,"context_line":"    def list(self):"},{"line_number":496,"context_line":"        return self._manager().list_environments()"},{"line_number":497,"context_line":""},{"line_number":498,"context_line":"    def delete(self):"},{"line_number":499,"context_line":"        self._manager().delete_environment(self.id())"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a016987_172f863f","line":496,"in_reply_to":"7a016987_8c85eb08","updated":"2015-05-27 12:22:02.000000000","message":"Done","commit_id":"362530a7859ac03f264c03f7d0ca83e0a392db47"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"6fe9b5efcb3c988c63bc72748ea3e698016aae7e","unresolved":false,"context_lines":[{"line_number":496,"context_line":"        return self._manager().list_environments()"},{"line_number":497,"context_line":""},{"line_number":498,"context_line":"    def delete(self):"},{"line_number":499,"context_line":"        self._manager().delete_environment(self.id())"},{"line_number":500,"context_line":""},{"line_number":501,"context_line":"    def is_deleted(self):"},{"line_number":502,"context_line":"        return False if self._manager().get_environment(self.id()) else True"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a016987_4c78132c","line":499,"updated":"2015-05-25 15:24:40.000000000","message":"same here","commit_id":"362530a7859ac03f264c03f7d0ca83e0a392db47"},{"author":{"_account_id":9601,"name":"Oleh Anufriiev","email":"oanufriev@mirantis.com","username":"oanufriev"},"change_message_id":"117b0db7e9babd5e9318e2e9557a64bd35a01e7d","unresolved":false,"context_lines":[{"line_number":496,"context_line":"        return self._manager().list_environments()"},{"line_number":497,"context_line":""},{"line_number":498,"context_line":"    def delete(self):"},{"line_number":499,"context_line":"        self._manager().delete_environment(self.id())"},{"line_number":500,"context_line":""},{"line_number":501,"context_line":"    def is_deleted(self):"},{"line_number":502,"context_line":"        return False if self._manager().get_environment(self.id()) else True"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a016987_d728ce35","line":499,"in_reply_to":"7a016987_4c78132c","updated":"2015-05-27 12:22:02.000000000","message":"Done","commit_id":"362530a7859ac03f264c03f7d0ca83e0a392db47"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"d93905b6b96b92ae726e89533eb4273cf7233b94","unresolved":false,"context_lines":[{"line_number":499,"context_line":"        self._manager().delete_environment(self.id())"},{"line_number":500,"context_line":""},{"line_number":501,"context_line":"    def is_deleted(self):"},{"line_number":502,"context_line":"        return False if self._manager().get_environment(self.id()) else True"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a016987_61751bc9","line":502,"updated":"2015-05-25 15:19:52.000000000","message":"return not self._manager().get_environment(self.id())","commit_id":"362530a7859ac03f264c03f7d0ca83e0a392db47"},{"author":{"_account_id":9601,"name":"Oleh Anufriiev","email":"oanufriev@mirantis.com","username":"oanufriev"},"change_message_id":"117b0db7e9babd5e9318e2e9557a64bd35a01e7d","unresolved":false,"context_lines":[{"line_number":499,"context_line":"        self._manager().delete_environment(self.id())"},{"line_number":500,"context_line":""},{"line_number":501,"context_line":"    def is_deleted(self):"},{"line_number":502,"context_line":"        return False if self._manager().get_environment(self.id()) else True"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a016987_b7e79211","line":502,"in_reply_to":"7a016987_61751bc9","updated":"2015-05-27 12:22:02.000000000","message":"Done","commit_id":"362530a7859ac03f264c03f7d0ca83e0a392db47"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"13c225c5a29bb66531f49ad3f8ddd9e64fa9fe9a","unresolved":false,"context_lines":[{"line_number":511,"context_line":""},{"line_number":512,"context_line":"# FUEL"},{"line_number":513,"context_line":""},{"line_number":514,"context_line":"@base.resource(\"fuel\", \"environment\", order\u003d1300,"},{"line_number":515,"context_line":"               admin_required\u003dTrue, perform_for_admin_only\u003dTrue)"},{"line_number":516,"context_line":"class FuelEnvironment(base.ResourceManager):"},{"line_number":517,"context_line":"    \"\"\"Fuel environment."}],"source_content_type":"text/x-python","patch_set":14,"id":"ba3cc151_25e09128","line":514,"updated":"2015-07-09 06:04:00.000000000","message":"Lets move its to the proper place above the keystone. And please add order\u003dnext(_fuel_order) here","commit_id":"099ba248f1fbe0f7e46cb735c07cbe5c8f01e503"},{"author":{"_account_id":9601,"name":"Oleh Anufriiev","email":"oanufriev@mirantis.com","username":"oanufriev"},"change_message_id":"222f7efea7079d5f64d976d1be3c94888d609a00","unresolved":false,"context_lines":[{"line_number":511,"context_line":""},{"line_number":512,"context_line":"# FUEL"},{"line_number":513,"context_line":""},{"line_number":514,"context_line":"@base.resource(\"fuel\", \"environment\", order\u003d1300,"},{"line_number":515,"context_line":"               admin_required\u003dTrue, perform_for_admin_only\u003dTrue)"},{"line_number":516,"context_line":"class FuelEnvironment(base.ResourceManager):"},{"line_number":517,"context_line":"    \"\"\"Fuel environment."}],"source_content_type":"text/x-python","patch_set":14,"id":"ba3cc151_b1ca719e","line":514,"in_reply_to":"ba3cc151_25e09128","updated":"2015-07-09 21:40:05.000000000","message":"Done","commit_id":"099ba248f1fbe0f7e46cb735c07cbe5c8f01e503"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"b19cc261f762fb683ea82bb56d8234d4f2042912","unresolved":false,"context_lines":[{"line_number":477,"context_line":""},{"line_number":478,"context_line":"# FUEL"},{"line_number":479,"context_line":""},{"line_number":480,"context_line":"@base.resource(\"fuel\", \"environment\", order\u003d1300,"},{"line_number":481,"context_line":"               admin_required\u003dTrue, perform_for_admin_only\u003dTrue)"},{"line_number":482,"context_line":"class FuelEnvironment(base.ResourceManager):"},{"line_number":483,"context_line":"    \"\"\"Fuel environment."}],"source_content_type":"text/x-python","patch_set":23,"id":"1a4dcd0f_29c68349","line":480,"updated":"2015-08-11 09:57:34.000000000","message":"1300 matches ironic order","commit_id":"88ef81f6a3fb36604d65aa9797930ce6ea60db79"},{"author":{"_account_id":9601,"name":"Oleh Anufriiev","email":"oanufriev@mirantis.com","username":"oanufriev"},"change_message_id":"8643ccdc6334f9f7cf0e30ec6657c41c9c123206","unresolved":false,"context_lines":[{"line_number":477,"context_line":""},{"line_number":478,"context_line":"# FUEL"},{"line_number":479,"context_line":""},{"line_number":480,"context_line":"@base.resource(\"fuel\", \"environment\", order\u003d1300,"},{"line_number":481,"context_line":"               admin_required\u003dTrue, perform_for_admin_only\u003dTrue)"},{"line_number":482,"context_line":"class FuelEnvironment(base.ResourceManager):"},{"line_number":483,"context_line":"    \"\"\"Fuel environment."}],"source_content_type":"text/x-python","patch_set":23,"id":"1a4dcd0f_72611511","line":480,"in_reply_to":"1a4dcd0f_29c68349","updated":"2015-08-14 12:43:43.000000000","message":"Done","commit_id":"88ef81f6a3fb36604d65aa9797930ce6ea60db79"},{"author":{"_account_id":7369,"name":"Sergey Skripnick","email":"sskripnick@mirantis.com","username":"redixin"},"change_message_id":"deb0a9f8f8deea1496ddf103eac37708b6f6bf2b","unresolved":false,"context_lines":[{"line_number":501,"context_line":""},{"line_number":502,"context_line":"    def is_deleted(self):"},{"line_number":503,"context_line":"        return not self._manager().get(self.id())"},{"line_number":504,"context_line":""},{"line_number":505,"context_line":""},{"line_number":506,"context_line":"# KEYSTONE"},{"line_number":507,"context_line":""}],"source_content_type":"text/x-python","patch_set":34,"id":"da20952f_8d709509","line":504,"updated":"2015-09-07 10:40:48.000000000","message":"Here should be \"list\" method which return only resources with proper prefix","commit_id":"9dbecbe0e7cc2ab26122cd6dfc7808e2e636dd46"},{"author":{"_account_id":9601,"name":"Oleh Anufriiev","email":"oanufriev@mirantis.com","username":"oanufriev"},"change_message_id":"9f3b1ea551a48a44fcd4e0781d8648d1401d9535","unresolved":false,"context_lines":[{"line_number":501,"context_line":""},{"line_number":502,"context_line":"    def is_deleted(self):"},{"line_number":503,"context_line":"        return not self._manager().get(self.id())"},{"line_number":504,"context_line":""},{"line_number":505,"context_line":""},{"line_number":506,"context_line":"# KEYSTONE"},{"line_number":507,"context_line":""}],"source_content_type":"text/x-python","patch_set":34,"id":"da20952f_10a6de0e","line":504,"in_reply_to":"da20952f_8d709509","updated":"2015-09-07 11:07:12.000000000","message":"Done","commit_id":"9dbecbe0e7cc2ab26122cd6dfc7808e2e636dd46"}],"rally/plugins/openstack/scenarios/fuel/environments.py":[{"author":{"_account_id":7369,"name":"Sergey Skripnick","email":"sskripnick@mirantis.com","username":"redixin"},"change_message_id":"e244c17b46131f57edc439e561b937f3268da1ab","unresolved":false,"context_lines":[{"line_number":23,"context_line":"    @validation.required_clients(\"fuel\", admin\u003dTrue)"},{"line_number":24,"context_line":"    @validation.required_openstack(admin\u003dTrue)"},{"line_number":25,"context_line":"    @base.scenario()"},{"line_number":26,"context_line":"    def list_environments(self):"},{"line_number":27,"context_line":"        \"\"\"List Fuel environments.\"\"\""},{"line_number":28,"context_line":"        self._list_environments()"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a016987_2ce6f744","side":"PARENT","line":26,"updated":"2015-05-25 15:18:58.000000000","message":"So we don\u0027t need this scenario anymore?","commit_id":"e824908a716c8d89aba5be06ecb93c283fa2a495"},{"author":{"_account_id":9601,"name":"Oleh Anufriiev","email":"oanufriev@mirantis.com","username":"oanufriev"},"change_message_id":"117b0db7e9babd5e9318e2e9557a64bd35a01e7d","unresolved":false,"context_lines":[{"line_number":23,"context_line":"    @validation.required_clients(\"fuel\", admin\u003dTrue)"},{"line_number":24,"context_line":"    @validation.required_openstack(admin\u003dTrue)"},{"line_number":25,"context_line":"    @base.scenario()"},{"line_number":26,"context_line":"    def list_environments(self):"},{"line_number":27,"context_line":"        \"\"\"List Fuel environments.\"\"\""},{"line_number":28,"context_line":"        self._list_environments()"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a016987_57e29e30","side":"PARENT","line":26,"in_reply_to":"7a016987_2ce6f744","updated":"2015-05-27 12:22:02.000000000","message":"Looks like.... \nCause Boris","commit_id":"e824908a716c8d89aba5be06ecb93c283fa2a495"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"d93905b6b96b92ae726e89533eb4273cf7233b94","unresolved":false,"context_lines":[{"line_number":44,"context_line":"                                          net_segment_type\u003dnet_segment_type)"},{"line_number":45,"context_line":"        self._delete_environment(env_id, retries, retry_pause)"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    @validation.required_openstack(admin\u003dTrue)"},{"line_number":48,"context_line":"    @base.scenario(context\u003d{\"admin_cleanup\": [\"fuel\"]})"},{"line_number":49,"context_line":"    def create_and_list_environments(self, release_id\u003d1,"},{"line_number":50,"context_line":"                                     network_provider\u003d\"neutron\","}],"source_content_type":"text/x-python","patch_set":4,"id":"7a016987_697bc12a","line":47,"updated":"2015-05-25 15:19:52.000000000","message":"This validator seems to be missed:\n\n @validation.required_clients(\"fuel\", admin\u003dTrue)","commit_id":"362530a7859ac03f264c03f7d0ca83e0a392db47"},{"author":{"_account_id":9601,"name":"Oleh Anufriiev","email":"oanufriev@mirantis.com","username":"oanufriev"},"change_message_id":"117b0db7e9babd5e9318e2e9557a64bd35a01e7d","unresolved":false,"context_lines":[{"line_number":44,"context_line":"                                          net_segment_type\u003dnet_segment_type)"},{"line_number":45,"context_line":"        self._delete_environment(env_id, retries, retry_pause)"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    @validation.required_openstack(admin\u003dTrue)"},{"line_number":48,"context_line":"    @base.scenario(context\u003d{\"admin_cleanup\": [\"fuel\"]})"},{"line_number":49,"context_line":"    def create_and_list_environments(self, release_id\u003d1,"},{"line_number":50,"context_line":"                                     network_provider\u003d\"neutron\","}],"source_content_type":"text/x-python","patch_set":4,"id":"7a016987_373722b2","line":47,"in_reply_to":"7a016987_697bc12a","updated":"2015-05-27 12:22:02.000000000","message":"Done","commit_id":"362530a7859ac03f264c03f7d0ca83e0a392db47"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"5146e917a3f04a1d67ace311a5103675aa5b2990","unresolved":false,"context_lines":[{"line_number":23,"context_line":"    @validation.required_clients(\"fuel\", admin\u003dTrue)"},{"line_number":24,"context_line":"    @validation.required_openstack(admin\u003dTrue)"},{"line_number":25,"context_line":"    @base.scenario()"},{"line_number":26,"context_line":"    def list_environments(self):"},{"line_number":27,"context_line":"        \"\"\"List Fuel environments.\"\"\""},{"line_number":28,"context_line":"        self._list_environments()"}],"source_content_type":"text/x-python","patch_set":8,"id":"3afb71cf_713ca693","side":"PARENT","line":26,"updated":"2015-06-05 15:15:38.000000000","message":"Not sure that we do not need this scenario anymore - we can imagine use-cases when this scenario is helpful.\n\nLet\u0027s discuss that.","commit_id":"dd94907defad1234aad7140d5f6315b1143f81b9"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"5146e917a3f04a1d67ace311a5103675aa5b2990","unresolved":false,"context_lines":[{"line_number":35,"context_line":"        :param deployment_mode: deployment mode"},{"line_number":36,"context_line":"        :param net_segment_type: net segment type"},{"line_number":37,"context_line":"        :param retries: retries count on delete oprations"},{"line_number":38,"context_line":"        :param retry_pause: time to sleep between retries"},{"line_number":39,"context_line":"        \"\"\""},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"        env_id \u003d self._create_environment(release_id\u003drelease_id,"}],"source_content_type":"text/x-python","patch_set":8,"id":"3afb71cf_2b036175","line":38,"updated":"2015-06-05 15:15:38.000000000","message":"I would insist on more strict definitions, for example, this parameter is unclear:\n\n * probably we should specify number, but can it be float?\n * this is probably seconds, but we should guess that\n\nSo, in my opinion, better definition is:\n\n :param retry_pause: float seconds to sleep between retries\n\nSame for other parameters - it is desirable to mention type of expected value\n\nFor example, with `str\u0027:\n\n :param network_provider: str network provider","commit_id":"4bb5eb6f13a78d981614d9b497aed02088c9cbdc"},{"author":{"_account_id":9601,"name":"Oleh Anufriiev","email":"oanufriev@mirantis.com","username":"oanufriev"},"change_message_id":"48b23f4714b1ff75767bd6284cc4febc166436a1","unresolved":false,"context_lines":[{"line_number":35,"context_line":"        :param deployment_mode: deployment mode"},{"line_number":36,"context_line":"        :param net_segment_type: net segment type"},{"line_number":37,"context_line":"        :param retries: retries count on delete oprations"},{"line_number":38,"context_line":"        :param retry_pause: time to sleep between retries"},{"line_number":39,"context_line":"        \"\"\""},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"        env_id \u003d self._create_environment(release_id\u003drelease_id,"}],"source_content_type":"text/x-python","patch_set":8,"id":"3afb71cf_71c1df53","line":38,"in_reply_to":"3afb71cf_2b036175","updated":"2015-06-09 11:51:26.000000000","message":"Partially Done","commit_id":"4bb5eb6f13a78d981614d9b497aed02088c9cbdc"},{"author":{"_account_id":13609,"name":"Pavel Boldin","email":"pboldin@mirantis.com","username":"pboldin"},"change_message_id":"ce1abdf33f781460b961bbb95ff14c466f5dee73","unresolved":false,"context_lines":[{"line_number":23,"context_line":"    @validation.required_clients(\"fuel\", admin\u003dTrue)"},{"line_number":24,"context_line":"    @validation.required_openstack(admin\u003dTrue)"},{"line_number":25,"context_line":"    @base.scenario(context\u003d{\"admin_cleanup\": [\"fuel\"]})"},{"line_number":26,"context_line":"    def create_and_delete_environments(self, release_id\u003d1,"},{"line_number":27,"context_line":"                                       network_provider\u003d\"neutron\","},{"line_number":28,"context_line":"                                       deployment_mode\u003d\"ha_compact\","},{"line_number":29,"context_line":"                                       net_segment_type\u003d\"vlan\","}],"source_content_type":"text/x-python","patch_set":11,"id":"3afb71cf_e53902f4","line":26,"updated":"2015-06-11 21:15:23.000000000","message":"You only create one environment. Should this be named `create_and_delete_environment\u0027 instead?","commit_id":"63a7d4562e97685ff3b26276b6d85efbf11c6158"},{"author":{"_account_id":9601,"name":"Oleh Anufriiev","email":"oanufriev@mirantis.com","username":"oanufriev"},"change_message_id":"46eb3f43931340768e2e9b38ac84fb534d6d5105","unresolved":false,"context_lines":[{"line_number":23,"context_line":"    @validation.required_clients(\"fuel\", admin\u003dTrue)"},{"line_number":24,"context_line":"    @validation.required_openstack(admin\u003dTrue)"},{"line_number":25,"context_line":"    @base.scenario(context\u003d{\"admin_cleanup\": [\"fuel\"]})"},{"line_number":26,"context_line":"    def create_and_delete_environments(self, release_id\u003d1,"},{"line_number":27,"context_line":"                                       network_provider\u003d\"neutron\","},{"line_number":28,"context_line":"                                       deployment_mode\u003d\"ha_compact\","},{"line_number":29,"context_line":"                                       net_segment_type\u003d\"vlan\","}],"source_content_type":"text/x-python","patch_set":11,"id":"1af86dd1_77e4a13a","line":26,"in_reply_to":"3afb71cf_e53902f4","updated":"2015-06-12 15:03:46.000000000","message":"Done","commit_id":"63a7d4562e97685ff3b26276b6d85efbf11c6158"},{"author":{"_account_id":13609,"name":"Pavel Boldin","email":"pboldin@mirantis.com","username":"pboldin"},"change_message_id":"ce1abdf33f781460b961bbb95ff14c466f5dee73","unresolved":false,"context_lines":[{"line_number":28,"context_line":"                                       deployment_mode\u003d\"ha_compact\","},{"line_number":29,"context_line":"                                       net_segment_type\u003d\"vlan\","},{"line_number":30,"context_line":"                                       retries\u003d5, retry_pause\u003d1):"},{"line_number":31,"context_line":"        \"\"\"Create, list and delete Fuel environments"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"        :param release_id: release id"},{"line_number":34,"context_line":"        :param network_provider: network provider"}],"source_content_type":"text/x-python","patch_set":11,"id":"3afb71cf_304cf675","line":31,"updated":"2015-06-11 21:15:23.000000000","message":"Please add a dot at the end of sentence.","commit_id":"63a7d4562e97685ff3b26276b6d85efbf11c6158"},{"author":{"_account_id":9601,"name":"Oleh Anufriiev","email":"oanufriev@mirantis.com","username":"oanufriev"},"change_message_id":"46eb3f43931340768e2e9b38ac84fb534d6d5105","unresolved":false,"context_lines":[{"line_number":28,"context_line":"                                       deployment_mode\u003d\"ha_compact\","},{"line_number":29,"context_line":"                                       net_segment_type\u003d\"vlan\","},{"line_number":30,"context_line":"                                       retries\u003d5, retry_pause\u003d1):"},{"line_number":31,"context_line":"        \"\"\"Create, list and delete Fuel environments"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"        :param release_id: release id"},{"line_number":34,"context_line":"        :param network_provider: network provider"}],"source_content_type":"text/x-python","patch_set":11,"id":"1af86dd1_17ca0da2","line":31,"in_reply_to":"3afb71cf_304cf675","updated":"2015-06-12 15:03:46.000000000","message":"Done","commit_id":"63a7d4562e97685ff3b26276b6d85efbf11c6158"},{"author":{"_account_id":13609,"name":"Pavel Boldin","email":"pboldin@mirantis.com","username":"pboldin"},"change_message_id":"ce1abdf33f781460b961bbb95ff14c466f5dee73","unresolved":false,"context_lines":[{"line_number":30,"context_line":"                                       retries\u003d5, retry_pause\u003d1):"},{"line_number":31,"context_line":"        \"\"\"Create, list and delete Fuel environments"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"        :param release_id: release id"},{"line_number":34,"context_line":"        :param network_provider: network provider"},{"line_number":35,"context_line":"        :param deployment_mode: deployment mode"},{"line_number":36,"context_line":"        :param net_segment_type: net segment type"}],"source_content_type":"text/x-python","patch_set":11,"id":"3afb71cf_e59d820b","line":33,"updated":"2015-06-11 21:15:23.000000000","message":"Please provide defaults information in the docstring.","commit_id":"63a7d4562e97685ff3b26276b6d85efbf11c6158"},{"author":{"_account_id":9601,"name":"Oleh Anufriiev","email":"oanufriev@mirantis.com","username":"oanufriev"},"change_message_id":"46eb3f43931340768e2e9b38ac84fb534d6d5105","unresolved":false,"context_lines":[{"line_number":30,"context_line":"                                       retries\u003d5, retry_pause\u003d1):"},{"line_number":31,"context_line":"        \"\"\"Create, list and delete Fuel environments"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"        :param release_id: release id"},{"line_number":34,"context_line":"        :param network_provider: network provider"},{"line_number":35,"context_line":"        :param deployment_mode: deployment mode"},{"line_number":36,"context_line":"        :param net_segment_type: net segment type"}],"source_content_type":"text/x-python","patch_set":11,"id":"1af86dd1_e880b048","line":33,"in_reply_to":"3afb71cf_e59d820b","updated":"2015-06-12 15:03:46.000000000","message":"Done","commit_id":"63a7d4562e97685ff3b26276b6d85efbf11c6158"},{"author":{"_account_id":7369,"name":"Sergey Skripnick","email":"sskripnick@mirantis.com","username":"redixin"},"change_message_id":"ddabafa5068170be4c09686133504140019f06e8","unresolved":false,"context_lines":[{"line_number":23,"context_line":"    @validation.required_clients(\"fuel\", admin\u003dTrue)"},{"line_number":24,"context_line":"    @validation.required_openstack(admin\u003dTrue)"},{"line_number":25,"context_line":"    @base.scenario()"},{"line_number":26,"context_line":"    def list_environments(self):"},{"line_number":27,"context_line":"        \"\"\"List Fuel environments.\"\"\""},{"line_number":28,"context_line":"        self._list_environments()"}],"source_content_type":"text/x-python","patch_set":19,"id":"3a50d1a3_6097d890","side":"PARENT","line":26,"updated":"2015-07-21 09:38:29.000000000","message":"Probably this should not be removed","commit_id":"e3727ce8c4e815cbcfc8eadd79381a7e996f6cc6"},{"author":{"_account_id":9601,"name":"Oleh Anufriiev","email":"oanufriev@mirantis.com","username":"oanufriev"},"change_message_id":"dd1a0056ba35238d4d49eadcad62c520c35447c8","unresolved":false,"context_lines":[{"line_number":23,"context_line":"    @validation.required_clients(\"fuel\", admin\u003dTrue)"},{"line_number":24,"context_line":"    @validation.required_openstack(admin\u003dTrue)"},{"line_number":25,"context_line":"    @base.scenario()"},{"line_number":26,"context_line":"    def list_environments(self):"},{"line_number":27,"context_line":"        \"\"\"List Fuel environments.\"\"\""},{"line_number":28,"context_line":"        self._list_environments()"}],"source_content_type":"text/x-python","patch_set":19,"id":"3a50d1a3_75022371","side":"PARENT","line":26,"in_reply_to":"3a50d1a3_6097d890","updated":"2015-07-22 17:35:34.000000000","message":"should be. cause boris_42","commit_id":"e3727ce8c4e815cbcfc8eadd79381a7e996f6cc6"},{"author":{"_account_id":7369,"name":"Sergey Skripnick","email":"sskripnick@mirantis.com","username":"redixin"},"change_message_id":"ddabafa5068170be4c09686133504140019f06e8","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"class FuelEnvironments(utils.FuelScenario):"},{"line_number":21,"context_line":"    \"\"\"Benchmark scenarios for Fuel environments.\"\"\""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"    @validation.required_clients(\"fuel\", admin\u003dTrue)"},{"line_number":24,"context_line":"    @validation.required_openstack(admin\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":19,"id":"3a50d1a3_40ee5cb5","line":21,"updated":"2015-07-21 09:38:29.000000000","message":"Please add description of all available scenario params like release_id, deployment_mode etc.","commit_id":"ebd8c8f881b88dc88bfa39ef7b9b4b7e95fe6977"},{"author":{"_account_id":9601,"name":"Oleh Anufriiev","email":"oanufriev@mirantis.com","username":"oanufriev"},"change_message_id":"dd1a0056ba35238d4d49eadcad62c520c35447c8","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"class FuelEnvironments(utils.FuelScenario):"},{"line_number":21,"context_line":"    \"\"\"Benchmark scenarios for Fuel environments.\"\"\""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"    @validation.required_clients(\"fuel\", admin\u003dTrue)"},{"line_number":24,"context_line":"    @validation.required_openstack(admin\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":19,"id":"3a50d1a3_d1dc2075","line":21,"in_reply_to":"3a50d1a3_40ee5cb5","updated":"2015-07-22 17:35:34.000000000","message":"Done","commit_id":"ebd8c8f881b88dc88bfa39ef7b9b4b7e95fe6977"},{"author":{"_account_id":7369,"name":"Sergey Skripnick","email":"sskripnick@mirantis.com","username":"redixin"},"change_message_id":"ddabafa5068170be4c09686133504140019f06e8","unresolved":false,"context_lines":[{"line_number":28,"context_line":"                                      deployment_mode\u003d\"ha_compact\","},{"line_number":29,"context_line":"                                      net_segment_type\u003d\"vlan\","},{"line_number":30,"context_line":"                                      retries\u003d5):"},{"line_number":31,"context_line":"        \"\"\"Create, list and delete Fuel environments."},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"        :param release_id: release id (default 1)"},{"line_number":34,"context_line":"        :param network_provider: network provider (default \u0027neutron\u0027)"}],"source_content_type":"text/x-python","patch_set":19,"id":"3a50d1a3_e0d0c855","line":31,"updated":"2015-07-21 09:38:29.000000000","message":"list?","commit_id":"ebd8c8f881b88dc88bfa39ef7b9b4b7e95fe6977"},{"author":{"_account_id":9601,"name":"Oleh Anufriiev","email":"oanufriev@mirantis.com","username":"oanufriev"},"change_message_id":"dd1a0056ba35238d4d49eadcad62c520c35447c8","unresolved":false,"context_lines":[{"line_number":28,"context_line":"                                      deployment_mode\u003d\"ha_compact\","},{"line_number":29,"context_line":"                                      net_segment_type\u003d\"vlan\","},{"line_number":30,"context_line":"                                      retries\u003d5):"},{"line_number":31,"context_line":"        \"\"\"Create, list and delete Fuel environments."},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"        :param release_id: release id (default 1)"},{"line_number":34,"context_line":"        :param network_provider: network provider (default \u0027neutron\u0027)"}],"source_content_type":"text/x-python","patch_set":19,"id":"3a50d1a3_b57d0be9","line":31,"in_reply_to":"3a50d1a3_e0d0c855","updated":"2015-07-22 17:35:34.000000000","message":"Done","commit_id":"ebd8c8f881b88dc88bfa39ef7b9b4b7e95fe6977"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"b19cc261f762fb683ea82bb56d8234d4f2042912","unresolved":false,"context_lines":[{"line_number":34,"context_line":"                                      network_provider\u003d\"neutron\","},{"line_number":35,"context_line":"                                      deployment_mode\u003d\"ha_compact\","},{"line_number":36,"context_line":"                                      net_segment_type\u003d\"vlan\","},{"line_number":37,"context_line":"                                      retries\u003d5):"},{"line_number":38,"context_line":"        \"\"\"Create and delete Fuel environments."},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"        :param release_id: release id (default 1)"}],"source_content_type":"text/x-python","patch_set":23,"id":"1a4dcd0f_cc34cddf","line":37,"updated":"2015-08-11 09:57:34.000000000","message":"Just a thought: it is not obvious that `retries\u0027 is related to deletion (have to read docstring), maybe rename to `delete_retries\u0027?","commit_id":"88ef81f6a3fb36604d65aa9797930ce6ea60db79"},{"author":{"_account_id":9601,"name":"Oleh Anufriiev","email":"oanufriev@mirantis.com","username":"oanufriev"},"change_message_id":"8643ccdc6334f9f7cf0e30ec6657c41c9c123206","unresolved":false,"context_lines":[{"line_number":34,"context_line":"                                      network_provider\u003d\"neutron\","},{"line_number":35,"context_line":"                                      deployment_mode\u003d\"ha_compact\","},{"line_number":36,"context_line":"                                      net_segment_type\u003d\"vlan\","},{"line_number":37,"context_line":"                                      retries\u003d5):"},{"line_number":38,"context_line":"        \"\"\"Create and delete Fuel environments."},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"        :param release_id: release id (default 1)"}],"source_content_type":"text/x-python","patch_set":23,"id":"1a4dcd0f_8d028408","line":37,"in_reply_to":"1a4dcd0f_cc34cddf","updated":"2015-08-14 12:43:43.000000000","message":"Done","commit_id":"88ef81f6a3fb36604d65aa9797930ce6ea60db79"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"449ac57f7668aba4416bcb008be655b370091fd6","unresolved":false,"context_lines":[{"line_number":57,"context_line":"                                     network_provider\u003d\"neutron\","},{"line_number":58,"context_line":"                                     deployment_mode\u003d\"ha_compact\","},{"line_number":59,"context_line":"                                     net_segment_type\u003d\"vlan\"):"},{"line_number":60,"context_line":"        \"\"\"List Fuel environments"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"        :param release_id: release id (default 1)"},{"line_number":63,"context_line":"        :param network_provider: network provider (default \u0027neutron\u0027)"}],"source_content_type":"text/x-python","patch_set":31,"id":"fa1b9901_53383ea0","line":60,"updated":"2015-08-25 14:35:20.000000000","message":"s/List/Create and list","commit_id":"89d36b33fe057236b7844138ab7e681af3aef7c6"},{"author":{"_account_id":9601,"name":"Oleh Anufriiev","email":"oanufriev@mirantis.com","username":"oanufriev"},"change_message_id":"565295d81c2d3f52e0eed14137710ee7e67d28ce","unresolved":false,"context_lines":[{"line_number":57,"context_line":"                                     network_provider\u003d\"neutron\","},{"line_number":58,"context_line":"                                     deployment_mode\u003d\"ha_compact\","},{"line_number":59,"context_line":"                                     net_segment_type\u003d\"vlan\"):"},{"line_number":60,"context_line":"        \"\"\"List Fuel environments"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"        :param release_id: release id (default 1)"},{"line_number":63,"context_line":"        :param network_provider: network provider (default \u0027neutron\u0027)"}],"source_content_type":"text/x-python","patch_set":31,"id":"fa1b9901_bbe5be09","line":60,"in_reply_to":"fa1b9901_53383ea0","updated":"2015-08-26 14:04:11.000000000","message":"Done","commit_id":"89d36b33fe057236b7844138ab7e681af3aef7c6"}],"rally/plugins/openstack/scenarios/fuel/utils.py":[{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"d93905b6b96b92ae726e89533eb4273cf7233b94","unresolved":false,"context_lines":[{"line_number":22,"context_line":"from rally import osclients"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"class _fuel_env(object):"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    def __init__(self, client):"},{"line_number":28,"context_line":"        self._environment \u003d client"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a016987_890f1d88","line":25,"updated":"2015-05-25 15:19:52.000000000","message":"class name naming is not CamelCase (ref. PEP8).\n\nAlso, I think that `FuelEnvironmentManager\u0027 is more accurate name.","commit_id":"362530a7859ac03f264c03f7d0ca83e0a392db47"},{"author":{"_account_id":7369,"name":"Sergey Skripnick","email":"sskripnick@mirantis.com","username":"redixin"},"change_message_id":"e244c17b46131f57edc439e561b937f3268da1ab","unresolved":false,"context_lines":[{"line_number":22,"context_line":"from rally import osclients"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"class _fuel_env(object):"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    def __init__(self, client):"},{"line_number":28,"context_line":"        self._environment \u003d client"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a016987_8c5babf6","line":25,"updated":"2015-05-25 15:18:58.000000000","message":"ok. we can merge this with FuelClient and place it in rally/benchmark/wrappers","commit_id":"362530a7859ac03f264c03f7d0ca83e0a392db47"},{"author":{"_account_id":7369,"name":"Sergey Skripnick","email":"sskripnick@mirantis.com","username":"redixin"},"change_message_id":"7147462dc42c610a826cd7038a4f1fb55d934ea9","unresolved":false,"context_lines":[{"line_number":22,"context_line":"from rally import osclients"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"class _fuel_env(object):"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    def __init__(self, client):"},{"line_number":28,"context_line":"        self._environment \u003d client"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a016987_c0428268","line":25,"in_reply_to":"7a016987_890f1d88","updated":"2015-05-25 20:19:21.000000000","message":"If we decide to move in under rally/benchmark/wrappers then we should name this class FuelWrapper","commit_id":"362530a7859ac03f264c03f7d0ca83e0a392db47"},{"author":{"_account_id":9601,"name":"Oleh Anufriiev","email":"oanufriev@mirantis.com","username":"oanufriev"},"change_message_id":"117b0db7e9babd5e9318e2e9557a64bd35a01e7d","unresolved":false,"context_lines":[{"line_number":22,"context_line":"from rally import osclients"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"class _fuel_env(object):"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    def __init__(self, client):"},{"line_number":28,"context_line":"        self._environment \u003d client"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a016987_572f3e88","line":25,"in_reply_to":"7a016987_c0428268","updated":"2015-05-27 12:22:02.000000000","message":"_fuel_env wraps part of fuel client. So.. it\u0027s not a complete wrapper","commit_id":"362530a7859ac03f264c03f7d0ca83e0a392db47"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"d93905b6b96b92ae726e89533eb4273cf7233b94","unresolved":false,"context_lines":[{"line_number":25,"context_line":"class _fuel_env(object):"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    def __init__(self, client):"},{"line_number":28,"context_line":"        self._environment \u003d client"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    def get_environment(self, env_id\u003dNone, env_name\u003dNone):"},{"line_number":31,"context_line":"        if env_id is None and env_name is None:"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a016987_4cd93383","line":28,"updated":"2015-05-25 15:19:52.000000000","message":"Maybe just `self.client \u003d client\u0027\n\nBecause, this looks better:\n\n self.clients(\"fuel\").environment.client.{сustom call}\n\ntnan:\n\n self.clients(\"fuel\").environment._environment.{сustom call}","commit_id":"362530a7859ac03f264c03f7d0ca83e0a392db47"},{"author":{"_account_id":9601,"name":"Oleh Anufriiev","email":"oanufriev@mirantis.com","username":"oanufriev"},"change_message_id":"117b0db7e9babd5e9318e2e9557a64bd35a01e7d","unresolved":false,"context_lines":[{"line_number":25,"context_line":"class _fuel_env(object):"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    def __init__(self, client):"},{"line_number":28,"context_line":"        self._environment \u003d client"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    def get_environment(self, env_id\u003dNone, env_name\u003dNone):"},{"line_number":31,"context_line":"        if env_id is None and env_name is None:"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a016987_d759ee36","line":28,"in_reply_to":"7a016987_4cd93383","updated":"2015-05-27 12:22:02.000000000","message":"Done","commit_id":"362530a7859ac03f264c03f7d0ca83e0a392db47"},{"author":{"_account_id":7369,"name":"Sergey Skripnick","email":"sskripnick@mirantis.com","username":"redixin"},"change_message_id":"7147462dc42c610a826cd7038a4f1fb55d934ea9","unresolved":false,"context_lines":[{"line_number":25,"context_line":"class _fuel_env(object):"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    def __init__(self, client):"},{"line_number":28,"context_line":"        self._environment \u003d client"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    def get_environment(self, env_id\u003dNone, env_name\u003dNone):"},{"line_number":31,"context_line":"        if env_id is None and env_name is None:"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a016987_80248ac6","line":28,"in_reply_to":"7a016987_4cd93383","updated":"2015-05-25 20:19:21.000000000","message":"See my comment above (_fuel_env + FuelClient \u003d FuelWrapper)","commit_id":"362530a7859ac03f264c03f7d0ca83e0a392db47"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"dfe706479eb1aa49bf3dd3334d695185010b8a5d","unresolved":false,"context_lines":[{"line_number":25,"context_line":"class _fuel_env(object):"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    def __init__(self, client):"},{"line_number":28,"context_line":"        self._environment \u003d client"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    def get_environment(self, env_id\u003dNone, env_name\u003dNone):"},{"line_number":31,"context_line":"        if env_id is None and env_name is None:"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a016987_3b486bcc","line":28,"in_reply_to":"7a016987_80248ac6","updated":"2015-05-25 21:19:00.000000000","message":"@Sergey, structure of FuelService (not FuelWrapper, since we are going to refactor wrappers to services soon) looks a bit more complicated - we have client instance that has managers (instances of another classes):\n\n fc \u003d FuelClient(...)\n fc.environment # FuelEnvironmentManager instance\n fc.node # FuelNodeManager instance\n fc.task # FuelTaskManager instance\n\nIf we decide to implement this in single class, this will be complicated task (and probably not the best idea)","commit_id":"362530a7859ac03f264c03f7d0ca83e0a392db47"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"6fe9b5efcb3c988c63bc72748ea3e698016aae7e","unresolved":false,"context_lines":[{"line_number":37,"context_line":"                return env"},{"line_number":38,"context_line":"        return {}"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    def list_environments(self):"},{"line_number":41,"context_line":"        \"\"\"List Fuel environments.\"\"\""},{"line_number":42,"context_line":"        try:"},{"line_number":43,"context_line":"            return [env for env in self._environment.get_all() if env["}],"source_content_type":"text/x-python","patch_set":4,"id":"7a016987_0ced7bef","line":40,"updated":"2015-05-25 15:24:40.000000000","message":"Why not `list()\u0027? This class is already related to environments","commit_id":"362530a7859ac03f264c03f7d0ca83e0a392db47"},{"author":{"_account_id":7369,"name":"Sergey Skripnick","email":"sskripnick@mirantis.com","username":"redixin"},"change_message_id":"7147462dc42c610a826cd7038a4f1fb55d934ea9","unresolved":false,"context_lines":[{"line_number":37,"context_line":"                return env"},{"line_number":38,"context_line":"        return {}"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    def list_environments(self):"},{"line_number":41,"context_line":"        \"\"\"List Fuel environments.\"\"\""},{"line_number":42,"context_line":"        try:"},{"line_number":43,"context_line":"            return [env for env in self._environment.get_all() if env["}],"source_content_type":"text/x-python","patch_set":4,"id":"7a016987_4057b226","line":40,"in_reply_to":"7a016987_0ced7bef","updated":"2015-05-25 20:19:21.000000000","message":"+1","commit_id":"362530a7859ac03f264c03f7d0ca83e0a392db47"},{"author":{"_account_id":9601,"name":"Oleh Anufriiev","email":"oanufriev@mirantis.com","username":"oanufriev"},"change_message_id":"117b0db7e9babd5e9318e2e9557a64bd35a01e7d","unresolved":false,"context_lines":[{"line_number":37,"context_line":"                return env"},{"line_number":38,"context_line":"        return {}"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    def list_environments(self):"},{"line_number":41,"context_line":"        \"\"\"List Fuel environments.\"\"\""},{"line_number":42,"context_line":"        try:"},{"line_number":43,"context_line":"            return [env for env in self._environment.get_all() if env["}],"source_content_type":"text/x-python","patch_set":4,"id":"7a016987_3774c29a","line":40,"in_reply_to":"7a016987_0ced7bef","updated":"2015-05-27 12:22:02.000000000","message":"Done","commit_id":"362530a7859ac03f264c03f7d0ca83e0a392db47"},{"author":{"_account_id":9601,"name":"Oleh Anufriiev","email":"oanufriev@mirantis.com","username":"oanufriev"},"change_message_id":"117b0db7e9babd5e9318e2e9557a64bd35a01e7d","unresolved":false,"context_lines":[{"line_number":37,"context_line":"                return env"},{"line_number":38,"context_line":"        return {}"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    def list_environments(self):"},{"line_number":41,"context_line":"        \"\"\"List Fuel environments.\"\"\""},{"line_number":42,"context_line":"        try:"},{"line_number":43,"context_line":"            return [env for env in self._environment.get_all() if env["}],"source_content_type":"text/x-python","patch_set":4,"id":"7a016987_d770cea6","line":40,"in_reply_to":"7a016987_4057b226","updated":"2015-05-27 12:22:02.000000000","message":"Done","commit_id":"362530a7859ac03f264c03f7d0ca83e0a392db47"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"6fe9b5efcb3c988c63bc72748ea3e698016aae7e","unresolved":false,"context_lines":[{"line_number":45,"context_line":"        except BaseException:"},{"line_number":46,"context_line":"            raise ValueError(\"Can\u0027t list envitonments\")"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    def create_environment(self, name, release_id\u003d1,"},{"line_number":49,"context_line":"                           network_provider\u003d\"neutron\","},{"line_number":50,"context_line":"                           deployment_mode\u003d\"ha_compact\","},{"line_number":51,"context_line":"                           net_segment_type\u003d\"vlan\"):"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a016987_ccbd23d9","line":48,"updated":"2015-05-25 15:24:40.000000000","message":"create(...)","commit_id":"362530a7859ac03f264c03f7d0ca83e0a392db47"},{"author":{"_account_id":9601,"name":"Oleh Anufriiev","email":"oanufriev@mirantis.com","username":"oanufriev"},"change_message_id":"117b0db7e9babd5e9318e2e9557a64bd35a01e7d","unresolved":false,"context_lines":[{"line_number":45,"context_line":"        except BaseException:"},{"line_number":46,"context_line":"            raise ValueError(\"Can\u0027t list envitonments\")"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    def create_environment(self, name, release_id\u003d1,"},{"line_number":49,"context_line":"                           network_provider\u003d\"neutron\","},{"line_number":50,"context_line":"                           deployment_mode\u003d\"ha_compact\","},{"line_number":51,"context_line":"                           net_segment_type\u003d\"vlan\"):"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a016987_976376dd","line":48,"in_reply_to":"7a016987_ccbd23d9","updated":"2015-05-27 12:22:02.000000000","message":"Done","commit_id":"362530a7859ac03f264c03f7d0ca83e0a392db47"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"6fe9b5efcb3c988c63bc72748ea3e698016aae7e","unresolved":false,"context_lines":[{"line_number":59,"context_line":"        except BaseException:"},{"line_number":60,"context_line":"            raise ValueError(\"Can\u0027t create environment\")"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    def delete_environment(self, env_id, retries\u003d5, retry_pause\u003d1):"},{"line_number":63,"context_line":"        env \u003d self.get_environment(env_id\u003denv_id)"},{"line_number":64,"context_line":"        retry_number \u003d 1"},{"line_number":65,"context_line":"        while env:"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a016987_6ccd0f86","line":62,"updated":"2015-05-25 15:24:40.000000000","message":"delete(...)","commit_id":"362530a7859ac03f264c03f7d0ca83e0a392db47"},{"author":{"_account_id":9601,"name":"Oleh Anufriiev","email":"oanufriev@mirantis.com","username":"oanufriev"},"change_message_id":"117b0db7e9babd5e9318e2e9557a64bd35a01e7d","unresolved":false,"context_lines":[{"line_number":59,"context_line":"        except BaseException:"},{"line_number":60,"context_line":"            raise ValueError(\"Can\u0027t create environment\")"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    def delete_environment(self, env_id, retries\u003d5, retry_pause\u003d1):"},{"line_number":63,"context_line":"        env \u003d self.get_environment(env_id\u003denv_id)"},{"line_number":64,"context_line":"        retry_number \u003d 1"},{"line_number":65,"context_line":"        while env:"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a016987_379ba2cb","line":62,"in_reply_to":"7a016987_6ccd0f86","updated":"2015-05-27 12:22:02.000000000","message":"Done","commit_id":"362530a7859ac03f264c03f7d0ca83e0a392db47"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"5146e917a3f04a1d67ace311a5103675aa5b2990","unresolved":false,"context_lines":[{"line_number":23,"context_line":"from rally import osclients"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"class _fuel_env(object):"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    def __init__(self, client):"},{"line_number":29,"context_line":"        self.client \u003d client"}],"source_content_type":"text/x-python","patch_set":8,"id":"3afb71cf_ab9071ed","line":26,"updated":"2015-06-05 15:15:38.000000000","message":"Class name should be in CamelCase, without leading underscore (ref. PEP8)\n\nIMO, `FuelEnvironmentsManager\u0027 is better name for this class, since it represents manager object","commit_id":"4bb5eb6f13a78d981614d9b497aed02088c9cbdc"},{"author":{"_account_id":9601,"name":"Oleh Anufriiev","email":"oanufriev@mirantis.com","username":"oanufriev"},"change_message_id":"48b23f4714b1ff75767bd6284cc4febc166436a1","unresolved":false,"context_lines":[{"line_number":23,"context_line":"from rally import osclients"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"class _fuel_env(object):"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    def __init__(self, client):"},{"line_number":29,"context_line":"        self.client \u003d client"}],"source_content_type":"text/x-python","patch_set":8,"id":"3afb71cf_d27c4aed","line":26,"in_reply_to":"3afb71cf_ab9071ed","updated":"2015-06-09 11:51:26.000000000","message":"Done","commit_id":"4bb5eb6f13a78d981614d9b497aed02088c9cbdc"},{"author":{"_account_id":13609,"name":"Pavel Boldin","email":"pboldin@mirantis.com","username":"pboldin"},"change_message_id":"3cb5485cf46b134a671a7a0104aa9c8713cda124","unresolved":false,"context_lines":[{"line_number":29,"context_line":"        self.client \u003d client"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    def get(self, env_id\u003dNone, env_name\u003dNone):"},{"line_number":32,"context_line":"        if env_id is None and env_name is None:"},{"line_number":33,"context_line":"            return {}"},{"line_number":34,"context_line":"        env_filter \u003d env_id or env_name"},{"line_number":35,"context_line":"        enves \u003d self.list()"}],"source_content_type":"text/x-python","patch_set":8,"id":"5afe65bd_4095dd3c","line":32,"updated":"2015-06-04 18:45:06.000000000","message":"What would be the result of both `env_id` and `env_name\u0027 given?\n\nYou should either raise an exception or better simply name that argument `env_id_or_name\u0027.","commit_id":"4bb5eb6f13a78d981614d9b497aed02088c9cbdc"},{"author":{"_account_id":9601,"name":"Oleh Anufriiev","email":"oanufriev@mirantis.com","username":"oanufriev"},"change_message_id":"48b23f4714b1ff75767bd6284cc4febc166436a1","unresolved":false,"context_lines":[{"line_number":29,"context_line":"        self.client \u003d client"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    def get(self, env_id\u003dNone, env_name\u003dNone):"},{"line_number":32,"context_line":"        if env_id is None and env_name is None:"},{"line_number":33,"context_line":"            return {}"},{"line_number":34,"context_line":"        env_filter \u003d env_id or env_name"},{"line_number":35,"context_line":"        enves \u003d self.list()"}],"source_content_type":"text/x-python","patch_set":8,"id":"3afb71cf_52d73abf","line":32,"in_reply_to":"5afe65bd_4095dd3c","updated":"2015-06-09 11:51:26.000000000","message":"\u003e\u003e What would be the result of both `env_id` and `env_name\u0027 given?\n\nenv by id\n\n\u003e\u003e name that argument `env_id_or_name\u0027.\n\nDone","commit_id":"4bb5eb6f13a78d981614d9b497aed02088c9cbdc"},{"author":{"_account_id":13609,"name":"Pavel Boldin","email":"pboldin@mirantis.com","username":"pboldin"},"change_message_id":"3cb5485cf46b134a671a7a0104aa9c8713cda124","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    def get(self, env_id\u003dNone, env_name\u003dNone):"},{"line_number":32,"context_line":"        if env_id is None and env_name is None:"},{"line_number":33,"context_line":"            return {}"},{"line_number":34,"context_line":"        env_filter \u003d env_id or env_name"},{"line_number":35,"context_line":"        enves \u003d self.list()"},{"line_number":36,"context_line":"        for env in enves:"}],"source_content_type":"text/x-python","patch_set":8,"id":"3afb71cf_e4feba04","line":33,"updated":"2015-06-04 18:45:06.000000000","message":"I think raising an `ValueError\u0027 is a more appropriate behaviour.","commit_id":"4bb5eb6f13a78d981614d9b497aed02088c9cbdc"},{"author":{"_account_id":13609,"name":"Pavel Boldin","email":"pboldin@mirantis.com","username":"pboldin"},"change_message_id":"3cb5485cf46b134a671a7a0104aa9c8713cda124","unresolved":false,"context_lines":[{"line_number":34,"context_line":"        env_filter \u003d env_id or env_name"},{"line_number":35,"context_line":"        enves \u003d self.list()"},{"line_number":36,"context_line":"        for env in enves:"},{"line_number":37,"context_line":"            if env[\"id\"] \u003d\u003d env_filter or env[\"name\"] \u003d\u003d env_filter:"},{"line_number":38,"context_line":"                return env"},{"line_number":39,"context_line":"        return {}"},{"line_number":40,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"3afb71cf_a41fa25a","line":37,"updated":"2015-06-04 18:45:06.000000000","message":"Then you can rewrite this as:\n if env_id_or_name is in (env[\"id\"], env[\"name\"]):\n     return env","commit_id":"4bb5eb6f13a78d981614d9b497aed02088c9cbdc"},{"author":{"_account_id":9601,"name":"Oleh Anufriiev","email":"oanufriev@mirantis.com","username":"oanufriev"},"change_message_id":"48b23f4714b1ff75767bd6284cc4febc166436a1","unresolved":false,"context_lines":[{"line_number":34,"context_line":"        env_filter \u003d env_id or env_name"},{"line_number":35,"context_line":"        enves \u003d self.list()"},{"line_number":36,"context_line":"        for env in enves:"},{"line_number":37,"context_line":"            if env[\"id\"] \u003d\u003d env_filter or env[\"name\"] \u003d\u003d env_filter:"},{"line_number":38,"context_line":"                return env"},{"line_number":39,"context_line":"        return {}"},{"line_number":40,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"3afb71cf_ad20539c","line":37,"in_reply_to":"3afb71cf_a41fa25a","updated":"2015-06-09 11:51:26.000000000","message":"Done","commit_id":"4bb5eb6f13a78d981614d9b497aed02088c9cbdc"},{"author":{"_account_id":13609,"name":"Pavel Boldin","email":"pboldin@mirantis.com","username":"pboldin"},"change_message_id":"3cb5485cf46b134a671a7a0104aa9c8713cda124","unresolved":false,"context_lines":[{"line_number":36,"context_line":"        for env in enves:"},{"line_number":37,"context_line":"            if env[\"id\"] \u003d\u003d env_filter or env[\"name\"] \u003d\u003d env_filter:"},{"line_number":38,"context_line":"                return env"},{"line_number":39,"context_line":"        return {}"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    def list(self):"},{"line_number":42,"context_line":"        \"\"\"List Fuel environments.\"\"\""}],"source_content_type":"text/x-python","patch_set":8,"id":"5afe65bd_e0a3a9b0","line":39,"updated":"2015-06-04 18:45:06.000000000","message":"Please simple `return\u0027.","commit_id":"4bb5eb6f13a78d981614d9b497aed02088c9cbdc"},{"author":{"_account_id":9601,"name":"Oleh Anufriiev","email":"oanufriev@mirantis.com","username":"oanufriev"},"change_message_id":"48b23f4714b1ff75767bd6284cc4febc166436a1","unresolved":false,"context_lines":[{"line_number":36,"context_line":"        for env in enves:"},{"line_number":37,"context_line":"            if env[\"id\"] \u003d\u003d env_filter or env[\"name\"] \u003d\u003d env_filter:"},{"line_number":38,"context_line":"                return env"},{"line_number":39,"context_line":"        return {}"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    def list(self):"},{"line_number":42,"context_line":"        \"\"\"List Fuel environments.\"\"\""}],"source_content_type":"text/x-python","patch_set":8,"id":"3afb71cf_8d0c773c","line":39,"in_reply_to":"5afe65bd_e0a3a9b0","updated":"2015-06-09 11:51:26.000000000","message":"Done","commit_id":"4bb5eb6f13a78d981614d9b497aed02088c9cbdc"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"5146e917a3f04a1d67ace311a5103675aa5b2990","unresolved":false,"context_lines":[{"line_number":56,"context_line":"                                     deployment_mode, net_segment_type)"},{"line_number":57,"context_line":"            if env:"},{"line_number":58,"context_line":"                return env"},{"line_number":59,"context_line":"            else:"},{"line_number":60,"context_line":"                raise RuntimeError(_(\"Environment was not created or was \""},{"line_number":61,"context_line":"                                     \"created but not returned by server.\"))"},{"line_number":62,"context_line":"        except BaseException:"}],"source_content_type":"text/x-python","patch_set":8,"id":"3afb71cf_cb060d20","line":59,"updated":"2015-06-05 15:15:38.000000000","message":"This `else\u0027 is not required, since there is `return\u0027 above","commit_id":"4bb5eb6f13a78d981614d9b497aed02088c9cbdc"},{"author":{"_account_id":9601,"name":"Oleh Anufriiev","email":"oanufriev@mirantis.com","username":"oanufriev"},"change_message_id":"48b23f4714b1ff75767bd6284cc4febc166436a1","unresolved":false,"context_lines":[{"line_number":56,"context_line":"                                     deployment_mode, net_segment_type)"},{"line_number":57,"context_line":"            if env:"},{"line_number":58,"context_line":"                return env"},{"line_number":59,"context_line":"            else:"},{"line_number":60,"context_line":"                raise RuntimeError(_(\"Environment was not created or was \""},{"line_number":61,"context_line":"                                     \"created but not returned by server.\"))"},{"line_number":62,"context_line":"        except BaseException:"}],"source_content_type":"text/x-python","patch_set":8,"id":"3afb71cf_ad7cd372","line":59,"in_reply_to":"3afb71cf_cb060d20","updated":"2015-06-09 11:51:26.000000000","message":"That\u0027s not a critical point.\nBut Done","commit_id":"4bb5eb6f13a78d981614d9b497aed02088c9cbdc"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"5146e917a3f04a1d67ace311a5103675aa5b2990","unresolved":false,"context_lines":[{"line_number":57,"context_line":"            if env:"},{"line_number":58,"context_line":"                return env"},{"line_number":59,"context_line":"            else:"},{"line_number":60,"context_line":"                raise RuntimeError(_(\"Environment was not created or was \""},{"line_number":61,"context_line":"                                     \"created but not returned by server.\"))"},{"line_number":62,"context_line":"        except BaseException:"},{"line_number":63,"context_line":"            raise RuntimeError(_(\"Can\u0027t create environment. \""}],"source_content_type":"text/x-python","patch_set":8,"id":"3afb71cf_0ec5538d","line":60,"updated":"2015-06-05 15:15:38.000000000","message":"Maybe just raise BaseException?\n\nThis looks much more compact for me:\n\n try:\n   env \u003d self.client.create(...)\n   if not env:\n     raise BaseException\n   return env\n except BaseException:\n   raise RuntimeError(_(\"Something went wrong \"\n                        \"while creating an environment.\"))","commit_id":"4bb5eb6f13a78d981614d9b497aed02088c9cbdc"},{"author":{"_account_id":9601,"name":"Oleh Anufriiev","email":"oanufriev@mirantis.com","username":"oanufriev"},"change_message_id":"48b23f4714b1ff75767bd6284cc4febc166436a1","unresolved":false,"context_lines":[{"line_number":57,"context_line":"            if env:"},{"line_number":58,"context_line":"                return env"},{"line_number":59,"context_line":"            else:"},{"line_number":60,"context_line":"                raise RuntimeError(_(\"Environment was not created or was \""},{"line_number":61,"context_line":"                                     \"created but not returned by server.\"))"},{"line_number":62,"context_line":"        except BaseException:"},{"line_number":63,"context_line":"            raise RuntimeError(_(\"Can\u0027t create environment. \""}],"source_content_type":"text/x-python","patch_set":8,"id":"3afb71cf_0ded27ef","line":60,"in_reply_to":"3afb71cf_0ec5538d","updated":"2015-06-09 11:51:26.000000000","message":"Yes, but these are different cases.\n\u0027except\u0027 block wraps server errors, when fuel client calls \u0027exit()\u0027.\nInsight \u0027try\u0027 block - some unexpected behaviour (but no http error)\nSo i want to print different messages","commit_id":"4bb5eb6f13a78d981614d9b497aed02088c9cbdc"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"5146e917a3f04a1d67ace311a5103675aa5b2990","unresolved":false,"context_lines":[{"line_number":60,"context_line":"                raise RuntimeError(_(\"Environment was not created or was \""},{"line_number":61,"context_line":"                                     \"created but not returned by server.\"))"},{"line_number":62,"context_line":"        except BaseException:"},{"line_number":63,"context_line":"            raise RuntimeError(_(\"Can\u0027t create environment. \""},{"line_number":64,"context_line":"                                 \"This can happen when environment with name \""},{"line_number":65,"context_line":"                                 \"%s already exists.\") % name)"},{"line_number":66,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"3afb71cf_cee73b3f","line":63,"updated":"2015-06-05 15:15:38.000000000","message":"I suggest this message: \"Something went wrong while creating an environment.\"","commit_id":"4bb5eb6f13a78d981614d9b497aed02088c9cbdc"},{"author":{"_account_id":9601,"name":"Oleh Anufriiev","email":"oanufriev@mirantis.com","username":"oanufriev"},"change_message_id":"48b23f4714b1ff75767bd6284cc4febc166436a1","unresolved":false,"context_lines":[{"line_number":60,"context_line":"                raise RuntimeError(_(\"Environment was not created or was \""},{"line_number":61,"context_line":"                                     \"created but not returned by server.\"))"},{"line_number":62,"context_line":"        except BaseException:"},{"line_number":63,"context_line":"            raise RuntimeError(_(\"Can\u0027t create environment. \""},{"line_number":64,"context_line":"                                 \"This can happen when environment with name \""},{"line_number":65,"context_line":"                                 \"%s already exists.\") % name)"},{"line_number":66,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"3afb71cf_d3020c09","line":63,"in_reply_to":"3afb71cf_cee73b3f","updated":"2015-06-09 11:51:26.000000000","message":"Done","commit_id":"4bb5eb6f13a78d981614d9b497aed02088c9cbdc"},{"author":{"_account_id":13609,"name":"Pavel Boldin","email":"pboldin@mirantis.com","username":"pboldin"},"change_message_id":"3cb5485cf46b134a671a7a0104aa9c8713cda124","unresolved":false,"context_lines":[{"line_number":64,"context_line":"                                 \"This can happen when environment with name \""},{"line_number":65,"context_line":"                                 \"%s already exists.\") % name)"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    def delete(self, env_id, retries\u003d5, retry_pause\u003d1):"},{"line_number":68,"context_line":"        env \u003d self.get(env_id\u003denv_id)"},{"line_number":69,"context_line":"        retry_number \u003d 1"},{"line_number":70,"context_line":"        while env:"}],"source_content_type":"text/x-python","patch_set":8,"id":"3afb71cf_c49f3eb3","line":67,"updated":"2015-06-04 18:45:06.000000000","message":"This implementation is unclear.\n\nCan you rewrite so it uses a patched version of `rally.common.utils.retry\u0027?","commit_id":"4bb5eb6f13a78d981614d9b497aed02088c9cbdc"},{"author":{"_account_id":9601,"name":"Oleh Anufriiev","email":"oanufriev@mirantis.com","username":"oanufriev"},"change_message_id":"48b23f4714b1ff75767bd6284cc4febc166436a1","unresolved":false,"context_lines":[{"line_number":64,"context_line":"                                 \"This can happen when environment with name \""},{"line_number":65,"context_line":"                                 \"%s already exists.\") % name)"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    def delete(self, env_id, retries\u003d5, retry_pause\u003d1):"},{"line_number":68,"context_line":"        env \u003d self.get(env_id\u003denv_id)"},{"line_number":69,"context_line":"        retry_number \u003d 1"},{"line_number":70,"context_line":"        while env:"}],"source_content_type":"text/x-python","patch_set":8,"id":"3afb71cf_935b74f6","line":67,"in_reply_to":"3afb71cf_c49f3eb3","updated":"2015-06-09 11:51:26.000000000","message":"I can not. Cause rally.common.utils.retry catches Exception, but not BaseException.","commit_id":"4bb5eb6f13a78d981614d9b497aed02088c9cbdc"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"5146e917a3f04a1d67ace311a5103675aa5b2990","unresolved":false,"context_lines":[{"line_number":70,"context_line":"        while env:"},{"line_number":71,"context_line":"            if retry_number \u003e retries:"},{"line_number":72,"context_line":"                raise RuntimeError(_(\"Can\u0027t delete environment \""},{"line_number":73,"context_line":"                                     \"id: %s \") % str(env_id))"},{"line_number":74,"context_line":"            try:"},{"line_number":75,"context_line":"                self.client.delete_by_id(env_id)"},{"line_number":76,"context_line":"            except BaseException:"}],"source_content_type":"text/x-python","patch_set":8,"id":"3afb71cf_6e63a7b2","line":73,"updated":"2015-06-05 15:15:38.000000000","message":"s/str(env_id)/env_id/ # str(...) is redundant","commit_id":"4bb5eb6f13a78d981614d9b497aed02088c9cbdc"},{"author":{"_account_id":9601,"name":"Oleh Anufriiev","email":"oanufriev@mirantis.com","username":"oanufriev"},"change_message_id":"48b23f4714b1ff75767bd6284cc4febc166436a1","unresolved":false,"context_lines":[{"line_number":70,"context_line":"        while env:"},{"line_number":71,"context_line":"            if retry_number \u003e retries:"},{"line_number":72,"context_line":"                raise RuntimeError(_(\"Can\u0027t delete environment \""},{"line_number":73,"context_line":"                                     \"id: %s \") % str(env_id))"},{"line_number":74,"context_line":"            try:"},{"line_number":75,"context_line":"                self.client.delete_by_id(env_id)"},{"line_number":76,"context_line":"            except BaseException:"}],"source_content_type":"text/x-python","patch_set":8,"id":"3afb71cf_b320b09c","line":73,"in_reply_to":"3afb71cf_6e63a7b2","updated":"2015-06-09 11:51:26.000000000","message":"Done","commit_id":"4bb5eb6f13a78d981614d9b497aed02088c9cbdc"},{"author":{"_account_id":13609,"name":"Pavel Boldin","email":"pboldin@mirantis.com","username":"pboldin"},"change_message_id":"ce1abdf33f781460b961bbb95ff14c466f5dee73","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    def get(self, env_id_or_name):"},{"line_number":32,"context_line":"        enves \u003d self.list()"},{"line_number":33,"context_line":"        for env in enves:"},{"line_number":34,"context_line":"            if env_id_or_name in (env[\"id\"], env[\"name\"]):"},{"line_number":35,"context_line":"                return env"},{"line_number":36,"context_line":"        return"}],"source_content_type":"text/x-python","patch_set":11,"id":"3afb71cf_b0d0e6f8","line":33,"updated":"2015-06-11 21:15:23.000000000","message":"No need to make a variable `enves\u0027. Just:\n for env in self.list():","commit_id":"63a7d4562e97685ff3b26276b6d85efbf11c6158"},{"author":{"_account_id":9601,"name":"Oleh Anufriiev","email":"oanufriev@mirantis.com","username":"oanufriev"},"change_message_id":"46eb3f43931340768e2e9b38ac84fb534d6d5105","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    def get(self, env_id_or_name):"},{"line_number":32,"context_line":"        enves \u003d self.list()"},{"line_number":33,"context_line":"        for env in enves:"},{"line_number":34,"context_line":"            if env_id_or_name in (env[\"id\"], env[\"name\"]):"},{"line_number":35,"context_line":"                return env"},{"line_number":36,"context_line":"        return"}],"source_content_type":"text/x-python","patch_set":11,"id":"1af86dd1_a8dab876","line":33,"in_reply_to":"3afb71cf_b0d0e6f8","updated":"2015-06-12 15:03:46.000000000","message":"Done","commit_id":"63a7d4562e97685ff3b26276b6d85efbf11c6158"},{"author":{"_account_id":13609,"name":"Pavel Boldin","email":"pboldin@mirantis.com","username":"pboldin"},"change_message_id":"ce1abdf33f781460b961bbb95ff14c466f5dee73","unresolved":false,"context_lines":[{"line_number":38,"context_line":"    def list(self):"},{"line_number":39,"context_line":"        \"\"\"List Fuel environments.\"\"\""},{"line_number":40,"context_line":"        try:"},{"line_number":41,"context_line":"            return [env for env in self.client.get_all() if env["},{"line_number":42,"context_line":"                \"name\"].startswith(base.Scenario.RESOURCE_NAME_PREFIX)]"},{"line_number":43,"context_line":"        except BaseException:"},{"line_number":44,"context_line":"            raise RuntimeError(_(\"Can\u0027t list envitonments. \""}],"source_content_type":"text/x-python","patch_set":11,"id":"3afb71cf_50a9b27a","line":41,"updated":"2015-06-11 21:15:23.000000000","message":"Please align these appropriately:\n return [\n     env for env in self.client.get_all()\n     if env[\"name\"].startswith...\n ]","commit_id":"63a7d4562e97685ff3b26276b6d85efbf11c6158"},{"author":{"_account_id":9601,"name":"Oleh Anufriiev","email":"oanufriev@mirantis.com","username":"oanufriev"},"change_message_id":"46eb3f43931340768e2e9b38ac84fb534d6d5105","unresolved":false,"context_lines":[{"line_number":38,"context_line":"    def list(self):"},{"line_number":39,"context_line":"        \"\"\"List Fuel environments.\"\"\""},{"line_number":40,"context_line":"        try:"},{"line_number":41,"context_line":"            return [env for env in self.client.get_all() if env["},{"line_number":42,"context_line":"                \"name\"].startswith(base.Scenario.RESOURCE_NAME_PREFIX)]"},{"line_number":43,"context_line":"        except BaseException:"},{"line_number":44,"context_line":"            raise RuntimeError(_(\"Can\u0027t list envitonments. \""}],"source_content_type":"text/x-python","patch_set":11,"id":"1af86dd1_8855bcc7","line":41,"in_reply_to":"3afb71cf_50a9b27a","updated":"2015-06-12 15:03:46.000000000","message":"Done","commit_id":"63a7d4562e97685ff3b26276b6d85efbf11c6158"},{"author":{"_account_id":13609,"name":"Pavel Boldin","email":"pboldin@mirantis.com","username":"pboldin"},"change_message_id":"ce1abdf33f781460b961bbb95ff14c466f5dee73","unresolved":false,"context_lines":[{"line_number":40,"context_line":"        try:"},{"line_number":41,"context_line":"            return [env for env in self.client.get_all() if env["},{"line_number":42,"context_line":"                \"name\"].startswith(base.Scenario.RESOURCE_NAME_PREFIX)]"},{"line_number":43,"context_line":"        except BaseException:"},{"line_number":44,"context_line":"            raise RuntimeError(_(\"Can\u0027t list envitonments. \""},{"line_number":45,"context_line":"                                 \"Please check server availability.\"))"},{"line_number":46,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"3afb71cf_501c12c1","line":43,"updated":"2015-06-11 21:15:23.000000000","message":"Probably it\u0027s better to catch SystemExit exception explicitly.","commit_id":"63a7d4562e97685ff3b26276b6d85efbf11c6158"},{"author":{"_account_id":9601,"name":"Oleh Anufriiev","email":"oanufriev@mirantis.com","username":"oanufriev"},"change_message_id":"46eb3f43931340768e2e9b38ac84fb534d6d5105","unresolved":false,"context_lines":[{"line_number":40,"context_line":"        try:"},{"line_number":41,"context_line":"            return [env for env in self.client.get_all() if env["},{"line_number":42,"context_line":"                \"name\"].startswith(base.Scenario.RESOURCE_NAME_PREFIX)]"},{"line_number":43,"context_line":"        except BaseException:"},{"line_number":44,"context_line":"            raise RuntimeError(_(\"Can\u0027t list envitonments. \""},{"line_number":45,"context_line":"                                 \"Please check server availability.\"))"},{"line_number":46,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"1af86dd1_e8b430d2","line":43,"in_reply_to":"3afb71cf_501c12c1","updated":"2015-06-12 15:03:46.000000000","message":"Done","commit_id":"63a7d4562e97685ff3b26276b6d85efbf11c6158"},{"author":{"_account_id":13609,"name":"Pavel Boldin","email":"pboldin@mirantis.com","username":"pboldin"},"change_message_id":"ce1abdf33f781460b961bbb95ff14c466f5dee73","unresolved":false,"context_lines":[{"line_number":54,"context_line":"            if env:"},{"line_number":55,"context_line":"                return env"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"            raise RuntimeError(_(\"Environment was not created or was \""},{"line_number":58,"context_line":"                                 \"created but not returned by server.\"))"},{"line_number":59,"context_line":"        except BaseException:"},{"line_number":60,"context_line":"            raise RuntimeError(_(\"Something went wrong while creating an \""}],"source_content_type":"text/x-python","patch_set":11,"id":"3afb71cf_10be9ad4","line":57,"updated":"2015-06-11 21:15:23.000000000","message":"This will be handled by the `except\u0027 below.\n\nPlease place it outside of the `try\u0027 block.","commit_id":"63a7d4562e97685ff3b26276b6d85efbf11c6158"},{"author":{"_account_id":9601,"name":"Oleh Anufriiev","email":"oanufriev@mirantis.com","username":"oanufriev"},"change_message_id":"46eb3f43931340768e2e9b38ac84fb534d6d5105","unresolved":false,"context_lines":[{"line_number":54,"context_line":"            if env:"},{"line_number":55,"context_line":"                return env"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"            raise RuntimeError(_(\"Environment was not created or was \""},{"line_number":58,"context_line":"                                 \"created but not returned by server.\"))"},{"line_number":59,"context_line":"        except BaseException:"},{"line_number":60,"context_line":"            raise RuntimeError(_(\"Something went wrong while creating an \""}],"source_content_type":"text/x-python","patch_set":11,"id":"1af86dd1_68ef20b1","line":57,"in_reply_to":"3afb71cf_10be9ad4","updated":"2015-06-12 15:03:46.000000000","message":"Done","commit_id":"63a7d4562e97685ff3b26276b6d85efbf11c6158"},{"author":{"_account_id":13609,"name":"Pavel Boldin","email":"pboldin@mirantis.com","username":"pboldin"},"change_message_id":"ce1abdf33f781460b961bbb95ff14c466f5dee73","unresolved":false,"context_lines":[{"line_number":63,"context_line":"                               % name)"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    def delete(self, env_id, retries\u003d5, retry_pause\u003d1):"},{"line_number":66,"context_line":"        env \u003d self.get(env_id)"},{"line_number":67,"context_line":"        retry_number \u003d 1"},{"line_number":68,"context_line":"        while env:"},{"line_number":69,"context_line":"            if retry_number \u003e retries:"}],"source_content_type":"text/x-python","patch_set":11,"id":"3afb71cf_8b925f9e","line":66,"updated":"2015-06-11 21:15:23.000000000","message":"I think you should rather patch the `utils.retry\u0027 or `wait_for\u0027 and use it there.","commit_id":"63a7d4562e97685ff3b26276b6d85efbf11c6158"},{"author":{"_account_id":9601,"name":"Oleh Anufriiev","email":"oanufriev@mirantis.com","username":"oanufriev"},"change_message_id":"28060a9b563635fd7f8fd5a382a4d702341fda92","unresolved":false,"context_lines":[{"line_number":63,"context_line":"                               % name)"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    def delete(self, env_id, retries\u003d5, retry_pause\u003d1):"},{"line_number":66,"context_line":"        env \u003d self.get(env_id)"},{"line_number":67,"context_line":"        retry_number \u003d 1"},{"line_number":68,"context_line":"        while env:"},{"line_number":69,"context_line":"            if retry_number \u003e retries:"}],"source_content_type":"text/x-python","patch_set":11,"id":"ba3cc151_d6da6017","line":66,"in_reply_to":"3afb71cf_8b925f9e","updated":"2015-07-06 15:23:55.000000000","message":"Done","commit_id":"63a7d4562e97685ff3b26276b6d85efbf11c6158"},{"author":{"_account_id":13609,"name":"Pavel Boldin","email":"pboldin@mirantis.com","username":"pboldin"},"change_message_id":"ce1abdf33f781460b961bbb95ff14c466f5dee73","unresolved":false,"context_lines":[{"line_number":94,"context_line":"        os.environ[\"KEYSTONE_PASS\"] \u003d password"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"        import fuelclient"},{"line_number":97,"context_line":"        FuelClient.fuelclient_pkg \u003d fuelclient"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"        get_client \u003d fuelclient.get_client"},{"line_number":100,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"3afb71cf_70926ef8","line":97,"updated":"2015-06-11 21:15:23.000000000","message":"I would prefer this to be called `fuelclient_module\u0027.","commit_id":"63a7d4562e97685ff3b26276b6d85efbf11c6158"},{"author":{"_account_id":9601,"name":"Oleh Anufriiev","email":"oanufriev@mirantis.com","username":"oanufriev"},"change_message_id":"46eb3f43931340768e2e9b38ac84fb534d6d5105","unresolved":false,"context_lines":[{"line_number":94,"context_line":"        os.environ[\"KEYSTONE_PASS\"] \u003d password"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"        import fuelclient"},{"line_number":97,"context_line":"        FuelClient.fuelclient_pkg \u003d fuelclient"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"        get_client \u003d fuelclient.get_client"},{"line_number":100,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"1af86dd1_88493cd3","line":97,"in_reply_to":"3afb71cf_70926ef8","updated":"2015-06-12 15:03:46.000000000","message":"Done","commit_id":"63a7d4562e97685ff3b26276b6d85efbf11c6158"},{"author":{"_account_id":7369,"name":"Sergey Skripnick","email":"sskripnick@mirantis.com","username":"redixin"},"change_message_id":"ddabafa5068170be4c09686133504140019f06e8","unresolved":false,"context_lines":[{"line_number":24,"context_line":"from rally.task.scenarios import base"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"class FuelEnvManager(object):"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    def __init__(self, client):"},{"line_number":30,"context_line":"        self.client \u003d client"}],"source_content_type":"text/x-python","patch_set":19,"id":"3a50d1a3_404adcad","line":27,"updated":"2015-07-21 09:38:29.000000000","message":"Why not do this in same way as rally.plugins.openstack.wrappers.*?","commit_id":"ebd8c8f881b88dc88bfa39ef7b9b4b7e95fe6977"},{"author":{"_account_id":9601,"name":"Oleh Anufriiev","email":"oanufriev@mirantis.com","username":"oanufriev"},"change_message_id":"dd1a0056ba35238d4d49eadcad62c520c35447c8","unresolved":false,"context_lines":[{"line_number":24,"context_line":"from rally.task.scenarios import base"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"class FuelEnvManager(object):"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    def __init__(self, client):"},{"line_number":30,"context_line":"        self.client \u003d client"}],"source_content_type":"text/x-python","patch_set":19,"id":"3a50d1a3_78ba1a70","line":27,"in_reply_to":"3a50d1a3_404adcad","updated":"2015-07-22 17:35:34.000000000","message":"Cause this work only on fuelclient.environment.\nAlso this class id actual till fuelclient will be rewritten.","commit_id":"ebd8c8f881b88dc88bfa39ef7b9b4b7e95fe6977"},{"author":{"_account_id":7369,"name":"Sergey Skripnick","email":"sskripnick@mirantis.com","username":"redixin"},"change_message_id":"c19d76afc5a906ca56e76a2e19405188ca2206a1","unresolved":false,"context_lines":[{"line_number":29,"context_line":"    def __init__(self, client):"},{"line_number":30,"context_line":"        self.client \u003d client"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    def get(self, env_id_or_name):"},{"line_number":33,"context_line":"        for env in self.list():"},{"line_number":34,"context_line":"            if env_id_or_name in (env[\"id\"], env[\"name\"]):"},{"line_number":35,"context_line":"                return env"}],"source_content_type":"text/x-python","patch_set":23,"id":"1a4dcd0f_ab56fecf","line":32,"updated":"2015-08-05 12:05:00.000000000","message":"There is no method to directly get resource by id or name in fuel api, right?","commit_id":"88ef81f6a3fb36604d65aa9797930ce6ea60db79"},{"author":{"_account_id":9601,"name":"Oleh Anufriiev","email":"oanufriev@mirantis.com","username":"oanufriev"},"change_message_id":"1378fd751b961e3f19debdc88ceb4ae150de7d37","unresolved":false,"context_lines":[{"line_number":29,"context_line":"    def __init__(self, client):"},{"line_number":30,"context_line":"        self.client \u003d client"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    def get(self, env_id_or_name):"},{"line_number":33,"context_line":"        for env in self.list():"},{"line_number":34,"context_line":"            if env_id_or_name in (env[\"id\"], env[\"name\"]):"},{"line_number":35,"context_line":"                return env"}],"source_content_type":"text/x-python","patch_set":23,"id":"1a4dcd0f_01c7d345","line":32,"in_reply_to":"1a4dcd0f_ab56fecf","updated":"2015-08-05 12:52:03.000000000","message":"fuel api provide method to get all envitonments\nhttps://github.com/stackforge/python-fuelclient/blob/master/fuelclient/v1/base_v1.py#L27\n\nand get environment by id only https://github.com/stackforge/python-fuelclient/blob/master/fuelclient/v1/base_v1.py#L32","commit_id":"88ef81f6a3fb36604d65aa9797930ce6ea60db79"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"b19cc261f762fb683ea82bb56d8234d4f2042912","unresolved":false,"context_lines":[{"line_number":33,"context_line":"        for env in self.list():"},{"line_number":34,"context_line":"            if env_id_or_name in (env[\"id\"], env[\"name\"]):"},{"line_number":35,"context_line":"                return env"},{"line_number":36,"context_line":"        return"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    def list(self):"},{"line_number":39,"context_line":"        \"\"\"List Fuel environments.\"\"\""}],"source_content_type":"text/x-python","patch_set":23,"id":"1a4dcd0f_8c37a5af","line":36,"updated":"2015-08-11 09:57:34.000000000","message":"This `return\u0027 is redundant, can be deleted","commit_id":"88ef81f6a3fb36604d65aa9797930ce6ea60db79"},{"author":{"_account_id":9601,"name":"Oleh Anufriiev","email":"oanufriev@mirantis.com","username":"oanufriev"},"change_message_id":"8643ccdc6334f9f7cf0e30ec6657c41c9c123206","unresolved":false,"context_lines":[{"line_number":33,"context_line":"        for env in self.list():"},{"line_number":34,"context_line":"            if env_id_or_name in (env[\"id\"], env[\"name\"]):"},{"line_number":35,"context_line":"                return env"},{"line_number":36,"context_line":"        return"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    def list(self):"},{"line_number":39,"context_line":"        \"\"\"List Fuel environments.\"\"\""}],"source_content_type":"text/x-python","patch_set":23,"id":"1a4dcd0f_0d0f542f","line":36,"in_reply_to":"1a4dcd0f_8c37a5af","updated":"2015-08-14 12:43:43.000000000","message":"Done","commit_id":"88ef81f6a3fb36604d65aa9797930ce6ea60db79"},{"author":{"_account_id":7369,"name":"Sergey Skripnick","email":"sskripnick@mirantis.com","username":"redixin"},"change_message_id":"c19d76afc5a906ca56e76a2e19405188ca2206a1","unresolved":false,"context_lines":[{"line_number":45,"context_line":"            raise RuntimeError(_(\"Can\u0027t list envitonments. \""},{"line_number":46,"context_line":"                                 \"Please check server availability.\"))"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    def create(self, name, release_id\u003d1,"},{"line_number":49,"context_line":"               network_provider\u003d\"neutron\","},{"line_number":50,"context_line":"               deployment_mode\u003d\"ha_compact\","},{"line_number":51,"context_line":"               net_segment_type\u003d\"vlan\"):"}],"source_content_type":"text/x-python","patch_set":23,"id":"1a4dcd0f_ebde466c","line":48,"updated":"2015-08-05 12:05:00.000000000","message":"This method allows creating resource which would not be listed by \"list\" method. AFAIU we are just removing ability to specify resource name by user in other scenarios/utils.","commit_id":"88ef81f6a3fb36604d65aa9797930ce6ea60db79"},{"author":{"_account_id":9601,"name":"Oleh Anufriiev","email":"oanufriev@mirantis.com","username":"oanufriev"},"change_message_id":"1378fd751b961e3f19debdc88ceb4ae150de7d37","unresolved":false,"context_lines":[{"line_number":45,"context_line":"            raise RuntimeError(_(\"Can\u0027t list envitonments. \""},{"line_number":46,"context_line":"                                 \"Please check server availability.\"))"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    def create(self, name, release_id\u003d1,"},{"line_number":49,"context_line":"               network_provider\u003d\"neutron\","},{"line_number":50,"context_line":"               deployment_mode\u003d\"ha_compact\","},{"line_number":51,"context_line":"               net_segment_type\u003d\"vlan\"):"}],"source_content_type":"text/x-python","patch_set":23,"id":"1a4dcd0f_a1213ffd","line":48,"in_reply_to":"1a4dcd0f_ebde466c","updated":"2015-08-05 12:52:03.000000000","message":"True\nFuelEnvManager should not be used nowhere except this module","commit_id":"88ef81f6a3fb36604d65aa9797930ce6ea60db79"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"b19cc261f762fb683ea82bb56d8234d4f2042912","unresolved":false,"context_lines":[{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    def delete(self, env_id, retries\u003d5, retry_pause\u003d0.5):"},{"line_number":67,"context_line":"        env \u003d self.get(env_id)"},{"line_number":68,"context_line":"        retry_number \u003d 1"},{"line_number":69,"context_line":"        while env:"},{"line_number":70,"context_line":"            if retry_number \u003e retries:"},{"line_number":71,"context_line":"                raise RuntimeError(_(\"Can\u0027t delete environment \""}],"source_content_type":"text/x-python","patch_set":23,"id":"1a4dcd0f_0c96354c","line":68,"updated":"2015-08-11 09:57:34.000000000","message":"retry_number \u003d 0  # This counts `Re-tries\u0027, not `tries\u0027","commit_id":"88ef81f6a3fb36604d65aa9797930ce6ea60db79"},{"author":{"_account_id":9601,"name":"Oleh Anufriiev","email":"oanufriev@mirantis.com","username":"oanufriev"},"change_message_id":"8643ccdc6334f9f7cf0e30ec6657c41c9c123206","unresolved":false,"context_lines":[{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    def delete(self, env_id, retries\u003d5, retry_pause\u003d0.5):"},{"line_number":67,"context_line":"        env \u003d self.get(env_id)"},{"line_number":68,"context_line":"        retry_number \u003d 1"},{"line_number":69,"context_line":"        while env:"},{"line_number":70,"context_line":"            if retry_number \u003e retries:"},{"line_number":71,"context_line":"                raise RuntimeError(_(\"Can\u0027t delete environment \""}],"source_content_type":"text/x-python","patch_set":23,"id":"1a4dcd0f_cd464c4f","line":68,"in_reply_to":"1a4dcd0f_0c96354c","updated":"2015-08-14 12:43:43.000000000","message":"Done","commit_id":"88ef81f6a3fb36604d65aa9797930ce6ea60db79"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"b19cc261f762fb683ea82bb56d8234d4f2042912","unresolved":false,"context_lines":[{"line_number":95,"context_line":"        os.environ[\"KEYSTONE_PASS\"] \u003d password"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"        import fuelclient"},{"line_number":98,"context_line":"        FuelClient.fuelclient_module \u003d fuelclient"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"        get_client \u003d fuelclient.get_client"},{"line_number":101,"context_line":""}],"source_content_type":"text/x-python","patch_set":23,"id":"1a4dcd0f_0ca4f5a3","line":98,"updated":"2015-08-11 09:57:34.000000000","message":"I recommend to make this shorter s/fuelclient_module/module/","commit_id":"88ef81f6a3fb36604d65aa9797930ce6ea60db79"},{"author":{"_account_id":9601,"name":"Oleh Anufriiev","email":"oanufriev@mirantis.com","username":"oanufriev"},"change_message_id":"8643ccdc6334f9f7cf0e30ec6657c41c9c123206","unresolved":false,"context_lines":[{"line_number":95,"context_line":"        os.environ[\"KEYSTONE_PASS\"] \u003d password"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"        import fuelclient"},{"line_number":98,"context_line":"        FuelClient.fuelclient_module \u003d fuelclient"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"        get_client \u003d fuelclient.get_client"},{"line_number":101,"context_line":""}],"source_content_type":"text/x-python","patch_set":23,"id":"1a4dcd0f_ad6ae07f","line":98,"in_reply_to":"1a4dcd0f_0ca4f5a3","updated":"2015-08-14 12:43:43.000000000","message":"At patch set 11 Pavel Boldin commented:\n\"I would prefer this to be called `fuelclient_module\u0027.\"\n\nPlease, read comments history.","commit_id":"88ef81f6a3fb36604d65aa9797930ce6ea60db79"},{"author":{"_account_id":7369,"name":"Sergey Skripnick","email":"sskripnick@mirantis.com","username":"redixin"},"change_message_id":"0026268015e165cc3830dfcdd110f12f179b71df","unresolved":false,"context_lines":[{"line_number":30,"context_line":"    def __init__(self, client):"},{"line_number":31,"context_line":"        self.client \u003d client"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    def get(self, env_id_or_name):"},{"line_number":34,"context_line":"        for env in self.list():"},{"line_number":35,"context_line":"            if env_id_or_name in (env[\"id\"], env[\"name\"]):"},{"line_number":36,"context_line":"                return env"}],"source_content_type":"text/x-python","patch_set":26,"id":"fa1b9901_eeb9b22f","line":33,"updated":"2015-08-18 10:39:46.000000000","message":"Please use get_by_id API method here.\n\nCreate one more method \"get_by_name\" if necessary.","commit_id":"6e69376bad3512f6f60652a4b678caf0d3f58de8"},{"author":{"_account_id":9601,"name":"Oleh Anufriiev","email":"oanufriev@mirantis.com","username":"oanufriev"},"change_message_id":"ecc0856b9249e7ee19bf2b70d7c121424fd20e9b","unresolved":false,"context_lines":[{"line_number":30,"context_line":"    def __init__(self, client):"},{"line_number":31,"context_line":"        self.client \u003d client"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    def get(self, env_id_or_name):"},{"line_number":34,"context_line":"        for env in self.list():"},{"line_number":35,"context_line":"            if env_id_or_name in (env[\"id\"], env[\"name\"]):"},{"line_number":36,"context_line":"                return env"}],"source_content_type":"text/x-python","patch_set":26,"id":"fa1b9901_e9d2ccff","line":33,"in_reply_to":"fa1b9901_eeb9b22f","updated":"2015-08-19 13:30:25.000000000","message":"Done","commit_id":"6e69376bad3512f6f60652a4b678caf0d3f58de8"},{"author":{"_account_id":7369,"name":"Sergey Skripnick","email":"sskripnick@mirantis.com","username":"redixin"},"change_message_id":"8c56754a0f7c6ccf560229b5cb9c6e1a4f5e1dca","unresolved":false,"context_lines":[{"line_number":38,"context_line":"        try:"},{"line_number":39,"context_line":"            return ["},{"line_number":40,"context_line":"                env for env in self.client.get_all()"},{"line_number":41,"context_line":"                if env[\"name\"].startswith("},{"line_number":42,"context_line":"                    scenario.Scenario.RESOURCE_NAME_PREFIX)]"},{"line_number":43,"context_line":"        except SystemExit:"},{"line_number":44,"context_line":"            raise RuntimeError(_(\"Can\u0027t list envitonments. \""}],"source_content_type":"text/x-python","patch_set":28,"id":"fa1b9901_374f886c","line":41,"updated":"2015-08-20 11:30:03.000000000","message":"Using this Manager we can create env with any name, and can only list envs with particular name prefix. This is kind of resource leak.","commit_id":"3bb46c0275aeaee83ac17676da2b3b3e397e94d5"},{"author":{"_account_id":9601,"name":"Oleh Anufriiev","email":"oanufriev@mirantis.com","username":"oanufriev"},"change_message_id":"aaac2dbadc240b3c0c11264a6e60335213ef7a19","unresolved":false,"context_lines":[{"line_number":38,"context_line":"        try:"},{"line_number":39,"context_line":"            return ["},{"line_number":40,"context_line":"                env for env in self.client.get_all()"},{"line_number":41,"context_line":"                if env[\"name\"].startswith("},{"line_number":42,"context_line":"                    scenario.Scenario.RESOURCE_NAME_PREFIX)]"},{"line_number":43,"context_line":"        except SystemExit:"},{"line_number":44,"context_line":"            raise RuntimeError(_(\"Can\u0027t list envitonments. \""}],"source_content_type":"text/x-python","patch_set":28,"id":"fa1b9901_2e4f2d6c","line":41,"in_reply_to":"fa1b9901_374f886c","updated":"2015-08-20 13:13:37.000000000","message":"Done","commit_id":"3bb46c0275aeaee83ac17676da2b3b3e397e94d5"},{"author":{"_account_id":7369,"name":"Sergey Skripnick","email":"sskripnick@mirantis.com","username":"redixin"},"change_message_id":"8c56754a0f7c6ccf560229b5cb9c6e1a4f5e1dca","unresolved":false,"context_lines":[{"line_number":70,"context_line":"                raise RuntimeError(_(\"Can\u0027t delete environment \""},{"line_number":71,"context_line":"                                     \"id: %s \") % env_id)"},{"line_number":72,"context_line":"            try:"},{"line_number":73,"context_line":"                self.client.delete_by_id(env_id)"},{"line_number":74,"context_line":"            except BaseException:"},{"line_number":75,"context_line":"                time.sleep(retry_pause)"},{"line_number":76,"context_line":"            env \u003d self.get(env_id)"}],"source_content_type":"text/x-python","patch_set":28,"id":"fa1b9901_f71d9062","line":73,"updated":"2015-08-20 11:30:03.000000000","message":"Is it really possible situation when api says \"ok\" but did nothing? (And we should repeat api call)","commit_id":"3bb46c0275aeaee83ac17676da2b3b3e397e94d5"},{"author":{"_account_id":9601,"name":"Oleh Anufriiev","email":"oanufriev@mirantis.com","username":"oanufriev"},"change_message_id":"aaac2dbadc240b3c0c11264a6e60335213ef7a19","unresolved":false,"context_lines":[{"line_number":70,"context_line":"                raise RuntimeError(_(\"Can\u0027t delete environment \""},{"line_number":71,"context_line":"                                     \"id: %s \") % env_id)"},{"line_number":72,"context_line":"            try:"},{"line_number":73,"context_line":"                self.client.delete_by_id(env_id)"},{"line_number":74,"context_line":"            except BaseException:"},{"line_number":75,"context_line":"                time.sleep(retry_pause)"},{"line_number":76,"context_line":"            env \u003d self.get(env_id)"}],"source_content_type":"text/x-python","patch_set":28,"id":"fa1b9901_ee54d5fe","line":73,"in_reply_to":"fa1b9901_f71d9062","updated":"2015-08-20 13:13:37.000000000","message":"yes","commit_id":"3bb46c0275aeaee83ac17676da2b3b3e397e94d5"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"42b5728b11ae79d6f323ff4a3e0f2b39f603075a","unresolved":false,"context_lines":[{"line_number":94,"context_line":"        os.environ[\"KEYSTONE_PASS\"] \u003d password"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"        import fuelclient"},{"line_number":97,"context_line":"        FuelClient.fuelclient_module \u003d fuelclient"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"        get_client \u003d fuelclient.get_client"},{"line_number":100,"context_line":""}],"source_content_type":"text/x-python","patch_set":29,"id":"fa1b9901_194d92c3","line":97,"updated":"2015-08-21 14:27:46.000000000","message":"I recommend using shorter name s/fuelclient_module/module/","commit_id":"e7c36f038943dea8b2526a1aa530799ca1966be7"},{"author":{"_account_id":9601,"name":"Oleh Anufriiev","email":"oanufriev@mirantis.com","username":"oanufriev"},"change_message_id":"5c152b7567173fba53734ac42dc04c7fc3243c5d","unresolved":false,"context_lines":[{"line_number":94,"context_line":"        os.environ[\"KEYSTONE_PASS\"] \u003d password"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"        import fuelclient"},{"line_number":97,"context_line":"        FuelClient.fuelclient_module \u003d fuelclient"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"        get_client \u003d fuelclient.get_client"},{"line_number":100,"context_line":""}],"source_content_type":"text/x-python","patch_set":29,"id":"fa1b9901_773ff5b3","line":97,"in_reply_to":"fa1b9901_194d92c3","updated":"2015-08-21 14:49:25.000000000","message":"!!!!!!!\nPatch Set 23:\n\n   At patch set 11 Pavel Boldin commented: \"I would prefer    this to be called `fuelclient_module\u0027.\"\n\nPlease, read comments history.","commit_id":"e7c36f038943dea8b2526a1aa530799ca1966be7"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"42b5728b11ae79d6f323ff4a3e0f2b39f603075a","unresolved":false,"context_lines":[{"line_number":128,"context_line":"                            deployment_mode\u003d\"ha_compact\","},{"line_number":129,"context_line":"                            net_segment_type\u003d\"vlan\"):"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"        name \u003d name or self._generate_random_name("},{"line_number":132,"context_line":"            prefix\u003dscenario.Scenario.RESOURCE_NAME_PREFIX)"},{"line_number":133,"context_line":"        env \u003d self.admin_clients(\"fuel\").environment.create("},{"line_number":134,"context_line":"            name, release_id, network_provider, deployment_mode,"}],"source_content_type":"text/x-python","patch_set":29,"id":"fa1b9901_f94f7e8f","line":131,"updated":"2015-08-21 14:27:46.000000000","message":"I think it is reasonable to check if given `name\u0027 (if specified) also starts with RESOURCE_NAME_PREFIX. Otherwise there will be cleanup issue","commit_id":"e7c36f038943dea8b2526a1aa530799ca1966be7"},{"author":{"_account_id":9601,"name":"Oleh Anufriiev","email":"oanufriev@mirantis.com","username":"oanufriev"},"change_message_id":"5c152b7567173fba53734ac42dc04c7fc3243c5d","unresolved":false,"context_lines":[{"line_number":128,"context_line":"                            deployment_mode\u003d\"ha_compact\","},{"line_number":129,"context_line":"                            net_segment_type\u003d\"vlan\"):"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"        name \u003d name or self._generate_random_name("},{"line_number":132,"context_line":"            prefix\u003dscenario.Scenario.RESOURCE_NAME_PREFIX)"},{"line_number":133,"context_line":"        env \u003d self.admin_clients(\"fuel\").environment.create("},{"line_number":134,"context_line":"            name, release_id, network_provider, deployment_mode,"}],"source_content_type":"text/x-python","patch_set":29,"id":"fa1b9901_57d19121","line":131,"in_reply_to":"fa1b9901_f94f7e8f","updated":"2015-08-21 14:49:25.000000000","message":"disagree. For cleanup work you have leve \u0027name\u0027 None\nBut you can add custom name for special purposes","commit_id":"e7c36f038943dea8b2526a1aa530799ca1966be7"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"449ac57f7668aba4416bcb008be655b370091fd6","unresolved":false,"context_lines":[{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    def list(self, prefix\u003dNone):"},{"line_number":40,"context_line":"        \"\"\"List Fuel environments.\"\"\""},{"line_number":41,"context_line":"        prefix \u003d prefix or scenario.Scenario.RESOURCE_NAME_PREFIX"},{"line_number":42,"context_line":"        try:"},{"line_number":43,"context_line":"            return ["},{"line_number":44,"context_line":"                env for env in self.client.get_all()"}],"source_content_type":"text/x-python","patch_set":31,"id":"fa1b9901_33ad8a9b","line":41,"updated":"2015-08-25 14:35:20.000000000","message":"os_scenario.Scenario doesn\u0027t change RESOURCE_NAME_PREFIX of parent class scenario.Scenario, so I prefer to use os_scenario.Scenario.RESOURCE_NAME_PREFIX and remove additional import.","commit_id":"89d36b33fe057236b7844138ab7e681af3aef7c6"},{"author":{"_account_id":9601,"name":"Oleh Anufriiev","email":"oanufriev@mirantis.com","username":"oanufriev"},"change_message_id":"565295d81c2d3f52e0eed14137710ee7e67d28ce","unresolved":false,"context_lines":[{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    def list(self, prefix\u003dNone):"},{"line_number":40,"context_line":"        \"\"\"List Fuel environments.\"\"\""},{"line_number":41,"context_line":"        prefix \u003d prefix or scenario.Scenario.RESOURCE_NAME_PREFIX"},{"line_number":42,"context_line":"        try:"},{"line_number":43,"context_line":"            return ["},{"line_number":44,"context_line":"                env for env in self.client.get_all()"}],"source_content_type":"text/x-python","patch_set":31,"id":"fa1b9901_91cf797e","line":41,"in_reply_to":"fa1b9901_33ad8a9b","updated":"2015-08-26 14:04:11.000000000","message":"Done","commit_id":"89d36b33fe057236b7844138ab7e681af3aef7c6"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"449ac57f7668aba4416bcb008be655b370091fd6","unresolved":false,"context_lines":[{"line_number":132,"context_line":"                            net_segment_type\u003d\"vlan\"):"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"        name \u003d name or self._generate_random_name("},{"line_number":135,"context_line":"            prefix\u003dscenario.Scenario.RESOURCE_NAME_PREFIX)"},{"line_number":136,"context_line":"        env \u003d self.admin_clients(\"fuel\").environment.create("},{"line_number":137,"context_line":"            name, release_id, network_provider, deployment_mode,"},{"line_number":138,"context_line":"            net_segment_type)"}],"source_content_type":"text/x-python","patch_set":31,"id":"fa1b9901_3384aa09","line":135,"updated":"2015-08-25 14:35:20.000000000","message":"same here","commit_id":"89d36b33fe057236b7844138ab7e681af3aef7c6"},{"author":{"_account_id":9601,"name":"Oleh Anufriiev","email":"oanufriev@mirantis.com","username":"oanufriev"},"change_message_id":"565295d81c2d3f52e0eed14137710ee7e67d28ce","unresolved":false,"context_lines":[{"line_number":132,"context_line":"                            net_segment_type\u003d\"vlan\"):"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"        name \u003d name or self._generate_random_name("},{"line_number":135,"context_line":"            prefix\u003dscenario.Scenario.RESOURCE_NAME_PREFIX)"},{"line_number":136,"context_line":"        env \u003d self.admin_clients(\"fuel\").environment.create("},{"line_number":137,"context_line":"            name, release_id, network_provider, deployment_mode,"},{"line_number":138,"context_line":"            net_segment_type)"}],"source_content_type":"text/x-python","patch_set":31,"id":"fa1b9901_51c56159","line":135,"in_reply_to":"fa1b9901_3384aa09","updated":"2015-08-26 14:04:11.000000000","message":"Done","commit_id":"89d36b33fe057236b7844138ab7e681af3aef7c6"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"e04846d740350aaa1631cbcb17fd98927064a4b6","unresolved":false,"context_lines":[{"line_number":61,"context_line":""},{"line_number":62,"context_line":"        if env:"},{"line_number":63,"context_line":"            return env"},{"line_number":64,"context_line":"        raise RuntimeError(_(\"Environment was not created or was \""},{"line_number":65,"context_line":"                             \"created but not returned by server.\"))"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    def delete(self, env_id, retries\u003d5, retry_pause\u003d0.5):"}],"source_content_type":"text/x-python","patch_set":32,"id":"fa1b9901_15c7ce96","line":64,"updated":"2015-08-26 14:54:22.000000000","message":"wtf?! it looks like fuel is too user-friendly","commit_id":"589173a81acb20f61b6ac634bb0c227f65935313"},{"author":{"_account_id":7369,"name":"Sergey Skripnick","email":"sskripnick@mirantis.com","username":"redixin"},"change_message_id":"15fbd0d8acddcf992aa9fa803ce674aa3336438d","unresolved":false,"context_lines":[{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    def list(self, prefix\u003dNone):"},{"line_number":39,"context_line":"        \"\"\"List Fuel environments.\"\"\""},{"line_number":40,"context_line":"        prefix \u003d prefix or scenario.OpenStackScenario.RESOURCE_NAME_PREFIX"},{"line_number":41,"context_line":"        try:"},{"line_number":42,"context_line":"            return ["},{"line_number":43,"context_line":"                env for env in self.client.get_all()"}],"source_content_type":"text/x-python","patch_set":33,"id":"da20952f_7f74359b","line":40,"updated":"2015-09-03 14:35:26.000000000","message":"Resource leak is still here. I see only one way to fix it -- force add prefix in create method.","commit_id":"f172d51c01473b5c0c309c4eca09c1f950ae1411"},{"author":{"_account_id":9601,"name":"Oleh Anufriiev","email":"oanufriev@mirantis.com","username":"oanufriev"},"change_message_id":"0f9720994a1192ccd1d064d64357b62ec3cd7f04","unresolved":false,"context_lines":[{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    def list(self, prefix\u003dNone):"},{"line_number":39,"context_line":"        \"\"\"List Fuel environments.\"\"\""},{"line_number":40,"context_line":"        prefix \u003d prefix or scenario.OpenStackScenario.RESOURCE_NAME_PREFIX"},{"line_number":41,"context_line":"        try:"},{"line_number":42,"context_line":"            return ["},{"line_number":43,"context_line":"                env for env in self.client.get_all()"}],"source_content_type":"text/x-python","patch_set":33,"id":"da20952f_d2162f48","line":40,"in_reply_to":"da20952f_7f74359b","updated":"2015-09-07 10:24:10.000000000","message":"Done","commit_id":"f172d51c01473b5c0c309c4eca09c1f950ae1411"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"1f7f32632e2c601ce9fdf4a54d2e9e7afb75ecd8","unresolved":false,"context_lines":[{"line_number":121,"context_line":"    def _list_environments(self):"},{"line_number":122,"context_line":"        return [env for env in self.admin_clients(\"fuel\").environment.list()"},{"line_number":123,"context_line":"                if env[\"name\"].startswith("},{"line_number":124,"context_line":"                    scenario.OpenStackScenario.RESOURCE_NAME_PREFIX)]"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"    @atomic.action_timer(\"fuel.create_environment\")"},{"line_number":127,"context_line":"    def _create_environment(self, release_id\u003d1,"}],"source_content_type":"text/x-python","patch_set":35,"id":"ba15a1d1_a631a10d","line":124,"updated":"2015-09-15 01:21:01.000000000","message":"I believe this method should return all fuel envs. And resource cleanup should take care to not delete non rally envs.\n\nPlease fix in next patch.","commit_id":"ddeb3aebe4ff78948a3df25aee66c2e9e8a82767"}],"tests/unit/plugins/openstack/context/cleanup/test_resources.py":[{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"5146e917a3f04a1d67ace311a5103675aa5b2990","unresolved":false,"context_lines":[{"line_number":449,"context_line":"        mock__manager.return_value.get.return_value \u003d []"},{"line_number":450,"context_line":"        fres \u003d resources.FuelEnvironment()"},{"line_number":451,"context_line":"        fres.id \u003d mock.Mock()"},{"line_number":452,"context_line":"        self.assertTrue(fres.is_deleted())"}],"source_content_type":"text/x-python","patch_set":8,"id":"3afb71cf_6e1de772","line":452,"updated":"2015-06-05 15:15:38.000000000","message":"This assert is not enough to prove that is_deleted is working.\n\nPlease add second assert: change mock__manager.return_value.get.return_value and assert that is_deleted returns False","commit_id":"4bb5eb6f13a78d981614d9b497aed02088c9cbdc"},{"author":{"_account_id":9601,"name":"Oleh Anufriiev","email":"oanufriev@mirantis.com","username":"oanufriev"},"change_message_id":"48b23f4714b1ff75767bd6284cc4febc166436a1","unresolved":false,"context_lines":[{"line_number":449,"context_line":"        mock__manager.return_value.get.return_value \u003d []"},{"line_number":450,"context_line":"        fres \u003d resources.FuelEnvironment()"},{"line_number":451,"context_line":"        fres.id \u003d mock.Mock()"},{"line_number":452,"context_line":"        self.assertTrue(fres.is_deleted())"}],"source_content_type":"text/x-python","patch_set":8,"id":"3afb71cf_b49aa56c","line":452,"in_reply_to":"3afb71cf_6e1de772","updated":"2015-06-09 11:51:26.000000000","message":"Done","commit_id":"4bb5eb6f13a78d981614d9b497aed02088c9cbdc"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"60f73721b8436d22884a974be9d5999e11fc5e35","unresolved":false,"context_lines":[{"line_number":534,"context_line":""},{"line_number":535,"context_line":"    @mock.patch(\"%s.FuelEnvironment._manager\" % BASE)"},{"line_number":536,"context_line":"    def test_is_deleted(self, mock__manager):"},{"line_number":537,"context_line":"        mock__manager.return_value.get.return_value \u003d []"},{"line_number":538,"context_line":"        fres \u003d resources.FuelEnvironment()"},{"line_number":539,"context_line":"        fres.id \u003d mock.Mock()"},{"line_number":540,"context_line":"        self.assertTrue(fres.is_deleted())"}],"source_content_type":"text/x-python","patch_set":33,"id":"da20952f_a8534715","line":537,"updated":"2015-09-04 13:32:38.000000000","message":"Why return value is list? FuelEnvManager returns None for missed env","commit_id":"f172d51c01473b5c0c309c4eca09c1f950ae1411"},{"author":{"_account_id":9601,"name":"Oleh Anufriiev","email":"oanufriev@mirantis.com","username":"oanufriev"},"change_message_id":"0f9720994a1192ccd1d064d64357b62ec3cd7f04","unresolved":false,"context_lines":[{"line_number":534,"context_line":""},{"line_number":535,"context_line":"    @mock.patch(\"%s.FuelEnvironment._manager\" % BASE)"},{"line_number":536,"context_line":"    def test_is_deleted(self, mock__manager):"},{"line_number":537,"context_line":"        mock__manager.return_value.get.return_value \u003d []"},{"line_number":538,"context_line":"        fres \u003d resources.FuelEnvironment()"},{"line_number":539,"context_line":"        fres.id \u003d mock.Mock()"},{"line_number":540,"context_line":"        self.assertTrue(fres.is_deleted())"}],"source_content_type":"text/x-python","patch_set":33,"id":"da20952f_6dc98225","line":537,"in_reply_to":"da20952f_a8534715","updated":"2015-09-07 10:24:10.000000000","message":"Done","commit_id":"f172d51c01473b5c0c309c4eca09c1f950ae1411"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"60f73721b8436d22884a974be9d5999e11fc5e35","unresolved":false,"context_lines":[{"line_number":536,"context_line":"    def test_is_deleted(self, mock__manager):"},{"line_number":537,"context_line":"        mock__manager.return_value.get.return_value \u003d []"},{"line_number":538,"context_line":"        fres \u003d resources.FuelEnvironment()"},{"line_number":539,"context_line":"        fres.id \u003d mock.Mock()"},{"line_number":540,"context_line":"        self.assertTrue(fres.is_deleted())"},{"line_number":541,"context_line":"        mock__manager.return_value.get.return_value \u003d [\"env\"]"},{"line_number":542,"context_line":"        self.assertFalse(fres.is_deleted())"}],"source_content_type":"text/x-python","patch_set":33,"id":"da20952f_c8e8fbb5","line":539,"updated":"2015-09-04 13:32:38.000000000","message":"This should not be a mock, but some simple value like \"foo_id\"","commit_id":"f172d51c01473b5c0c309c4eca09c1f950ae1411"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"a68144bb27b2b6fc93d8a06092fefafa74a968c8","unresolved":false,"context_lines":[{"line_number":536,"context_line":"    def test_is_deleted(self, mock__manager):"},{"line_number":537,"context_line":"        mock__manager.return_value.get.return_value \u003d []"},{"line_number":538,"context_line":"        fres \u003d resources.FuelEnvironment()"},{"line_number":539,"context_line":"        fres.id \u003d mock.Mock()"},{"line_number":540,"context_line":"        self.assertTrue(fres.is_deleted())"},{"line_number":541,"context_line":"        mock__manager.return_value.get.return_value \u003d [\"env\"]"},{"line_number":542,"context_line":"        self.assertFalse(fres.is_deleted())"}],"source_content_type":"text/x-python","patch_set":33,"id":"da20952f_4cf03691","line":539,"in_reply_to":"da20952f_6dbe6266","updated":"2015-09-07 14:56:30.000000000","message":"Ok","commit_id":"f172d51c01473b5c0c309c4eca09c1f950ae1411"},{"author":{"_account_id":9601,"name":"Oleh Anufriiev","email":"oanufriev@mirantis.com","username":"oanufriev"},"change_message_id":"0f9720994a1192ccd1d064d64357b62ec3cd7f04","unresolved":false,"context_lines":[{"line_number":536,"context_line":"    def test_is_deleted(self, mock__manager):"},{"line_number":537,"context_line":"        mock__manager.return_value.get.return_value \u003d []"},{"line_number":538,"context_line":"        fres \u003d resources.FuelEnvironment()"},{"line_number":539,"context_line":"        fres.id \u003d mock.Mock()"},{"line_number":540,"context_line":"        self.assertTrue(fres.is_deleted())"},{"line_number":541,"context_line":"        mock__manager.return_value.get.return_value \u003d [\"env\"]"},{"line_number":542,"context_line":"        self.assertFalse(fres.is_deleted())"}],"source_content_type":"text/x-python","patch_set":33,"id":"da20952f_6dbe6266","line":539,"in_reply_to":"da20952f_c8e8fbb5","updated":"2015-09-07 10:24:10.000000000","message":"Mock, cause\u0027id\u0027 is a method of resources.FuelEnvironmen class.","commit_id":"f172d51c01473b5c0c309c4eca09c1f950ae1411"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"60f73721b8436d22884a974be9d5999e11fc5e35","unresolved":false,"context_lines":[{"line_number":538,"context_line":"        fres \u003d resources.FuelEnvironment()"},{"line_number":539,"context_line":"        fres.id \u003d mock.Mock()"},{"line_number":540,"context_line":"        self.assertTrue(fres.is_deleted())"},{"line_number":541,"context_line":"        mock__manager.return_value.get.return_value \u003d [\"env\"]"},{"line_number":542,"context_line":"        self.assertFalse(fres.is_deleted())"}],"source_content_type":"text/x-python","patch_set":33,"id":"da20952f_a8958732","line":541,"updated":"2015-09-04 13:32:38.000000000","message":"Use str or dict return value, not list (this is confusing)","commit_id":"f172d51c01473b5c0c309c4eca09c1f950ae1411"},{"author":{"_account_id":9601,"name":"Oleh Anufriiev","email":"oanufriev@mirantis.com","username":"oanufriev"},"change_message_id":"0f9720994a1192ccd1d064d64357b62ec3cd7f04","unresolved":false,"context_lines":[{"line_number":538,"context_line":"        fres \u003d resources.FuelEnvironment()"},{"line_number":539,"context_line":"        fres.id \u003d mock.Mock()"},{"line_number":540,"context_line":"        self.assertTrue(fres.is_deleted())"},{"line_number":541,"context_line":"        mock__manager.return_value.get.return_value \u003d [\"env\"]"},{"line_number":542,"context_line":"        self.assertFalse(fres.is_deleted())"}],"source_content_type":"text/x-python","patch_set":33,"id":"da20952f_2db4ea7f","line":541,"in_reply_to":"da20952f_a8958732","updated":"2015-09-07 10:24:10.000000000","message":"Done","commit_id":"f172d51c01473b5c0c309c4eca09c1f950ae1411"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"60f73721b8436d22884a974be9d5999e11fc5e35","unresolved":false,"context_lines":[{"line_number":539,"context_line":"        fres.id \u003d mock.Mock()"},{"line_number":540,"context_line":"        self.assertTrue(fres.is_deleted())"},{"line_number":541,"context_line":"        mock__manager.return_value.get.return_value \u003d [\"env\"]"},{"line_number":542,"context_line":"        self.assertFalse(fres.is_deleted())"}],"source_content_type":"text/x-python","patch_set":33,"id":"da20952f_68cbef53","line":542,"updated":"2015-09-04 13:32:38.000000000","message":"Add assert that env manager get() method is called with env id","commit_id":"f172d51c01473b5c0c309c4eca09c1f950ae1411"},{"author":{"_account_id":9601,"name":"Oleh Anufriiev","email":"oanufriev@mirantis.com","username":"oanufriev"},"change_message_id":"0f9720994a1192ccd1d064d64357b62ec3cd7f04","unresolved":false,"context_lines":[{"line_number":539,"context_line":"        fres.id \u003d mock.Mock()"},{"line_number":540,"context_line":"        self.assertTrue(fres.is_deleted())"},{"line_number":541,"context_line":"        mock__manager.return_value.get.return_value \u003d [\"env\"]"},{"line_number":542,"context_line":"        self.assertFalse(fres.is_deleted())"}],"source_content_type":"text/x-python","patch_set":33,"id":"da20952f_6d1ae27e","line":542,"in_reply_to":"da20952f_68cbef53","updated":"2015-09-07 10:24:10.000000000","message":"Done","commit_id":"f172d51c01473b5c0c309c4eca09c1f950ae1411"}],"tests/unit/plugins/openstack/scenarios/fuel/test_environments.py":[{"author":{"_account_id":13609,"name":"Pavel Boldin","email":"pboldin@mirantis.com","username":"pboldin"},"change_message_id":"ce1abdf33f781460b961bbb95ff14c466f5dee73","unresolved":false,"context_lines":[{"line_number":26,"context_line":"        scenario._create_environment \u003d mock.Mock()"},{"line_number":27,"context_line":"        scenario._list_environments \u003d mock.Mock()"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"        self.assertIsNone(scenario.create_and_list_environments())"},{"line_number":30,"context_line":"        scenario._create_environment.assert_called_once_with("},{"line_number":31,"context_line":"            release_id\u003d1, network_provider\u003d\"neutron\","},{"line_number":32,"context_line":"            deployment_mode\u003d\"ha_compact\", net_segment_type\u003d\"vlan\")"}],"source_content_type":"text/x-python","patch_set":11,"id":"3afb71cf_1d0eb2e5","line":29,"updated":"2015-06-11 21:15:23.000000000","message":"Well, actually, `assertIsNone\u0027 was kinda joke.\n\nThe bad thing about this line is that it hides away the method-in-test call and this is bad.\n\nSo, if you want to keep it (please do, because we actually use the scenario\u0027s return value in rally and it *must* comply to a format or be None) please make the following:\n\n retval \u003d scenario.create_and_list_environments()\n self.assertIsNone(retval)","commit_id":"63a7d4562e97685ff3b26276b6d85efbf11c6158"},{"author":{"_account_id":9601,"name":"Oleh Anufriiev","email":"oanufriev@mirantis.com","username":"oanufriev"},"change_message_id":"46eb3f43931340768e2e9b38ac84fb534d6d5105","unresolved":false,"context_lines":[{"line_number":26,"context_line":"        scenario._create_environment \u003d mock.Mock()"},{"line_number":27,"context_line":"        scenario._list_environments \u003d mock.Mock()"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"        self.assertIsNone(scenario.create_and_list_environments())"},{"line_number":30,"context_line":"        scenario._create_environment.assert_called_once_with("},{"line_number":31,"context_line":"            release_id\u003d1, network_provider\u003d\"neutron\","},{"line_number":32,"context_line":"            deployment_mode\u003d\"ha_compact\", net_segment_type\u003d\"vlan\")"}],"source_content_type":"text/x-python","patch_set":11,"id":"1af86dd1_28f36875","line":29,"in_reply_to":"3afb71cf_1d0eb2e5","updated":"2015-06-12 15:03:46.000000000","message":"Done","commit_id":"63a7d4562e97685ff3b26276b6d85efbf11c6158"},{"author":{"_account_id":13609,"name":"Pavel Boldin","email":"pboldin@mirantis.com","username":"pboldin"},"change_message_id":"ce1abdf33f781460b961bbb95ff14c466f5dee73","unresolved":false,"context_lines":[{"line_number":38,"context_line":"        scenario._create_environment \u003d mock.Mock(return_value\u003d42)"},{"line_number":39,"context_line":"        scenario._delete_environment \u003d mock.Mock()"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"        self.assertIsNone(scenario.create_and_delete_environments())"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"        scenario._create_environment.assert_called_once_with("},{"line_number":44,"context_line":"            release_id\u003d1, network_provider\u003d\"neutron\","}],"source_content_type":"text/x-python","patch_set":11,"id":"3afb71cf_bd22feff","line":41,"updated":"2015-06-11 21:15:23.000000000","message":"Same applies here.\n\nBut there is one more thing: please call the scenarios with some foo/bar args so you can really check that the argument is passed and not hardcoded to the default.\n\nIt saved me once that I pass foobars because I wrote:\n\n utility_param\u003d\"scenario_param\"\n\ninstead of\n\n utility_param\u003dscenario_param","commit_id":"63a7d4562e97685ff3b26276b6d85efbf11c6158"},{"author":{"_account_id":9601,"name":"Oleh Anufriiev","email":"oanufriev@mirantis.com","username":"oanufriev"},"change_message_id":"28060a9b563635fd7f8fd5a382a4d702341fda92","unresolved":false,"context_lines":[{"line_number":38,"context_line":"        scenario._create_environment \u003d mock.Mock(return_value\u003d42)"},{"line_number":39,"context_line":"        scenario._delete_environment \u003d mock.Mock()"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"        self.assertIsNone(scenario.create_and_delete_environments())"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"        scenario._create_environment.assert_called_once_with("},{"line_number":44,"context_line":"            release_id\u003d1, network_provider\u003d\"neutron\","}],"source_content_type":"text/x-python","patch_set":11,"id":"ba3cc151_03ade930","line":41,"in_reply_to":"3afb71cf_bd22feff","updated":"2015-07-06 15:23:55.000000000","message":"Done","commit_id":"63a7d4562e97685ff3b26276b6d85efbf11c6158"}],"tests/unit/plugins/openstack/scenarios/fuel/test_utils.py":[{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"5146e917a3f04a1d67ace311a5103675aa5b2990","unresolved":false,"context_lines":[{"line_number":106,"context_line":""},{"line_number":107,"context_line":"    def test_create(self):"},{"line_number":108,"context_line":"        client \u003d mock.Mock()"},{"line_number":109,"context_line":"        client.create \u003d mock.Mock(return_value\u003d\"env\")"},{"line_number":110,"context_line":"        fenv \u003d utils._fuel_env(client)"},{"line_number":111,"context_line":"        kwargs \u003d {\"release_id\": 42, \"network_provider\": \"testprov\","},{"line_number":112,"context_line":"                  \"deployment_mode\": \"some_mode\", \"net_segment_type\": \"bar\"}"}],"source_content_type":"text/x-python","patch_set":8,"id":"3afb71cf_918f2223","line":109,"updated":"2015-06-05 15:15:38.000000000","message":"Mock creates mock-properties on the fly, so you can write this instead:\n\n client.create.return_value \u003d \"env\"","commit_id":"4bb5eb6f13a78d981614d9b497aed02088c9cbdc"},{"author":{"_account_id":9601,"name":"Oleh Anufriiev","email":"oanufriev@mirantis.com","username":"oanufriev"},"change_message_id":"48b23f4714b1ff75767bd6284cc4febc166436a1","unresolved":false,"context_lines":[{"line_number":106,"context_line":""},{"line_number":107,"context_line":"    def test_create(self):"},{"line_number":108,"context_line":"        client \u003d mock.Mock()"},{"line_number":109,"context_line":"        client.create \u003d mock.Mock(return_value\u003d\"env\")"},{"line_number":110,"context_line":"        fenv \u003d utils._fuel_env(client)"},{"line_number":111,"context_line":"        kwargs \u003d {\"release_id\": 42, \"network_provider\": \"testprov\","},{"line_number":112,"context_line":"                  \"deployment_mode\": \"some_mode\", \"net_segment_type\": \"bar\"}"}],"source_content_type":"text/x-python","patch_set":8,"id":"3afb71cf_11a62bae","line":109,"in_reply_to":"3afb71cf_918f2223","updated":"2015-06-09 11:51:26.000000000","message":"Done","commit_id":"4bb5eb6f13a78d981614d9b497aed02088c9cbdc"},{"author":{"_account_id":13609,"name":"Pavel Boldin","email":"pboldin@mirantis.com","username":"pboldin"},"change_message_id":"ce1abdf33f781460b961bbb95ff14c466f5dee73","unresolved":false,"context_lines":[{"line_number":112,"context_line":""},{"line_number":113,"context_line":"    def test_create_env_not_returned(self):"},{"line_number":114,"context_line":"        client \u003d mock.Mock()"},{"line_number":115,"context_line":"        client.create \u003d mock.Mock(return_value\u003dNone)"},{"line_number":116,"context_line":"        kwargs \u003d {\"release_id\": 42, \"network_provider\": \"testprov\","},{"line_number":117,"context_line":"                  \"deployment_mode\": \"some_mode\", \"net_segment_type\": \"bar\"}"},{"line_number":118,"context_line":"        fenv \u003d utils.FuelEnvManager(client)"}],"source_content_type":"text/x-python","patch_set":11,"id":"1af86dd1_83a93ee2","line":115,"updated":"2015-06-11 21:15:23.000000000","message":"You can just use:\n\n client.create.return_value \u003d None","commit_id":"63a7d4562e97685ff3b26276b6d85efbf11c6158"},{"author":{"_account_id":9601,"name":"Oleh Anufriiev","email":"oanufriev@mirantis.com","username":"oanufriev"},"change_message_id":"46eb3f43931340768e2e9b38ac84fb534d6d5105","unresolved":false,"context_lines":[{"line_number":112,"context_line":""},{"line_number":113,"context_line":"    def test_create_env_not_returned(self):"},{"line_number":114,"context_line":"        client \u003d mock.Mock()"},{"line_number":115,"context_line":"        client.create \u003d mock.Mock(return_value\u003dNone)"},{"line_number":116,"context_line":"        kwargs \u003d {\"release_id\": 42, \"network_provider\": \"testprov\","},{"line_number":117,"context_line":"                  \"deployment_mode\": \"some_mode\", \"net_segment_type\": \"bar\"}"},{"line_number":118,"context_line":"        fenv \u003d utils.FuelEnvManager(client)"}],"source_content_type":"text/x-python","patch_set":11,"id":"1af86dd1_88aa5c18","line":115,"in_reply_to":"1af86dd1_83a93ee2","updated":"2015-06-12 15:03:46.000000000","message":"Done","commit_id":"63a7d4562e97685ff3b26276b6d85efbf11c6158"},{"author":{"_account_id":13609,"name":"Pavel Boldin","email":"pboldin@mirantis.com","username":"pboldin"},"change_message_id":"ce1abdf33f781460b961bbb95ff14c466f5dee73","unresolved":false,"context_lines":[{"line_number":122,"context_line":"    @mock.patch(UTILS + \"time\")"},{"line_number":123,"context_line":"    def test_delete(self, mock_time, mock_b_scenario):"},{"line_number":124,"context_line":"        mock_b_scenario.RESOURCE_NAME_PREFIX \u003d \"\""},{"line_number":125,"context_line":"        enves \u003d [{\"id\": \"some_one\", \"name\": \"one\"}]"},{"line_number":126,"context_line":"        client \u003d mock.Mock()"},{"line_number":127,"context_line":"        client.delete_by_id \u003d mock.Mock()"},{"line_number":128,"context_line":"        client.get_all \u003d mock.Mock(return_value\u003denves)"}],"source_content_type":"text/x-python","patch_set":11,"id":"3afb71cf_e0f8cdc6","line":125,"updated":"2015-06-11 21:15:23.000000000","message":"Please don\u0027t use `enves\u0027 -- this is kinda a copy from Russian. Use `envs\u0027 instead.","commit_id":"63a7d4562e97685ff3b26276b6d85efbf11c6158"},{"author":{"_account_id":9601,"name":"Oleh Anufriiev","email":"oanufriev@mirantis.com","username":"oanufriev"},"change_message_id":"46eb3f43931340768e2e9b38ac84fb534d6d5105","unresolved":false,"context_lines":[{"line_number":122,"context_line":"    @mock.patch(UTILS + \"time\")"},{"line_number":123,"context_line":"    def test_delete(self, mock_time, mock_b_scenario):"},{"line_number":124,"context_line":"        mock_b_scenario.RESOURCE_NAME_PREFIX \u003d \"\""},{"line_number":125,"context_line":"        enves \u003d [{\"id\": \"some_one\", \"name\": \"one\"}]"},{"line_number":126,"context_line":"        client \u003d mock.Mock()"},{"line_number":127,"context_line":"        client.delete_by_id \u003d mock.Mock()"},{"line_number":128,"context_line":"        client.get_all \u003d mock.Mock(return_value\u003denves)"}],"source_content_type":"text/x-python","patch_set":11,"id":"1af86dd1_e35b332d","line":125,"in_reply_to":"3afb71cf_e0f8cdc6","updated":"2015-06-12 15:03:46.000000000","message":"Done","commit_id":"63a7d4562e97685ff3b26276b6d85efbf11c6158"},{"author":{"_account_id":13609,"name":"Pavel Boldin","email":"pboldin@mirantis.com","username":"pboldin"},"change_message_id":"ce1abdf33f781460b961bbb95ff14c466f5dee73","unresolved":false,"context_lines":[{"line_number":124,"context_line":"        mock_b_scenario.RESOURCE_NAME_PREFIX \u003d \"\""},{"line_number":125,"context_line":"        enves \u003d [{\"id\": \"some_one\", \"name\": \"one\"}]"},{"line_number":126,"context_line":"        client \u003d mock.Mock()"},{"line_number":127,"context_line":"        client.delete_by_id \u003d mock.Mock()"},{"line_number":128,"context_line":"        client.get_all \u003d mock.Mock(return_value\u003denves)"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"        fenv \u003d utils.FuelEnvManager(client)"}],"source_content_type":"text/x-python","patch_set":11,"id":"1af86dd1_63af62e4","line":127,"updated":"2015-06-11 21:15:23.000000000","message":"This line is not necessary.","commit_id":"63a7d4562e97685ff3b26276b6d85efbf11c6158"},{"author":{"_account_id":9601,"name":"Oleh Anufriiev","email":"oanufriev@mirantis.com","username":"oanufriev"},"change_message_id":"46eb3f43931340768e2e9b38ac84fb534d6d5105","unresolved":false,"context_lines":[{"line_number":124,"context_line":"        mock_b_scenario.RESOURCE_NAME_PREFIX \u003d \"\""},{"line_number":125,"context_line":"        enves \u003d [{\"id\": \"some_one\", \"name\": \"one\"}]"},{"line_number":126,"context_line":"        client \u003d mock.Mock()"},{"line_number":127,"context_line":"        client.delete_by_id \u003d mock.Mock()"},{"line_number":128,"context_line":"        client.get_all \u003d mock.Mock(return_value\u003denves)"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"        fenv \u003d utils.FuelEnvManager(client)"}],"source_content_type":"text/x-python","patch_set":11,"id":"1af86dd1_23794b94","line":127,"in_reply_to":"1af86dd1_63af62e4","updated":"2015-06-12 15:03:46.000000000","message":"Done","commit_id":"63a7d4562e97685ff3b26276b6d85efbf11c6158"},{"author":{"_account_id":13609,"name":"Pavel Boldin","email":"pboldin@mirantis.com","username":"pboldin"},"change_message_id":"ce1abdf33f781460b961bbb95ff14c466f5dee73","unresolved":false,"context_lines":[{"line_number":125,"context_line":"        enves \u003d [{\"id\": \"some_one\", \"name\": \"one\"}]"},{"line_number":126,"context_line":"        client \u003d mock.Mock()"},{"line_number":127,"context_line":"        client.delete_by_id \u003d mock.Mock()"},{"line_number":128,"context_line":"        client.get_all \u003d mock.Mock(return_value\u003denves)"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"        fenv \u003d utils.FuelEnvManager(client)"},{"line_number":131,"context_line":"        self.assertRaises(RuntimeError, fenv.delete, \"some_one\", retries\u003d2,"}],"source_content_type":"text/x-python","patch_set":11,"id":"1af86dd1_a37b1a7b","line":128,"updated":"2015-06-11 21:15:23.000000000","message":"Just:\n\n client.get_all.return_value \u003d envs","commit_id":"63a7d4562e97685ff3b26276b6d85efbf11c6158"},{"author":{"_account_id":9601,"name":"Oleh Anufriiev","email":"oanufriev@mirantis.com","username":"oanufriev"},"change_message_id":"46eb3f43931340768e2e9b38ac84fb534d6d5105","unresolved":false,"context_lines":[{"line_number":125,"context_line":"        enves \u003d [{\"id\": \"some_one\", \"name\": \"one\"}]"},{"line_number":126,"context_line":"        client \u003d mock.Mock()"},{"line_number":127,"context_line":"        client.delete_by_id \u003d mock.Mock()"},{"line_number":128,"context_line":"        client.get_all \u003d mock.Mock(return_value\u003denves)"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"        fenv \u003d utils.FuelEnvManager(client)"},{"line_number":131,"context_line":"        self.assertRaises(RuntimeError, fenv.delete, \"some_one\", retries\u003d2,"}],"source_content_type":"text/x-python","patch_set":11,"id":"1af86dd1_23a02bf4","line":128,"in_reply_to":"1af86dd1_a37b1a7b","updated":"2015-06-12 15:03:46.000000000","message":"Done","commit_id":"63a7d4562e97685ff3b26276b6d85efbf11c6158"},{"author":{"_account_id":13609,"name":"Pavel Boldin","email":"pboldin@mirantis.com","username":"pboldin"},"change_message_id":"ce1abdf33f781460b961bbb95ff14c466f5dee73","unresolved":false,"context_lines":[{"line_number":139,"context_line":"        mock_b_scenario.RESOURCE_NAME_PREFIX \u003d \"\""},{"line_number":140,"context_line":"        enves \u003d [{\"id\": \"some_one\", \"name\": \"one\"}]"},{"line_number":141,"context_line":"        client \u003d mock.Mock()"},{"line_number":142,"context_line":"        client.delete_by_id \u003d mock.Mock(side_effect\u003dBaseException)"},{"line_number":143,"context_line":"        client.get_all \u003d mock.Mock(return_value\u003denves)"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"        fenv \u003d utils.FuelEnvManager(client)"}],"source_content_type":"text/x-python","patch_set":11,"id":"1af86dd1_83f7fef4","line":142,"updated":"2015-06-11 21:15:23.000000000","message":"Same here:\n\n client.delete_by_id.side_effect \u003d BaseException\n client.get_all.return_value \u003d envs\n\nOr simply (arguably) better:\n\n client \u003d mock.Mock(**{\"delete_by_id.side_effect\": BaseException,\n  \"get_all.return_value\": envs})","commit_id":"63a7d4562e97685ff3b26276b6d85efbf11c6158"},{"author":{"_account_id":9601,"name":"Oleh Anufriiev","email":"oanufriev@mirantis.com","username":"oanufriev"},"change_message_id":"46eb3f43931340768e2e9b38ac84fb534d6d5105","unresolved":false,"context_lines":[{"line_number":139,"context_line":"        mock_b_scenario.RESOURCE_NAME_PREFIX \u003d \"\""},{"line_number":140,"context_line":"        enves \u003d [{\"id\": \"some_one\", \"name\": \"one\"}]"},{"line_number":141,"context_line":"        client \u003d mock.Mock()"},{"line_number":142,"context_line":"        client.delete_by_id \u003d mock.Mock(side_effect\u003dBaseException)"},{"line_number":143,"context_line":"        client.get_all \u003d mock.Mock(return_value\u003denves)"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"        fenv \u003d utils.FuelEnvManager(client)"}],"source_content_type":"text/x-python","patch_set":11,"id":"1af86dd1_638d037b","line":142,"in_reply_to":"1af86dd1_83f7fef4","updated":"2015-06-12 15:03:46.000000000","message":"Done","commit_id":"63a7d4562e97685ff3b26276b6d85efbf11c6158"},{"author":{"_account_id":13609,"name":"Pavel Boldin","email":"pboldin@mirantis.com","username":"pboldin"},"change_message_id":"ce1abdf33f781460b961bbb95ff14c466f5dee73","unresolved":false,"context_lines":[{"line_number":154,"context_line":""},{"line_number":155,"context_line":"    @mock.patch(UTILS + \"FuelEnvManager\")"},{"line_number":156,"context_line":"    @mock.patch(UTILS + \"os\")"},{"line_number":157,"context_line":"    def test___init__(self, mock_os, mockFuelEnvManager):"},{"line_number":158,"context_line":"        mock_os.environ \u003d {}"},{"line_number":159,"context_line":"        mock_fuelclient \u003d mock.Mock(get_client\u003dlambda *args, **kw: [args, kw])"},{"line_number":160,"context_line":"        with mock.patch.dict(\"sys.modules\", {\"fuelclient\": mock_fuelclient}):"}],"source_content_type":"text/x-python","patch_set":11,"id":"3afb71cf_e0a20d9a","line":157,"updated":"2015-06-11 21:15:23.000000000","message":"Please use:\n mock_fuel_env_manager","commit_id":"63a7d4562e97685ff3b26276b6d85efbf11c6158"},{"author":{"_account_id":9601,"name":"Oleh Anufriiev","email":"oanufriev@mirantis.com","username":"oanufriev"},"change_message_id":"46eb3f43931340768e2e9b38ac84fb534d6d5105","unresolved":false,"context_lines":[{"line_number":154,"context_line":""},{"line_number":155,"context_line":"    @mock.patch(UTILS + \"FuelEnvManager\")"},{"line_number":156,"context_line":"    @mock.patch(UTILS + \"os\")"},{"line_number":157,"context_line":"    def test___init__(self, mock_os, mockFuelEnvManager):"},{"line_number":158,"context_line":"        mock_os.environ \u003d {}"},{"line_number":159,"context_line":"        mock_fuelclient \u003d mock.Mock(get_client\u003dlambda *args, **kw: [args, kw])"},{"line_number":160,"context_line":"        with mock.patch.dict(\"sys.modules\", {\"fuelclient\": mock_fuelclient}):"}],"source_content_type":"text/x-python","patch_set":11,"id":"1af86dd1_83559fc7","line":157,"in_reply_to":"3afb71cf_e0a20d9a","updated":"2015-06-12 15:03:46.000000000","message":"Done","commit_id":"63a7d4562e97685ff3b26276b6d85efbf11c6158"},{"author":{"_account_id":13609,"name":"Pavel Boldin","email":"pboldin@mirantis.com","username":"pboldin"},"change_message_id":"ce1abdf33f781460b961bbb95ff14c466f5dee73","unresolved":false,"context_lines":[{"line_number":174,"context_line":"                             client.node)"},{"line_number":175,"context_line":"            self.assertEqual([(\"task\",), {\"version\": \"foo_version\"}],"},{"line_number":176,"context_line":"                             client.task)"},{"line_number":177,"context_line":"            mockFuelEnvManager.asser_called_once_with("},{"line_number":178,"context_line":"                {\"version\": \"foo_version\"})"},{"line_number":179,"context_line":""},{"line_number":180,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"3afb71cf_40e1e1cf","line":177,"updated":"2015-06-11 21:15:23.000000000","message":"typo:\nassert_called_once_with","commit_id":"63a7d4562e97685ff3b26276b6d85efbf11c6158"},{"author":{"_account_id":9601,"name":"Oleh Anufriiev","email":"oanufriev@mirantis.com","username":"oanufriev"},"change_message_id":"46eb3f43931340768e2e9b38ac84fb534d6d5105","unresolved":false,"context_lines":[{"line_number":174,"context_line":"                             client.node)"},{"line_number":175,"context_line":"            self.assertEqual([(\"task\",), {\"version\": \"foo_version\"}],"},{"line_number":176,"context_line":"                             client.task)"},{"line_number":177,"context_line":"            mockFuelEnvManager.asser_called_once_with("},{"line_number":178,"context_line":"                {\"version\": \"foo_version\"})"},{"line_number":179,"context_line":""},{"line_number":180,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"1af86dd1_03588ff9","line":177,"in_reply_to":"3afb71cf_40e1e1cf","updated":"2015-06-12 15:03:46.000000000","message":"Done","commit_id":"63a7d4562e97685ff3b26276b6d85efbf11c6158"},{"author":{"_account_id":13609,"name":"Pavel Boldin","email":"pboldin@mirantis.com","username":"pboldin"},"change_message_id":"ce1abdf33f781460b961bbb95ff14c466f5dee73","unresolved":false,"context_lines":[{"line_number":181,"context_line":"class FuelScenarioTestCase(test.ClientsTestCase):"},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"    @mock.patch(UTILS + \"FuelScenario.admin_clients\")"},{"line_number":184,"context_line":"    def test__list_environments(self, mock_clients):"},{"line_number":185,"context_line":"        mock_admin \u003d mock.Mock()"},{"line_number":186,"context_line":"        mock_clients.return_value \u003d mock_admin"},{"line_number":187,"context_line":"        mock_admin.environment.list.return_value \u003d ("}],"source_content_type":"text/x-python","patch_set":11,"id":"1af86dd1_03e42e39","line":184,"updated":"2015-06-11 21:15:23.000000000","message":"Please use newly introduced self.admin_clients(\"fuel\") from ClientsTestCase instead.","commit_id":"63a7d4562e97685ff3b26276b6d85efbf11c6158"},{"author":{"_account_id":9601,"name":"Oleh Anufriiev","email":"oanufriev@mirantis.com","username":"oanufriev"},"change_message_id":"28060a9b563635fd7f8fd5a382a4d702341fda92","unresolved":false,"context_lines":[{"line_number":181,"context_line":"class FuelScenarioTestCase(test.ClientsTestCase):"},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"    @mock.patch(UTILS + \"FuelScenario.admin_clients\")"},{"line_number":184,"context_line":"    def test__list_environments(self, mock_clients):"},{"line_number":185,"context_line":"        mock_admin \u003d mock.Mock()"},{"line_number":186,"context_line":"        mock_clients.return_value \u003d mock_admin"},{"line_number":187,"context_line":"        mock_admin.environment.list.return_value \u003d ("}],"source_content_type":"text/x-python","patch_set":11,"id":"ba3cc151_46ec5f8f","line":184,"in_reply_to":"1af86dd1_03e42e39","updated":"2015-07-06 15:23:55.000000000","message":"Done","commit_id":"63a7d4562e97685ff3b26276b6d85efbf11c6158"},{"author":{"_account_id":13609,"name":"Pavel Boldin","email":"pboldin@mirantis.com","username":"pboldin"},"change_message_id":"ce1abdf33f781460b961bbb95ff14c466f5dee73","unresolved":false,"context_lines":[{"line_number":196,"context_line":"    @mock.patch(UTILS + \"base.Scenario\")"},{"line_number":197,"context_line":"    def test__create_environment(self, mock_b_scenario):"},{"line_number":198,"context_line":"        mock_b_scenario.RESOURCE_NAME_PREFIX \u003d \"pref\""},{"line_number":199,"context_line":"        admin_clients \u003d mock.Mock()"},{"line_number":200,"context_line":"        admin_clients.return_value.environment.create.return_value \u003d {\"id\": 42}"},{"line_number":201,"context_line":""},{"line_number":202,"context_line":"        fscen \u003d utils.FuelScenario()"}],"source_content_type":"text/x-python","patch_set":11,"id":"1af86dd1_23be0a00","line":199,"updated":"2015-06-11 21:15:23.000000000","message":"Same here.","commit_id":"63a7d4562e97685ff3b26276b6d85efbf11c6158"},{"author":{"_account_id":9601,"name":"Oleh Anufriiev","email":"oanufriev@mirantis.com","username":"oanufriev"},"change_message_id":"28060a9b563635fd7f8fd5a382a4d702341fda92","unresolved":false,"context_lines":[{"line_number":196,"context_line":"    @mock.patch(UTILS + \"base.Scenario\")"},{"line_number":197,"context_line":"    def test__create_environment(self, mock_b_scenario):"},{"line_number":198,"context_line":"        mock_b_scenario.RESOURCE_NAME_PREFIX \u003d \"pref\""},{"line_number":199,"context_line":"        admin_clients \u003d mock.Mock()"},{"line_number":200,"context_line":"        admin_clients.return_value.environment.create.return_value \u003d {\"id\": 42}"},{"line_number":201,"context_line":""},{"line_number":202,"context_line":"        fscen \u003d utils.FuelScenario()"}],"source_content_type":"text/x-python","patch_set":11,"id":"ba3cc151_06ff3735","line":199,"in_reply_to":"1af86dd1_23be0a00","updated":"2015-07-06 15:23:55.000000000","message":"Done","commit_id":"63a7d4562e97685ff3b26276b6d85efbf11c6158"},{"author":{"_account_id":13609,"name":"Pavel Boldin","email":"pboldin@mirantis.com","username":"pboldin"},"change_message_id":"ce1abdf33f781460b961bbb95ff14c466f5dee73","unresolved":false,"context_lines":[{"line_number":199,"context_line":"        admin_clients \u003d mock.Mock()"},{"line_number":200,"context_line":"        admin_clients.return_value.environment.create.return_value \u003d {\"id\": 42}"},{"line_number":201,"context_line":""},{"line_number":202,"context_line":"        fscen \u003d utils.FuelScenario()"},{"line_number":203,"context_line":"        fscen.admin_clients \u003d admin_clients"},{"line_number":204,"context_line":""},{"line_number":205,"context_line":"        fscen._generate_random_name \u003d mock.Mock("}],"source_content_type":"text/x-python","patch_set":11,"id":"1af86dd1_a3c9daae","line":202,"updated":"2015-06-11 21:15:23.000000000","message":"Please name it either a `scenario\u0027 or `fuel_scenario\u0027. fscen is confusing.","commit_id":"63a7d4562e97685ff3b26276b6d85efbf11c6158"},{"author":{"_account_id":9601,"name":"Oleh Anufriiev","email":"oanufriev@mirantis.com","username":"oanufriev"},"change_message_id":"46eb3f43931340768e2e9b38ac84fb534d6d5105","unresolved":false,"context_lines":[{"line_number":199,"context_line":"        admin_clients \u003d mock.Mock()"},{"line_number":200,"context_line":"        admin_clients.return_value.environment.create.return_value \u003d {\"id\": 42}"},{"line_number":201,"context_line":""},{"line_number":202,"context_line":"        fscen \u003d utils.FuelScenario()"},{"line_number":203,"context_line":"        fscen.admin_clients \u003d admin_clients"},{"line_number":204,"context_line":""},{"line_number":205,"context_line":"        fscen._generate_random_name \u003d mock.Mock("}],"source_content_type":"text/x-python","patch_set":11,"id":"1af86dd1_a3f65bd5","line":202,"in_reply_to":"1af86dd1_a3c9daae","updated":"2015-06-12 15:03:46.000000000","message":"Done","commit_id":"63a7d4562e97685ff3b26276b6d85efbf11c6158"},{"author":{"_account_id":13609,"name":"Pavel Boldin","email":"pboldin@mirantis.com","username":"pboldin"},"change_message_id":"ce1abdf33f781460b961bbb95ff14c466f5dee73","unresolved":false,"context_lines":[{"line_number":216,"context_line":"            \"ha_compact\", \"vlan\")"},{"line_number":217,"context_line":""},{"line_number":218,"context_line":"    def test__delete_environment(self):"},{"line_number":219,"context_line":"        fscen \u003d utils.FuelScenario()"},{"line_number":220,"context_line":"        fscen.admin_clients \u003d mock.Mock()"},{"line_number":221,"context_line":"        fscen._delete_environment(42, 33, 15)"},{"line_number":222,"context_line":"        tmp_mock \u003d fscen.admin_clients.return_value"}],"source_content_type":"text/x-python","patch_set":11,"id":"1af86dd1_8345be18","line":219,"updated":"2015-06-11 21:15:23.000000000","message":"Use admin_clients\u003dself.admin_clients instead.","commit_id":"63a7d4562e97685ff3b26276b6d85efbf11c6158"},{"author":{"_account_id":9601,"name":"Oleh Anufriiev","email":"oanufriev@mirantis.com","username":"oanufriev"},"change_message_id":"28060a9b563635fd7f8fd5a382a4d702341fda92","unresolved":false,"context_lines":[{"line_number":216,"context_line":"            \"ha_compact\", \"vlan\")"},{"line_number":217,"context_line":""},{"line_number":218,"context_line":"    def test__delete_environment(self):"},{"line_number":219,"context_line":"        fscen \u003d utils.FuelScenario()"},{"line_number":220,"context_line":"        fscen.admin_clients \u003d mock.Mock()"},{"line_number":221,"context_line":"        fscen._delete_environment(42, 33, 15)"},{"line_number":222,"context_line":"        tmp_mock \u003d fscen.admin_clients.return_value"}],"source_content_type":"text/x-python","patch_set":11,"id":"ba3cc151_f7943b45","line":219,"in_reply_to":"1af86dd1_8345be18","updated":"2015-07-06 15:23:55.000000000","message":"Done","commit_id":"63a7d4562e97685ff3b26276b6d85efbf11c6158"},{"author":{"_account_id":7369,"name":"Sergey Skripnick","email":"sskripnick@mirantis.com","username":"redixin"},"change_message_id":"ddabafa5068170be4c09686133504140019f06e8","unresolved":false,"context_lines":[{"line_number":194,"context_line":"            return_value\u003d\"random_name\")"},{"line_number":195,"context_line":"        result \u003d fuel_scenario._create_environment()"},{"line_number":196,"context_line":"        self.assertEqual("},{"line_number":197,"context_line":"            self.admin_clients(\"fuel\").environment.create.return_value[\"id\"],"},{"line_number":198,"context_line":"            result)"},{"line_number":199,"context_line":"        fuel_scenario._generate_random_name.assert_called_once_with("},{"line_number":200,"context_line":"            prefix\u003dmock_base_scenario.RESOURCE_NAME_PREFIX)"}],"source_content_type":"text/x-python","patch_set":19,"id":"3a50d1a3_9b993571","line":197,"updated":"2015-07-21 09:38:29.000000000","message":"Why not just 42?","commit_id":"ebd8c8f881b88dc88bfa39ef7b9b4b7e95fe6977"},{"author":{"_account_id":9601,"name":"Oleh Anufriiev","email":"oanufriev@mirantis.com","username":"oanufriev"},"change_message_id":"dd1a0056ba35238d4d49eadcad62c520c35447c8","unresolved":false,"context_lines":[{"line_number":194,"context_line":"            return_value\u003d\"random_name\")"},{"line_number":195,"context_line":"        result \u003d fuel_scenario._create_environment()"},{"line_number":196,"context_line":"        self.assertEqual("},{"line_number":197,"context_line":"            self.admin_clients(\"fuel\").environment.create.return_value[\"id\"],"},{"line_number":198,"context_line":"            result)"},{"line_number":199,"context_line":"        fuel_scenario._generate_random_name.assert_called_once_with("},{"line_number":200,"context_line":"            prefix\u003dmock_base_scenario.RESOURCE_NAME_PREFIX)"}],"source_content_type":"text/x-python","patch_set":19,"id":"3a50d1a3_583cfee1","line":197,"in_reply_to":"3a50d1a3_9b993571","updated":"2015-07-22 17:35:34.000000000","message":":)\n\ncause in this way i can change id at one place, not two.","commit_id":"ebd8c8f881b88dc88bfa39ef7b9b4b7e95fe6977"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"b19cc261f762fb683ea82bb56d8234d4f2042912","unresolved":false,"context_lines":[{"line_number":88,"context_line":"            {\"name\": mock_base_scenario.RESOURCE_NAME_PREFIX + \"one\"},"},{"line_number":89,"context_line":"            {\"name\": mock_base_scenario.RESOURCE_NAME_PREFIX + \"two\"},"},{"line_number":90,"context_line":"            {\"name\": \"three\"}]"},{"line_number":91,"context_line":"        client.get_all \u003d mock.Mock(return_value\u003denvs)"},{"line_number":92,"context_line":"        fenv \u003d utils.FuelEnvManager(client)"},{"line_number":93,"context_line":"        self.assertEqual(envs[:-1], fenv.list())"},{"line_number":94,"context_line":""}],"source_content_type":"text/x-python","patch_set":23,"id":"1a4dcd0f_2c8531ac","line":91,"updated":"2015-08-11 09:57:34.000000000","message":"This is shorter:\n\n client.get_all.return_value \u003d envs","commit_id":"88ef81f6a3fb36604d65aa9797930ce6ea60db79"},{"author":{"_account_id":9601,"name":"Oleh Anufriiev","email":"oanufriev@mirantis.com","username":"oanufriev"},"change_message_id":"8643ccdc6334f9f7cf0e30ec6657c41c9c123206","unresolved":false,"context_lines":[{"line_number":88,"context_line":"            {\"name\": mock_base_scenario.RESOURCE_NAME_PREFIX + \"one\"},"},{"line_number":89,"context_line":"            {\"name\": mock_base_scenario.RESOURCE_NAME_PREFIX + \"two\"},"},{"line_number":90,"context_line":"            {\"name\": \"three\"}]"},{"line_number":91,"context_line":"        client.get_all \u003d mock.Mock(return_value\u003denvs)"},{"line_number":92,"context_line":"        fenv \u003d utils.FuelEnvManager(client)"},{"line_number":93,"context_line":"        self.assertEqual(envs[:-1], fenv.list())"},{"line_number":94,"context_line":""}],"source_content_type":"text/x-python","patch_set":23,"id":"1a4dcd0f_0df514ca","line":91,"in_reply_to":"1a4dcd0f_2c8531ac","updated":"2015-08-14 12:43:43.000000000","message":"Done","commit_id":"88ef81f6a3fb36604d65aa9797930ce6ea60db79"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"42b5728b11ae79d6f323ff4a3e0f2b39f603075a","unresolved":false,"context_lines":[{"line_number":61,"context_line":"    def test_get(self):"},{"line_number":62,"context_line":"        client \u003d mock.Mock()"},{"line_number":63,"context_line":"        fenv \u003d utils.FuelEnvManager(client)"},{"line_number":64,"context_line":"        fenv.get(\"some_id\")"},{"line_number":65,"context_line":"        client.get_by_id.assert_called_once_with(\"some_id\")"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    @mock.patch(UTILS + \"scenario.Scenario\")"}],"source_content_type":"text/x-python","patch_set":29,"id":"fa1b9901_5cc77895","line":64,"updated":"2015-08-21 14:27:46.000000000","message":"Missed check for return value","commit_id":"e7c36f038943dea8b2526a1aa530799ca1966be7"},{"author":{"_account_id":9601,"name":"Oleh Anufriiev","email":"oanufriev@mirantis.com","username":"oanufriev"},"change_message_id":"5c152b7567173fba53734ac42dc04c7fc3243c5d","unresolved":false,"context_lines":[{"line_number":61,"context_line":"    def test_get(self):"},{"line_number":62,"context_line":"        client \u003d mock.Mock()"},{"line_number":63,"context_line":"        fenv \u003d utils.FuelEnvManager(client)"},{"line_number":64,"context_line":"        fenv.get(\"some_id\")"},{"line_number":65,"context_line":"        client.get_by_id.assert_called_once_with(\"some_id\")"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    @mock.patch(UTILS + \"scenario.Scenario\")"}],"source_content_type":"text/x-python","patch_set":29,"id":"fa1b9901_f79a2513","line":64,"in_reply_to":"fa1b9901_5cc77895","updated":"2015-08-21 14:49:25.000000000","message":"Done","commit_id":"e7c36f038943dea8b2526a1aa530799ca1966be7"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"42b5728b11ae79d6f323ff4a3e0f2b39f603075a","unresolved":false,"context_lines":[{"line_number":74,"context_line":"            {\"name\": \"three\"}]"},{"line_number":75,"context_line":"        client.get_all.return_value \u003d envs"},{"line_number":76,"context_line":"        fenv \u003d utils.FuelEnvManager(client)"},{"line_number":77,"context_line":"        self.assertEqual(envs[:-1], fenv.list())"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    def test_list_exception(self):"},{"line_number":80,"context_line":"        client \u003d mock.Mock()"}],"source_content_type":"text/x-python","patch_set":29,"id":"fa1b9901_dcbce8dd","line":77,"updated":"2015-08-21 14:27:46.000000000","message":"I would recommend to use explicit values instead of `envs[:-1]\u0027 - this will make test more readable and reliable","commit_id":"e7c36f038943dea8b2526a1aa530799ca1966be7"},{"author":{"_account_id":9601,"name":"Oleh Anufriiev","email":"oanufriev@mirantis.com","username":"oanufriev"},"change_message_id":"5c152b7567173fba53734ac42dc04c7fc3243c5d","unresolved":false,"context_lines":[{"line_number":74,"context_line":"            {\"name\": \"three\"}]"},{"line_number":75,"context_line":"        client.get_all.return_value \u003d envs"},{"line_number":76,"context_line":"        fenv \u003d utils.FuelEnvManager(client)"},{"line_number":77,"context_line":"        self.assertEqual(envs[:-1], fenv.list())"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    def test_list_exception(self):"},{"line_number":80,"context_line":"        client \u003d mock.Mock()"}],"source_content_type":"text/x-python","patch_set":29,"id":"fa1b9901_97b40982","line":77,"in_reply_to":"fa1b9901_dcbce8dd","updated":"2015-08-21 14:49:25.000000000","message":"Disagree, cause duplication.","commit_id":"e7c36f038943dea8b2526a1aa530799ca1966be7"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"60f73721b8436d22884a974be9d5999e11fc5e35","unresolved":false,"context_lines":[{"line_number":181,"context_line":"            return_value\u003d\"random_name\")"},{"line_number":182,"context_line":"        result \u003d fuel_scenario._create_environment()"},{"line_number":183,"context_line":"        self.assertEqual("},{"line_number":184,"context_line":"            self.admin_clients(\"fuel\").environment.create.return_value[\"id\"],"},{"line_number":185,"context_line":"            result)"},{"line_number":186,"context_line":"        fuel_scenario._generate_random_name.assert_called_once_with("},{"line_number":187,"context_line":"            prefix\u003dfuel_scenario.RESOURCE_NAME_PREFIX)"}],"source_content_type":"text/x-python","patch_set":33,"id":"da20952f_2bc1712f","line":184,"updated":"2015-09-04 13:32:38.000000000","message":"Use 42 instead of self.admin_clients(\"fuel\").environment.create.return_value[\"id\"]","commit_id":"f172d51c01473b5c0c309c4eca09c1f950ae1411"},{"author":{"_account_id":9601,"name":"Oleh Anufriiev","email":"oanufriev@mirantis.com","username":"oanufriev"},"change_message_id":"0f9720994a1192ccd1d064d64357b62ec3cd7f04","unresolved":false,"context_lines":[{"line_number":181,"context_line":"            return_value\u003d\"random_name\")"},{"line_number":182,"context_line":"        result \u003d fuel_scenario._create_environment()"},{"line_number":183,"context_line":"        self.assertEqual("},{"line_number":184,"context_line":"            self.admin_clients(\"fuel\").environment.create.return_value[\"id\"],"},{"line_number":185,"context_line":"            result)"},{"line_number":186,"context_line":"        fuel_scenario._generate_random_name.assert_called_once_with("},{"line_number":187,"context_line":"            prefix\u003dfuel_scenario.RESOURCE_NAME_PREFIX)"}],"source_content_type":"text/x-python","patch_set":33,"id":"da20952f_52d21fd2","line":184,"in_reply_to":"da20952f_2bc1712f","updated":"2015-09-07 10:24:10.000000000","message":"Why? Why self.admin_clients(\"fuel\").environment.create.return_value[\"id\"] is so bad?","commit_id":"f172d51c01473b5c0c309c4eca09c1f950ae1411"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"a68144bb27b2b6fc93d8a06092fefafa74a968c8","unresolved":false,"context_lines":[{"line_number":181,"context_line":"            return_value\u003d\"random_name\")"},{"line_number":182,"context_line":"        result \u003d fuel_scenario._create_environment()"},{"line_number":183,"context_line":"        self.assertEqual("},{"line_number":184,"context_line":"            self.admin_clients(\"fuel\").environment.create.return_value[\"id\"],"},{"line_number":185,"context_line":"            result)"},{"line_number":186,"context_line":"        fuel_scenario._generate_random_name.assert_called_once_with("},{"line_number":187,"context_line":"            prefix\u003dfuel_scenario.RESOURCE_NAME_PREFIX)"}],"source_content_type":"text/x-python","patch_set":33,"id":"da20952f_acceb257","line":184,"in_reply_to":"da20952f_52d21fd2","updated":"2015-09-07 14:56:30.000000000","message":"Because this is too long and hard to read","commit_id":"f172d51c01473b5c0c309c4eca09c1f950ae1411"}]}
