)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8840,"name":"Carlos L. Torres","email":"carlos.torres@rackspace.com","username":"carl6796"},"change_message_id":"8f634340b3bea508a0cf74d9528bf91e7273ad2b","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Pavel Boldin \u003cpboldin@mirantis.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-07-03 18:08:30 +0300"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add command_customizer context"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add `command_customizer\u0027 context that allows image customization using"},{"line_number":10,"context_line":"side effects of a command execution. E.g. one can install an application"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":18,"id":"ba3cc151_e0b7c9d5","line":7,"updated":"2015-07-09 20:50:45.000000000","message":"I find that \u0027command_customizer\u0027 might not be a good name for this. I think customizer is not even a word, and `command_customizer` does not give indication of what it actually does.\n\nIt seems that the intention of this context is to add dependencies to the image prior executing the commands.\n\nHow about something like\n\n  command_spec\n\nspec, as in specification.\n\nA CommandSpec define the dependencies needed prior executing the command, and actual command(s) to execute.","commit_id":"045d5ed7dd3cc18dd1e44acc9e2c7dc2ed677ff9"}],"rally/plugins/openstack/context/vm/command_customizer.py":[{"author":{"_account_id":8840,"name":"Carlos L. Torres","email":"carlos.torres@rackspace.com","username":"carl6796"},"change_message_id":"f648a14b09962f3254f21fc8e258445592dc7c79","unresolved":false,"context_lines":[{"line_number":91,"context_line":"            command\u003dself.config[\"command\"],"},{"line_number":92,"context_line":"            pkey\u003duser[\"keypair\"][\"private\"])"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"        if code:"},{"line_number":95,"context_line":"            raise exceptions.ScriptError("},{"line_number":96,"context_line":"                message\u003d\"Command `%(command)s\u0027 execution failed,\""},{"line_number":97,"context_line":"                \" code %(code)d:\\n\""}],"source_content_type":"text/x-python","patch_set":14,"id":"1af86dd1_70526215","line":94,"updated":"2015-06-12 16:33:43.000000000","message":"A successful command will return 0, will that be a string, or an integer?\n\nIf `code` is a string then if-statement will be true, regardless of what code returns.\n\nIf `code` is an integer, then I suggest you check explicitly that is not 0.\n\n  if code !\u003d 0:","commit_id":"a78a62682ac48b65489cd216e6bbcd6d84b266df"},{"author":{"_account_id":13609,"name":"Pavel Boldin","email":"pboldin@mirantis.com","username":"pboldin"},"change_message_id":"9ac1ca5781f6635b7113921f9b7ed34711c24c1a","unresolved":false,"context_lines":[{"line_number":91,"context_line":"            command\u003dself.config[\"command\"],"},{"line_number":92,"context_line":"            pkey\u003duser[\"keypair\"][\"private\"])"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"        if code:"},{"line_number":95,"context_line":"            raise exceptions.ScriptError("},{"line_number":96,"context_line":"                message\u003d\"Command `%(command)s\u0027 execution failed,\""},{"line_number":97,"context_line":"                \" code %(code)d:\\n\""}],"source_content_type":"text/x-python","patch_set":14,"id":"fa32b979_ebd24134","line":94,"in_reply_to":"1af86dd1_70526215","updated":"2015-06-13 00:44:09.000000000","message":"It will return whatever session.recv_exit_status() returns on the file https://github.com/openstack/rally/blob/master/rally/common/sshutils.py#L228\n\nIt is always* an integer.\n\nSorry, I don\u0027t see a reason to check for !\u003d 0. Can you point me out to one?\n\n*Always until the API is broken.","commit_id":"a78a62682ac48b65489cd216e6bbcd6d84b266df"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"60bc294b7afbe99d4411338dedc29250f0d98feb","unresolved":false,"context_lines":[{"line_number":21,"context_line":"import rally.task.context as context"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"@context.context(name\u003d\"command_customizer\", order\u003d501)"},{"line_number":25,"context_line":"class CommandCustomizerContext(custom_image.BaseCustomImageGenerator):"},{"line_number":26,"context_line":"    \"\"\"Context class for generating image customized by a command execution."},{"line_number":27,"context_line":""}],"source_content_type":"text/x-python","patch_set":18,"id":"9a41bdd9_49bb0c73","line":24,"updated":"2015-07-13 07:14:37.000000000","message":"So I dislike the name. It\u0027s really unclear without the context: \n\n  image_command_customizer\n\nwill be way better","commit_id":"045d5ed7dd3cc18dd1e44acc9e2c7dc2ed677ff9"}],"rally/plugins/openstack/context/vm/image_command_customizer.py":[{"author":{"_account_id":6835,"name":"Kun Huang","email":"gareth@openstacker.org","username":"academicgareth"},"change_message_id":"6ddbcec21dd2e780f569812eb7042aee96925833","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    Use this script e.g. to download and install something."},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    Example: samples/tasks/contexts/vm/blogbench_install.sh"},{"line_number":33,"context_line":"    \"\"\""},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    CONFIG_SCHEMA \u003d copy.deepcopy("}],"source_content_type":"text/x-python","patch_set":21,"id":"3a50d1a3_8d25c6c3","line":32,"updated":"2015-07-20 01:20:15.000000000","message":"I really like put an example here, but this file path doesn\u0027t exist :(","commit_id":"2d744ea2bfc25ada48c028e644d67c3625ecdc32"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"98c0c48f14225776eb51e1487dbfa2455ae2cb73","unresolved":false,"context_lines":[{"line_number":85,"context_line":"    }"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"    def _customize_image(self, server, fip, user):"},{"line_number":88,"context_line":"        code, out, err \u003d vm_utils.VMScenario()._run_command("},{"line_number":89,"context_line":"            fip[\"ip\"], self.config[\"port\"],"},{"line_number":90,"context_line":"            self.config[\"username\"], self.config.get(\"password\"),"},{"line_number":91,"context_line":"            command\u003dself.config[\"command\"],"}],"source_content_type":"text/x-python","patch_set":21,"id":"3a50d1a3_116bef1f","line":88,"updated":"2015-07-20 15:54:53.000000000","message":"this should be rebased properly you should pass context to VMScenario (e.g. to run from some user it)","commit_id":"2d744ea2bfc25ada48c028e644d67c3625ecdc32"}]}
