)]}'
{"rally-jobs/rally-neutron.yaml":[{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"12361210bfce2f1549883cb0a81f4cbb51854ddf","unresolved":false,"context_lines":[{"line_number":492,"context_line":"        image_command_customizer:"},{"line_number":493,"context_line":"          command:"},{"line_number":494,"context_line":"            local_path: \"/home/jenkins/.rally/extra/script_benchmark.sh\""},{"line_number":495,"context_line":"            remote_path: \"./script_benchmark.sh\""},{"line_number":496,"context_line":"          flavor:"},{"line_number":497,"context_line":"            name: \"m1.tiny\""},{"line_number":498,"context_line":"          image:"}],"source_content_type":"text/x-yaml","patch_set":26,"id":"fa1b9901_5776583f","line":495,"updated":"2015-08-17 17:41:54.000000000","message":"I don\u0027t understand how this thing work. \n\nE.g. why do you need to customize image with script that just run benchmarks?","commit_id":"db01546cf013b19c8323a72abd4a069c103467b9"},{"author":{"_account_id":13609,"name":"Pavel Boldin","email":"pboldin@mirantis.com","username":"pboldin"},"change_message_id":"5960922ec0270feea21533ee384289445b5d9f9b","unresolved":false,"context_lines":[{"line_number":492,"context_line":"        image_command_customizer:"},{"line_number":493,"context_line":"          command:"},{"line_number":494,"context_line":"            local_path: \"/home/jenkins/.rally/extra/script_benchmark.sh\""},{"line_number":495,"context_line":"            remote_path: \"./script_benchmark.sh\""},{"line_number":496,"context_line":"          flavor:"},{"line_number":497,"context_line":"            name: \"m1.tiny\""},{"line_number":498,"context_line":"          image:"}],"source_content_type":"text/x-yaml","patch_set":26,"id":"fa1b9901_73e7d0e4","line":495,"in_reply_to":"fa1b9901_5776583f","updated":"2015-08-18 09:33:29.000000000","message":"This just uploads `script_benchmark.sh\u0027 to the remote host as `$PWD/script_benchmark.sh\u0027.","commit_id":"db01546cf013b19c8323a72abd4a069c103467b9"}],"rally/plugins/openstack/scenarios/vm/vmtasks.py":[{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"04224041410ed9540cc723fe1221fbe2b830d737","unresolved":false,"context_lines":[{"line_number":20,"context_line":"from rally import exceptions"},{"line_number":21,"context_line":"from rally.plugins.openstack.scenarios.cinder import utils as cinder_utils"},{"line_number":22,"context_line":"from rally.plugins.openstack.scenarios.nova import utils as nova_utils"},{"line_number":23,"context_line":"from rally.plugins.openstack.scenarios.vm import utils as vm_utils"},{"line_number":24,"context_line":"from rally.task.scenarios import base"},{"line_number":25,"context_line":"from rally.task import types"},{"line_number":26,"context_line":"from rally.task import validation"}],"source_content_type":"text/x-python","patch_set":26,"id":"fa1b9901_f1606703","line":23,"updated":"2015-08-19 17:25:13.000000000","message":"this will be when you rebase: \n\nfrom rally.plugins.openstack import scenario","commit_id":"db01546cf013b19c8323a72abd4a069c103467b9"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"04224041410ed9540cc723fe1221fbe2b830d737","unresolved":false,"context_lines":[{"line_number":192,"context_line":"    @validation.required_services(consts.Service.NOVA, consts.Service.CINDER)"},{"line_number":193,"context_line":"    @validation.required_openstack(users\u003dTrue)"},{"line_number":194,"context_line":"    @validation.required_contexts(\"image_command_customizer\")"},{"line_number":195,"context_line":"    @base.scenario(context\u003d{\"cleanup\": [\"nova\", \"cinder\"],"},{"line_number":196,"context_line":"                            \"keypair\": {}, \"allow_ssh\": {}})"},{"line_number":197,"context_line":"    def boot_runcommand_delete_custom_image(self, **kwargs):"},{"line_number":198,"context_line":"        \"\"\"Boot a server from a custom image, run a command that outputs JSON."}],"source_content_type":"text/x-python","patch_set":26,"id":"fa1b9901_f17947c9","line":195,"updated":"2015-08-19 17:25:13.000000000","message":"@scenario.configure","commit_id":"db01546cf013b19c8323a72abd4a069c103467b9"}],"rally/task/scenarios/base.py":[{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"3e7697b2448eaadcf7aa5b46c9a6ee41126a372e","unresolved":false,"context_lines":[{"line_number":63,"context_line":"        # TODO(boris-42): This is going to be inside OpenStackScenario subclass"},{"line_number":64,"context_line":"        #                 so Rally framework won\u0027t depend on OpenStack stuff"},{"line_number":65,"context_line":"        if context:"},{"line_number":66,"context_line":"            if context.get(\"admin\", {}).get(\"endpoint\"):"},{"line_number":67,"context_line":"                self._admin_clients \u003d osclients.Clients("},{"line_number":68,"context_line":"                    context[\"admin\"][\"endpoint\"])"},{"line_number":69,"context_line":"            if context.get(\"user\", {}).get(\"endpoint\"):"}],"source_content_type":"text/x-python","patch_set":23,"id":"9a41bdd9_59ec9929","line":66,"updated":"2015-07-15 18:09:26.000000000","message":"how it relates to your scenario?","commit_id":"06f56eaf1a82dfa57882953001719450dd21aa1a"},{"author":{"_account_id":13609,"name":"Pavel Boldin","email":"pboldin@mirantis.com","username":"pboldin"},"change_message_id":"728ebcd28526bd82984928227846d16e069da7e2","unresolved":false,"context_lines":[{"line_number":63,"context_line":"        # TODO(boris-42): This is going to be inside OpenStackScenario subclass"},{"line_number":64,"context_line":"        #                 so Rally framework won\u0027t depend on OpenStack stuff"},{"line_number":65,"context_line":"        if context:"},{"line_number":66,"context_line":"            if context.get(\"admin\", {}).get(\"endpoint\"):"},{"line_number":67,"context_line":"                self._admin_clients \u003d osclients.Clients("},{"line_number":68,"context_line":"                    context[\"admin\"][\"endpoint\"])"},{"line_number":69,"context_line":"            if context.get(\"user\", {}).get(\"endpoint\"):"}],"source_content_type":"text/x-python","patch_set":23,"id":"9a41bdd9_f8ea3eda","line":66,"in_reply_to":"9a41bdd9_380e66e5","updated":"2015-07-15 21:59:57.000000000","message":"Well, the thing is: the code is broken.\n\nRequiring that \"admin\" if present, has \"endpoint\" of type Endpoint object and so does \"user\" is an overkill.","commit_id":"06f56eaf1a82dfa57882953001719450dd21aa1a"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"bb21a832af1d59d01a6b41d1d09e32ed1a58e63c","unresolved":false,"context_lines":[{"line_number":63,"context_line":"        # TODO(boris-42): This is going to be inside OpenStackScenario subclass"},{"line_number":64,"context_line":"        #                 so Rally framework won\u0027t depend on OpenStack stuff"},{"line_number":65,"context_line":"        if context:"},{"line_number":66,"context_line":"            if context.get(\"admin\", {}).get(\"endpoint\"):"},{"line_number":67,"context_line":"                self._admin_clients \u003d osclients.Clients("},{"line_number":68,"context_line":"                    context[\"admin\"][\"endpoint\"])"},{"line_number":69,"context_line":"            if context.get(\"user\", {}).get(\"endpoint\"):"}],"source_content_type":"text/x-python","patch_set":23,"id":"9a41bdd9_380e66e5","line":66,"in_reply_to":"9a41bdd9_59ec9929","updated":"2015-07-15 21:57:15.000000000","message":"So I would prefer to avoid this change. \n\nSeems like trying to avoid fixing unittest and instead of that making code pass them.","commit_id":"06f56eaf1a82dfa57882953001719450dd21aa1a"}],"samples/tasks/scenarios/vm/boot_runcommand_delete_custom_image.json":[{"author":{"_account_id":6835,"name":"Kun Huang","email":"gareth@openstacker.org","username":"academicgareth"},"change_message_id":"eac5682f1c1fab8bb8c7e2315560eb369b07d831","unresolved":false,"context_lines":[{"line_number":2,"context_line":"    \"VMTasks.boot_runcommand_delete_custom_image\": ["},{"line_number":3,"context_line":"        {"},{"line_number":4,"context_line":"            \"args\": {"},{"line_number":5,"context_line":"                \"flavor\": {\"name\": \"m1.small\"},"},{"line_number":6,"context_line":"                \"command\": {"},{"line_number":7,"context_line":"                    \"remote_path\": \"./instance_dd_test.sh\""},{"line_number":8,"context_line":"                },"}],"source_content_type":"application/json","patch_set":26,"id":"1a4dcd0f_4fa5e144","line":5,"updated":"2015-08-06 02:57:09.000000000","message":"could we get a proper flavor from context? not setting it again will improve user experience here","commit_id":"db01546cf013b19c8323a72abd4a069c103467b9"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"79b084ab99c3220b99eb666434095c5290f8f132","unresolved":false,"context_lines":[{"line_number":2,"context_line":"    \"VMTasks.boot_runcommand_delete_custom_image\": ["},{"line_number":3,"context_line":"        {"},{"line_number":4,"context_line":"            \"args\": {"},{"line_number":5,"context_line":"                \"flavor\": {\"name\": \"m1.small\"},"},{"line_number":6,"context_line":"                \"command\": {"},{"line_number":7,"context_line":"                    \"remote_path\": \"./instance_dd_test.sh\""},{"line_number":8,"context_line":"                },"}],"source_content_type":"application/json","patch_set":26,"id":"1a4dcd0f_d8a77509","line":5,"in_reply_to":"1a4dcd0f_4fa5e144","updated":"2015-08-06 04:48:08.000000000","message":"Actually in some cases it can be useful that flavors can be different.\n\nSo I would like to keep it as is.","commit_id":"db01546cf013b19c8323a72abd4a069c103467b9"}]}
