)]}'
{"rally/benchmark/scenarios/nova/keypairs.py":[{"author":{"_account_id":7369,"name":"Sergey Skripnick","email":"sskripnick@mirantis.com","username":"redixin"},"change_message_id":"07fd3e55295bf7b1962828f068877d108d6522ff","unresolved":false,"context_lines":[{"line_number":74,"context_line":""},{"line_number":75,"context_line":"        keypair \u003d self._create_keypair(**kwargs)"},{"line_number":76,"context_line":"        server \u003d self._boot_server(image, flavor,"},{"line_number":77,"context_line":"                                   key_name\u003dkeypair, **kwargs)"},{"line_number":78,"context_line":"        self._delete_server(server)"},{"line_number":79,"context_line":"        self._delete_keypair(keypair)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a016987_539e3957","line":77,"updated":"2015-05-15 09:56:14.000000000","message":"the same kwargs for create_keypair and for boot_server?","commit_id":"f1eb9de5eeb13f007c0e44bf8bbd884d5a9f0989"},{"author":{"_account_id":11105,"name":"Swapnil Kulkarni","email":"coolsvap@gmail.com","username":"coolsvap"},"change_message_id":"deacb8c94ea53ffd949f4820fb483b14867fa403","unresolved":false,"context_lines":[{"line_number":74,"context_line":""},{"line_number":75,"context_line":"        keypair \u003d self._create_keypair(**kwargs)"},{"line_number":76,"context_line":"        server \u003d self._boot_server(image, flavor,"},{"line_number":77,"context_line":"                                   key_name\u003dkeypair, **kwargs)"},{"line_number":78,"context_line":"        self._delete_server(server)"},{"line_number":79,"context_line":"        self._delete_keypair(keypair)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a016987_735a5585","line":77,"in_reply_to":"7a016987_539e3957","updated":"2015-05-15 10:05:40.000000000","message":"yes, self._boot_server() accepts as well **kwargs which are passed to nova python clients.","commit_id":"f1eb9de5eeb13f007c0e44bf8bbd884d5a9f0989"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"b63002ba63addc1a656a5022edf3b86b77d454bf","unresolved":false,"context_lines":[{"line_number":74,"context_line":""},{"line_number":75,"context_line":"        keypair \u003d self._create_keypair(**kwargs)"},{"line_number":76,"context_line":"        server \u003d self._boot_server(image, flavor,"},{"line_number":77,"context_line":"                                   key_name\u003dkeypair, **kwargs)"},{"line_number":78,"context_line":"        self._delete_server(server)"},{"line_number":79,"context_line":"        self._delete_keypair(keypair)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a016987_2e55924f","line":77,"in_reply_to":"7a016987_735a5585","updated":"2015-05-15 10:37:29.000000000","message":"ohhhh I didn\u0027t saw this\n\nyep we should have: \n\n  server_kwargs\u003dNone\n\nas separated parameter","commit_id":"f1eb9de5eeb13f007c0e44bf8bbd884d5a9f0989"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"22253e9b6b4ae5ebc3f38a777532f10ba71a5410","unresolved":false,"context_lines":[{"line_number":74,"context_line":"        :param kwargs: Optional additional arguments for keypair creation"},{"line_number":75,"context_line":"        \"\"\""},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"        if server_kwargs is None:"},{"line_number":78,"context_line":"            server_kwargs \u003d {}"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"        keypair \u003d self._create_keypair(**kwargs)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a016987_dd010f6c","line":77,"updated":"2015-05-15 14:09:15.000000000","message":"Actually I would like to see the unit tests that will check that server_kwargs are passed to the right place","commit_id":"efecccbea50970a6b48e9e1bc89f27d28e2b6bd1"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"ada6d648a7055ae0670a62a49195cc645158820f","unresolved":false,"context_lines":[{"line_number":75,"context_line":"        \"\"\""},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"        if server_kwargs is None:"},{"line_number":78,"context_line":"            server_kwargs \u003d {}"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"        keypair \u003d self._create_keypair(**kwargs)"},{"line_number":81,"context_line":"        server \u003d self._boot_server(image, flavor,"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa32b979_30ad38e9","line":78,"updated":"2015-06-24 15:36:10.000000000","message":"Could be write in standard way server_kwargs \u003d server_kwargs or {}. And its one line instead of two.","commit_id":"efecccbea50970a6b48e9e1bc89f27d28e2b6bd1"}]}
