)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"8517cb26f0b33310698a9a402a709496ae433fda","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Brian Downs \u003cbrian.downs@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-05-26 14:22:38 -0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Remove break from case statement to allow for parsing of CLI args."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Added 2 lines of tests to test_install.sh. One for sqlite db type and"},{"line_number":10,"context_line":"one for mysql db type with the necessary parameters."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"7a016987_184b4b5b","line":7,"updated":"2015-05-26 22:52:32.000000000","message":"This is not valid commit message. Remove dot at the end of this line","commit_id":"1f97ac144357b2ce771d6ed57d8d3500aa9c9c62"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"8517cb26f0b33310698a9a402a709496ae433fda","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Remove break from case statement to allow for parsing of CLI args."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Added 2 lines of tests to test_install.sh. One for sqlite db type and"},{"line_number":10,"context_line":"one for mysql db type with the necessary parameters."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Closes-bug: 1458408"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"7a016987_18622bd9","line":9,"updated":"2015-05-26 22:52:32.000000000","message":"You don\u0027t need to specify what amount of lines you added. \n\nJust say that you add test to check that --dbtype can be used.","commit_id":"1f97ac144357b2ce771d6ed57d8d3500aa9c9c62"}],"install_rally.sh":[{"author":{"_account_id":7369,"name":"Sergey Skripnick","email":"sskripnick@mirantis.com","username":"redixin"},"change_message_id":"9ec34525fd52abff3d043951153dd79ad4d88321","unresolved":false,"context_lines":[{"line_number":523,"context_line":"            shift"},{"line_number":524,"context_line":"            DBTYPE\u003d$1"},{"line_number":525,"context_line":"            case $DBTYPE in"},{"line_number":526,"context_line":"                sqlite|mysql|postgres) break ;;"},{"line_number":527,"context_line":"                *)"},{"line_number":528,"context_line":"                    err \"Invalid database type $DBTYPE.\""},{"line_number":529,"context_line":"                    print_usage"}],"source_content_type":"text/x-sh","patch_set":2,"id":"7a016987_41f1ff93","side":"PARENT","line":526,"updated":"2015-05-25 13:12:35.000000000","message":"This \"break\" does break only internal case/esac block, right?","commit_id":"a5fbbe88ddf195f3273cff4a8c85f8b83877a16d"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"5c4d4d9434a2434ecd66a13cd921f530360c4420","unresolved":false,"context_lines":[{"line_number":523,"context_line":"            shift"},{"line_number":524,"context_line":"            DBTYPE\u003d$1"},{"line_number":525,"context_line":"            case $DBTYPE in"},{"line_number":526,"context_line":"                sqlite|mysql|postgres);;"},{"line_number":527,"context_line":"                *)"},{"line_number":528,"context_line":"                    err \"Invalid database type $DBTYPE.\""},{"line_number":529,"context_line":"                    print_usage"}],"source_content_type":"text/x-sh","patch_set":2,"id":"7a016987_a1831302","line":526,"updated":"2015-05-25 13:09:08.000000000","message":"Could you please provide functional tests for this case. \n\nYou should add few bash lines at the end of the file:\n\n  https://github.com/openstack/rally/blob/master/tests/ci/test_install.sh\n\nThat will call this script with --dbtype sqlite so we won\u0027t have such regression in future","commit_id":"093650d71f61593623b45d891bc25bf30ea28420"}],"tests/ci/test_install.sh":[{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"98694492e03756c1ca0d085d7bfb578bedeb9363","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":"./install_rally.sh --overwrite --dbtype sqlite"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"./install_rally.sh --overwrite --dbtype mysql --db-host localhost --db-name rally --db-user rally --db-password rally"}],"source_content_type":"text/x-sh","patch_set":3,"id":"7a016987_8af8044b","line":36,"updated":"2015-05-26 20:23:50.000000000","message":"I said before that you should use here sqlite DB not mysql we don\u0027t have it on this gates","commit_id":"141be62192b4f9087d203ffa4c9d696f970d3d47"}]}
