)]}'
{"rally/plugins/openstack/scenarios/cinder/volumes.py":[{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"4828548def9b15e7c5e945100121ede4576b13e5","unresolved":false,"context_lines":[{"line_number":345,"context_line":"        # NOTE: Volume size cannot be smaller than the snapshot size, so"},{"line_number":346,"context_line":"        #       volume with specified size should be created to avoid"},{"line_number":347,"context_line":"        #       size mismatching between volume and snapshot."},{"line_number":348,"context_line":"        size \u003d random.randint(size[\"min\"], size[\"max\"])"},{"line_number":349,"context_line":""},{"line_number":350,"context_line":"        nested_level \u003d random.randint(nested_level[\"min\"], nested_level[\"max\"])"},{"line_number":351,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7a016987_4c0ff32e","line":348,"updated":"2015-05-25 15:05:30.000000000","message":"But we already have this property in utils. Could you explain more? https://github.com/openstack/rally/blob/master/rally/plugins/openstack/scenarios/cinder/utils.py#L85","commit_id":"c21baa421139f2a0d7824cc541d08c7325033f1d"},{"author":{"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},"change_message_id":"776bb37c7642fcb7d7edd4c6f88ec50163ec4a3c","unresolved":false,"context_lines":[{"line_number":345,"context_line":"        # NOTE: Volume size cannot be smaller than the snapshot size, so"},{"line_number":346,"context_line":"        #       volume with specified size should be created to avoid"},{"line_number":347,"context_line":"        #       size mismatching between volume and snapshot."},{"line_number":348,"context_line":"        size \u003d random.randint(size[\"min\"], size[\"max\"])"},{"line_number":349,"context_line":""},{"line_number":350,"context_line":"        nested_level \u003d random.randint(nested_level[\"min\"], nested_level[\"max\"])"},{"line_number":351,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7a016987_4cab73d7","line":348,"in_reply_to":"7a016987_4c0ff32e","updated":"2015-05-25 15:12:55.000000000","message":"We should create volume from snapshot or snapshot from volume with the same or bigger size, if this scenario use random from utils create method, it is possible to create volume or snapshot smaller than original one, and error will occur.","commit_id":"c21baa421139f2a0d7824cc541d08c7325033f1d"}],"tests/unit/plugins/openstack/scenarios/cinder/test_volumes.py":[{"author":{"_account_id":8507,"name":"Mikhail Dubov","email":"mdubov@mirantis.com","username":"msdubov"},"change_message_id":"0a852da84881bb796d247ea2d4345ca9eb486979","unresolved":false,"context_lines":[{"line_number":396,"context_line":"        random_call_count \u003d mock_random.randint.call_count"},{"line_number":397,"context_line":"        self.assertEqual(2, random_call_count)"},{"line_number":398,"context_line":""},{"line_number":399,"context_line":"        scenario._create_volume.assert_called_with(3, snapshot_id\u003dfake_snapshot.id)"},{"line_number":400,"context_line":""},{"line_number":401,"context_line":"    def test_create_volume_backup(self):"},{"line_number":402,"context_line":"        fake_volume \u003d mock.MagicMock()"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a016987_e1d8eb54","line":399,"updated":"2015-05-25 13:06:22.000000000","message":"So this line is \u003e79 characters, that\u0027s why pep8 is failing. I also think that you should assert here not just that _create_volume was called with \u00273\u0027 as a parameter, but that it was called *every time* with \u00273\u0027.\n\nI mean that assert_called_with() makes assertions only about the most recent call.","commit_id":"8a2d4486fa9146856442ebd53f716e9ed2c044d7"}]}
