)]}'
{"rally/verification/tempest/diff.py":[{"author":{"_account_id":126,"name":"Ilya Alekseyev","email":"ilyaalekseyev@acm.org","username":"ilyaalekseyev"},"change_message_id":"f3dd0f071b2e241abea5d4fdae8096a857353062","unresolved":false,"context_lines":[{"line_number":76,"context_line":"            val2 \u003d result2[field]"},{"line_number":77,"context_line":"            if val1 !\u003d val2:"},{"line_number":78,"context_line":"                if field \u003d\u003d \"time\":"},{"line_number":79,"context_line":"                    time_threshold \u003d abs(((val2 - val1) / (val1 or 1)) * 100)"},{"line_number":80,"context_line":"                    if time_threshold \u003c self.threshold:"},{"line_number":81,"context_line":"                        continue"},{"line_number":82,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7a016987_2dae63e6","line":79,"updated":"2015-05-29 00:58:29.000000000","message":"Shouldn\u0027t it be like this:\n time_threshold \u003d (max(val2,val1) - min(val2,val1) / (min(val2,val1) or 1)) * 100\n?","commit_id":"e32149c0f99e4838cf53cb307797d549a86a927a"},{"author":{"_account_id":126,"name":"Ilya Alekseyev","email":"ilyaalekseyev@acm.org","username":"ilyaalekseyev"},"change_message_id":"117f9306effa9ff923fbe1be3ab3deeff3839d40","unresolved":false,"context_lines":[{"line_number":76,"context_line":"            val2 \u003d result2[field]"},{"line_number":77,"context_line":"            if val1 !\u003d val2:"},{"line_number":78,"context_line":"                if field \u003d\u003d \"time\":"},{"line_number":79,"context_line":"                    time_threshold \u003d abs(((val2 - val1) / (val1 or 1)) * 100)"},{"line_number":80,"context_line":"                    if time_threshold \u003c self.threshold:"},{"line_number":81,"context_line":"                        continue"},{"line_number":82,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5afe65bd_572bd382","line":79,"in_reply_to":"5afe65bd_1caa20d5","updated":"2015-06-02 15:31:04.000000000","message":"Agree.","commit_id":"e32149c0f99e4838cf53cb307797d549a86a927a"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"1533e7b02b4fd9f13d791dcf6e9667078cc159e5","unresolved":false,"context_lines":[{"line_number":76,"context_line":"            val2 \u003d result2[field]"},{"line_number":77,"context_line":"            if val1 !\u003d val2:"},{"line_number":78,"context_line":"                if field \u003d\u003d \"time\":"},{"line_number":79,"context_line":"                    time_threshold \u003d abs(((val2 - val1) / (val1 or 1)) * 100)"},{"line_number":80,"context_line":"                    if time_threshold \u003c self.threshold:"},{"line_number":81,"context_line":"                        continue"},{"line_number":82,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7a016987_9af0e4fe","line":79,"in_reply_to":"7a016987_2dae63e6","updated":"2015-05-29 08:43:47.000000000","message":"Your code is more complicated, but `abs()\u0027 actually does the job","commit_id":"e32149c0f99e4838cf53cb307797d549a86a927a"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"575938658841dd061ab843057811fe40b9939657","unresolved":false,"context_lines":[{"line_number":76,"context_line":"            val2 \u003d result2[field]"},{"line_number":77,"context_line":"            if val1 !\u003d val2:"},{"line_number":78,"context_line":"                if field \u003d\u003d \"time\":"},{"line_number":79,"context_line":"                    time_threshold \u003d abs(((val2 - val1) / (val1 or 1)) * 100)"},{"line_number":80,"context_line":"                    if time_threshold \u003c self.threshold:"},{"line_number":81,"context_line":"                        continue"},{"line_number":82,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5afe65bd_3c839cce","line":79,"in_reply_to":"7a016987_2fb765d9","updated":"2015-06-02 15:24:20.000000000","message":"Thank you, I will apply this approach","commit_id":"e32149c0f99e4838cf53cb307797d549a86a927a"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"44a5cf5eb290275b427f197fe09d8a6b5018c6bc","unresolved":false,"context_lines":[{"line_number":76,"context_line":"            val2 \u003d result2[field]"},{"line_number":77,"context_line":"            if val1 !\u003d val2:"},{"line_number":78,"context_line":"                if field \u003d\u003d \"time\":"},{"line_number":79,"context_line":"                    time_threshold \u003d abs(((val2 - val1) / (val1 or 1)) * 100)"},{"line_number":80,"context_line":"                    if time_threshold \u003c self.threshold:"},{"line_number":81,"context_line":"                        continue"},{"line_number":82,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5afe65bd_1caa20d5","line":79,"in_reply_to":"7a016987_2fb765d9","updated":"2015-06-02 15:15:33.000000000","message":"You are right (however this change would be yet another fix, not related to zero division)","commit_id":"e32149c0f99e4838cf53cb307797d549a86a927a"},{"author":{"_account_id":126,"name":"Ilya Alekseyev","email":"ilyaalekseyev@acm.org","username":"ilyaalekseyev"},"change_message_id":"7ab7759590d91687d167233e45684d665a5e32ee","unresolved":false,"context_lines":[{"line_number":76,"context_line":"            val2 \u003d result2[field]"},{"line_number":77,"context_line":"            if val1 !\u003d val2:"},{"line_number":78,"context_line":"                if field \u003d\u003d \"time\":"},{"line_number":79,"context_line":"                    time_threshold \u003d abs(((val2 - val1) / (val1 or 1)) * 100)"},{"line_number":80,"context_line":"                    if time_threshold \u003c self.threshold:"},{"line_number":81,"context_line":"                        continue"},{"line_number":82,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7a016987_2fb765d9","line":79,"in_reply_to":"7a016987_9af0e4fe","updated":"2015-05-29 13:50:35.000000000","message":"i mean that we\u0027ll have different threshold for val1\u003d5, val2\u003d10 and val1\u003d10,val1\u003d5\n In first case it will be 100% and in second 50%","commit_id":"e32149c0f99e4838cf53cb307797d549a86a927a"}],"tests/unit/verification/test_diff.py":[{"author":{"_account_id":14257,"name":"Mahito Ogura","email":"m.ogura@ntt.com","username":"Mahito"},"change_message_id":"75951d4b3e726e7b39fe437ee90e127a6437b947","unresolved":false,"context_lines":[{"line_number":101,"context_line":"                                 \"time\": 0}}"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"        # This must NOT raise ZeroDivisionError"},{"line_number":104,"context_line":"        diff_ \u003d diff.Diff(results1, results2, 0)"},{"line_number":105,"context_line":"        self.assertEqual(2, len(diff_.diffs))"},{"line_number":106,"context_line":"        diff_ \u003d diff.Diff(results2, results1, 0)"},{"line_number":107,"context_line":"        self.assertEqual(2, len(diff_.diffs))"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a016987_f31a6c6e","line":104,"updated":"2015-05-29 02:23:02.000000000","message":"This case doesn\u0027t raise ZeroDivisionError when use old code.\nIt seems that needless test.","commit_id":"e32149c0f99e4838cf53cb307797d549a86a927a"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"1533e7b02b4fd9f13d791dcf6e9667078cc159e5","unresolved":false,"context_lines":[{"line_number":101,"context_line":"                                 \"time\": 0}}"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"        # This must NOT raise ZeroDivisionError"},{"line_number":104,"context_line":"        diff_ \u003d diff.Diff(results1, results2, 0)"},{"line_number":105,"context_line":"        self.assertEqual(2, len(diff_.diffs))"},{"line_number":106,"context_line":"        diff_ \u003d diff.Diff(results2, results1, 0)"},{"line_number":107,"context_line":"        self.assertEqual(2, len(diff_.diffs))"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a016987_7a7088a4","line":104,"in_reply_to":"7a016987_f31a6c6e","updated":"2015-05-29 08:43:47.000000000","message":"Yes, this line does not raise, but this assert must exist - what if someone change diff.Diff, so this assert becomes raising error?\n\nThe cause of ZeroDivisionError is actually missing assert at line 106, so this assert (L104) is added to prevent further and possible bug.","commit_id":"e32149c0f99e4838cf53cb307797d549a86a927a"}]}
