)]}'
{"rally/api.py":[{"author":{"_account_id":13609,"name":"Pavel Boldin","email":"pboldin@mirantis.com","username":"pboldin"},"change_message_id":"9dfdf9ccea0bfc0502ff2e8ccd427f2ca3e1a95c","unresolved":false,"context_lines":[{"line_number":130,"context_line":"            if not re.search(mis.join([\"{%\\s*set\\s+\", \"\\s*\u003d\\s*\", \"[^\\w]+\"]),"},{"line_number":131,"context_line":"                             task_template):"},{"line_number":132,"context_line":"                maybe_missing.append(mis)"},{"line_number":133,"context_line":"        # NOTE(jlk): Also check for a default filter which can show up as"},{"line_number":134,"context_line":"        #            a missing variable"},{"line_number":135,"context_line":"        real_missing \u003d []"},{"line_number":136,"context_line":"        for mis in maybe_missing:"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a016987_44285ce2","line":133,"updated":"2015-05-28 23:32:08.000000000","message":"Please just add this check to the loop above.\n\nProbably, rewrite the check as a function:\n def is_really_missing(mis):\n   ...\n\nAnd make a comprehension:\n\n real_missing \u003d filter(is_really_missing, missing)","commit_id":"714a82efcae75dffa6b78a908555944f599b43e7"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"03651bf9b5d082eca4133bf593337d098ea390c4","unresolved":false,"context_lines":[{"line_number":130,"context_line":"            if not re.search(mis.join([\"{%\\s*set\\s+\", \"\\s*\u003d\\s*\", \"[^\\w]+\"]),"},{"line_number":131,"context_line":"                             task_template):"},{"line_number":132,"context_line":"                maybe_missing.append(mis)"},{"line_number":133,"context_line":"        # NOTE(jlk): Also check for a default filter which can show up as"},{"line_number":134,"context_line":"        #            a missing variable"},{"line_number":135,"context_line":"        real_missing \u003d []"},{"line_number":136,"context_line":"        for mis in maybe_missing:"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a016987_646fd8fc","line":133,"in_reply_to":"7a016987_44285ce2","updated":"2015-05-28 23:36:50.000000000","message":"We should avoid using map/filters/... and others because they returns different types in py2 and py3.","commit_id":"714a82efcae75dffa6b78a908555944f599b43e7"},{"author":{"_account_id":13609,"name":"Pavel Boldin","email":"pboldin@mirantis.com","username":"pboldin"},"change_message_id":"cc8647a1b5d0c6e107c9d26f8203674880830a0d","unresolved":false,"context_lines":[{"line_number":130,"context_line":"            if not re.search(mis.join([\"{%\\s*set\\s+\", \"\\s*\u003d\\s*\", \"[^\\w]+\"]),"},{"line_number":131,"context_line":"                             task_template):"},{"line_number":132,"context_line":"                maybe_missing.append(mis)"},{"line_number":133,"context_line":"        # NOTE(jlk): Also check for a default filter which can show up as"},{"line_number":134,"context_line":"        #            a missing variable"},{"line_number":135,"context_line":"        real_missing \u003d []"},{"line_number":136,"context_line":"        for mis in maybe_missing:"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a016987_643d98dc","line":133,"in_reply_to":"7a016987_646fd8fc","updated":"2015-05-28 23:38:41.000000000","message":"OK, then a comprehension indeed:\n real_missing \u003d [mis for mis in missing if is_really_missing(mis)]","commit_id":"714a82efcae75dffa6b78a908555944f599b43e7"}]}
