)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"14cf72c1cc1dd5c3e649c115b597f9112421d63c","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     ningyan \u003cyan.ning@twcable.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-06-01 20:17:01 -0600"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"fix typo in monasca samples"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: Ib97831f025bdf87ee7504211f26d067b982c507a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"5afe65bd_1211f1ac","line":7,"updated":"2015-06-02 13:53:02.000000000","message":"This patch doesn\u0027t fix samples, it adds benchmarks for monasco project","commit_id":"73d68991dfdc244155adec00f54f402fbaf4e0bc"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"15db535ff9848f78a3f0bfccfa8d8ed6b2c6ed4d","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     ningyan \u003cyan.ning@twcable.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-08-31 14:21:31 -0600"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Update monascaclient to the latest version"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":" * enable monascaclient call in Rally infra only in this patch"},{"line_number":10,"context_line":" * will work on adding monasca tests in Rally with seperate patches."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":21,"id":"7a2fa921_dfe35e04","line":7,"updated":"2015-10-12 15:52:50.000000000","message":"This is actually `Add\u0027, not `Update\u0027 :)","commit_id":"4e81e1d7767a510082f8dde11e31e3d86888065f"}],"optional-requirements.txt":[{"author":{"_account_id":8126,"name":"Bradley Klein","email":"bradley.klein@charter.com","username":"bklei"},"change_message_id":"7941d06a2564c5aa127d325bc0a4340717469201","unresolved":false,"context_lines":[{"line_number":1,"context_line":"git+git://github.com/stackforge/python-mistralclient.git"},{"line_number":2,"context_line":"python-fuelclient\u003d\u003d6.1.0"},{"line_number":3,"context_line":"python-muranoclient\u003e\u003d0.5.5"},{"line_number":4,"context_line":"python-monascaclient\u003e\u003d1.0.18"}],"source_content_type":"text/plain","patch_set":19,"id":"da20952f_631a4e7f","line":4,"updated":"2015-08-28 19:21:23.000000000","message":"Should be the latest for now -- 1.0.22..","commit_id":"9b57b05d19ab17514a1c280661daad2ab1905b01"}],"rally/osclients.py":[{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"2b9008a4714d06353bdabb18aa50299d654dd5f2","unresolved":false,"context_lines":[{"line_number":262,"context_line":"        return client"},{"line_number":263,"context_line":""},{"line_number":264,"context_line":"    @cached"},{"line_number":265,"context_line":"    def monasca(self, version\u003d\"2_0\"):"},{"line_number":266,"context_line":"        \"\"\"Return monasca client.\"\"\""},{"line_number":267,"context_line":"        from monascaclient import client as monasca"},{"line_number":268,"context_line":"        kc \u003d self.keystone()"}],"source_content_type":"text/x-python","patch_set":6,"id":"5afe65bd_d7ac63ef","line":265,"updated":"2015-06-02 15:36:08.000000000","message":"is it normal version \"2_0\"?","commit_id":"73d68991dfdc244155adec00f54f402fbaf4e0bc"}],"rally/plugins/openstack/scenarios/authenticate/authenticate.py":[{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"d09a34be9af10f466183e1de31420ac704656900","unresolved":false,"context_lines":[{"line_number":114,"context_line":""},{"line_number":115,"context_line":"    @validation.number(\"repetitions\", minval\u003d1)"},{"line_number":116,"context_line":"    @validation.required_openstack(users\u003dTrue)"},{"line_number":117,"context_line":"    @scenario.configure()"},{"line_number":118,"context_line":"    def validate_monasca(self, repetitions):"},{"line_number":119,"context_line":"        \"\"\"Check Monasca Client to ensure validation of token."},{"line_number":120,"context_line":""}],"source_content_type":"text/x-python","patch_set":23,"id":"5a2ca52d_7ed0811f","line":117,"updated":"2015-10-16 09:41:00.000000000","message":"we need here required_service() validator as well (like for mistral)","commit_id":"925f83eb16642a94f86e91114b2e1e493922da76"},{"author":{"_account_id":7369,"name":"Sergey Skripnick","email":"sskripnick@mirantis.com","username":"redixin"},"change_message_id":"517ea13c5000edb5780fdfdc6317b01f52ede859","unresolved":false,"context_lines":[{"line_number":114,"context_line":""},{"line_number":115,"context_line":"    @validation.number(\"repetitions\", minval\u003d1)"},{"line_number":116,"context_line":"    @validation.required_openstack(users\u003dTrue)"},{"line_number":117,"context_line":"    @scenario.configure()"},{"line_number":118,"context_line":"    def validate_monasca(self, repetitions):"},{"line_number":119,"context_line":"        \"\"\"Check Monasca Client to ensure validation of token."},{"line_number":120,"context_line":""}],"source_content_type":"text/x-python","patch_set":23,"id":"3a29b11f_7217d451","line":117,"in_reply_to":"5a2ca52d_7ed0811f","updated":"2015-10-19 12:09:10.000000000","message":"oh i missed this.","commit_id":"925f83eb16642a94f86e91114b2e1e493922da76"}],"rally/plugins/openstack/scenarios/monasca/metrics.py":[{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"14cf72c1cc1dd5c3e649c115b597f9112421d63c","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"class MonascaMetrics(monascautils.MonascaScenario):"},{"line_number":22,"context_line":"    \"\"\"Benchmark scenarios for monasca Metrics API.\"\"\""},{"line_number":23,"context_line":"    @validation.required_services(consts.Service.MONASCA)"},{"line_number":24,"context_line":"    @validation.required_openstack(admin\u003dTrue)"},{"line_number":25,"context_line":"    @base.scenario()"},{"line_number":26,"context_line":"    def list_metrics(self):"}],"source_content_type":"text/x-python","patch_set":6,"id":"5afe65bd_951a6b6d","line":23,"updated":"2015-06-02 13:53:02.000000000","message":"you should add required_clients validator[*], since monascaclient is not in main requirements of rally(see my comment at requirements.txt)\n\n[*] - https://github.com/openstack/rally/blob/master/rally/benchmark/validation.py#L433","commit_id":"73d68991dfdc244155adec00f54f402fbaf4e0bc"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"2b9008a4714d06353bdabb18aa50299d654dd5f2","unresolved":false,"context_lines":[{"line_number":30,"context_line":"                break"},{"line_number":31,"context_line":"        tenant_id \u003d self.context[\"tenant\"][\"id\"]"},{"line_number":32,"context_line":"        user_id \u003d self.context[\"user\"][\"id\"]"},{"line_number":33,"context_line":"        self.admin_clients(\"keystone\").roles.grant(role\u003droleID,"},{"line_number":34,"context_line":"                                                   user\u003duser_id,"},{"line_number":35,"context_line":"                                                   project\u003dtenant_id)"},{"line_number":36,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"5afe65bd_fc0ce443","line":33,"updated":"2015-06-02 15:36:08.000000000","message":"If we don\u0027t have \"monasca_project_admin\" in role list then we will get error. Is it possible?","commit_id":"73d68991dfdc244155adec00f54f402fbaf4e0bc"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"2b9008a4714d06353bdabb18aa50299d654dd5f2","unresolved":false,"context_lines":[{"line_number":34,"context_line":"                                                   user\u003duser_id,"},{"line_number":35,"context_line":"                                                   project\u003dtenant_id)"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"        \"\"\"Fetch user\u0027s metrics.\"\"\""},{"line_number":38,"context_line":"        self._list_metrics()"}],"source_content_type":"text/x-python","patch_set":6,"id":"5afe65bd_b74b2759","line":37,"updated":"2015-06-02 15:36:08.000000000","message":"Docstring must to be right under function name","commit_id":"73d68991dfdc244155adec00f54f402fbaf4e0bc"},{"author":{"_account_id":15029,"name":"John Wu","email":"weiwu@cisco.com","username":"johnwwu"},"change_message_id":"661afff8750df63352bd3411a21a3810349d9a18","unresolved":false,"context_lines":[{"line_number":32,"context_line":"                break"},{"line_number":33,"context_line":"        tenant_id \u003d self.context[\"tenant\"][\"id\"]"},{"line_number":34,"context_line":"        user_id \u003d self.context[\"user\"][\"id\"]"},{"line_number":35,"context_line":"        self.admin_clients(\"keystone\").roles.grant(role\u003droleID,"},{"line_number":36,"context_line":"                                                   user\u003duser_id,"},{"line_number":37,"context_line":"                                                   project\u003dtenant_id)"},{"line_number":38,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"5afe65bd_f169a68c","line":35,"updated":"2015-06-02 17:49:39.000000000","message":"You can grant the role during roles context instead of scenario, please see:\n\nhttps://github.com/openstack/rally/blob/master/rally/plugins/openstack/context/roles.py#L29","commit_id":"82a0ee54187f352d922ce999df921b709787a522"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"44476829f2f610cfd075f2ebb84e946d6e4f249c","unresolved":false,"context_lines":[{"line_number":22,"context_line":"    \"\"\"Benchmark scenarios for monasca Metrics API.\"\"\""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    @validation.required_services(consts.Service.MONASCA)"},{"line_number":25,"context_line":"    @validation.required_clients(\"monasca\")"},{"line_number":26,"context_line":"    @validation.required_openstack(admin\u003dTrue)"},{"line_number":27,"context_line":"    @base.scenario()"},{"line_number":28,"context_line":"    def list_metrics(self):"}],"source_content_type":"text/x-python","patch_set":9,"id":"5afe65bd_4d8fb1cc","line":25,"updated":"2015-06-02 21:58:57.000000000","message":"Here is keystone required client. And add docstring to function","commit_id":"736a175de3826244ff6f130fa76ca9ac26adb6c0"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"5e77d4e9d3e71d9a5607433c72b4b3e4dc2c577d","unresolved":false,"context_lines":[{"line_number":22,"context_line":"    \"\"\"Benchmark scenarios for monasca Metrics API.\"\"\""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    @validation.required_services(consts.Service.MONASCA)"},{"line_number":25,"context_line":"    @validation.required_clients(\"monasca\")"},{"line_number":26,"context_line":"    @validation.required_openstack(admin\u003dTrue)"},{"line_number":27,"context_line":"    @base.scenario()"},{"line_number":28,"context_line":"    def list_metrics(self):"}],"source_content_type":"text/x-python","patch_set":9,"id":"5afe65bd_10d43245","line":25,"in_reply_to":"5afe65bd_4d8fb1cc","updated":"2015-06-02 22:14:50.000000000","message":"method `required_clients` should be used only for clients from optional-requrements","commit_id":"736a175de3826244ff6f130fa76ca9ac26adb6c0"}],"requirements.txt":[{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"14cf72c1cc1dd5c3e649c115b597f9112421d63c","unresolved":false,"context_lines":[{"line_number":33,"context_line":"python-troveclient\u003e\u003d1.0.7"},{"line_number":34,"context_line":"python-zaqarclient\u003e\u003d0.0.3"},{"line_number":35,"context_line":"python-swiftclient\u003e\u003d2.2.0"},{"line_number":36,"context_line":"python-monascaclient\u003e\u003d1.0.18"},{"line_number":37,"context_line":"python-subunit\u003e\u003d0.0.18"},{"line_number":38,"context_line":"requests\u003e\u003d2.5.2"},{"line_number":39,"context_line":"SQLAlchemy\u003e\u003d0.9.7,\u003c\u003d0.9.99"}],"source_content_type":"text/plain","patch_set":6,"id":"5afe65bd_7263851b","line":36,"updated":"2015-06-02 13:53:02.000000000","message":"Since monascaclient is not in global-requirements[1] yet, we can\u0027t add it as requirements to Rally, but optional-requirements is the right place[2].\n\n[1] - https://github.com/openstack/requirements/blob/master/global-requirements.txt\n[2] - https://github.com/openstack/rally/blob/master/optional-requirements.txt","commit_id":"73d68991dfdc244155adec00f54f402fbaf4e0bc"}]}
