)]}'
{"rally/plugins/openstack/context/cleanup/manager.py":[{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"37b4af91e3d3fb91da73eb8cf8c64d0ac0c6839e","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from rally.common import broker"},{"line_number":19,"context_line":"from rally.common.i18n import _"},{"line_number":20,"context_line":"from rally import exceptions"},{"line_number":21,"context_line":"from rally.common import log as logging"},{"line_number":22,"context_line":"from rally.common import utils as rutils"},{"line_number":23,"context_line":"from rally import osclients"}],"source_content_type":"text/x-python","patch_set":1,"id":"5afe65bd_8937fdaf","line":20,"updated":"2015-06-02 09:51:43.000000000","message":"This module is not used","commit_id":"c896ee8a307645df35956809b03960051c2a78d9"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"52cebd72575d5d31c82ecfc7808eb2e4c6d60d51","unresolved":false,"context_lines":[{"line_number":175,"context_line":"                admin\u003dself._get_cached_client(admin, cache\u003dcache),"},{"line_number":176,"context_line":"                user\u003dself._get_cached_client(user, cache\u003dcache),"},{"line_number":177,"context_line":"                tenant_uuid\u003duser and user[\"tenant_id\"])"},{"line_number":178,"context_line":""},{"line_number":179,"context_line":"            if not manager.is_deleted():"},{"line_number":180,"context_line":"                self._delete_single_resource(manager)"},{"line_number":181,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5afe65bd_6fc0182b","line":178,"updated":"2015-06-03 06:09:13.000000000","message":"shouldn\u0027t this in a try/except block as Line 94 do?","commit_id":"03a3289e3e2da5b09254eba73268284ccfbc2552"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"58cd2423fe124d5b54cd098aa38fdb77813ef614","unresolved":false,"context_lines":[{"line_number":175,"context_line":"                admin\u003dself._get_cached_client(admin, cache\u003dcache),"},{"line_number":176,"context_line":"                user\u003dself._get_cached_client(user, cache\u003dcache),"},{"line_number":177,"context_line":"                tenant_uuid\u003duser and user[\"tenant_id\"])"},{"line_number":178,"context_line":""},{"line_number":179,"context_line":"            if not manager.is_deleted():"},{"line_number":180,"context_line":"                self._delete_single_resource(manager)"},{"line_number":181,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3afb71cf_975d7617","line":178,"in_reply_to":"5afe65bd_3ae1329b","updated":"2015-06-09 07:25:36.000000000","message":"So if is it safe to remove the try/except block in line94?","commit_id":"03a3289e3e2da5b09254eba73268284ccfbc2552"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"5519978ffa07ca9d917aedcab4fa30cda20072d6","unresolved":false,"context_lines":[{"line_number":175,"context_line":"                admin\u003dself._get_cached_client(admin, cache\u003dcache),"},{"line_number":176,"context_line":"                user\u003dself._get_cached_client(user, cache\u003dcache),"},{"line_number":177,"context_line":"                tenant_uuid\u003duser and user[\"tenant_id\"])"},{"line_number":178,"context_line":""},{"line_number":179,"context_line":"            if not manager.is_deleted():"},{"line_number":180,"context_line":"                self._delete_single_resource(manager)"},{"line_number":181,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5afe65bd_f02bc0e9","line":178,"in_reply_to":"5afe65bd_6fc0182b","updated":"2015-06-03 11:24:55.000000000","message":"Agree. I think it should","commit_id":"03a3289e3e2da5b09254eba73268284ccfbc2552"},{"author":{"_account_id":8576,"name":"Yair Fried","email":"yfried@redhat.com","username":"yfried"},"change_message_id":"96c00419faf9fa58b97e444efa933af5f36d8e42","unresolved":false,"context_lines":[{"line_number":175,"context_line":"                admin\u003dself._get_cached_client(admin, cache\u003dcache),"},{"line_number":176,"context_line":"                user\u003dself._get_cached_client(user, cache\u003dcache),"},{"line_number":177,"context_line":"                tenant_uuid\u003duser and user[\"tenant_id\"])"},{"line_number":178,"context_line":""},{"line_number":179,"context_line":"            if not manager.is_deleted():"},{"line_number":180,"context_line":"                self._delete_single_resource(manager)"},{"line_number":181,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5afe65bd_3ae1329b","line":178,"in_reply_to":"5afe65bd_f02bc0e9","updated":"2015-06-03 12:34:01.000000000","message":"L94 is the problematic line. it writes unnecessary warnings. the purpose of this patch is to avoid L94 if the resource has already been deleted","commit_id":"03a3289e3e2da5b09254eba73268284ccfbc2552"}]}