)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"cb377622ea75b502551a2aa979b9c630c5095037","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     kiran-r \u003ckiran.ranganath@maplelabs.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-06-04 16:20:18 +0530"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Check parameter inside a dictionary argument is set"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Currently checking paramter in args i.e."},{"line_number":10,"context_line":"{\"args\": \"parameter\"} is supported but checking"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3afb71cf_922372a7","line":7,"updated":"2015-06-08 11:06:34.000000000","message":"Add validator....","commit_id":"f963423f8de7f98a5c63a882441bf4ee016e9a63"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"cb377622ea75b502551a2aa979b9c630c5095037","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Check parameter inside a dictionary argument is set"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Currently checking paramter in args i.e."},{"line_number":10,"context_line":"{\"args\": \"parameter\"} is supported but checking"},{"line_number":11,"context_line":"a parameter inside a dictionary in args"},{"line_number":12,"context_line":"is unsupported i.e. {\"args\": {\"dict\": \"parameter\"}."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3afb71cf_92f6d2f7","line":9,"updated":"2015-06-08 11:06:34.000000000","message":"typo parameter","commit_id":"f963423f8de7f98a5c63a882441bf4ee016e9a63"},{"author":{"_account_id":8507,"name":"Mikhail Dubov","email":"mdubov@mirantis.com","username":"msdubov"},"change_message_id":"86f5c1a36dd4ce078514d25a2572130f2ed39591","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Currently checking paramter in args i.e."},{"line_number":10,"context_line":"{\"args\": \"parameter\"} is supported but checking"},{"line_number":11,"context_line":"a parameter inside a dictionary in args"},{"line_number":12,"context_line":"is unsupported i.e. {\"args\": {\"dict\": \"parameter\"}."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: Ic2dc13b84be107cd8c6add28a22835c448f1b71f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3afb71cf_b26d4e06","line":12,"updated":"2015-06-08 11:08:43.000000000","message":"Please explain in the commit message where this is going to be useful.","commit_id":"f963423f8de7f98a5c63a882441bf4ee016e9a63"}],"rally/benchmark/validation.py":[{"author":{"_account_id":8507,"name":"Mikhail Dubov","email":"mdubov@mirantis.com","username":"msdubov"},"change_message_id":"86f5c1a36dd4ce078514d25a2572130f2ed39591","unresolved":false,"context_lines":[{"line_number":514,"context_line":""},{"line_number":515,"context_line":"@validator"},{"line_number":516,"context_line":"def restricted_parameters(config, clients, deployment, param_name,"},{"line_number":517,"context_line":"                          dict_name\u003dNone):"},{"line_number":518,"context_line":"    \"\"\"Validator that check that parameter is not set.\"\"\""},{"line_number":519,"context_line":"    args \u003d config.get(\"args\", {})"},{"line_number":520,"context_line":"    if dict_name:"}],"source_content_type":"text/x-python","patch_set":1,"id":"3afb71cf_d2344afc","line":517,"updated":"2015-06-08 11:08:43.000000000","message":"I believe \u0027dict_name\u0027 is not clear enough, I\u0027d suggest renaming this parameter to something like \u0027check_in_dict\u0027","commit_id":"f963423f8de7f98a5c63a882441bf4ee016e9a63"},{"author":{"_account_id":11748,"name":"Chris St. Pierre","email":"cstpierr@cisco.com","username":"stpierre"},"change_message_id":"78a984f0fdd212833e1828f870e13ce2a8d67fa3","unresolved":false,"context_lines":[{"line_number":515,"context_line":"@validator"},{"line_number":516,"context_line":"def restricted_parameters(config, clients, deployment, param_name,"},{"line_number":517,"context_line":"                          dict_name\u003dNone):"},{"line_number":518,"context_line":"    \"\"\"Validator that check that parameter is not set.\"\"\""},{"line_number":519,"context_line":"    args \u003d config.get(\"args\", {})"},{"line_number":520,"context_line":"    if dict_name:"},{"line_number":521,"context_line":"        args \u003d args.get(dict_name, {})"}],"source_content_type":"text/x-python","patch_set":1,"id":"5afe65bd_4c7f6115","line":518,"updated":"2015-06-04 15:16:09.000000000","message":"Please add documentation for the various parameters to the docstring.","commit_id":"f963423f8de7f98a5c63a882441bf4ee016e9a63"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"cb377622ea75b502551a2aa979b9c630c5095037","unresolved":false,"context_lines":[{"line_number":517,"context_line":"                          dict_name\u003dNone):"},{"line_number":518,"context_line":"    \"\"\"Validator that check that parameter is not set.\"\"\""},{"line_number":519,"context_line":"    args \u003d config.get(\"args\", {})"},{"line_number":520,"context_line":"    if dict_name:"},{"line_number":521,"context_line":"        args \u003d args.get(dict_name, {})"},{"line_number":522,"context_line":"    if param_name in args:"},{"line_number":523,"context_line":"        return ValidationResult("}],"source_content_type":"text/x-python","patch_set":1,"id":"3afb71cf_876e962d","line":520,"updated":"2015-06-08 11:06:34.000000000","message":"If dict_name is specified but its not in args then we retrun nothing","commit_id":"f963423f8de7f98a5c63a882441bf4ee016e9a63"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"cb377622ea75b502551a2aa979b9c630c5095037","unresolved":false,"context_lines":[{"line_number":521,"context_line":"        args \u003d args.get(dict_name, {})"},{"line_number":522,"context_line":"    if param_name in args:"},{"line_number":523,"context_line":"        return ValidationResult("},{"line_number":524,"context_line":"            False, \"You can\u0027t specify parameter \u0027%(param)s\u0027 in \u0027%(dict)s\u0027\""},{"line_number":525,"context_line":"            % {\"param\": param_name, \"dict\": \"args\" if dict_name is None else"},{"line_number":526,"context_line":"               dict_name})"}],"source_content_type":"text/x-python","patch_set":1,"id":"3afb71cf_873b36d1","line":524,"updated":"2015-06-08 11:06:34.000000000","message":"add internationalization","commit_id":"f963423f8de7f98a5c63a882441bf4ee016e9a63"},{"author":{"_account_id":8507,"name":"Mikhail Dubov","email":"mdubov@mirantis.com","username":"msdubov"},"change_message_id":"86f5c1a36dd4ce078514d25a2572130f2ed39591","unresolved":false,"context_lines":[{"line_number":521,"context_line":"        args \u003d args.get(dict_name, {})"},{"line_number":522,"context_line":"    if param_name in args:"},{"line_number":523,"context_line":"        return ValidationResult("},{"line_number":524,"context_line":"            False, \"You can\u0027t specify parameter \u0027%(param)s\u0027 in \u0027%(dict)s\u0027\""},{"line_number":525,"context_line":"            % {\"param\": param_name, \"dict\": \"args\" if dict_name is None else"},{"line_number":526,"context_line":"               dict_name})"}],"source_content_type":"text/x-python","patch_set":1,"id":"3afb71cf_4d643fe4","line":524,"in_reply_to":"3afb71cf_873b36d1","updated":"2015-06-08 11:08:43.000000000","message":"Just to be clear, Roman means putting here\n\n_(\"You can\u0027t specify ...\") % {...}","commit_id":"f963423f8de7f98a5c63a882441bf4ee016e9a63"},{"author":{"_account_id":11748,"name":"Chris St. Pierre","email":"cstpierr@cisco.com","username":"stpierre"},"change_message_id":"78a984f0fdd212833e1828f870e13ce2a8d67fa3","unresolved":false,"context_lines":[{"line_number":523,"context_line":"        return ValidationResult("},{"line_number":524,"context_line":"            False, \"You can\u0027t specify parameter \u0027%(param)s\u0027 in \u0027%(dict)s\u0027\""},{"line_number":525,"context_line":"            % {\"param\": param_name, \"dict\": \"args\" if dict_name is None else"},{"line_number":526,"context_line":"               dict_name})"}],"source_content_type":"text/x-python","patch_set":1,"id":"5afe65bd_6c9c5d5d","line":526,"updated":"2015-06-04 15:16:09.000000000","message":"Better:\n\n    {\"param\": param_name, \"dict\": dict_name if dict_name else \"args\"}","commit_id":"f963423f8de7f98a5c63a882441bf4ee016e9a63"},{"author":{"_account_id":8576,"name":"Yair Fried","email":"yfried@redhat.com","username":"yfried"},"change_message_id":"276b8aedbf5a2f40995bd0839704952f06771f2d","unresolved":false,"context_lines":[{"line_number":514,"context_line":""},{"line_number":515,"context_line":"@validator"},{"line_number":516,"context_line":"def restricted_parameters(config, clients, deployment, param_name,"},{"line_number":517,"context_line":"                          check_in_dict\u003dNone):"},{"line_number":518,"context_line":"    \"\"\"Validator that check if parameter is not set."},{"line_number":519,"context_line":""},{"line_number":520,"context_line":"    :param param_name: str, name of the parameter"}],"source_content_type":"text/x-python","patch_set":5,"id":"3afb71cf_4916374d","line":517,"updated":"2015-06-09 13:11:30.000000000","message":"s/check_in_dict/subdict","commit_id":"6652dc6aa259c56f8e91359dae60a4c4ad36f57c"},{"author":{"_account_id":8576,"name":"Yair Fried","email":"yfried@redhat.com","username":"yfried"},"change_message_id":"276b8aedbf5a2f40995bd0839704952f06771f2d","unresolved":false,"context_lines":[{"line_number":515,"context_line":"@validator"},{"line_number":516,"context_line":"def restricted_parameters(config, clients, deployment, param_name,"},{"line_number":517,"context_line":"                          check_in_dict\u003dNone):"},{"line_number":518,"context_line":"    \"\"\"Validator that check if parameter is not set."},{"line_number":519,"context_line":""},{"line_number":520,"context_line":"    :param param_name: str, name of the parameter"},{"line_number":521,"context_line":"    :param check_in_dict: str, name of the dictionary to check for param_name"}],"source_content_type":"text/x-python","patch_set":5,"id":"3afb71cf_e6c3d055","line":518,"updated":"2015-06-09 13:11:30.000000000","message":"\"checks that\"\nActually:  \n\n  \"Validates that parameter...\"\n\nis even better. I know that other docstring are different, but IMO, this is better English.","commit_id":"6652dc6aa259c56f8e91359dae60a4c4ad36f57c"},{"author":{"_account_id":8576,"name":"Yair Fried","email":"yfried@redhat.com","username":"yfried"},"change_message_id":"276b8aedbf5a2f40995bd0839704952f06771f2d","unresolved":false,"context_lines":[{"line_number":516,"context_line":"def restricted_parameters(config, clients, deployment, param_name,"},{"line_number":517,"context_line":"                          check_in_dict\u003dNone):"},{"line_number":518,"context_line":"    \"\"\"Validator that check if parameter is not set."},{"line_number":519,"context_line":""},{"line_number":520,"context_line":"    :param param_name: str, name of the parameter"},{"line_number":521,"context_line":"    :param check_in_dict: str, name of the dictionary to check for param_name"},{"line_number":522,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":5,"id":"3afb71cf_695a132c","line":519,"updated":"2015-06-09 13:11:30.000000000","message":"if you are listing parameters, please list all of them (config, clients, deployment)","commit_id":"6652dc6aa259c56f8e91359dae60a4c4ad36f57c"},{"author":{"_account_id":8576,"name":"Yair Fried","email":"yfried@redhat.com","username":"yfried"},"change_message_id":"276b8aedbf5a2f40995bd0839704952f06771f2d","unresolved":false,"context_lines":[{"line_number":518,"context_line":"    \"\"\"Validator that check if parameter is not set."},{"line_number":519,"context_line":""},{"line_number":520,"context_line":"    :param param_name: str, name of the parameter"},{"line_number":521,"context_line":"    :param check_in_dict: str, name of the dictionary to check for param_name"},{"line_number":522,"context_line":"    \"\"\""},{"line_number":523,"context_line":"    args \u003d config.get(\"args\", {})"},{"line_number":524,"context_line":"    if check_in_dict:"}],"source_content_type":"text/x-python","patch_set":5,"id":"3afb71cf_c61a147d","line":521,"updated":"2015-06-09 13:11:30.000000000","message":"check_in_dict: sub-dict of \"config\" to search for param_name. if not defined - will search in \"config\"","commit_id":"6652dc6aa259c56f8e91359dae60a4c4ad36f57c"},{"author":{"_account_id":8576,"name":"Yair Fried","email":"yfried@redhat.com","username":"yfried"},"change_message_id":"276b8aedbf5a2f40995bd0839704952f06771f2d","unresolved":false,"context_lines":[{"line_number":522,"context_line":"    \"\"\""},{"line_number":523,"context_line":"    args \u003d config.get(\"args\", {})"},{"line_number":524,"context_line":"    if check_in_dict:"},{"line_number":525,"context_line":"        args \u003d args.get(check_in_dict, {})"},{"line_number":526,"context_line":"    if param_name in args:"},{"line_number":527,"context_line":"        return ValidationResult("},{"line_number":528,"context_line":"            False, _(\"You can\u0027t specify parameter \u0027%(param)s\u0027 in \u0027%(dict)s\u0027\")"}],"source_content_type":"text/x-python","patch_set":5,"id":"3afb71cf_4670640b","line":525,"updated":"2015-06-09 13:11:30.000000000","message":"How about:\n\n  a_dict, a_key \u003d (args, check_in_dict) if check_in_dict else (config, \"args\")\n  if param_name in a_dict.get(a_key, {}):","commit_id":"6652dc6aa259c56f8e91359dae60a4c4ad36f57c"},{"author":{"_account_id":8576,"name":"Yair Fried","email":"yfried@redhat.com","username":"yfried"},"change_message_id":"276b8aedbf5a2f40995bd0839704952f06771f2d","unresolved":false,"context_lines":[{"line_number":526,"context_line":"    if param_name in args:"},{"line_number":527,"context_line":"        return ValidationResult("},{"line_number":528,"context_line":"            False, _(\"You can\u0027t specify parameter \u0027%(param)s\u0027 in \u0027%(dict)s\u0027\")"},{"line_number":529,"context_line":"            % {\"param\": param_name, \"dict\": check_in_dict if check_in_dict else"},{"line_number":530,"context_line":"                \"args\"})"}],"source_content_type":"text/x-python","patch_set":5,"id":"3afb71cf_46b3c498","line":529,"updated":"2015-06-09 13:11:30.000000000","message":"\"dict\": a_dict","commit_id":"6652dc6aa259c56f8e91359dae60a4c4ad36f57c"}],"tests/unit/benchmark/test_validation.py":[{"author":{"_account_id":11748,"name":"Chris St. Pierre","email":"cstpierr@cisco.com","username":"stpierre"},"change_message_id":"78a984f0fdd212833e1828f870e13ce2a8d67fa3","unresolved":false,"context_lines":[{"line_number":677,"context_line":"        validator \u003d self._unwrap_validator("},{"line_number":678,"context_line":"            validation.restricted_parameters, \"param_name\", \"dict_name\")"},{"line_number":679,"context_line":"        result \u003d validator({\"args\": {\"dict_name\": {}}}, None, None)"},{"line_number":680,"context_line":"        self.assertTrue(result.is_valid, result.msg)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5afe65bd_ecbf2da8","line":680,"updated":"2015-06-04 15:16:09.000000000","message":"Please add a negative test case for this, too. (For extra points, add a negative test case for the base restricted_parameters() validator as well.)","commit_id":"f963423f8de7f98a5c63a882441bf4ee016e9a63"}]}
