)]}'
{"rally-jobs/rally-manila-no-ss.yaml":[{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"1da8394195d13d75fa375f93c6b71641b167da83","unresolved":false,"context_lines":[{"line_number":42,"context_line":"        max_sleep: 2"},{"line_number":43,"context_line":"      runner:"},{"line_number":44,"context_line":"        type: \"constant\""},{"line_number":45,"context_line":"        times: 2"},{"line_number":46,"context_line":"        concurrency: 2"},{"line_number":47,"context_line":"      context:"},{"line_number":48,"context_line":"        quotas:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"fa32b979_67027671","line":45,"updated":"2015-06-16 15:40:17.000000000","message":"I would put here 4 iterations ...","commit_id":"650e664518b5641b8a5d7a42bf8d438ad8a29574"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"ad05b1fffa9bec80c67d96cecae4878dc479e318","unresolved":false,"context_lines":[{"line_number":42,"context_line":"        max_sleep: 2"},{"line_number":43,"context_line":"      runner:"},{"line_number":44,"context_line":"        type: \"constant\""},{"line_number":45,"context_line":"        times: 2"},{"line_number":46,"context_line":"        concurrency: 2"},{"line_number":47,"context_line":"      context:"},{"line_number":48,"context_line":"        quotas:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"fa32b979_f8cf077d","line":45,"in_reply_to":"fa32b979_67027671","updated":"2015-06-16 17:08:01.000000000","message":"Done","commit_id":"650e664518b5641b8a5d7a42bf8d438ad8a29574"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"1da8394195d13d75fa375f93c6b71641b167da83","unresolved":false,"context_lines":[{"line_number":46,"context_line":"        concurrency: 2"},{"line_number":47,"context_line":"      context:"},{"line_number":48,"context_line":"        quotas:"},{"line_number":49,"context_line":"          manila:"},{"line_number":50,"context_line":"            shares: -1"},{"line_number":51,"context_line":"            gigabytes: -1"},{"line_number":52,"context_line":"        users:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"fa32b979_c7f3429d","line":49,"updated":"2015-06-16 15:40:17.000000000","message":"actually we don\u0027t need this context here... but you can keep it if you would like","commit_id":"650e664518b5641b8a5d7a42bf8d438ad8a29574"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"ad05b1fffa9bec80c67d96cecae4878dc479e318","unresolved":false,"context_lines":[{"line_number":46,"context_line":"        concurrency: 2"},{"line_number":47,"context_line":"      context:"},{"line_number":48,"context_line":"        quotas:"},{"line_number":49,"context_line":"          manila:"},{"line_number":50,"context_line":"            shares: -1"},{"line_number":51,"context_line":"            gigabytes: -1"},{"line_number":52,"context_line":"        users:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"fa32b979_aa784590","line":49,"in_reply_to":"fa32b979_c7f3429d","updated":"2015-06-16 17:08:01.000000000","message":"I prefer to set here values to explicitly show what quotas we will consume using this scenario.","commit_id":"650e664518b5641b8a5d7a42bf8d438ad8a29574"}],"rally/benchmark/validation.py":[{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"e8d4d2dfcc10dbaa43773188fb874d8e1ea5d494","unresolved":false,"context_lines":[{"line_number":318,"context_line":"    share_proto \u003d config.get(\"args\", {}).get(\"share_proto\")"},{"line_number":319,"context_line":"    if six.text_type(share_proto).upper() not in allowed:"},{"line_number":320,"context_line":"        message \u003d _(\"Share protocol \u0027%(sp)s\u0027 is invalid, allowed values are \""},{"line_number":321,"context_line":"                    \"%(allowed)s.\") % {\"sp\": share_proto, \"allowed\": allowed}"},{"line_number":322,"context_line":"        return ValidationResult(False, message)"},{"line_number":323,"context_line":""},{"line_number":324,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"fa32b979_e2288235","line":321,"updated":"2015-06-17 15:06:09.000000000","message":"I prefer to join allowed types:\n\n    _(\"Share protocol \u0027%(sp)s\u0027 is invalid, allowed values are \u0027%(allowed)s\u0027.\") %\n       {\"sp\": share_proto, \"allowed\": \"\u0027, \u0027\".join(allowed)}\n\nCurrent message: \"Share protocol \u0027share_proto\u0027 is invalid, allowed values are (\u0027NFS\u0027, \u0027CIFS\u0027, \u0027GLUSTERFS\u0027, \u0027HDFS\u0027).\"\n\nProposed: \"Share protocol \u0027share_proto\u0027 is invalid, allowed values are \u0027NFS\u0027, \u0027CIFS\u0027, \u0027GLUSTERFS\u0027, \u0027HDFS\u0027.\"","commit_id":"bd35ea547e8356477f7a8e42a5b4f0829639aded"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"04489c0da4a3055e848a5f87bcfea278597d0177","unresolved":false,"context_lines":[{"line_number":318,"context_line":"    share_proto \u003d config.get(\"args\", {}).get(\"share_proto\")"},{"line_number":319,"context_line":"    if six.text_type(share_proto).upper() not in allowed:"},{"line_number":320,"context_line":"        message \u003d _(\"Share protocol \u0027%(sp)s\u0027 is invalid, allowed values are \""},{"line_number":321,"context_line":"                    \"%(allowed)s.\") % {\"sp\": share_proto, \"allowed\": allowed}"},{"line_number":322,"context_line":"        return ValidationResult(False, message)"},{"line_number":323,"context_line":""},{"line_number":324,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"fa32b979_9579af84","line":321,"in_reply_to":"fa32b979_e2288235","updated":"2015-06-17 15:17:05.000000000","message":"Done","commit_id":"bd35ea547e8356477f7a8e42a5b4f0829639aded"}],"rally/plugins/openstack/context/cleanup/resources.py":[{"author":{"_account_id":7369,"name":"Sergey Skripnick","email":"sskripnick@mirantis.com","username":"redixin"},"change_message_id":"e4720e5b9a856c90c28774d5c8abe3ef7174b395","unresolved":false,"context_lines":[{"line_number":260,"context_line":"class ManilaShare(base.ResourceManager):"},{"line_number":261,"context_line":""},{"line_number":262,"context_line":"    def list(self):"},{"line_number":263,"context_line":"        self._resource \u003d \"shares\""},{"line_number":264,"context_line":"        return super(ManilaShare, self).list()"},{"line_number":265,"context_line":""},{"line_number":266,"context_line":"    def delete(self):"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa32b979_7a718ba7","line":263,"updated":"2015-06-17 10:03:32.000000000","message":"this is no needed. _resource is set by @base.resource decorator","commit_id":"4a104a97ea6b5b15c7d68350c76fe808a8f887fb"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"4e45b33f268671bb709d685ca7f392f37e638be8","unresolved":false,"context_lines":[{"line_number":260,"context_line":"class ManilaShare(base.ResourceManager):"},{"line_number":261,"context_line":""},{"line_number":262,"context_line":"    def list(self):"},{"line_number":263,"context_line":"        self._resource \u003d \"shares\""},{"line_number":264,"context_line":"        return super(ManilaShare, self).list()"},{"line_number":265,"context_line":""},{"line_number":266,"context_line":"    def delete(self):"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa32b979_daa8d722","line":263,"in_reply_to":"fa32b979_7a718ba7","updated":"2015-06-17 10:13:30.000000000","message":"There is incorrect one. That is why this one set.","commit_id":"4a104a97ea6b5b15c7d68350c76fe808a8f887fb"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"968616baad56685e71c747dc8f8374594cd19bfe","unresolved":false,"context_lines":[{"line_number":260,"context_line":"class ManilaShare(base.ResourceManager):"},{"line_number":261,"context_line":""},{"line_number":262,"context_line":"    def list(self):"},{"line_number":263,"context_line":"        self._resource \u003d \"shares\""},{"line_number":264,"context_line":"        return super(ManilaShare, self).list()"},{"line_number":265,"context_line":""},{"line_number":266,"context_line":"    def delete(self):"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa32b979_563a5bcd","line":263,"in_reply_to":"fa32b979_daa8d722","updated":"2015-06-17 12:31:05.000000000","message":"Strange, last time I tested it, it had incorrect value. Now it is ok. Updated.","commit_id":"4a104a97ea6b5b15c7d68350c76fe808a8f887fb"},{"author":{"_account_id":7369,"name":"Sergey Skripnick","email":"sskripnick@mirantis.com","username":"redixin"},"change_message_id":"e4720e5b9a856c90c28774d5c8abe3ef7174b395","unresolved":false,"context_lines":[{"line_number":264,"context_line":"        return super(ManilaShare, self).list()"},{"line_number":265,"context_line":""},{"line_number":266,"context_line":"    def delete(self):"},{"line_number":267,"context_line":"        self._resource \u003d \"shares\""},{"line_number":268,"context_line":"        return super(ManilaShare, self).delete()"},{"line_number":269,"context_line":""},{"line_number":270,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"fa32b979_3a68e3b8","line":267,"updated":"2015-06-17 10:03:32.000000000","message":"ditto","commit_id":"4a104a97ea6b5b15c7d68350c76fe808a8f887fb"}],"rally/plugins/openstack/scenarios/manila/shares.py":[{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"1da8394195d13d75fa375f93c6b71641b167da83","unresolved":false,"context_lines":[{"line_number":22,"context_line":"class ManilaShares(utils.ManilaScenario):"},{"line_number":23,"context_line":"    \"\"\"Benchmark scenarios for Manila shares.\"\"\""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"    @validation.validate_share_proto()"},{"line_number":26,"context_line":"    @validation.required_services(consts.Service.MANILA)"},{"line_number":27,"context_line":"    @validation.required_openstack(users\u003dTrue)"},{"line_number":28,"context_line":"    @base.scenario()"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa32b979_677276af","line":25,"updated":"2015-06-16 15:40:17.000000000","message":"it\u0027s better to specify argument: \n\n   @validation. validate_share_proto(\"share_proto\")\n   ....","commit_id":"650e664518b5641b8a5d7a42bf8d438ad8a29574"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"ad05b1fffa9bec80c67d96cecae4878dc479e318","unresolved":false,"context_lines":[{"line_number":22,"context_line":"class ManilaShares(utils.ManilaScenario):"},{"line_number":23,"context_line":"    \"\"\"Benchmark scenarios for Manila shares.\"\"\""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"    @validation.validate_share_proto()"},{"line_number":26,"context_line":"    @validation.required_services(consts.Service.MANILA)"},{"line_number":27,"context_line":"    @validation.required_openstack(users\u003dTrue)"},{"line_number":28,"context_line":"    @base.scenario()"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa32b979_3827af65","line":25,"in_reply_to":"fa32b979_677276af","updated":"2015-06-16 17:08:01.000000000","message":"Why? This check is specific for one concrete argument. So, no need to specify some that is constant.","commit_id":"650e664518b5641b8a5d7a42bf8d438ad8a29574"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"1da8394195d13d75fa375f93c6b71641b167da83","unresolved":false,"context_lines":[{"line_number":25,"context_line":"    @validation.validate_share_proto()"},{"line_number":26,"context_line":"    @validation.required_services(consts.Service.MANILA)"},{"line_number":27,"context_line":"    @validation.required_openstack(users\u003dTrue)"},{"line_number":28,"context_line":"    @base.scenario()"},{"line_number":29,"context_line":"    def create_and_delete_share(self, share_proto, size\u003d1, min_sleep\u003d0,"},{"line_number":30,"context_line":"                                max_sleep\u003d0, **kwargs):"},{"line_number":31,"context_line":"        \"\"\"Create and delete a share."}],"source_content_type":"text/x-python","patch_set":4,"id":"fa32b979_a41cfc77","line":28,"updated":"2015-06-16 15:40:17.000000000","message":"@base.scenario(context\u003d{\"cleanup\": \"manila\"}), and you should have cleanup resource  for manila shares","commit_id":"650e664518b5641b8a5d7a42bf8d438ad8a29574"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"ad05b1fffa9bec80c67d96cecae4878dc479e318","unresolved":false,"context_lines":[{"line_number":25,"context_line":"    @validation.validate_share_proto()"},{"line_number":26,"context_line":"    @validation.required_services(consts.Service.MANILA)"},{"line_number":27,"context_line":"    @validation.required_openstack(users\u003dTrue)"},{"line_number":28,"context_line":"    @base.scenario()"},{"line_number":29,"context_line":"    def create_and_delete_share(self, share_proto, size\u003d1, min_sleep\u003d0,"},{"line_number":30,"context_line":"                                max_sleep\u003d0, **kwargs):"},{"line_number":31,"context_line":"        \"\"\"Create and delete a share."}],"source_content_type":"text/x-python","patch_set":4,"id":"fa32b979_b86dff99","line":28,"in_reply_to":"fa32b979_a41cfc77","updated":"2015-06-16 17:08:01.000000000","message":"Done","commit_id":"650e664518b5641b8a5d7a42bf8d438ad8a29574"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"1da8394195d13d75fa375f93c6b71641b167da83","unresolved":false,"context_lines":[{"line_number":26,"context_line":"    @validation.required_services(consts.Service.MANILA)"},{"line_number":27,"context_line":"    @validation.required_openstack(users\u003dTrue)"},{"line_number":28,"context_line":"    @base.scenario()"},{"line_number":29,"context_line":"    def create_and_delete_share(self, share_proto, size\u003d1, min_sleep\u003d0,"},{"line_number":30,"context_line":"                                max_sleep\u003d0, **kwargs):"},{"line_number":31,"context_line":"        \"\"\"Create and delete a share."},{"line_number":32,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"fa32b979_6713560e","line":29,"updated":"2015-06-16 15:40:17.000000000","message":"it will be nice to add benchmark that just creates shares (for scale testing purpose)","commit_id":"650e664518b5641b8a5d7a42bf8d438ad8a29574"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"ad05b1fffa9bec80c67d96cecae4878dc479e318","unresolved":false,"context_lines":[{"line_number":26,"context_line":"    @validation.required_services(consts.Service.MANILA)"},{"line_number":27,"context_line":"    @validation.required_openstack(users\u003dTrue)"},{"line_number":28,"context_line":"    @base.scenario()"},{"line_number":29,"context_line":"    def create_and_delete_share(self, share_proto, size\u003d1, min_sleep\u003d0,"},{"line_number":30,"context_line":"                                max_sleep\u003d0, **kwargs):"},{"line_number":31,"context_line":"        \"\"\"Create and delete a share."},{"line_number":32,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"fa32b979_f8e867e4","line":29,"in_reply_to":"fa32b979_6713560e","updated":"2015-06-16 17:08:01.000000000","message":"Could be, but is it necessarily to do in this commit?","commit_id":"650e664518b5641b8a5d7a42bf8d438ad8a29574"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"1da8394195d13d75fa375f93c6b71641b167da83","unresolved":false,"context_lines":[{"line_number":41,"context_line":"        :param max_sleep: maximum sleep time in seconds (non-negative)"},{"line_number":42,"context_line":"        :param kwargs: optional args to create a share"},{"line_number":43,"context_line":"        \"\"\""},{"line_number":44,"context_line":"        share \u003d self._create_share("},{"line_number":45,"context_line":"            share_proto\u003dshare_proto,"},{"line_number":46,"context_line":"            size\u003dsize,"},{"line_number":47,"context_line":"            **kwargs)"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa32b979_27ac6eec","line":44,"updated":"2015-06-16 15:40:17.000000000","message":"Usually we have such style: \n\n  share \u003d self._create_share(share_proto\u003dshare_proto,\n                             size\u003dsize,\n                             **kwargs)","commit_id":"650e664518b5641b8a5d7a42bf8d438ad8a29574"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"ad05b1fffa9bec80c67d96cecae4878dc479e318","unresolved":false,"context_lines":[{"line_number":41,"context_line":"        :param max_sleep: maximum sleep time in seconds (non-negative)"},{"line_number":42,"context_line":"        :param kwargs: optional args to create a share"},{"line_number":43,"context_line":"        \"\"\""},{"line_number":44,"context_line":"        share \u003d self._create_share("},{"line_number":45,"context_line":"            share_proto\u003dshare_proto,"},{"line_number":46,"context_line":"            size\u003dsize,"},{"line_number":47,"context_line":"            **kwargs)"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa32b979_6acebdb5","line":44,"in_reply_to":"fa32b979_27ac6eec","updated":"2015-06-16 17:08:01.000000000","message":"This is question of preference. I prefer to use new-line-approach for two reasons:\n\n- with change of length of method or var name we change only one line. using your approach it will affect indentation.\n\n- more longer names can be used for methods and its params.","commit_id":"650e664518b5641b8a5d7a42bf8d438ad8a29574"}],"tests/unit/benchmark/test_validation.py":[{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"1da8394195d13d75fa375f93c6b71641b167da83","unresolved":false,"context_lines":[{"line_number":348,"context_line":"    @ddt.data("},{"line_number":349,"context_line":"        *([{\"args\": {\"share_proto\": v}} for v in ("},{"line_number":350,"context_line":"           None, \"\", \"nfsfoo\", \"foonfs\", \"nfscifs\", )] +"},{"line_number":351,"context_line":"          [{}, {\"args\": {}}])"},{"line_number":352,"context_line":"    )"},{"line_number":353,"context_line":"    def test_validate_share_proto_invalid(self, config):"},{"line_number":354,"context_line":"        validator \u003d self._unwrap_validator(validation.validate_share_proto)"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa32b979_47b5f2eb","line":351,"updated":"2015-06-16 15:40:17.000000000","message":"usually we use [] instead of () in code","commit_id":"650e664518b5641b8a5d7a42bf8d438ad8a29574"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"ad05b1fffa9bec80c67d96cecae4878dc479e318","unresolved":false,"context_lines":[{"line_number":348,"context_line":"    @ddt.data("},{"line_number":349,"context_line":"        *([{\"args\": {\"share_proto\": v}} for v in ("},{"line_number":350,"context_line":"           None, \"\", \"nfsfoo\", \"foonfs\", \"nfscifs\", )] +"},{"line_number":351,"context_line":"          [{}, {\"args\": {}}])"},{"line_number":352,"context_line":"    )"},{"line_number":353,"context_line":"    def test_validate_share_proto_invalid(self, config):"},{"line_number":354,"context_line":"        validator \u003d self._unwrap_validator(validation.validate_share_proto)"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa32b979_c7ab421c","line":351,"in_reply_to":"fa32b979_47b5f2eb","updated":"2015-06-16 17:08:01.000000000","message":"\"tuple\" is ten times faster than \"list\". So, when we have explicitly defined container with data and are not going to change it, then it is definitely better to use tuple due to speed reasons. Here is exactly that case.","commit_id":"650e664518b5641b8a5d7a42bf8d438ad8a29574"}],"tests/unit/plugins/openstack/scenarios/manila/test_utils.py":[{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"1da8394195d13d75fa375f93c6b71641b167da83","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"@ddt.ddt"},{"line_number":27,"context_line":"class ManilaScenarioTestCase(test.TestCase):"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    def setUp(self):"},{"line_number":30,"context_line":"        super(ManilaScenarioTestCase, self).setUp()"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa32b979_e7c0c62c","line":27,"updated":"2015-06-16 15:40:17.000000000","message":"it will be better to use from tests/test.py  ClientsTestCase instead of TestCase...","commit_id":"650e664518b5641b8a5d7a42bf8d438ad8a29574"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"ad05b1fffa9bec80c67d96cecae4878dc479e318","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"@ddt.ddt"},{"line_number":27,"context_line":"class ManilaScenarioTestCase(test.TestCase):"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    def setUp(self):"},{"line_number":30,"context_line":"        super(ManilaScenarioTestCase, self).setUp()"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa32b979_987d9be9","line":27,"in_reply_to":"fa32b979_e7c0c62c","updated":"2015-06-16 17:08:01.000000000","message":"Done","commit_id":"650e664518b5641b8a5d7a42bf8d438ad8a29574"}]}
