)]}'
{"rally/plugins/openstack/scenarios/manila/shares.py":[{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"43312f7bf8a94228a74c1ac0f71add1fd399d95f","unresolved":false,"context_lines":[{"line_number":138,"context_line":"    @validation.required_services(consts.Service.MANILA)"},{"line_number":139,"context_line":"    @validation.required_openstack(users\u003dTrue)"},{"line_number":140,"context_line":"    @base.scenario(context\u003d{\"cleanup\": [\"manila\"]})"},{"line_number":141,"context_line":"    def create_security_service_and_delete(self, type, dns_ip\u003dNone,"},{"line_number":142,"context_line":"                                           server\u003dNone, domain\u003dNone, user\u003dNone,"},{"line_number":143,"context_line":"                                           password\u003dNone, name\u003dNone,"},{"line_number":144,"context_line":"                                           description\u003dNone):"}],"source_content_type":"text/x-python","patch_set":10,"id":"fa32b979_da0eede4","line":141,"updated":"2015-06-22 09:51:25.000000000","message":"`type\u0027 shadows built-in type, must be renamed\n\nhttp://docs.openstack.org/developer/hacking/#general","commit_id":"ff1362533851d8dd44febe1b870f0e294ca49b36"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"d579754ccdbc6e814e4f7f04518d1a7afdce57f1","unresolved":false,"context_lines":[{"line_number":138,"context_line":"    @validation.required_services(consts.Service.MANILA)"},{"line_number":139,"context_line":"    @validation.required_openstack(users\u003dTrue)"},{"line_number":140,"context_line":"    @base.scenario(context\u003d{\"cleanup\": [\"manila\"]})"},{"line_number":141,"context_line":"    def create_security_service_and_delete(self, type, dns_ip\u003dNone,"},{"line_number":142,"context_line":"                                           server\u003dNone, domain\u003dNone, user\u003dNone,"},{"line_number":143,"context_line":"                                           password\u003dNone, name\u003dNone,"},{"line_number":144,"context_line":"                                           description\u003dNone):"}],"source_content_type":"text/x-python","patch_set":10,"id":"ba3cc151_7ccfbdb3","line":141,"in_reply_to":"fa32b979_da0eede4","updated":"2015-07-06 10:51:25.000000000","message":"Done","commit_id":"ff1362533851d8dd44febe1b870f0e294ca49b36"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"db56e740c19f0ee499139e87ffba768bb09320ca","unresolved":false,"context_lines":[{"line_number":162,"context_line":"            user\u003duser,"},{"line_number":163,"context_line":"            password\u003dpassword,"},{"line_number":164,"context_line":"            name\u003dname,"},{"line_number":165,"context_line":"            description\u003ddescription,"},{"line_number":166,"context_line":"        )"},{"line_number":167,"context_line":"        self._delete_security_service(security_service)"}],"source_content_type":"text/x-python","patch_set":10,"id":"fa32b979_c9798284","line":165,"updated":"2015-06-25 21:54:56.000000000","message":"Why you use a new line for each parameter?","commit_id":"ff1362533851d8dd44febe1b870f0e294ca49b36"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"d579754ccdbc6e814e4f7f04518d1a7afdce57f1","unresolved":false,"context_lines":[{"line_number":162,"context_line":"            user\u003duser,"},{"line_number":163,"context_line":"            password\u003dpassword,"},{"line_number":164,"context_line":"            name\u003dname,"},{"line_number":165,"context_line":"            description\u003ddescription,"},{"line_number":166,"context_line":"        )"},{"line_number":167,"context_line":"        self._delete_security_service(security_service)"}],"source_content_type":"text/x-python","patch_set":10,"id":"ba3cc151_fefc2474","line":165,"in_reply_to":"fa32b979_c9798284","updated":"2015-07-06 10:51:25.000000000","message":"http://docs.openstack.org/developer/hacking/#calling-methods","commit_id":"ff1362533851d8dd44febe1b870f0e294ca49b36"}],"rally/plugins/openstack/scenarios/manila/utils.py":[{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"43312f7bf8a94228a74c1ac0f71add1fd399d95f","unresolved":false,"context_lines":[{"line_number":174,"context_line":"        return share_servers"},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"    @base.atomic_action_timer(\"manila.create_security_service\")"},{"line_number":177,"context_line":"    def _create_security_service(self, type, dns_ip\u003dNone, server\u003dNone,"},{"line_number":178,"context_line":"                                 domain\u003dNone, user\u003dNone, password\u003dNone,"},{"line_number":179,"context_line":"                                 name\u003dNone, description\u003dNone):"},{"line_number":180,"context_line":"        \"\"\"Create security service."}],"source_content_type":"text/x-python","patch_set":10,"id":"fa32b979_fadf3138","line":177,"updated":"2015-06-22 09:51:25.000000000","message":"`type\u0027 must be renamed","commit_id":"ff1362533851d8dd44febe1b870f0e294ca49b36"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"d579754ccdbc6e814e4f7f04518d1a7afdce57f1","unresolved":false,"context_lines":[{"line_number":174,"context_line":"        return share_servers"},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"    @base.atomic_action_timer(\"manila.create_security_service\")"},{"line_number":177,"context_line":"    def _create_security_service(self, type, dns_ip\u003dNone, server\u003dNone,"},{"line_number":178,"context_line":"                                 domain\u003dNone, user\u003dNone, password\u003dNone,"},{"line_number":179,"context_line":"                                 name\u003dNone, description\u003dNone):"},{"line_number":180,"context_line":"        \"\"\"Create security service."}],"source_content_type":"text/x-python","patch_set":10,"id":"ba3cc151_5cf759f5","line":177,"in_reply_to":"fa32b979_fadf3138","updated":"2015-07-06 10:51:25.000000000","message":"Done","commit_id":"ff1362533851d8dd44febe1b870f0e294ca49b36"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"db56e740c19f0ee499139e87ffba768bb09320ca","unresolved":false,"context_lines":[{"line_number":202,"context_line":"            user\u003duser,"},{"line_number":203,"context_line":"            password\u003dpassword,"},{"line_number":204,"context_line":"            name\u003dname,"},{"line_number":205,"context_line":"            description\u003ddescription)"},{"line_number":206,"context_line":"        return security_service"},{"line_number":207,"context_line":""},{"line_number":208,"context_line":"    @base.atomic_action_timer(\"manila.delete_security_service\")"}],"source_content_type":"text/x-python","patch_set":10,"id":"fa32b979_299eeeb8","line":205,"updated":"2015-06-25 21:54:56.000000000","message":"Why you use a new line for each parameter?","commit_id":"ff1362533851d8dd44febe1b870f0e294ca49b36"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"d579754ccdbc6e814e4f7f04518d1a7afdce57f1","unresolved":false,"context_lines":[{"line_number":202,"context_line":"            user\u003duser,"},{"line_number":203,"context_line":"            password\u003dpassword,"},{"line_number":204,"context_line":"            name\u003dname,"},{"line_number":205,"context_line":"            description\u003ddescription)"},{"line_number":206,"context_line":"        return security_service"},{"line_number":207,"context_line":""},{"line_number":208,"context_line":"    @base.atomic_action_timer(\"manila.delete_security_service\")"}],"source_content_type":"text/x-python","patch_set":10,"id":"ba3cc151_7efb3448","line":205,"in_reply_to":"fa32b979_299eeeb8","updated":"2015-07-06 10:51:25.000000000","message":"http://docs.openstack.org/developer/hacking/#calling-methods","commit_id":"ff1362533851d8dd44febe1b870f0e294ca49b36"}],"tests/unit/plugins/openstack/scenarios/manila/test_shares.py":[{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"8aead9a5ab350f13536e468fbf8614098da58613","unresolved":false,"context_lines":[{"line_number":166,"context_line":"        scenario._create_security_service \u003d mock.MagicMock("},{"line_number":167,"context_line":"            return_value\u003dfake_ss)"},{"line_number":168,"context_line":"        scenario._delete_security_service \u003d mock.MagicMock()"},{"line_number":169,"context_line":"        expected_params \u003d {"},{"line_number":170,"context_line":"            \"type\": params.get(\"type\"),"},{"line_number":171,"context_line":"            \"dns_ip\": params.get(\"dns_ip\"),"},{"line_number":172,"context_line":"            \"server\": params.get(\"server\"),"}],"source_content_type":"text/x-python","patch_set":10,"id":"fa32b979_fa0e518b","line":169,"updated":"2015-06-22 10:02:14.000000000","message":"L169-L178 are actually `expected_params \u003d dict(params)\u0027,","commit_id":"ff1362533851d8dd44febe1b870f0e294ca49b36"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"fa2ff13e9bf138d4b545881a58a5eb637925b1a6","unresolved":false,"context_lines":[{"line_number":166,"context_line":"        scenario._create_security_service \u003d mock.MagicMock("},{"line_number":167,"context_line":"            return_value\u003dfake_ss)"},{"line_number":168,"context_line":"        scenario._delete_security_service \u003d mock.MagicMock()"},{"line_number":169,"context_line":"        expected_params \u003d {"},{"line_number":170,"context_line":"            \"type\": params.get(\"type\"),"},{"line_number":171,"context_line":"            \"dns_ip\": params.get(\"dns_ip\"),"},{"line_number":172,"context_line":"            \"server\": params.get(\"server\"),"}],"source_content_type":"text/x-python","patch_set":10,"id":"fa32b979_6ff644d8","line":169,"in_reply_to":"fa32b979_fa0e518b","updated":"2015-06-25 17:31:51.000000000","message":"Line 179 is redundant - yes. But your proposal is not suitable, because all keys in dict with expected params are expected to be there in all cases.","commit_id":"ff1362533851d8dd44febe1b870f0e294ca49b36"}]}
