)]}'
{"rally-jobs/rally-manila.yaml":[{"author":{"_account_id":8840,"name":"Carlos L. Torres","email":"carlos.torres@rackspace.com","username":"carl6796"},"change_message_id":"cffe83491d0dbd7343af8aa288c1b3adc46811b2","unresolved":false,"context_lines":[{"line_number":115,"context_line":"  {% for s in (\"ldap\", \"kerberos\", \"active_directory\") %}"},{"line_number":116,"context_line":"    -"},{"line_number":117,"context_line":"      args:"},{"line_number":118,"context_line":"        security_service_type: \"active_directory\""},{"line_number":119,"context_line":"      runner:"},{"line_number":120,"context_line":"        type: \"constant\""},{"line_number":121,"context_line":"        times: 10"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"fa32b979_f52f503c","line":118,"updated":"2015-06-26 18:04:46.000000000","message":"It seems that the intention of looping over the different security_service_types \u0027ldap, \u0027kerberos\u0027, etc, is not being used here.\n\nIs there are reason?","commit_id":"75dac2461dd5f46af94e936635ed7870cdd52608"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"7c48030c6716185bfa932cec4af73f28447a96b3","unresolved":false,"context_lines":[{"line_number":115,"context_line":"  {% for s in (\"ldap\", \"kerberos\", \"active_directory\") %}"},{"line_number":116,"context_line":"    -"},{"line_number":117,"context_line":"      args:"},{"line_number":118,"context_line":"        security_service_type: \"active_directory\""},{"line_number":119,"context_line":"      runner:"},{"line_number":120,"context_line":"        type: \"constant\""},{"line_number":121,"context_line":"        times: 10"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"fa32b979_bbc5390b","line":118,"in_reply_to":"fa32b979_f52f503c","updated":"2015-07-06 10:58:16.000000000","message":"Good catch! Done.","commit_id":"75dac2461dd5f46af94e936635ed7870cdd52608"}],"rally/plugins/openstack/scenarios/manila/shares.py":[{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"af82b6a6f127e90395da99320f11216e7d02b9ea","unresolved":false,"context_lines":[{"line_number":179,"context_line":"            \u0027active_directory\u0027."},{"line_number":180,"context_line":"        \"\"\""},{"line_number":181,"context_line":"        sn \u003d self._create_share_network()"},{"line_number":182,"context_line":"        ss \u003d self._create_security_service("},{"line_number":183,"context_line":"            security_service_type\u003dsecurity_service_type)"},{"line_number":184,"context_line":"        self._add_security_service_to_share_network(sn, ss)"}],"source_content_type":"text/x-python","patch_set":13,"id":"ba3cc151_e08e6ccf","line":182,"updated":"2015-07-07 19:34:24.000000000","message":"I don\u0027t see the code that cleans up services here:\n\nhttps://github.com/openstack/rally/blob/master/rally/plugins/openstack/context/cleanup/resources.py#L254-L269","commit_id":"4ded8d6ac97b0756c5ff20affb236dfc35fbbef0"},{"author":{"_account_id":6835,"name":"Kun Huang","email":"gareth@openstacker.org","username":"academicgareth"},"change_message_id":"e576df66d39b8c3759c020d71696d301b0b0cf82","unresolved":false,"context_lines":[{"line_number":179,"context_line":"            \u0027active_directory\u0027."},{"line_number":180,"context_line":"        \"\"\""},{"line_number":181,"context_line":"        sn \u003d self._create_share_network()"},{"line_number":182,"context_line":"        ss \u003d self._create_security_service("},{"line_number":183,"context_line":"            security_service_type\u003dsecurity_service_type)"},{"line_number":184,"context_line":"        self._add_security_service_to_share_network(sn, ss)"}],"source_content_type":"text/x-python","patch_set":13,"id":"ba3cc151_a8759198","line":182,"in_reply_to":"ba3cc151_e08e6ccf","updated":"2015-07-08 09:42:42.000000000","message":"@boris\n\nverified, no dirty data :)","commit_id":"4ded8d6ac97b0756c5ff20affb236dfc35fbbef0"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"b7ac163c00397131e68d5771e761f692ee6096d4","unresolved":false,"context_lines":[{"line_number":179,"context_line":"            \u0027active_directory\u0027."},{"line_number":180,"context_line":"        \"\"\""},{"line_number":181,"context_line":"        sn \u003d self._create_share_network()"},{"line_number":182,"context_line":"        ss \u003d self._create_security_service("},{"line_number":183,"context_line":"            security_service_type\u003dsecurity_service_type)"},{"line_number":184,"context_line":"        self._add_security_service_to_share_network(sn, ss)"}],"source_content_type":"text/x-python","patch_set":13,"id":"ba3cc151_ba007eac","line":182,"in_reply_to":"ba3cc151_e08e6ccf","updated":"2015-07-08 05:30:49.000000000","message":"https://review.openstack.org/#/c/191016/13/rally/plugins/openstack/context/cleanup/resources.py","commit_id":"4ded8d6ac97b0756c5ff20affb236dfc35fbbef0"},{"author":{"_account_id":6835,"name":"Kun Huang","email":"gareth@openstacker.org","username":"academicgareth"},"change_message_id":"570b27438a111d6993db9699459921c6635eaa4a","unresolved":false,"context_lines":[{"line_number":180,"context_line":"        \"\"\""},{"line_number":181,"context_line":"        sn \u003d self._create_share_network()"},{"line_number":182,"context_line":"        ss \u003d self._create_security_service("},{"line_number":183,"context_line":"            security_service_type\u003dsecurity_service_type)"},{"line_number":184,"context_line":"        self._add_security_service_to_share_network(sn, ss)"}],"source_content_type":"text/x-python","patch_set":13,"id":"ba3cc151_aab38909","line":183,"updated":"2015-07-07 06:56:06.000000000","message":"I\u0027m sure whether other reviewers would complain these naming style(sn, ss)","commit_id":"4ded8d6ac97b0756c5ff20affb236dfc35fbbef0"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"af82b6a6f127e90395da99320f11216e7d02b9ea","unresolved":false,"context_lines":[{"line_number":180,"context_line":"        \"\"\""},{"line_number":181,"context_line":"        sn \u003d self._create_share_network()"},{"line_number":182,"context_line":"        ss \u003d self._create_security_service("},{"line_number":183,"context_line":"            security_service_type\u003dsecurity_service_type)"},{"line_number":184,"context_line":"        self._add_security_service_to_share_network(sn, ss)"}],"source_content_type":"text/x-python","patch_set":13,"id":"ba3cc151_20fe9438","line":183,"in_reply_to":"ba3cc151_aab38909","updated":"2015-07-07 19:34:24.000000000","message":"It\u0027s ok here, because code is quite short...","commit_id":"4ded8d6ac97b0756c5ff20affb236dfc35fbbef0"}]}