)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"67191925eb0696d25171678c9730fe2cec69a653","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add rally.common.plugin.discover module"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Move all realted to plugins from utils to discover module"},{"line_number":10,"context_line":"and fix the code and tests to make it work"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Ifaed1fadfa0760f121cb1584cb4d8ae3fee8768d"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"fa32b979_c674e09d","line":9,"updated":"2015-06-15 14:44:49.000000000","message":"s/realted/related","commit_id":"ccfcf8de298f5778630783c449d10e48823df969"}],"rally/common/plugin/discover.py":[{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"3b430177ab9c91903ab0178dc6f6778ffeeae12a","unresolved":false,"context_lines":[{"line_number":26,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"def itersubclasses(cls, _seen\u003dNone):"},{"line_number":30,"context_line":"    \"\"\"Generator over all subclasses of a given class in depth first order.\"\"\""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    if not isinstance(cls, type):"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa32b979_5ef87449","line":29,"updated":"2015-06-16 09:39:12.000000000","message":"Maybe s/_seen/seen/ - it seems that there is no reason for leading `_\u0027","commit_id":"e316f061875cdb5ca2e13c446859a8edf36fac21"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"ef512eb1ca49a0a4b1d126bb9af6831d381c4c72","unresolved":false,"context_lines":[{"line_number":26,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"def itersubclasses(cls, _seen\u003dNone):"},{"line_number":30,"context_line":"    \"\"\"Generator over all subclasses of a given class in depth first order.\"\"\""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    if not isinstance(cls, type):"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa32b979_54f85349","line":29,"in_reply_to":"fa32b979_5ef87449","updated":"2015-06-16 10:01:44.000000000","message":"Done","commit_id":"e316f061875cdb5ca2e13c446859a8edf36fac21"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"3b430177ab9c91903ab0178dc6f6778ffeeae12a","unresolved":false,"context_lines":[{"line_number":30,"context_line":"    \"\"\"Generator over all subclasses of a given class in depth first order.\"\"\""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    if not isinstance(cls, type):"},{"line_number":33,"context_line":"        raise TypeError(_(\"itersubclasses must be called with \""},{"line_number":34,"context_line":"                          \"new-style classes, not %.100r\") % cls)"},{"line_number":35,"context_line":"    _seen \u003d _seen or set()"},{"line_number":36,"context_line":"    try:"},{"line_number":37,"context_line":"        subs \u003d cls.__subclasses__()"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa32b979_1e2f4cf7","line":34,"range":{"start_line":33,"start_character":57,"end_line":34,"end_character":50},"updated":"2015-06-16 09:39:12.000000000","message":"Maybe s/%.100r/%r/ ? Does this `.100\u0027 required?","commit_id":"e316f061875cdb5ca2e13c446859a8edf36fac21"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"ef512eb1ca49a0a4b1d126bb9af6831d381c4c72","unresolved":false,"context_lines":[{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    if not isinstance(cls, type):"},{"line_number":33,"context_line":"        raise TypeError(_(\"itersubclasses must be called with \""},{"line_number":34,"context_line":"                          \"new-style classes, not %.100r\") % cls)"},{"line_number":35,"context_line":"    _seen \u003d _seen or set()"},{"line_number":36,"context_line":"    try:"},{"line_number":37,"context_line":"        subs \u003d cls.__subclasses__()"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa32b979_548ff3cb","line":34,"in_reply_to":"fa32b979_1e2f4cf7","updated":"2015-06-16 10:01:44.000000000","message":"I will just remove this. Because we have pep8 checks not to use old style classes. So this part really doesn\u0027t matter for us.","commit_id":"e316f061875cdb5ca2e13c446859a8edf36fac21"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"3b430177ab9c91903ab0178dc6f6778ffeeae12a","unresolved":false,"context_lines":[{"line_number":45,"context_line":"                yield sub"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"def try_append_module(name, modules):"},{"line_number":49,"context_line":"    if name not in modules:"},{"line_number":50,"context_line":"        modules[name] \u003d importutils.import_module(name)"},{"line_number":51,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"fa32b979_3e825095","line":48,"updated":"2015-06-16 09:39:12.000000000","message":"This is implicit append by reference, can we do this explicit? This function seems to be used once at L66, so we can get rid of it at all","commit_id":"e316f061875cdb5ca2e13c446859a8edf36fac21"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"ef512eb1ca49a0a4b1d126bb9af6831d381c4c72","unresolved":false,"context_lines":[{"line_number":45,"context_line":"                yield sub"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"def try_append_module(name, modules):"},{"line_number":49,"context_line":"    if name not in modules:"},{"line_number":50,"context_line":"        modules[name] \u003d importutils.import_module(name)"},{"line_number":51,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"fa32b979_f4bc076e","line":48,"in_reply_to":"fa32b979_3e825095","updated":"2015-06-16 10:01:44.000000000","message":"Done","commit_id":"e316f061875cdb5ca2e13c446859a8edf36fac21"}]}
