)]}'
{"rally-jobs/rally-neutron.yaml":[{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"623922b88908e177a7997fb8a67c7d18bd25b4fa","unresolved":false,"context_lines":[{"line_number":119,"context_line":"        pool_create_args: {}"},{"line_number":120,"context_line":"      runner:"},{"line_number":121,"context_line":"        type: \"constant\""},{"line_number":122,"context_line":"        times: 20"},{"line_number":123,"context_line":"        concurrency: 10"},{"line_number":124,"context_line":"      context:"},{"line_number":125,"context_line":"        users:"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"fa32b979_4c78f9c4","line":122,"updated":"2015-06-15 13:18:56.000000000","message":"please, rebase your change at https://review.openstack.org/#/c/191762/ . at change this line to :\n\n    times: {{smoke or 20}}","commit_id":"dcfc995e4b49395790d744b97a695496824ff7b8"}],"rally/plugins/openstack/scenarios/neutron/loadbalancer_v1.py":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"ac86fd10296c08f7f925847a823ec2e2dbc06266","unresolved":false,"context_lines":[{"line_number":41,"context_line":"    @validation.required_services(consts.Service.NEUTRON)"},{"line_number":42,"context_line":"    @validation.required_openstack(users\u003dTrue)"},{"line_number":43,"context_line":"    @validation.required_contexts(\"network\")"},{"line_number":44,"context_line":"    @base.scenario(context\u003d{\"cleanup\": [\"neutron\"]})"},{"line_number":45,"context_line":"    def create_and_delete_pools(self, pool_create_args\u003dNone):"},{"line_number":46,"context_line":"        \"\"\"Create a pool(v1) and delete a pool(v1)."},{"line_number":47,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"fa32b979_e9e1e6ff","line":44,"updated":"2015-06-13 05:22:13.000000000","message":"No need to use \"context\u003d{\"cleanup\": [\"neutron\"]}\" because resources that are created in scenario are deleted in it too.","commit_id":"c19941712958d46bae2792541c3bac932620cce7"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"bd075891cebb1bc10a28e8c56f92b874cf38ae56","unresolved":false,"context_lines":[{"line_number":41,"context_line":"    @validation.required_services(consts.Service.NEUTRON)"},{"line_number":42,"context_line":"    @validation.required_openstack(users\u003dTrue)"},{"line_number":43,"context_line":"    @validation.required_contexts(\"network\")"},{"line_number":44,"context_line":"    @base.scenario(context\u003d{\"cleanup\": [\"neutron\"]})"},{"line_number":45,"context_line":"    def create_and_delete_pools(self, pool_create_args\u003dNone):"},{"line_number":46,"context_line":"        \"\"\"Create a pool(v1) and delete a pool(v1)."},{"line_number":47,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"fa32b979_294fce93","line":44,"in_reply_to":"fa32b979_09952ae3","updated":"2015-06-13 05:47:43.000000000","message":"Context networks are deleted here: https://github.com/openstack/rally/blob/06b79259/rally/plugins/openstack/context/network.py#L73\n\nYou do not create them in scenario.","commit_id":"c19941712958d46bae2792541c3bac932620cce7"},{"author":{"_account_id":14884,"name":"Kiran Ranganath","email":"kiran7193@gmail.com","username":"kiran"},"change_message_id":"beaf890887f0190f04b9ff62c28d5054869a8811","unresolved":false,"context_lines":[{"line_number":41,"context_line":"    @validation.required_services(consts.Service.NEUTRON)"},{"line_number":42,"context_line":"    @validation.required_openstack(users\u003dTrue)"},{"line_number":43,"context_line":"    @validation.required_contexts(\"network\")"},{"line_number":44,"context_line":"    @base.scenario(context\u003d{\"cleanup\": [\"neutron\"]})"},{"line_number":45,"context_line":"    def create_and_delete_pools(self, pool_create_args\u003dNone):"},{"line_number":46,"context_line":"        \"\"\"Create a pool(v1) and delete a pool(v1)."},{"line_number":47,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"fa32b979_6955d61b","line":44,"in_reply_to":"fa32b979_294fce93","updated":"2015-06-13 05:50:00.000000000","message":"Done","commit_id":"c19941712958d46bae2792541c3bac932620cce7"},{"author":{"_account_id":14884,"name":"Kiran Ranganath","email":"kiran7193@gmail.com","username":"kiran"},"change_message_id":"d81abe7818a4a81627c4ed37334d6f152a3a8d41","unresolved":false,"context_lines":[{"line_number":41,"context_line":"    @validation.required_services(consts.Service.NEUTRON)"},{"line_number":42,"context_line":"    @validation.required_openstack(users\u003dTrue)"},{"line_number":43,"context_line":"    @validation.required_contexts(\"network\")"},{"line_number":44,"context_line":"    @base.scenario(context\u003d{\"cleanup\": [\"neutron\"]})"},{"line_number":45,"context_line":"    def create_and_delete_pools(self, pool_create_args\u003dNone):"},{"line_number":46,"context_line":"        \"\"\"Create a pool(v1) and delete a pool(v1)."},{"line_number":47,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"fa32b979_09952ae3","line":44,"in_reply_to":"fa32b979_e9e1e6ff","updated":"2015-06-13 05:41:10.000000000","message":"How would the context resources cleanup then??\nI retained this for network and subnets created in context.","commit_id":"c19941712958d46bae2792541c3bac932620cce7"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"b6d06912599069f8bca0007d42740ede760800c0","unresolved":false,"context_lines":[{"line_number":54,"context_line":"        pools \u003d []"},{"line_number":55,"context_line":"        for net in self.context.get(\"tenant\", {}).get(\"networks\", []):"},{"line_number":56,"context_line":"            for subnet_id in net[\"subnets\"]:"},{"line_number":57,"context_line":"                pool \u003d self._create_v1_pool(subnet_id, **pool_create_args)"},{"line_number":58,"context_line":"                pools.append(pool)"},{"line_number":59,"context_line":"        for pool in pools:"},{"line_number":60,"context_line":"            self._delete_v1_pool(pool[\"pool\"])"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa32b979_7fca6851","line":57,"updated":"2015-06-13 09:33:26.000000000","message":"do we need \"pool\" variable here at all?","commit_id":"d90ff9f78e90781aab906cdd95d0d507aa0fece5"},{"author":{"_account_id":14884,"name":"Kiran Ranganath","email":"kiran7193@gmail.com","username":"kiran"},"change_message_id":"1a22e5bea77160cd377609aa15d28f781134a337","unresolved":false,"context_lines":[{"line_number":54,"context_line":"        pools \u003d []"},{"line_number":55,"context_line":"        for net in self.context.get(\"tenant\", {}).get(\"networks\", []):"},{"line_number":56,"context_line":"            for subnet_id in net[\"subnets\"]:"},{"line_number":57,"context_line":"                pool \u003d self._create_v1_pool(subnet_id, **pool_create_args)"},{"line_number":58,"context_line":"                pools.append(pool)"},{"line_number":59,"context_line":"        for pool in pools:"},{"line_number":60,"context_line":"            self._delete_v1_pool(pool[\"pool\"])"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa32b979_7fd108fb","line":57,"in_reply_to":"fa32b979_7fca6851","updated":"2015-06-13 09:36:09.000000000","message":"You mean to say like this\n\npools.append(self._create_v1_pool(subnet_id, **pool_create_args))","commit_id":"d90ff9f78e90781aab906cdd95d0d507aa0fece5"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"d401b5a1fe78150c668651199146bca291b12609","unresolved":false,"context_lines":[{"line_number":43,"context_line":"    @validation.required_contexts(\"network\")"},{"line_number":44,"context_line":"    @base.scenario()"},{"line_number":45,"context_line":"    def create_and_delete_pools(self, pool_create_args\u003dNone):"},{"line_number":46,"context_line":"        \"\"\"Create a pool(v1) and delete a pool(v1)."},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"        Measure the \"neutron lb-pool-create\" and \"neutron lb-pool-delete\""},{"line_number":49,"context_line":"        command performance. The scenario creates a pool for every subnet"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa32b979_e2b49bd2","line":46,"updated":"2015-06-13 12:36:10.000000000","message":"Create pools(v1) and delete pools(v1).","commit_id":"ec68ca275dd52d9b4c17640df00d478b6ca4b692"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"f16e531d1356ac759bd64e51ca3e7e68cba907a4","unresolved":false,"context_lines":[{"line_number":41,"context_line":"    @validation.required_services(consts.Service.NEUTRON)"},{"line_number":42,"context_line":"    @validation.required_openstack(users\u003dTrue)"},{"line_number":43,"context_line":"    @validation.required_contexts(\"network\")"},{"line_number":44,"context_line":"    @base.scenario()"},{"line_number":45,"context_line":"    def create_and_delete_pools(self, pool_create_args\u003dNone):"},{"line_number":46,"context_line":"        \"\"\"Create pools(v1) and delete pools(v1)."},{"line_number":47,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"fa32b979_07ab9f75","line":44,"updated":"2015-06-15 16:51:48.000000000","message":"you should change this to: \n\n   @base.scenario(context\u003d{\"cleanup\": [\"neutron\"]})\n\notherwise it may leave some resources in cloud in case of errors ...","commit_id":"098045af8419ba20019f02848aba3bd57d738dfd"},{"author":{"_account_id":14884,"name":"Kiran Ranganath","email":"kiran7193@gmail.com","username":"kiran"},"change_message_id":"b9f2c8fad367143a60f0182c2cc7e99277f7f075","unresolved":false,"context_lines":[{"line_number":41,"context_line":"    @validation.required_services(consts.Service.NEUTRON)"},{"line_number":42,"context_line":"    @validation.required_openstack(users\u003dTrue)"},{"line_number":43,"context_line":"    @validation.required_contexts(\"network\")"},{"line_number":44,"context_line":"    @base.scenario()"},{"line_number":45,"context_line":"    def create_and_delete_pools(self, pool_create_args\u003dNone):"},{"line_number":46,"context_line":"        \"\"\"Create pools(v1) and delete pools(v1)."},{"line_number":47,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"fa32b979_a763d319","line":44,"in_reply_to":"fa32b979_07ab9f75","updated":"2015-06-15 16:56:24.000000000","message":"1) This is a create and delete scenario. Hence the created pool is deleted within the method itself.\n2) The context  resources are cleared buy the context https://github.com/openstack/rally/blob/master/rally/plugins/openstack/context/network.py#L73-L80\n\nHence there is no need of context \u003d {\"cleanup\": [\"neutron\"]}","commit_id":"098045af8419ba20019f02848aba3bd57d738dfd"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"40a1c0bb764d82969ad4fadf6539e97bad826173","unresolved":false,"context_lines":[{"line_number":41,"context_line":"    @validation.required_services(consts.Service.NEUTRON)"},{"line_number":42,"context_line":"    @validation.required_openstack(users\u003dTrue)"},{"line_number":43,"context_line":"    @validation.required_contexts(\"network\")"},{"line_number":44,"context_line":"    @base.scenario()"},{"line_number":45,"context_line":"    def create_and_delete_pools(self, pool_create_args\u003dNone):"},{"line_number":46,"context_line":"        \"\"\"Create pools(v1) and delete pools(v1)."},{"line_number":47,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"fa32b979_18978091","line":44,"in_reply_to":"fa32b979_a763d319","updated":"2015-06-15 17:29:52.000000000","message":"1) In case of connection issues between creation/deletion you will leave resources\n\n2) It is current well known bug that will be fixed some day. And context won\u0027t touch resources of scenario..","commit_id":"098045af8419ba20019f02848aba3bd57d738dfd"},{"author":{"_account_id":7369,"name":"Sergey Skripnick","email":"sskripnick@mirantis.com","username":"redixin"},"change_message_id":"9aa0489fa754ea113e5bc9363f1710f0927fb0ff","unresolved":false,"context_lines":[{"line_number":55,"context_line":"        for net in self.context.get(\"tenant\", {}).get(\"networks\", []):"},{"line_number":56,"context_line":"            for subnet_id in net[\"subnets\"]:"},{"line_number":57,"context_line":"                pools.append(self._create_v1_pool(subnet_id,"},{"line_number":58,"context_line":"                             **pool_create_args))"},{"line_number":59,"context_line":"        for pool in pools:"},{"line_number":60,"context_line":"            self._delete_v1_pool(pool[\"pool\"])"}],"source_content_type":"text/x-python","patch_set":8,"id":"fa32b979_d61bfd19","line":58,"updated":"2015-06-16 13:41:15.000000000","message":"TypeError will be raised if pool_create_arg is None, and it is None by default","commit_id":"baa883a8f1db4b8c050bc57d921588b628f8956f"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"230247f68cd58b8e72543e44450c63b29128a886","unresolved":false,"context_lines":[{"line_number":55,"context_line":"        for net in self.context.get(\"tenant\", {}).get(\"networks\", []):"},{"line_number":56,"context_line":"            for subnet_id in net[\"subnets\"]:"},{"line_number":57,"context_line":"                pools.append(self._create_v1_pool(subnet_id,"},{"line_number":58,"context_line":"                             **pool_create_args))"},{"line_number":59,"context_line":"        for pool in pools:"},{"line_number":60,"context_line":"            self._delete_v1_pool(pool[\"pool\"])"}],"source_content_type":"text/x-python","patch_set":8,"id":"fa32b979_7159dbfd","line":58,"in_reply_to":"fa32b979_d61bfd19","updated":"2015-06-16 13:58:03.000000000","message":"Agree, add `pool_create_args \u003d pool_create_args or {}`, better to fix create_and_list_pools also.","commit_id":"baa883a8f1db4b8c050bc57d921588b628f8956f"},{"author":{"_account_id":14884,"name":"Kiran Ranganath","email":"kiran7193@gmail.com","username":"kiran"},"change_message_id":"7962c5a5a9a5b8fdb2c2269c68ed1d373f1af8be","unresolved":false,"context_lines":[{"line_number":55,"context_line":"        for net in self.context.get(\"tenant\", {}).get(\"networks\", []):"},{"line_number":56,"context_line":"            for subnet_id in net[\"subnets\"]:"},{"line_number":57,"context_line":"                pools.append(self._create_v1_pool(subnet_id,"},{"line_number":58,"context_line":"                             **pool_create_args))"},{"line_number":59,"context_line":"        for pool in pools:"},{"line_number":60,"context_line":"            self._delete_v1_pool(pool[\"pool\"])"}],"source_content_type":"text/x-python","patch_set":8,"id":"fa32b979_11316fec","line":58,"in_reply_to":"fa32b979_d61bfd19","updated":"2015-06-16 13:54:17.000000000","message":"Can I do it this way?\npools.append(self._create_v1_pool(subnet_id,\n                     **pool_create_args or {}))","commit_id":"baa883a8f1db4b8c050bc57d921588b628f8956f"}],"tests/unit/plugins/openstack/scenarios/neutron/test_loadbalancer_v1.py":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"ac86fd10296c08f7f925847a823ec2e2dbc06266","unresolved":false,"context_lines":[{"line_number":38,"context_line":"                    subnet_id, **pool_create_args)"},{"line_number":39,"context_line":"        neutron_scenario._list_v1_pools.assert_called_once_with()"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    def _validate_create_and_delete_pools_scenario(self, pool_create_args):"},{"line_number":42,"context_line":"        neutron_scenario \u003d loadbalancer_v1.NeutronLoadbalancerV1("},{"line_number":43,"context_line":"            self._get_context())"},{"line_number":44,"context_line":"        pool \u003d {"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa32b979_a9799e31","line":41,"updated":"2015-06-13 05:22:13.000000000","message":"You may be interested in simplifying this test suite, see example: https://github.com/openstack/rally/blob/06a442a6/tests/unit/plugins/openstack/scenarios/manila/test_shares.py","commit_id":"c19941712958d46bae2792541c3bac932620cce7"},{"author":{"_account_id":14884,"name":"Kiran Ranganath","email":"kiran7193@gmail.com","username":"kiran"},"change_message_id":"d81abe7818a4a81627c4ed37334d6f152a3a8d41","unresolved":false,"context_lines":[{"line_number":38,"context_line":"                    subnet_id, **pool_create_args)"},{"line_number":39,"context_line":"        neutron_scenario._list_v1_pools.assert_called_once_with()"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    def _validate_create_and_delete_pools_scenario(self, pool_create_args):"},{"line_number":42,"context_line":"        neutron_scenario \u003d loadbalancer_v1.NeutronLoadbalancerV1("},{"line_number":43,"context_line":"            self._get_context())"},{"line_number":44,"context_line":"        pool \u003d {"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa32b979_499332fb","line":41,"in_reply_to":"fa32b979_a9799e31","updated":"2015-06-13 05:41:10.000000000","message":"sounds interesting!! I would like to have more pointers. :)","commit_id":"c19941712958d46bae2792541c3bac932620cce7"},{"author":{"_account_id":13609,"name":"Pavel Boldin","email":"pboldin@mirantis.com","username":"pboldin"},"change_message_id":"ba4923538331c599822ad70f6e6f10871596d964","unresolved":false,"context_lines":[{"line_number":51,"context_line":"        neutron_scenario.create_and_delete_pools("},{"line_number":52,"context_line":"            pool_create_args\u003dpool_create_args)"},{"line_number":53,"context_line":"        pools \u003d []"},{"line_number":54,"context_line":"        for net in self._get_context()[\"tenant\"][\"networks\"]:"},{"line_number":55,"context_line":"            for subnet_id in net[\"subnets\"]:"},{"line_number":56,"context_line":"                pools.append("},{"line_number":57,"context_line":"                    neutron_scenario._create_v1_pool.assert_called_once_with("}],"source_content_type":"text/x-python","patch_set":9,"id":"fa32b979_bab5ec31","line":54,"updated":"2015-06-16 19:42:46.000000000","message":"you only have one network and one subnet so these `assert_called_once_with\u0027 do nothing.\n\nPlease rather assert:\n self.assertEqual([mock.call(subnet_id\u003d..., *pool...), ...], neutron_scenario._create_v1_pool.mock_calls)\n\nPlease fix the rest of the tests as well.","commit_id":"898d0a2b5bdbc1204f9a0e2f47f0b28e933edaca"}],"tests/unit/plugins/openstack/scenarios/neutron/test_utils.py":[{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"d401b5a1fe78150c668651199146bca291b12609","unresolved":false,"context_lines":[{"line_number":434,"context_line":"    def test_delete_pool(self):"},{"line_number":435,"context_line":"        scenario \u003d utils.NeutronScenario()"},{"line_number":436,"context_line":""},{"line_number":437,"context_line":"        pool_create_args \u003d {}"},{"line_number":438,"context_line":"        pool \u003d scenario._create_v1_pool(pool_create_args)"},{"line_number":439,"context_line":"        scenario._delete_v1_pool(pool)"},{"line_number":440,"context_line":"        self._test_atomic_action_timer(scenario.atomic_actions(),"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa32b979_22e283d6","line":437,"updated":"2015-06-13 12:36:10.000000000","message":"why not mock out self.clients(\"neutron\").create_pool and delete_pool?","commit_id":"ec68ca275dd52d9b4c17640df00d478b6ca4b692"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"d401b5a1fe78150c668651199146bca291b12609","unresolved":false,"context_lines":[{"line_number":436,"context_line":""},{"line_number":437,"context_line":"        pool_create_args \u003d {}"},{"line_number":438,"context_line":"        pool \u003d scenario._create_v1_pool(pool_create_args)"},{"line_number":439,"context_line":"        scenario._delete_v1_pool(pool)"},{"line_number":440,"context_line":"        self._test_atomic_action_timer(scenario.atomic_actions(),"},{"line_number":441,"context_line":"                                       \"neutron.delete_pool\")"},{"line_number":442,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"fa32b979_e2eb3baf","line":439,"updated":"2015-06-13 12:36:10.000000000","message":"Needs assert_called_once_with also","commit_id":"ec68ca275dd52d9b4c17640df00d478b6ca4b692"},{"author":{"_account_id":13609,"name":"Pavel Boldin","email":"pboldin@mirantis.com","username":"pboldin"},"change_message_id":"ba4923538331c599822ad70f6e6f10871596d964","unresolved":false,"context_lines":[{"line_number":435,"context_line":"        scenario \u003d utils.NeutronScenario()"},{"line_number":436,"context_line":""},{"line_number":437,"context_line":"        pool_create_args \u003d {}"},{"line_number":438,"context_line":"        pool \u003d scenario._create_v1_pool(pool_create_args)"},{"line_number":439,"context_line":"        scenario._delete_v1_pool(pool)"},{"line_number":440,"context_line":"        self.clients(\"neutron\").delete_pool.assert_called_once_with("},{"line_number":441,"context_line":"            pool[\"pool\"])"}],"source_content_type":"text/x-python","patch_set":9,"id":"fa32b979_babacc08","line":438,"updated":"2015-06-16 19:42:46.000000000","message":"Please do not call the _create_v1_pool here. You are doing it wrong anyways (first arg is subnet_id).\n\nRather, do:\n\n pool \u003d {\"pool\": \"foobar\"}\n \n scenario._delete_v1_pool(pool)\n self.clients(\"neutron\").delete_pool.assert_called_once_with(pool[\"pool\"])","commit_id":"898d0a2b5bdbc1204f9a0e2f47f0b28e933edaca"}]}
