)]}'
{"rally/plugins/openstack/scenarios/neutron/loadbalancer_v1.py":[{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"7dd8661420352d80f08e791d4c974135f472aa19","unresolved":false,"context_lines":[{"line_number":64,"context_line":"    @validation.required_openstack(users\u003dTrue)"},{"line_number":65,"context_line":"    @validation.required_contexts(\"network\")"},{"line_number":66,"context_line":"    @base.scenario(context\u003d{\"cleanup\": [\"neutron\"]})"},{"line_number":67,"context_line":"    def create_and_update_pools(self, pool_update_args, pool_create_args\u003dNone):"},{"line_number":68,"context_line":"        \"\"\"Create a pool(v1) and update a pool(v1)."},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"        Measure the \"neutron lb-pool-create\" and \"neutron lb-pool-delete\""}],"source_content_type":"text/x-python","patch_set":3,"id":"fa32b979_c298776d","line":67,"updated":"2015-06-13 12:28:16.000000000","message":"put pool_update_args\u003dNone, then define with {}, since there are default values for name and admin state in _update_v1_pool","commit_id":"4ad04092ad4ec0cb0f08de37558b1c7477daeb48"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"7dd8661420352d80f08e791d4c974135f472aa19","unresolved":false,"context_lines":[{"line_number":65,"context_line":"    @validation.required_contexts(\"network\")"},{"line_number":66,"context_line":"    @base.scenario(context\u003d{\"cleanup\": [\"neutron\"]})"},{"line_number":67,"context_line":"    def create_and_update_pools(self, pool_update_args, pool_create_args\u003dNone):"},{"line_number":68,"context_line":"        \"\"\"Create a pool(v1) and update a pool(v1)."},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"        Measure the \"neutron lb-pool-create\" and \"neutron lb-pool-delete\""},{"line_number":71,"context_line":"        command performance. The scenario creates a pool for every subnet"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa32b979_e2afbb92","line":68,"updated":"2015-06-13 12:28:16.000000000","message":"Create pools(v1) and update pools(v1)","commit_id":"4ad04092ad4ec0cb0f08de37558b1c7477daeb48"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"7dd8661420352d80f08e791d4c974135f472aa19","unresolved":false,"context_lines":[{"line_number":67,"context_line":"    def create_and_update_pools(self, pool_update_args, pool_create_args\u003dNone):"},{"line_number":68,"context_line":"        \"\"\"Create a pool(v1) and update a pool(v1)."},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"        Measure the \"neutron lb-pool-create\" and \"neutron lb-pool-delete\""},{"line_number":71,"context_line":"        command performance. The scenario creates a pool for every subnet"},{"line_number":72,"context_line":"        and then deletes those pools."},{"line_number":73,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"fa32b979_62c5eb59","line":70,"updated":"2015-06-13 12:28:16.000000000","message":"Measure the \"neutron lb-pool-create\" and \"neutron lb-pool-update\"","commit_id":"4ad04092ad4ec0cb0f08de37558b1c7477daeb48"},{"author":{"_account_id":8576,"name":"Yair Fried","email":"yfried@redhat.com","username":"yfried"},"change_message_id":"dcefbbe0bad738f75cd1c1cdc59f30d123d598bc","unresolved":false,"context_lines":[{"line_number":78,"context_line":"        pools \u003d []"},{"line_number":79,"context_line":"        for net in self.context.get(\"tenant\", {}).get(\"networks\", []):"},{"line_number":80,"context_line":"            for subnet_id in net[\"subnets\"]:"},{"line_number":81,"context_line":"                pools.append(self._create_v1_pool(subnet_id,"},{"line_number":82,"context_line":"                             **pool_create_args))"},{"line_number":83,"context_line":"        for pool in pools:"},{"line_number":84,"context_line":"            self._update_v1_pool(pool, **pool_update_args or {})"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa32b979_eafd496f","line":81,"updated":"2015-06-14 14:46:40.000000000","message":"pool_update_args \u003d pool_update_args or {}","commit_id":"21791440ae6955935e6bb8f53c5ea81e98a7f50b"},{"author":{"_account_id":14884,"name":"Kiran Ranganath","email":"kiran7193@gmail.com","username":"kiran"},"change_message_id":"4877c3d223cae4a8aab1a68d4e932c508d84a07d","unresolved":false,"context_lines":[{"line_number":78,"context_line":"        pools \u003d []"},{"line_number":79,"context_line":"        for net in self.context.get(\"tenant\", {}).get(\"networks\", []):"},{"line_number":80,"context_line":"            for subnet_id in net[\"subnets\"]:"},{"line_number":81,"context_line":"                pools.append(self._create_v1_pool(subnet_id,"},{"line_number":82,"context_line":"                             **pool_create_args))"},{"line_number":83,"context_line":"        for pool in pools:"},{"line_number":84,"context_line":"            self._update_v1_pool(pool, **pool_update_args or {})"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa32b979_a61d35bf","line":81,"in_reply_to":"fa32b979_eafd496f","updated":"2015-06-15 03:01:05.000000000","message":"Why is pool_update _args needed inside _create_v1_pool()?","commit_id":"21791440ae6955935e6bb8f53c5ea81e98a7f50b"},{"author":{"_account_id":8576,"name":"Yair Fried","email":"yfried@redhat.com","username":"yfried"},"change_message_id":"dcefbbe0bad738f75cd1c1cdc59f30d123d598bc","unresolved":false,"context_lines":[{"line_number":81,"context_line":"                pools.append(self._create_v1_pool(subnet_id,"},{"line_number":82,"context_line":"                             **pool_create_args))"},{"line_number":83,"context_line":"        for pool in pools:"},{"line_number":84,"context_line":"            self._update_v1_pool(pool, **pool_update_args or {})"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa32b979_0a03cd74","line":84,"range":{"start_line":84,"start_character":41,"end_line":84,"end_character":57},"updated":"2015-06-14 14:46:40.000000000","message":"please remove \"or {}\"","commit_id":"21791440ae6955935e6bb8f53c5ea81e98a7f50b"},{"author":{"_account_id":14884,"name":"Kiran Ranganath","email":"kiran7193@gmail.com","username":"kiran"},"change_message_id":"4877c3d223cae4a8aab1a68d4e932c508d84a07d","unresolved":false,"context_lines":[{"line_number":81,"context_line":"                pools.append(self._create_v1_pool(subnet_id,"},{"line_number":82,"context_line":"                             **pool_create_args))"},{"line_number":83,"context_line":"        for pool in pools:"},{"line_number":84,"context_line":"            self._update_v1_pool(pool, **pool_update_args or {})"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa32b979_4660e935","line":84,"in_reply_to":"fa32b979_0a03cd74","updated":"2015-06-15 03:01:05.000000000","message":"Please mention why this has to be NOT done. :)","commit_id":"21791440ae6955935e6bb8f53c5ea81e98a7f50b"},{"author":{"_account_id":8576,"name":"Yair Fried","email":"yfried@redhat.com","username":"yfried"},"change_message_id":"2e2fa5fcb6018af3665dc5e2a72ce178a7c05158","unresolved":false,"context_lines":[{"line_number":81,"context_line":"                pools.append(self._create_v1_pool(subnet_id,"},{"line_number":82,"context_line":"                             **pool_create_args))"},{"line_number":83,"context_line":"        for pool in pools:"},{"line_number":84,"context_line":"            self._update_v1_pool(pool, **pool_update_args or {})"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa32b979_4a0f1237","line":84,"in_reply_to":"fa32b979_4660e935","updated":"2015-06-17 11:23:25.000000000","message":"I\u0027m unfamiliar with a strict rule, but IMO it\u0027s better to have defaults set outside of the method invocation.","commit_id":"21791440ae6955935e6bb8f53c5ea81e98a7f50b"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"414d8dd1d9ee5a0ac3ec9dbc0505805cdbc2c3f8","unresolved":false,"context_lines":[{"line_number":75,"context_line":"        :param pool_create_args: dict, POST /lb/pools request options"},{"line_number":76,"context_line":"        :param pool_update_args: dict, POST /lb/pools update options"},{"line_number":77,"context_line":"        \"\"\""},{"line_number":78,"context_line":"        pools \u003d []"},{"line_number":79,"context_line":"        for net in self.context.get(\"tenant\", {}).get(\"networks\", []):"},{"line_number":80,"context_line":"            for subnet_id in net[\"subnets\"]:"},{"line_number":81,"context_line":"                pools.append(self._create_v1_pool(subnet_id,"}],"source_content_type":"text/x-python","patch_set":9,"id":"fa32b979_710a097b","line":78,"updated":"2015-06-17 12:59:34.000000000","message":"Add:\n\npool_create_args \u003d pool_create_args or {}\n\npool_update_args \u003d pool_update_args or {}","commit_id":"6ae676e08e0b63de4048a52063427edee88329c4"}],"rally/plugins/openstack/scenarios/neutron/utils.py":[{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"7dd8661420352d80f08e791d4c974135f472aa19","unresolved":false,"context_lines":[{"line_number":320,"context_line":""},{"line_number":321,"context_line":"    @base.atomic_action_timer(\"neutron.update_pool\")"},{"line_number":322,"context_line":"    def _update_v1_pool(self, pool, **pool_update_args):"},{"line_number":323,"context_line":"        \"\"\"Update the pool name and admin state."},{"line_number":324,"context_line":""},{"line_number":325,"context_line":"        This atomic function updates pool name by"},{"line_number":326,"context_line":"        appending the existing name and admin state with pool_update_args."}],"source_content_type":"text/x-python","patch_set":3,"id":"fa32b979_429f875f","line":323,"updated":"2015-06-13 12:28:16.000000000","message":"\u0027Update pool.\u0027 would be enough, since you didn\u0027t specify name and admin state here.","commit_id":"4ad04092ad4ec0cb0f08de37558b1c7477daeb48"},{"author":{"_account_id":13609,"name":"Pavel Boldin","email":"pboldin@mirantis.com","username":"pboldin"},"change_message_id":"8d0b2d0f5379d04a32b357289e8afa219537d435","unresolved":false,"context_lines":[{"line_number":330,"context_line":"        :returns: updated neutron pool dict"},{"line_number":331,"context_line":"        \"\"\""},{"line_number":332,"context_line":"        suffix \u003d pool_update_args.get("},{"line_number":333,"context_line":"            \"name\", self._generate_random_name(\"_\"))"},{"line_number":334,"context_line":"        admin_state_up \u003d pool_update_args.get(\"admin_state_up\", True)"},{"line_number":335,"context_line":"        body \u003d {"},{"line_number":336,"context_line":"            \"pool\": {"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa32b979_02189f83","line":333,"updated":"2015-06-13 13:37:37.000000000","message":"While this is not important here please note that sometimes calculating a default can take time and the value will be thrown away anyways.\n\nSo, it is better to:\n\n suffix \u003d pool_update_args.get(\"name\", None)\n if suffix is None:\n   suffix \u003d self._generate_random_name(\" \")","commit_id":"a4bcb0e026fefe9ca2644ce64e84e267471d2b40"},{"author":{"_account_id":8576,"name":"Yair Fried","email":"yfried@redhat.com","username":"yfried"},"change_message_id":"dcefbbe0bad738f75cd1c1cdc59f30d123d598bc","unresolved":false,"context_lines":[{"line_number":319,"context_line":"        self.clients(\"neutron\").delete_pool(pool[\"id\"])"},{"line_number":320,"context_line":""},{"line_number":321,"context_line":"    @base.atomic_action_timer(\"neutron.update_pool\")"},{"line_number":322,"context_line":"    def _update_v1_pool(self, pool, **pool_update_args):"},{"line_number":323,"context_line":"        \"\"\"Update pool."},{"line_number":324,"context_line":""},{"line_number":325,"context_line":"        This atomic function updates pool name by"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa32b979_ea34694b","line":322,"updated":"2015-06-14 14:46:40.000000000","message":"seems like update is duplicated in a lot in this module.\nCould you please try and reuse some code here?","commit_id":"21791440ae6955935e6bb8f53c5ea81e98a7f50b"},{"author":{"_account_id":8576,"name":"Yair Fried","email":"yfried@redhat.com","username":"yfried"},"change_message_id":"8c1276f0a3db72f4faf9cbc8d28219c2039b3bd8","unresolved":false,"context_lines":[{"line_number":328,"context_line":"        :param pool: Pool object"},{"line_number":329,"context_line":"        :param pool_update_args: dict, POST /lb/pools update options"},{"line_number":330,"context_line":"        :returns: updated neutron pool dict"},{"line_number":331,"context_line":"        \"\"\""},{"line_number":332,"context_line":"        body \u003d {"},{"line_number":333,"context_line":"            \"pool\": {"},{"line_number":334,"context_line":"                \"name\": pool[\"pool\"][\"name\"] + pool_update_args.get("}],"source_content_type":"text/x-python","patch_set":9,"id":"fa32b979_3d3d3ac4","line":331,"updated":"2015-06-17 11:23:12.000000000","message":"Please don\u0027t do that. If you don\u0027t want to fix the code duplication, leave it as is so it\u0027s clear that this IS code duplication and the next guy will have easier time finding and fixing this.","commit_id":"6ae676e08e0b63de4048a52063427edee88329c4"}],"tests/unit/fakes.py":[{"author":{"_account_id":8576,"name":"Yair Fried","email":"yfried@redhat.com","username":"yfried"},"change_message_id":"dcefbbe0bad738f75cd1c1cdc59f30d123d598bc","unresolved":false,"context_lines":[{"line_number":1195,"context_line":"            raise neutron_exceptions.NeutronClientException"},{"line_number":1196,"context_line":"        self.__networks[network_id].update(data)"},{"line_number":1197,"context_line":""},{"line_number":1198,"context_line":"    def update_pool(self, pool_id, data):"},{"line_number":1199,"context_line":"        if pool_id not in self.__pools:"},{"line_number":1200,"context_line":"            raise neutron_exceptions.NeutronClientException"},{"line_number":1201,"context_line":"        self.__pools[pool_id].update(data)"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa32b979_ca3c0532","line":1198,"updated":"2015-06-14 14:46:40.000000000","message":"ditto","commit_id":"21791440ae6955935e6bb8f53c5ea81e98a7f50b"},{"author":{"_account_id":14884,"name":"Kiran Ranganath","email":"kiran7193@gmail.com","username":"kiran"},"change_message_id":"4877c3d223cae4a8aab1a68d4e932c508d84a07d","unresolved":false,"context_lines":[{"line_number":1195,"context_line":"            raise neutron_exceptions.NeutronClientException"},{"line_number":1196,"context_line":"        self.__networks[network_id].update(data)"},{"line_number":1197,"context_line":""},{"line_number":1198,"context_line":"    def update_pool(self, pool_id, data):"},{"line_number":1199,"context_line":"        if pool_id not in self.__pools:"},{"line_number":1200,"context_line":"            raise neutron_exceptions.NeutronClientException"},{"line_number":1201,"context_line":"        self.__pools[pool_id].update(data)"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa32b979_e63c9d31","line":1198,"in_reply_to":"fa32b979_ca3c0532","updated":"2015-06-15 03:01:05.000000000","message":"Please elaborate. I am not understanding the exact problem here.","commit_id":"21791440ae6955935e6bb8f53c5ea81e98a7f50b"},{"author":{"_account_id":14884,"name":"Kiran Ranganath","email":"kiran7193@gmail.com","username":"kiran"},"change_message_id":"a63976b88092a635b4f016407a98beb4b61d3be8","unresolved":false,"context_lines":[{"line_number":1195,"context_line":"            raise neutron_exceptions.NeutronClientException"},{"line_number":1196,"context_line":"        self.__networks[network_id].update(data)"},{"line_number":1197,"context_line":""},{"line_number":1198,"context_line":"    def update_pool(self, pool_id, data):"},{"line_number":1199,"context_line":"        if pool_id not in self.__pools:"},{"line_number":1200,"context_line":"            raise neutron_exceptions.NeutronClientException"},{"line_number":1201,"context_line":"        self.__pools[pool_id].update(data)"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa32b979_c1f943ca","line":1198,"in_reply_to":"fa32b979_e63c9d31","updated":"2015-06-15 03:22:01.000000000","message":"I got this. I am solving duplication here.","commit_id":"21791440ae6955935e6bb8f53c5ea81e98a7f50b"},{"author":{"_account_id":8576,"name":"Yair Fried","email":"yfried@redhat.com","username":"yfried"},"change_message_id":"8c1276f0a3db72f4faf9cbc8d28219c2039b3bd8","unresolved":false,"context_lines":[{"line_number":1190,"context_line":"        self.__subnets[subnet_id] \u003d subnet"},{"line_number":1191,"context_line":"        return {\"subnet\": subnet}"},{"line_number":1192,"context_line":""},{"line_number":1193,"context_line":"    def update_resource(self, resource_id, resource_list, data):"},{"line_number":1194,"context_line":"        if resource_id not in resource_list:"},{"line_number":1195,"context_line":"            raise neutron_exceptions.NeutronClientException"},{"line_number":1196,"context_line":"        self.resource_list[resource_id].update(data)"}],"source_content_type":"text/x-python","patch_set":9,"id":"fa32b979_fdb7d237","line":1193,"updated":"2015-06-17 11:23:12.000000000","message":"nice fix. but please rename resource_list to resource_dict","commit_id":"6ae676e08e0b63de4048a52063427edee88329c4"},{"author":{"_account_id":14884,"name":"Kiran Ranganath","email":"kiran7193@gmail.com","username":"kiran"},"change_message_id":"d0ee8ba2d000772b2019441fb0fcc7919a8ac241","unresolved":false,"context_lines":[{"line_number":1190,"context_line":"        self.__subnets[subnet_id] \u003d subnet"},{"line_number":1191,"context_line":"        return {\"subnet\": subnet}"},{"line_number":1192,"context_line":""},{"line_number":1193,"context_line":"    def update_resource(self, resource_id, resource_list, data):"},{"line_number":1194,"context_line":"        if resource_id not in resource_list:"},{"line_number":1195,"context_line":"            raise neutron_exceptions.NeutronClientException"},{"line_number":1196,"context_line":"        self.resource_list[resource_id].update(data)"}],"source_content_type":"text/x-python","patch_set":9,"id":"fa32b979_7db42281","line":1193,"in_reply_to":"fa32b979_fdb7d237","updated":"2015-06-17 11:41:16.000000000","message":"Done","commit_id":"6ae676e08e0b63de4048a52063427edee88329c4"}],"tests/unit/plugins/openstack/scenarios/neutron/test_loadbalancer_v1.py":[{"author":{"_account_id":13609,"name":"Pavel Boldin","email":"pboldin@mirantis.com","username":"pboldin"},"change_message_id":"8d0b2d0f5379d04a32b357289e8afa219537d435","unresolved":false,"context_lines":[{"line_number":76,"context_line":"            }"},{"line_number":77,"context_line":"        }"},{"line_number":78,"context_line":"        pool_update_args \u003d {\"name\": \"_updated\", \"admin_state_up\": True}"},{"line_number":79,"context_line":"        neutron_create_mock \u003d neutron_scenario._create_v1_pool \u003d mock.Mock()"},{"line_number":80,"context_line":"        neutron_create_mock.return_value \u003d pool"},{"line_number":81,"context_line":"        neutron_update_mock \u003d neutron_scenario._update_v1_pool \u003d mock.Mock()"},{"line_number":82,"context_line":"        neutron_update_mock.return_value \u003d updated_pool"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa32b979_e23fbbd4","line":79,"updated":"2015-06-13 13:37:37.000000000","message":"There is no need to introduce a new variable:\n neutron_scenario._create_v1_pool \u003d mock.Mock(return_value\u003dpool)\n\nAnd use it in checks:\n neutron_scenario._create_v1_pool.assert_called_once_with(..)","commit_id":"a4bcb0e026fefe9ca2644ce64e84e267471d2b40"}],"tests/unit/plugins/openstack/scenarios/neutron/test_utils.py":[{"author":{"_account_id":13609,"name":"Pavel Boldin","email":"pboldin@mirantis.com","username":"pboldin"},"change_message_id":"8d0b2d0f5379d04a32b357289e8afa219537d435","unresolved":false,"context_lines":[{"line_number":101,"context_line":"        result_pool \u003d scenario._update_v1_pool(pool, **pool_update_args)"},{"line_number":102,"context_line":"        self.clients(\"neutron\").update_pool.assert_called_once_with("},{"line_number":103,"context_line":"            pool[\"pool\"][\"id\"], expected_pool)"},{"line_number":104,"context_line":"        self.assertEqual(result_pool, expected_pool)"},{"line_number":105,"context_line":"        self._test_atomic_action_timer(scenario.atomic_actions(),"},{"line_number":106,"context_line":"                                       \"neutron.update_pool\")"},{"line_number":107,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"fa32b979_a22213b8","line":104,"updated":"2015-06-13 13:37:37.000000000","message":"The order is otherwise.","commit_id":"a4bcb0e026fefe9ca2644ce64e84e267471d2b40"}]}
