)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6835,"name":"Kun Huang","email":"gareth@openstacker.org","username":"academicgareth"},"change_message_id":"a1dc953f46a7c38675a3d63ab0b30636a8fad7a6","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Kiran \u003ckiran.ranganath@maplelabs.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-06-21 13:59:25 +0530"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"pool_create_args not handled for type error"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"pool_create_args is NoneType by default."},{"line_number":10,"context_line":"With this default it would raise a type error."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"fa32b979_11f88f48","line":7,"updated":"2015-06-23 04:33:02.000000000","message":"it\u0027s better to say what you do in this patch rather than what mistakes you found, for example:\n\ns/pool_create_args not handled for type error/Handle NoneType error from pool_create_args","commit_id":"00768b6a87999e0982adf2a63a79cc752ac65908"}],"tests/unit/plugins/openstack/scenarios/neutron/test_loadbalancer_v1.py":[{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"00bf6cf79fce85342ebdd4e9c5e843c8a9fb13ed","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    def _validate_create_and_list_pools_scenario(self, pool_create_args\u003dNone):"},{"line_number":29,"context_line":"        neutron_scenario \u003d loadbalancer_v1.NeutronLoadbalancerV1("},{"line_number":30,"context_line":"            self._get_context())"},{"line_number":31,"context_line":"        pool_data \u003d pool_create_args or {}"},{"line_number":32,"context_line":"        neutron_scenario._create_v1_pool \u003d mock.Mock()"},{"line_number":33,"context_line":"        neutron_scenario._list_v1_pools \u003d mock.Mock()"},{"line_number":34,"context_line":"        neutron_scenario.create_and_list_pools("}],"source_content_type":"text/x-python","patch_set":4,"id":"fa32b979_fb56c828","line":31,"updated":"2015-06-24 20:29:37.000000000","message":"This is very strange. You will send {} instead of None to the method to test that None works. So it\u0027s not valid test. \n\nPlease remove this line","commit_id":"19195060ba6924d3a6bd289f19d01b470eb592be"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"642253976d6e19bbeca8a9fe7fa56747fdb17abb","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    def _validate_create_and_list_pools_scenario(self, pool_create_args\u003dNone):"},{"line_number":29,"context_line":"        neutron_scenario \u003d loadbalancer_v1.NeutronLoadbalancerV1("},{"line_number":30,"context_line":"            self._get_context())"},{"line_number":31,"context_line":"        pool_data \u003d pool_create_args or {}"},{"line_number":32,"context_line":"        neutron_scenario._create_v1_pool \u003d mock.Mock()"},{"line_number":33,"context_line":"        neutron_scenario._list_v1_pools \u003d mock.Mock()"},{"line_number":34,"context_line":"        neutron_scenario.create_and_list_pools("}],"source_content_type":"text/x-python","patch_set":4,"id":"ba3cc151_95259dac","line":31,"in_reply_to":"fa32b979_246b9df2","updated":"2015-06-30 04:23:17.000000000","message":"heh this looks a bit messy, but ok..","commit_id":"19195060ba6924d3a6bd289f19d01b470eb592be"},{"author":{"_account_id":6835,"name":"Kun Huang","email":"gareth@openstacker.org","username":"academicgareth"},"change_message_id":"5dad3d881a6417ce9df5c557b2a52768449965a3","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    def _validate_create_and_list_pools_scenario(self, pool_create_args\u003dNone):"},{"line_number":29,"context_line":"        neutron_scenario \u003d loadbalancer_v1.NeutronLoadbalancerV1("},{"line_number":30,"context_line":"            self._get_context())"},{"line_number":31,"context_line":"        pool_data \u003d pool_create_args or {}"},{"line_number":32,"context_line":"        neutron_scenario._create_v1_pool \u003d mock.Mock()"},{"line_number":33,"context_line":"        neutron_scenario._list_v1_pools \u003d mock.Mock()"},{"line_number":34,"context_line":"        neutron_scenario.create_and_list_pools("}],"source_content_type":"text/x-python","patch_set":4,"id":"fa32b979_246b9df2","line":31,"in_reply_to":"fa32b979_95ee5d20","updated":"2015-06-25 07:22:07.000000000","message":"It works, Boris. \n\nThe pool_create_args (None) is used as input values of function neutron_scenario.create_and_list_pools L34~L35. The var pool_data (empty dict) is used to be uncoupled for assert statement L39. (It is a little misleading)","commit_id":"19195060ba6924d3a6bd289f19d01b470eb592be"},{"author":{"_account_id":14884,"name":"Kiran Ranganath","email":"kiran7193@gmail.com","username":"kiran"},"change_message_id":"e7f0c98562303f51b7c2570570234e8d05e77c14","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    def _validate_create_and_list_pools_scenario(self, pool_create_args\u003dNone):"},{"line_number":29,"context_line":"        neutron_scenario \u003d loadbalancer_v1.NeutronLoadbalancerV1("},{"line_number":30,"context_line":"            self._get_context())"},{"line_number":31,"context_line":"        pool_data \u003d pool_create_args or {}"},{"line_number":32,"context_line":"        neutron_scenario._create_v1_pool \u003d mock.Mock()"},{"line_number":33,"context_line":"        neutron_scenario._list_v1_pools \u003d mock.Mock()"},{"line_number":34,"context_line":"        neutron_scenario.create_and_list_pools("}],"source_content_type":"text/x-python","patch_set":4,"id":"fa32b979_95ee5d20","line":31,"in_reply_to":"fa32b979_fb56c828","updated":"2015-06-25 03:20:14.000000000","message":"**NoneType is not possible. We cannot send NoneType as **kwargs\nThis patch is to avoid this failure itself. https://review.openstack.org/#/c/192222/4/rally/plugins/openstack/scenarios/neutron/loadbalancer_v1.py,cm","commit_id":"19195060ba6924d3a6bd289f19d01b470eb592be"}]}
