)]}'
{"rally/plugins/openstack/scenarios/vm/utils.py":[{"author":{"_account_id":9601,"name":"Oleh Anufriiev","email":"oanufriev@mirantis.com","username":"oanufriev"},"change_message_id":"776412eb95133576cd802790b2e10e1725f62940","unresolved":false,"context_lines":[{"line_number":144,"context_line":"        utils.wait_for("},{"line_number":145,"context_line":"            server_ip,"},{"line_number":146,"context_line":"            is_ready\u003dutils.resource_is(ICMP_UP_STATUS, self._ping_ip_address),"},{"line_number":147,"context_line":"            timeout\u003dCONF.benchmark.vm_ping_timeout,"},{"line_number":148,"context_line":"            check_interval\u003dCONF.benchmark.vm_ping_poll_interval"},{"line_number":149,"context_line":"        )"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"    def _run_command(self, server_ip, port, username, password, command,"}],"source_content_type":"text/x-python","patch_set":8,"id":"ba3cc151_a89b2317","line":148,"range":{"start_line":147,"start_character":0,"end_line":148,"end_character":63},"updated":"2015-07-02 13:01:03.000000000","message":"IMO, you should add ping timeout and check interval as optional kwargs, so scenario developers can set them from scenario/context config.\nIn addition to your implementation tha will be realy configurable.","commit_id":"74267f4e100f90f59259ac1fd39ea084d361447d"},{"author":{"_account_id":11748,"name":"Chris St. Pierre","email":"cstpierr@cisco.com","username":"stpierre"},"change_message_id":"a831d343ac975a5a6ba96db175f38a5915524044","unresolved":false,"context_lines":[{"line_number":145,"context_line":"            server_ip,"},{"line_number":146,"context_line":"            is_ready\u003dutils.resource_is(ICMP_UP_STATUS, self._ping_ip_address),"},{"line_number":147,"context_line":"            timeout\u003dCONF.benchmark.vm_ping_timeout,"},{"line_number":148,"context_line":"            check_interval\u003dCONF.benchmark.vm_ping_poll_interval"},{"line_number":149,"context_line":"        )"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"    def _run_command(self, server_ip, port, username, password, command,"}],"source_content_type":"text/x-python","patch_set":8,"id":"ba3cc151_0b4fa937","line":148,"in_reply_to":"ba3cc151_a89b2317","updated":"2015-07-02 13:07:00.000000000","message":"They can already be set in rally.conf; there\u0027s only one scenario that uses them, so there\u0027s little value in making them kwargs; AFAIK no other scenario has timeouts or poll intervals that are configurable aside from rally.conf; and the ping timeout really shouldn\u0027t vary much from one VM to another. I really don\u0027t know what options you could pass to VMTasks.boot_runcommand_delete to make a VM take vastly longer to become pingable.","commit_id":"74267f4e100f90f59259ac1fd39ea084d361447d"}]}