)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"ebd418353e4e6836279a322636112b6f70a96a2e","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Kiran \u003ckiran.ranganath@maplelabs.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-06-19 16:08:47 +0530"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add create_pool to context"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This feature would help in further scenarios which require"},{"line_number":10,"context_line":"pools to be created in the context."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"fa32b979_42754730","line":7,"updated":"2015-06-19 12:30:49.000000000","message":"Also I\u0027d better rewrite commit message. Change to title for example \"Add ability to create pool in Neutron context\". Just imagine that in the future you are searching for that patch in log history.  Write what you have done, not what you will do.","commit_id":"ede24e90132fce9ebef0dec6bcc8d27e24026617"},{"author":{"_account_id":8576,"name":"Yair Fried","email":"yfried@redhat.com","username":"yfried"},"change_message_id":"0cc943c4537f2432f91eace1dfbd82783500e1e8","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Kiran \u003ckiran.ranganath@maplelabs.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-06-29 13:24:04 +0530"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add ability to create pool in Neutron context"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This feature would help in future scenarios which require"},{"line_number":10,"context_line":"pools to be created in the context."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":17,"id":"ba3cc151_e4c8f976","line":7,"updated":"2015-06-30 08:38:42.000000000","message":"Adds LBaaS-V1 context","commit_id":"e0ee44979e833f6e37c570e478cdd0e3682a3755"},{"author":{"_account_id":14884,"name":"Kiran Ranganath","email":"kiran7193@gmail.com","username":"kiran"},"change_message_id":"203a95d24fd04877f6048da2dfb305b721b65a8b","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Kiran \u003ckiran.ranganath@maplelabs.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-06-29 13:24:04 +0530"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add ability to create pool in Neutron context"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This feature would help in future scenarios which require"},{"line_number":10,"context_line":"pools to be created in the context."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":17,"id":"ba3cc151_b821b1b6","line":7,"in_reply_to":"ba3cc151_e4c8f976","updated":"2015-06-30 10:25:05.000000000","message":"Done","commit_id":"e0ee44979e833f6e37c570e478cdd0e3682a3755"},{"author":{"_account_id":8576,"name":"Yair Fried","email":"yfried@redhat.com","username":"yfried"},"change_message_id":"0cc943c4537f2432f91eace1dfbd82783500e1e8","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2015-06-29 13:24:04 +0530"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add ability to create pool in Neutron context"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This feature would help in future scenarios which require"},{"line_number":10,"context_line":"pools to be created in the context."},{"line_number":11,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":17,"id":"ba3cc151_64ab898a","line":8,"updated":"2015-06-30 08:38:42.000000000","message":"Context to create pools...","commit_id":"e0ee44979e833f6e37c570e478cdd0e3682a3755"},{"author":{"_account_id":14884,"name":"Kiran Ranganath","email":"kiran7193@gmail.com","username":"kiran"},"change_message_id":"203a95d24fd04877f6048da2dfb305b721b65a8b","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2015-06-29 13:24:04 +0530"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add ability to create pool in Neutron context"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This feature would help in future scenarios which require"},{"line_number":10,"context_line":"pools to be created in the context."},{"line_number":11,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":17,"id":"ba3cc151_5830a501","line":8,"in_reply_to":"ba3cc151_64ab898a","updated":"2015-06-30 10:25:05.000000000","message":"Done","commit_id":"e0ee44979e833f6e37c570e478cdd0e3682a3755"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"0bba8592aed7363454f5a3f7db5bc0d026d4aaf4","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Context to create pools."},{"line_number":10,"context_line":"This patch also adds a method in network wrapper"},{"line_number":11,"context_line":"to check if a Network extension is supported in"},{"line_number":12,"context_line":"the deployment."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I7b4defe187c0631928d70bd09d7bcea956f4eed3"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":25,"id":"ba3cc151_85b8b676","line":11,"updated":"2015-07-08 11:24:29.000000000","message":"I would recommend to move this feature (check if a network extension is supported) to separate patch. Just recommendation","commit_id":"fd695ffb07bd56632bc6b5053ed1b645dbc2e958"},{"author":{"_account_id":14884,"name":"Kiran Ranganath","email":"kiran7193@gmail.com","username":"kiran"},"change_message_id":"c34ea75126c9c1088878296eaf9f0d218acef997","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Context to create pools."},{"line_number":10,"context_line":"This patch also adds a method in network wrapper"},{"line_number":11,"context_line":"to check if a Network extension is supported in"},{"line_number":12,"context_line":"the deployment."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I7b4defe187c0631928d70bd09d7bcea956f4eed3"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":25,"id":"ba3cc151_3f152e3f","line":11,"in_reply_to":"ba3cc151_85b8b676","updated":"2015-07-08 12:33:16.000000000","message":"I would like to have it in the same patch.\nIf there is a reason and you want me pull it out, I will. :)","commit_id":"fd695ffb07bd56632bc6b5053ed1b645dbc2e958"},{"author":{"_account_id":6835,"name":"Kun Huang","email":"gareth@openstacker.org","username":"academicgareth"},"change_message_id":"20a6ee26a0d33793e4b35d801034fc561427fa6b","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Adds LBaaS context, verify network extension"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"1) Refactor rally/plugins/openstack/context/{network\u003d\u003eneutron}"},{"line_number":10,"context_line":"2) Context to create LBaaS resources"},{"line_number":11,"context_line":"3) Add check in network wrapper to verify if a Network extension"},{"line_number":12,"context_line":"is supported in the deployment."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":33,"id":"3a50d1a3_699d52bb","line":10,"updated":"2015-07-22 03:02:15.000000000","message":"I think it\u0027s better to say \"create LBaaS v1 resources\"","commit_id":"8abe7bd1d1e5310c3754468f33ee02f1885bb2b8"}],"rally/plugins/openstack/context/lbaas_v1.py":[{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"daf25adfef8560ff0064a92c3b0d437dcc1602eb","unresolved":false,"context_lines":[{"line_number":27,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"@context.context(name\u003d\"lbaas_v1\", order\u003d350)"},{"line_number":31,"context_line":"class LbaasV1(context.Context):"},{"line_number":32,"context_line":"    CONFIG_SCHEMA \u003d {"},{"line_number":33,"context_line":"        \"type\": \"object\","}],"source_content_type":"text/x-python","patch_set":12,"id":"fa32b979_e6ab3d1d","line":30,"updated":"2015-06-26 10:37:42.000000000","message":"order 350 clashes with network context\n\nhttps://github.com/openstack/rally/blob/master/rally/plugins/openstack/context/network.py#L30","commit_id":"b5af2567f6e752319ad01a483ce819a45e54dd1c"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"daf25adfef8560ff0064a92c3b0d437dcc1602eb","unresolved":false,"context_lines":[{"line_number":63,"context_line":"    def setup(self):"},{"line_number":64,"context_line":"        for user, tenant_id in (utils.iterate_per_tenants("},{"line_number":65,"context_line":"                self.context.get(\"users\", []))):"},{"line_number":66,"context_line":"            self.context[\"tenants\"][tenant_id][\"networks\"] \u003d []"},{"line_number":67,"context_line":"            for i in range(self.config[\"networks_per_tenant\"]):"},{"line_number":68,"context_line":"                # NOTE(amaretskiy): add_router and subnets_num take effect"},{"line_number":69,"context_line":"                #                   for Neutron only."}],"source_content_type":"text/x-python","patch_set":12,"id":"fa32b979_017acb77","line":66,"updated":"2015-06-26 10:37:42.000000000","message":"Why create networks by this context? This is already handled by network context!\n\nI think you can:\n\n* add a dependency too network context by decorator @validation.required_contexts(\"network\") and set order\u003d360. So you will have networks created by network context and this context will run after network context\n\n* then in this context list networks, create pools and attach subnets to pools","commit_id":"b5af2567f6e752319ad01a483ce819a45e54dd1c"},{"author":{"_account_id":8576,"name":"Yair Fried","email":"yfried@redhat.com","username":"yfried"},"change_message_id":"b43d2b2e507d83fbfa5ad5674eaf794cc0dfdf4b","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"@context.context(name\u003d\"lbaas_v1\", order\u003d360)"},{"line_number":28,"context_line":"class LbaasV1(context.Context):"},{"line_number":29,"context_line":"    CONFIG_SCHEMA \u003d {"},{"line_number":30,"context_line":"        \"type\": \"object\","},{"line_number":31,"context_line":"        \"$schema\": consts.JSON_SCHEMA,"}],"source_content_type":"text/x-python","patch_set":17,"id":"ba3cc151_ba0a08d1","line":28,"updated":"2015-06-30 08:44:12.000000000","message":"this is called LBaaS, but only creates pools, so the name is misleading.\nIMO, it should be invoked like:  \n\n  lbaas_v1: {\"pools\": ... }\n\nthat way, it can be extended in the future.\n\nIf you think this ctx should only create pools, please name it accordingly: \"lbaas_v1_pools\"","commit_id":"e0ee44979e833f6e37c570e478cdd0e3682a3755"},{"author":{"_account_id":14884,"name":"Kiran Ranganath","email":"kiran7193@gmail.com","username":"kiran"},"change_message_id":"203a95d24fd04877f6048da2dfb305b721b65a8b","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"@context.context(name\u003d\"lbaas_v1\", order\u003d360)"},{"line_number":28,"context_line":"class LbaasV1(context.Context):"},{"line_number":29,"context_line":"    CONFIG_SCHEMA \u003d {"},{"line_number":30,"context_line":"        \"type\": \"object\","},{"line_number":31,"context_line":"        \"$schema\": consts.JSON_SCHEMA,"}],"source_content_type":"text/x-python","patch_set":17,"id":"ba3cc151_61fdb439","line":28,"in_reply_to":"ba3cc151_ba0a08d1","updated":"2015-06-30 10:25:05.000000000","message":"Done","commit_id":"e0ee44979e833f6e37c570e478cdd0e3682a3755"},{"author":{"_account_id":8576,"name":"Yair Fried","email":"yfried@redhat.com","username":"yfried"},"change_message_id":"18f0e621e0b717c928e31bf65a21faa5e6fa7a55","unresolved":false,"context_lines":[{"line_number":50,"context_line":"            osclients.Clients(ctx[\"admin\"][\"endpoint\"]),"},{"line_number":51,"context_line":"            self.config)"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    @utils.log_task_wrapper(LOG.info, _(\"Enter context: `lbaas_v1`\"))"},{"line_number":54,"context_line":"    def setup(self):"},{"line_number":55,"context_line":"        use_sg, msg \u003d self.net_wrapper.supports_extension(\"lbaas\")"},{"line_number":56,"context_line":"        if not use_sg:"}],"source_content_type":"text/x-python","patch_set":19,"id":"ba3cc151_523b9c9c","line":53,"updated":"2015-06-30 11:25:43.000000000","message":"There\u0027s no doc of what this ctx does.\nIIUC: \"creates a lb-pool for each network in tenant.\"\n\nIf I\u0027m right, please add this. if not - please explain.\n\nAlso, I know that pools aren\u0027t tied to a specific network by design, but can hold members from many networks. Am I right?","commit_id":"f93b9b904157317ac510e905d76d9d62b9424637"},{"author":{"_account_id":14884,"name":"Kiran Ranganath","email":"kiran7193@gmail.com","username":"kiran"},"change_message_id":"64f048cfef8e5eb57d265b7347a45c8777f26c82","unresolved":false,"context_lines":[{"line_number":50,"context_line":"            osclients.Clients(ctx[\"admin\"][\"endpoint\"]),"},{"line_number":51,"context_line":"            self.config)"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    @utils.log_task_wrapper(LOG.info, _(\"Enter context: `lbaas_v1`\"))"},{"line_number":54,"context_line":"    def setup(self):"},{"line_number":55,"context_line":"        use_sg, msg \u003d self.net_wrapper.supports_extension(\"lbaas\")"},{"line_number":56,"context_line":"        if not use_sg:"}],"source_content_type":"text/x-python","patch_set":19,"id":"ba3cc151_6d828596","line":53,"in_reply_to":"ba3cc151_523b9c9c","updated":"2015-06-30 12:17:41.000000000","message":"One Pool \u003d One subnet :)","commit_id":"f93b9b904157317ac510e905d76d9d62b9424637"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"2ff78230f3ea000c0c2a6f95ddb29a8e345f8e31","unresolved":false,"context_lines":[{"line_number":37,"context_line":"        \"additionalProperties\": False"},{"line_number":38,"context_line":"    }"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    DEFAULT_CONFIG \u003d {"},{"line_number":41,"context_line":"        \"pool\": {"},{"line_number":42,"context_line":"            \"lb_method\": \"ROUND_ROBIN\","},{"line_number":43,"context_line":"            \"protocol\": \"HTTP\""}],"source_content_type":"text/x-python","patch_set":20,"id":"ba3cc151_ebc2b333","line":40,"updated":"2015-07-01 16:21:49.000000000","message":"Okay, what will be in self.config[\"pool\"] if I specify this in scenario file (missed pool.lb_method):\n\n  \"context\": {\n      ...\n      \"lbaas_v1\": {\n          \"pool\": {\n              \"protocol\": \"HTTP\"\n          }\n      }\n  }","commit_id":"e91ccbc52744d92108336a9dbae447b8ec7f0bde"},{"author":{"_account_id":14884,"name":"Kiran Ranganath","email":"kiran7193@gmail.com","username":"kiran"},"change_message_id":"e6eca47027dffdb9345780342693088b25ae05c2","unresolved":false,"context_lines":[{"line_number":37,"context_line":"        \"additionalProperties\": False"},{"line_number":38,"context_line":"    }"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    DEFAULT_CONFIG \u003d {"},{"line_number":41,"context_line":"        \"pool\": {"},{"line_number":42,"context_line":"            \"lb_method\": \"ROUND_ROBIN\","},{"line_number":43,"context_line":"            \"protocol\": \"HTTP\""}],"source_content_type":"text/x-python","patch_set":20,"id":"ba3cc151_51a90c8f","line":40,"in_reply_to":"ba3cc151_ebc2b333","updated":"2015-07-01 16:49:33.000000000","message":"In this case, default_config is not loaded but,\nAccording to Line #68 **self.config[\"pool\"] contains protocl\u003d\"HTTP\" only. But in https://review.openstack.org/#/c/193432/20/rally/plugins/openstack/wrappers/network.py,cm Line #251 defaults which are not exisitng in the passed **kwargs is gracefully handled and thus this will NOT be a problem. :)","commit_id":"e91ccbc52744d92108336a9dbae447b8ec7f0bde"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"2ff78230f3ea000c0c2a6f95ddb29a8e345f8e31","unresolved":false,"context_lines":[{"line_number":53,"context_line":"    @utils.log_task_wrapper(LOG.info, _(\"Enter context: `lbaas_v1`\"))"},{"line_number":54,"context_line":"    # Creates a lb-pool for every subnet created in network context."},{"line_number":55,"context_line":"    def setup(self):"},{"line_number":56,"context_line":"        use_sg, msg \u003d self.net_wrapper.supports_extension(\"lbaas\")"},{"line_number":57,"context_line":"        if not use_sg:"},{"line_number":58,"context_line":"            LOG.info(_(\"Neutron driver does not support extension: %s\") % msg)"},{"line_number":59,"context_line":"            return"}],"source_content_type":"text/x-python","patch_set":20,"id":"ba3cc151_e5042219","line":56,"updated":"2015-07-01 16:21:49.000000000","message":"It seems that `use_sg\u0027 means \"use security group\" - this is copy-pasted and confusing.\n\nRename it to something logical (for example `use_lb\u0027)","commit_id":"e91ccbc52744d92108336a9dbae447b8ec7f0bde"},{"author":{"_account_id":14884,"name":"Kiran Ranganath","email":"kiran7193@gmail.com","username":"kiran"},"change_message_id":"e6eca47027dffdb9345780342693088b25ae05c2","unresolved":false,"context_lines":[{"line_number":53,"context_line":"    @utils.log_task_wrapper(LOG.info, _(\"Enter context: `lbaas_v1`\"))"},{"line_number":54,"context_line":"    # Creates a lb-pool for every subnet created in network context."},{"line_number":55,"context_line":"    def setup(self):"},{"line_number":56,"context_line":"        use_sg, msg \u003d self.net_wrapper.supports_extension(\"lbaas\")"},{"line_number":57,"context_line":"        if not use_sg:"},{"line_number":58,"context_line":"            LOG.info(_(\"Neutron driver does not support extension: %s\") % msg)"},{"line_number":59,"context_line":"            return"}],"source_content_type":"text/x-python","patch_set":20,"id":"ba3cc151_116b84b8","line":56,"in_reply_to":"ba3cc151_e5042219","updated":"2015-07-01 16:49:33.000000000","message":"Done","commit_id":"e91ccbc52744d92108336a9dbae447b8ec7f0bde"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"2ff78230f3ea000c0c2a6f95ddb29a8e345f8e31","unresolved":false,"context_lines":[{"line_number":55,"context_line":"    def setup(self):"},{"line_number":56,"context_line":"        use_sg, msg \u003d self.net_wrapper.supports_extension(\"lbaas\")"},{"line_number":57,"context_line":"        if not use_sg:"},{"line_number":58,"context_line":"            LOG.info(_(\"Neutron driver does not support extension: %s\") % msg)"},{"line_number":59,"context_line":"            return"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"        for user, tenant_id in (utils.iterate_per_tenants("}],"source_content_type":"text/x-python","patch_set":20,"id":"ba3cc151_a84cb19e","line":58,"updated":"2015-07-01 16:21:49.000000000","message":"msg is \"neutron driver does not support \u003cextension name\u003e\", so full message is:\n\n\"Neutron driver does not support extension: neutron driver does not support \u003cextension name\u003e\"\n\nRemove duplicated part and log `msg\u0027 only:\n\n  LOG.info(msg)","commit_id":"e91ccbc52744d92108336a9dbae447b8ec7f0bde"},{"author":{"_account_id":14884,"name":"Kiran Ranganath","email":"kiran7193@gmail.com","username":"kiran"},"change_message_id":"e6eca47027dffdb9345780342693088b25ae05c2","unresolved":false,"context_lines":[{"line_number":55,"context_line":"    def setup(self):"},{"line_number":56,"context_line":"        use_sg, msg \u003d self.net_wrapper.supports_extension(\"lbaas\")"},{"line_number":57,"context_line":"        if not use_sg:"},{"line_number":58,"context_line":"            LOG.info(_(\"Neutron driver does not support extension: %s\") % msg)"},{"line_number":59,"context_line":"            return"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"        for user, tenant_id in (utils.iterate_per_tenants("}],"source_content_type":"text/x-python","patch_set":20,"id":"ba3cc151_d160bcd1","line":58,"in_reply_to":"ba3cc151_a84cb19e","updated":"2015-07-01 16:49:33.000000000","message":"Done","commit_id":"e91ccbc52744d92108336a9dbae447b8ec7f0bde"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"d511bd2fc544a693535058b89067cf1fc0800b53","unresolved":false,"context_lines":[{"line_number":38,"context_line":"    }"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    DEFAULT_CONFIG \u003d {"},{"line_number":41,"context_line":"        \"pool\": {"},{"line_number":42,"context_line":"            \"lb_method\": \"ROUND_ROBIN\","},{"line_number":43,"context_line":"            \"protocol\": \"HTTP\""},{"line_number":44,"context_line":"        }"}],"source_content_type":"text/x-python","patch_set":22,"id":"ba3cc151_767671d8","line":41,"updated":"2015-07-02 01:12:02.000000000","message":"are there any cases that using LbaasV1 context for other lb resources but don\u0027t need to create pool ? If so, better to add a config to control this.","commit_id":"291aeb9a6af00c57d1ea8c48785f4ce6f335845c"},{"author":{"_account_id":14884,"name":"Kiran Ranganath","email":"kiran7193@gmail.com","username":"kiran"},"change_message_id":"64b2d105795cafe3a591f92d3392c1b830a89983","unresolved":false,"context_lines":[{"line_number":38,"context_line":"    }"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    DEFAULT_CONFIG \u003d {"},{"line_number":41,"context_line":"        \"pool\": {"},{"line_number":42,"context_line":"            \"lb_method\": \"ROUND_ROBIN\","},{"line_number":43,"context_line":"            \"protocol\": \"HTTP\""},{"line_number":44,"context_line":"        }"}],"source_content_type":"text/x-python","patch_set":22,"id":"ba3cc151_ddd43821","line":41,"in_reply_to":"ba3cc151_767671d8","updated":"2015-07-02 05:23:28.000000000","message":"As of now, this context will not be used to create any other lb resources apart from pool.","commit_id":"291aeb9a6af00c57d1ea8c48785f4ce6f335845c"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"d511bd2fc544a693535058b89067cf1fc0800b53","unresolved":false,"context_lines":[{"line_number":51,"context_line":"            self.config)"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    @utils.log_task_wrapper(LOG.info, _(\"Enter context: `lbaas_v1`\"))"},{"line_number":54,"context_line":"    # Creates a lb-pool for every subnet created in network context."},{"line_number":55,"context_line":"    def setup(self):"},{"line_number":56,"context_line":"        use_lb, msg \u003d self.net_wrapper.supports_extension(\"lbaas\")"},{"line_number":57,"context_line":"        if not use_lb:"}],"source_content_type":"text/x-python","patch_set":22,"id":"ba3cc151_364469b5","line":54,"updated":"2015-07-02 01:12:02.000000000","message":"move this to L61","commit_id":"291aeb9a6af00c57d1ea8c48785f4ce6f335845c"},{"author":{"_account_id":14884,"name":"Kiran Ranganath","email":"kiran7193@gmail.com","username":"kiran"},"change_message_id":"64b2d105795cafe3a591f92d3392c1b830a89983","unresolved":false,"context_lines":[{"line_number":51,"context_line":"            self.config)"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    @utils.log_task_wrapper(LOG.info, _(\"Enter context: `lbaas_v1`\"))"},{"line_number":54,"context_line":"    # Creates a lb-pool for every subnet created in network context."},{"line_number":55,"context_line":"    def setup(self):"},{"line_number":56,"context_line":"        use_lb, msg \u003d self.net_wrapper.supports_extension(\"lbaas\")"},{"line_number":57,"context_line":"        if not use_lb:"}],"source_content_type":"text/x-python","patch_set":22,"id":"ba3cc151_fdd9fc57","line":54,"in_reply_to":"ba3cc151_364469b5","updated":"2015-07-02 05:23:28.000000000","message":"Done","commit_id":"291aeb9a6af00c57d1ea8c48785f4ce6f335845c"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"d511bd2fc544a693535058b89067cf1fc0800b53","unresolved":false,"context_lines":[{"line_number":74,"context_line":"                for pool in network.get(\"lb_pools\", []):"},{"line_number":75,"context_line":"                    with logging.ExceptionLogger("},{"line_number":76,"context_line":"                            LOG,"},{"line_number":77,"context_line":"                            _(\"Failed to delete network for tenant %s\")"},{"line_number":78,"context_line":"                            % tenant_id):"},{"line_number":79,"context_line":"                        self.net_wrapper.delete_v1_pool(pool[\"pool\"][\"id\"])"}],"source_content_type":"text/x-python","patch_set":22,"id":"ba3cc151_f631215b","line":77,"updated":"2015-07-02 01:12:02.000000000","message":"Failed to delete pool %(pool)s for tenant %(tenant)s","commit_id":"291aeb9a6af00c57d1ea8c48785f4ce6f335845c"},{"author":{"_account_id":14884,"name":"Kiran Ranganath","email":"kiran7193@gmail.com","username":"kiran"},"change_message_id":"64b2d105795cafe3a591f92d3392c1b830a89983","unresolved":false,"context_lines":[{"line_number":74,"context_line":"                for pool in network.get(\"lb_pools\", []):"},{"line_number":75,"context_line":"                    with logging.ExceptionLogger("},{"line_number":76,"context_line":"                            LOG,"},{"line_number":77,"context_line":"                            _(\"Failed to delete network for tenant %s\")"},{"line_number":78,"context_line":"                            % tenant_id):"},{"line_number":79,"context_line":"                        self.net_wrapper.delete_v1_pool(pool[\"pool\"][\"id\"])"}],"source_content_type":"text/x-python","patch_set":22,"id":"ba3cc151_9dda304a","line":77,"in_reply_to":"ba3cc151_f631215b","updated":"2015-07-02 05:23:28.000000000","message":"Done","commit_id":"291aeb9a6af00c57d1ea8c48785f4ce6f335845c"},{"author":{"_account_id":8576,"name":"Yair Fried","email":"yfried@redhat.com","username":"yfried"},"change_message_id":"2de15a0d7c20d639979f9c1cec8a39e1d08af598","unresolved":false,"context_lines":[{"line_number":57,"context_line":"            LOG.info(msg)"},{"line_number":58,"context_line":"            return"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"        # Creates a lb-pool for every subnet created in network context."},{"line_number":61,"context_line":"        for user, tenant_id in (utils.iterate_per_tenants("},{"line_number":62,"context_line":"                self.context.get(\"users\", []))):"},{"line_number":63,"context_line":"            for network in self.context[\"tenants\"][tenant_id][\"networks\"]:"}],"source_content_type":"text/x-python","patch_set":23,"id":"ba3cc151_af68b088","line":60,"updated":"2015-07-06 07:08:53.000000000","message":"this should be the method\u0027s docstring. not a comment. sorry if I was unclear","commit_id":"ed06e7bb9fd226ad751f40869d37fe166e760af0"},{"author":{"_account_id":14884,"name":"Kiran Ranganath","email":"kiran7193@gmail.com","username":"kiran"},"change_message_id":"b04baa6da3e3bf19d18ee7202c43620a12b46e72","unresolved":false,"context_lines":[{"line_number":57,"context_line":"            LOG.info(msg)"},{"line_number":58,"context_line":"            return"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"        # Creates a lb-pool for every subnet created in network context."},{"line_number":61,"context_line":"        for user, tenant_id in (utils.iterate_per_tenants("},{"line_number":62,"context_line":"                self.context.get(\"users\", []))):"},{"line_number":63,"context_line":"            for network in self.context[\"tenants\"][tenant_id][\"networks\"]:"}],"source_content_type":"text/x-python","patch_set":23,"id":"ba3cc151_cff7348b","line":60,"in_reply_to":"ba3cc151_af68b088","updated":"2015-07-06 07:16:37.000000000","message":"I was asked to move the docstring here. :)\nhttps://review.openstack.org/#/c/193432/22..23/rally/plugins/openstack/context/lbaas_v1.py,unified Line #54","commit_id":"ed06e7bb9fd226ad751f40869d37fe166e760af0"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"0bba8592aed7363454f5a3f7db5bc0d026d4aaf4","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"@context.context(name\u003d\"lbaas_v1\", order\u003d360)"},{"line_number":28,"context_line":"class LbaasV1(context.Context):"},{"line_number":29,"context_line":"    CONFIG_SCHEMA \u003d {"},{"line_number":30,"context_line":"        \"type\": \"object\","},{"line_number":31,"context_line":"        \"$schema\": consts.JSON_SCHEMA,"}],"source_content_type":"text/x-python","patch_set":25,"id":"ba3cc151_8b6f67fb","line":28,"updated":"2015-07-08 11:24:29.000000000","message":"Imagine that we are implementing context for lbaas v2 pools - in this case we will have to improve network wrapper with methods create_v2_pool() and delete_v2_pool(), but the context code can be reused.\n\nI propose make this context class extensible to handle v2 (in future), just rename class name s/LbaasV1/Lbaas/ and add extra argument \"lbaas_version\"","commit_id":"fd695ffb07bd56632bc6b5053ed1b645dbc2e958"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"ae81c86a9454a41432d5e66839c182cb19485623","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"@context.context(name\u003d\"lbaas_v1\", order\u003d360)"},{"line_number":28,"context_line":"class LbaasV1(context.Context):"},{"line_number":29,"context_line":"    CONFIG_SCHEMA \u003d {"},{"line_number":30,"context_line":"        \"type\": \"object\","},{"line_number":31,"context_line":"        \"$schema\": consts.JSON_SCHEMA,"}],"source_content_type":"text/x-python","patch_set":25,"id":"ba3cc151_72276412","line":28,"in_reply_to":"ba3cc151_5fafd229","updated":"2015-07-08 14:41:59.000000000","message":"The only significant change of create-pool arguments for v2 is tenant_id, but tenant_id is something that context knows (L61) - we should not specify it in arguments, so context arguments the same for v1 and v2 and it is reasonable to use same context class for both lbaas versions","commit_id":"fd695ffb07bd56632bc6b5053ed1b645dbc2e958"},{"author":{"_account_id":14884,"name":"Kiran Ranganath","email":"kiran7193@gmail.com","username":"kiran"},"change_message_id":"08cb8d850b4ee14fcf6c9de57722dabc2f2c1b67","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"@context.context(name\u003d\"lbaas_v1\", order\u003d360)"},{"line_number":28,"context_line":"class LbaasV1(context.Context):"},{"line_number":29,"context_line":"    CONFIG_SCHEMA \u003d {"},{"line_number":30,"context_line":"        \"type\": \"object\","},{"line_number":31,"context_line":"        \"$schema\": consts.JSON_SCHEMA,"}],"source_content_type":"text/x-python","patch_set":25,"id":"ba3cc151_61a790a7","line":28,"in_reply_to":"ba3cc151_72276412","updated":"2015-07-08 16:03:44.000000000","message":"I will do it.","commit_id":"fd695ffb07bd56632bc6b5053ed1b645dbc2e958"},{"author":{"_account_id":14884,"name":"Kiran Ranganath","email":"kiran7193@gmail.com","username":"kiran"},"change_message_id":"668d452e1242484a1b3a9ce7a384df908706ba0b","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"@context.context(name\u003d\"lbaas_v1\", order\u003d360)"},{"line_number":28,"context_line":"class LbaasV1(context.Context):"},{"line_number":29,"context_line":"    CONFIG_SCHEMA \u003d {"},{"line_number":30,"context_line":"        \"type\": \"object\","},{"line_number":31,"context_line":"        \"$schema\": consts.JSON_SCHEMA,"}],"source_content_type":"text/x-python","patch_set":25,"id":"ba3cc151_5fafd229","line":28,"in_reply_to":"ba3cc151_8b6f67fb","updated":"2015-07-08 12:48:47.000000000","message":"I don\u0027t think this could be done because v2 has a different config input like lb_method is for v1 and lb_algorithm in v2. So the defaults need to be loaded accordingly. Please give your inputs on this.\n\nhttps://wiki.openstack.org/wiki/Neutron/LBaaS/API_1.0#Create_a_Pool\n\nhttp://developer.openstack.org/api-ref-networking-v2-ext.html#listPools","commit_id":"fd695ffb07bd56632bc6b5053ed1b645dbc2e958"},{"author":{"_account_id":14884,"name":"Kiran Ranganath","email":"kiran7193@gmail.com","username":"kiran"},"change_message_id":"c34ea75126c9c1088878296eaf9f0d218acef997","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"@context.context(name\u003d\"lbaas_v1\", order\u003d360)"},{"line_number":28,"context_line":"class LbaasV1(context.Context):"},{"line_number":29,"context_line":"    CONFIG_SCHEMA \u003d {"},{"line_number":30,"context_line":"        \"type\": \"object\","},{"line_number":31,"context_line":"        \"$schema\": consts.JSON_SCHEMA,"}],"source_content_type":"text/x-python","patch_set":25,"id":"ba3cc151_0c1e0abb","line":28,"in_reply_to":"ba3cc151_8b6f67fb","updated":"2015-07-08 12:33:16.000000000","message":"I will do that","commit_id":"fd695ffb07bd56632bc6b5053ed1b645dbc2e958"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"0bba8592aed7363454f5a3f7db5bc0d026d4aaf4","unresolved":false,"context_lines":[{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    def __init__(self, ctx):"},{"line_number":48,"context_line":"        super(LbaasV1, self).__init__(ctx)"},{"line_number":49,"context_line":"        self.net_wrapper \u003d network_wrapper.wrap("},{"line_number":50,"context_line":"            osclients.Clients(ctx[\"admin\"][\"endpoint\"]),"},{"line_number":51,"context_line":"            self.config)"},{"line_number":52,"context_line":""}],"source_content_type":"text/x-python","patch_set":25,"id":"ba3cc151_5c06031d","line":49,"updated":"2015-07-08 11:24:29.000000000","message":"It is better to create net_wrapper instance in setup() and cleanup(), because some tasks can run very long time (hours) so identity token can expire so cleanup() will not work.\n\nI know that network context has same issue.\n\nI will make proper fix for network context.","commit_id":"fd695ffb07bd56632bc6b5053ed1b645dbc2e958"},{"author":{"_account_id":14884,"name":"Kiran Ranganath","email":"kiran7193@gmail.com","username":"kiran"},"change_message_id":"c34ea75126c9c1088878296eaf9f0d218acef997","unresolved":false,"context_lines":[{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    def __init__(self, ctx):"},{"line_number":48,"context_line":"        super(LbaasV1, self).__init__(ctx)"},{"line_number":49,"context_line":"        self.net_wrapper \u003d network_wrapper.wrap("},{"line_number":50,"context_line":"            osclients.Clients(ctx[\"admin\"][\"endpoint\"]),"},{"line_number":51,"context_line":"            self.config)"},{"line_number":52,"context_line":""}],"source_content_type":"text/x-python","patch_set":25,"id":"ba3cc151_ec7f26de","line":49,"in_reply_to":"ba3cc151_5c06031d","updated":"2015-07-08 12:33:16.000000000","message":"Cleanup should happen only after the run is completed and it is highly likely for the token to get expired.\nPlease elaborate regarding the instantiation. :)","commit_id":"fd695ffb07bd56632bc6b5053ed1b645dbc2e958"},{"author":{"_account_id":14884,"name":"Kiran Ranganath","email":"kiran7193@gmail.com","username":"kiran"},"change_message_id":"08cb8d850b4ee14fcf6c9de57722dabc2f2c1b67","unresolved":false,"context_lines":[{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    def __init__(self, ctx):"},{"line_number":48,"context_line":"        super(LbaasV1, self).__init__(ctx)"},{"line_number":49,"context_line":"        self.net_wrapper \u003d network_wrapper.wrap("},{"line_number":50,"context_line":"            osclients.Clients(ctx[\"admin\"][\"endpoint\"]),"},{"line_number":51,"context_line":"            self.config)"},{"line_number":52,"context_line":""}],"source_content_type":"text/x-python","patch_set":25,"id":"ba3cc151_c1953c32","line":49,"in_reply_to":"ba3cc151_8f24450d","updated":"2015-07-08 16:03:44.000000000","message":"Cool! I shall try to fix this. :)","commit_id":"fd695ffb07bd56632bc6b5053ed1b645dbc2e958"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"46fbac9eb531d88121ef3dba8d02d0d4712c0119","unresolved":false,"context_lines":[{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    def __init__(self, ctx):"},{"line_number":48,"context_line":"        super(LbaasV1, self).__init__(ctx)"},{"line_number":49,"context_line":"        self.net_wrapper \u003d network_wrapper.wrap("},{"line_number":50,"context_line":"            osclients.Clients(ctx[\"admin\"][\"endpoint\"]),"},{"line_number":51,"context_line":"            self.config)"},{"line_number":52,"context_line":""}],"source_content_type":"text/x-python","patch_set":25,"id":"ba3cc151_8f24450d","line":49,"in_reply_to":"ba3cc151_ec7f26de","updated":"2015-07-08 14:26:53.000000000","message":"So that is an example of use case:\n\n * LbaasV1 __init__()  # token is created\n * LbaasV1 setup()  # OK\n * run too many iterations for 2 hours (absolutely real)\n * LbaasV1 cleanup()  # token leaves only 1 hour, so it is expired - Falure\n\nWhat do you think about this?","commit_id":"fd695ffb07bd56632bc6b5053ed1b645dbc2e958"}],"rally/plugins/openstack/context/network.py":[{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"5cd096462584e9a925caf87690d1917aa9975d0b","unresolved":false,"context_lines":[{"line_number":40,"context_line":"                \"type\": \"integer\","},{"line_number":41,"context_line":"                \"minimum\": 1"},{"line_number":42,"context_line":"            },"},{"line_number":43,"context_line":"            \"add_v1_pool\": {"},{"line_number":44,"context_line":"                \"type\": \"boolean\""},{"line_number":45,"context_line":"            }"},{"line_number":46,"context_line":"        },"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa32b979_e9124609","line":43,"updated":"2015-06-19 11:14:14.000000000","message":"This parameter name looks ugly for me - I think that pool version should not be in parameter name.\n\nThis context uses network wrapper - this wrapper should be something smart, so if we want to create pool v1 explicitly - we can use neutron client, but if we want to simplify work then we should use network wrapper which (I think) must be able to auto-detect load balancer api version and then create pool.\n\nSo move care about version to network wrapper side","commit_id":"ede24e90132fce9ebef0dec6bcc8d27e24026617"},{"author":{"_account_id":8576,"name":"Yair Fried","email":"yfried@redhat.com","username":"yfried"},"change_message_id":"a858777bd17c55725459d4dd4f3d425a0c6718de","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"fa32b979_7a29a488","updated":"2015-06-23 11:25:11.000000000","message":"Maybe you missed my previous comment: \n\nNetwork context is for networks. Please create a new context \"lbaas_v1\" that would handle LBaaS resources. We strive to keep these things as small and simple as possible.\nIIRC, you should be able to specify that the new context requires neutorn and/or network context","commit_id":"393b16b08160c764d41eb4d94de7f2598f04a9ba"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"daf25adfef8560ff0064a92c3b0d437dcc1602eb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"fa32b979_413533a6","updated":"2015-06-26 10:37:42.000000000","message":"Do not change this context - see my comment in `context.lbaas_v1\u0027","commit_id":"b5af2567f6e752319ad01a483ce819a45e54dd1c"}],"rally/plugins/openstack/context/neutron/allow_ssh.py":[{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"1ae44067e6fd0b578c45c29959dd7d48023d7896","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":35,"id":"3a50d1a3_54ca574f","updated":"2015-07-22 11:00:53.000000000","message":"Why this context has been moved from `network\u0027 to `neutron\u0027?","commit_id":"3f498ebceb5a962b6738bc10c571d72e2687e1b6"},{"author":{"_account_id":14884,"name":"Kiran Ranganath","email":"kiran7193@gmail.com","username":"kiran"},"change_message_id":"53203f0d4f7ee43db0428dba7f54cbb3402b74e1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":35,"id":"3a50d1a3_efef10e7","in_reply_to":"3a50d1a3_54ca574f","updated":"2015-07-22 11:21:24.000000000","message":"Because this directory does not only contain network context anymore. This patch adds lbaas. So it is good to generalize it according to the project name like it is in nova, keystone etc.","commit_id":"3f498ebceb5a962b6738bc10c571d72e2687e1b6"},{"author":{"_account_id":14884,"name":"Kiran Ranganath","email":"kiran7193@gmail.com","username":"kiran"},"change_message_id":"244bd568af6872eb21f2cb59635d2292f9b5ddfe","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":35,"id":"3a50d1a3_f0bdac68","in_reply_to":"3a50d1a3_ef7f10a9","updated":"2015-07-22 12:04:42.000000000","message":"Agree :)\nI will put only lbaas in neutron","commit_id":"3f498ebceb5a962b6738bc10c571d72e2687e1b6"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"e702175f0f8d52c674f1ba7bf1bc624f5136891e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":35,"id":"3a50d1a3_ef7f10a9","in_reply_to":"3a50d1a3_efef10e7","updated":"2015-07-22 11:27:57.000000000","message":"So this is about neutron, not nova, right? If so, why this context does nova stuff?","commit_id":"3f498ebceb5a962b6738bc10c571d72e2687e1b6"}],"rally/plugins/openstack/context/neutron/lbaas.py":[{"author":{"_account_id":6835,"name":"Kun Huang","email":"gareth@openstacker.org","username":"academicgareth"},"change_message_id":"20a6ee26a0d33793e4b35d801034fc561427fa6b","unresolved":false,"context_lines":[{"line_number":69,"context_line":"                self.context.get(\"users\", []))):"},{"line_number":70,"context_line":"            for network in self.context[\"tenants\"][tenant_id][\"networks\"]:"},{"line_number":71,"context_line":"                for subnet in network.get(\"subnets\", []):"},{"line_number":72,"context_line":"                    if self.config[\"lbaas_version\"] \u003d\u003d 1:"},{"line_number":73,"context_line":"                        network.setdefault(\"lb_pools\", []).append("},{"line_number":74,"context_line":"                            net_wrapper.create_v1_pool("},{"line_number":75,"context_line":"                                subnet,"}],"source_content_type":"text/x-python","patch_set":33,"id":"3a50d1a3_8989be77","line":72,"updated":"2015-07-22 03:02:15.000000000","message":"what about adding a else statement for this if:\n    else:\n        raise NotImplementedError(\"bla bla\")","commit_id":"8abe7bd1d1e5310c3754468f33ee02f1885bb2b8"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"1ae44067e6fd0b578c45c29959dd7d48023d7896","unresolved":false,"context_lines":[{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    def __init__(self, ctx):"},{"line_number":53,"context_line":"        super(Lbaas, self).__init__(ctx)"},{"line_number":54,"context_line":"        self.ctx \u003d ctx"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    @utils.log_task_wrapper(LOG.info, _(\"Enter context: `lbaas`\"))"},{"line_number":57,"context_line":"    def setup(self):"}],"source_content_type":"text/x-python","patch_set":35,"id":"3a50d1a3_54d1f7f8","line":54,"updated":"2015-07-22 11:00:53.000000000","message":"You do not need this `self.ctx\u0027 as well as the __init__() - this `ctx\u0027 is already saved by base class:\n\nhttps://github.com/openstack/rally/blob/master/rally/task/context.py#L73","commit_id":"3f498ebceb5a962b6738bc10c571d72e2687e1b6"},{"author":{"_account_id":14884,"name":"Kiran Ranganath","email":"kiran7193@gmail.com","username":"kiran"},"change_message_id":"53203f0d4f7ee43db0428dba7f54cbb3402b74e1","unresolved":false,"context_lines":[{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    def __init__(self, ctx):"},{"line_number":53,"context_line":"        super(Lbaas, self).__init__(ctx)"},{"line_number":54,"context_line":"        self.ctx \u003d ctx"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    @utils.log_task_wrapper(LOG.info, _(\"Enter context: `lbaas`\"))"},{"line_number":57,"context_line":"    def setup(self):"}],"source_content_type":"text/x-python","patch_set":35,"id":"3a50d1a3_ef74f036","line":54,"in_reply_to":"3a50d1a3_54d1f7f8","updated":"2015-07-22 11:21:24.000000000","message":"Done","commit_id":"3f498ebceb5a962b6738bc10c571d72e2687e1b6"}],"rally/plugins/openstack/context/neutron/networks.py":[{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"1ae44067e6fd0b578c45c29959dd7d48023d7896","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":35,"id":"3a50d1a3_d40bc78c","updated":"2015-07-22 11:00:53.000000000","message":"Why thsi context has been moved to `neutron\u0027? Do you think this context does not work with nova-network?","commit_id":"3f498ebceb5a962b6738bc10c571d72e2687e1b6"}],"rally/plugins/openstack/wrappers/network.py":[{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"016ef9e4814c47ec60bdf2a9ae72d7fa0d82cb61","unresolved":false,"context_lines":[{"line_number":232,"context_line":"    def create_lb_pool(self, subnet_id, **kwargs):"},{"line_number":233,"context_line":"        \"\"\"Create LB Pool (v1)."},{"line_number":234,"context_line":""},{"line_number":235,"context_line":"        :param subnet_id: str, neutron subnet-id"},{"line_number":236,"context_line":"        :returns: neutron lb-pool dict"},{"line_number":237,"context_line":"        \"\"\""},{"line_number":238,"context_line":"        pool_args \u003d {"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa32b979_cbebbd77","line":235,"updated":"2015-06-19 09:41:01.000000000","message":"Please document kwargs also","commit_id":"77d737eac8024341fb09ad9d15854a59a0a6721d"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"016ef9e4814c47ec60bdf2a9ae72d7fa0d82cb61","unresolved":false,"context_lines":[{"line_number":291,"context_line":"                                                 {\"subnet_id\": subnet[\"id\"]})"},{"line_number":292,"context_line":""},{"line_number":293,"context_line":"        pools \u003d []"},{"line_number":294,"context_line":"        if kwargs.get(\"add_v1_pool\", False):"},{"line_number":295,"context_line":"            for subnet_id in subnets:"},{"line_number":296,"context_line":"                pool \u003d self.create_lb_pool(subnet_id, **kwargs)"},{"line_number":297,"context_line":"                pools.append(pool[\"pool\"][\"id\"])"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa32b979_960f1c2e","line":294,"updated":"2015-06-19 09:41:01.000000000","message":"It will return None by default that is not passed value for if. So maybe we could remove False here.","commit_id":"77d737eac8024341fb09ad9d15854a59a0a6721d"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"016ef9e4814c47ec60bdf2a9ae72d7fa0d82cb61","unresolved":false,"context_lines":[{"line_number":294,"context_line":"        if kwargs.get(\"add_v1_pool\", False):"},{"line_number":295,"context_line":"            for subnet_id in subnets:"},{"line_number":296,"context_line":"                pool \u003d self.create_lb_pool(subnet_id, **kwargs)"},{"line_number":297,"context_line":"                pools.append(pool[\"pool\"][\"id\"])"},{"line_number":298,"context_line":""},{"line_number":299,"context_line":"        return {\"id\": network[\"id\"],"},{"line_number":300,"context_line":"                \"name\": network[\"name\"],"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa32b979_d6f604f9","line":297,"updated":"2015-06-19 09:41:01.000000000","message":"Looks strange we return pool and in pool there is a key pool)","commit_id":"77d737eac8024341fb09ad9d15854a59a0a6721d"},{"author":{"_account_id":14884,"name":"Kiran Ranganath","email":"kiran7193@gmail.com","username":"kiran"},"change_message_id":"cb0c3cb61138cf92339bf808b18a6a01bec5c936","unresolved":false,"context_lines":[{"line_number":294,"context_line":"        if kwargs.get(\"add_v1_pool\", False):"},{"line_number":295,"context_line":"            for subnet_id in subnets:"},{"line_number":296,"context_line":"                pool \u003d self.create_lb_pool(subnet_id, **kwargs)"},{"line_number":297,"context_line":"                pools.append(pool[\"pool\"][\"id\"])"},{"line_number":298,"context_line":""},{"line_number":299,"context_line":"        return {\"id\": network[\"id\"],"},{"line_number":300,"context_line":"                \"name\": network[\"name\"],"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa32b979_5ced35ee","line":297,"in_reply_to":"fa32b979_d6f604f9","updated":"2015-06-19 10:36:43.000000000","message":"The API\u0027s work that way. :) take a look at this link\nhttps://wiki.openstack.org/wiki/Neutron/LBaaS/API_1.0#Create_a_Pool\nstructure is like pool\u003d{\"pool\":{\"id\":\"hijk\", \"lb_method\": \"ROUND_ROBIN\",...}","commit_id":"77d737eac8024341fb09ad9d15854a59a0a6721d"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"5cd096462584e9a925caf87690d1917aa9975d0b","unresolved":false,"context_lines":[{"line_number":301,"context_line":"                \"name\": network[\"name\"],"},{"line_number":302,"context_line":"                \"status\": network[\"status\"],"},{"line_number":303,"context_line":"                \"subnets\": subnets,"},{"line_number":304,"context_line":"                \"v1_pools\": pools,"},{"line_number":305,"context_line":"                \"external\": network.get(\"router:external\", False),"},{"line_number":306,"context_line":"                \"router_id\": router and router[\"id\"] or None,"},{"line_number":307,"context_line":"                \"tenant_id\": tenant_id}"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa32b979_a91c3e14","line":304,"updated":"2015-06-19 11:14:14.000000000","message":"\"pools\": [\u003cpool-id\u003e, ...],\n\"lb_version\": 1,","commit_id":"ede24e90132fce9ebef0dec6bcc8d27e24026617"},{"author":{"_account_id":8576,"name":"Yair Fried","email":"yfried@redhat.com","username":"yfried"},"change_message_id":"eaf9ce219bcb4accf63e1fda6d1af0ae4f8fd8ee","unresolved":false,"context_lines":[{"line_number":229,"context_line":"                    \"network_id\": net[\"id\"], \"enable_snat\": True}"},{"line_number":230,"context_line":"        return self.client.create_router({\"router\": kwargs})[\"router\"]"},{"line_number":231,"context_line":""},{"line_number":232,"context_line":"    def create_lb_pool(self, subnet_id, **kwargs):"},{"line_number":233,"context_line":"        \"\"\"Create LB Pool (v1)."},{"line_number":234,"context_line":""},{"line_number":235,"context_line":"        :param subnet_id: str, neutron subnet-id"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa32b979_acd505ba","line":232,"updated":"2015-06-21 07:14:28.000000000","message":"method should have V1 in its name.\nAs we discussed, if the Class doesn\u0027t have \"V1\" then method/property should.\nThe reason is that in the future this could clash with v2 code.","commit_id":"dca15cab3134b5530ae7ae409d5db9c8e94c193a"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"4407d69d8b98a633a5bbd1e69aea15c058b1082f","unresolved":false,"context_lines":[{"line_number":294,"context_line":"        pools \u003d []"},{"line_number":295,"context_line":"        if kwargs.get(\"add_lb_pool\"):"},{"line_number":296,"context_line":"            for subnet_id in subnets:"},{"line_number":297,"context_line":"                pools.append(self.create_v1_pool(subnet_id, **kwargs))"},{"line_number":298,"context_line":""},{"line_number":299,"context_line":"        return {\"id\": network[\"id\"],"},{"line_number":300,"context_line":"                \"name\": network[\"name\"],"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa32b979_eef20f06","line":297,"updated":"2015-06-22 11:22:16.000000000","message":"How do we know that we should use v1?","commit_id":"18d72089378ba167b2c50a016f4076bf73a7f74e"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"4407d69d8b98a633a5bbd1e69aea15c058b1082f","unresolved":false,"context_lines":[{"line_number":325,"context_line":"        for subnet_id in network[\"subnets\"]:"},{"line_number":326,"context_line":"            self._delete_subnet(subnet_id)"},{"line_number":327,"context_line":""},{"line_number":328,"context_line":"        for pool_id in network[\"lb_pools\"]:"},{"line_number":329,"context_line":"            self.client.delete_pool(pool_id)"},{"line_number":330,"context_line":""},{"line_number":331,"context_line":"        return self.client.delete_network(network[\"id\"])"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa32b979_4e9e9bb9","line":328,"updated":"2015-06-22 11:22:16.000000000","message":"What is pool_id? I guess that is dict (see L237, L247, L297), so at least variable name is not correct, however it seems that we need ID, not dict here","commit_id":"18d72089378ba167b2c50a016f4076bf73a7f74e"},{"author":{"_account_id":8576,"name":"Yair Fried","email":"yfried@redhat.com","username":"yfried"},"change_message_id":"0cc943c4537f2432f91eace1dfbd82783500e1e8","unresolved":false,"context_lines":[{"line_number":95,"context_line":"        \"\"\"Delete floating IP.\"\"\""},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"    @abc.abstractmethod"},{"line_number":98,"context_line":"    def supports_extension(self):"},{"line_number":99,"context_line":"        \"\"\"Checks whether a neutron extension is supported.\"\"\""},{"line_number":100,"context_line":""},{"line_number":101,"context_line":""}],"source_content_type":"text/x-python","patch_set":17,"id":"ba3cc151_44520569","line":98,"updated":"2015-06-30 08:38:42.000000000","message":"Ideally, this change would be a different patch. At the very least, it should be mentioned in commit-msg.","commit_id":"e0ee44979e833f6e37c570e478cdd0e3682a3755"},{"author":{"_account_id":14884,"name":"Kiran Ranganath","email":"kiran7193@gmail.com","username":"kiran"},"change_message_id":"203a95d24fd04877f6048da2dfb305b721b65a8b","unresolved":false,"context_lines":[{"line_number":95,"context_line":"        \"\"\"Delete floating IP.\"\"\""},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"    @abc.abstractmethod"},{"line_number":98,"context_line":"    def supports_extension(self):"},{"line_number":99,"context_line":"        \"\"\"Checks whether a neutron extension is supported.\"\"\""},{"line_number":100,"context_line":""},{"line_number":101,"context_line":""}],"source_content_type":"text/x-python","patch_set":17,"id":"ba3cc151_78a9e97a","line":98,"in_reply_to":"ba3cc151_44520569","updated":"2015-06-30 10:25:05.000000000","message":"Done","commit_id":"e0ee44979e833f6e37c570e478cdd0e3682a3755"},{"author":{"_account_id":8576,"name":"Yair Fried","email":"yfried@redhat.com","username":"yfried"},"change_message_id":"0cc943c4537f2432f91eace1dfbd82783500e1e8","unresolved":false,"context_lines":[{"line_number":96,"context_line":""},{"line_number":97,"context_line":"    @abc.abstractmethod"},{"line_number":98,"context_line":"    def supports_extension(self):"},{"line_number":99,"context_line":"        \"\"\"Checks whether a neutron extension is supported.\"\"\""},{"line_number":100,"context_line":""},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"class NovaNetworkWrapper(NetworkWrapper):"}],"source_content_type":"text/x-python","patch_set":17,"id":"ba3cc151_5fe88e7c","line":99,"updated":"2015-06-30 08:38:42.000000000","message":"This is the top level. so s/neutron/network","commit_id":"e0ee44979e833f6e37c570e478cdd0e3682a3755"},{"author":{"_account_id":14884,"name":"Kiran Ranganath","email":"kiran7193@gmail.com","username":"kiran"},"change_message_id":"203a95d24fd04877f6048da2dfb305b721b65a8b","unresolved":false,"context_lines":[{"line_number":96,"context_line":""},{"line_number":97,"context_line":"    @abc.abstractmethod"},{"line_number":98,"context_line":"    def supports_extension(self):"},{"line_number":99,"context_line":"        \"\"\"Checks whether a neutron extension is supported.\"\"\""},{"line_number":100,"context_line":""},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"class NovaNetworkWrapper(NetworkWrapper):"}],"source_content_type":"text/x-python","patch_set":17,"id":"ba3cc151_d8b035e0","line":99,"in_reply_to":"ba3cc151_5fe88e7c","updated":"2015-06-30 10:25:05.000000000","message":"Done","commit_id":"e0ee44979e833f6e37c570e478cdd0e3682a3755"},{"author":{"_account_id":8576,"name":"Yair Fried","email":"yfried@redhat.com","username":"yfried"},"change_message_id":"0cc943c4537f2432f91eace1dfbd82783500e1e8","unresolved":false,"context_lines":[{"line_number":188,"context_line":"        if use_ext:"},{"line_number":189,"context_line":"            return True, \"\""},{"line_number":190,"context_line":""},{"line_number":191,"context_line":"        return False, _(\"neutron driver does not support %s\") % (extension)"},{"line_number":192,"context_line":""},{"line_number":193,"context_line":""},{"line_number":194,"context_line":"class NeutronWrapper(NetworkWrapper):"}],"source_content_type":"text/x-python","patch_set":17,"id":"ba3cc151_5fb64e8b","line":191,"updated":"2015-06-30 08:38:42.000000000","message":"s/neutron/Nova","commit_id":"e0ee44979e833f6e37c570e478cdd0e3682a3755"},{"author":{"_account_id":14884,"name":"Kiran Ranganath","email":"kiran7193@gmail.com","username":"kiran"},"change_message_id":"203a95d24fd04877f6048da2dfb305b721b65a8b","unresolved":false,"context_lines":[{"line_number":188,"context_line":"        if use_ext:"},{"line_number":189,"context_line":"            return True, \"\""},{"line_number":190,"context_line":""},{"line_number":191,"context_line":"        return False, _(\"neutron driver does not support %s\") % (extension)"},{"line_number":192,"context_line":""},{"line_number":193,"context_line":""},{"line_number":194,"context_line":"class NeutronWrapper(NetworkWrapper):"}],"source_content_type":"text/x-python","patch_set":17,"id":"ba3cc151_5b1e5f64","line":191,"in_reply_to":"ba3cc151_5fb64e8b","updated":"2015-06-30 10:25:05.000000000","message":"Done","commit_id":"e0ee44979e833f6e37c570e478cdd0e3682a3755"},{"author":{"_account_id":8576,"name":"Yair Fried","email":"yfried@redhat.com","username":"yfried"},"change_message_id":"0cc943c4537f2432f91eace1dfbd82783500e1e8","unresolved":false,"context_lines":[{"line_number":412,"context_line":"        if use_ext:"},{"line_number":413,"context_line":"            return True, \"\""},{"line_number":414,"context_line":""},{"line_number":415,"context_line":"        return False, _(\"neutron driver does not support %s\") % (extension)"},{"line_number":416,"context_line":""},{"line_number":417,"context_line":""},{"line_number":418,"context_line":"def wrap(clients, config\u003dNone):"}],"source_content_type":"text/x-python","patch_set":17,"id":"ba3cc151_1a69b4be","line":415,"updated":"2015-06-30 08:38:42.000000000","message":"AFAIK, this should be:  \n\n  _(\"neutron driver does not support %s\" % extension)","commit_id":"e0ee44979e833f6e37c570e478cdd0e3682a3755"},{"author":{"_account_id":14884,"name":"Kiran Ranganath","email":"kiran7193@gmail.com","username":"kiran"},"change_message_id":"203a95d24fd04877f6048da2dfb305b721b65a8b","unresolved":false,"context_lines":[{"line_number":412,"context_line":"        if use_ext:"},{"line_number":413,"context_line":"            return True, \"\""},{"line_number":414,"context_line":""},{"line_number":415,"context_line":"        return False, _(\"neutron driver does not support %s\") % (extension)"},{"line_number":416,"context_line":""},{"line_number":417,"context_line":""},{"line_number":418,"context_line":"def wrap(clients, config\u003dNone):"}],"source_content_type":"text/x-python","patch_set":17,"id":"ba3cc151_38936151","line":415,"in_reply_to":"ba3cc151_1a69b4be","updated":"2015-06-30 10:25:05.000000000","message":"http://paste.openstack.org/show/327896/","commit_id":"e0ee44979e833f6e37c570e478cdd0e3682a3755"},{"author":{"_account_id":8576,"name":"Yair Fried","email":"yfried@redhat.com","username":"yfried"},"change_message_id":"18f0e621e0b717c928e31bf65a21faa5e6fa7a55","unresolved":false,"context_lines":[{"line_number":412,"context_line":"        if use_ext:"},{"line_number":413,"context_line":"            return True, \"\""},{"line_number":414,"context_line":""},{"line_number":415,"context_line":"        return False, _(\"neutron driver does not support %s\") % (extension)"},{"line_number":416,"context_line":""},{"line_number":417,"context_line":""},{"line_number":418,"context_line":"def wrap(clients, config\u003dNone):"}],"source_content_type":"text/x-python","patch_set":19,"id":"ba3cc151_726d8097","line":415,"updated":"2015-06-30 11:25:43.000000000","message":"I stand corrected. :)","commit_id":"f93b9b904157317ac510e905d76d9d62b9424637"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"2ff78230f3ea000c0c2a6f95ddb29a8e345f8e31","unresolved":false,"context_lines":[{"line_number":408,"context_line":"        :rtype: (bool, string)"},{"line_number":409,"context_line":"        \"\"\""},{"line_number":410,"context_line":"        extensions \u003d self.client.list_extensions().get(\"extensions\", [])"},{"line_number":411,"context_line":"        use_ext \u003d any(ext.get(\"alias\") \u003d\u003d extension for ext in extensions)"},{"line_number":412,"context_line":"        if use_ext:"},{"line_number":413,"context_line":"            return True, \"\""},{"line_number":414,"context_line":""}],"source_content_type":"text/x-python","patch_set":20,"id":"ba3cc151_7623e6a7","line":411,"updated":"2015-07-01 16:21:49.000000000","message":"You can get rig of variable `use_ext\u0027:\n\n if any(ext.get(\"alias\") \u003d\u003d extension for ext in extensions):\n     return ...","commit_id":"e91ccbc52744d92108336a9dbae447b8ec7f0bde"},{"author":{"_account_id":14884,"name":"Kiran Ranganath","email":"kiran7193@gmail.com","username":"kiran"},"change_message_id":"e6eca47027dffdb9345780342693088b25ae05c2","unresolved":false,"context_lines":[{"line_number":408,"context_line":"        :rtype: (bool, string)"},{"line_number":409,"context_line":"        \"\"\""},{"line_number":410,"context_line":"        extensions \u003d self.client.list_extensions().get(\"extensions\", [])"},{"line_number":411,"context_line":"        use_ext \u003d any(ext.get(\"alias\") \u003d\u003d extension for ext in extensions)"},{"line_number":412,"context_line":"        if use_ext:"},{"line_number":413,"context_line":"            return True, \"\""},{"line_number":414,"context_line":""}],"source_content_type":"text/x-python","patch_set":20,"id":"ba3cc151_919794eb","line":411,"in_reply_to":"ba3cc151_7623e6a7","updated":"2015-07-01 16:49:33.000000000","message":"Done","commit_id":"e91ccbc52744d92108336a9dbae447b8ec7f0bde"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"953dd1657bb7a7491cdb9f3e4009f6150ffaa7b2","unresolved":false,"context_lines":[{"line_number":309,"context_line":"    def delete_v1_pool(self, pool_id):"},{"line_number":310,"context_line":"        \"\"\"Delete LB Pool (v1)"},{"line_number":311,"context_line":""},{"line_number":312,"context_line":"        :param pool_id: str, Lb-Pool-id"},{"line_number":313,"context_line":"        \"\"\""},{"line_number":314,"context_line":"        return self.client.delete_pool(pool_id)"},{"line_number":315,"context_line":""}],"source_content_type":"text/x-python","patch_set":23,"id":"ba3cc151_1d09e4dd","line":312,"updated":"2015-07-04 11:15:46.000000000","message":"Please document return value","commit_id":"ed06e7bb9fd226ad751f40869d37fe166e760af0"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"0bba8592aed7363454f5a3f7db5bc0d026d4aaf4","unresolved":false,"context_lines":[{"line_number":183,"context_line":"        \"\"\""},{"line_number":184,"context_line":"        if extension \u003d\u003d \"security-group\":"},{"line_number":185,"context_line":"            return True, \"\""},{"line_number":186,"context_line":"        extensions \u003d self.client.list_extensions().get(\"extensions\", [])"},{"line_number":187,"context_line":"        if any(ext.get(\"alias\") \u003d\u003d extension for ext in extensions):"},{"line_number":188,"context_line":"            return True, \"\""},{"line_number":189,"context_line":""}],"source_content_type":"text/x-python","patch_set":25,"id":"ba3cc151_51e4acde","line":186,"updated":"2015-07-08 11:24:29.000000000","message":"AttributeError: \u0027Client\u0027 object has no attribute \u0027list_extensions\u0027\n\nhttp://paste.openstack.org/show/354986/","commit_id":"fd695ffb07bd56632bc6b5053ed1b645dbc2e958"},{"author":{"_account_id":14884,"name":"Kiran Ranganath","email":"kiran7193@gmail.com","username":"kiran"},"change_message_id":"cd55d533a52efbb48b41fe6b455d8a048a37901d","unresolved":false,"context_lines":[{"line_number":183,"context_line":"        \"\"\""},{"line_number":184,"context_line":"        if extension \u003d\u003d \"security-group\":"},{"line_number":185,"context_line":"            return True, \"\""},{"line_number":186,"context_line":"        extensions \u003d self.client.list_extensions().get(\"extensions\", [])"},{"line_number":187,"context_line":"        if any(ext.get(\"alias\") \u003d\u003d extension for ext in extensions):"},{"line_number":188,"context_line":"            return True, \"\""},{"line_number":189,"context_line":""}],"source_content_type":"text/x-python","patch_set":25,"id":"ba3cc151_ac84be0a","line":186,"in_reply_to":"ba3cc151_51e4acde","updated":"2015-07-08 12:21:33.000000000","message":"Alex, I believe something is wrong in your OpenStack. I tried the same task which succeeded in mine. I guess \"neutron ext-list\" command is not working in your setup.\n\nhttp://paste.openstack.org/show/355155/\n\nAlso, the dependent patch \"create_and_list_vips\" succeeded. \n\nhttp://logs.openstack.org/27/193527/20/check/gate-rally-dsvm-neutron-rally/8ed429d/rally-plot/results.html.gz#/NeutronLoadbalancerV1.create_and_list_vips/overview","commit_id":"fd695ffb07bd56632bc6b5053ed1b645dbc2e958"},{"author":{"_account_id":14884,"name":"Kiran Ranganath","email":"kiran7193@gmail.com","username":"kiran"},"change_message_id":"08cb8d850b4ee14fcf6c9de57722dabc2f2c1b67","unresolved":false,"context_lines":[{"line_number":183,"context_line":"        \"\"\""},{"line_number":184,"context_line":"        if extension \u003d\u003d \"security-group\":"},{"line_number":185,"context_line":"            return True, \"\""},{"line_number":186,"context_line":"        extensions \u003d self.client.list_extensions().get(\"extensions\", [])"},{"line_number":187,"context_line":"        if any(ext.get(\"alias\") \u003d\u003d extension for ext in extensions):"},{"line_number":188,"context_line":"            return True, \"\""},{"line_number":189,"context_line":""}],"source_content_type":"text/x-python","patch_set":25,"id":"ba3cc151_b3cbaba3","line":186,"in_reply_to":"ba3cc151_ac403760","updated":"2015-07-08 16:03:44.000000000","message":"Wonderful catch (trying with Nova-network) :)\nI apologize for my ignorance in my previous comment.\n\nPlease see if this would work.\nhttp://paste.openstack.org/show/355659/","commit_id":"fd695ffb07bd56632bc6b5053ed1b645dbc2e958"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"600fd2dcc50f5341f490d7c4fc1104a6bb7d2ec4","unresolved":false,"context_lines":[{"line_number":183,"context_line":"        \"\"\""},{"line_number":184,"context_line":"        if extension \u003d\u003d \"security-group\":"},{"line_number":185,"context_line":"            return True, \"\""},{"line_number":186,"context_line":"        extensions \u003d self.client.list_extensions().get(\"extensions\", [])"},{"line_number":187,"context_line":"        if any(ext.get(\"alias\") \u003d\u003d extension for ext in extensions):"},{"line_number":188,"context_line":"            return True, \"\""},{"line_number":189,"context_line":""}],"source_content_type":"text/x-python","patch_set":25,"id":"ba3cc151_ac403760","line":186,"in_reply_to":"ba3cc151_ac84be0a","updated":"2015-07-08 14:11:48.000000000","message":"My cloud is OK, but there is no Neutron component in my cloud - it uses nova-network, so your method failed for nova-network component (except check for \"security-group\" extension which is always True)","commit_id":"fd695ffb07bd56632bc6b5053ed1b645dbc2e958"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"0bba8592aed7363454f5a3f7db5bc0d026d4aaf4","unresolved":false,"context_lines":[{"line_number":410,"context_line":"        if any(ext.get(\"alias\") \u003d\u003d extension for ext in extensions):"},{"line_number":411,"context_line":"            return True, \"\""},{"line_number":412,"context_line":""},{"line_number":413,"context_line":"        return False, _(\"neutron driver does not support %s\") % (extension)"},{"line_number":414,"context_line":""},{"line_number":415,"context_line":""},{"line_number":416,"context_line":"def wrap(clients, config\u003dNone):"}],"source_content_type":"text/x-python","patch_set":25,"id":"ba3cc151_fcb3574b","line":413,"updated":"2015-07-08 11:24:29.000000000","message":"s/neutron/Neutron/\n\nThat is because:\n\n * message usually starts with capital letter\n * we have capitalized message in NovaNetworkWrapper.supports_extension()","commit_id":"fd695ffb07bd56632bc6b5053ed1b645dbc2e958"},{"author":{"_account_id":14884,"name":"Kiran Ranganath","email":"kiran7193@gmail.com","username":"kiran"},"change_message_id":"c34ea75126c9c1088878296eaf9f0d218acef997","unresolved":false,"context_lines":[{"line_number":410,"context_line":"        if any(ext.get(\"alias\") \u003d\u003d extension for ext in extensions):"},{"line_number":411,"context_line":"            return True, \"\""},{"line_number":412,"context_line":""},{"line_number":413,"context_line":"        return False, _(\"neutron driver does not support %s\") % (extension)"},{"line_number":414,"context_line":""},{"line_number":415,"context_line":""},{"line_number":416,"context_line":"def wrap(clients, config\u003dNone):"}],"source_content_type":"text/x-python","patch_set":25,"id":"ba3cc151_ccb7c2d6","line":413,"in_reply_to":"ba3cc151_fcb3574b","updated":"2015-07-08 12:33:16.000000000","message":"Done","commit_id":"fd695ffb07bd56632bc6b5053ed1b645dbc2e958"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"1ae44067e6fd0b578c45c29959dd7d48023d7896","unresolved":false,"context_lines":[{"line_number":178,"context_line":"        \"\"\"Check whether a Nova-network extension is supported"},{"line_number":179,"context_line":""},{"line_number":180,"context_line":"        :param extension: str Nova network extension"},{"line_number":181,"context_line":"        :return: result tuple. Always (True, \"\") for secgroups in nova-network."},{"line_number":182,"context_line":"        :rtype: (bool, string)"},{"line_number":183,"context_line":"        \"\"\""},{"line_number":184,"context_line":"        # TODO(rkiran): Add other extensions whenever necessary"}],"source_content_type":"text/x-python","patch_set":35,"id":"3a50d1a3_34fb0b7b","line":181,"updated":"2015-07-22 11:00:53.000000000","message":"s/:return:/:returns:/","commit_id":"3f498ebceb5a962b6738bc10c571d72e2687e1b6"},{"author":{"_account_id":14884,"name":"Kiran Ranganath","email":"kiran7193@gmail.com","username":"kiran"},"change_message_id":"53203f0d4f7ee43db0428dba7f54cbb3402b74e1","unresolved":false,"context_lines":[{"line_number":178,"context_line":"        \"\"\"Check whether a Nova-network extension is supported"},{"line_number":179,"context_line":""},{"line_number":180,"context_line":"        :param extension: str Nova network extension"},{"line_number":181,"context_line":"        :return: result tuple. Always (True, \"\") for secgroups in nova-network."},{"line_number":182,"context_line":"        :rtype: (bool, string)"},{"line_number":183,"context_line":"        \"\"\""},{"line_number":184,"context_line":"        # TODO(rkiran): Add other extensions whenever necessary"}],"source_content_type":"text/x-python","patch_set":35,"id":"3a50d1a3_4f95e43c","line":181,"in_reply_to":"3a50d1a3_34fb0b7b","updated":"2015-07-22 11:21:24.000000000","message":"Done","commit_id":"3f498ebceb5a962b6738bc10c571d72e2687e1b6"}],"tests/unit/plugins/openstack/context/test_lbaas_v1.py":[{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"daf25adfef8560ff0064a92c3b0d437dcc1602eb","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2014: Mirantis Inc."},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":12,"id":"fa32b979_419f7365","line":1,"updated":"2015-06-26 10:37:42.000000000","message":"Are you from Mirantis? ;)\n\nYou can just remove this line, it is not required","commit_id":"b5af2567f6e752319ad01a483ce819a45e54dd1c"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"2ff78230f3ea000c0c2a6f95ddb29a8e345f8e31","unresolved":false,"context_lines":[{"line_number":108,"context_line":"    def test_cleanup(self, mock_wrap, mock_clients):"},{"line_number":109,"context_line":"        net_context \u003d lbaas_v1_context.LbaasV1(self.get_context())"},{"line_number":110,"context_line":"        net_context.cleanup()"},{"line_number":111,"context_line":"        mock_wrap().delete_pool.called_once_with("},{"line_number":112,"context_line":"            [mock.call({\"pool\": {\"id\": \"foo_pool\"}}),"},{"line_number":113,"context_line":"                mock.call({\"pool\": {\"id\": \"bar_pool\"}})],"},{"line_number":114,"context_line":"            any_order\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":20,"id":"ba3cc151_d6b75238","line":111,"updated":"2015-07-01 16:21:49.000000000","message":"In this method you should check calls of `delete_v1_pool\u0027 only","commit_id":"e91ccbc52744d92108336a9dbae447b8ec7f0bde"},{"author":{"_account_id":14884,"name":"Kiran Ranganath","email":"kiran7193@gmail.com","username":"kiran"},"change_message_id":"e6eca47027dffdb9345780342693088b25ae05c2","unresolved":false,"context_lines":[{"line_number":108,"context_line":"    def test_cleanup(self, mock_wrap, mock_clients):"},{"line_number":109,"context_line":"        net_context \u003d lbaas_v1_context.LbaasV1(self.get_context())"},{"line_number":110,"context_line":"        net_context.cleanup()"},{"line_number":111,"context_line":"        mock_wrap().delete_pool.called_once_with("},{"line_number":112,"context_line":"            [mock.call({\"pool\": {\"id\": \"foo_pool\"}}),"},{"line_number":113,"context_line":"                mock.call({\"pool\": {\"id\": \"bar_pool\"}})],"},{"line_number":114,"context_line":"            any_order\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":20,"id":"ba3cc151_167a9abd","line":111,"in_reply_to":"ba3cc151_d6b75238","updated":"2015-07-01 16:49:33.000000000","message":"Done","commit_id":"e91ccbc52744d92108336a9dbae447b8ec7f0bde"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"3627d0304c7dbe4a388ad301753a32f1395d4ce0","unresolved":false,"context_lines":[{"line_number":25,"context_line":"            \"admin\": {\"endpoint\": \"foo_admin\"},"},{"line_number":26,"context_line":"            \"config\": {\"lbaas_v1\": kwargs},"},{"line_number":27,"context_line":"            \"tenants\":"},{"line_number":28,"context_line":"            {"},{"line_number":29,"context_line":"                \"foo_tenant\":"},{"line_number":30,"context_line":"                {"},{"line_number":31,"context_line":"                    \"networks\":"}],"source_content_type":"text/x-python","patch_set":23,"id":"ba3cc151_25918347","line":28,"updated":"2015-07-02 09:49:22.000000000","message":"Something seems wrong with indentation","commit_id":"ed06e7bb9fd226ad751f40869d37fe166e760af0"},{"author":{"_account_id":14884,"name":"Kiran Ranganath","email":"kiran7193@gmail.com","username":"kiran"},"change_message_id":"1aaafac2967257ec9992cf31bd2ae3fbc8839b86","unresolved":false,"context_lines":[{"line_number":25,"context_line":"            \"admin\": {\"endpoint\": \"foo_admin\"},"},{"line_number":26,"context_line":"            \"config\": {\"lbaas_v1\": kwargs},"},{"line_number":27,"context_line":"            \"tenants\":"},{"line_number":28,"context_line":"            {"},{"line_number":29,"context_line":"                \"foo_tenant\":"},{"line_number":30,"context_line":"                {"},{"line_number":31,"context_line":"                    \"networks\":"}],"source_content_type":"text/x-python","patch_set":23,"id":"ba3cc151_18e919b7","line":28,"in_reply_to":"ba3cc151_25918347","updated":"2015-07-03 03:54:57.000000000","message":"Done","commit_id":"ed06e7bb9fd226ad751f40869d37fe166e760af0"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"3627d0304c7dbe4a388ad301753a32f1395d4ce0","unresolved":false,"context_lines":[{"line_number":32,"context_line":"                    [{"},{"line_number":33,"context_line":"                        \"id\": \"foo_net\","},{"line_number":34,"context_line":"                        \"subnet\": [\"foo_subnet\"],"},{"line_number":35,"context_line":"                        \"lb_pools\": ["},{"line_number":36,"context_line":"                            {"},{"line_number":37,"context_line":"                                \"pool\": {"},{"line_number":38,"context_line":"                                    \"id\": \"foo_pool\"}}]}]},"}],"source_content_type":"text/x-python","patch_set":23,"id":"ba3cc151_458fe729","line":35,"updated":"2015-07-02 09:49:22.000000000","message":"\"lb_pools\" is a result data, it should be absent here","commit_id":"ed06e7bb9fd226ad751f40869d37fe166e760af0"},{"author":{"_account_id":14884,"name":"Kiran Ranganath","email":"kiran7193@gmail.com","username":"kiran"},"change_message_id":"1aaafac2967257ec9992cf31bd2ae3fbc8839b86","unresolved":false,"context_lines":[{"line_number":32,"context_line":"                    [{"},{"line_number":33,"context_line":"                        \"id\": \"foo_net\","},{"line_number":34,"context_line":"                        \"subnet\": [\"foo_subnet\"],"},{"line_number":35,"context_line":"                        \"lb_pools\": ["},{"line_number":36,"context_line":"                            {"},{"line_number":37,"context_line":"                                \"pool\": {"},{"line_number":38,"context_line":"                                    \"id\": \"foo_pool\"}}]}]},"}],"source_content_type":"text/x-python","patch_set":23,"id":"ba3cc151_b8d4adeb","line":35,"in_reply_to":"ba3cc151_458fe729","updated":"2015-07-03 03:54:57.000000000","message":"Done","commit_id":"ed06e7bb9fd226ad751f40869d37fe166e760af0"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"3627d0304c7dbe4a388ad301753a32f1395d4ce0","unresolved":false,"context_lines":[{"line_number":68,"context_line":"        mock_utils.iterate_per_tenants.return_value \u003d ["},{"line_number":69,"context_line":"            (\"bar_user\", \"bar_tenant\")]"},{"line_number":70,"context_line":"        mock_create \u003d mock.Mock(side_effect\u003dlambda t, **kw: t + \"-net\")"},{"line_number":71,"context_line":"        mock_wrap.return_value \u003d mock.Mock(create_network\u003dmock_create)"},{"line_number":72,"context_line":"        net_context \u003d lbaas_v1_context.LbaasV1("},{"line_number":73,"context_line":"            self.get_context())"},{"line_number":74,"context_line":"        net_context.net_wrapper.supports_extension.return_value \u003d (True, None)"}],"source_content_type":"text/x-python","patch_set":23,"id":"ba3cc151_e555dbc1","line":71,"updated":"2015-07-02 09:49:22.000000000","message":"Does lbaas_v1 context create networks?\n\nYou should check create_v1_pool() calls instead","commit_id":"ed06e7bb9fd226ad751f40869d37fe166e760af0"},{"author":{"_account_id":14884,"name":"Kiran Ranganath","email":"kiran7193@gmail.com","username":"kiran"},"change_message_id":"1aaafac2967257ec9992cf31bd2ae3fbc8839b86","unresolved":false,"context_lines":[{"line_number":68,"context_line":"        mock_utils.iterate_per_tenants.return_value \u003d ["},{"line_number":69,"context_line":"            (\"bar_user\", \"bar_tenant\")]"},{"line_number":70,"context_line":"        mock_create \u003d mock.Mock(side_effect\u003dlambda t, **kw: t + \"-net\")"},{"line_number":71,"context_line":"        mock_wrap.return_value \u003d mock.Mock(create_network\u003dmock_create)"},{"line_number":72,"context_line":"        net_context \u003d lbaas_v1_context.LbaasV1("},{"line_number":73,"context_line":"            self.get_context())"},{"line_number":74,"context_line":"        net_context.net_wrapper.supports_extension.return_value \u003d (True, None)"}],"source_content_type":"text/x-python","patch_set":23,"id":"ba3cc151_98d529e6","line":71,"in_reply_to":"ba3cc151_e555dbc1","updated":"2015-07-03 03:54:57.000000000","message":"Done","commit_id":"ed06e7bb9fd226ad751f40869d37fe166e760af0"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"3627d0304c7dbe4a388ad301753a32f1395d4ce0","unresolved":false,"context_lines":[{"line_number":95,"context_line":"        mock_utils.iterate_per_tenants.return_value \u003d ["},{"line_number":96,"context_line":"            (\"bar_user\", \"bar_tenant\")]"},{"line_number":97,"context_line":"        mock_create \u003d mock.Mock(side_effect\u003dlambda t, **kw: t + \"-net\")"},{"line_number":98,"context_line":"        mock_wrap.return_value \u003d mock.Mock(create_network\u003dmock_create)"},{"line_number":99,"context_line":"        net_context \u003d lbaas_v1_context.LbaasV1("},{"line_number":100,"context_line":"            self.get_context())"},{"line_number":101,"context_line":"        net_context.net_wrapper.supports_extension.return_value \u003d (False, None)"}],"source_content_type":"text/x-python","patch_set":23,"id":"ba3cc151_855def16","line":98,"updated":"2015-07-02 09:49:22.000000000","message":"mock for create_network() is not required here at all - the only important check is create_v1_pool() calls","commit_id":"ed06e7bb9fd226ad751f40869d37fe166e760af0"},{"author":{"_account_id":14884,"name":"Kiran Ranganath","email":"kiran7193@gmail.com","username":"kiran"},"change_message_id":"1aaafac2967257ec9992cf31bd2ae3fbc8839b86","unresolved":false,"context_lines":[{"line_number":95,"context_line":"        mock_utils.iterate_per_tenants.return_value \u003d ["},{"line_number":96,"context_line":"            (\"bar_user\", \"bar_tenant\")]"},{"line_number":97,"context_line":"        mock_create \u003d mock.Mock(side_effect\u003dlambda t, **kw: t + \"-net\")"},{"line_number":98,"context_line":"        mock_wrap.return_value \u003d mock.Mock(create_network\u003dmock_create)"},{"line_number":99,"context_line":"        net_context \u003d lbaas_v1_context.LbaasV1("},{"line_number":100,"context_line":"            self.get_context())"},{"line_number":101,"context_line":"        net_context.net_wrapper.supports_extension.return_value \u003d (False, None)"}],"source_content_type":"text/x-python","patch_set":23,"id":"ba3cc151_38073d83","line":98,"in_reply_to":"ba3cc151_855def16","updated":"2015-07-03 03:54:57.000000000","message":"Done","commit_id":"ed06e7bb9fd226ad751f40869d37fe166e760af0"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"3627d0304c7dbe4a388ad301753a32f1395d4ce0","unresolved":false,"context_lines":[{"line_number":97,"context_line":"        mock_create \u003d mock.Mock(side_effect\u003dlambda t, **kw: t + \"-net\")"},{"line_number":98,"context_line":"        mock_wrap.return_value \u003d mock.Mock(create_network\u003dmock_create)"},{"line_number":99,"context_line":"        net_context \u003d lbaas_v1_context.LbaasV1("},{"line_number":100,"context_line":"            self.get_context())"},{"line_number":101,"context_line":"        net_context.net_wrapper.supports_extension.return_value \u003d (False, None)"},{"line_number":102,"context_line":"        net_context.setup()"},{"line_number":103,"context_line":"        net_context.net_wrapper.supports_extension.assert_called_once_with("}],"source_content_type":"text/x-python","patch_set":23,"id":"ba3cc151_b3795cca","line":100,"updated":"2015-07-02 09:49:22.000000000","message":"Why this is separate line?\n\nThis line is only 66 characters long (incl. 8 leading spaces):\n    net_context \u003d baas_v1_context.LbaasV1(self.get_context())","commit_id":"ed06e7bb9fd226ad751f40869d37fe166e760af0"},{"author":{"_account_id":14884,"name":"Kiran Ranganath","email":"kiran7193@gmail.com","username":"kiran"},"change_message_id":"1aaafac2967257ec9992cf31bd2ae3fbc8839b86","unresolved":false,"context_lines":[{"line_number":97,"context_line":"        mock_create \u003d mock.Mock(side_effect\u003dlambda t, **kw: t + \"-net\")"},{"line_number":98,"context_line":"        mock_wrap.return_value \u003d mock.Mock(create_network\u003dmock_create)"},{"line_number":99,"context_line":"        net_context \u003d lbaas_v1_context.LbaasV1("},{"line_number":100,"context_line":"            self.get_context())"},{"line_number":101,"context_line":"        net_context.net_wrapper.supports_extension.return_value \u003d (False, None)"},{"line_number":102,"context_line":"        net_context.setup()"},{"line_number":103,"context_line":"        net_context.net_wrapper.supports_extension.assert_called_once_with("}],"source_content_type":"text/x-python","patch_set":23,"id":"ba3cc151_18003965","line":100,"in_reply_to":"ba3cc151_b3795cca","updated":"2015-07-03 03:54:57.000000000","message":"Done","commit_id":"ed06e7bb9fd226ad751f40869d37fe166e760af0"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"3627d0304c7dbe4a388ad301753a32f1395d4ce0","unresolved":false,"context_lines":[{"line_number":102,"context_line":"        net_context.setup()"},{"line_number":103,"context_line":"        net_context.net_wrapper.supports_extension.assert_called_once_with("},{"line_number":104,"context_line":"            \"lbaas\")"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"    @mock.patch(\"rally.osclients.Clients\")"},{"line_number":107,"context_line":"    @mock.patch(NET + \"wrap\")"},{"line_number":108,"context_line":"    def test_cleanup(self, mock_wrap, mock_clients):"}],"source_content_type":"text/x-python","patch_set":23,"id":"ba3cc151_c539b7d8","line":105,"updated":"2015-07-02 09:49:22.000000000","message":"So, we have supports_extension() returning False, now we have to prove that pools are not created by setup()\n\nYou should check that create_v1_pool() has no calls - this check is missed here","commit_id":"ed06e7bb9fd226ad751f40869d37fe166e760af0"},{"author":{"_account_id":14884,"name":"Kiran Ranganath","email":"kiran7193@gmail.com","username":"kiran"},"change_message_id":"1aaafac2967257ec9992cf31bd2ae3fbc8839b86","unresolved":false,"context_lines":[{"line_number":102,"context_line":"        net_context.setup()"},{"line_number":103,"context_line":"        net_context.net_wrapper.supports_extension.assert_called_once_with("},{"line_number":104,"context_line":"            \"lbaas\")"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"    @mock.patch(\"rally.osclients.Clients\")"},{"line_number":107,"context_line":"    @mock.patch(NET + \"wrap\")"},{"line_number":108,"context_line":"    def test_cleanup(self, mock_wrap, mock_clients):"}],"source_content_type":"text/x-python","patch_set":23,"id":"ba3cc151_d8f6518e","line":105,"in_reply_to":"ba3cc151_c539b7d8","updated":"2015-07-03 03:54:57.000000000","message":"Done","commit_id":"ed06e7bb9fd226ad751f40869d37fe166e760af0"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"d00a52cbdb49bf2111fa33f8e692e25c56cb7cd5","unresolved":false,"context_lines":[{"line_number":110,"context_line":"                   \"subnets\": [\"subnet-id\"]}"},{"line_number":111,"context_line":"        net_context.cleanup()"},{"line_number":112,"context_line":"        for pool in network.get(\"lb_pools\", []):"},{"line_number":113,"context_line":"            mock_wrap.net_wrapper.delete_v1_pool(pool[\"pool\"][\"id\"])"},{"line_number":114,"context_line":"        net_context.net_wrapper.delete_v1_pool.called_once_with(pool[\"pool\"][\"id\"])"}],"source_content_type":"text/x-python","patch_set":24,"id":"ba3cc151_870c7343","line":113,"range":{"start_line":113,"start_character":12,"end_line":113,"end_character":68},"updated":"2015-07-07 10:49:42.000000000","message":"This should not be called in test! This is something that you should check that has been called in tested code!\n\nSo, remove L112-113 and check `net_context.net_wrapper.delete_v1_pool.mock_calls\u0027","commit_id":"1a01ce8b495ed07851b6d1e25e5ba52de0be4905"},{"author":{"_account_id":6835,"name":"Kun Huang","email":"gareth@openstacker.org","username":"academicgareth"},"change_message_id":"e011d7e633d452ce593f259a909b09ae2df95890","unresolved":false,"context_lines":[{"line_number":110,"context_line":"    def test_cleanup(self, mock_wrap, mock_clients):"},{"line_number":111,"context_line":"        net_context \u003d lbaas_v1_context.LbaasV1(self.get_context())"},{"line_number":112,"context_line":"        expected_pools \u003d []"},{"line_number":113,"context_line":"        for tenant_id, tenant_ctx in sorted("},{"line_number":114,"context_line":"                net_context.context[\"tenants\"].items()):"},{"line_number":115,"context_line":"            resultant_pool \u003d {\"pool\": {"},{"line_number":116,"context_line":"                \"id\": str(tenant_id.split(\"_\")[0]) + \"_pool\"}}"}],"source_content_type":"text/x-python","patch_set":25,"id":"ba3cc151_2d38baed","line":113,"updated":"2015-07-08 06:43:13.000000000","message":"why sort here?","commit_id":"fd695ffb07bd56632bc6b5053ed1b645dbc2e958"},{"author":{"_account_id":14884,"name":"Kiran Ranganath","email":"kiran7193@gmail.com","username":"kiran"},"change_message_id":"08cb8d850b4ee14fcf6c9de57722dabc2f2c1b67","unresolved":false,"context_lines":[{"line_number":110,"context_line":"    def test_cleanup(self, mock_wrap, mock_clients):"},{"line_number":111,"context_line":"        net_context \u003d lbaas_v1_context.LbaasV1(self.get_context())"},{"line_number":112,"context_line":"        expected_pools \u003d []"},{"line_number":113,"context_line":"        for tenant_id, tenant_ctx in sorted("},{"line_number":114,"context_line":"                net_context.context[\"tenants\"].items()):"},{"line_number":115,"context_line":"            resultant_pool \u003d {\"pool\": {"},{"line_number":116,"context_line":"                \"id\": str(tenant_id.split(\"_\")[0]) + \"_pool\"}}"}],"source_content_type":"text/x-python","patch_set":25,"id":"ba3cc151_e1b160e1","line":113,"in_reply_to":"ba3cc151_0fcd9530","updated":"2015-07-08 16:03:44.000000000","message":"Done","commit_id":"fd695ffb07bd56632bc6b5053ed1b645dbc2e958"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"46fbac9eb531d88121ef3dba8d02d0d4712c0119","unresolved":false,"context_lines":[{"line_number":110,"context_line":"    def test_cleanup(self, mock_wrap, mock_clients):"},{"line_number":111,"context_line":"        net_context \u003d lbaas_v1_context.LbaasV1(self.get_context())"},{"line_number":112,"context_line":"        expected_pools \u003d []"},{"line_number":113,"context_line":"        for tenant_id, tenant_ctx in sorted("},{"line_number":114,"context_line":"                net_context.context[\"tenants\"].items()):"},{"line_number":115,"context_line":"            resultant_pool \u003d {\"pool\": {"},{"line_number":116,"context_line":"                \"id\": str(tenant_id.split(\"_\")[0]) + \"_pool\"}}"}],"source_content_type":"text/x-python","patch_set":25,"id":"ba3cc151_0fcd9530","line":113,"in_reply_to":"ba3cc151_2d38baed","updated":"2015-07-08 14:26:53.000000000","message":"Agreed, `sorted\u0027 looks absolutely unnecessary","commit_id":"fd695ffb07bd56632bc6b5053ed1b645dbc2e958"},{"author":{"_account_id":6835,"name":"Kun Huang","email":"gareth@openstacker.org","username":"academicgareth"},"change_message_id":"e011d7e633d452ce593f259a909b09ae2df95890","unresolved":false,"context_lines":[{"line_number":112,"context_line":"        expected_pools \u003d []"},{"line_number":113,"context_line":"        for tenant_id, tenant_ctx in sorted("},{"line_number":114,"context_line":"                net_context.context[\"tenants\"].items()):"},{"line_number":115,"context_line":"            resultant_pool \u003d {\"pool\": {"},{"line_number":116,"context_line":"                \"id\": str(tenant_id.split(\"_\")[0]) + \"_pool\"}}"},{"line_number":117,"context_line":"            expected_pools.append(resultant_pool)"},{"line_number":118,"context_line":"            for network in ("}],"source_content_type":"text/x-python","patch_set":25,"id":"ba3cc151_d05c411b","line":115,"updated":"2015-07-08 06:43:13.000000000","message":"ret_pool or retsult_pool is more popular in my mind, please watch others\u0027 view here","commit_id":"fd695ffb07bd56632bc6b5053ed1b645dbc2e958"}],"tests/unit/plugins/openstack/wrappers/test_network.py":[{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"3627d0304c7dbe4a388ad301753a32f1395d4ce0","unresolved":false,"context_lines":[{"line_number":378,"context_line":"    def test_delete_v1_pool(self):"},{"line_number":379,"context_line":"        service \u003d self.get_wrapper()"},{"line_number":380,"context_line":"        pool \u003d {\"pool\": {\"id\": \"pool-id\"}}"},{"line_number":381,"context_line":"        service.client.delete_pool.return_value \u003d ()"},{"line_number":382,"context_line":"        service.delete_v1_pool(pool[\"pool\"][\"id\"])"},{"line_number":383,"context_line":"        service.client.delete_pool.called_once_with([mock.call(\"pool-id\")])"},{"line_number":384,"context_line":""}],"source_content_type":"text/x-python","patch_set":23,"id":"ba3cc151_458047c0","line":381,"updated":"2015-07-02 09:49:22.000000000","message":"This line looks unnecessary","commit_id":"ed06e7bb9fd226ad751f40869d37fe166e760af0"},{"author":{"_account_id":14884,"name":"Kiran Ranganath","email":"kiran7193@gmail.com","username":"kiran"},"change_message_id":"1aaafac2967257ec9992cf31bd2ae3fbc8839b86","unresolved":false,"context_lines":[{"line_number":378,"context_line":"    def test_delete_v1_pool(self):"},{"line_number":379,"context_line":"        service \u003d self.get_wrapper()"},{"line_number":380,"context_line":"        pool \u003d {\"pool\": {\"id\": \"pool-id\"}}"},{"line_number":381,"context_line":"        service.client.delete_pool.return_value \u003d ()"},{"line_number":382,"context_line":"        service.delete_v1_pool(pool[\"pool\"][\"id\"])"},{"line_number":383,"context_line":"        service.client.delete_pool.called_once_with([mock.call(\"pool-id\")])"},{"line_number":384,"context_line":""}],"source_content_type":"text/x-python","patch_set":23,"id":"ba3cc151_88018608","line":381,"in_reply_to":"ba3cc151_458047c0","updated":"2015-07-03 03:54:57.000000000","message":"Done","commit_id":"ed06e7bb9fd226ad751f40869d37fe166e760af0"}]}
