)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6835,"name":"Kun Huang","email":"gareth@openstacker.org","username":"academicgareth"},"change_message_id":"f39c16173315bab4c504aa013625c115167c7269","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Angus Lees \u003cgus@inodes.org\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-06-22 11:41:54 +1000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"OpenStack: support regions"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This change adds \"region\" to the provider options and uses it when"},{"line_number":10,"context_line":"creating nova servers."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"fa32b979_89de41d8","line":7,"updated":"2015-06-25 08:23:05.000000000","message":"The commit title is too simple to understand. At least, \"OpenStackProvider: support regions\"","commit_id":"d3835699c7c81fda0ebd1163c668575b0c244174"},{"author":{"_account_id":11279,"name":"Angus Lees","email":"gus@inodes.org","username":"gus"},"change_message_id":"b704ed545b7e8c325b4d7221d73362eb251b8755","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Angus Lees \u003cgus@inodes.org\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-06-22 11:41:54 +1000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"OpenStack: support regions"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This change adds \"region\" to the provider options and uses it when"},{"line_number":10,"context_line":"creating nova servers."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9a41bdd9_1d7ee769","line":7,"in_reply_to":"fa32b979_89de41d8","updated":"2015-07-16 05:32:18.000000000","message":"Yeah that is quite terrible :/\n\nImproved.","commit_id":"d3835699c7c81fda0ebd1163c668575b0c244174"}],"rally/deploy/serverprovider/providers/openstack.py":[{"author":{"_account_id":6835,"name":"Kun Huang","email":"gareth@openstacker.org","username":"academicgareth"},"change_message_id":"f39c16173315bab4c504aa013625c115167c7269","unresolved":false,"context_lines":[{"line_number":107,"context_line":"        super(OpenStackProvider, self).__init__(deployment, config)"},{"line_number":108,"context_line":"        user_endpoint \u003d objects.Endpoint(config[\"auth_url\"], config[\"user\"],"},{"line_number":109,"context_line":"                                         config[\"password\"], config[\"tenant\"],"},{"line_number":110,"context_line":"                                         region_name\u003dconfig.get(\"region\"))"},{"line_number":111,"context_line":"        clients \u003d osclients.Clients(user_endpoint)"},{"line_number":112,"context_line":"        self.nova \u003d clients.nova()"},{"line_number":113,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa32b979_cc10d750","line":110,"updated":"2015-06-25 08:23:05.000000000","message":"It\u0027s better to specify a default value for \u0027region\u0027. Devstack use \u0027RegionOne\u0027 by default, but keystone client use \u0027regionOne\u0027. Since Rally use Devstack to deploy OpenStack, this should make sense:\n\n    region_name\u003dconfig.get(\"region\", \"RegionOne\")","commit_id":"d3835699c7c81fda0ebd1163c668575b0c244174"},{"author":{"_account_id":11279,"name":"Angus Lees","email":"gus@inodes.org","username":"gus"},"change_message_id":"b704ed545b7e8c325b4d7221d73362eb251b8755","unresolved":false,"context_lines":[{"line_number":107,"context_line":"        super(OpenStackProvider, self).__init__(deployment, config)"},{"line_number":108,"context_line":"        user_endpoint \u003d objects.Endpoint(config[\"auth_url\"], config[\"user\"],"},{"line_number":109,"context_line":"                                         config[\"password\"], config[\"tenant\"],"},{"line_number":110,"context_line":"                                         region_name\u003dconfig.get(\"region\"))"},{"line_number":111,"context_line":"        clients \u003d osclients.Clients(user_endpoint)"},{"line_number":112,"context_line":"        self.nova \u003d clients.nova()"},{"line_number":113,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a41bdd9_1d0b4725","line":110,"in_reply_to":"fa32b979_cc10d750","updated":"2015-07-16 05:32:18.000000000","message":"I disagree.  Yes, a simple default devstack install will have region\u003dRegionOne but a non-devstack production cluster (or complex devstack setup) might install with multiple regions and quite likely none named \"RegionOne\".\n\nIn all these cases a default of region\u003dNone will do something sensible.  A default of region\u003dRegionOne will only work for the trivial devstack case.","commit_id":"d3835699c7c81fda0ebd1163c668575b0c244174"}]}
