)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"c2238ee54e242fac7f5908631ca460d4987cce1f","unresolved":false,"context_lines":[{"line_number":16,"context_line":"   server created (should use a string rather than a file handle in the"},{"line_number":17,"context_line":"   loop below)."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Since security bugs that allow reading arbitrary files from OpenStack"},{"line_number":20,"context_line":"servers are all the rage these days, this change removes the vestigial"},{"line_number":21,"context_line":"userdata_file code to prevent anyone being tempted to \"fix\" this feature"},{"line_number":22,"context_line":"and allow reads from arbitrary server-side paths in some distant future."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"3a50d1a3_e67acbf0","line":19,"updated":"2015-07-22 15:07:35.000000000","message":"Could you add Closes-bug?","commit_id":"27d7b25435ef275b027cc5848bf5d01f690574ba"},{"author":{"_account_id":11279,"name":"Angus Lees","email":"gus@inodes.org","username":"gus"},"change_message_id":"ef63437963a98fb6a01734b09ab1e90b27ff2f6e","unresolved":false,"context_lines":[{"line_number":16,"context_line":"   server created (should use a string rather than a file handle in the"},{"line_number":17,"context_line":"   loop below)."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Since security bugs that allow reading arbitrary files from OpenStack"},{"line_number":20,"context_line":"servers are all the rage these days, this change removes the vestigial"},{"line_number":21,"context_line":"userdata_file code to prevent anyone being tempted to \"fix\" this feature"},{"line_number":22,"context_line":"and allow reads from arbitrary server-side paths in some distant future."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"1a4dcd0f_7ed2965d","line":19,"in_reply_to":"3a50d1a3_b9a7ebbb","updated":"2015-08-13 00:31:54.000000000","message":"Since evidently this was enough to stall the review, I created a corresponding launchpad bug.","commit_id":"27d7b25435ef275b027cc5848bf5d01f690574ba"},{"author":{"_account_id":11279,"name":"Angus Lees","email":"gus@inodes.org","username":"gus"},"change_message_id":"3fb438cc22e1f475fc2f4cd99f2e13b0198c2ef9","unresolved":false,"context_lines":[{"line_number":16,"context_line":"   server created (should use a string rather than a file handle in the"},{"line_number":17,"context_line":"   loop below)."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Since security bugs that allow reading arbitrary files from OpenStack"},{"line_number":20,"context_line":"servers are all the rage these days, this change removes the vestigial"},{"line_number":21,"context_line":"userdata_file code to prevent anyone being tempted to \"fix\" this feature"},{"line_number":22,"context_line":"and allow reads from arbitrary server-side paths in some distant future."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"3a50d1a3_b9a7ebbb","line":19,"in_reply_to":"3a50d1a3_e67acbf0","updated":"2015-07-23 01:06:59.000000000","message":".. Except it isn\u0027t actually a bug (yet).  The \"userdata_file\" code that I\u0027m deleting here isn\u0027t reachable because of (A) above.\n\nThe security bugs I\u0027m referring to here were in other OpenStack services (swift, cinder are the two that I can recall) and unrelated in all but the fact they allowed reading arbitrary files on the server.  I can remove this part of the change description if you feel this was unclear.","commit_id":"27d7b25435ef275b027cc5848bf5d01f690574ba"},{"author":{"_account_id":6835,"name":"Kun Huang","email":"gareth@openstacker.org","username":"academicgareth"},"change_message_id":"c5a6342a7523652b52109c15487348601a6a4e2d","unresolved":false,"context_lines":[{"line_number":10,"context_line":"\"userdata_file\" option that reads userdata from a file path.  Currently"},{"line_number":11,"context_line":"this feature doesn\u0027t work because:"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"A) The config schema rejects the userdata_file property."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"B) There\u0027s a bug where the file contents are only passed to the first"},{"line_number":16,"context_line":"   server created (should use a string rather than a file handle in the"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"1a4dcd0f_b7f04192","line":13,"updated":"2015-08-13 02:24:29.000000000","message":"which config schema?","commit_id":"b3bcd1899137f707ff152b9b3a805013b2c6f3a6"},{"author":{"_account_id":11279,"name":"Angus Lees","email":"gus@inodes.org","username":"gus"},"change_message_id":"7029de126947f799366b2ad8ce637ca1b64c016b","unresolved":false,"context_lines":[{"line_number":10,"context_line":"\"userdata_file\" option that reads userdata from a file path.  Currently"},{"line_number":11,"context_line":"this feature doesn\u0027t work because:"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"A) The config schema rejects the userdata_file property."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"B) There\u0027s a bug where the file contents are only passed to the first"},{"line_number":16,"context_line":"   server created (should use a string rather than a file handle in the"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"1a4dcd0f_31a59446","line":13,"in_reply_to":"1a4dcd0f_b7f04192","updated":"2015-08-17 03:47:49.000000000","message":"See CONFIG_SCHEMA earlier in openstack.py","commit_id":"b3bcd1899137f707ff152b9b3a805013b2c6f3a6"},{"author":{"_account_id":6835,"name":"Kun Huang","email":"gareth@openstacker.org","username":"academicgareth"},"change_message_id":"c5a6342a7523652b52109c15487348601a6a4e2d","unresolved":false,"context_lines":[{"line_number":19,"context_line":"Since security bugs that allow reading arbitrary files from OpenStack"},{"line_number":20,"context_line":"servers are all the rage these days, this change removes the vestigial"},{"line_number":21,"context_line":"userdata_file code to prevent anyone being tempted to \"fix\" this feature"},{"line_number":22,"context_line":"and allow reads from arbitrary server-side paths in some distant future."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"If/when this feature is desired, it needs to be clear that the"},{"line_number":25,"context_line":"userdata_file contents will be read on the client side of some"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"1a4dcd0f_9730a557","line":22,"updated":"2015-08-13 02:24:29.000000000","message":"L15~L22\nIt looks serious, and I think you need add a reference to that bug :)","commit_id":"b3bcd1899137f707ff152b9b3a805013b2c6f3a6"},{"author":{"_account_id":11279,"name":"Angus Lees","email":"gus@inodes.org","username":"gus"},"change_message_id":"7029de126947f799366b2ad8ce637ca1b64c016b","unresolved":false,"context_lines":[{"line_number":19,"context_line":"Since security bugs that allow reading arbitrary files from OpenStack"},{"line_number":20,"context_line":"servers are all the rage these days, this change removes the vestigial"},{"line_number":21,"context_line":"userdata_file code to prevent anyone being tempted to \"fix\" this feature"},{"line_number":22,"context_line":"and allow reads from arbitrary server-side paths in some distant future."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"If/when this feature is desired, it needs to be clear that the"},{"line_number":25,"context_line":"userdata_file contents will be read on the client side of some"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"1a4dcd0f_f133ac11","line":22,"in_reply_to":"1a4dcd0f_9730a557","updated":"2015-08-17 03:47:49.000000000","message":"L15-17 is talking about a different bug to the vague references in L19-22.  I think my rhetoric in L19-22 is confusing people since this is the second review comment asking about these security bugs in other projects - and those bugs are really not relevant to this particular change.\n\nI\u0027ve removed the vague reference to bugs in other projects.","commit_id":"b3bcd1899137f707ff152b9b3a805013b2c6f3a6"}]}