)]}'
{"tests/unit/test_mock.py":[{"author":{"_account_id":11748,"name":"Chris St. Pierre","email":"cstpierr@cisco.com","username":"stpierre"},"change_message_id":"7981558a9ed85c8718c8964b234a3ac0dc94b6f9","unresolved":false,"context_lines":[{"line_number":276,"context_line":"                        \"filename\": error[\"filename\"],"},{"line_number":277,"context_line":"                        \"lineno\": error[\"lineno\"]})"},{"line_number":278,"context_line":""},{"line_number":279,"context_line":"        self.assertEqual([], errors)"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa32b979_ff905f97","line":279,"updated":"2015-06-22 21:51:53.000000000","message":"I wonder if we want to change this to:\n\n    self.assertEqual(len(errors), 0)\n\nWhen errors has stuff in it, the assertion as it currently stands makes a lot of noise, and that noise increases as errors gets more stuff.","commit_id":"6c585902a2e5e45dc687afd29e9269b17c15a18e"},{"author":{"_account_id":13609,"name":"Pavel Boldin","email":"pboldin@mirantis.com","username":"pboldin"},"change_message_id":"3df46d0412e84eb7acac0161d9cdc7579b36638e","unresolved":false,"context_lines":[{"line_number":276,"context_line":"                        \"filename\": error[\"filename\"],"},{"line_number":277,"context_line":"                        \"lineno\": error[\"lineno\"]})"},{"line_number":278,"context_line":""},{"line_number":279,"context_line":"        self.assertEqual([], errors)"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa32b979_3f732782","line":279,"in_reply_to":"fa32b979_ff905f97","updated":"2015-06-22 21:55:15.000000000","message":"Chris,\n\nAt first (\"we put nitpicks to your nitpicks so you can nitpick while you nitpick\"): the argument order is otherwise.\n\nAt second, sometimes people do shutdown stderr/stdout output from tests completely (Rally explicitly captures them by OS_STDOUT_CAPTURE) so these will be the last thing to resort to.","commit_id":"6c585902a2e5e45dc687afd29e9269b17c15a18e"},{"author":{"_account_id":11748,"name":"Chris St. Pierre","email":"cstpierr@cisco.com","username":"stpierre"},"change_message_id":"fa4da4fde79db77272dc922591eb1edacc332d0f","unresolved":false,"context_lines":[{"line_number":86,"context_line":"                val \u003d node.left.s % self.globals_[node.right.id]"},{"line_number":87,"context_line":"            elif isinstance(node.op, ast.Add):"},{"line_number":88,"context_line":"                assert (isinstance(node.left, ast.Name) and"},{"line_number":89,"context_line":"                        isinstance(node.right, ast.Str))"},{"line_number":90,"context_line":"                val \u003d self.globals_[node.left.id] + node.right.s"},{"line_number":91,"context_line":"        elif isinstance(node, ast.Name):"},{"line_number":92,"context_line":"            val \u003d self.globals_[node.id]"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa32b979_97272fc9","line":89,"updated":"2015-06-25 12:32:53.000000000","message":"Using assertions here seems strange, since they\u0027re not caught anywhere else. I think you\u0027re saying that something like this would be a bug?\n\n    @mock.patch(\"rally.foo.\" + \"bar\")\n    @mock.patch(\"rally.foo.%s\" % \"bar\")\n\nI guess I don\u0027t disagree with that, but it\u0027d be nice to have a friendly error message from assert so that the user who writes something like the above understands what s/he did wrong.","commit_id":"538b119bae3920270dcd3e073ada88dac87270df"},{"author":{"_account_id":11748,"name":"Chris St. Pierre","email":"cstpierr@cisco.com","username":"stpierre"},"change_message_id":"fa4da4fde79db77272dc922591eb1edacc332d0f","unresolved":false,"context_lines":[{"line_number":125,"context_line":"            prefixed_variants.append(token + \"_\" + prefixed_variants[-1])"},{"line_number":126,"context_line":"        return prefixed_variants"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"    class Variants(object):"},{"line_number":129,"context_line":"        def __init__(self, variants):"},{"line_number":130,"context_line":"            self.variants \u003d variants"},{"line_number":131,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"fa32b979_b7927355","line":128,"updated":"2015-06-25 12:32:53.000000000","message":"Can Variants be a module-level class instead of an inner class to FuncMockArgsDecoratorsChecker?","commit_id":"538b119bae3920270dcd3e073ada88dac87270df"},{"author":{"_account_id":11748,"name":"Chris St. Pierre","email":"cstpierr@cisco.com","username":"stpierre"},"change_message_id":"fa4da4fde79db77272dc922591eb1edacc332d0f","unresolved":false,"context_lines":[{"line_number":136,"context_line":"            return \"{\" + \", \".join(map(repr, variants)) + ("},{"line_number":137,"context_line":"                \", ...}\" if len(self.variants) \u003e 3 else \"}\")"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"        __repr__ \u003d __str__"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"        def __eq__(self, val):"},{"line_number":142,"context_line":"            return val \u003d\u003d self.variants"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa32b979_37098395","line":139,"updated":"2015-06-25 12:32:53.000000000","message":"If __repr__ is defined but __str__ is not, then the class acts as if __str__ \u003d __repr__: https://docs.python.org/2/reference/datamodel.html#object.__repr__\n\nIOW, you can just define __repr__ instead of defining __str__ and assigning it to __repr__ as well.","commit_id":"538b119bae3920270dcd3e073ada88dac87270df"},{"author":{"_account_id":11748,"name":"Chris St. Pierre","email":"cstpierr@cisco.com","username":"stpierre"},"change_message_id":"fa4da4fde79db77272dc922591eb1edacc332d0f","unresolved":false,"context_lines":[{"line_number":139,"context_line":"        __repr__ \u003d __str__"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"        def __eq__(self, val):"},{"line_number":142,"context_line":"            return val \u003d\u003d self.variants"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"        def __contains__(self, val):"},{"line_number":145,"context_line":"            return val in self.variants"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa32b979_172d5ffd","line":142,"updated":"2015-06-25 12:32:53.000000000","message":"This works if \u0027val\u0027 is a list itself, but what if val is a Variants object? This could be:\n\n    return getattr(val, \u0027variants\u0027, val) \u003d\u003d self.variants\n\nThat way it would work if val was a Variants object (or Variants-like), or if it was a list.","commit_id":"538b119bae3920270dcd3e073ada88dac87270df"},{"author":{"_account_id":11748,"name":"Chris St. Pierre","email":"cstpierr@cisco.com","username":"stpierre"},"change_message_id":"fa4da4fde79db77272dc922591eb1edacc332d0f","unresolved":false,"context_lines":[{"line_number":142,"context_line":"            return val \u003d\u003d self.variants"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"        def __contains__(self, val):"},{"line_number":145,"context_line":"            return val in self.variants"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"    def _get_mocked_name_variants(self, name):"},{"line_number":148,"context_line":"        tokens \u003d name.split(\".\")"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa32b979_d732975d","line":145,"updated":"2015-06-25 12:32:53.000000000","message":"Ditto.","commit_id":"538b119bae3920270dcd3e073ada88dac87270df"},{"author":{"_account_id":11748,"name":"Chris St. Pierre","email":"cstpierr@cisco.com","username":"stpierre"},"change_message_id":"fa4da4fde79db77272dc922591eb1edacc332d0f","unresolved":false,"context_lines":[{"line_number":298,"context_line":"        if errors:"},{"line_number":299,"context_line":"            print(FuncMockArgsDecoratorsChecker.__doc__)"},{"line_number":300,"context_line":"            print(\"\\n\\n\""},{"line_number":301,"context_line":"                  \"There were found the following errors during the described\""},{"line_number":302,"context_line":"                  \" check:\")"},{"line_number":303,"context_line":"            for error in errors:"},{"line_number":304,"context_line":"                print(\"\\n\\n\""}],"source_content_type":"text/x-python","patch_set":7,"id":"fa32b979_17c9df25","line":301,"updated":"2015-06-25 12:32:53.000000000","message":"Better: \"The following errors were found during the described check:\"","commit_id":"538b119bae3920270dcd3e073ada88dac87270df"},{"author":{"_account_id":6835,"name":"Kun Huang","email":"gareth@openstacker.org","username":"academicgareth"},"change_message_id":"7b6e4a4481f268f8ac9deab1605a683577051be2","unresolved":false,"context_lines":[{"line_number":313,"context_line":"                message.rstrip().replace(\"\\n\", \"  \").replace(\"\\t\", \"\")"},{"line_number":314,"context_line":"                for message in error[\"messages\"]"},{"line_number":315,"context_line":"            ]"},{"line_number":316,"context_line":"        self.assertEqual([], errors)"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa32b979_69da7919","line":316,"updated":"2015-06-27 08:27:47.000000000","message":"Do L311~L315 serve L316 to help print nice output?\n\nIt is a little redundant with L 307\n\nOR after printing message at last for loop, the assert statement in this line could be simplified to self.assertFalse(\"The following errors were found during the described check\")","commit_id":"538b119bae3920270dcd3e073ada88dac87270df"},{"author":{"_account_id":13609,"name":"Pavel Boldin","email":"pboldin@mirantis.com","username":"pboldin"},"change_message_id":"cbb0226c767ce7613fc4ffffe88c5e4954c1e088","unresolved":false,"context_lines":[{"line_number":313,"context_line":"                message.rstrip().replace(\"\\n\", \"  \").replace(\"\\t\", \"\")"},{"line_number":314,"context_line":"                for message in error[\"messages\"]"},{"line_number":315,"context_line":"            ]"},{"line_number":316,"context_line":"        self.assertEqual([], errors)"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa32b979_d4623cd9","line":316,"in_reply_to":"fa32b979_69da7919","updated":"2015-06-27 09:47:57.000000000","message":"Please take a look at a previous discussion. I will add a comment to a re-roll.","commit_id":"538b119bae3920270dcd3e073ada88dac87270df"}]}
