)]}'
{"rally/benchmark/validation.py":[{"author":{"_account_id":6835,"name":"Kun Huang","email":"gareth@openstacker.org","username":"academicgareth"},"change_message_id":"d569da9b08f0f6b278b5d7a7b36c717dec43efc0","unresolved":false,"context_lines":[{"line_number":616,"context_line":"    :param subdict: sub-dict of \"config\" to search for param_names. if"},{"line_number":617,"context_line":"    not defined - will search in \"config\""},{"line_number":618,"context_line":"    \"\"\""},{"line_number":619,"context_line":"    param_names \u003d param_names or []"},{"line_number":620,"context_line":"    for param_name in param_names:"},{"line_number":621,"context_line":"        args \u003d config.get(\"args\", {})"},{"line_number":622,"context_line":"        a_dict, a_key \u003d (args, subdict) if subdict else (config, \"args\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa32b979_bdefff1b","line":619,"updated":"2015-06-24 05:00:36.000000000","message":"If we pass a string type value as param_names, the mistake will be hidden. For example, with \u0027wrong_param\u0027, the below for loop will check \u0027w\u0027, \u0027r\u0027.... and don\u0027t warn you or raise something. So we need check param_name iterable here.\n\nOr check the whole value only for string parameter, not iterate string directly.","commit_id":"5868fa54e2e239d041ad7f6e0c6e095c69848475"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"ad6f02e74b780d1d76c34ff02d820eaf15676071","unresolved":false,"context_lines":[{"line_number":616,"context_line":"    :param subdict: sub-dict of \"config\" to search for param_names. if"},{"line_number":617,"context_line":"    not defined - will search in \"config\""},{"line_number":618,"context_line":"    \"\"\""},{"line_number":619,"context_line":"    param_names \u003d param_names or []"},{"line_number":620,"context_line":"    for param_name in param_names:"},{"line_number":621,"context_line":"        args \u003d config.get(\"args\", {})"},{"line_number":622,"context_line":"        a_dict, a_key \u003d (args, subdict) if subdict else (config, \"args\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa32b979_a3759ccb","line":619,"in_reply_to":"fa32b979_bdefff1b","updated":"2015-06-24 06:52:35.000000000","message":"check added","commit_id":"5868fa54e2e239d041ad7f6e0c6e095c69848475"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"50304a5f7a4994726f9a90a3390bb24982417f3f","unresolved":false,"context_lines":[{"line_number":610,"context_line":"@validator"},{"line_number":611,"context_line":"def restricted_parameters(config, clients, deployment, param_names,"},{"line_number":612,"context_line":"                          subdict\u003dNone):"},{"line_number":613,"context_line":"    \"\"\"Validates that parameter is not set."},{"line_number":614,"context_line":""},{"line_number":615,"context_line":"    :param param_names: parameters list to be validated."},{"line_number":616,"context_line":"    :param subdict: sub-dict of \"config\" to search for param_names. if"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa32b979_2bc87721","line":613,"updated":"2015-06-24 12:24:34.000000000","message":"s/parameter/parameter(s)","commit_id":"a23d1d7a36278a10f2ab1b6b768e6248201a66b3"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"c59f5d045bde07d2d8b1c8d6a5608fd3609e8d2b","unresolved":false,"context_lines":[{"line_number":610,"context_line":"@validator"},{"line_number":611,"context_line":"def restricted_parameters(config, clients, deployment, param_names,"},{"line_number":612,"context_line":"                          subdict\u003dNone):"},{"line_number":613,"context_line":"    \"\"\"Validates that parameter is not set."},{"line_number":614,"context_line":""},{"line_number":615,"context_line":"    :param param_names: parameters list to be validated."},{"line_number":616,"context_line":"    :param subdict: sub-dict of \"config\" to search for param_names. if"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa32b979_6dbf53d0","line":613,"in_reply_to":"fa32b979_2bc87721","updated":"2015-06-25 00:53:17.000000000","message":"Done","commit_id":"a23d1d7a36278a10f2ab1b6b768e6248201a66b3"},{"author":{"_account_id":6835,"name":"Kun Huang","email":"gareth@openstacker.org","username":"academicgareth"},"change_message_id":"afa663700e8190f4018ceda171c6d4469e03d5b5","unresolved":false,"context_lines":[{"line_number":616,"context_line":"    :param subdict: sub-dict of \"config\" to search for param_names. if"},{"line_number":617,"context_line":"    not defined - will search in \"config\""},{"line_number":618,"context_line":"    \"\"\""},{"line_number":619,"context_line":"    if type(param_names) !\u003d list:"},{"line_number":620,"context_line":"        return ValidationResult(False, _(\"`param_names` must be a list\"))"},{"line_number":621,"context_line":""},{"line_number":622,"context_line":"    for param_name in param_names:"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa32b979_58defe6d","line":619,"updated":"2015-06-24 07:36:21.000000000","message":"a trivial improvement could be:\n\n    if not isinstance(param_names, list):\n        ...","commit_id":"a23d1d7a36278a10f2ab1b6b768e6248201a66b3"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"9397e50353c8918b22805d8da460ae742e5f4a54","unresolved":false,"context_lines":[{"line_number":616,"context_line":"    :param subdict: sub-dict of \"config\" to search for param_names. if"},{"line_number":617,"context_line":"    not defined - will search in \"config\""},{"line_number":618,"context_line":"    \"\"\""},{"line_number":619,"context_line":"    if type(param_names) !\u003d list:"},{"line_number":620,"context_line":"        return ValidationResult(False, _(\"`param_names` must be a list\"))"},{"line_number":621,"context_line":""},{"line_number":622,"context_line":"    for param_name in param_names:"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa32b979_fe3c7330","line":619,"in_reply_to":"fa32b979_4b95bb30","updated":"2015-06-24 22:02:21.000000000","message":"if not instance(param_names, (list, tuple)):\n     param_names \u003d [param_names]","commit_id":"a23d1d7a36278a10f2ab1b6b768e6248201a66b3"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"50304a5f7a4994726f9a90a3390bb24982417f3f","unresolved":false,"context_lines":[{"line_number":616,"context_line":"    :param subdict: sub-dict of \"config\" to search for param_names. if"},{"line_number":617,"context_line":"    not defined - will search in \"config\""},{"line_number":618,"context_line":"    \"\"\""},{"line_number":619,"context_line":"    if type(param_names) !\u003d list:"},{"line_number":620,"context_line":"        return ValidationResult(False, _(\"`param_names` must be a list\"))"},{"line_number":621,"context_line":""},{"line_number":622,"context_line":"    for param_name in param_names:"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa32b979_4b95bb30","line":619,"in_reply_to":"fa32b979_58defe6d","updated":"2015-06-24 12:24:34.000000000","message":"I prefer next check:\n\n    if not instance(param_names, list) or not instance(param_names, tuple):\n         param_names \u003d [param_names]","commit_id":"a23d1d7a36278a10f2ab1b6b768e6248201a66b3"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"c59f5d045bde07d2d8b1c8d6a5608fd3609e8d2b","unresolved":false,"context_lines":[{"line_number":616,"context_line":"    :param subdict: sub-dict of \"config\" to search for param_names. if"},{"line_number":617,"context_line":"    not defined - will search in \"config\""},{"line_number":618,"context_line":"    \"\"\""},{"line_number":619,"context_line":"    if type(param_names) !\u003d list:"},{"line_number":620,"context_line":"        return ValidationResult(False, _(\"`param_names` must be a list\"))"},{"line_number":621,"context_line":""},{"line_number":622,"context_line":"    for param_name in param_names:"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa32b979_ed6fe38f","line":619,"in_reply_to":"fa32b979_fe3c7330","updated":"2015-06-25 00:53:17.000000000","message":"Done","commit_id":"a23d1d7a36278a10f2ab1b6b768e6248201a66b3"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"50304a5f7a4994726f9a90a3390bb24982417f3f","unresolved":false,"context_lines":[{"line_number":623,"context_line":"        args \u003d config.get(\"args\", {})"},{"line_number":624,"context_line":"        a_dict, a_key \u003d (args, subdict) if subdict else (config, \"args\")"},{"line_number":625,"context_line":"        if param_name in a_dict.get(a_key, {}):"},{"line_number":626,"context_line":"            msg \u003d (_(\"You can\u0027t specify parameter \u0027%(param)s\u0027 in \u0027%(a_dict)s\u0027\")"},{"line_number":627,"context_line":"                   % {\"param\": param_name,"},{"line_number":628,"context_line":"                      \"a_dict\": subdict if subdict else \"args\"})"},{"line_number":629,"context_line":"            return ValidationResult(False, msg)"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa32b979_2b615739","line":626,"updated":"2015-06-24 12:24:34.000000000","message":"It would be much better to check all parameters at once. I mean:\n\n    restricted_params \u003d []\n    for param_name in param_names:\n        ...\n        if param_name in a_dict.get(a_key, {}):\n            restricted_params.append(param_name)\n    if restricted_params:\n        return ValidationResult","commit_id":"a23d1d7a36278a10f2ab1b6b768e6248201a66b3"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"c59f5d045bde07d2d8b1c8d6a5608fd3609e8d2b","unresolved":false,"context_lines":[{"line_number":623,"context_line":"        args \u003d config.get(\"args\", {})"},{"line_number":624,"context_line":"        a_dict, a_key \u003d (args, subdict) if subdict else (config, \"args\")"},{"line_number":625,"context_line":"        if param_name in a_dict.get(a_key, {}):"},{"line_number":626,"context_line":"            msg \u003d (_(\"You can\u0027t specify parameter \u0027%(param)s\u0027 in \u0027%(a_dict)s\u0027\")"},{"line_number":627,"context_line":"                   % {\"param\": param_name,"},{"line_number":628,"context_line":"                      \"a_dict\": subdict if subdict else \"args\"})"},{"line_number":629,"context_line":"            return ValidationResult(False, msg)"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa32b979_8d0177b1","line":626,"in_reply_to":"fa32b979_2b615739","updated":"2015-06-25 00:53:17.000000000","message":"Done","commit_id":"a23d1d7a36278a10f2ab1b6b768e6248201a66b3"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"9b01c3a0ceace8dc494d7a15976fda9e0c986da2","unresolved":false,"context_lines":[{"line_number":617,"context_line":"                    not defined - will search in \"config\""},{"line_number":618,"context_line":"    \"\"\""},{"line_number":619,"context_line":"    if not isinstance(param_names, (list, tuple)):"},{"line_number":620,"context_line":"        param_names \u003d [param_names]"},{"line_number":621,"context_line":""},{"line_number":622,"context_line":"    restricted_params \u003d []"},{"line_number":623,"context_line":"    for param_name in param_names:"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa32b979_ed6795b5","line":620,"updated":"2015-06-26 13:12:48.000000000","message":"Why not to do always a list and do not make such checks? Just [param1] or [param1, param2]","commit_id":"8060c6d2e96e954b753d8c6d59f988256f064b34"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"7b0cdb24c63d8571caf38ea204d66afbdd613dee","unresolved":false,"context_lines":[{"line_number":617,"context_line":"                    not defined - will search in \"config\""},{"line_number":618,"context_line":"    \"\"\""},{"line_number":619,"context_line":"    if not isinstance(param_names, (list, tuple)):"},{"line_number":620,"context_line":"        param_names \u003d [param_names]"},{"line_number":621,"context_line":""},{"line_number":622,"context_line":"    restricted_params \u003d []"},{"line_number":623,"context_line":"    for param_name in param_names:"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa32b979_4de6c1b1","line":620,"in_reply_to":"fa32b979_ed6795b5","updated":"2015-06-26 13:23:53.000000000","message":"Because it decreases readability of decorator:)","commit_id":"8060c6d2e96e954b753d8c6d59f988256f064b34"}]}
