)]}'
{"rally/benchmark/scenarios/base.py":[{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"1b279b0066bbd7330263d1dbe8480268734a6ddf","unresolved":false,"context_lines":[{"line_number":54,"context_line":"       be auto discoverable and you will be able to specify it in test config."},{"line_number":55,"context_line":"    \"\"\""},{"line_number":56,"context_line":"    RESOURCE_NAME_PREFIX \u003d \"rally_\""},{"line_number":57,"context_line":"    RESOURCE_NAME_LENGTH \u003d 16"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    def __init__(self, context\u003dNone, admin_clients\u003dNone, clients\u003dNone):"},{"line_number":60,"context_line":"        self.context \u003d context"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa32b979_41e690b1","line":57,"range":{"start_line":57,"start_character":4,"end_line":57,"end_character":24},"updated":"2015-06-26 11:51:01.000000000","message":"This property is being widely used:\n\n grep -r RESOURCE_NAME_LENGTH rally/\n\nWill you change all these properties?\n\nDo you think that we should manually calculate random part length by RESOURCE_NAME_LENGTH - RESOURCE_NAME_PREFIX ?","commit_id":"ef32b7dfd15eda9502006b5d750c024a36534e11"},{"author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"change_message_id":"715f148d9dc5f5141c03b0a016b6a6886a7ccd5b","unresolved":false,"context_lines":[{"line_number":54,"context_line":"       be auto discoverable and you will be able to specify it in test config."},{"line_number":55,"context_line":"    \"\"\""},{"line_number":56,"context_line":"    RESOURCE_NAME_PREFIX \u003d \"rally_\""},{"line_number":57,"context_line":"    RESOURCE_NAME_LENGTH \u003d 16"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    def __init__(self, context\u003dNone, admin_clients\u003dNone, clients\u003dNone):"},{"line_number":60,"context_line":"        self.context \u003d context"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba3cc151_b7f09792","line":57,"in_reply_to":"fa32b979_41e690b1","updated":"2015-07-01 13:42:27.000000000","message":"As you stated in your other comment, there are cases where the random part becomes quite small, and in order for some tests to pass, RESOURCE_NAME_LENGTH had to be bigger than 10.","commit_id":"ef32b7dfd15eda9502006b5d750c024a36534e11"}],"rally/common/utils.py":[{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"e5cd20a90d54d060a3324446061594b879db3a5a","unresolved":false,"context_lines":[{"line_number":416,"context_line":"    \"\"\""},{"line_number":417,"context_line":""},{"line_number":418,"context_line":"    rand_part \u003d \"\".join(random.choice(choice)"},{"line_number":419,"context_line":"                        for i in range(length - len(prefix)))"},{"line_number":420,"context_line":"    return prefix + rand_part"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa32b979_6415e247","line":419,"updated":"2015-06-26 12:19:05.000000000","message":"you should check here that `length - len(prefix)` \u003e 0","commit_id":"ef32b7dfd15eda9502006b5d750c024a36534e11"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"c1b4da09796ff99fb1c53a1c651e2820fa4d4a74","unresolved":false,"context_lines":[{"line_number":416,"context_line":"    \"\"\""},{"line_number":417,"context_line":""},{"line_number":418,"context_line":"    rand_part \u003d \"\".join(random.choice(choice)"},{"line_number":419,"context_line":"                        for i in range(length - len(prefix)))"},{"line_number":420,"context_line":"    return prefix + rand_part"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba3cc151_9d0ae677","line":419,"in_reply_to":"ba3cc151_ba9dde67","updated":"2015-07-07 10:43:18.000000000","message":"Right, it should be verified.","commit_id":"ef32b7dfd15eda9502006b5d750c024a36534e11"},{"author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"change_message_id":"715f148d9dc5f5141c03b0a016b6a6886a7ccd5b","unresolved":false,"context_lines":[{"line_number":416,"context_line":"    \"\"\""},{"line_number":417,"context_line":""},{"line_number":418,"context_line":"    rand_part \u003d \"\".join(random.choice(choice)"},{"line_number":419,"context_line":"                        for i in range(length - len(prefix)))"},{"line_number":420,"context_line":"    return prefix + rand_part"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba3cc151_ba9dde67","line":419,"in_reply_to":"fa32b979_6415e247","updated":"2015-07-01 13:42:27.000000000","message":"Indeed.","commit_id":"ef32b7dfd15eda9502006b5d750c024a36534e11"}]}