)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6835,"name":"Kun Huang","email":"gareth@openstacker.org","username":"academicgareth"},"change_message_id":"e7454cef3963fe3c3d72990efbc3ce7b321203dc","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"* Fix related unit tests"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"* Fix hacking check that doens\u0027t allow to use list() and dict()"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Change-Id: I0769a10bf55ff7440ef46643dbcc8005cdb7523e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"ba3cc151_be43c712","line":17,"updated":"2015-07-07 08:34:30.000000000","message":"It means re-enable to use \"list()\"? I doesn\u0027t work now. I have add a \"KUN \u003d list()\", and \u0027tox -epep8\u0027 got http://paste.openstack.org/show/351246/ .\n\nI think this is a kind of fix on \"tox.ini-\u003e[flake8]-\u003eignore\"","commit_id":"aca1858e86bf619384d37ce144827805b966096b"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"cd9c5b5c5ab349187876b0886fdf34cadebad17b","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"* Fix related unit tests"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"* Fix hacking check that doens\u0027t allow to use list() and dict()"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Change-Id: I0769a10bf55ff7440ef46643dbcc8005cdb7523e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"ba3cc151_92ad6b8a","line":17,"in_reply_to":"ba3cc151_be43c712","updated":"2015-07-09 20:25:11.000000000","message":"rephrased","commit_id":"aca1858e86bf619384d37ce144827805b966096b"}],"rally/plugins/openstack/context/sahara/sahara_image.py":[{"author":{"_account_id":6835,"name":"Kun Huang","email":"gareth@openstacker.org","username":"academicgareth"},"change_message_id":"e7454cef3963fe3c3d72990efbc3ce7b321203dc","unresolved":false,"context_lines":[{"line_number":91,"context_line":"            clients \u003d osclients.Clients(user[\"endpoint\"])"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"            image \u003d clients.glance().images.get(image_uuid)"},{"line_number":94,"context_line":"            print(image.is_public)"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"            if not image.is_public:"},{"line_number":97,"context_line":"                raise exceptions.BenchmarkSetupFailure("}],"source_content_type":"text/x-python","patch_set":2,"id":"ba3cc151_93ab5c1e","line":94,"updated":"2015-07-07 08:34:30.000000000","message":"debug line?","commit_id":"aca1858e86bf619384d37ce144827805b966096b"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"cd9c5b5c5ab349187876b0886fdf34cadebad17b","unresolved":false,"context_lines":[{"line_number":91,"context_line":"            clients \u003d osclients.Clients(user[\"endpoint\"])"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"            image \u003d clients.glance().images.get(image_uuid)"},{"line_number":94,"context_line":"            print(image.is_public)"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"            if not image.is_public:"},{"line_number":97,"context_line":"                raise exceptions.BenchmarkSetupFailure("}],"source_content_type":"text/x-python","patch_set":2,"id":"ba3cc151_12b07bdc","line":94,"in_reply_to":"ba3cc151_93ab5c1e","updated":"2015-07-09 20:25:11.000000000","message":"Done","commit_id":"aca1858e86bf619384d37ce144827805b966096b"}],"rally/plugins/openstack/scenarios/sahara/utils.py":[{"author":{"_account_id":6835,"name":"Kun Huang","email":"gareth@openstacker.org","username":"academicgareth"},"change_message_id":"e7454cef3963fe3c3d72990efbc3ce7b321203dc","unresolved":false,"context_lines":[{"line_number":505,"context_line":"        \"\"\""},{"line_number":506,"context_line":""},{"line_number":507,"context_line":"        if consts.Service.NEUTRON not in self.clients(\"services\").values():"},{"line_number":508,"context_line":"            print(self.clients(\"services\").values())"},{"line_number":509,"context_line":"            return None"},{"line_number":510,"context_line":""},{"line_number":511,"context_line":"        # Taking net id from context."}],"source_content_type":"text/x-python","patch_set":2,"id":"ba3cc151_f349888f","line":508,"updated":"2015-07-07 08:34:30.000000000","message":"debug line","commit_id":"aca1858e86bf619384d37ce144827805b966096b"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"cd9c5b5c5ab349187876b0886fdf34cadebad17b","unresolved":false,"context_lines":[{"line_number":505,"context_line":"        \"\"\""},{"line_number":506,"context_line":""},{"line_number":507,"context_line":"        if consts.Service.NEUTRON not in self.clients(\"services\").values():"},{"line_number":508,"context_line":"            print(self.clients(\"services\").values())"},{"line_number":509,"context_line":"            return None"},{"line_number":510,"context_line":""},{"line_number":511,"context_line":"        # Taking net id from context."}],"source_content_type":"text/x-python","patch_set":2,"id":"ba3cc151_52dda312","line":508,"in_reply_to":"ba3cc151_f349888f","updated":"2015-07-09 20:25:11.000000000","message":"Done","commit_id":"aca1858e86bf619384d37ce144827805b966096b"}],"tests/hacking/checks.py":[{"author":{"_account_id":11748,"name":"Chris St. Pierre","email":"cstpierr@cisco.com","username":"stpierre"},"change_message_id":"e5d181588bba4edce2f923f886e40e6909b5273a","unresolved":false,"context_lines":[{"line_number":47,"context_line":"re_assert_equal_in_start_with_true_or_false \u003d re.compile("},{"line_number":48,"context_line":"    r\"assertEqual\\((True|False), (\\w|[][.\u0027\\\"])+( not)? in (\\w|[][.\u0027\\\", ])+\\)\")"},{"line_number":49,"context_line":"re_no_construct_dict \u003d re.compile("},{"line_number":50,"context_line":"    r\"\\sdict\\(\\)\")"},{"line_number":51,"context_line":"re_no_construct_list \u003d re.compile("},{"line_number":52,"context_line":"    r\"\\slist\\(\\)\")"},{"line_number":53,"context_line":"re_str_format \u003d re.compile(r\"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"ba3cc151_3526d468","line":50,"updated":"2015-07-07 19:22:00.000000000","message":"I\u0027m not sure we should completely eliminate dict(), since Python 2.6 doesn\u0027t have dict comprehensions. Instead you have to do something like:\n\n    foo \u003d dict([(k, v) for k, v in some_iterable])\n\nWhich is ugly, but at least it\u0027s not:\n\n    foo \u003d {}\n    for k, v in some_iterable:\n        foo[k] \u003d v\n\nThat said, poor-man\u0027s dict comprehensions are really the only place we should be using dict(), so maybe we just need a smarter hacking rule.\n\nAlso, this change seems like it should be in a separate patch.","commit_id":"aca1858e86bf619384d37ce144827805b966096b"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"cd9c5b5c5ab349187876b0886fdf34cadebad17b","unresolved":false,"context_lines":[{"line_number":47,"context_line":"re_assert_equal_in_start_with_true_or_false \u003d re.compile("},{"line_number":48,"context_line":"    r\"assertEqual\\((True|False), (\\w|[][.\u0027\\\"])+( not)? in (\\w|[][.\u0027\\\", ])+\\)\")"},{"line_number":49,"context_line":"re_no_construct_dict \u003d re.compile("},{"line_number":50,"context_line":"    r\"\\sdict\\(\\)\")"},{"line_number":51,"context_line":"re_no_construct_list \u003d re.compile("},{"line_number":52,"context_line":"    r\"\\slist\\(\\)\")"},{"line_number":53,"context_line":"re_str_format \u003d re.compile(r\"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"ba3cc151_5204c37c","line":50,"in_reply_to":"ba3cc151_3526d468","updated":"2015-07-09 20:25:11.000000000","message":"I would try to separate it.","commit_id":"aca1858e86bf619384d37ce144827805b966096b"}],"tests/unit/plugins/openstack/context/sahara/test_sahara_cluster.py":[{"author":{"_account_id":11748,"name":"Chris St. Pierre","email":"cstpierr@cisco.com","username":"stpierre"},"change_message_id":"e5d181588bba4edce2f923f886e40e6909b5273a","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"CTX \u003d \"rally.plugins.openstack.context.sahara\""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"class SaharaClusterTestCase(test.TestCase):"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    def setUp(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba3cc151_b54e64bf","line":26,"updated":"2015-07-07 19:22:00.000000000","message":"Since the SaharaCluster context object gets its osclients.Clients object from the scenario object it creates, it seems like this could use tests.unit.test.ScenarioTestCase, and save you some mocking below. It\u0027d also make it easier to test the bench_utils.wait_for() call, since ScenarioTestCase has some handy fixtures.","commit_id":"aca1858e86bf619384d37ce144827805b966096b"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"cd9c5b5c5ab349187876b0886fdf34cadebad17b","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"CTX \u003d \"rally.plugins.openstack.context.sahara\""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"class SaharaClusterTestCase(test.TestCase):"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    def setUp(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba3cc151_9249ebd2","line":26,"in_reply_to":"ba3cc151_b54e64bf","updated":"2015-07-09 20:25:11.000000000","message":"Nope it can not I tried. You can try in some other patch \u003d) \nSuch kinds of refactoring of code are defiantly out of scope of this patch.","commit_id":"aca1858e86bf619384d37ce144827805b966096b"},{"author":{"_account_id":11748,"name":"Chris St. Pierre","email":"cstpierr@cisco.com","username":"stpierre"},"change_message_id":"29b54be595906c45cd36ec51844b15a8a9952ccf","unresolved":false,"context_lines":[{"line_number":24,"context_line":"CTX \u003d \"rally.plugins.openstack.context.sahara\""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"class SaharaClusterTestCase(test.TestCase):"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    def setUp(self):"},{"line_number":30,"context_line":"        super(SaharaClusterTestCase, self).setUp()"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba3cc151_806a7d18","line":27,"updated":"2015-07-09 20:52:51.000000000","message":"Converting this to ScenarioTestCase works if you set:\n\n    patch_benchmark_utils \u003d False\n\nAnd it\u0027s no more refactoring than you\u0027ve already done -- it changes exactly the same lines in nearly the same ways.","commit_id":"d1eb92d7e2f930b96aeb9436174f4f59366d1c0b"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"8c4584359b74ed4fe0b0ee6b99ba799fb585ac1f","unresolved":false,"context_lines":[{"line_number":24,"context_line":"CTX \u003d \"rally.plugins.openstack.context.sahara\""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"class SaharaClusterTestCase(test.TestCase):"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    def setUp(self):"},{"line_number":30,"context_line":"        super(SaharaClusterTestCase, self).setUp()"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba3cc151_ef71edac","line":27,"in_reply_to":"ba3cc151_806a7d18","updated":"2015-07-10 02:30:15.000000000","message":"Done","commit_id":"d1eb92d7e2f930b96aeb9436174f4f59366d1c0b"},{"author":{"_account_id":11748,"name":"Chris St. Pierre","email":"cstpierr@cisco.com","username":"stpierre"},"change_message_id":"b7c38afd833503dffe0067e0b407d070dff0531c","unresolved":false,"context_lines":[{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    @mock.patch(\"%s.sahara_cluster.resource_manager.cleanup\" % CTX)"},{"line_number":73,"context_line":"    @mock.patch(\"%s.sahara_cluster.utils.SaharaScenario._launch_cluster\" % CTX,"},{"line_number":74,"context_line":"                return_value\u003dmock.MagicMock(id\u003d42))"},{"line_number":75,"context_line":"    @mock.patch(\"%s.sahara_cluster.utils.SaharaScenario.clients\" % CTX)"},{"line_number":76,"context_line":"    def test_setup_and_cleanup(self, mock_sahara_scenario_clients,"},{"line_number":77,"context_line":"                               mock_sahara_scenario__launch_cluster,"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba3cc151_c352ab68","line":74,"updated":"2015-07-10 14:07:11.000000000","message":"Since you converted the class to ScenarioTestCase, you no longer have to mock out clients.","commit_id":"050c7a7c0057b427ff3d6a9c8c7adc7f870b59ce"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"2d1e197f6914385a5445fecc7e6e113d7f77f6e6","unresolved":false,"context_lines":[{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    @mock.patch(\"%s.sahara_cluster.resource_manager.cleanup\" % CTX)"},{"line_number":73,"context_line":"    @mock.patch(\"%s.sahara_cluster.utils.SaharaScenario._launch_cluster\" % CTX,"},{"line_number":74,"context_line":"                return_value\u003dmock.MagicMock(id\u003d42))"},{"line_number":75,"context_line":"    @mock.patch(\"%s.sahara_cluster.utils.SaharaScenario.clients\" % CTX)"},{"line_number":76,"context_line":"    def test_setup_and_cleanup(self, mock_sahara_scenario_clients,"},{"line_number":77,"context_line":"                               mock_sahara_scenario__launch_cluster,"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a41bdd9_04510ad8","line":74,"in_reply_to":"ba3cc151_c352ab68","updated":"2015-07-14 18:43:02.000000000","message":"Done","commit_id":"050c7a7c0057b427ff3d6a9c8c7adc7f870b59ce"},{"author":{"_account_id":11748,"name":"Chris St. Pierre","email":"cstpierr@cisco.com","username":"stpierre"},"change_message_id":"b7c38afd833503dffe0067e0b407d070dff0531c","unresolved":false,"context_lines":[{"line_number":99,"context_line":"                enable_anti_affinity\u003dFalse,"},{"line_number":100,"context_line":"                wait_active\u003dFalse"},{"line_number":101,"context_line":"            ))"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"        mock_sahara_scenario_clients.return_value.clusters.get.side_effect \u003d ["},{"line_number":104,"context_line":"            mock.MagicMock(status\u003d\"not-active\"),"},{"line_number":105,"context_line":"            mock.MagicMock(status\u003d\"active\")]"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba3cc151_834ca3c9","line":102,"updated":"2015-07-10 14:07:11.000000000","message":"And this can be changed to:\n\n    self.clients(\"sahara\").clusters.get.side_effect \u003d [...]","commit_id":"050c7a7c0057b427ff3d6a9c8c7adc7f870b59ce"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"2d1e197f6914385a5445fecc7e6e113d7f77f6e6","unresolved":false,"context_lines":[{"line_number":99,"context_line":"                enable_anti_affinity\u003dFalse,"},{"line_number":100,"context_line":"                wait_active\u003dFalse"},{"line_number":101,"context_line":"            ))"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"        mock_sahara_scenario_clients.return_value.clusters.get.side_effect \u003d ["},{"line_number":104,"context_line":"            mock.MagicMock(status\u003d\"not-active\"),"},{"line_number":105,"context_line":"            mock.MagicMock(status\u003d\"active\")]"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a41bdd9_a4605ea6","line":102,"in_reply_to":"ba3cc151_834ca3c9","updated":"2015-07-14 18:43:02.000000000","message":"Done","commit_id":"050c7a7c0057b427ff3d6a9c8c7adc7f870b59ce"},{"author":{"_account_id":11748,"name":"Chris St. Pierre","email":"cstpierr@cisco.com","username":"stpierre"},"change_message_id":"b7c38afd833503dffe0067e0b407d070dff0531c","unresolved":false,"context_lines":[{"line_number":113,"context_line":""},{"line_number":114,"context_line":"    @mock.patch(\"%s.sahara_cluster.utils.SaharaScenario._launch_cluster\" % CTX,"},{"line_number":115,"context_line":"                return_value\u003dmock.MagicMock(id\u003d42))"},{"line_number":116,"context_line":"    @mock.patch(\"%s.sahara_cluster.utils.SaharaScenario.clients\" % CTX)"},{"line_number":117,"context_line":"    def test_setup_and_cleanup_error(self, mock_sahara_scenario_clients,"},{"line_number":118,"context_line":"                                     mock_sahara_scenario__launch_cluster):"},{"line_number":119,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"ba3cc151_a38e87ce","line":116,"updated":"2015-07-10 14:07:11.000000000","message":"Same here.","commit_id":"050c7a7c0057b427ff3d6a9c8c7adc7f870b59ce"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"2d1e197f6914385a5445fecc7e6e113d7f77f6e6","unresolved":false,"context_lines":[{"line_number":113,"context_line":""},{"line_number":114,"context_line":"    @mock.patch(\"%s.sahara_cluster.utils.SaharaScenario._launch_cluster\" % CTX,"},{"line_number":115,"context_line":"                return_value\u003dmock.MagicMock(id\u003d42))"},{"line_number":116,"context_line":"    @mock.patch(\"%s.sahara_cluster.utils.SaharaScenario.clients\" % CTX)"},{"line_number":117,"context_line":"    def test_setup_and_cleanup_error(self, mock_sahara_scenario_clients,"},{"line_number":118,"context_line":"                                     mock_sahara_scenario__launch_cluster):"},{"line_number":119,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"9a41bdd9_447cf21e","line":116,"in_reply_to":"ba3cc151_a38e87ce","updated":"2015-07-14 18:43:02.000000000","message":"Done","commit_id":"050c7a7c0057b427ff3d6a9c8c7adc7f870b59ce"},{"author":{"_account_id":11748,"name":"Chris St. Pierre","email":"cstpierr@cisco.com","username":"stpierre"},"change_message_id":"b7c38afd833503dffe0067e0b407d070dff0531c","unresolved":false,"context_lines":[{"line_number":139,"context_line":"                wait_active\u003dFalse"},{"line_number":140,"context_line":"            ))"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"        mock_sahara_scenario_clients.return_value.clusters.get.side_effect \u003d ["},{"line_number":143,"context_line":"            mock.MagicMock(status\u003d\"not-active\"),"},{"line_number":144,"context_line":"            mock.MagicMock(status\u003d\"error\")"},{"line_number":145,"context_line":"        ]"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba3cc151_03b41380","line":142,"updated":"2015-07-10 14:07:11.000000000","message":"...and here.","commit_id":"050c7a7c0057b427ff3d6a9c8c7adc7f870b59ce"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"2d1e197f6914385a5445fecc7e6e113d7f77f6e6","unresolved":false,"context_lines":[{"line_number":139,"context_line":"                wait_active\u003dFalse"},{"line_number":140,"context_line":"            ))"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"        mock_sahara_scenario_clients.return_value.clusters.get.side_effect \u003d ["},{"line_number":143,"context_line":"            mock.MagicMock(status\u003d\"not-active\"),"},{"line_number":144,"context_line":"            mock.MagicMock(status\u003d\"error\")"},{"line_number":145,"context_line":"        ]"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a41bdd9_e4742637","line":142,"in_reply_to":"ba3cc151_03b41380","updated":"2015-07-14 18:43:02.000000000","message":"Done","commit_id":"050c7a7c0057b427ff3d6a9c8c7adc7f870b59ce"}],"tests/unit/plugins/openstack/context/sahara/test_sahara_image.py":[{"author":{"_account_id":11748,"name":"Chris St. Pierre","email":"cstpierr@cisco.com","username":"stpierre"},"change_message_id":"e5d181588bba4edce2f923f886e40e6909b5273a","unresolved":false,"context_lines":[{"line_number":25,"context_line":"SCN \u003d \"rally.plugins.openstack.scenarios\""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"class SaharaImageTestCase(test.ScenarioTestCase):"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    def setUp(self):"},{"line_number":31,"context_line":"        super(SaharaImageTestCase, self).setUp()"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba3cc151_15d710c0","line":28,"updated":"2015-07-07 19:22:00.000000000","message":"Yeah, exactly like this. :D","commit_id":"aca1858e86bf619384d37ce144827805b966096b"},{"author":{"_account_id":11748,"name":"Chris St. Pierre","email":"cstpierr@cisco.com","username":"stpierre"},"change_message_id":"e5d181588bba4edce2f923f886e40e6909b5273a","unresolved":false,"context_lines":[{"line_number":128,"context_line":"    @mock.patch(\"%s.glance.utils.GlanceScenario._create_image\" % SCN,"},{"line_number":129,"context_line":"                return_value\u003dmock.MagicMock(id\u003d42))"},{"line_number":130,"context_line":"    @mock.patch(\"%s.resource_manager.cleanup\" % CTX)"},{"line_number":131,"context_line":"    @mock.patch(\"%s.osclients.Clients\" % CTX)"},{"line_number":132,"context_line":"    def test_setup_and_cleanup_existing_image("},{"line_number":133,"context_line":"            self, mock_clients, mock_cleanup,"},{"line_number":134,"context_line":"            mock_glance_scenario__create_image):"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba3cc151_95f1e06c","line":131,"updated":"2015-07-07 19:22:00.000000000","message":"This shouldn\u0027t be necessary since you\u0027re using ScenarioTestCase as a base.","commit_id":"aca1858e86bf619384d37ce144827805b966096b"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"cd9c5b5c5ab349187876b0886fdf34cadebad17b","unresolved":false,"context_lines":[{"line_number":128,"context_line":"    @mock.patch(\"%s.glance.utils.GlanceScenario._create_image\" % SCN,"},{"line_number":129,"context_line":"                return_value\u003dmock.MagicMock(id\u003d42))"},{"line_number":130,"context_line":"    @mock.patch(\"%s.resource_manager.cleanup\" % CTX)"},{"line_number":131,"context_line":"    @mock.patch(\"%s.osclients.Clients\" % CTX)"},{"line_number":132,"context_line":"    def test_setup_and_cleanup_existing_image("},{"line_number":133,"context_line":"            self, mock_clients, mock_cleanup,"},{"line_number":134,"context_line":"            mock_glance_scenario__create_image):"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba3cc151_d26d3333","line":131,"in_reply_to":"ba3cc151_95f1e06c","updated":"2015-07-09 20:25:11.000000000","message":"It is necessary because of this code:\n\nhttps://github.com/openstack/rally/blob/master/rally/plugins/openstack/context/sahara/sahara_image.py#L67 \n\nThey use directly osclients","commit_id":"aca1858e86bf619384d37ce144827805b966096b"},{"author":{"_account_id":11748,"name":"Chris St. Pierre","email":"cstpierr@cisco.com","username":"stpierre"},"change_message_id":"e5d181588bba4edce2f923f886e40e6909b5273a","unresolved":false,"context_lines":[{"line_number":133,"context_line":"            self, mock_clients, mock_cleanup,"},{"line_number":134,"context_line":"            mock_glance_scenario__create_image):"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"        mock_clients.glance.images.get.return_value \u003d mock.MagicMock("},{"line_number":137,"context_line":"            is_public\u003dTrue)"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"        ctx \u003d self.existing_image_context"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba3cc151_15fe3038","line":136,"updated":"2015-07-07 19:22:00.000000000","message":"s/mock_clients.glance/self.clients(\"glance\")/","commit_id":"aca1858e86bf619384d37ce144827805b966096b"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"cd9c5b5c5ab349187876b0886fdf34cadebad17b","unresolved":false,"context_lines":[{"line_number":133,"context_line":"            self, mock_clients, mock_cleanup,"},{"line_number":134,"context_line":"            mock_glance_scenario__create_image):"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"        mock_clients.glance.images.get.return_value \u003d mock.MagicMock("},{"line_number":137,"context_line":"            is_public\u003dTrue)"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"        ctx \u003d self.existing_image_context"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba3cc151_9277ab01","line":136,"in_reply_to":"ba3cc151_15fe3038","updated":"2015-07-09 20:25:11.000000000","message":"it won\u0027t work \u003d)","commit_id":"aca1858e86bf619384d37ce144827805b966096b"},{"author":{"_account_id":11748,"name":"Chris St. Pierre","email":"cstpierr@cisco.com","username":"stpierre"},"change_message_id":"e5d181588bba4edce2f923f886e40e6909b5273a","unresolved":false,"context_lines":[{"line_number":150,"context_line":"        self.assertEqual(False, mock_cleanup.called)"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"    @mock.patch(\"%s.osclients.Clients.glance\" % CTX)"},{"line_number":153,"context_line":"    def test_check_existing_image(self, mock_clients_glance):"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"        ctx \u003d self.existing_image_context"},{"line_number":156,"context_line":"        sahara_ctx \u003d sahara_image.SaharaImage(ctx)"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba3cc151_75953ce2","line":153,"updated":"2015-07-07 19:22:00.000000000","message":"Same here and below.","commit_id":"aca1858e86bf619384d37ce144827805b966096b"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"cd9c5b5c5ab349187876b0886fdf34cadebad17b","unresolved":false,"context_lines":[{"line_number":150,"context_line":"        self.assertEqual(False, mock_cleanup.called)"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"    @mock.patch(\"%s.osclients.Clients.glance\" % CTX)"},{"line_number":153,"context_line":"    def test_check_existing_image(self, mock_clients_glance):"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"        ctx \u003d self.existing_image_context"},{"line_number":156,"context_line":"        sahara_ctx \u003d sahara_image.SaharaImage(ctx)"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba3cc151_52604335","line":153,"in_reply_to":"ba3cc151_75953ce2","updated":"2015-07-09 20:25:11.000000000","message":"same here","commit_id":"aca1858e86bf619384d37ce144827805b966096b"}],"tests/unit/plugins/openstack/context/test_ceilometer.py":[{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"7af5e0fb0f113725247ab06a918b9fd75e9b9877","unresolved":false,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    def _gen_tenants(self, count):"},{"line_number":30,"context_line":"        tenants \u003d {}"},{"line_number":31,"context_line":"        for id_ in range(count):"},{"line_number":32,"context_line":"            tenants[str(id_)] \u003d {\"name\": str(id_)}"},{"line_number":33,"context_line":"        return tenants"},{"line_number":34,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"ba3cc151_a94eb335","line":31,"updated":"2015-07-09 09:56:28.000000000","message":"Replace L30-33 with dict comprehension:\n\n return {str(t_id): {\"name\": str(t_id)} for t_id in range(count)}","commit_id":"aca1858e86bf619384d37ce144827805b966096b"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"b730678ee8581f07fc19b7ffac469edf5c454f3b","unresolved":false,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    def _gen_tenants(self, count):"},{"line_number":30,"context_line":"        tenants \u003d {}"},{"line_number":31,"context_line":"        for id_ in range(count):"},{"line_number":32,"context_line":"            tenants[str(id_)] \u003d {\"name\": str(id_)}"},{"line_number":33,"context_line":"        return tenants"},{"line_number":34,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"ba3cc151_cd10d550","line":31,"in_reply_to":"ba3cc151_2a3927a4","updated":"2015-07-09 13:52:42.000000000","message":"Agreed","commit_id":"aca1858e86bf619384d37ce144827805b966096b"},{"author":{"_account_id":11748,"name":"Chris St. Pierre","email":"cstpierr@cisco.com","username":"stpierre"},"change_message_id":"a1db505b86d447204bd751b7c8f85a21b9532f15","unresolved":false,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    def _gen_tenants(self, count):"},{"line_number":30,"context_line":"        tenants \u003d {}"},{"line_number":31,"context_line":"        for id_ in range(count):"},{"line_number":32,"context_line":"            tenants[str(id_)] \u003d {\"name\": str(id_)}"},{"line_number":33,"context_line":"        return tenants"},{"line_number":34,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"ba3cc151_2a3927a4","line":31,"in_reply_to":"ba3cc151_a94eb335","updated":"2015-07-09 13:39:02.000000000","message":"Dict comprehensions don\u0027t exist in Python 2.6.","commit_id":"aca1858e86bf619384d37ce144827805b966096b"},{"author":{"_account_id":11748,"name":"Chris St. Pierre","email":"cstpierr@cisco.com","username":"stpierre"},"change_message_id":"e5d181588bba4edce2f923f886e40e6909b5273a","unresolved":false,"context_lines":[{"line_number":29,"context_line":"    def _gen_tenants(self, count):"},{"line_number":30,"context_line":"        tenants \u003d {}"},{"line_number":31,"context_line":"        for id_ in range(count):"},{"line_number":32,"context_line":"            tenants[str(id_)] \u003d {\"name\": str(id_)}"},{"line_number":33,"context_line":"        return tenants"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    def _gen_context(self, tenants_count, users_per_tenant,"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba3cc151_f5894ccb","line":32,"updated":"2015-07-07 19:22:00.000000000","message":"Here\u0027s a sort of strange example of where dict() could actually help us:\n\n    tenants \u003d dict([(str(i), {\"name\": str(i)}) for i in range(count)])","commit_id":"aca1858e86bf619384d37ce144827805b966096b"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"cd9c5b5c5ab349187876b0886fdf34cadebad17b","unresolved":false,"context_lines":[{"line_number":29,"context_line":"    def _gen_tenants(self, count):"},{"line_number":30,"context_line":"        tenants \u003d {}"},{"line_number":31,"context_line":"        for id_ in range(count):"},{"line_number":32,"context_line":"            tenants[str(id_)] \u003d {\"name\": str(id_)}"},{"line_number":33,"context_line":"        return tenants"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    def _gen_context(self, tenants_count, users_per_tenant,"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba3cc151_12d15bcd","line":32,"in_reply_to":"ba3cc151_f5894ccb","updated":"2015-07-09 20:25:11.000000000","message":"I don\u0027t think that it actually make big sense. \n\nThe more interesting idea that can help us to keep _gen_tenants somewhere in common place (or remove it if we don\u0027t need it actually)","commit_id":"aca1858e86bf619384d37ce144827805b966096b"}],"tests/unit/plugins/openstack/context/test_images.py":[{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"7af5e0fb0f113725247ab06a918b9fd75e9b9877","unresolved":false,"context_lines":[{"line_number":31,"context_line":"    def _gen_tenants(self, count):"},{"line_number":32,"context_line":"        tenants \u003d {}"},{"line_number":33,"context_line":"        for id_ in range(count):"},{"line_number":34,"context_line":"            tenants[str(id_)] \u003d {\"name\": str(id_)}"},{"line_number":35,"context_line":"        return tenants"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    @mock.patch(\"%s.images.context.Context.__init__\" % CTX)"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba3cc151_295b8387","line":34,"updated":"2015-07-09 09:56:28.000000000","message":"Dict comprehension would look better","commit_id":"aca1858e86bf619384d37ce144827805b966096b"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"b730678ee8581f07fc19b7ffac469edf5c454f3b","unresolved":false,"context_lines":[{"line_number":31,"context_line":"    def _gen_tenants(self, count):"},{"line_number":32,"context_line":"        tenants \u003d {}"},{"line_number":33,"context_line":"        for id_ in range(count):"},{"line_number":34,"context_line":"            tenants[str(id_)] \u003d {\"name\": str(id_)}"},{"line_number":35,"context_line":"        return tenants"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    @mock.patch(\"%s.images.context.Context.__init__\" % CTX)"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba3cc151_ed54b9fe","line":34,"in_reply_to":"ba3cc151_295b8387","updated":"2015-07-09 13:52:42.000000000","message":"Update: unfortunately dict comprehension does not exist in py2.6","commit_id":"aca1858e86bf619384d37ce144827805b966096b"}],"tests/unit/plugins/openstack/context/test_servers.py":[{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"7af5e0fb0f113725247ab06a918b9fd75e9b9877","unresolved":false,"context_lines":[{"line_number":31,"context_line":"    def _gen_tenants(self, count):"},{"line_number":32,"context_line":"        tenants \u003d {}"},{"line_number":33,"context_line":"        for id_ in range(count):"},{"line_number":34,"context_line":"            tenants[str(id_)] \u003d {\"name\": str(id_)}"},{"line_number":35,"context_line":"        return tenants"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    def test_init(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba3cc151_49c92725","line":34,"updated":"2015-07-09 09:56:28.000000000","message":"ditto","commit_id":"aca1858e86bf619384d37ce144827805b966096b"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"b730678ee8581f07fc19b7ffac469edf5c454f3b","unresolved":false,"context_lines":[{"line_number":31,"context_line":"    def _gen_tenants(self, count):"},{"line_number":32,"context_line":"        tenants \u003d {}"},{"line_number":33,"context_line":"        for id_ in range(count):"},{"line_number":34,"context_line":"            tenants[str(id_)] \u003d {\"name\": str(id_)}"},{"line_number":35,"context_line":"        return tenants"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    def test_init(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba3cc151_ad431141","line":34,"in_reply_to":"ba3cc151_49c92725","updated":"2015-07-09 13:52:42.000000000","message":"Update: unfortunately dict comprehension does not exist in py2.6","commit_id":"aca1858e86bf619384d37ce144827805b966096b"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"0c51f425bc900ec5b872128451494342e2fc4fe1","unresolved":false,"context_lines":[{"line_number":31,"context_line":"    def _gen_tenants(self, count):"},{"line_number":32,"context_line":"        tenants \u003d {}"},{"line_number":33,"context_line":"        for id_ in range(count):"},{"line_number":34,"context_line":"            tenants[str(id_)] \u003d {\"name\": str(id_)}"},{"line_number":35,"context_line":"        return tenants"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    def test_init(self):"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a41bdd9_5aeb83b0","line":34,"updated":"2015-07-14 11:28:04.000000000","message":"Is this a redundant refactor? If no, then such case exists in https://review.openstack.org/#/c/198956/4/tests/unit/plugins/openstack/context/test_stacks.py","commit_id":"050c7a7c0057b427ff3d6a9c8c7adc7f870b59ce"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"2d1e197f6914385a5445fecc7e6e113d7f77f6e6","unresolved":false,"context_lines":[{"line_number":31,"context_line":"    def _gen_tenants(self, count):"},{"line_number":32,"context_line":"        tenants \u003d {}"},{"line_number":33,"context_line":"        for id_ in range(count):"},{"line_number":34,"context_line":"            tenants[str(id_)] \u003d {\"name\": str(id_)}"},{"line_number":35,"context_line":"        return tenants"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    def test_init(self):"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a41bdd9_04c02a29","line":34,"in_reply_to":"9a41bdd9_5aeb83b0","updated":"2015-07-14 18:43:02.000000000","message":"I would prefer to keep it here. \nFixing bad things in code shouldn\u0027t be blocker (even if they are offtopic)","commit_id":"050c7a7c0057b427ff3d6a9c8c7adc7f870b59ce"}],"tests/unit/plugins/openstack/scenarios/cinder/test_volumes.py":[{"author":{"_account_id":11748,"name":"Chris St. Pierre","email":"cstpierr@cisco.com","username":"stpierre"},"change_message_id":"e5d181588bba4edce2f923f886e40e6909b5273a","unresolved":false,"context_lines":[{"line_number":384,"context_line":"                              \"endpoint\": mock.MagicMock()},"},{"line_number":385,"context_line":"                     \"users\": [{\"tenant_id\": \"fake\", \"users_per_tenant\": 1}],"},{"line_number":386,"context_line":"                     \"tenant\": {\"id\": \"fake\", \"name\": \"fake\","},{"line_number":387,"context_line":"                                \"servers\": [fake_server.uuid]}})"},{"line_number":388,"context_line":""},{"line_number":389,"context_line":"        scenario.get_random_server \u003d mock.MagicMock(return_value\u003dfake_server)"},{"line_number":390,"context_line":"        scenario._attach_volume \u003d mock.MagicMock()"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba3cc151_0042703e","line":387,"updated":"2015-07-07 19:22:00.000000000","message":"This block of six lines, differing only in the server list, is used 9 times in this file. Time to make it a function.","commit_id":"aca1858e86bf619384d37ce144827805b966096b"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"cd9c5b5c5ab349187876b0886fdf34cadebad17b","unresolved":false,"context_lines":[{"line_number":384,"context_line":"                              \"endpoint\": mock.MagicMock()},"},{"line_number":385,"context_line":"                     \"users\": [{\"tenant_id\": \"fake\", \"users_per_tenant\": 1}],"},{"line_number":386,"context_line":"                     \"tenant\": {\"id\": \"fake\", \"name\": \"fake\","},{"line_number":387,"context_line":"                                \"servers\": [fake_server.uuid]}})"},{"line_number":388,"context_line":""},{"line_number":389,"context_line":"        scenario.get_random_server \u003d mock.MagicMock(return_value\u003dfake_server)"},{"line_number":390,"context_line":"        scenario._attach_volume \u003d mock.MagicMock()"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba3cc151_b2e0af97","line":387,"in_reply_to":"ba3cc151_0042703e","updated":"2015-07-09 20:25:11.000000000","message":"Seems you are right\u003d)","commit_id":"aca1858e86bf619384d37ce144827805b966096b"}],"tests/unit/plugins/openstack/scenarios/keystone/test_basic.py":[{"author":{"_account_id":11748,"name":"Chris St. Pierre","email":"cstpierr@cisco.com","username":"stpierre"},"change_message_id":"e5d181588bba4edce2f923f886e40e6909b5273a","unresolved":false,"context_lines":[{"line_number":32,"context_line":"                \"endpoint\": mock.MagicMock()"},{"line_number":33,"context_line":"            },"},{"line_number":34,"context_line":"            \"tenant\": {\"id\": \"fake_tenant_id\"}"},{"line_number":35,"context_line":"        }"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    @mock.patch(\"rally.common.utils.generate_random_name\")"},{"line_number":38,"context_line":"    def test_create_user(self, mock_generate_random_name):"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba3cc151_8074409c","line":35,"updated":"2015-07-07 19:22:00.000000000","message":"Similar to this. :)","commit_id":"aca1858e86bf619384d37ce144827805b966096b"}],"tests/unit/plugins/openstack/scenarios/sahara/test_utils.py":[{"author":{"_account_id":11748,"name":"Chris St. Pierre","email":"cstpierr@cisco.com","username":"stpierre"},"change_message_id":"e5d181588bba4edce2f923f886e40e6909b5273a","unresolved":false,"context_lines":[{"line_number":138,"context_line":"            }"},{"line_number":139,"context_line":"        }"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"        self.clients(\"services\").values.return_value \u003d {"},{"line_number":142,"context_line":"            \"neutron\": consts.Service.NEUTRON"},{"line_number":143,"context_line":"        }"},{"line_number":144,"context_line":"        scenario \u003d utils.SaharaScenario(context\u003dcontext)"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba3cc151_4041580a","line":141,"updated":"2015-07-07 19:22:00.000000000","message":"This looks wrong to me. values() should just return a list of service constants, not a dict; self.clients(\"services\") returns the dict.","commit_id":"aca1858e86bf619384d37ce144827805b966096b"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"cd9c5b5c5ab349187876b0886fdf34cadebad17b","unresolved":false,"context_lines":[{"line_number":138,"context_line":"            }"},{"line_number":139,"context_line":"        }"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"        self.clients(\"services\").values.return_value \u003d {"},{"line_number":142,"context_line":"            \"neutron\": consts.Service.NEUTRON"},{"line_number":143,"context_line":"        }"},{"line_number":144,"context_line":"        scenario \u003d utils.SaharaScenario(context\u003dcontext)"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba3cc151_6b7e3f1a","line":141,"in_reply_to":"ba3cc151_4041580a","updated":"2015-07-09 20:25:11.000000000","message":"It is how Ceilometer works.","commit_id":"aca1858e86bf619384d37ce144827805b966096b"},{"author":{"_account_id":11748,"name":"Chris St. Pierre","email":"cstpierr@cisco.com","username":"stpierre"},"change_message_id":"29b54be595906c45cd36ec51844b15a8a9952ccf","unresolved":false,"context_lines":[{"line_number":138,"context_line":"            }"},{"line_number":139,"context_line":"        }"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"        self.clients(\"services\").values.return_value \u003d {"},{"line_number":142,"context_line":"            \"neutron\": consts.Service.NEUTRON"},{"line_number":143,"context_line":"        }"},{"line_number":144,"context_line":"        scenario \u003d utils.SaharaScenario(context\u003dcontext)"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba3cc151_f36241ac","line":141,"updated":"2015-07-09 20:52:51.000000000","message":"Ceilometer doesn\u0027t have anything to do with this. The line of code being mocked out is:\n\n    if consts.Service.NEUTRON in self.clients(\"services\").values():\n\nself.clients(\"services\") isn\u0027t a real client; it\u0027s a function that returns a dict of {service_type: service_name}. So self.clients(\"services\").values() should return a list of service names.\n\nInstead, this mocks it out so that self.clients(\"services\").values() returns a dict of {service_type: service_name}. The tests work because, coincidentally, in this case, the service type is the same as the service name -- both are \"neutron.\" But in other cases it will not work; the \"computev3\" service type maps to the \"novav3\" service name, for instance.\n\nThis should be:\n\n    self.clients(\"services\").return_value \u003d {\"neutron\": consts.Service.NEUTRON}\n\nOr, if you prefer:\n\n    self.clients(\"services\").values.return_value \u003d [consts.Service.NEUTRON]","commit_id":"d1eb92d7e2f930b96aeb9436174f4f59366d1c0b"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"8c4584359b74ed4fe0b0ee6b99ba799fb585ac1f","unresolved":false,"context_lines":[{"line_number":138,"context_line":"            }"},{"line_number":139,"context_line":"        }"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"        self.clients(\"services\").values.return_value \u003d {"},{"line_number":142,"context_line":"            \"neutron\": consts.Service.NEUTRON"},{"line_number":143,"context_line":"        }"},{"line_number":144,"context_line":"        scenario \u003d utils.SaharaScenario(context\u003dcontext)"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba3cc151_cfa7490a","line":141,"in_reply_to":"ba3cc151_f36241ac","updated":"2015-07-10 02:30:15.000000000","message":"uh sorry","commit_id":"d1eb92d7e2f930b96aeb9436174f4f59366d1c0b"}]}
