)]}'
{"install_rally.sh":[{"author":{"_account_id":11748,"name":"Chris St. Pierre","email":"cstpierr@cisco.com","username":"stpierre"},"change_message_id":"06a0f73400d3a59fa50c34c7bc06a19133b95b54","unresolved":false,"context_lines":[{"line_number":313,"context_line":"            cat \u003c\u003c__EOF__"},{"line_number":314,"context_line":"In order to install the required software you would need to run as"},{"line_number":315,"context_line":"\u0027root\u0027 the following command:"},{"line_number":316,"context_line":""},{"line_number":317,"context_line":"    $pkg_manager $missing"},{"line_number":318,"context_line":""},{"line_number":319,"context_line":"__EOF__"}],"source_content_type":"text/x-sh","patch_set":1,"id":"ba3cc151_403b98eb","side":"PARENT","line":316,"updated":"2015-07-07 19:39:02.000000000","message":"The whitespace before the $pkg_manager command makes it stand out from the error message. Why did you remove it?","commit_id":"b683121536fb32bbee7e4ab982723d27ac86ec11"},{"author":{"_account_id":11748,"name":"Chris St. Pierre","email":"cstpierr@cisco.com","username":"stpierre"},"change_message_id":"06a0f73400d3a59fa50c34c7bc06a19133b95b54","unresolved":false,"context_lines":[{"line_number":22,"context_line":"OVERWRITEDIR\u003d\"ask\""},{"line_number":23,"context_line":"USEVIRTUALENV\u003d\"yes\""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"# ansi colors for formatting heredoc "},{"line_number":26,"context_line":"e\u003d$(printf \"\\e\")"},{"line_number":27,"context_line":"GREEN\u003d\"$e[0;32m\""},{"line_number":28,"context_line":"NO_COLOR\u003d\"$e[0;0m\""}],"source_content_type":"text/x-sh","patch_set":1,"id":"ba3cc151_c0aa4819","line":25,"updated":"2015-07-07 19:39:02.000000000","message":"Trailing whitespace.","commit_id":"e720eaac4b2da2a6923d90afd9963d3902be258d"},{"author":{"_account_id":11748,"name":"Chris St. Pierre","email":"cstpierr@cisco.com","username":"stpierre"},"change_message_id":"06a0f73400d3a59fa50c34c7bc06a19133b95b54","unresolved":false,"context_lines":[{"line_number":23,"context_line":"USEVIRTUALENV\u003d\"yes\""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"# ansi colors for formatting heredoc "},{"line_number":26,"context_line":"e\u003d$(printf \"\\e\")"},{"line_number":27,"context_line":"GREEN\u003d\"$e[0;32m\""},{"line_number":28,"context_line":"NO_COLOR\u003d\"$e[0;0m\""},{"line_number":29,"context_line":"RED\u003d\"$e[0;31m\""}],"source_content_type":"text/x-sh","patch_set":1,"id":"ba3cc151_00b1108f","line":26,"updated":"2015-07-07 19:39:02.000000000","message":"Single-character variable names are the devil.","commit_id":"e720eaac4b2da2a6923d90afd9963d3902be258d"},{"author":{"_account_id":11748,"name":"Chris St. Pierre","email":"cstpierr@cisco.com","username":"stpierre"},"change_message_id":"06a0f73400d3a59fa50c34c7bc06a19133b95b54","unresolved":false,"context_lines":[{"line_number":89,"context_line":"  header\u003d\"$2\""},{"line_number":90,"context_line":"  shift 2"},{"line_number":91,"context_line":"  cat 1\u003e\u00262 \u003c\u003c__EOF__"},{"line_number":92,"context_line":"$RED"},{"line_number":93,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":94,"context_line":"$PROG: ERROR: $header"},{"line_number":95,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-sh","patch_set":1,"id":"ba3cc151_c081e890","line":92,"updated":"2015-07-07 19:39:02.000000000","message":"This adds an extra newline before the overline. Instead, do:\n\n      cat 1\u003e\u00262 \u003c\u003c__EOF__\n    $RED\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\n    ...\n    __EOF__","commit_id":"e720eaac4b2da2a6923d90afd9963d3902be258d"},{"author":{"_account_id":11748,"name":"Chris St. Pierre","email":"cstpierr@cisco.com","username":"stpierre"},"change_message_id":"06a0f73400d3a59fa50c34c7bc06a19133b95b54","unresolved":false,"context_lines":[{"line_number":112,"context_line":"script to help us identifying the problem."},{"line_number":113,"context_line":"$RED"},{"line_number":114,"context_line":"Aborting installation!"},{"line_number":115,"context_line":"$NO_COLOR"},{"line_number":116,"context_line":"__EOF__"},{"line_number":117,"context_line":"  exit \"$rc\""},{"line_number":118,"context_line":"}"}],"source_content_type":"text/x-sh","patch_set":1,"id":"ba3cc151_4044f872","line":115,"updated":"2015-07-07 19:39:02.000000000","message":"Another added newline. There are bunch of these, so I won\u0027t point them all out.","commit_id":"e720eaac4b2da2a6923d90afd9963d3902be258d"},{"author":{"_account_id":11748,"name":"Chris St. Pierre","email":"cstpierr@cisco.com","username":"stpierre"},"change_message_id":"06a0f73400d3a59fa50c34c7bc06a19133b95b54","unresolved":false,"context_lines":[{"line_number":160,"context_line":"$GREEN  -h, --help       $NO_COLOR     Print this help text"},{"line_number":161,"context_line":"$GREEN  -v, --verbose    $NO_COLOR     Verbose mode"},{"line_number":162,"context_line":"$GREEN  -s, --system     $NO_COLOR     Install system-wide."},{"line_number":163,"context_line":"$GREEN  -d, --target     $NO_COLOR     DIRECTORY     Install Rally virtual environment into DIRECTORY."},{"line_number":164,"context_line":"                                                     (Default: $HOME/rally if not root)."},{"line_number":165,"context_line":"$GREEN  -f, --overwrite  $NO_COLOR     Remove target directory if it already exists."},{"line_number":166,"context_line":"$GREEN  -y, --yes        $NO_COLOR     Do not ask for confirmation: assume a \u0027yes\u0027 reply"}],"source_content_type":"text/x-sh","patch_set":1,"id":"ba3cc151_60a25c4d","line":163,"updated":"2015-07-07 19:39:02.000000000","message":"The way you\u0027ve formatted options that accept arguments throws off the alignment of the help. It also makes a number of the lines in the help very, very long indeed.","commit_id":"e720eaac4b2da2a6923d90afd9963d3902be258d"},{"author":{"_account_id":11748,"name":"Chris St. Pierre","email":"cstpierr@cisco.com","username":"stpierre"},"change_message_id":"06a0f73400d3a59fa50c34c7bc06a19133b95b54","unresolved":false,"context_lines":[{"line_number":161,"context_line":"$GREEN  -v, --verbose    $NO_COLOR     Verbose mode"},{"line_number":162,"context_line":"$GREEN  -s, --system     $NO_COLOR     Install system-wide."},{"line_number":163,"context_line":"$GREEN  -d, --target     $NO_COLOR     DIRECTORY     Install Rally virtual environment into DIRECTORY."},{"line_number":164,"context_line":"                                                     (Default: $HOME/rally if not root)."},{"line_number":165,"context_line":"$GREEN  -f, --overwrite  $NO_COLOR     Remove target directory if it already exists."},{"line_number":166,"context_line":"$GREEN  -y, --yes        $NO_COLOR     Do not ask for confirmation: assume a \u0027yes\u0027 reply"},{"line_number":167,"context_line":"                                       to every question."}],"source_content_type":"text/x-sh","patch_set":1,"id":"ba3cc151_a0bf045f","line":164,"updated":"2015-07-07 19:39:02.000000000","message":"The alignment of subsequent lines is also wrong, since $GREEN and $NO_COLOR are zero-width when expanded.","commit_id":"e720eaac4b2da2a6923d90afd9963d3902be258d"},{"author":{"_account_id":11748,"name":"Chris St. Pierre","email":"cstpierr@cisco.com","username":"stpierre"},"change_message_id":"06a0f73400d3a59fa50c34c7bc06a19133b95b54","unresolved":false,"context_lines":[{"line_number":404,"context_line":"Run \u0027deactivate\u0027, then run this script again."},{"line_number":405,"context_line":"$NO_COLOR"},{"line_number":406,"context_line":"__EOF__"},{"line_number":407,"context_line":"        exit $EX_SOFTWARE"},{"line_number":408,"context_line":"    fi"},{"line_number":409,"context_line":""},{"line_number":410,"context_line":"    # Use the latest virtualenv that can use `.tar.gz` files"}],"source_content_type":"text/x-sh","patch_set":1,"id":"ba3cc151_2008d42c","line":407,"updated":"2015-07-07 19:39:02.000000000","message":"Scope creep: It seems like this whole if block should just use die().","commit_id":"e720eaac4b2da2a6923d90afd9963d3902be258d"},{"author":{"_account_id":11748,"name":"Chris St. Pierre","email":"cstpierr@cisco.com","username":"stpierre"},"change_message_id":"06a0f73400d3a59fa50c34c7bc06a19133b95b54","unresolved":false,"context_lines":[{"line_number":752,"context_line":"  * Virtual Environment at: $VENVDIR"},{"line_number":753,"context_line":"  * Database at: $RALLY_DATABASE_DIR"},{"line_number":754,"context_line":"  * Configuration file at: $RALLY_CONFIGURATION_DIR"},{"line_number":755,"context_line":"$NO_COLOR"},{"line_number":756,"context_line":"__EOF__"},{"line_number":757,"context_line":"    setup_rally_configuration \"$SOURCEDIR\""},{"line_number":758,"context_line":"else"}],"source_content_type":"text/x-sh","patch_set":1,"id":"ba3cc151_3b20059b","line":755,"updated":"2015-07-07 19:39:02.000000000","message":"Making this whole thing green just makes it look like a fruit salad. I\u0027d suggest instead making the header green (to match the red header of errors), and perhaps the values in the \"Information about...\" section at the end.","commit_id":"e720eaac4b2da2a6923d90afd9963d3902be258d"},{"author":{"_account_id":11748,"name":"Chris St. Pierre","email":"cstpierr@cisco.com","username":"stpierre"},"change_message_id":"06a0f73400d3a59fa50c34c7bc06a19133b95b54","unresolved":false,"context_lines":[{"line_number":774,"context_line":"  * Method: system"},{"line_number":775,"context_line":"  * Database at: $RALLY_DATABASE_DIR"},{"line_number":776,"context_line":"  * Configuration file at: $RALLY_CONFIGURATION_DIR"},{"line_number":777,"context_line":"$NO_COLOR"},{"line_number":778,"context_line":"__EOF__"},{"line_number":779,"context_line":"fi"}],"source_content_type":"text/x-sh","patch_set":1,"id":"ba3cc151_5b2389a7","line":777,"updated":"2015-07-07 19:39:02.000000000","message":"Same here.","commit_id":"e720eaac4b2da2a6923d90afd9963d3902be258d"},{"author":{"_account_id":11748,"name":"Chris St. Pierre","email":"cstpierr@cisco.com","username":"stpierre"},"change_message_id":"e07a2b6ad9ba788d453bb2f751a6791b9368b2f7","unresolved":false,"context_lines":[{"line_number":72,"context_line":"#"},{"line_number":73,"context_line":"abort () {"},{"line_number":74,"context_line":"  local rc\u003d\"$1\""},{"line_number":75,"context_line":"  shift"},{"line_number":76,"context_line":"  (echo -n \"$PROG: ERROR: \";"},{"line_number":77,"context_line":"      if [ $# -gt 0 ]; then echo \"$@\"; else cat; fi) 1\u003e\u00262"},{"line_number":78,"context_line":"  exit \"$rc\""}],"source_content_type":"text/x-sh","patch_set":2,"id":"ba3cc151_5012830a","line":75,"updated":"2015-07-07 20:41:05.000000000","message":"We should colorize this error, too. Yay for two different ways to exit with an error....","commit_id":"be3d0e644115be11cbba96c645b27faf11157d68"},{"author":{"_account_id":11748,"name":"Chris St. Pierre","email":"cstpierr@cisco.com","username":"stpierre"},"change_message_id":"ad3841f5ae3b8d9195938d59fef419b3165e8577","unresolved":false,"context_lines":[{"line_number":166,"context_line":"$GREEN  -D, --dbtype TYPE     $NO_COLOR Select the database type. TYPE can be one of"},{"line_number":167,"context_line":"                         \u0027sqlite\u0027, \u0027mysql\u0027, \u0027postgres\u0027."},{"line_number":168,"context_line":"                         Default: sqlite"},{"line_number":169,"context_line":"$GREEN --db-user USER        $NO_COLOR Database user to use. Only used when --dbtype"},{"line_number":170,"context_line":"                         is either \u0027mysql\u0027 or \u0027postgres\u0027."},{"line_number":171,"context_line":"$GREEN  --db-password PASSWORD$NO_COLOR Password of the database user. Only used when"},{"line_number":172,"context_line":"                         --dbtype is either \u0027mysql\u0027 or \u0027postgres\u0027."}],"source_content_type":"text/x-sh","patch_set":2,"id":"ba3cc151_cda8407a","line":169,"updated":"2015-07-07 20:39:18.000000000","message":"Need one more space between $GREEN and --db-user on this line.","commit_id":"be3d0e644115be11cbba96c645b27faf11157d68"},{"author":{"_account_id":11748,"name":"Chris St. Pierre","email":"cstpierr@cisco.com","username":"stpierre"},"change_message_id":"ad3841f5ae3b8d9195938d59fef419b3165e8577","unresolved":false,"context_lines":[{"line_number":752,"context_line":"  * Virtual Environment at: $VENVDIR"},{"line_number":753,"context_line":"  * Database at: $RALLY_DATABASE_DIR"},{"line_number":754,"context_line":"  * Configuration file at: $RALLY_CONFIGURATION_DIR"},{"line_number":755,"context_line":"$NO_COLOR"},{"line_number":756,"context_line":"__EOF__"},{"line_number":757,"context_line":"    setup_rally_configuration \"$SOURCEDIR\""},{"line_number":758,"context_line":"else"}],"source_content_type":"text/x-sh","patch_set":2,"id":"ba3cc151_70d0e753","line":755,"updated":"2015-07-07 20:39:18.000000000","message":"For these I was thinking something more like:\n\n    * Method:$GREEN virtualenv$NO_COLOR\n    * Virtual environment at:$GREEN $VENVDIR$NO_COLOR\n\netc., to draw out the interesting values.","commit_id":"be3d0e644115be11cbba96c645b27faf11157d68"}]}
