)]}'
{"rally/plugins/openstack/context/cleanup/manager.py":[{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"6e7fb358b9726a9acc3b0f9af5d4b7ac8f79ffbf","unresolved":false,"context_lines":[{"line_number":77,"context_line":"            \"resource\": resource._resource"},{"line_number":78,"context_line":"        }"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"        LOG.debug(\"Deleting %(service)s %(resource)s object %(uuid)s\" %"},{"line_number":81,"context_line":"                  msg_kw)"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba3cc151_977676a2","line":80,"updated":"2015-07-09 02:00:52.000000000","message":"could you add _(\"...\")?","commit_id":"a533e3811f6ab845a0b0513c7e5aae0fd42124aa"},{"author":{"_account_id":11748,"name":"Chris St. Pierre","email":"cstpierr@cisco.com","username":"stpierre"},"change_message_id":"5226f21be17fce2917d8d17ca5bc108ef43116e2","unresolved":false,"context_lines":[{"line_number":77,"context_line":"            \"resource\": resource._resource"},{"line_number":78,"context_line":"        }"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"        LOG.debug(\"Deleting %(service)s %(resource)s object %(uuid)s\" %"},{"line_number":81,"context_line":"                  msg_kw)"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba3cc151_d848912f","line":80,"in_reply_to":"ba3cc151_977676a2","updated":"2015-07-09 14:14:33.000000000","message":"Debug logs should not be translated: https://github.com/openstack/rally/blob/master/tests/hacking/checks.py#L151-L166","commit_id":"a533e3811f6ab845a0b0513c7e5aae0fd42124aa"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"ef58164cd0dca275ca56b7992eb13204cfcb5cdd","unresolved":false,"context_lines":[{"line_number":77,"context_line":"            \"resource\": resource._resource"},{"line_number":78,"context_line":"        }"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"        LOG.debug(\"Deleting %(service)s %(resource)s object %(uuid)s\" %"},{"line_number":81,"context_line":"                  msg_kw)"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba3cc151_4649e6b6","line":80,"in_reply_to":"ba3cc151_d848912f","updated":"2015-07-10 00:31:07.000000000","message":"Right, thanks for clarify.","commit_id":"a533e3811f6ab845a0b0513c7e5aae0fd42124aa"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"6e7fb358b9726a9acc3b0f9af5d4b7ac8f79ffbf","unresolved":false,"context_lines":[{"line_number":275,"context_line":"                  }"},{"line_number":276,"context_line":"    \"\"\""},{"line_number":277,"context_line":"    for manager in find_resource_managers(names, admin_required):"},{"line_number":278,"context_line":"        LOG.debug(\"Cleaning up %(service)s %(resource)s objects\" %"},{"line_number":279,"context_line":"                  {\"service\": manager._service,"},{"line_number":280,"context_line":"                   \"resource\": manager._resource})"},{"line_number":281,"context_line":"        SeekAndDestroy(manager, admin, users).exterminate()"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba3cc151_576c6ecf","line":278,"updated":"2015-07-09 02:00:52.000000000","message":"same here.","commit_id":"a533e3811f6ab845a0b0513c7e5aae0fd42124aa"}],"rally/plugins/openstack/scenarios/keystone/basic.py":[{"author":{"_account_id":6835,"name":"Kun Huang","email":"gareth@openstacker.org","username":"academicgareth"},"change_message_id":"1a97c62d4491bcb48bf4f2b793a509cf5ed11207","unresolved":false,"context_lines":[{"line_number":156,"context_line":""},{"line_number":157,"context_line":"    @validation.required_openstack(admin\u003dTrue)"},{"line_number":158,"context_line":"    @base.scenario(context\u003d{\"admin_cleanup\": [\"keystone\"]})"},{"line_number":159,"context_line":"    def create_and_delete_service(self, service_type\u003dNone, description\u003dNone):"},{"line_number":160,"context_line":"        \"\"\"Create and delete service."},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"        :param service_type: type of the service"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a41bdd9_edd43548","line":159,"updated":"2015-07-14 02:16:49.000000000","message":"one question: do you think whether we should keep back-compatibility here? Users\u0027 old task file will contain the \u0027name\u0027 word which will break this function call here.","commit_id":"69256f58cf329db5a10855e29fe05a782b0cbc19"},{"author":{"_account_id":11748,"name":"Chris St. Pierre","email":"cstpierr@cisco.com","username":"stpierre"},"change_message_id":"1538b4a7f8702fea607cd17ddddac0cad493832f","unresolved":false,"context_lines":[{"line_number":156,"context_line":""},{"line_number":157,"context_line":"    @validation.required_openstack(admin\u003dTrue)"},{"line_number":158,"context_line":"    @base.scenario(context\u003d{\"admin_cleanup\": [\"keystone\"]})"},{"line_number":159,"context_line":"    def create_and_delete_service(self, service_type\u003dNone, description\u003dNone):"},{"line_number":160,"context_line":"        \"\"\"Create and delete service."},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"        :param service_type: type of the service"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a41bdd9_a8137b0c","line":159,"in_reply_to":"9a41bdd9_edd43548","updated":"2015-07-14 02:52:07.000000000","message":"Done","commit_id":"69256f58cf329db5a10855e29fe05a782b0cbc19"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"c81af5d3d911bd1fae2c8a0bfce96d5fb62fa151","unresolved":false,"context_lines":[{"line_number":199,"context_line":""},{"line_number":200,"context_line":"    @validation.required_openstack(admin\u003dTrue)"},{"line_number":201,"context_line":"    @utils.log_deprecated_args("},{"line_number":202,"context_line":"        \"The \u0027name\u0027 argument to create_and_delete_service will be ignored\","},{"line_number":203,"context_line":"        \"0.0.5\", [\"name\"])"},{"line_number":204,"context_line":"    @base.scenario(context\u003d{\"admin_cleanup\": [\"keystone\"]})"},{"line_number":205,"context_line":"    def create_and_list_services(self, name\u003dNone, service_type\u003dNone,"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a41bdd9_ce182678","line":202,"updated":"2015-07-14 16:28:09.000000000","message":"s/create_and_delete_service/create_and_list_services/","commit_id":"deef39ab559467dcaf3e62d7eefe407c59585c9a"}],"rally/plugins/openstack/scenarios/keystone/utils.py":[{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"7545ad23ceaf3ca1fa51bfb1e51941e84eb1dee2","unresolved":false,"context_lines":[{"line_number":72,"context_line":"        :param description: description of the service"},{"line_number":73,"context_line":"        :returns: keystone service instance"},{"line_number":74,"context_line":"        \"\"\""},{"line_number":75,"context_line":"        if name and name.startswith(self.RESOURCE_NAME_PREFIX):"},{"line_number":76,"context_line":"            name \u003d name"},{"line_number":77,"context_line":"        elif name:"},{"line_number":78,"context_line":"            name \u003d self.RESOURCE_NAME_PREFIX + name"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba3cc151_cfe989b9","line":75,"updated":"2015-07-10 02:26:50.000000000","message":"IMHO we should not allow people to specify name of resources via task configuration this is source of errors.","commit_id":"8129a4f2223ccc50240779bc64723bfefcd2d6fa"},{"author":{"_account_id":6835,"name":"Kun Huang","email":"gareth@openstacker.org","username":"academicgareth"},"change_message_id":"1a97c62d4491bcb48bf4f2b793a509cf5ed11207","unresolved":false,"context_lines":[{"line_number":75,"context_line":"        description \u003d description or self._generate_random_name("},{"line_number":76,"context_line":"            prefix\u003d\"rally_test_service_description_\")"},{"line_number":77,"context_line":"        return self.admin_clients(\"keystone\").services.create("},{"line_number":78,"context_line":"            self._generate_random_name(),"},{"line_number":79,"context_line":"            service_type, description)"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"    @base.atomic_action_timer(\"keystone.create_users\")"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a41bdd9_cd837155","line":78,"updated":"2015-07-14 02:16:49.000000000","message":"missing prefix here?","commit_id":"69256f58cf329db5a10855e29fe05a782b0cbc19"},{"author":{"_account_id":11748,"name":"Chris St. Pierre","email":"cstpierr@cisco.com","username":"stpierre"},"change_message_id":"1538b4a7f8702fea607cd17ddddac0cad493832f","unresolved":false,"context_lines":[{"line_number":75,"context_line":"        description \u003d description or self._generate_random_name("},{"line_number":76,"context_line":"            prefix\u003d\"rally_test_service_description_\")"},{"line_number":77,"context_line":"        return self.admin_clients(\"keystone\").services.create("},{"line_number":78,"context_line":"            self._generate_random_name(),"},{"line_number":79,"context_line":"            service_type, description)"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"    @base.atomic_action_timer(\"keystone.create_users\")"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a41bdd9_081ce710","line":78,"in_reply_to":"9a41bdd9_cd837155","updated":"2015-07-14 02:52:07.000000000","message":"If no prefix is supplied the class RESOURCE_NAME_PREFIX variable is used: https://github.com/openstack/rally/blob/master/rally/task/scenarios/base.py#L69","commit_id":"69256f58cf329db5a10855e29fe05a782b0cbc19"}],"samples/tasks/scenarios/keystone/create-and-delete-service.json":[{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"6e7fb358b9726a9acc3b0f9af5d4b7ac8f79ffbf","unresolved":false,"context_lines":[{"line_number":2,"context_line":"    \"KeystoneBasic.create_and_delete_service\": ["},{"line_number":3,"context_line":"    {"},{"line_number":4,"context_line":"            \"args\": {"},{"line_number":5,"context_line":"                \"name\": \"Rally_test_service\","},{"line_number":6,"context_line":"                \"service_type\": \"Rally_test_type\","},{"line_number":7,"context_line":"                \"description\": \"test_description\""},{"line_number":8,"context_line":"            },"}],"source_content_type":"application/json","patch_set":1,"id":"ba3cc151_970756c9","line":5,"updated":"2015-07-09 02:00:52.000000000","message":"Using \u0027rally_keystone_test_service\u0027 would be nice, otherwise name will beome \u0027rally_keystone_Rally_test_service\u0027, seems strange.","commit_id":"a533e3811f6ab845a0b0513c7e5aae0fd42124aa"},{"author":{"_account_id":11748,"name":"Chris St. Pierre","email":"cstpierr@cisco.com","username":"stpierre"},"change_message_id":"5226f21be17fce2917d8d17ca5bc108ef43116e2","unresolved":false,"context_lines":[{"line_number":2,"context_line":"    \"KeystoneBasic.create_and_delete_service\": ["},{"line_number":3,"context_line":"    {"},{"line_number":4,"context_line":"            \"args\": {"},{"line_number":5,"context_line":"                \"name\": \"Rally_test_service\","},{"line_number":6,"context_line":"                \"service_type\": \"Rally_test_type\","},{"line_number":7,"context_line":"                \"description\": \"test_description\""},{"line_number":8,"context_line":"            },"}],"source_content_type":"application/json","patch_set":1,"id":"ba3cc151_f80c75ed","line":5,"in_reply_to":"ba3cc151_970756c9","updated":"2015-07-09 14:14:33.000000000","message":"Done","commit_id":"a533e3811f6ab845a0b0513c7e5aae0fd42124aa"}]}
