)]}'
{"doc/specs/in-progress/consistent_resource_names.rst":[{"author":{"_account_id":1980,"name":"jose-idar","email":"jose.idar@gmail.com","username":"jose-idar"},"change_message_id":"26786c5a46eb9d09758cb25d7d73e61be5b1f5a7","unresolved":false,"context_lines":[{"line_number":38,"context_line":"All resources created by Rally will have the same name"},{"line_number":39,"context_line":"prefix. Following the name prefix, there will be two random elements:"},{"line_number":40,"context_line":"one that will be the same for all resources created by a task, and one"},{"line_number":41,"context_line":"that will be unique for all resources."},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"These will be configured by three settings in `rally.conf`::"},{"line_number":44,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"3a50d1a3_f7654944","line":41,"updated":"2015-07-23 17:49:11.000000000","message":"It seems that it would make more sense to just register the resources created by tasks at the time of their creation, perhaps saving them to a file for cleanup later.","commit_id":"78d8a840c6219359397bd2703275fcfbe324c3a8"},{"author":{"_account_id":11748,"name":"Chris St. Pierre","email":"cstpierr@cisco.com","username":"stpierre"},"change_message_id":"1271bd0d7bd2d820601f36eb9ef275675c4df03b","unresolved":false,"context_lines":[{"line_number":38,"context_line":"All resources created by Rally will have the same name"},{"line_number":39,"context_line":"prefix. Following the name prefix, there will be two random elements:"},{"line_number":40,"context_line":"one that will be the same for all resources created by a task, and one"},{"line_number":41,"context_line":"that will be unique for all resources."},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"These will be configured by three settings in `rally.conf`::"},{"line_number":44,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"3a50d1a3_1a19fc21","line":41,"in_reply_to":"3a50d1a3_f7654944","updated":"2015-07-23 18:03:56.000000000","message":"That would be simpler, but that idea has already been floated (and rejected) because if you lose the file then you lose with it the possibility for cleanup. I\u0027ll add an explanation of this to the \"Alternatives\" section.","commit_id":"78d8a840c6219359397bd2703275fcfbe324c3a8"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"8f7f6ec6db1eace459766d6f41fb3ba76b835c71","unresolved":false,"context_lines":[{"line_number":40,"context_line":"one that will be the same for all resources created by a task, and one"},{"line_number":41,"context_line":"that will be unique for all resources."},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"These will be configured by three settings in `rally.conf`::"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    resource_name_format \u003d rally_XXXXXXXX_XXXXXXXX"},{"line_number":46,"context_line":"    context_resource_name_format \u003d rally_ctx_XXXXXXXX_XXXXXXXX"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9a41bdd9_3124935e","line":43,"updated":"2015-07-14 16:45:35.000000000","message":"As far as I understand, this approach makes name format fixed for all tasks.\n\nHowever rally is on its way to be universal benchmarking tool (and even some OpenStack components have specific limitations to resource names), so, I think, we need an ability go generate name with arbitrary format, for example use digits only, or start name with non-numeric char","commit_id":"78d8a840c6219359397bd2703275fcfbe324c3a8"},{"author":{"_account_id":8840,"name":"Carlos L. Torres","email":"carlos.torres@rackspace.com","username":"carl6796"},"change_message_id":"da089e25c9865a5160200decdadb5b7444d2ba1d","unresolved":false,"context_lines":[{"line_number":40,"context_line":"one that will be the same for all resources created by a task, and one"},{"line_number":41,"context_line":"that will be unique for all resources."},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"These will be configured by three settings in `rally.conf`::"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    resource_name_format \u003d rally_XXXXXXXX_XXXXXXXX"},{"line_number":46,"context_line":"    context_resource_name_format \u003d rally_ctx_XXXXXXXX_XXXXXXXX"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9a41bdd9_c106b41c","line":43,"in_reply_to":"9a41bdd9_3124935e","updated":"2015-07-14 18:14:57.000000000","message":"I agree with you Alexander, but shouldn\u0027t we just wait until that scenario comes up? As of now, the only implementation, and use, of Rally is for OpenStack, IMHO we should just wait until there\u0027s another system that we implement support for on Rally. \n\nFor me these 3 configs are good enough for now. Personally, I refrain of unnecessary abstractions and complexity until they are needed, because YAGNI. Most likely there will be other things that will be more important, or will need a complete different design when adding support for other concrete systems to Rally.","commit_id":"78d8a840c6219359397bd2703275fcfbe324c3a8"},{"author":{"_account_id":11748,"name":"Chris St. Pierre","email":"cstpierr@cisco.com","username":"stpierre"},"change_message_id":"8f0becb3602fd49f38b08bdd155cf2b3932a52cb","unresolved":false,"context_lines":[{"line_number":40,"context_line":"one that will be the same for all resources created by a task, and one"},{"line_number":41,"context_line":"that will be unique for all resources."},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"These will be configured by three settings in `rally.conf`::"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    resource_name_format \u003d rally_XXXXXXXX_XXXXXXXX"},{"line_number":46,"context_line":"    context_resource_name_format \u003d rally_ctx_XXXXXXXX_XXXXXXXX"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9a41bdd9_e71bc871","line":43,"in_reply_to":"9a41bdd9_c106b41c","updated":"2015-07-14 18:52:53.000000000","message":"These settings are sufficient to do both of the things you propose. The default settings already start with non-numeric characters; if only digits are allowed, you could do, e.g.:\n\n    resource_name_format \u003d 1XXX1XXX\n    context_resource_name_format \u003d 2XXX2XXX\n    resource_name_allowed_characters \u003d 0123456789\n\nThe downside to this approach is that you\u0027ll need to muck with rally.conf if you want to use the same Rally install to benchmark multiple systems with incompatible naming requirements, but that\u0027s an *extremely* marginal criticism. Eventually we might want to make these configurable per-deployment -- since these changes are for out-of-band cleanup, they explicitly need to be separate from tasks -- but I\u0027m with Carlos on that premature abstraction.","commit_id":"78d8a840c6219359397bd2703275fcfbe324c3a8"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"8f7f6ec6db1eace459766d6f41fb3ba76b835c71","unresolved":false,"context_lines":[{"line_number":94,"context_line":"* Overhaul `rally.common.utils.generate_random_name()` and"},{"line_number":95,"context_line":"  `rally.task.scenarios.base.Scenario._generate_random_name()`. Early"},{"line_number":96,"context_line":"  proof of concept that implements some of the points in this spec:"},{"line_number":97,"context_line":"  https://review.openstack.org/#/c/184888/"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"* Find and fix resources that are created without"},{"line_number":100,"context_line":"  generate_random_name()."}],"source_content_type":"text/x-rst","patch_set":2,"id":"9a41bdd9_0e0cce3f","line":97,"updated":"2015-07-14 16:45:35.000000000","message":"This link can merge a lot of patch sets with different code - I think it is better to explain all required changes in this spec explicitly, without referring to some patches.","commit_id":"78d8a840c6219359397bd2703275fcfbe324c3a8"},{"author":{"_account_id":11748,"name":"Chris St. Pierre","email":"cstpierr@cisco.com","username":"stpierre"},"change_message_id":"8f0becb3602fd49f38b08bdd155cf2b3932a52cb","unresolved":false,"context_lines":[{"line_number":94,"context_line":"* Overhaul `rally.common.utils.generate_random_name()` and"},{"line_number":95,"context_line":"  `rally.task.scenarios.base.Scenario._generate_random_name()`. Early"},{"line_number":96,"context_line":"  proof of concept that implements some of the points in this spec:"},{"line_number":97,"context_line":"  https://review.openstack.org/#/c/184888/"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"* Find and fix resources that are created without"},{"line_number":100,"context_line":"  generate_random_name()."}],"source_content_type":"text/x-rst","patch_set":2,"id":"9a41bdd9_676c98d0","line":97,"in_reply_to":"9a41bdd9_0e0cce3f","updated":"2015-07-14 18:52:53.000000000","message":"What is unclear? There really are just the two work items listed, and they touch lots of code points.","commit_id":"78d8a840c6219359397bd2703275fcfbe324c3a8"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"29e1c4ac8b6b53c53057a56a8e12468deffd151b","unresolved":false,"context_lines":[{"line_number":42,"context_line":""},{"line_number":43,"context_line":"These will be configured by three settings in `rally.conf`::"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    resource_name_format \u003d rally_XXXXXXXX_XXXXXXXX"},{"line_number":46,"context_line":"    context_resource_name_format \u003d rally_ctx_XXXXXXXX_XXXXXXXX"},{"line_number":47,"context_line":"    resource_name_allowed_characters \u003d"},{"line_number":48,"context_line":"        ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1a4dcd0f_18f20270","line":45,"updated":"2015-08-05 00:06:47.000000000","message":"Actually, as real usage showed this format has issues. E.g. usually people creates resources for Rally with name rally* in the same cloud as they benchmark. After that Rally cleanups its self.","commit_id":"2260fec860e19c5cc7b350087b0557d07e508ffe"},{"author":{"_account_id":11748,"name":"Chris St. Pierre","email":"cstpierr@cisco.com","username":"stpierre"},"change_message_id":"e9227ba71d898a98fd815ccbcc415c71cee97918","unresolved":false,"context_lines":[{"line_number":42,"context_line":""},{"line_number":43,"context_line":"These will be configured by three settings in `rally.conf`::"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    resource_name_format \u003d rally_XXXXXXXX_XXXXXXXX"},{"line_number":46,"context_line":"    context_resource_name_format \u003d rally_ctx_XXXXXXXX_XXXXXXXX"},{"line_number":47,"context_line":"    resource_name_allowed_characters \u003d"},{"line_number":48,"context_line":"        ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1a4dcd0f_ced03322","line":45,"in_reply_to":"1a4dcd0f_18f20270","updated":"2015-08-05 13:46:04.000000000","message":"Done","commit_id":"2260fec860e19c5cc7b350087b0557d07e508ffe"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"29e1c4ac8b6b53c53057a56a8e12468deffd151b","unresolved":false,"context_lines":[{"line_number":43,"context_line":"These will be configured by three settings in `rally.conf`::"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    resource_name_format \u003d rally_XXXXXXXX_XXXXXXXX"},{"line_number":46,"context_line":"    context_resource_name_format \u003d rally_ctx_XXXXXXXX_XXXXXXXX"},{"line_number":47,"context_line":"    resource_name_allowed_characters \u003d"},{"line_number":48,"context_line":"        ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789"},{"line_number":49,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"1a4dcd0f_7878e6c4","line":46,"updated":"2015-08-05 00:06:47.000000000","message":"I believe we should have something like: \n\n  \u003ctype\u003e\u003cseperator\u003erally\u003cseperator\u003e\u003ctask_uuid_hash\u003e\u003cseperator\u003e\u003crandom_part\u003e\n\nWhere: \n\n  type in [\"c\", \"s\"]\n  separator in [\",\", \":\", \";\", \"-\", \"_\"]\n  task_uuid_hash (generate hash from task uuid so it will be short)\n  randmo_part [depend on users]","commit_id":"2260fec860e19c5cc7b350087b0557d07e508ffe"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"29e1c4ac8b6b53c53057a56a8e12468deffd151b","unresolved":false,"context_lines":[{"line_number":45,"context_line":"    resource_name_format \u003d rally_XXXXXXXX_XXXXXXXX"},{"line_number":46,"context_line":"    context_resource_name_format \u003d rally_ctx_XXXXXXXX_XXXXXXXX"},{"line_number":47,"context_line":"    resource_name_allowed_characters \u003d"},{"line_number":48,"context_line":"        ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"`resource_name_format` is for resources created by Rally scenarios;"},{"line_number":51,"context_line":"`context_resource_name_format` is for resources created by"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1a4dcd0f_d35d5d7a","line":48,"updated":"2015-08-05 00:06:47.000000000","message":"I see already troubles with such approach. \n\nE.g. We have two groups of benchmarks for 2 different systems \nand they have incompatible name restrictions. \n\nIn such case we won\u0027t be able to provide default set of rules for all kinds of benchmarks","commit_id":"2260fec860e19c5cc7b350087b0557d07e508ffe"},{"author":{"_account_id":11748,"name":"Chris St. Pierre","email":"cstpierr@cisco.com","username":"stpierre"},"change_message_id":"e9227ba71d898a98fd815ccbcc415c71cee97918","unresolved":false,"context_lines":[{"line_number":45,"context_line":"    resource_name_format \u003d rally_XXXXXXXX_XXXXXXXX"},{"line_number":46,"context_line":"    context_resource_name_format \u003d rally_ctx_XXXXXXXX_XXXXXXXX"},{"line_number":47,"context_line":"    resource_name_allowed_characters \u003d"},{"line_number":48,"context_line":"        ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"`resource_name_format` is for resources created by Rally scenarios;"},{"line_number":51,"context_line":"`context_resource_name_format` is for resources created by"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1a4dcd0f_0eb29b06","line":48,"in_reply_to":"1a4dcd0f_d35d5d7a","updated":"2015-08-05 13:46:04.000000000","message":"I agree; this is the major shortcoming of this spec. But I don\u0027t know how to solve it. The naive answer is to allow configuring these in the task file, but that means that you need to have the task file in order to run cleanup, which is not good. I think the best solution might be to allow configuring this in the deployment, but I think that can be added in a subsequent spec (which I\u0027m happy to write and implement as well).","commit_id":"2260fec860e19c5cc7b350087b0557d07e508ffe"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"29e1c4ac8b6b53c53057a56a8e12468deffd151b","unresolved":false,"context_lines":[{"line_number":47,"context_line":"    resource_name_allowed_characters \u003d"},{"line_number":48,"context_line":"        ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"`resource_name_format` is for resources created by Rally scenarios;"},{"line_number":51,"context_line":"`context_resource_name_format` is for resources created by"},{"line_number":52,"context_line":"contexts. These have different name formats because they have"},{"line_number":53,"context_line":"different cleanup requirements. Both accept `mktemp(1)`-style"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1a4dcd0f_38fd7e3a","line":50,"updated":"2015-08-05 00:06:47.000000000","message":"why not \"scenario_name_format\"","commit_id":"2260fec860e19c5cc7b350087b0557d07e508ffe"},{"author":{"_account_id":11748,"name":"Chris St. Pierre","email":"cstpierr@cisco.com","username":"stpierre"},"change_message_id":"e9227ba71d898a98fd815ccbcc415c71cee97918","unresolved":false,"context_lines":[{"line_number":47,"context_line":"    resource_name_allowed_characters \u003d"},{"line_number":48,"context_line":"        ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"`resource_name_format` is for resources created by Rally scenarios;"},{"line_number":51,"context_line":"`context_resource_name_format` is for resources created by"},{"line_number":52,"context_line":"contexts. These have different name formats because they have"},{"line_number":53,"context_line":"different cleanup requirements. Both accept `mktemp(1)`-style"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1a4dcd0f_4b33b514","line":50,"in_reply_to":"1a4dcd0f_38fd7e3a","updated":"2015-08-05 13:46:04.000000000","message":"Done","commit_id":"2260fec860e19c5cc7b350087b0557d07e508ffe"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"29e1c4ac8b6b53c53057a56a8e12468deffd151b","unresolved":false,"context_lines":[{"line_number":57,"context_line":""},{"line_number":58,"context_line":"* Both format options must have two separate sets of at least three"},{"line_number":59,"context_line":"  consecutive \u0027X\u0027s. (That is, they must match:"},{"line_number":60,"context_line":"  `^.*(?\u003c!X)X{3,}(?!X).*(?\u003c!X)X{3,}(?!X)`. This marks a slight"},{"line_number":61,"context_line":"  departure from `mktemp(1)`, which requires a single set of three or"},{"line_number":62,"context_line":"  more \u0027X\u0027s at the end.)"},{"line_number":63,"context_line":"* The two format options must be different."}],"source_content_type":"text/x-rst","patch_set":3,"id":"1a4dcd0f_b39f7102","line":60,"updated":"2015-08-05 00:06:47.000000000","message":"Why we need to allow end users to configure this at all? \n\nJust imagine next situation:\n\n   1) Put your own rally.conf stuff\n   2) Run benchmark \n   3) In the middle of benchmarking you are losing VM with Rally \n   4) Getting new Rally instance \n   5) You don\u0027t remember what exactly you put to rally.conf and rally can\u0027t cleanup resources..","commit_id":"2260fec860e19c5cc7b350087b0557d07e508ffe"},{"author":{"_account_id":11748,"name":"Chris St. Pierre","email":"cstpierr@cisco.com","username":"stpierre"},"change_message_id":"e9227ba71d898a98fd815ccbcc415c71cee97918","unresolved":false,"context_lines":[{"line_number":57,"context_line":""},{"line_number":58,"context_line":"* Both format options must have two separate sets of at least three"},{"line_number":59,"context_line":"  consecutive \u0027X\u0027s. (That is, they must match:"},{"line_number":60,"context_line":"  `^.*(?\u003c!X)X{3,}(?!X).*(?\u003c!X)X{3,}(?!X)`. This marks a slight"},{"line_number":61,"context_line":"  departure from `mktemp(1)`, which requires a single set of three or"},{"line_number":62,"context_line":"  more \u0027X\u0027s at the end.)"},{"line_number":63,"context_line":"* The two format options must be different."}],"source_content_type":"text/x-rst","patch_set":3,"id":"1a4dcd0f_2e443719","line":60,"in_reply_to":"1a4dcd0f_b39f7102","updated":"2015-08-05 13:46:04.000000000","message":"Because we will never, ever, ever find a single format that works for all systems that might need to be benchmarked. Your proposal above is fairly flexible, but I can easily imagine a system that doesn\u0027t allow any of the separators you propose (RFC 952 hostnames are close -- they only allow \u0027-\u0027 of the five you suggest), or that doesn\u0027t allow starting with a letter, or that has significant length restrictions (remember eight character usernames?). All of these are handled by making it fully configurable:\n\n    scenario_name_format \u003d s.rally.XXXXXXXX.XXXXXXXX\n    scenario_name_format \u003d :s:rally:XXXXXXXX:XXXXXXXX\n    scenario_name_format \u003d XXXsrXXX\n\nIf we\u0027re going to claim that Rally is a generic benchmarking tool, this needs to be very flexible.","commit_id":"2260fec860e19c5cc7b350087b0557d07e508ffe"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"29e1c4ac8b6b53c53057a56a8e12468deffd151b","unresolved":false,"context_lines":[{"line_number":80,"context_line":"requirements for out-of-band cleanup. It also doesn\u0027t support the two"},{"line_number":81,"context_line":"other goals of this spec -- broader application support and multiple"},{"line_number":82,"context_line":"concurrent runs -- both of which would still require most of the work"},{"line_number":83,"context_line":"described herein."},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"Implementation"},{"line_number":86,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1a4dcd0f_73b1e98e","line":83,"updated":"2015-08-05 00:06:47.000000000","message":"and it will create huge overhead during benchmarking + it won\u0027t scale well in case of distributed load genreation","commit_id":"2260fec860e19c5cc7b350087b0557d07e508ffe"},{"author":{"_account_id":11748,"name":"Chris St. Pierre","email":"cstpierr@cisco.com","username":"stpierre"},"change_message_id":"e9227ba71d898a98fd815ccbcc415c71cee97918","unresolved":false,"context_lines":[{"line_number":80,"context_line":"requirements for out-of-band cleanup. It also doesn\u0027t support the two"},{"line_number":81,"context_line":"other goals of this spec -- broader application support and multiple"},{"line_number":82,"context_line":"concurrent runs -- both of which would still require most of the work"},{"line_number":83,"context_line":"described herein."},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"Implementation"},{"line_number":86,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1a4dcd0f_6e655fb3","line":83,"in_reply_to":"1a4dcd0f_73b1e98e","updated":"2015-08-05 13:46:04.000000000","message":"Done","commit_id":"2260fec860e19c5cc7b350087b0557d07e508ffe"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"1a2ca2b2a061fec9c517ace4a635c9c2095bfabb","unresolved":false,"context_lines":[{"line_number":43,"context_line":"These will be configured by three settings in `rally.conf`::"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    scenario_resource_name_format \u003d s_rally_XXXXXXXX_XXXXXXXX"},{"line_number":46,"context_line":"    context_resource_name_format \u003d c_rally_XXXXXXXX_XXXXXXXX"},{"line_number":47,"context_line":"    resource_name_allowed_characters \u003d"},{"line_number":48,"context_line":"        ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789"},{"line_number":49,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"1a4dcd0f_615afbf3","line":46,"updated":"2015-08-07 01:14:51.000000000","message":"This comment was not addressed:\n\n  I believe we should have something like:\n    \u003ctype\u003e\u003cseperator\u003erally\u003cseperator\u003e\u003ctask_uuid_hash\u003e\u003cseperator\u003e  \u003crandom_part\u003e\n  Where:\n    type in [\"c\", \"s\"]\n    separator in [\",\", \":\", \";\", \"-\", \"_\"]\n    task_uuid_hash (generate hash from task uuid so it will be short)\n    randmo_part [depend on users]","commit_id":"631eb6665900d5a5bdc748a2c2519dcec1fd2ea2"},{"author":{"_account_id":11748,"name":"Chris St. Pierre","email":"cstpierr@cisco.com","username":"stpierre"},"change_message_id":"d8bfcd420b95b9da7afcbb9dd2aea97ef0c4b9aa","unresolved":false,"context_lines":[{"line_number":43,"context_line":"These will be configured by three settings in `rally.conf`::"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    scenario_resource_name_format \u003d s_rally_XXXXXXXX_XXXXXXXX"},{"line_number":46,"context_line":"    context_resource_name_format \u003d c_rally_XXXXXXXX_XXXXXXXX"},{"line_number":47,"context_line":"    resource_name_allowed_characters \u003d"},{"line_number":48,"context_line":"        ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789"},{"line_number":49,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"1a4dcd0f_9f998ac6","line":46,"in_reply_to":"1a4dcd0f_615afbf3","updated":"2015-08-07 11:42:19.000000000","message":"That comment seemed a bit like the sum of your other comments, so it was addressed in various ways:\n\n* I changed the type (scenario, context) indicator as you suggested.\n* The format already contains a task UUID hash and random part.\n\nThe only difference is the separator, but that\u0027s completely configurable so there\u0027s nothing to stop someone from using any of the separators you suggest, or any other separator, either, and as I noted in the last patchset that flexibility is really important.","commit_id":"631eb6665900d5a5bdc748a2c2519dcec1fd2ea2"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"1553539986fa1367e82e63a156d0350d8d7858dd","unresolved":false,"context_lines":[{"line_number":43,"context_line":"These will be configured by three settings in `rally.conf`::"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    scenario_resource_name_format \u003d s_rally_XXXXXXXX_XXXXXXXX"},{"line_number":46,"context_line":"    context_resource_name_format \u003d c_rally_XXXXXXXX_XXXXXXXX"},{"line_number":47,"context_line":"    resource_name_allowed_characters \u003d"},{"line_number":48,"context_line":"        ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789"},{"line_number":49,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"da20952f_3c08a227","line":46,"in_reply_to":"1a4dcd0f_9f998ac6","updated":"2015-08-31 21:41:41.000000000","message":"I will still prefer to avoid specification of names in rally.conf it will block us to split rally and rally plugins code. Rally plugins should be able to specify name patters of their resources...","commit_id":"631eb6665900d5a5bdc748a2c2519dcec1fd2ea2"},{"author":{"_account_id":8576,"name":"Yair Fried","email":"yfried@redhat.com","username":"yfried"},"change_message_id":"58107162ecfccd4d492b78c22cf967ec787bd620","unresolved":false,"context_lines":[{"line_number":65,"context_line":"We will attempt to use the task ID, stripped of dashes, for the first"},{"line_number":66,"context_line":"random portion. If `resource_name_allowed_characters` does not allow"},{"line_number":67,"context_line":"all of the characters in the task ID (lowercase letters and digits),"},{"line_number":68,"context_line":"then we will randomly generate the first portion from"},{"line_number":69,"context_line":"`resource_name_allowed_characters`."},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"The second random portion will be generated randomly."}],"source_content_type":"text/x-rst","patch_set":4,"id":"da20952f_60568407","line":68,"updated":"2015-08-31 13:58:57.000000000","message":"As Boris mentioned - using hash here would be better","commit_id":"631eb6665900d5a5bdc748a2c2519dcec1fd2ea2"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"314fa77054d7ce7d6a66381fe4011411014fbe8c","unresolved":false,"context_lines":[{"line_number":68,"context_line":"portions. The default will be::"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"    RESOURCE_NAME_ALLOWED_CHARACTERS \u003d \\"},{"line_number":71,"context_line":"        \"ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789\""},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"We will attempt to use the task ID, stripped of dashes, for the first"},{"line_number":74,"context_line":"random portion. If ``RESOURCE_NAME_ALLOWED_CHARACTERS`` does not allow"}],"source_content_type":"text/x-rst","patch_set":5,"id":"da20952f_2e5cf617","line":71,"updated":"2015-09-06 11:09:08.000000000","message":"RESOURCE_NAME_ALLOWED_CHARACTERS \u003d (\n\t\t\t      \"ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789\")","commit_id":"babf25ccdcafc05cf8d1b8e9c362d556bbd35dfb"}]}
