)]}'
{"rally/cli/commands/deployment.py":[{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"e0e750b2390f97de1f181f1ba13e9b06eecdc681","unresolved":false,"context_lines":[{"line_number":268,"context_line":"                           \"export OS_PASSWORD\u003d%(password)s\\n\""},{"line_number":269,"context_line":"                           \"export OS_TENANT_NAME\u003d%(tenant_name)s\\n\""},{"line_number":270,"context_line":"                           \"export OS_USER_DOMAIN_NAME\u003d%(user_domain_name)s\\n\""},{"line_number":271,"context_line":"                           \"export OS_PROJECT_DOMAIN_NAME\u003d%(project_domain_name)s\\n\""},{"line_number":272,"context_line":"                           % endpoint)"},{"line_number":273,"context_line":"            if endpoint.get(\"region_name\"):"},{"line_number":274,"context_line":"                env_file.write(\"export OS_REGION_NAME\u003d%s\\n\" %"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a41bdd9_0476af3d","line":271,"updated":"2015-07-15 16:55:06.000000000","message":"As I understand this is needed only for v3 but without it would work for v2?","commit_id":"54b70786531942a046ed5c3f885f4be2f385d44f"},{"author":{"_account_id":14764,"name":"Yuki Nishiwaki","email":"uckey.1067@gmail.com","username":"ukinau"},"change_message_id":"884074fdf74e3584df9d81a651f2d8ff12850219","unresolved":false,"context_lines":[{"line_number":268,"context_line":"                           \"export OS_PASSWORD\u003d%(password)s\\n\""},{"line_number":269,"context_line":"                           \"export OS_TENANT_NAME\u003d%(tenant_name)s\\n\""},{"line_number":270,"context_line":"                           \"export OS_USER_DOMAIN_NAME\u003d%(user_domain_name)s\\n\""},{"line_number":271,"context_line":"                           \"export OS_PROJECT_DOMAIN_NAME\u003d%(project_domain_name)s\\n\""},{"line_number":272,"context_line":"                           % endpoint)"},{"line_number":273,"context_line":"            if endpoint.get(\"region_name\"):"},{"line_number":274,"context_line":"                env_file.write(\"export OS_REGION_NAME\u003d%s\\n\" %"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a41bdd9_6c7750a0","line":271,"in_reply_to":"9a41bdd9_0476af3d","updated":"2015-07-16 00:15:35.000000000","message":"You are right. when use v2 , we don\u0027t need domain name.\nBut if there is domain name variables when you use v2,  we can call v2 api properly ( in other words, don\u0027t interfare ).\nSo in order to be simple implement I did so because we don\u0027t need parse endpoint.\nBut If you think don\u0027t add variables that don\u0027t is required by v2 to openrc, I\u0027ll change it.","commit_id":"54b70786531942a046ed5c3f885f4be2f385d44f"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"e0e750b2390f97de1f181f1ba13e9b06eecdc681","unresolved":false,"context_lines":[{"line_number":270,"context_line":"                           \"export OS_USER_DOMAIN_NAME\u003d%(user_domain_name)s\\n\""},{"line_number":271,"context_line":"                           \"export OS_PROJECT_DOMAIN_NAME\u003d%(project_domain_name)s\\n\""},{"line_number":272,"context_line":"                           % endpoint)"},{"line_number":273,"context_line":"            if endpoint.get(\"region_name\"):"},{"line_number":274,"context_line":"                env_file.write(\"export OS_REGION_NAME\u003d%s\\n\" %"},{"line_number":275,"context_line":"                               endpoint[\"region_name\"])"},{"line_number":276,"context_line":"            if endpoint.get(\"endpoint\"):"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a41bdd9_44d597e5","line":273,"updated":"2015-07-15 16:55:06.000000000","message":"If so then we need to add to env_file added above lines as region name, for example.","commit_id":"54b70786531942a046ed5c3f885f4be2f385d44f"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"8069115604cb5517444e9ef29a82a5de25b75b97","unresolved":false,"context_lines":[{"line_number":278,"context_line":"                env_file.write(\"export OS_USER_DOMAIN_NAME\u003d%s\\n\""},{"line_number":279,"context_line":"                               \"export OS_PROJECT_DOMAIN_NAME\u003d%s\\n\" %"},{"line_number":280,"context_line":"                               (endpoint[\"user_domain_name\"],"},{"line_number":281,"context_line":"                                endpoint[\"project_domain_name\"]))"},{"line_number":282,"context_line":"        expanded_path \u003d os.path.expanduser(\"~/.rally/openrc\")"},{"line_number":283,"context_line":"        if os.path.exists(expanded_path):"},{"line_number":284,"context_line":"            os.remove(expanded_path)"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a41bdd9_7f782f2c","line":281,"updated":"2015-07-16 14:12:43.000000000","message":"This could be written simpler(reduce number of lines). \n  env_file.write(\"export OS_USER_DOMAIN_NAME\u003d%(user_domain_name)s\\n\"\n                         \"export OS_PROJECT_DOMAIN_NAME\u003d%(project_domain_name)s\\n\" % endpoint)","commit_id":"0cc420ad1c50fda2fbc8b23c91e3e5bea832450d"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"bffc61f81b444a3d5fcc87f2ff7f0137cc957f5a","unresolved":false,"context_lines":[{"line_number":274,"context_line":"            if endpoint.get(\"endpoint\"):"},{"line_number":275,"context_line":"                env_file.write(\"export OS_ENDPOINT\u003d%s\\n\" %"},{"line_number":276,"context_line":"                               endpoint[\"endpoint\"])"},{"line_number":277,"context_line":"            if utils.check_keystone_api_v3(endpoint[\"auth_url\"]):"},{"line_number":278,"context_line":"                env_file.write(\"export OS_USER_DOMAIN_NAME\u003d%s\\n\""},{"line_number":279,"context_line":"                               \"export OS_PROJECT_DOMAIN_NAME\u003d%s\\n\" %"},{"line_number":280,"context_line":"                               (endpoint[\"user_domain_name\"],"}],"source_content_type":"text/x-python","patch_set":6,"id":"9a41bdd9_bf479776","line":277,"updated":"2015-07-16 14:16:25.000000000","message":"I suggest not add function from utils that check version of keystone. I suggested Just to write if endpoint.get(\"user_domain_name\") and same from project domain and then we don\u0027t need additional function from utils.","commit_id":"169f1dc86bfcd20a1b1927bbe9e847b98099e329"},{"author":{"_account_id":14764,"name":"Yuki Nishiwaki","email":"uckey.1067@gmail.com","username":"ukinau"},"change_message_id":"b47a11442cd19c38013f206f5bf41cd300da39df","unresolved":false,"context_lines":[{"line_number":274,"context_line":"            if endpoint.get(\"endpoint\"):"},{"line_number":275,"context_line":"                env_file.write(\"export OS_ENDPOINT\u003d%s\\n\" %"},{"line_number":276,"context_line":"                               endpoint[\"endpoint\"])"},{"line_number":277,"context_line":"            if utils.check_keystone_api_v3(endpoint[\"auth_url\"]):"},{"line_number":278,"context_line":"                env_file.write(\"export OS_USER_DOMAIN_NAME\u003d%s\\n\""},{"line_number":279,"context_line":"                               \"export OS_PROJECT_DOMAIN_NAME\u003d%s\\n\" %"},{"line_number":280,"context_line":"                               (endpoint[\"user_domain_name\"],"}],"source_content_type":"text/x-python","patch_set":6,"id":"9a41bdd9_f9dbf71f","line":277,"in_reply_to":"9a41bdd9_2e4837cc","updated":"2015-07-16 15:34:26.000000000","message":"2) If it is so, when we use existing deploy engine, absolutely these statement will return true.\nBecause we set \"Default\" to hoge_domain_name as default value  in create_endpoint method \"rally/deployment/engines/existing.py\".\n\nSo we need to verify version and I think checking version is more natural than checking if hoge_domain_name is set or not.","commit_id":"169f1dc86bfcd20a1b1927bbe9e847b98099e329"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"774e0b5aaa445dc23d2b9a7aa1f6dc7d74cf0981","unresolved":false,"context_lines":[{"line_number":274,"context_line":"            if endpoint.get(\"endpoint\"):"},{"line_number":275,"context_line":"                env_file.write(\"export OS_ENDPOINT\u003d%s\\n\" %"},{"line_number":276,"context_line":"                               endpoint[\"endpoint\"])"},{"line_number":277,"context_line":"            if utils.check_keystone_api_v3(endpoint[\"auth_url\"]):"},{"line_number":278,"context_line":"                env_file.write(\"export OS_USER_DOMAIN_NAME\u003d%s\\n\""},{"line_number":279,"context_line":"                               \"export OS_PROJECT_DOMAIN_NAME\u003d%s\\n\" %"},{"line_number":280,"context_line":"                               (endpoint[\"user_domain_name\"],"}],"source_content_type":"text/x-python","patch_set":6,"id":"9a41bdd9_2e4837cc","line":277,"in_reply_to":"9a41bdd9_a8399ff4","updated":"2015-07-16 15:19:45.000000000","message":"1) Ok. Agree\n2) I don\u0027t think its needed. I think that its enough to write like this:\n    if endpoint.get(\"user_domain_name\"):\n        env_file.write(\"export OS_USER_DOMAIN_NAME\u003d%s\\n\" %\n\t\t\t         endpoint[\"user_domain_name\"])\n    if endpoint.get(\"project_domain_name\"):\n        env_file.write(\"export OS_PROJECT_DOMAIN_NAME\u003d%s\\n\" %\n                                 endpoint[\"project_domain_name\"]","commit_id":"169f1dc86bfcd20a1b1927bbe9e847b98099e329"},{"author":{"_account_id":14764,"name":"Yuki Nishiwaki","email":"uckey.1067@gmail.com","username":"ukinau"},"change_message_id":"d8179daa98a73321edc512abeedaa1e13b2c44a4","unresolved":false,"context_lines":[{"line_number":274,"context_line":"            if endpoint.get(\"endpoint\"):"},{"line_number":275,"context_line":"                env_file.write(\"export OS_ENDPOINT\u003d%s\\n\" %"},{"line_number":276,"context_line":"                               endpoint[\"endpoint\"])"},{"line_number":277,"context_line":"            if utils.check_keystone_api_v3(endpoint[\"auth_url\"]):"},{"line_number":278,"context_line":"                env_file.write(\"export OS_USER_DOMAIN_NAME\u003d%s\\n\""},{"line_number":279,"context_line":"                               \"export OS_PROJECT_DOMAIN_NAME\u003d%s\\n\" %"},{"line_number":280,"context_line":"                               (endpoint[\"user_domain_name\"],"}],"source_content_type":"text/x-python","patch_set":6,"id":"9a41bdd9_a8399ff4","line":277,"in_reply_to":"9a41bdd9_bf479776","updated":"2015-07-16 14:57:46.000000000","message":"Sorry I missed patchset5 comment.\nSo I reply here too.\n\n\u003eThis could be written simpler(reduce number of lines). \n\n\u003e  env_file.write(\"export OS_USER_DOMAIN_NAME\u003d%(user_domain_name)s\\n\"\n\n\u003e                         \"export OS_PROJECT_DOMAIN_NAME\u003d%(project_domain_name)s\\n\" % endpoint)\n\nThis cause pep8 error that alert too many character in one line.\n\n----\n\nI got same advise by Alexander. Therefore I canceled adding check-api-version method to utils.\n\nI\u0027ll replace utils.check_keystone_api_v3 with following. \n\n- if re.match(r\"^/v3/?$\", parse.urlparse(endpoint[\"auth_url\"]).path) is not None :\n\nHow about it ?","commit_id":"169f1dc86bfcd20a1b1927bbe9e847b98099e329"}],"tests/unit/cli/commands/test_deployment.py":[{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"9e7783fd6d9bcf4c13c228d9be97f3b83c15761a","unresolved":false,"context_lines":[{"line_number":270,"context_line":"            \"tenant_name\": \"fake_tenant_name\","},{"line_number":271,"context_line":"            \"endpoint\": \"fake_endpoint\","},{"line_number":272,"context_line":"            \"region_name\": None,"},{"line_number":273,"context_line":"            \"user_domain_name\": \"fake_domain_name\","},{"line_number":274,"context_line":"            \"project_domain_name\": \"fake_domain_name\"}"},{"line_number":275,"context_line":""},{"line_number":276,"context_line":"        with mock.patch(\"rally.cli.commands.deployment.open\", mock.mock_open(),"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a41bdd9_8855c0fa","line":273,"updated":"2015-07-16 13:33:38.000000000","message":"What if tested code has mixed up these values?\n\nUse different values for different resources, for example:\n\n ...\n \"user_domain_name\": \"fake_user_domain\",\n \"project_domain_name\": \"fake_project_domain\"","commit_id":"0cc420ad1c50fda2fbc8b23c91e3e5bea832450d"},{"author":{"_account_id":14764,"name":"Yuki Nishiwaki","email":"uckey.1067@gmail.com","username":"ukinau"},"change_message_id":"f1368c888d7add647434abca163aff92e7d598b0","unresolved":false,"context_lines":[{"line_number":270,"context_line":"            \"tenant_name\": \"fake_tenant_name\","},{"line_number":271,"context_line":"            \"endpoint\": \"fake_endpoint\","},{"line_number":272,"context_line":"            \"region_name\": None,"},{"line_number":273,"context_line":"            \"user_domain_name\": \"fake_domain_name\","},{"line_number":274,"context_line":"            \"project_domain_name\": \"fake_domain_name\"}"},{"line_number":275,"context_line":""},{"line_number":276,"context_line":"        with mock.patch(\"rally.cli.commands.deployment.open\", mock.mock_open(),"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a41bdd9_e88d6c31","line":273,"in_reply_to":"9a41bdd9_8855c0fa","updated":"2015-07-16 13:40:49.000000000","message":"Done","commit_id":"0cc420ad1c50fda2fbc8b23c91e3e5bea832450d"}]}
