)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6835,"name":"Kun Huang","email":"gareth@openstacker.org","username":"academicgareth"},"change_message_id":"3999abaf871d36c0cbb47b5690b36eb690446509","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Change endpoint initialization"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Remove endpoint authentication from init of"},{"line_number":10,"context_line":"network context and add it in setup and cleanup."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I971fb9b7eefa6cff30441fd6c9519f8311cddcf9"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"3a50d1a3_dc001069","line":10,"updated":"2015-07-27 07:43:50.000000000","message":"It will be much better to add your motivations here to why you have these changes.","commit_id":"05fea5ee4e0b2502861aa3fd9f678fb54d8ce7f5"}],"rally/plugins/openstack/context/network.py":[{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"82f809b2c9e52f45bae3b241b15f7104e435d1bc","unresolved":false,"context_lines":[{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    @utils.log_task_wrapper(LOG.info, _(\"Enter context: `network`\"))"},{"line_number":57,"context_line":"    def setup(self):"},{"line_number":58,"context_line":"        self.net_wrapper \u003d network_wrapper.wrap("},{"line_number":59,"context_line":"            osclients.Clients(self.ctx[\"admin\"][\"endpoint\"]),"},{"line_number":60,"context_line":"            self.config)"},{"line_number":61,"context_line":"        for user, tenant_id in (utils.iterate_per_tenants("}],"source_content_type":"text/x-python","patch_set":1,"id":"9a41bdd9_59bd79d6","line":58,"updated":"2015-07-15 18:12:35.000000000","message":"I prefer to use local variable for net_wrapper, since it used only in this function","commit_id":"31ecf53dee2a44cd8e8323b975218f14c45c4038"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"82f809b2c9e52f45bae3b241b15f7104e435d1bc","unresolved":false,"context_lines":[{"line_number":72,"context_line":""},{"line_number":73,"context_line":"    @utils.log_task_wrapper(LOG.info, _(\"Exit context: `network`\"))"},{"line_number":74,"context_line":"    def cleanup(self):"},{"line_number":75,"context_line":"        self.net_wrapper \u003d network_wrapper.wrap("},{"line_number":76,"context_line":"            osclients.Clients(self.ctx[\"admin\"][\"endpoint\"]),"},{"line_number":77,"context_line":"            self.config)"},{"line_number":78,"context_line":"        for tenant_id, tenant_ctx in six.iteritems(self.context[\"tenants\"]):"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a41bdd9_79c07d50","line":75,"updated":"2015-07-15 18:12:35.000000000","message":"same here","commit_id":"31ecf53dee2a44cd8e8323b975218f14c45c4038"}],"rally/plugins/openstack/context/network/networks.py":[{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"7cc1761cb84d638b0c55816edd753bd9daff393d","unresolved":false,"context_lines":[{"line_number":67,"context_line":"                self.context[\"tenants\"][tenant_id][\"networks\"].append(network)"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"    @utils.log_task_wrapper(LOG.info, _(\"Exit context: `network`\"))"},{"line_number":70,"context_line":"    def cleanup(self):"},{"line_number":71,"context_line":"        net_wrapper \u003d network_wrapper.wrap("},{"line_number":72,"context_line":"            osclients.Clients(self.context[\"admin\"][\"endpoint\"]),"},{"line_number":73,"context_line":"            self.config)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a50d1a3_31dc0818","line":70,"updated":"2015-07-24 04:58:27.000000000","message":"Could you add a NOTE here about reason to use new net_wrapper? Thanks.","commit_id":"2159131f25ef0530638b9de29c51c3bd859acaef"},{"author":{"_account_id":6835,"name":"Kun Huang","email":"gareth@openstacker.org","username":"academicgareth"},"change_message_id":"3999abaf871d36c0cbb47b5690b36eb690446509","unresolved":false,"context_lines":[{"line_number":52,"context_line":"    @utils.log_task_wrapper(LOG.info, _(\"Enter context: `network`\"))"},{"line_number":53,"context_line":"    def setup(self):"},{"line_number":54,"context_line":"        # NOTE(rkiran): having net_wrapper in setup and cleanup"},{"line_number":55,"context_line":"        #               simplifies reusability of these methods."},{"line_number":56,"context_line":"        net_wrapper \u003d network_wrapper.wrap("},{"line_number":57,"context_line":"            osclients.Clients(self.context[\"admin\"][\"endpoint\"]),"},{"line_number":58,"context_line":"            self.config)"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a50d1a3_7cd1bcfa","line":55,"updated":"2015-07-27 07:43:50.000000000","message":"this is not to simplify sth I think, pls try to explain it clearly (sth like to avoid token expiring in cleanup step)","commit_id":"05fea5ee4e0b2502861aa3fd9f678fb54d8ce7f5"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"256628c0d4e3ed65b109f46222b7a7ee8f9a24bc","unresolved":false,"context_lines":[{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    @utils.log_task_wrapper(LOG.info, _(\"Enter context: `network`\"))"},{"line_number":53,"context_line":"    def setup(self):"},{"line_number":54,"context_line":"        # NOTE(rkiran): initializing net_wrapper requests token everytime setup"},{"line_number":55,"context_line":"        #               and cleanup is called, this avoids token expiration."},{"line_number":56,"context_line":"        net_wrapper \u003d network_wrapper.wrap("},{"line_number":57,"context_line":"            osclients.Clients(self.context[\"admin\"][\"endpoint\"]),"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a50d1a3_27815fc3","line":54,"updated":"2015-07-29 12:02:25.000000000","message":"This explanation is not true (and we have discussed that in IRC). The actual reason is do not keep clients instance during almost all task runtime (context setup -\u003e another contexts setup -\u003e run all iterations -\u003e another context cleanup -\u003e this context cleanup) - if we keep this instance, then we can experience problems related to multithreading/multiprocessing, since some clients are not thread-safe, for example they can keep sockets opened.\n\nSo this comment should be changed or even simply removed","commit_id":"e647f84a123af46e3fdbdc17ce2bd81d7e26cb61"}],"tests/unit/plugins/openstack/context/network/test_network.py":[{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"7992e7c308bc5a042ad8bfbad07f9c1df5dfcdd4","unresolved":false,"context_lines":[{"line_number":16,"context_line":"import mock"},{"line_number":17,"context_line":"import netaddr"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from rally.plugins.openstack.context.network import networks as network_context"},{"line_number":20,"context_line":"from tests.unit import test"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"NET \u003d \"rally.plugins.openstack.wrappers.network.\""}],"source_content_type":"text/x-python","patch_set":2,"id":"3a50d1a3_0deb41e0","line":19,"updated":"2015-07-22 22:55:27.000000000","message":"here is 80 characters. pep8 failure","commit_id":"344fed449f7d238191becb6c5a2f37395606066e"}]}