)]}'
{"rally/common/utils.py":[{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"11ddbf14fc0ebc05e48734014afc908f1614388a","unresolved":false,"context_lines":[{"line_number":419,"context_line":"    return prefix + rand_part"},{"line_number":420,"context_line":""},{"line_number":421,"context_line":""},{"line_number":422,"context_line":"def check_keystone_api_v3(url):"},{"line_number":423,"context_line":"    path \u003d moves.urllib.parse.urlparse(url).path"},{"line_number":424,"context_line":"    if re.match(r\"^/v3/?$\", path) is None:"},{"line_number":425,"context_line":"        return False"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a41bdd9_62d098f8","line":422,"updated":"2015-07-16 14:25:48.000000000","message":"This function looks confusing:\n\n* the module is wrong, if this function is actually required, it must be placed to rally.osclients\n\n* where is something related to `keystone\u0027 in the function body? I see only simple regexp check for `/v3/\u0027 - name `check_url_has_v3\u0027 sounds better\n\nOverall, I do not see any reason why this this function is needed - you use it in next patch, where it can be replaced with simple regexp check.\n\nI suggest to not add this function at all","commit_id":"0f9b2e25784becf68f9fe3cf9834b92e82988af9"},{"author":{"_account_id":14764,"name":"Yuki Nishiwaki","email":"uckey.1067@gmail.com","username":"ukinau"},"change_message_id":"da99e6207b5f23abb20a2de76643f29f9927e0e0","unresolved":false,"context_lines":[{"line_number":419,"context_line":"    return prefix + rand_part"},{"line_number":420,"context_line":""},{"line_number":421,"context_line":""},{"line_number":422,"context_line":"def check_keystone_api_v3(url):"},{"line_number":423,"context_line":"    path \u003d moves.urllib.parse.urlparse(url).path"},{"line_number":424,"context_line":"    if re.match(r\"^/v3/?$\", path) is None:"},{"line_number":425,"context_line":"        return False"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a41bdd9_85ca866d","line":422,"in_reply_to":"9a41bdd9_62d098f8","updated":"2015-07-16 14:35:50.000000000","message":"I see. Thanks for your review.\nYou are right.\nActually I was at a loss about how do I check version of api.\nTherefore I wanted opinion.\nI\u0027ll do it in next patch.","commit_id":"0f9b2e25784becf68f9fe3cf9834b92e82988af9"}]}