)]}'
{"rally/deployment/serverprovider/providers/openstack.py":[{"author":{"_account_id":8491,"name":"Illia Khudoshyn","email":"ikhudoshyn@mirantis.com","username":"ikhudoshyn"},"change_message_id":"22cb9687d43819a65f72413f052d0c610d1b777a","unresolved":false,"context_lines":[{"line_number":47,"context_line":""},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"def _cloud_init_success(s):"},{"line_number":50,"context_line":"    status, x, x \u003d s.ssh.execute("},{"line_number":51,"context_line":"        \"test -r /run/cloud-init/result.json\")"},{"line_number":52,"context_line":"    if status !\u003d 0:"},{"line_number":53,"context_line":"        LOG.debug(\"/run/cloud-init/result.json not found\")"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa1b9901_9492bc56","line":50,"updated":"2015-08-17 12:36:50.000000000","message":"AFAIK using underscores rather then regular variable names (\u0027x\u0027 here) is the recommended way to denote unused data in cases like this.","commit_id":"6cceeeef8cd756b45b7b9a91023d70fd5dabe163"},{"author":{"_account_id":11279,"name":"Angus Lees","email":"gus@inodes.org","username":"gus"},"change_message_id":"e4631b4ca41f94091ac70bc38e2c89a3c4529bd5","unresolved":false,"context_lines":[{"line_number":47,"context_line":""},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"def _cloud_init_success(s):"},{"line_number":50,"context_line":"    status, x, x \u003d s.ssh.execute("},{"line_number":51,"context_line":"        \"test -r /run/cloud-init/result.json\")"},{"line_number":52,"context_line":"    if status !\u003d 0:"},{"line_number":53,"context_line":"        LOG.debug(\"/run/cloud-init/result.json not found\")"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa1b9901_7c5f7841","line":50,"in_reply_to":"fa1b9901_7c823196","updated":"2015-08-19 02:13:35.000000000","message":"Done","commit_id":"6cceeeef8cd756b45b7b9a91023d70fd5dabe163"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"c3454f6c4460ae4e96d0512e8d4291a8e10e2cad","unresolved":false,"context_lines":[{"line_number":47,"context_line":""},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"def _cloud_init_success(s):"},{"line_number":50,"context_line":"    status, x, x \u003d s.ssh.execute("},{"line_number":51,"context_line":"        \"test -r /run/cloud-init/result.json\")"},{"line_number":52,"context_line":"    if status !\u003d 0:"},{"line_number":53,"context_line":"        LOG.debug(\"/run/cloud-init/result.json not found\")"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa1b9901_cfddec71","line":50,"in_reply_to":"fa1b9901_9492bc56","updated":"2015-08-17 18:52:51.000000000","message":"Illia, this is not true for OpenStack related projects. Underscore is reserved for translation take a look at line 22","commit_id":"6cceeeef8cd756b45b7b9a91023d70fd5dabe163"},{"author":{"_account_id":8491,"name":"Illia Khudoshyn","email":"ikhudoshyn@mirantis.com","username":"ikhudoshyn"},"change_message_id":"d5470f752ec6ca905e82e09cebc7dac5a05f5444","unresolved":false,"context_lines":[{"line_number":47,"context_line":""},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"def _cloud_init_success(s):"},{"line_number":50,"context_line":"    status, x, x \u003d s.ssh.execute("},{"line_number":51,"context_line":"        \"test -r /run/cloud-init/result.json\")"},{"line_number":52,"context_line":"    if status !\u003d 0:"},{"line_number":53,"context_line":"        LOG.debug(\"/run/cloud-init/result.json not found\")"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa1b9901_d87efbe3","line":50,"in_reply_to":"fa1b9901_cfddec71","updated":"2015-08-18 09:17:51.000000000","message":"Got it. Just was a bit frustrated looking for later usage of \u0027x\u0027.","commit_id":"6cceeeef8cd756b45b7b9a91023d70fd5dabe163"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"1262b559d21e26c27f3b57399ec0247e2f8005bc","unresolved":false,"context_lines":[{"line_number":47,"context_line":""},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"def _cloud_init_success(s):"},{"line_number":50,"context_line":"    status, x, x \u003d s.ssh.execute("},{"line_number":51,"context_line":"        \"test -r /run/cloud-init/result.json\")"},{"line_number":52,"context_line":"    if status !\u003d 0:"},{"line_number":53,"context_line":"        LOG.debug(\"/run/cloud-init/result.json not found\")"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa1b9901_7c823196","line":50,"in_reply_to":"fa1b9901_d87efbe3","updated":"2015-08-18 15:11:16.000000000","message":"I think that we can run `cat /run/cloud-init/result.json\u0027 here - so zero status means we have json in stdout, and non-zero status means we do not have this file yet, and ignore error","commit_id":"6cceeeef8cd756b45b7b9a91023d70fd5dabe163"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"1262b559d21e26c27f3b57399ec0247e2f8005bc","unresolved":false,"context_lines":[{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    status, stdout, stderr \u003d s.ssh.execute("},{"line_number":57,"context_line":"        \"cat /run/cloud-init/result.json\")"},{"line_number":58,"context_line":"    if status !\u003d 0:"},{"line_number":59,"context_line":"        raise RuntimeError(\"Failed to read result.json on %s: %s\" %"},{"line_number":60,"context_line":"                           (s, stderr))"},{"line_number":61,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"fa1b9901_7c4a31c7","line":58,"updated":"2015-08-18 15:11:16.000000000","message":"`if status:\u0027  is enough","commit_id":"6cceeeef8cd756b45b7b9a91023d70fd5dabe163"},{"author":{"_account_id":11279,"name":"Angus Lees","email":"gus@inodes.org","username":"gus"},"change_message_id":"e4631b4ca41f94091ac70bc38e2c89a3c4529bd5","unresolved":false,"context_lines":[{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    status, stdout, stderr \u003d s.ssh.execute("},{"line_number":57,"context_line":"        \"cat /run/cloud-init/result.json\")"},{"line_number":58,"context_line":"    if status !\u003d 0:"},{"line_number":59,"context_line":"        raise RuntimeError(\"Failed to read result.json on %s: %s\" %"},{"line_number":60,"context_line":"                           (s, stderr))"},{"line_number":61,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"fa1b9901_9c5a8c4f","line":58,"in_reply_to":"fa1b9901_7c4a31c7","updated":"2015-08-19 02:13:35.000000000","message":"Done","commit_id":"6cceeeef8cd756b45b7b9a91023d70fd5dabe163"}]}
