)]}'
{"rally/plugins/openstack/scenarios/nova/utils.py":[{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"ea252200eef7632295f525d2d7e164df587b00d6","unresolved":false,"context_lines":[{"line_number":125,"context_line":"            nets \u003d [net[\"id\"] for net in"},{"line_number":126,"context_line":"                    self.context.get(\"tenant\", {}).get(\"networks\", [])]"},{"line_number":127,"context_line":"            if nets:"},{"line_number":128,"context_line":"                # NOTE(stpierre): Try to balance servers among"},{"line_number":129,"context_line":"                # networks. If we can\u0027t determine how many tenants"},{"line_number":130,"context_line":"                # were created (generally because we\u0027re operating with"},{"line_number":131,"context_line":"                # existing users), then this balancing may be"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a50d1a3_1922f101","line":128,"updated":"2015-07-27 15:20:46.000000000","message":"Lines 128-151 can be replaced with single statement (which actually makes the best balancing):\n\n net_idx \u003d self.context[\"iteration\"] % len(nets)","commit_id":"cc79232aa5db7eaf8581e7fd20b8c834648cd157"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"7470b8555424a6ff4275745e5d18a79b094ff908","unresolved":false,"context_lines":[{"line_number":130,"context_line":"                net_idx \u003d divmod("},{"line_number":131,"context_line":"                    (self.context[\"iteration\"]"},{"line_number":132,"context_line":"                     % self.context[\"config\"][\"users\"][\"tenants\"]),"},{"line_number":133,"context_line":"                    len(nets))[1]"},{"line_number":134,"context_line":"                kwargs[\"nics\"] \u003d [{\"net-id\": nets[net_idx]}]"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"        server \u003d self.clients(\"nova\").servers.create("}],"source_content_type":"text/x-python","patch_set":3,"id":"1a4dcd0f_1a7435fb","side":"PARENT","line":133,"updated":"2015-08-05 01:27:29.000000000","message":"Users exist always in both cases existing_users and users context. \n\nhttps://github.com/openstack/rally/blob/master/rally/plugins/openstack/context/keystone/existing_users.py#L62-L65","commit_id":"4acba44cd003f405779eaf7e00145d2cb032a54f"},{"author":{"_account_id":11748,"name":"Chris St. Pierre","email":"cstpierr@cisco.com","username":"stpierre"},"change_message_id":"58438246a45a43a5b091660981842e631d8f2edb","unresolved":false,"context_lines":[{"line_number":130,"context_line":"                net_idx \u003d divmod("},{"line_number":131,"context_line":"                    (self.context[\"iteration\"]"},{"line_number":132,"context_line":"                     % self.context[\"config\"][\"users\"][\"tenants\"]),"},{"line_number":133,"context_line":"                    len(nets))[1]"},{"line_number":134,"context_line":"                kwargs[\"nics\"] \u003d [{\"net-id\": nets[net_idx]}]"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"        server \u003d self.clients(\"nova\").servers.create("}],"source_content_type":"text/x-python","patch_set":3,"id":"1a4dcd0f_37480d87","side":"PARENT","line":133,"in_reply_to":"1a4dcd0f_1a7435fb","updated":"2015-08-05 13:17:06.000000000","message":"But the scenario doesn\u0027t get a list of all of the users; it just gets the user that it should run with. There\u0027s no consistent way to get the total number of users in the case of both the users and existing_users contexts. And Alex claims that this change actually results in better balancing, too.","commit_id":"4acba44cd003f405779eaf7e00145d2cb032a54f"}]}
