)]}'
{"rally/db/sqlalchemy/api.py":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"f6873d363f6e09eeef9694b0ad98c0fb7a9f4d52","unresolved":false,"context_lines":[{"line_number":37,"context_line":"    global _FACADE"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    if _FACADE is None:"},{"line_number":40,"context_line":"        _FACADE \u003d db_session.enginefacade.LegacyEngineFacade.from_config(CONF)"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    return _FACADE"},{"line_number":43,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"3a50d1a3_66979b90","line":40,"updated":"2015-07-28 14:57:09.000000000","message":"Commit message says:\n\n\"\"\"\n\nInstead of\noslo.db.sqlalchemy.enginefacade.LegacyEngineFacade use\noslo.db.sqlalchemy.EngineFacade\n\n\"\"\"\n\nSo, commit message and change contradict because you still use \"Legacy\" thing.","commit_id":"2a36720c3652c02afe4f475d03ea2a34716fab88"},{"author":{"_account_id":6835,"name":"Kun Huang","email":"gareth@openstacker.org","username":"academicgareth"},"change_message_id":"b5f196f41ee6c3c191ae866e7019321dbb880801","unresolved":false,"context_lines":[{"line_number":37,"context_line":"    global _FACADE"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    if _FACADE is None:"},{"line_number":40,"context_line":"        _FACADE \u003d db_session.enginefacade.LegacyEngineFacade.from_config(CONF)"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    return _FACADE"},{"line_number":43,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"3a50d1a3_beee2720","line":40,"in_reply_to":"3a50d1a3_58c825a8","updated":"2015-08-03 06:52:57.000000000","message":"it should be \"oslo.db.sqlalchemy.enginefacade\"\n\nhttps://github.com/openstack/oslo.db/blob/master/oslo_db/sqlalchemy/enginefacade.py#L844","commit_id":"2a36720c3652c02afe4f475d03ea2a34716fab88"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"a2bcd617942699b35f58ae8906a1b23bf0369aa7","unresolved":false,"context_lines":[{"line_number":37,"context_line":"    global _FACADE"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    if _FACADE is None:"},{"line_number":40,"context_line":"        _FACADE \u003d db_session.enginefacade.LegacyEngineFacade.from_config(CONF)"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    return _FACADE"},{"line_number":43,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"3a50d1a3_58c825a8","line":40,"in_reply_to":"3a50d1a3_66979b90","updated":"2015-07-28 23:11:43.000000000","message":"This seems like a terrible idea. \n\nWe shouldn\u0027t switch to legacy code...","commit_id":"2a36720c3652c02afe4f475d03ea2a34716fab88"}]}